Page MenuHomeFreeBSD

crypto/openssl: apply polish to new vendor import process
ClosedPublic

Authored by ngie on Sep 8 2025, 1:31 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 10, 3:33 PM
Unknown Object (File)
Fri, Oct 10, 9:18 AM
Unknown Object (File)
Fri, Oct 10, 9:18 AM
Unknown Object (File)
Fri, Oct 10, 9:18 AM
Unknown Object (File)
Fri, Oct 10, 2:59 AM
Unknown Object (File)
Sat, Oct 4, 1:28 AM
Unknown Object (File)
Fri, Oct 3, 10:58 AM
Unknown Object (File)
Thu, Sep 25, 3:59 PM
Subscribers

Details

Summary

This change does the following 2 things:

  • Makes the build more repeatable by isolating the environment. This prevents bmake from leaking variables into gmake and makes the overall process a bit more robust.
  • Add debug printouts to make the process more straightforward to the reader and whoever is executing doing the current vendor import.

MFC after: 1 month

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ngie requested review of this revision.Sep 8 2025, 1:31 AM
ngie edited the summary of this revision. (Show Details)
ngie added a subscriber: emaste.
crypto/openssl/BSDmakefile
29

SETENV seems a bit misleading, ENV is a bit too generic, perhaps CLEAN_ENV perhaps?

46

Using GMAKE rather than bare gmake would be better.
Or ${GMAKE:Ugmake} if you don't want GMAKE?= gmake somewhere

51

excursions like this should be in () to avoid confusing other steps in jobs mode.
Ie. in jobs mode all commands in a target are fed to a signle shell instance, so the find below will behave differently in jobs mode vs compat mode

crypto/openssl/BSDmakefile
29

I was trying to follow the naming convention established by ports, but I probably should have used SETENVI: https://cgit.freebsd.org/ports/tree/Mk/bsd.commands.mk#n85 .

51

Interesting. Will adjust!

ngie marked 3 inline comments as done.Sep 15 2025, 6:37 PM
This revision is now accepted and ready to land.Sep 15 2025, 10:09 PM