Define this helper variable in one place and make it available while
building the entire base system.
Obtained from: CheriBSD (mostly)
Details
Details
- Reviewers
mm sjg - Group Reviewers
cheri - Commits
- rG7980cf5d6f71: Centralize definition of ZFSTOP
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
In CheriBSD we have a second import of ZFS (with various CHERI patches applied) which is why we benefit from having a single definition of this variable, but I think the cleanup of using ZFSTOP more widely is nice regardless as it makes several long lines a bit shorter.
| share/mk/src.sys.mk | ||
|---|---|---|
| 51 | @sjg Is this the right place to put a definition for a variable that is shared across the entire src tree? | |
| share/mk/src.sys.mk | ||
|---|---|---|
| 51 | It is certainly not unreasonable. There are potentially many makefiles included before this, if you want to allow any of those to provide an alternative, you might want to use ?= here. Eg. in our trees at work (with site.*.mk) there are 29 makefiles read before src.sys.mk, even in upstream main, there are 17 makefiles read first. | |
| share/mk/src.sys.mk | ||
|---|---|---|
| 51 | Hmm, I guess it can't hurt to use ?= here, but I didn't really envision this being something you would override. OTOH, perhaps using a local.*.mk downstream in CheriBSD would be nicer than a local diff that modifies this one line. | |