Page MenuHomeFreeBSD

mm (Martin Matuska)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 19 2020, 12:16 AM (30 w, 1 d)

Recent Activity

Wed, Jun 16

mm committed R10:014f9aa8218a: zfs: unbreak stable/13 build on i386 after b0c251b0d (authored by mm).
zfs: unbreak stable/13 build on i386 after b0c251b0d
Wed, Jun 16, 1:59 AM
mm closed D30783: zfs: unbreak stable/13 clang build on i386 after b0c251b0d.
Wed, Jun 16, 1:59 AM · ZFS
mm updated the diff for D30783: zfs: unbreak stable/13 clang build on i386 after b0c251b0d.

atomic.S patch by mav

Wed, Jun 16, 1:55 AM · ZFS
mm added a comment to D30783: zfs: unbreak stable/13 clang build on i386 after b0c251b0d.

I am in for the assembler code patch. I will prepare an updated version.

Wed, Jun 16, 1:35 AM · ZFS
mm added a comment to D30783: zfs: unbreak stable/13 clang build on i386 after b0c251b0d.

I am definitely going to do that. But in the meantime we need a buildable stable/13 for i386. The solution I am proposing does (temporarily) place an additional file into cddl/lib/libzfs what is outside of sys/contrib/openzfs.

Wed, Jun 16, 1:27 AM · ZFS
mm added a comment to D30783: zfs: unbreak stable/13 clang build on i386 after b0c251b0d.

I assume Brian just forgot to merge that commit or intentionally didn't merge that commit and did not inspect your commit for changes in that direction. The i386 build should be broken for Linux as well.

Wed, Jun 16, 1:23 AM · ZFS
mm requested review of D30783: zfs: unbreak stable/13 clang build on i386 after b0c251b0d.
Wed, Jun 16, 12:50 AM · ZFS
mm committed R10:d940dcb757cd: zfs: unbreak stable/13 clang build on non-x86 archs after b0c251b0d (authored by mm).
zfs: unbreak stable/13 clang build on non-x86 archs after b0c251b0d
Wed, Jun 16, 12:46 AM

Sun, Jun 13

mm committed R10:b0c251b0dea8: zfs: merge openzfs/zfs@c3b60eded (zfs-2.1-release) into stable/13 (authored by mm).
zfs: merge openzfs/zfs@c3b60eded (zfs-2.1-release) into stable/13
Sun, Jun 13, 3:47 AM
mm committed R10:44877c8db05b: zfs: change zstream -> zstreamdump link into a symlink (authored by mm).
zfs: change zstream -> zstreamdump link into a symlink
Sun, Jun 13, 3:46 AM
mm committed R10:eee7786f7523: zfs: fix invalid entries in ObsoleteFiles.inc added in 3ff01b231 (authored by mm).
zfs: fix invalid entries in ObsoleteFiles.inc added in 3ff01b231
Sun, Jun 13, 3:18 AM
mm committed R10:3ff01b231dfa: zfs: merge openzfs/zfs@afa7b3484 (master) into main (authored by mm).
zfs: merge openzfs/zfs@afa7b3484 (master) into main
Sun, Jun 13, 2:45 AM

Sat, Jun 12

mm committed R11:7198f8de37dd: lang/luajit-openresty: Update 2.1-20201027 -> 2.1-20210510 (authored by mm).
lang/luajit-openresty: Update 2.1-20201027 -> 2.1-20210510
Sat, Jun 12, 1:05 AM

Thu, Jun 10

mm committed R10:47ddbfae278b: zfs: unbreak build with clang 12 (authored by mm).
zfs: unbreak build with clang 12
Thu, Jun 10, 11:37 PM

Tue, Jun 8

mm committed R10:f20893853e8e: zfs: unbreak build broken in 160388166 (authored by mm).
zfs: unbreak build broken in 160388166
Tue, Jun 8, 8:22 PM
mm committed R10:04c4bd7f7b52: zfs: merge openzfs/zfs@7d9f3ef0e (zfs-2.1-release) into stable/13 (authored by mm).
zfs: merge openzfs/zfs@7d9f3ef0e (zfs-2.1-release) into stable/13
Tue, Jun 8, 3:05 PM
mm committed R10:160388166736: zfs: merge openzfs/zfs@75b4cbf62 (master) into main (authored by mm).
zfs: merge openzfs/zfs@75b4cbf62 (master) into main
Tue, Jun 8, 2:54 PM
mm committed R10:84b8d2bc9ba8: zfs: merge openzfs/zfs@3522f57b6 (zfs-2.1-release) to stable/13 (authored by mm).
zfs: merge openzfs/zfs@3522f57b6 (zfs-2.1-release) to stable/13
Tue, Jun 8, 2:38 PM
mm committed R10:ed9215c8e05f: zfs: merge openzfs/zfs@3522f57b6 (master) to main (authored by mm).
zfs: merge openzfs/zfs@3522f57b6 (master) to main
Tue, Jun 8, 2:27 PM

May 5 2021

mm added a comment to D26311: gpioled_acpi: driver for GPIO controlled LEDs declared using ACPI _DSD.
In D26311#676085, @avg wrote:

@mm , do you have amdgpio driver? Has it attached?

May 5 2021, 7:31 AM
mm added a comment to D26311: gpioled_acpi: driver for GPIO controlled LEDs declared using ACPI _DSD.

I get currently the following reply on stable/13 with an APU2 bios 4.13.0.4:
gpioleds0: <ACPI GPIO LEDs> on acpi0
gpioleds0: GPIO controller device \134_SB_.PCI0.GPIO is not attached
gpioleds0: GPIO controller device \134_SB_.PCI0.GPIO is not attached
gpioleds0: GPIO controller device \134_SB_.PCI0.GPIO is not attached
gpioleds0: detached

May 5 2021, 6:35 AM

Apr 26 2021

mm committed R10:9f1dc86c46d6: zfs: restore copyright disclaimer change from 4b84b4cca (authored by mm).
zfs: restore copyright disclaimer change from 4b84b4cca
Apr 26 2021, 8:18 PM
mm committed R10:4b84b4cca472: zfs: fix non-functional mismerges from vendor/openzfs (authored by mm).
zfs: fix non-functional mismerges from vendor/openzfs
Apr 26 2021, 1:10 AM

Apr 22 2021

mm committed R10:049d49e40a9d: zfs: merge openzfs/zfs@3522f57b6 (master) (authored by mm).
zfs: merge openzfs/zfs@3522f57b6 (master)
Apr 22 2021, 3:04 PM

Apr 14 2021

mm committed R10:6db169e92081: zfs: merge openzfs/zfs@3522f57b6 (master) (authored by mm).
zfs: merge openzfs/zfs@3522f57b6 (master)
Apr 14 2021, 10:53 AM
mm committed R10:d76d37d9c3f3: Update vendor/openzfs to openzfs/zfs/master@3522f57b6 (authored by mm).
Update vendor/openzfs to openzfs/zfs/master@3522f57b6
Apr 14 2021, 6:21 AM

Apr 4 2021

mm committed R10:93d1c189bc36: zfs: merge OpenZFS master-891568c99 (authored by mm).
zfs: merge OpenZFS master-891568c99
Apr 4 2021, 1:20 PM
mm committed R10:cf2a72643460: zfs: merge OpenZFS master-9305ff2ed (authored by mm).
zfs: merge OpenZFS master-9305ff2ed
Apr 4 2021, 1:20 PM

Mar 21 2021

mm committed R10:f9693bef8dc8: zfs: merge OpenZFS master-891568c99 (authored by mm).
zfs: merge OpenZFS master-891568c99
Mar 21 2021, 1:26 AM
mm committed R10:48a1c304e82e: Update vendor/openzfs to master-891568c99 (authored by mm).
Update vendor/openzfs to master-891568c99
Mar 21 2021, 12:42 AM

Mar 14 2021

mm committed R10:9db44a8e5da9: zfs: merge OpenZFS master-9305ff2ed (authored by mm).
zfs: merge OpenZFS master-9305ff2ed
Mar 14 2021, 1:39 AM

Mar 13 2021

mm committed R10:9162a1ce3ae9: Update vendor/openzfs to master-9305ff2ed (authored by mm).
Update vendor/openzfs to master-9305ff2ed
Mar 13 2021, 5:33 PM

Mar 10 2021

mm added a comment to D29036: libarchive: Make test_read_append_filter_wrong_program pass again.

Thank you. We are testing Linux, FreeBSD, macOS (via GitHub Actions) and OmniOS (via Jenkins) on GitHub so that will tell how it behaves on other platforms.

Mar 10 2021, 10:38 AM
mm added a comment to D29036: libarchive: Make test_read_append_filter_wrong_program pass again.

If you don't know I am a core libarchive developer and release manager so getting the fix upstream is up to me.
I don't like modifying the framework this way, we should fix the individual test instead.

Mar 10 2021, 10:27 AM
mm committed R10:29805b312c77: zfs: update openzfs version reference to bedbc13da (authored by mm).
zfs: update openzfs version reference to bedbc13da
Mar 10 2021, 9:39 AM
mm committed R10:9629ecfeefb3: zfs: add missing seqc write begin/end around zfs_acl_chown_setattr (authored by mjg).
zfs: add missing seqc write begin/end around zfs_acl_chown_setattr
Mar 10 2021, 9:39 AM
mm committed R10:603f1c3da48c: openzfs: attach pam_zfs_key to build (authored by greg_unrelenting.technology).
openzfs: attach pam_zfs_key to build
Mar 10 2021, 9:39 AM
mm committed R10:f2d3322c4511: zfs: merge OpenZFS master-bedbc13da (authored by mm).
zfs: merge OpenZFS master-bedbc13da
Mar 10 2021, 9:39 AM
mm committed R10:16f5a4ea9109: Install links for zpool feature compat aliases (authored by freqlabs).
Install links for zpool feature compat aliases
Mar 10 2021, 9:39 AM
mm committed R10:ee36544bd811: zfs: add missing checks for unsupported features (authored by mm).
zfs: add missing checks for unsupported features
Mar 10 2021, 9:38 AM
mm committed R10:57b9b81894e8: zfs: merge OpenZFS master-9312e0fd1 (authored by mm).
zfs: merge OpenZFS master-9312e0fd1
Mar 10 2021, 9:38 AM
mm committed R10:e295b9d9f598: zfs: bump version and install new share files (authored by mm).
zfs: bump version and install new share files
Mar 10 2021, 9:38 AM
mm committed R10:e1f9a18f917d: zfs: merge OpenZFS master-bf156c966 (authored by mm).
zfs: merge OpenZFS master-bf156c966
Mar 10 2021, 9:38 AM
mm committed R10:9e8f831780f7: zfs: change file mode of all merged tests (authored by mm).
zfs: change file mode of all merged tests
Mar 10 2021, 9:38 AM
mm committed R10:21b12f3e451b: zfs: merge OpenZFS master-436ab35a5 (authored by mm).
zfs: merge OpenZFS master-436ab35a5
Mar 10 2021, 9:37 AM

Mar 6 2021

mm committed R10:eed4d02d7ff7: zfs: cancel TRIM or initialize on FAULTED non-writeable vdevs (authored by mm).
zfs: cancel TRIM or initialize on FAULTED non-writeable vdevs
Mar 6 2021, 8:26 PM
mm committed R10:d2faf2e6b2d4: zfs: fix assert in FreeBSD-specific dmu_read_pages (authored by mm).
zfs: fix assert in FreeBSD-specific dmu_read_pages
Mar 6 2021, 8:26 PM
mm committed R10:e33a2b2905a8: zfs: fix vdev_rebuild_thread deadlock (authored by mm).
zfs: fix vdev_rebuild_thread deadlock
Mar 6 2021, 8:26 PM
mm committed R10:2fa2d50ead44: zfs: fix overly broad locking in spa_vdev_config_exit() (authored by mm).
zfs: fix overly broad locking in spa_vdev_config_exit()
Mar 6 2021, 8:25 PM

Mar 5 2021

mm committed R10:6781b8a32e70: zfs: update openzfs version reference to bedbc13da (authored by mm).
zfs: update openzfs version reference to bedbc13da
Mar 5 2021, 2:57 PM

Mar 3 2021

mm added a comment to D29036: libarchive: Make test_read_append_filter_wrong_program pass again.

What about we develop a fix for this at upstream?

Mar 3 2021, 6:00 PM
mm committed R10:dc2743434f6c: zfs: cancel TRIM or initialize on FAULTED non-writeable vdevs (authored by mm).
zfs: cancel TRIM or initialize on FAULTED non-writeable vdevs
Mar 3 2021, 2:02 AM
mm committed R10:19049a2b2bd7: zfs: fix assert in FreeBSD-specific dmu_read_pages (authored by mm).
zfs: fix assert in FreeBSD-specific dmu_read_pages
Mar 3 2021, 2:02 AM
mm committed R10:c70690631443: zfs: fix vdev_rebuild_thread deadlock (authored by mm).
zfs: fix vdev_rebuild_thread deadlock
Mar 3 2021, 2:02 AM
mm committed R10:f08e17c8a251: zfs: fix overly broad locking in spa_vdev_config_exit() (authored by mm).
zfs: fix overly broad locking in spa_vdev_config_exit()
Mar 3 2021, 2:01 AM
mm committed R10:caed7b1c399d: zfs: merge OpenZFS master-bedbc13da (authored by mm).
zfs: merge OpenZFS master-bedbc13da
Mar 3 2021, 1:17 AM
mm committed R10:154ce66101db: Update vendor/openzfs to master-bedbc13da (authored by mm).
Update vendor/openzfs to master-bedbc13da
Mar 3 2021, 12:45 AM

Feb 28 2021

mm accepted D28018: openzfs: attach pam_zfs_key to build.
Feb 28 2021, 9:31 AM · ZFS

Feb 26 2021

mm committed R10:c170aa9f37e4: zfs: add missing checks for unsupported features (authored by mm).
zfs: add missing checks for unsupported features
Feb 26 2021, 11:07 PM
mm closed D28935: zfs: fix handling of unsupported features.
Feb 26 2021, 11:07 PM · ZFS
mm requested review of D28935: zfs: fix handling of unsupported features.
Feb 26 2021, 10:59 AM · ZFS

Feb 25 2021

mm accepted D28925: Install links for zpool feature compat aliases.
Feb 25 2021, 7:03 PM
mm committed R10:3d66df702668: zfs: restore FreeBSD resource usage accounting (authored by mm).
zfs: restore FreeBSD resource usage accounting
Feb 25 2021, 4:27 PM
mm committed R10:442719c0c6de: zfs: disable use of hardware crypto offload drivers (authored by mm).
zfs: disable use of hardware crypto offload drivers
Feb 25 2021, 4:21 PM
mm committed R10:ee0b7e05e72c: zfs: fix panic if scrubbing after removing a slog device (authored by mm).
zfs: fix panic if scrubbing after removing a slog device
Feb 25 2021, 4:20 PM

Feb 24 2021

mm added a comment to D28892: unzip: sync with NetBSD upstream to add passphrase support.
In D28892#647126, @nyan wrote:
In D28892#646718, @ak wrote:

Also, I just noticed that in half of return statements we don't use parentheses, which is violation of style(7).

Yes, but it's a difference of style between FreeBSD and NetBSD.
So I don't change it.

Feb 24 2021, 11:46 AM

Feb 22 2021

mm committed R10:21269625733f: zfs: restore FreeBSD resource usage accounting (authored by mm).
zfs: restore FreeBSD resource usage accounting
Feb 22 2021, 9:21 PM
mm committed R10:940415f20a78: zfs: disable use of hardware crypto offload drivers (authored by mm).
zfs: disable use of hardware crypto offload drivers
Feb 22 2021, 5:44 PM
mm committed R10:64649f028542: zfs: fix panic if scrubbing after removing a slog device (authored by mm).
zfs: fix panic if scrubbing after removing a slog device
Feb 22 2021, 5:28 PM
mm committed R10:ba27dd8be821: zfs: merge OpenZFS master-9312e0fd1 (authored by mm).
zfs: merge OpenZFS master-9312e0fd1
Feb 22 2021, 12:02 PM

Feb 21 2021

mm committed R10:0626917d0786: Update vendor/openzfs to master-9312e0fd1 (authored by mm).
Update vendor/openzfs to master-9312e0fd1
Feb 21 2021, 8:38 PM

Feb 18 2021

mm added a comment to D28768: zfs: Remove unused abd_alloc_scatter_offset_chunkcnt.

I have merged lastest OpenZFS to main including the new "compatibility" property, you can close this now. Thanks for getting the change upstream!

Feb 18 2021, 2:59 PM
mm committed R10:10f57cb98fd6: zfs: bump version and install new share files (authored by mm).
zfs: bump version and install new share files
Feb 18 2021, 2:22 PM
mm committed R10:ee36e25a86cb: zfs: merge OpenZFS master-bf156c966 (authored by mm).
zfs: merge OpenZFS master-bf156c966
Feb 18 2021, 2:21 PM
mm requested changes to D28768: zfs: Remove unused abd_alloc_scatter_offset_chunkcnt.

I have updated the vendor branch to bf156c966, so technically we can merge from it. The idea is that we keep as low diff to upstream as possible. Have you already done merging from a vendor branch?

Feb 18 2021, 9:31 AM
mm committed R10:62ceb3c592a5: Update OpenZFS to master-bf156c966 (authored by mm).
Update OpenZFS to master-bf156c966
Feb 18 2021, 9:27 AM
mm committed R10:0be7053c91b9: zfs: Avoid updating the L2ARC device header unnecessarily (authored by mm).
zfs: Avoid updating the L2ARC device header unnecessarily
Feb 18 2021, 9:05 AM
mm committed R10:223debfb954c: zfs: fix RAIDZ2/3 not healing parity with 2+ bad disks (authored by mm).
zfs: fix RAIDZ2/3 not healing parity with 2+ bad disks
Feb 18 2021, 9:02 AM
mm committed R10:edb9049c3a78: zfs: Avoid updating the L2ARC device header unnecessarily (authored by mm).
zfs: Avoid updating the L2ARC device header unnecessarily
Feb 18 2021, 1:30 AM
mm committed R10:6f21b7996a95: zfs: fix RAIDZ2/3 not healing parity with 2+ bad disks (authored by mm).
zfs: fix RAIDZ2/3 not healing parity with 2+ bad disks
Feb 18 2021, 1:30 AM
mm accepted D28760: OpenZFS: #if 0 unused abd_alloc_scatter_offset_chunkcnt()..

Yes, looks like Matthew Ahrens has inlined this code into abd_get_offset_scatter()
Thank you @rlibby for submitting the upstream PR.

Feb 18 2021, 12:19 AM

Feb 16 2021

mm committed R10:afcb3c4cb49f: zfs: change file mode of all merged tests (authored by mm).
zfs: change file mode of all merged tests
Feb 16 2021, 11:25 AM
mm closed D28677: Merge OpenZFS 436ab35a5.
Feb 16 2021, 10:31 AM
mm committed R10:184c1b943937: zfs: merge OpenZFS master-436ab35a5 (authored by mm).
zfs: merge OpenZFS master-436ab35a5
Feb 16 2021, 2:00 AM
mm updated the diff for D28677: Merge OpenZFS 436ab35a5.

Rebase and update.

Feb 16 2021, 1:39 AM
mm retitled D28677: Merge OpenZFS 436ab35a5 from Merge OpenZFS gc1c31a835 to Merge OpenZFS 436ab35a5.
Feb 16 2021, 1:05 AM

Feb 15 2021

mm committed R10:83dd4a9252fd: Update OpenZFS to master-436ab35a5 (authored by mm).
Update OpenZFS to master-436ab35a5
Feb 15 2021, 11:35 PM
mm updated the diff for D28677: Merge OpenZFS 436ab35a5.

Rebased to eac22dd48079d5cccecb07f4e60b44bb692167f8

Feb 15 2021, 5:05 PM
mm added a comment to D28677: Merge OpenZFS 436ab35a5.

To be true guys, what is much more interesting than this diff is the diff between vendor/openzfs and sys/contrib/openzfs - I guess we want to keep it as small as possible (long-term). And currently there is already some difference.
So if you have no objections I might throw this in but I am not really into having this in 13.0-RELEASE, 13-stable after a reasonable amount of time (at least 2 weeks) would be o.k. for me.

Feb 15 2021, 4:45 PM
mm added a comment to D28677: Merge OpenZFS 436ab35a5.

The zfs test suite was not very happy with this in my bhyve, I guess we postpone this or someone else could continue with the merge. I have cherry-picked two important commits for 13.0-RELEASE.

Feb 15 2021, 10:39 AM
mm committed R10:5dce03847fdc: zfs: Avoid updating the L2ARC device header unnecessarily (authored by mm).
zfs: Avoid updating the L2ARC device header unnecessarily
Feb 15 2021, 10:00 AM
mm closed D28682: zfs: Avoid updating the L2ARC device header unnecessarily.
Feb 15 2021, 10:00 AM
mm closed D28681: zfs: fix RAIDZ2/3 not healing parity with 2+ bad disks.
Feb 15 2021, 9:55 AM
mm committed R10:f15e18a642cb: zfs: fix RAIDZ2/3 not healing parity with 2+ bad disks (authored by mm).
zfs: fix RAIDZ2/3 not healing parity with 2+ bad disks
Feb 15 2021, 9:55 AM
mm requested review of D28682: zfs: Avoid updating the L2ARC device header unnecessarily.
Feb 15 2021, 8:15 AM
mm requested review of D28681: zfs: fix RAIDZ2/3 not healing parity with 2+ bad disks.
Feb 15 2021, 8:02 AM
mm added a comment to D28677: Merge OpenZFS 436ab35a5.

@mjg I don't think much has changed under the hood because:

Feb 15 2021, 7:33 AM
mm updated subscribers of D28677: Merge OpenZFS 436ab35a5.
Feb 15 2021, 2:51 AM
mm added a comment to D28677: Merge OpenZFS 436ab35a5.

Github version: https://github.com/mmatuska/freebsd-src/commits/openzfs_gc1c31a835
@mjg please review the modification of zfs_freebsd_readlink() in sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vnops_os.c

Feb 15 2021, 2:47 AM
mm requested review of D28677: Merge OpenZFS 436ab35a5.
Feb 15 2021, 2:43 AM