Page MenuHomeFreeBSD

rmacklem (Rick Macklem)
User

Projects

User Details

User Since
Jan 13 2015, 10:58 PM (382 w, 5 d)

Recent Activity

Yesterday

rmacklem committed R10:a1735a7698a6: nfsd: Add a sanity check to SecinfoNoname for file type (authored by rmacklem).
nfsd: Add a sanity check to SecinfoNoname for file type
Sun, May 15, 7:19 PM
rmacklem committed R10:0b4f2ab0e913: krpc: Fix NFS-over-TLS for KTLS1.3 (authored by rmacklem).
krpc: Fix NFS-over-TLS for KTLS1.3
Sun, May 15, 6:54 PM

Sat, May 14

rmacklem committed R10:373511338d95: uipc_socket.c: Modify MSG_TLSAPPDATA to only do Alert Records (authored by rmacklem).
uipc_socket.c: Modify MSG_TLSAPPDATA to only do Alert Records
Sat, May 14, 7:59 PM
rmacklem closed D35170: Make MSG_TLSAPPDATA only apply to Alert records.
Sat, May 14, 7:58 PM

Wed, May 11

rmacklem requested review of D35170: Make MSG_TLSAPPDATA only apply to Alert records.
Wed, May 11, 1:33 AM

Sat, May 7

rmacklem updated the diff for D35136: update the rpc.tlsservd man page for the -C option.

Use the .So, .Sc macros for single quotes around :

Sat, May 7, 1:03 AM

Fri, May 6

rmacklem added inline comments to D35136: update the rpc.tlsservd man page for the -C option.
Fri, May 6, 11:35 PM
rmacklem updated the diff for D35136: update the rpc.tlsservd man page for the -C option.

Update the description to use SSL_CTX_set_ciphersuites().
I now note that "openssl ciphers -s -tls1_3" will list the
ciphers that work.

Fri, May 6, 11:32 PM
rmacklem added a comment to D35136: update the rpc.tlsservd man page for the -C option.

Since I should be able to test KTLS1.3 in a couple of weeks,
I think this man page update should be delayed until KTLS1.3
is working and "-C" is converted to SSL_CTX_set_ciphersuites().

Fri, May 6, 11:06 PM
rmacklem committed R10:d71c9f14682f: rpc.tlsservd: Add logging of TLS version and cipher used (authored by rmacklem).
rpc.tlsservd: Add logging of TLS version and cipher used
Fri, May 6, 9:05 PM
rmacklem added inline comments to D35136: update the rpc.tlsservd man page for the -C option.
Fri, May 6, 8:50 PM
rmacklem updated the diff for D35136: update the rpc.tlsservd man page for the -C option.

Reference openssl-ciphers for the preferred-ciphers list
and comment on what is likely to work as suggested by
Pau Amma.

Fri, May 6, 8:48 PM

Thu, May 5

rmacklem committed R10:15881823b9da: rpc.tlsclntd, rpc.tlsservd: Fix getopt_long argument (authored by rmacklem).
rpc.tlsclntd, rpc.tlsservd: Fix getopt_long argument
Thu, May 5, 11:24 PM
rmacklem requested review of D35136: update the rpc.tlsservd man page for the -C option.
Thu, May 5, 11:03 PM
rmacklem committed R10:712aac1389e8: rpc.tlsservd: Add a -C command line option for preferred_ciphers (authored by rmacklem).
rpc.tlsservd: Add a -C command line option for preferred_ciphers
Thu, May 5, 10:56 PM

Wed, May 4

rmacklem committed R10:ef4edb70c909: nfsd: Add a sanity check for Owner/OwnerGroup string length (authored by rmacklem).
nfsd: Add a sanity check for Owner/OwnerGroup string length
Wed, May 4, 9:00 PM
rmacklem committed R10:f32bf50d43be: nfsd: Fix handling of Open/Create for the pNFS server (authored by rmacklem).
nfsd: Fix handling of Open/Create for the pNFS server
Wed, May 4, 8:54 PM

Tue, May 3

rmacklem committed R10:70910e4b55ca: nfscl: Acquire a refcount on "cred" for mirrored pNFS RPCs (authored by rmacklem).
nfscl: Acquire a refcount on "cred" for mirrored pNFS RPCs
Tue, May 3, 2:25 PM
rmacklem resigned from D35098: nfs: skip bootpc when vfs.root.mountfrom is other than nfs.

It really needs someone familiar with bootstrapping to review this.
(Except for being the nfs case, it really has nothing to do with nfs.)

Tue, May 3, 3:43 AM · PowerPC

Mon, May 2

rmacklem committed R10:271f6d52a606: nfsd: Fix session slot freeing for NFSv4.1/4.2 (authored by rmacklem).
nfsd: Fix session slot freeing for NFSv4.1/4.2
Mon, May 2, 7:48 PM

Sun, May 1

rmacklem committed R10:47d75c29f551: nfsd: Add a sanity check to SecinfoNoname for file type (authored by rmacklem).
nfsd: Add a sanity check to SecinfoNoname for file type
Sun, May 1, 8:43 PM

Sat, Apr 30

rmacklem committed R10:5218d82c81f9: nfscl: Add support for a NFSv4 AppendWrite RPC (authored by rmacklem).
nfscl: Add support for a NFSv4 AppendWrite RPC
Sat, Apr 30, 8:54 PM
rmacklem added a comment to D35098: nfs: skip bootpc when vfs.root.mountfrom is other than nfs.

Beyond changing strstr() to a check for "nfs:" at the beginning of the
string, as suggested by sjg@, I don't see a problem with this.

Sat, Apr 30, 3:11 PM · PowerPC

Wed, Apr 27

rmacklem committed R10:350668eb09a2: rpc.tlsservd: Delete set but unused variable (authored by rmacklem).
rpc.tlsservd: Delete set but unused variable
Wed, Apr 27, 2:31 AM

Sat, Apr 23

rmacklem committed R10:92ecb030d254: mountd: Delay starting mountd until after mountlate (authored by rmacklem).
mountd: Delay starting mountd until after mountlate
Sat, Apr 23, 10:26 PM

Apr 16 2022

rmacklem committed R10:32c3e0f04921: nfscl: Clean up the code by removing unused arguments (authored by rmacklem).
nfscl: Clean up the code by removing unused arguments
Apr 16 2022, 1:56 AM

Apr 14 2022

rmacklem committed R10:068fc057458f: nfscl: Clean up the code by removing unused arguments (authored by rmacklem).
nfscl: Clean up the code by removing unused arguments
Apr 14 2022, 11:20 PM

Apr 13 2022

rmacklem committed R10:6cabeb169ef4: nfsd: Do not exempt NFSv3 Fsinfo from the TLS check (authored by rmacklem).
nfsd: Do not exempt NFSv3 Fsinfo from the TLS check
Apr 13 2022, 2:59 PM
rmacklem committed R10:4ad3423bc285: nfscl: Clean up the code by removing unused arguments (authored by rmacklem).
nfscl: Clean up the code by removing unused arguments
Apr 13 2022, 2:49 PM

Apr 10 2022

rmacklem committed R10:5580e5bd7160: nfscl: Clean up the code by removing unused arguments (authored by rmacklem).
nfscl: Clean up the code by removing unused arguments
Apr 10 2022, 9:09 PM
rmacklem committed R10:38c3cf6aedec: nfscl: Clean up the code by removing unused arguments (authored by rmacklem).
nfscl: Clean up the code by removing unused arguments
Apr 10 2022, 1:55 AM

Apr 9 2022

rmacklem committed R10:c45d934f6b7a: nfscl: Ansify a function header (authored by rmacklem).
nfscl: Ansify a function header
Apr 9 2022, 10:15 PM

Apr 8 2022

rmacklem committed R10:21de450aa1a7: nfscl: Add support for a NFSv4 AppendWrite RPC (authored by rmacklem).
nfscl: Add support for a NFSv4 AppendWrite RPC
Apr 8 2022, 9:01 PM

Apr 5 2022

rmacklem committed R10:330aa8acdec7: nfscl: Add support for a NFSv4 AppendWrite RPC (authored by rmacklem).
nfscl: Add support for a NFSv4 AppendWrite RPC
Apr 5 2022, 3:15 PM

Apr 4 2022

rmacklem accepted D34756: Add KERN_LOCKF.

Looks fine to me now.

Apr 4 2022, 11:10 PM
rmacklem added inline comments to D34756: Add KERN_LOCKF.
Apr 4 2022, 2:27 PM

Apr 3 2022

rmacklem added inline comments to D34756: Add KERN_LOCKF.
Apr 3 2022, 10:33 PM
rmacklem added a comment to D34756: Add KERN_LOCKF.

I'll admit I didn't look at the code in detail, but it looks ok to me.

Apr 3 2022, 7:09 PM

Apr 1 2022

rmacklem accepted D34567: nfs: do not panic on bootpc_init when no interfaces are found.

Looks ok to me, although I'll admit I never
use diskless NFS root file systems nor bootp.

Apr 1 2022, 9:20 PM

Mar 28 2022

rmacklem committed R10:c1970a7ebab5: nfscl: Fix IO_APPEND writes from kernel space (authored by rmacklem).
nfscl: Fix IO_APPEND writes from kernel space
Mar 28 2022, 10:14 PM

Mar 26 2022

rmacklem added a comment to D34567: nfs: do not panic on bootpc_init when no interfaces are found.

I don't see a problem with doing this, but since I am
not familiar with the various situations used by bootp
for mounting a root fs, I can't say if this change will
cause problems.

Mar 26 2022, 2:09 PM

Mar 17 2022

rmacklem committed R10:f37dc50d9f08: nfscl: Do not do a Lookup+Open for pNFS mounts (authored by rmacklem).
nfscl: Do not do a Lookup+Open for pNFS mounts
Mar 17 2022, 2:49 PM

Mar 13 2022

rmacklem committed R10:57014f21e754: nfscl: Fix NFSv4.1/4.2 Lookup+Open RPC (authored by rmacklem).
nfscl: Fix NFSv4.1/4.2 Lookup+Open RPC
Mar 13 2022, 8:17 PM

Mar 10 2022

rmacklem committed R10:3fc3fe90915f: nfsd: Do not exempt NFSv3 Fsinfo from the TLS check (authored by rmacklem).
nfsd: Do not exempt NFSv3 Fsinfo from the TLS check
Mar 10 2022, 12:55 AM
rmacklem added a comment to D34470: nfs: replace SAVESTART with SAVENAME.

It crashes almost instantly for NFSv4.
Basically, it does a vrele(ni_startdir);

Mar 10 2022, 12:27 AM

Mar 6 2022

rmacklem committed R11:0de291a6f5af: nfs-over-tls: Update to version 1.2 (authored by rmacklem).
nfs-over-tls: Update to version 1.2
Mar 6 2022, 3:05 PM

Mar 4 2022

rmacklem committed R10:22d6238a0473: nfscl: Fix a use after free in nfscl_cleanupkext() (authored by rmacklem).
nfscl: Fix a use after free in nfscl_cleanupkext()
Mar 4 2022, 4:16 PM
rmacklem committed R10:69b2217cde24: nfscl: Fix a use after free in nfscl_cleanupkext() (authored by rmacklem).
nfscl: Fix a use after free in nfscl_cleanupkext()
Mar 4 2022, 4:11 PM

Feb 25 2022

rmacklem committed R10:1cedb4ea1a79: nfscl: Fix a use after free in nfscl_cleanupkext() (authored by rmacklem).
nfscl: Fix a use after free in nfscl_cleanupkext()
Feb 25 2022, 3:28 PM
rmacklem added inline comments to D34334: fix a use after free in nfscl_cleanupkext().
Feb 25 2022, 2:51 PM

Feb 24 2022

rmacklem updated the diff for D34334: fix a use after free in nfscl_cleanupkext().

cy@ reported via email that he had a problem when
running with the previous patch. He observed the mount
"come to a grinding halt" when under heavy load.
(He was doing "make -j16" builds.)
The CPU was busy, which would have indicated that
the renew thread was very busy.
The "goto tryagain(2)" was only done when an entry
was deleted, so it wasn't exactly an infinite loop, but
it appears that the overhead of repeating the loops
from the beginning was excessive when there were many
open owners.

Feb 24 2022, 10:19 PM
rmacklem added a reverting change for R10:dd08b84e35b6: nfscl: Fix a use after free in nfscl_cleanupkext(): R10:06148d225170: Revert "nfscl: Fix a use after free in nfscl_cleanupkext()".
Feb 24 2022, 3:05 PM
rmacklem committed R10:06148d225170: Revert "nfscl: Fix a use after free in nfscl_cleanupkext()" (authored by rmacklem).
Revert "nfscl: Fix a use after free in nfscl_cleanupkext()"
Feb 24 2022, 3:05 PM
rmacklem added a reverting change for D34334: fix a use after free in nfscl_cleanupkext(): R10:06148d225170: Revert "nfscl: Fix a use after free in nfscl_cleanupkext()".
Feb 24 2022, 3:04 PM

Feb 22 2022

rmacklem committed R10:dd08b84e35b6: nfscl: Fix a use after free in nfscl_cleanupkext() (authored by rmacklem).
nfscl: Fix a use after free in nfscl_cleanupkext()
Feb 22 2022, 10:25 PM
rmacklem closed D34334: fix a use after free in nfscl_cleanupkext().
Feb 22 2022, 10:24 PM
rmacklem updated the diff for D34334: fix a use after free in nfscl_cleanupkext().

Instead of returning a boolean, nfscl_cleanup_common()
returns flag bits for which of open/lock owner(s) have
been free'd.

Feb 22 2022, 4:57 PM
rmacklem added inline comments to D34334: fix a use after free in nfscl_cleanupkext().
Feb 22 2022, 2:55 PM
rmacklem committed R10:0dd60a57103e: gssd: Modify /etc/rc.d/gssd so that it starts after NETWORKING (authored by rmacklem).
gssd: Modify /etc/rc.d/gssd so that it starts after NETWORKING
Feb 22 2022, 12:48 AM
rmacklem committed R10:cc6f50fc371f: gssd: Modify /etc/rc.d/gssd so that it starts after NETWORKING (authored by rmacklem).
gssd: Modify /etc/rc.d/gssd so that it starts after NETWORKING
Feb 22 2022, 12:42 AM
rmacklem requested review of D34334: fix a use after free in nfscl_cleanupkext().
Feb 22 2022, 12:21 AM

Feb 16 2022

rmacklem committed R10:95e95764918f: nfsd: Reply NFSERR_SEQMISORDERED for bogus seqid argument (authored by rmacklem).
nfsd: Reply NFSERR_SEQMISORDERED for bogus seqid argument
Feb 16 2022, 11:01 PM
rmacklem committed R10:59c8b54cc7c1: nfsd: Allow file owners to perform Open(Delegate_cur) (authored by rmacklem).
nfsd: Allow file owners to perform Open(Delegate_cur)
Feb 16 2022, 11:00 PM
rmacklem committed R10:7deb47265d12: nfsd: Reply NFSERR_SEQMISORDERED for bogus seqid argument (authored by rmacklem).
nfsd: Reply NFSERR_SEQMISORDERED for bogus seqid argument
Feb 16 2022, 1:04 AM
rmacklem committed R10:3a42078ae951: nfsd: Allow file owners to perform Open(Delegate_cur) (authored by rmacklem).
nfsd: Allow file owners to perform Open(Delegate_cur)
Feb 16 2022, 1:02 AM

Feb 15 2022

rmacklem committed R10:0f5e9425e74b: gssd: Modify /etc/rc.d/gssd so that it starts after NETWORKING (authored by rmacklem).
gssd: Modify /etc/rc.d/gssd so that it starts after NETWORKING
Feb 15 2022, 10:20 PM
rmacklem closed D34265: modify /etc/rc.d/gssd so that it starts after NETWORKING and kdc.
Feb 15 2022, 10:19 PM · rc

Feb 14 2022

rmacklem added a reviewer for D34265: modify /etc/rc.d/gssd so that it starts after NETWORKING and kdc: 0mp.

I have added Mateusz as a reviewer. If anyone else is willing to review this, please do so.
I have heard from Arno that it did fix the problem for him and would like to get this into
13.1.

Feb 14 2022, 10:31 PM · rc
rmacklem requested review of D34265: modify /etc/rc.d/gssd so that it starts after NETWORKING and kdc.
Feb 14 2022, 2:29 AM · rc

Feb 10 2022

rmacklem committed R10:be1776da76c7: nfsclient: Delete unused function nfscl_getcookie() (authored by rmacklem).
nfsclient: Delete unused function nfscl_getcookie()
Feb 10 2022, 3:40 AM

Feb 9 2022

rmacklem committed R10:17a56f3fabdf: nfsd: Reply NFSERR_SEQMISORDERED for bogus seqid argument (authored by rmacklem).
nfsd: Reply NFSERR_SEQMISORDERED for bogus seqid argument
Feb 9 2022, 11:19 PM

Feb 2 2022

rmacklem committed R10:e2fe58d61b7c: nfsd: Allow file owners to perform Open(Delegate_cur) (authored by rmacklem).
nfsd: Allow file owners to perform Open(Delegate_cur)
Feb 2 2022, 10:11 PM
rmacklem accepted D33726: fusefs: fix VOP_READDIR problems for NFS-exported FUSE file systems.

Looks ok, if I understood what the patch does.
Basically, instead of reading a directory from the
beginning of it, it simply refuses to export the file
system unless it has the FSESS_NO_OPENDIR_SUPPORT
property, which means the cookies remain valid.

Feb 2 2022, 9:03 PM

Jan 27 2022

rmacklem committed R10:98c788737f71: nfsclient: Delete unused function nfscl_getcookie() (authored by rmacklem).
nfsclient: Delete unused function nfscl_getcookie()
Jan 27 2022, 11:32 PM
rmacklem committed R10:62db233e1fd2: mount_nfs: Add a "bgnow" NFS mount option (authored by rmacklem).
mount_nfs: Add a "bgnow" NFS mount option
Jan 27 2022, 12:15 AM

Jan 25 2022

rmacklem committed R10:82dbca47a558: mount_nfs: Add a "bgnow" NFS mount option (authored by rmacklem).
mount_nfs: Add a "bgnow" NFS mount option
Jan 25 2022, 11:27 PM
rmacklem committed R10:3953a0d780ac: nfsd: Do not accept audit/alarm ACEs for the NFSv4 server (authored by rmacklem).
nfsd: Do not accept audit/alarm ACEs for the NFSv4 server
Jan 25 2022, 11:25 PM
rmacklem added a comment to D33549: vm_object: restore handling of shadow_count for all type of objects.

It turned out that NFS did not need to know if a file
was mmap'd, since it had to invalidate pages
unconditionally for the Append case.

Jan 25 2022, 3:10 PM

Jan 23 2022

rmacklem committed R10:f72926eab00c: mountd: Delay starting mountd until after mountlate (authored by rmacklem).
mountd: Delay starting mountd until after mountlate
Jan 23 2022, 10:19 PM
rmacklem closed D33256: Modify the rc scripts so that mountd starts after mountlate.
Jan 23 2022, 10:18 PM · rc

Jan 11 2022

rmacklem committed R10:a91a57846b58: nfsd: Do not accept audit/alarm ACEs for the NFSv4 server (authored by rmacklem).
nfsd: Do not accept audit/alarm ACEs for the NFSv4 server
Jan 11 2022, 5:45 PM
rmacklem added a reverting change for R10:0fa074b53e7c: nfscommon: Add arguments for support of the dacl attribute: R10:5da9b3b011fd: Revert "nfscommon: Add arguments for support of the dacl attribute".
Jan 11 2022, 4:35 PM
rmacklem committed R10:5da9b3b011fd: Revert "nfscommon: Add arguments for support of the dacl attribute" (authored by rmacklem).
Revert "nfscommon: Add arguments for support of the dacl attribute"
Jan 11 2022, 4:35 PM
rmacklem added a reverting change for R10:f10dc28ec21d: nfscommon: Return NFSERR_ATTRNOTSUPP for AUDIT/ALARM ACEs: R10:b1f80dfac968: Revert "nfscommon: Return NFSERR_ATTRNOTSUPP for AUDIT/ALARM ACEs".
Jan 11 2022, 4:30 PM
rmacklem committed R10:b1f80dfac968: Revert "nfscommon: Return NFSERR_ATTRNOTSUPP for AUDIT/ALARM ACEs" (authored by rmacklem).
Revert "nfscommon: Return NFSERR_ATTRNOTSUPP for AUDIT/ALARM ACEs"
Jan 11 2022, 4:30 PM
rmacklem committed R10:08a8d16cbb26: mount_nfs: Add a "bgnow" NFS mount option (authored by rmacklem).
mount_nfs: Add a "bgnow" NFS mount option
Jan 11 2022, 4:23 PM
rmacklem closed D33733: Add a "bgnow" NFS mount option that causes the mount to go background immediately.
Jan 11 2022, 4:22 PM

Jan 9 2022

rmacklem added inline comments to D33800: fusefs: implement VOP_DEALLOCATE.
Jan 9 2022, 2:37 PM

Jan 6 2022

rmacklem committed R10:e4df1036f66d: nfscl: Always invalidate buffers for append writes (authored by rmacklem).
nfscl: Always invalidate buffers for append writes
Jan 6 2022, 10:25 PM

Jan 3 2022

rmacklem requested review of D33733: Add a "bgnow" NFS mount option that causes the mount to go background immediately.
Jan 3 2022, 10:31 PM

Dec 30 2021

rmacklem committed R10:6d16489da847: nfscl: Handle CB_SEQUENCE not first op correctly (authored by rmacklem).
nfscl: Handle CB_SEQUENCE not first op correctly
Dec 30 2021, 1:36 AM
rmacklem committed R10:efc08dab492c: nfscl: Handle CB_SEQUENCE not first op correctly (authored by rmacklem).
nfscl: Handle CB_SEQUENCE not first op correctly
Dec 30 2021, 1:28 AM
rmacklem committed R10:7aa23c7b59f7: rpc: Delete AUTH_NEEDS_TLS(_MUTUAL_HOST) auth_stat values (authored by rmacklem).
rpc: Delete AUTH_NEEDS_TLS(_MUTUAL_HOST) auth_stat values
Dec 30 2021, 1:27 AM

Dec 27 2021

rmacklem committed R10:f10dc28ec21d: nfscommon: Return NFSERR_ATTRNOTSUPP for AUDIT/ALARM ACEs (authored by rmacklem).
nfscommon: Return NFSERR_ATTRNOTSUPP for AUDIT/ALARM ACEs
Dec 27 2021, 4:07 PM
rmacklem committed R10:e4a65cff230d: nfsd: Limit parsing of layout errors to maxcnt bytes (authored by rmacklem).
nfsd: Limit parsing of layout errors to maxcnt bytes
Dec 27 2021, 1:05 AM
rmacklem committed R10:3c3b641a610c: nfscl: add a filesize limit check to nfs_allocate() (authored by rmacklem).
nfscl: add a filesize limit check to nfs_allocate()
Dec 27 2021, 12:59 AM
rmacklem committed R10:030acb63d9a8: nfsd: Limit parsing of layout errors to maxcnt bytes (authored by rmacklem).
nfsd: Limit parsing of layout errors to maxcnt bytes
Dec 27 2021, 12:57 AM
rmacklem committed R10:0fa074b53e7c: nfscommon: Add arguments for support of the dacl attribute (authored by rmacklem).
nfscommon: Add arguments for support of the dacl attribute
Dec 27 2021, 12:47 AM

Dec 26 2021

rmacklem committed R10:4adb1ced83f4: nfscl: Fix must_commit handling for mirrored pNFS mounts (authored by rmacklem).
nfscl: Fix must_commit handling for mirrored pNFS mounts
Dec 26 2021, 2:41 AM
rmacklem committed R10:468043bbaeb9: nfscl: Fix must_commit handling for mirrored pNFS mounts (authored by rmacklem).
nfscl: Fix must_commit handling for mirrored pNFS mounts
Dec 26 2021, 2:26 AM