Page MenuHomeFreeBSD

rmacklem (Rick Macklem)
User

Projects

User Details

User Since
Jan 13 2015, 10:58 PM (320 w, 1 d)

Recent Activity

Today

rmacklem committed R10:0dcfb6d761cc: getdirentries.2: fix for NFS mounts (authored by rmacklem).
getdirentries.2: fix for NFS mounts
Thu, Mar 4, 1:33 AM

Yesterday

rmacklem committed R10:3664067ea91a: nfsclient: fix panic in cache_enter_time() (authored by rmacklem).
nfsclient: fix panic in cache_enter_time()
Wed, Mar 3, 4:29 PM
rmacklem committed R10:2d379aed1e5c: copy_file_range(2): Fix for small values of input file offset and len (authored by rmacklem).
copy_file_range(2): Fix for small values of input file offset and len
Wed, Mar 3, 3:42 PM
rmacklem committed R10:a2a4cfc3157f: nfsclient: fix panic in cache_enter_time() (authored by rmacklem).
nfsclient: fix panic in cache_enter_time()
Wed, Mar 3, 3:12 PM
rmacklem committed R10:902a18d50aef: copy_file_range(2): Fix for small values of input file offset and len (authored by rmacklem).
copy_file_range(2): Fix for small values of input file offset and len
Wed, Mar 3, 2:50 PM

Tue, Mar 2

rmacklem committed R10:c04199affeac: nfsclient: Fix ReadDS/WriteDS/CommitDS nfsstats RPC counts for a NFSv3 DS (authored by rmacklem).
nfsclient: Fix ReadDS/WriteDS/CommitDS nfsstats RPC counts for a NFSv3 DS
Tue, Mar 2, 10:21 PM

Mon, Mar 1

rmacklem committed R10:b96e66349ed8: getdirentries.2: fix for NFS mounts (authored by rmacklem).
getdirentries.2: fix for NFS mounts
Mon, Mar 1, 9:06 PM
rmacklem committed R10:94f2e42f5e0b: nfsclient: Fix the stripe unit size for a File Layout pNFS layout (authored by rmacklem).
nfsclient: Fix the stripe unit size for a File Layout pNFS layout
Mon, Mar 1, 8:51 PM
rmacklem committed R10:a5f9fe2bab78: copy_file_range(2): Fix for small values of input file offset and len (authored by rmacklem).
copy_file_range(2): Fix for small values of input file offset and len
Mon, Mar 1, 2:32 PM
rmacklem closed D28981: copy_file_range(2): Fix for small values of input file offset and len.
Mon, Mar 1, 2:32 PM

Sun, Feb 28

rmacklem committed R10:15bed8c46b32: nfsclient: add nfs node locking around uses of n_direofoffset (authored by rmacklem).
nfsclient: add nfs node locking around uses of n_direofoffset
Sun, Feb 28, 10:56 PM
rmacklem committed R10:3e04ab36ba5c: nfsclient: add checks for a server returning the current directory (authored by rmacklem).
nfsclient: add checks for a server returning the current directory
Sun, Feb 28, 10:17 PM
rmacklem closed D28987: add safetybelt checks for cache_enter_time() when an NFS server sends a bogus reply.
Sun, Feb 28, 10:17 PM
rmacklem added a comment to D28981: copy_file_range(2): Fix for small values of input file offset and len.

I have a few C programs, which could be cleaned up.
But I know nothing about automated testing nor
what FreeBSD currently does.

Sun, Feb 28, 9:43 PM
rmacklem requested review of D28987: add safetybelt checks for cache_enter_time() when an NFS server sends a bogus reply.
Sun, Feb 28, 3:56 PM
rmacklem added a comment to D28981: copy_file_range(2): Fix for small values of input file offset and len.

It was found with an automated test. I just don't know
the details, except it is python code. I'll forward the
email and koobs@ can fill you in.

Sun, Feb 28, 2:20 PM
rmacklem requested review of D28981: copy_file_range(2): Fix for small values of input file offset and len.
Sun, Feb 28, 3:42 AM
rmacklem closed D28969: fix panic "dvp != vp not true" in cache_enter_time().
Sun, Feb 28, 1:57 AM
rmacklem committed R10:3fe2c68ba20f: nfsclient: fix panic in cache_enter_time() (authored by rmacklem).
nfsclient: fix panic in cache_enter_time()
Sun, Feb 28, 1:57 AM

Sat, Feb 27

rmacklem requested review of D28969: fix panic "dvp != vp not true" in cache_enter_time().
Sat, Feb 27, 4:34 PM

Thu, Feb 18

rmacklem committed R10:2f48313ab26e: nfs-over-tls: add rc scripts for rpc.tlsclntd and rpc.tlsservd (authored by rmacklem).
nfs-over-tls: add rc scripts for rpc.tlsclntd and rpc.tlsservd
Thu, Feb 18, 10:42 PM
rmacklem closed D28432: add rc.d scripts for nfs-over-tls daemons.
Thu, Feb 18, 10:41 PM
rmacklem committed R10:b9cbc85d7272: nfs-over-tls: add user space daemons rpc.tlsclntd and rpc.tlsservd (authored by rmacklem).
nfs-over-tls: add user space daemons rpc.tlsclntd and rpc.tlsservd
Thu, Feb 18, 10:18 PM
rmacklem closed D28430: add nfs-over-tls daemons to head/main.
Thu, Feb 18, 10:17 PM
rmacklem added a comment to D28430: add nfs-over-tls daemons to head/main.

Mark inline comment as done.

Thu, Feb 18, 1:14 AM
rmacklem updated the diff for D28430: add nfs-over-tls daemons to head/main.

As suggested by jhb@, add a command line option
to rpc.tlsclntd to specify preferred ciphers.
If the option is not specified, the daemon does
not make a SSL_CTX_set_cipher_list() call.

Thu, Feb 18, 1:13 AM

Wed, Feb 17

rmacklem committed R10:cace1baa12a5: mount_nfs: update man page description for oneopenown (authored by rmacklem).
mount_nfs: update man page description for oneopenown
Wed, Feb 17, 9:31 PM
rmacklem added inline comments to D28430: add nfs-over-tls daemons to head/main.
Wed, Feb 17, 12:39 AM
rmacklem added a comment to D28430: add nfs-over-tls daemons to head/main.

Mark jhb@s comment as done.
W.r.t. the review of the rest of it, I understand
completely and will probably commit soon without
a full review.

Wed, Feb 17, 12:28 AM
rmacklem updated the diff for D28430: add nfs-over-tls daemons to head/main.

Essentially revert the last changes that made the
code build without KTLS. Always building seems
to be a desirable property for a port, which is why
I made the change.

Wed, Feb 17, 12:18 AM

Tue, Feb 16

rmacklem closed D28572: sysutils/nfs-over-tls: Fix build with OpenSSL without KTLS patches.
Tue, Feb 16, 2:51 PM
rmacklem committed rP565403: sysutils/nfs-over-tls: Fix build with OpenSSL without KTLS patches.
sysutils/nfs-over-tls: Fix build with OpenSSL without KTLS patches
Tue, Feb 16, 2:51 PM

Mon, Feb 15

rmacklem committed R10:a0698341cd89: getdirentries.2: fix for NFS mounts (authored by rmacklem).
getdirentries.2: fix for NFS mounts
Mon, Feb 15, 2:20 AM
rmacklem closed D28664: fix getdirentries man page for NFS client returning d_off == 0.
Mon, Feb 15, 2:19 AM

Sun, Feb 14

rmacklem added a comment to D28664: fix getdirentries man page for NFS client returning d_off == 0.

Marked inline comments as done.

Sun, Feb 14, 9:36 PM
rmacklem updated the diff for D28664: fix getdirentries man page for NFS client returning d_off == 0.

Apply changes suggested by asomers@.

Sun, Feb 14, 9:36 PM
rmacklem requested review of D28664: fix getdirentries man page for NFS client returning d_off == 0.
Sun, Feb 14, 4:35 PM

Sat, Feb 13

rmacklem updated the diff for D28572: sysutils/nfs-over-tls: Fix build with OpenSSL without KTLS patches.

Revert the last change and take setting root/wheel out
of the port's Makefile, as requested by loader.

Sat, Feb 13, 2:59 PM

Fri, Feb 12

rmacklem updated the diff for D28572: sysutils/nfs-over-tls: Fix build with OpenSSL without KTLS patches.

Add check for UID == 0, since this port
can only be installed as root.

Fri, Feb 12, 4:06 PM
rmacklem updated the diff for D28572: sysutils/nfs-over-tls: Fix build with OpenSSL without KTLS patches.

Change BROKEN to IGNORE as suggested.

Fri, Feb 12, 12:08 AM

Thu, Feb 11

rmacklem updated the diff for D28572: sysutils/nfs-over-tls: Fix build with OpenSSL without KTLS patches.

Bumped the software to version1.1 as suggested.

Thu, Feb 11, 2:00 PM
rmacklem added a comment to D28430: add nfs-over-tls daemons to head/main.

Marked inline comment as done.

Thu, Feb 11, 1:16 PM
rmacklem updated the diff for D28430: add nfs-over-tls daemons to head/main.

Fixed usr.sbin/Makefile as suggested by jhb@.

Thu, Feb 11, 1:12 PM
rmacklem added a reviewer for D28572: sysutils/nfs-over-tls: Fix build with OpenSSL without KTLS patches: loader.

Add loader as a reviewer.

Thu, Feb 11, 12:14 AM

Wed, Feb 10

rmacklem requested review of D28572: sysutils/nfs-over-tls: Fix build with OpenSSL without KTLS patches.
Wed, Feb 10, 2:22 PM

Tue, Feb 9

rmacklem updated the diff for D28430: add nfs-over-tls daemons to head/main.

Patch the daemons so that they will build
for an OpenSSL that is not patched for KTLS.
Also added a check for them being built with
an OpenSSL with KTLS enabled and just errx()
if not.

Tue, Feb 9, 5:39 PM

Wed, Feb 3

rmacklem committed rP563881: Fix out of date distinfo..
Fix out of date distinfo.
Wed, Feb 3, 1:53 PM

Feb 2 2021

rmacklem updated the diff for D28430: add nfs-over-tls daemons to head/main.

The return value for SSL_get_verify_result() is
long and not int.
This update declares a long variable called verfret
to hold the value returned by SSL_get_verify_result()
instead of using "ret", which is an int.

Feb 2 2021, 1:09 AM

Jan 31 2021

rmacklem added a comment to D28430: add nfs-over-tls daemons to head/main.

Mark inline comment as done.

Jan 31 2021, 9:50 PM
rmacklem updated the diff for D28430: add nfs-over-tls daemons to head/main.

Fix export to exports as reported by gbe@.
Also, delete a couple of debug output lines
that got missed by a previous edit.

Jan 31 2021, 9:49 PM
rmacklem requested review of D28432: add rc.d scripts for nfs-over-tls daemons.
Jan 31 2021, 12:22 AM

Jan 30 2021

rmacklem added a comment to D28430: add nfs-over-tls daemons to head/main.

Well, not exactly missing. I was planning on
the rc.d changes being a separate review,
in part because they will need a detailed
look, given my lack of expertise w.r.t. them.

Jan 30 2021, 6:12 PM
rmacklem requested review of D28430: add nfs-over-tls daemons to head/main.
Jan 30 2021, 5:31 PM

Jan 24 2021

rmacklem abandoned D28318: fix ncl_pager_setsize() so that the correct nsize can be set via a new argument.

Your patch sounds fine to me and is what I was
thinking when I asked.
(I didn't understand why the ncl_pager_setsize() call
was added, but I also admit I don't understand the
vm side of vnode_pager_setsze().)

Jan 24 2021, 10:03 PM
rmacklem added a comment to D28318: fix ncl_pager_setsize() so that the correct nsize can be set via a new argument.

Comment inline.

Jan 24 2021, 3:32 PM

Jan 23 2021

rmacklem requested review of D28318: fix ncl_pager_setsize() so that the correct nsize can be set via a new argument.
Jan 23 2021, 11:32 PM
rmacklem accepted D28306: nfs client: block vnode_pager_setsize() calls from nfscl_loadattrcache in nfs_write.

Looks fine to me, although I'll admit that I
do not really understand the vnode_pager_setsize()
stuff well enough to say whether or not this is correct?

Jan 23 2021, 2:49 PM

Jan 18 2021

rmacklem added a comment to D28215: update mount_nfs(8) man page for uses of the oneopenown option.

Marked comments as done.

Jan 18 2021, 3:08 AM
rmacklem closed D28215: update mount_nfs(8) man page for uses of the oneopenown option.
Jan 18 2021, 3:05 AM
rmacklem committed R10:448de00de556: mount_nfs: update man page description for oneopenown (authored by rmacklem).
mount_nfs: update man page description for oneopenown
Jan 18 2021, 3:05 AM

Jan 17 2021

rmacklem requested review of D28215: update mount_nfs(8) man page for uses of the oneopenown option.
Jan 17 2021, 9:40 PM

Jan 12 2021

rmacklem committed R10:f6dc363f6dd2: nfs-over-tls: handle res.gid.gid_val correctly for memory allocation (authored by rmacklem).
nfs-over-tls: handle res.gid.gid_val correctly for memory allocation
Jan 12 2021, 10:03 PM

Jan 10 2021

rmacklem committed R10:148a227bf80e: nfsd: add KASSERTs to nfsm_trimtrailing() for M_EXTPG mbufs (authored by rmacklem).
nfsd: add KASSERTs to nfsm_trimtrailing() for M_EXTPG mbufs
Jan 10 2021, 9:54 PM
rmacklem closed D28053: add kasserts to nfsm_trimtrailing as suggested by kib@.
Jan 10 2021, 9:54 PM

Jan 9 2021

rmacklem added a comment to D28053: add kasserts to nfsm_trimtrailing as suggested by kib@.

Yes, bextpgsiz is the bytes remaining to be used in the page.
It was easier than using offset within the page, since there
is 1st_page_off to deal with.

Jan 9 2021, 3:02 AM
rmacklem requested review of D28053: add kasserts to nfsm_trimtrailing as suggested by kib@.
Jan 9 2021, 12:20 AM

Jan 3 2021

rmacklem closed D27935: add recommendation for using a large "len" argument.
Jan 3 2021, 1:25 AM
rmacklem committed R10:d189a74dfdcd: copy_file_range(2): add recommendation to use large "len" (authored by rmacklem).
copy_file_range(2): add recommendation to use large "len"
Jan 3 2021, 1:25 AM
rmacklem committed R10:c98a764c681f: cp(1): fix performance issue for large non-sparse file copies (authored by rmacklem).
cp(1): fix performance issue for large non-sparse file copies
Jan 3 2021, 1:02 AM
rmacklem closed D27937: fix the performance of cp(1) when copying large non-sparse files.
Jan 3 2021, 1:02 AM
rmacklem added a comment to D27935: add recommendation for using a large "len" argument.

Handled inline comments.

Jan 3 2021, 12:28 AM
rmacklem updated the diff for D27935: add recommendation for using a large "len" argument.

Update patch as recommended by asomers@.

Jan 3 2021, 12:25 AM

Jan 2 2021

rmacklem requested review of D27937: fix the performance of cp(1) when copying large non-sparse files.
Jan 2 2021, 11:51 PM
rmacklem requested review of D27935: add recommendation for using a large "len" argument.
Jan 2 2021, 11:04 PM
rmacklem accepted D27881: nfs server: improve use if the VFS KPI.

Looks fine to me now.
With these changes my test run works fine.

Jan 2 2021, 1:55 AM
rmacklem added a comment to D27881: nfs server: improve use if the VFS KPI.

Comments inline.

Jan 2 2021, 12:07 AM

Jan 1 2021

rmacklem committed R10:dc78533a5204: nfsd: fix NFSv4.0 seqid handling for ERELOOKUP (authored by rmacklem).
nfsd: fix NFSv4.0 seqid handling for ERELOOKUP
Jan 1 2021, 10:25 PM
rmacklem committed R10:774a36851e0e: nfsd: fix NFS server for ERELOOKUP (authored by rmacklem).
nfsd: fix NFS server for ERELOOKUP
Jan 1 2021, 10:01 PM
rmacklem closed D27875: fix the NFS server for ERELOOKUP operation redos.
Jan 1 2021, 10:00 PM

Dec 31 2020

rmacklem requested review of D27875: fix the NFS server for ERELOOKUP operation redos.
Dec 31 2020, 10:29 PM

Dec 24 2020

rmacklem committed R10:79302a6304b1: mount_nfs(8): add a description for the new "tlscertname" option (authored by rmacklem).
mount_nfs(8): add a description for the new "tlscertname" option
Dec 24 2020, 10:25 PM
rmacklem closed D27733: add a description for the new tlscertname NFS mount option.
Dec 24 2020, 10:24 PM

Dec 23 2020

rmacklem added a comment to D27733: add a description for the new tlscertname NFS mount option.

Marked inline comments as done.

Dec 23 2020, 12:15 AM
rmacklem updated the diff for D27733: add a description for the new tlscertname NFS mount option.

Made the recommended changes.
I'll admit I started with .Ar and then changed to .Dq
because a plain text screen like I use does not mark
.Ar in any way.

Dec 23 2020, 12:15 AM

Dec 22 2020

rmacklem requested review of D27733: add a description for the new tlscertname NFS mount option.
Dec 22 2020, 11:15 PM

Dec 17 2020

rmacklem closed D27506: fix mountcritremote so that the NFSv4 callback daemon will start before NFS mounts are done.
Dec 17 2020, 12:21 AM · rc
rmacklem committed rS368710: Make mountcritremote dependent upon nfscbd..
Make mountcritremote dependent upon nfscbd.
Dec 17 2020, 12:21 AM

Dec 13 2020

rmacklem added a comment to D27506: fix mountcritremote so that the NFSv4 callback daemon will start before NFS mounts are done.

Well, the nfscbd should definitely be done before mountcritremote.
I have not seen evidence that this does not happen, but nothing I
know of forces the ordering.

Dec 13 2020, 10:46 PM · rc
rmacklem committed R9:204fe18066aa: Added my name/email (authored by rmacklem).
Added my name/email
Dec 13 2020, 5:41 PM
rmacklem committed R9:e11dd15f6835: Added myself to contrib.committers.sgml and removed myself from (authored by rmacklem).
Added myself to contrib.committers.sgml and removed myself from
Dec 13 2020, 5:41 PM
rmacklem committed R9:945f6a8363ad: Added myself to developers.sgml. (authored by rmacklem).
Added myself to developers.sgml.
Dec 13 2020, 5:41 PM
rmacklem committed R9:7bb729341f16: added my pgp key (authored by rmacklem).
added my pgp key
Dec 13 2020, 5:41 PM
rmacklem committed R9:cc1a039034b5: Added my new committer entry. (authored by rmacklem).
Added my new committer entry.
Dec 13 2020, 5:41 PM

Dec 8 2020

rmacklem committed rS368466: MFC: r368268.
MFC: r368268
Dec 8 2020, 10:38 PM
rmacklem requested review of D27506: fix mountcritremote so that the NFSv4 callback daemon will start before NFS mounts are done.
Dec 8 2020, 2:01 AM · rc
rmacklem committed rS368420: Replace the etc/rc.d patches with an updated one..
Replace the etc/rc.d patches with an updated one.
Dec 8 2020, 12:06 AM

Dec 7 2020

rmacklem committed rS368419: Delete the out of date setup file..
Delete the out of date setup file.
Dec 7 2020, 11:39 PM

Dec 3 2020

rmacklem added a comment to D27272: Add a manpage for kernel TLS..

Righto. I was thinking that, someday (maybe within the
FreeBSD13 release lifetime) that NFS over TLS might
become widely useful and not needing to build a
custom kernel would be nice then.

Dec 3 2020, 11:35 PM

Dec 2 2020

rmacklem added a comment to D27272: Add a manpage for kernel TLS..

It's up to you, however I tend to think of sysctls as orthogonal
to kernel options and, as such, having the default change
based on KERN_TLS seems a little weird to me.

Dec 2 2020, 2:34 AM

Dec 1 2020

rmacklem closed D27430: improve man page description for AmazonEFS NFS mounts.
Dec 1 2020, 11:33 PM