- User Since
- Jan 13 2015, 10:58 PM (230 w, 5 d)
Change the mem_iszero() helper function to return bool instead of int, since C99 bool is now fashionable
in the FreeBSD kernel.
Changed an int to a bool, since C99 bools now appear to be fashionable in the FreeBSD kernel.
int arguments changed to C99 bool as requested by kib@.
Sat, Jun 15
Added replies to inline comments.
This variant allows a sleep to be done for allocation of a new list entry. It only returns NULL
if it would need to sleep waiting to be able to lock the range.
Replace vn_rangelock_rlock_nonblock() with vn_rangelock_rlock_trylock() to be consistent with D20645.
This variant of the patch has the "_nonblock" suffixes replaced by "_trylock" as suggested by asomers@.
A quick grep of src/sys/sys shows that "nonblock" is used for flags, but "_trylock" is used as a suffix
for non-blocking lock functions.
This variant of the patch rangelocks the byte ranges for both the input and output files.
It uses the vn_rangelock_rlock_nonblock() call in the D20645 patch to do this without a
risk of deadlock.
Thu, Jun 13
Added inline replies to the inline comments that still apply to this version.
This version of the patch avoids the problems w.r.t. concurrent locking of two vnodes
by locking/unlocking the vnodes (which also implies rangelocks and vn_start_write())
I am going to take the "does this sycall need to be atomic?" over to FreeBSD-fs@.
(I will copy kib@'s and asomers@ comments into the post.)
Tue, Jun 11
Yes, I did understand the comment w.r.t. range_locks. I fixed the rest of the stuff for two vnodes locked
concurrently, but I couldn't see an easy way to do range_locks on both of them without a LOR.
Added a question w.r.t. which way I should handle the locking of the two vnodes.
Mon, Jun 10
Mon, Jun 3
Sun, Jun 2
The COMPARE_ARRAYS() macro has been changed per suggestions by kib@.
The COMPARE_ARRAYS() macro has been changed to remove the "optimizations"
as suggested by kib@. It now just checks for the common case of identical
arrays by iterating through them with a for loop.
This also allowed the "typ" argument to be removed, since it is no longer needed.
W.r.t. the config file. Unless there are several who disagree with just having this always enabled,
I think it is ok to just have it always enabled and not configurable.
Sat, Jun 1
This version of the patch just implements the incremental update of the kernel exports
for all reloads and does not need/use the "-I" option.
Fri, May 31
Well, the main reason I made it an optional non-default option is...
- The exports file format (and the code that parses it and reloads it) is complex and I may have missed a case such that the "-I reload" doesn't get it right. --> With a non-default option, the sysadmin can just go back to the default case and that should work around the bug until it is fixed. (Since the initial load must be a full loading of the exports, the non "-I" case code needs to remain in the sources and making it non-optional wouldn't simplify the code.)
Wed, May 22
Sounds fine to me. (I'll admit I never look at man pages for this stuff and just the code, so
I didn't even notice there was a man page. Oops.)
I haven't had a Kerberos setup for quite a while.
However, Peter Errikson uses Kerberized NFS and even with a Windows KDC, I think?
Mon, May 20
Here are the results of a test run done by Peter for a hash table of the size this patch
creates and one ten times bigger:
“BigHash” (without “/ 10”)
May 18 15:06:56 filur00 mountd: time spent reading exports: 6.9s
May 18 15:06:56 filur00 mountd: time spent updating kernel: 16.4s
May 18 15:07:10 filur00 mountd: time spent reading exports: 902.5ms
May 18 15:07:10 filur00 mountd: time spent updating kernel: 17.9ms
May 16 2019
May 14 2019
May 11 2019
May 10 2019
May 6 2019
May 3 2019
May 2 2019
Apr 28 2019
Apr 27 2019
Apr 25 2019
Apr 21 2019
Apr 20 2019
Apr 19 2019
Apr 18 2019
Apr 16 2019
Apr 15 2019
Apr 14 2019
Updated patch renames pfind_locked() to pfind_any_locked(), per mjg@'s request.
pfind_locked() has been renamed pfind_any_locked() and a comment
indicating that it finds zombies has been added, per mjg@'s request.
Apr 13 2019
Replied to inline comment.
I have included responses to the inline comments.