- User Since
- Jan 13 2015, 10:58 PM (437 w, 3 d)
Well, the master/server terminology is used
in other places, such as nfsd(8).
The terminology must be short enough that
it is displayed correctly by "ps". I think
"controlling server" would get truncated.
(This is the man page, but it needs to be
consistent with what the daemon does.)
Thu, Jun 1
Wed, May 31
This version gets rid of the pre-1.1.1 calls.
It also fixes a typo where I used > instead
of >= for the OPENSSL_VERSION_NUMBER.
I installed openssl31 via ports and did builds
using that with OPENSSL_NO_DEPRECATED_...
and found a few more.
Mon, May 29
Sun, May 28
Fri, May 26
Thu, May 25
Wed, May 24
Mon, May 22
Sun, May 21
Fri, May 19
Thu, May 18
Wed, May 17
Tue, May 16
Mon, May 15
Sat, May 6
Looks fine to me. I'll wait to hear from mav@
w.r.t. which one of us will commit it.
Fri, May 5
The "int ret = 1;" appears to still be in the patch.
I suspect that is just uploading the wrong version.
Trivial to fix during commit.
Thu, May 4
Except for the minor nit that "ret" no longer
does anything and can be removed, it
looks fine to me now.
Apr 29 2023
Yes. The other nfs daemons were converted to master/server and,
at the time, that seemed to be considered appropriate.
This change makes nfsuserd do the same.
Made a couple of inline suggestions, but the code does
look correct to me.
I assume you do not have src commit bit, given your login name?
Apr 22 2023
Apr 16 2023
Apr 13 2023
Looks ok to me. Just fyi, using xdrproc_t outside the kernel is
always a bit sketchy, since the functions have variable
numbers of arguments and the typedef is a non-typedef.
Apr 11 2023
Apr 10 2023
Oops, typo. It should be ap->a_fsizetd and not ap->a_fsize_td.
danfe@ reported a problem via email where rlimit
resulted in an empty file. I think this is due to the
use of SSIZE_MAX for the length and then checking
it with a call to vn_rlimit_fsize().
Apr 8 2023
Made the changes suggested by karels@.
Apr 7 2023
Apr 6 2023
LGTM. mjg@ can decide if he needs this for his
patch against zfs_copy_file_range().
A little off topic, but would it make sense to add
"lktype" arguments to vn_lock_pair() so that it can
optionally acquire LK_SHARED vnode locks?
Apr 5 2023
Well I know nothing about ZFS, but while doing this I learned that block cloning is not enabled
by default. I suspect many other ZFS users are like me and would not know that enabling
block cloning was needed for performance (or even how to enable it). I assume there is a
reason it is not always enabled?
--> At this time, I don't think block cloning being disabled is a rare corner case.
Apr 4 2023
You might find these little programs useful for testing.
(I realized my only ZFS setup doesn't do block whatever,
so I can only test the fallback to vn_generic_copy_file_range().)
Apr 1 2023
Mar 29 2023
Mar 27 2023
Mar 23 2023
Mar 22 2023
Mar 21 2023
Oops, I missed the reviewed by pauamma (manpages),
since it happened just when I did the commit.