Page MenuHomeFreeBSD

rmacklem (Rick Macklem)
User

Projects

User Details

User Since
Jan 13 2015, 10:58 PM (203 w, 5 d)

Recent Activity

Sat, Dec 1

rmacklem accepted D18393: Add kern.rpc.gss.client_max.

Looks fine to me, although I'll admit I've never noticed there was a CLIENT_MAX in this code.
(I wasn't the author.)

Sat, Dec 1, 1:09 AM

Fri, Nov 23

rmacklem committed rS340787: Make sure the NFS readdir client fills in all "struct dirent" data..
Make sure the NFS readdir client fills in all "struct dirent" data.
Fri, Nov 23, 12:17 AM

Tue, Nov 20

rmacklem committed rS340663: Improve sanity checking for the dircount hint argument to.
Improve sanity checking for the dircount hint argument to
Tue, Nov 20, 2:00 AM
rmacklem committed rS340662: nfsm_advance() would panic() when the offs argument was negative..
nfsm_advance() would panic() when the offs argument was negative.
Tue, Nov 20, 1:56 AM
rmacklem committed rS340661: r304026 added code that started statistics gathering for an operation.
r304026 added code that started statistics gathering for an operation
Tue, Nov 20, 1:52 AM

Mon, Nov 19

rmacklem committed rS340590: MFC: r339999.
MFC: r339999
Mon, Nov 19, 12:49 AM

Sun, Nov 18

rmacklem committed rS340589: MFC: r339999.
MFC: r339999
Sun, Nov 18, 11:48 PM
rmacklem committed rS340588: MFC: r339999.
MFC: r339999
Sun, Nov 18, 11:00 PM

Mon, Nov 12

rmacklem added a comment to D17917: d_off support for multiple filesystems.

Added an inline suggestion related to the man page update.

Mon, Nov 12, 4:02 PM
rmacklem accepted D17917: d_off support for multiple filesystems.

Assuming you resolve the man page issue that kib@ has commented on, this looks ok to me.

Mon, Nov 12, 3:49 PM
rmacklem committed rS340357: Add support for the NFSv4.2 IOAdvise RPC to sys/fs/nfsclient..
Add support for the NFSv4.2 IOAdvise RPC to sys/fs/nfsclient.
Mon, Nov 12, 12:42 AM
rmacklem committed rS340356: Add NFSv4.2 client support for VOP_ADVISE() to sys/fs/nfs. Changes to.
Add NFSv4.2 client support for VOP_ADVISE() to sys/fs/nfs. Changes to
Mon, Nov 12, 12:24 AM
rmacklem committed rS340355: Update the kernel to a current one from head..
Update the kernel to a current one from head.
Mon, Nov 12, 12:07 AM

Nov 9 2018

rmacklem added a comment to D17917: d_off support for multiple filesystems.

I can't seem to remember how to do inline comments (if I ever knew), so I'll stick it here...

Nov 9 2018, 11:33 PM

Nov 6 2018

rmacklem committed rS340207: Change nfs_advlock() so that the NFSVOPUNLOCK() is mostly done at the end..
Change nfs_advlock() so that the NFSVOPUNLOCK() is mostly done at the end.
Nov 6 2018, 10:51 PM
rmacklem closed D17853: recode nfs_advlock() so that it does "goto out" instead of many return()s. No semantic change..
Nov 6 2018, 10:51 PM
rmacklem added a comment to D17839: add a global file system mount option called "fsid" that overrides the file system's choice of fsid.

W.r.t. ZFS, I have no idea. It appears that it would need to be a temporary property, but I can't see how/where
those get added?

Nov 6 2018, 2:27 AM
rmacklem added a comment to D17853: recode nfs_advlock() so that it does "goto out" instead of many return()s. No semantic change..

nfs_dolock() is the front end for the NLM stuff, which I know nothing about.
I'll try emailing dfr@ and see if he can tell me what locking is required.
(You might have noticed that I don't have much use for the NLM;-)

Nov 6 2018, 2:03 AM
rmacklem created D17853: recode nfs_advlock() so that it does "goto out" instead of many return()s. No semantic change..
Nov 6 2018, 12:41 AM

Nov 5 2018

rmacklem added a comment to D17839: add a global file system mount option called "fsid" that overrides the file system's choice of fsid.

Added an inline comment.

Nov 5 2018, 1:45 AM
rmacklem added a comment to D17839: add a global file system mount option called "fsid" that overrides the file system's choice of fsid.

Added two inline comments.

Nov 5 2018, 12:06 AM

Nov 4 2018

rmacklem created D17839: add a global file system mount option called "fsid" that overrides the file system's choice of fsid.
Nov 4 2018, 11:38 PM

Nov 1 2018

rmacklem committed rS339999: Fix NFS client vnode locking to avoid a crash during forced dismount..
Fix NFS client vnode locking to avoid a crash during forced dismount.
Nov 1 2018, 3:27 PM
rmacklem closed D17757: fix NFS client advisory locking when a forced dismount is performed.
Nov 1 2018, 3:27 PM

Oct 31 2018

rmacklem added a comment to D17757: fix NFS client advisory locking when a forced dismount is performed.

Hmm, not sure. If you look at the code near the end of nfs_advlock() { around line#3100-3120 in head's sys/fs/nfsclient/nfs_clvnops.c } that isn't really
shown in the patch, then where the vnode gets VOP_UNLOCK()'d gets more convoluted. Such as before the lf_advlock() call.
I could do an errout: case so that many of the VOP_UNLOCK(); return(X); cases could become error = X; goto errout; but I'm not sure that
makes the code more readable.
If you think it does make it more readable, let me know and I'll change it.
{ Some like single return points and others don't like goto's. I have no strong opinion w.r.t. this. }

Oct 31 2018, 3:27 AM

Oct 30 2018

rmacklem created D17757: fix NFS client advisory locking when a forced dismount is performed.
Oct 30 2018, 12:19 AM

Oct 9 2018

rmacklem committed rS339247: Fix the pNFS server's reporting of disk space usage for the "#<path>" case..
Fix the pNFS server's reporting of disk space usage for the "#<path>" case.
Oct 9 2018, 1:11 AM

Sep 24 2018

rmacklem committed rS338900: Add a sanity check for v_type == VREG to the NFSv4.2 IO Advise operation..
Add a sanity check for v_type == VREG to the NFSv4.2 IO Advise operation.
Sep 24 2018, 12:54 AM

Sep 23 2018

rmacklem committed rS338895: Add the IO Advise operation to the NFSv4.2 server. At this time, it only.
Add the IO Advise operation to the NFSv4.2 server. At this time, it only
Sep 23 2018, 2:17 AM

Sep 20 2018

rmacklem committed rS338817: Add the Layout stats operation to the NFSv4.2 server..
Add the Layout stats operation to the NFSv4.2 server.
Sep 20 2018, 12:27 AM

Sep 19 2018

rmacklem committed rS338812: Add the Layout Error operation to the NFSv4.2. server..
Add the Layout Error operation to the NFSv4.2. server.
Sep 19 2018, 10:39 PM

Sep 17 2018

rmacklem committed rS338706: Add the basic support for NFSv4.2 to the client and server..
Add the basic support for NFSv4.2 to the client and server.
Sep 17 2018, 1:00 AM
rmacklem committed rS338705: Create a project area for adding NFSv4.2 support to the NFS client and server..
Create a project area for adding NFSv4.2 support to the NFS client and server.
Sep 17 2018, 12:36 AM
rmacklem committed rS338704: Delete this project source tree since the up to date sources are now in.
Delete this project source tree since the up to date sources are now in
Sep 17 2018, 12:27 AM
rmacklem committed rS338703: Delete this projects tree, since the up to date code is now in head/current..
Delete this projects tree, since the up to date code is now in head/current.
Sep 17 2018, 12:16 AM

Aug 27 2018

rmacklem committed rS338339: Add notice that this source tree is no longer being maintained..
Add notice that this source tree is no longer being maintained.
Aug 27 2018, 1:03 PM
rmacklem committed rS338338: Add deprecation notice. This code is now maintained in head/current..
Add deprecation notice. This code is now maintained in head/current.
Aug 27 2018, 12:35 PM

Aug 24 2018

rmacklem committed rS338308: MFC: r337438.
MFC: r337438
Aug 24 2018, 10:48 PM
rmacklem committed rS338307: MFC: r337438.
MFC: r337438
Aug 24 2018, 10:41 PM

Aug 23 2018

rmacklem committed rS338217: Fix the nfsuserd.8 man page for the changes made to support uid/gid.
Fix the nfsuserd.8 man page for the changes made to support uid/gid
Aug 23 2018, 12:05 AM

Aug 22 2018

rmacklem committed rS338193: Revert r320758, which was the man page update for r320757 just reverted..
Revert r320758, which was the man page update for r320757 just reverted.
Aug 22 2018, 12:26 PM
rmacklem committed rS338192: Revert r320757 since it can cause "excl->shared" panics..
Revert r320757 since it can cause "excl->shared" panics.
Aug 22 2018, 12:20 PM

Aug 21 2018

rmacklem committed rS338132: MFC: r336839.
MFC: r336839
Aug 21 2018, 11:17 AM
rmacklem committed rS338131: MFC: r336839.
MFC: r336839
Aug 21 2018, 11:11 AM

Aug 18 2018

rmacklem committed rS338019: Fix LORs between vn_start_write() and vn_lock() in nfsrv_copymr()..
Fix LORs between vn_start_write() and vn_lock() in nfsrv_copymr().
Aug 18 2018, 7:14 PM

Aug 17 2018

rmacklem committed rS337990: Fix LORs between vn_start_write() and vn_lock() in the pNFS server..
Fix LORs between vn_start_write() and vn_lock() in the pNFS server.
Aug 17 2018, 9:12 PM
rmacklem committed rS337962: Don't set a file's size for the MDS file of a pNFS service..
Don't set a file's size for the MDS file of a pNFS service.
Aug 17 2018, 12:32 PM

Aug 9 2018

rmacklem committed rS337509: Fix a typo plus add a couple of sentences to pnfsserver.4..
Fix a typo plus add a couple of sentences to pnfsserver.4.
Aug 9 2018, 12:15 AM

Aug 8 2018

rmacklem committed rS337502: Fix the err() arguments for a nfssvc(8) failure..
Fix the err() arguments for a nfssvc(8) failure.
Aug 8 2018, 8:30 PM
rmacklem committed rS337501: Assorted fixes to handling of LayoutRecall callbacks, mostly error handling..
Assorted fixes to handling of LayoutRecall callbacks, mostly error handling.
Aug 8 2018, 8:21 PM

Aug 7 2018

rmacklem committed rS337438: Allow newnfs_request() to retry all callback RPCs with an NFSERR_DELAY reply..
Allow newnfs_request() to retry all callback RPCs with an NFSERR_DELAY reply.
Aug 7 2018, 9:29 PM

Aug 5 2018

rmacklem committed rS337363: Add a reference to pnfsserver.4 to the nfsd.8 man page..
Add a reference to pnfsserver.4 to the nfsd.8 man page.
Aug 5 2018, 8:37 PM
rmacklem committed rS337362: Update the pnfs.4 man page to reference the pnfsserver.4 man page..
Update the pnfs.4 man page to reference the pnfsserver.4 man page.
Aug 5 2018, 8:20 PM
rmacklem committed rS337361: Add pnfsserver.4 to the Makefile for nfsd..
Add pnfsserver.4 to the Makefile for nfsd.
Aug 5 2018, 8:15 PM
rmacklem committed rS337360: Add a man page that describes the setup of a pNFS service..
Add a man page that describes the setup of a pNFS service.
Aug 5 2018, 8:14 PM
rmacklem committed rS337357: Copy all bits of a file handle in case there is padding in the structure..
Copy all bits of a file handle in case there is padding in the structure.
Aug 5 2018, 7:22 PM

Aug 2 2018

rmacklem committed rS337170: Silence newer gcc warnings..
Silence newer gcc warnings.
Aug 2 2018, 8:11 PM
rmacklem committed rS337064: MFC: r336357.
MFC: r336357
Aug 2 2018, 3:14 AM

Aug 1 2018

rmacklem committed rS337058: MFC: r336357.
MFC: r336357
Aug 1 2018, 7:25 PM

Jul 31 2018

rmacklem committed rS337006: MFC: r336215.
MFC: r336215
Jul 31 2018, 9:02 PM
rmacklem committed rS337005: MFC: r336215.
MFC: r336215
Jul 31 2018, 8:57 PM

Jul 30 2018

rmacklem committed rS336933: Silence newer gcc warnings..
Silence newer gcc warnings.
Jul 30 2018, 8:25 PM
rmacklem committed rS336928: MFC: r335866.
MFC: r335866
Jul 30 2018, 7:29 PM
rmacklem committed rS336927: MFC: r335866.
MFC: r335866
Jul 30 2018, 7:24 PM
rmacklem committed rS336899: MFC: r334966.
MFC: r334966
Jul 30 2018, 12:17 PM
rmacklem committed rS336898: MFC: r334966.
MFC: r334966
Jul 30 2018, 12:10 PM

Jul 29 2018

rmacklem committed rS336878: Silence newer gcc warnings..
Silence newer gcc warnings.
Jul 29 2018, 9:51 PM

Jul 28 2018

rmacklem committed rS336846: MFC: r334492.
MFC: r334492
Jul 28 2018, 8:38 PM
rmacklem committed rS336842: MFC: r334492.
MFC: r334492
Jul 28 2018, 8:29 PM
rmacklem committed rS336839: Modify the NFSv4.1 server so that it allows ReclaimComplete as done by ESXi 6.7..
Modify the NFSv4.1 server so that it allows ReclaimComplete as done by ESXi 6.7.
Jul 28 2018, 8:21 PM

Jul 27 2018

rmacklem committed rS336798: Update nfsd.8 for support of IPv6 addresses for hosts in the "-p" option..
Update nfsd.8 for support of IPv6 addresses for hosts in the "-p" option.
Jul 27 2018, 11:38 PM
rmacklem committed rS336797: When parsing the "-p" option for nfsd, only use an IPv6 link local address.
When parsing the "-p" option for nfsd, only use an IPv6 link local address
Jul 27 2018, 11:34 PM
rmacklem committed rS336795: Add support for IPv6 addresses to the pNFS "-p" option..
Add support for IPv6 addresses to the pNFS "-p" option.
Jul 27 2018, 11:10 PM

Jul 21 2018

rmacklem committed rS336573: Set CLSET_TIMEOUT on TCP connections to pNFS DSs..
Set CLSET_TIMEOUT on TCP connections to pNFS DSs.
Jul 21 2018, 1:33 AM

Jul 20 2018

rmacklem committed rS336544: Update the comments and add a sysctl to set the retry limit for connections.
Update the comments and add a sysctl to set the retry limit for connections
Jul 20 2018, 12:38 PM
rmacklem committed rS336543: Update the krpc code to what is in head/current..
Update the krpc code to what is in head/current.
Jul 20 2018, 12:32 PM
rmacklem committed rS336542: Set SO_SNDTIMEO in the client side krpc when CLSET_TIMEOUT is done..
Set SO_SNDTIMEO in the client side krpc when CLSET_TIMEOUT is done.
Jul 20 2018, 12:03 PM
rmacklem closed D16293: when CLSET_TIMEOUT is used, set timeouts for sosend() and soconnect() in the krpc.
Jul 20 2018, 12:03 PM
rmacklem updated the diff for D16293: when CLSET_TIMEOUT is used, set timeouts for sosend() and soconnect() in the krpc.

I just ran a test without the timeout in the loop waiting for a connection
attempt and the time it took for a failover was only 1minute more than
with that patch.

Jul 20 2018, 1:50 AM

Jul 19 2018

rmacklem added a comment to D16293: when CLSET_TIMEOUT is used, set timeouts for sosend() and soconnect() in the krpc.

The problem is that, without the "timeout" it takes too long for the msleep() to wake up.
The "timeout" or whatever you prefer to call it is meant to set the upper bound on the
time that this loop waits for a TCP connection to complete to approximately
tv.tv_sec (the same timeout as set for SO_SNDTIMEO).

Jul 19 2018, 11:24 PM
rmacklem committed rS336518: MFC: r333766.
MFC: r333766
Jul 19 2018, 9:07 PM
rmacklem committed rS336516: MFC: r333766.
MFC: r333766
Jul 19 2018, 8:59 PM
rmacklem updated the diff for D16293: when CLSET_TIMEOUT is used, set timeouts for sosend() and soconnect() in the krpc.

Added comments as kib@ suggested and used tvtohz(), so that tv_usec component is included in timeout.
(I have emailed kib@ one that uses the 1sec timeout and I put that here if he prefers that one.)

Jul 19 2018, 12:22 PM
rmacklem added a comment to D16293: when CLSET_TIMEOUT is used, set timeouts for sosend() and soconnect() in the krpc.

I commented inline. I'll admit I don't see spurious wakeup()s will be a problem.
I can (actually already have for the patch I have) include the tv_usec field in
the timeout calculation.
(I'll admit I get nervous fooling with things like time_uptime, which can go
negative in 2038 and assorted things related to overflow.)

Jul 19 2018, 12:04 AM

Jul 18 2018

rmacklem added a comment to D16293: when CLSET_TIMEOUT is used, set timeouts for sosend() and soconnect() in the krpc.

Explained inline, but basically timeouts at both places count as one retry
and the RPC attempt fails when the limit on these retries is reached,
so it seems to me that they should be the same amount of time?

Jul 18 2018, 12:31 PM

Jul 17 2018

rmacklem added a comment to D16293: when CLSET_TIMEOUT is used, set timeouts for sosend() and soconnect() in the krpc.

I added an inline comment which was basically that I didn't think a timeout of a fraction
of 1sec or setting a timeout of greater than 1sec resolution would be useful.
(My assumption is that normal operation against a slow server could result
in delays of 1sec.)

Jul 17 2018, 10:10 PM
rmacklem committed rS336422: MFC: r333645.
MFC: r333645
Jul 17 2018, 7:26 PM
rmacklem committed rS336421: MFC: r333645.
MFC: r333645
Jul 17 2018, 7:10 PM
rmacklem committed rS336413: Update the NFS server code with recent changes in head for handling.
Update the NFS server code with recent changes in head for handling
Jul 17 2018, 12:13 PM

Jul 16 2018

rmacklem committed rS336357: Modify the reasons for not issuing a delegation in the NFSv4.1 server..
Modify the reasons for not issuing a delegation in the NFSv4.1 server.
Jul 16 2018, 9:32 PM
rmacklem created D16293: when CLSET_TIMEOUT is used, set timeouts for sosend() and soconnect() in the krpc.
Jul 16 2018, 8:54 PM

Jul 15 2018

rmacklem committed rS336312: Shut down the TCP connection to a DS in the pNFS client when Renew fails..
Shut down the TCP connection to a DS in the pNFS client when Renew fails.
Jul 15 2018, 6:55 PM

Jul 14 2018

rmacklem committed rS336296: Add a comment explaining why the timeout for DS connections is set to.
Add a comment explaining why the timeout for DS connections is set to
Jul 14 2018, 8:44 PM
rmacklem committed rS336295: Add code to the pNFS client so that it shuts down a TCP connection to a.
Add code to the pNFS client so that it shuts down a TCP connection to a
Jul 14 2018, 8:39 PM
rmacklem committed rS336292: Fix the pNFS client when mirrors aren't on the same machine..
Fix the pNFS client when mirrors aren't on the same machine.
Jul 14 2018, 7:52 PM
rmacklem committed rS336277: Set CLSET_TIMEOUT() on a TCP connection to a DS to lease_duration/4..
Set CLSET_TIMEOUT() on a TCP connection to a DS to lease_duration/4.
Jul 14 2018, 1:45 PM
rmacklem committed rS336276: Add a timeout to the msleep() waiting for a socket connection for the pNFS.
Add a timeout to the msleep() waiting for a socket connection for the pNFS
Jul 14 2018, 1:39 PM

Jul 13 2018

rmacklem committed rS336260: Close down the TCP connection to a pNFS DS when it is disabled..
Close down the TCP connection to a pNFS DS when it is disabled.
Jul 13 2018, 8:03 PM
rmacklem committed rS336239: Change the pNFS client so that it does not report an NFSERR_STALE from.
Change the pNFS client so that it does not report an NFSERR_STALE from
Jul 13 2018, 12:39 PM

Jul 12 2018

rmacklem committed rS336234: MFC: r333579.
MFC: r333579
Jul 12 2018, 10:59 PM