Page MenuHomeFreeBSD

rmacklem (Rick Macklem)
User

Projects

User Details

User Since
Jan 13 2015, 10:58 PM (281 w, 1 h)

Recent Activity

Yesterday

rmacklem committed rS361711: Fix build issue introduced by r361699..
Fix build issue introduced by r361699.
Tue, Jun 2, 12:03 AM

Mon, Jun 1

rmacklem requested review of D25088: fix export_args flags field to be 64bits and handle more than 16 groups for the mapped user.
Mon, Jun 1, 3:21 AM
rmacklem accepted D25077: tmpfs: Preserve alignment of struct fid fields.

Looks fine to me, too.
I assume this fixes your crashes, good work.

Mon, Jun 1, 2:33 AM

Sun, May 31

rmacklem committed rS361682: Oops, I didn't notice the "cd" is needed for each install line..
Oops, I didn't notice the "cd" is needed for each install line.
Sun, May 31, 10:46 PM
rmacklem committed rS361679: Update the Makefile to copy rpcsec_tls.h to /usr/include/rpc..
Update the Makefile to copy rpcsec_tls.h to /usr/include/rpc.
Sun, May 31, 10:15 PM
rmacklem committed rS361659: Update rpcsec_tls.h to the one just added to head/current..
Update rpcsec_tls.h to the one just added to head/current.
Sun, May 31, 3:44 AM
rmacklem committed rS361658: Add the .h file that describes the operations for the rpctls_syscall..
Add the .h file that describes the operations for the rpctls_syscall.
Sun, May 31, 1:13 AM
rmacklem accepted D25045: Assign default security flavor when converting old export args.

Looks fine to me.

Sun, May 31, 12:50 AM

Fri, May 29

rmacklem committed rS361614: Oops two, missed syscall.mk as well..
Oops two, missed syscall.mk as well.
Fri, May 29, 12:10 AM

Thu, May 28

rmacklem committed rS361610: Oops, missed syscall.h and sysproto.h for r361602..
Oops, missed syscall.h and sysproto.h for r361602.
Thu, May 28, 11:58 PM
rmacklem committed rS361603: Add an entry to Symbol.map for the rpctls_syscall added by r361599..
Add an entry to Symbol.map for the rpctls_syscall added by r361599.
Thu, May 28, 9:26 PM
rmacklem committed rS361602: Update the files created from the new syscalls.master from r361599..
Update the files created from the new syscalls.master from r361599.
Thu, May 28, 9:23 PM
rmacklem committed rS361599: Add a syscall for the nfs-over-tls daemons to use..
Add a syscall for the nfs-over-tls daemons to use.
Thu, May 28, 9:06 PM
rmacklem updated the diff for D24949: add syscall for the nfs-over-tls daemons to use.

Modified compat/freebsd32/syscalls.master entry
as suggested by brooks@.
It worked and did not create a proto entry.

Thu, May 28, 1:43 AM

Wed, May 27

rmacklem committed rS361567: Fix sosend() for the case where mbufs are passed in while doing ktls..
Fix sosend() for the case where mbufs are passed in while doing ktls.
Wed, May 27, 11:21 PM
rmacklem added a reviewer for D24674: fix sosend() so that it can handle an mbuf list for KTLS: glebius.
Wed, May 27, 12:40 AM

Mon, May 25

rmacklem committed rS361470: To enable building a kernel without having the rest of /usr/src around,.
To enable building a kernel without having the rest of /usr/src around,
Mon, May 25, 8:07 PM

Sun, May 24

rmacklem resigned from D24977: Make NFS address selection use fib4_lookup()..

Sorry, I know nothing about this stuff, so I can't review it.
(This code has been written by others, possibly long ago.)

Sun, May 24, 12:44 AM

Sat, May 23

rmacklem committed rS361428: Fix a few problems caused during the code merge of the up-to-date head kernel..
Fix a few problems caused during the code merge of the up-to-date head kernel.
Sat, May 23, 11:38 PM
rmacklem committed rS361417: Fix one case of an ext_pgs mbuf change that I missed..
Fix one case of an ext_pgs mbuf change that I missed.
Sat, May 23, 4:43 PM
rmacklem committed rS361416: Merge in an up-to-date kernel from head and make the changes.
Merge in an up-to-date kernel from head and make the changes
Sat, May 23, 3:50 PM
rmacklem updated the diff for D24949: add syscall for the nfs-over-tls daemons to use.

Oops, forgot to "make sysent" before testing the last one.
Since the entry on compat/freebsd32/syscalls.master is NOSTD,
I needed to prepend "freebsd_" to the prototype name to
avoid a conflict.

Sat, May 23, 2:43 PM
rmacklem updated the diff for D24949: add syscall for the nfs-over-tls daemons to use.

Removed the blank line from syscalls.master and
added the definition to compat/freebsd32/syscalls.master,
as suggested by brooks@.

Sat, May 23, 12:14 AM

Thu, May 21

rmacklem requested review of D24949: add syscall for the nfs-over-tls daemons to use.
Thu, May 21, 11:45 PM

Wed, May 20

rmacklem committed rS361308: Fix the daemons so that they use the preferred calls for openssl3.
Fix the daemons so that they use the preferred calls for openssl3
Wed, May 20, 11:19 PM
rmacklem committed rS361270: Modify the client side non-application data record upcall so that it is.
Modify the client side non-application data record upcall so that it is
Wed, May 20, 1:26 AM

Tue, May 19

rmacklem committed rS361233: Fix the daemons so that they do not terminate upon SIGPIPE..
Fix the daemons so that they do not terminate upon SIGPIPE.
Tue, May 19, 1:32 AM

Mon, May 18

rmacklem committed rS361146: Add a function nfsm_set() to initialize "struct nfsrv_descript" for building.
Add a function nfsm_set() to initialize "struct nfsrv_descript" for building
Mon, May 18, 12:08 AM

Sun, May 17

rmacklem committed rS361144: Assorted error handling fixups plus a fix for client side handling of.
Assorted error handling fixups plus a fix for client side handling of
Sun, May 17, 10:05 PM
rmacklem committed rS361141: Separate errors doing the rpctlscd/rpctlssd upcalls from RPC errors..
Separate errors doing the rpctlscd/rpctlssd upcalls from RPC errors.
Sun, May 17, 8:37 PM

Sat, May 16

rmacklem committed rS361119: Make nfsm_set() a void function, since the return value is no longer used..
Make nfsm_set() a void function, since the return value is no longer used.
Sat, May 16, 11:25 PM
rmacklem committed rS361101: Add support for doing upcalls to the rpctlscd daemon to the krpc client.
Add support for doing upcalls to the rpctlscd daemon to the krpc client
Sat, May 16, 2:43 AM
rmacklem committed rS361100: Add fdrop()s to the rpctls syscall for the "fp" reference..
Add fdrop()s to the rpctls syscall for the "fp" reference.
Sat, May 16, 2:35 AM

Thu, May 14

rmacklem committed rS361062: Add code that does upcalls to the daemons when an non-application data record.
Add code that does upcalls to the daemons when an non-application data record
Thu, May 14, 9:46 PM

Wed, May 13

rmacklem committed rS360997: Get rid of the changes done to the krpc and xdr for dissecting ext_pgs mbufs..
Get rid of the changes done to the krpc and xdr for dissecting ext_pgs mbufs.
Wed, May 13, 12:03 AM

Tue, May 12

rmacklem committed rS360994: Get rid of two fields that were only used for dissecting ext_pgs mbufs..
Get rid of two fields that were only used for dissecting ext_pgs mbufs.
Tue, May 12, 11:33 PM
rmacklem accepted D24811: nfs: Remove APPLESTATIC macro.

Sure. Actually I thought of mentioning this when you got
rid of the #ifdef APPLE junk, but figured you'd be tired of
large but trivial edits.

Tue, May 12, 2:55 AM
rmacklem committed rS360949: Revert one more change that was done to handle dissection of ext_pgs mbufs..
Revert one more change that was done to handle dissection of ext_pgs mbufs.
Tue, May 12, 1:23 AM
rmacklem committed rS360945: Get rid of some more of the dissect code for ext_pgs mbufs..
Get rid of some more of the dissect code for ext_pgs mbufs.
Tue, May 12, 12:37 AM

Mon, May 11

rmacklem added a comment to D24628: Add support for KTLS RX via software decryption..

Comments inline. Mostly questions.

Mon, May 11, 3:13 PM

Sun, May 10

rmacklem accepted D24753: vfs_exports: Tighten bounds and assert consistency of numsecflavors.
Sun, May 10, 10:18 PM
rmacklem committed rS360884: Simplify nfsm_set() so that it does not do the dissect case..
Simplify nfsm_set() so that it does not do the dissect case.
Sun, May 10, 9:37 PM
rmacklem committed rS360883: Revert some of the code for dissecting the ext_pgs mbufs, since it is.
Revert some of the code for dissecting the ext_pgs mbufs, since it is
Sun, May 10, 8:45 PM
rmacklem added a comment to D24753: vfs_exports: Tighten bounds and assert consistency of numsecflavors.

After you have updated your patch, I'll look again.
Thanks for doing this, rick

Sun, May 10, 12:40 AM
rmacklem committed rS360861: Update the nfs-over-tls-setup.txt document slightly..
Update the nfs-over-tls-setup.txt document slightly.
Sun, May 10, 12:28 AM
rmacklem committed rS360860: Modify ktls_decrypt() slightly, so that a small iov is allocated on.
Modify ktls_decrypt() slightly, so that a small iov is allocated on
Sun, May 10, 12:24 AM
rmacklem committed rS360859: Add some very basic handling of TLS_GET_RECORD control mbufs..
Add some very basic handling of TLS_GET_RECORD control mbufs.
Sun, May 10, 12:17 AM

Sat, May 9

rmacklem committed rS360858: Add some very basic handling of TLS_GET_RECORD control mbufs for the.
Add some very basic handling of TLS_GET_RECORD control mbufs for the
Sat, May 9, 11:56 PM
rmacklem committed rS360832: Make both rpctlssd and rpctlscd load the ktls_ocf module, as required..
Make both rpctlssd and rpctlscd load the ktls_ocf module, as required.
Sat, May 9, 1:48 AM
rmacklem committed rS360831: Update krpc.h as needed for the new clnt_vc_soupcall() just committed..
Update krpc.h as needed for the new clnt_vc_soupcall() just committed.
Sat, May 9, 1:34 AM
rmacklem committed rS360830: Rewrite clnt_vc_soupcall() so that it does soreceive() for an.
Rewrite clnt_vc_soupcall() so that it does soreceive() for an
Sat, May 9, 1:19 AM

Fri, May 8

rmacklem accepted D24752: Remove APPLEKEXT ifdefs.

Yes, they are useless.
(As an historic note, long ago there was a Mac OS/X port, where the code
was built as a module and these #ifdef's were used for that.)

Fri, May 8, 12:59 AM

Wed, May 6

rmacklem committed rS360720: Update nfs-over-tls-setup.txt..
Update nfs-over-tls-setup.txt.
Wed, May 6, 11:04 PM
rmacklem committed rS360719: Get rid of MYTEST and modify GENERIC, so that builds are easier for testers..
Get rid of MYTEST and modify GENERIC, so that builds are easier for testers.
Wed, May 6, 10:52 PM
rmacklem committed rS360680: Do not do SSL_shutdown() for now, since it can cause crashes..
Do not do SSL_shutdown() for now, since it can cause crashes.
Wed, May 6, 1:47 AM
rmacklem committed rS360678: Delete unused function newnfs_trimleading..
Delete unused function newnfs_trimleading.
Wed, May 6, 12:44 AM

Tue, May 5

rmacklem added inline comments to D24628: Add support for KTLS RX via software decryption..
Tue, May 5, 12:15 PM
rmacklem added inline comments to D24628: Add support for KTLS RX via software decryption..
Tue, May 5, 4:52 AM
rmacklem added a comment to D24628: Add support for KTLS RX via software decryption..

I just made another inline comment. It looks like SOCKBUF_LOCK(sb) gets called
twice in the if (error) { } block?

Tue, May 5, 3:11 AM
rmacklem added a comment to D24628: Add support for KTLS RX via software decryption..

I haven't looked at the patch in detail (and I'm far from an expert in this
area). However, the overall approach sounds fine to me and I have only
found the one little problem (leak of malloc'd "iov" in ktls_decrypt())
during testing sofar. (See inline comment above.)

Tue, May 5, 1:23 AM
rmacklem committed rS360650: Revert r360514, to avoid unnecessary churn of the sources..
Revert r360514, to avoid unnecessary churn of the sources.
Tue, May 5, 12:58 AM
rmacklem committed rS360649: Put a copy of nfs-over-tls-setup.txt here..
Put a copy of nfs-over-tls-setup.txt here.
Tue, May 5, 12:08 AM

Mon, May 4

rmacklem committed rS360647: Fix a leak in ktls_decrypt()..
Fix a leak in ktls_decrypt().
Mon, May 4, 11:53 PM
rmacklem committed rS360646: Replace openssl3.patch with a slightly cleaner one..
Replace openssl3.patch with a slightly cleaner one.
Mon, May 4, 11:49 PM

May 3 2020

rmacklem committed rS360616: Add a little function to acquire the ktls sysctls..
Add a little function to acquire the ktls sysctls.
May 3 2020, 11:15 PM
rmacklem committed rS360615: Fix handling of ktls not enabled in the daemons..
Fix handling of ktls not enabled in the daemons.
May 3 2020, 10:00 PM
rmacklem committed rS360589: Add the patch file for /usr/ktls/include/openssl..
Add the patch file for /usr/ktls/include/openssl.
May 3 2020, 2:23 AM
rmacklem committed rS360588: Get rid of mountd subdirectory that I somehow created..
Get rid of mountd subdirectory that I somehow created.
May 3 2020, 1:23 AM
rmacklem committed rS360587: Clear out all the cruft I created under usr.sbin, so that only the.
Clear out all the cruft I created under usr.sbin, so that only the
May 3 2020, 1:21 AM
rmacklem committed rS360586: Disable the code that copied received mbufs to ext_pgs mbufs..
Disable the code that copied received mbufs to ext_pgs mbufs.
May 3 2020, 1:05 AM
rmacklem committed rS360585: Add the kernel config I use, which includes "options KERN_TLS", plus.
Add the kernel config I use, which includes "options KERN_TLS", plus
May 3 2020, 12:51 AM
rmacklem committed rS360584: Add jhb@'s ktls rx patch to the kernel..
Add jhb@'s ktls rx patch to the kernel.
May 3 2020, 12:46 AM
rmacklem committed rS360580: Fix the daemons so they actually work with jhb@'s patched openssl3..
Fix the daemons so they actually work with jhb@'s patched openssl3.
May 3 2020, 12:15 AM

May 1 2020

rmacklem committed rS360556: MFC: r360032.
MFC: r360032
May 1 2020, 11:07 PM
rmacklem committed rS360555: MFC: r360032.
MFC: r360032
May 1 2020, 10:37 PM
rmacklem committed rS360518: Modify nfsm_copyfrommbuf() so that it calls nfsm_copfrommbuf_extpgs() for.
Modify nfsm_copyfrommbuf() so that it calls nfsm_copfrommbuf_extpgs() for
May 1 2020, 1:30 AM
rmacklem committed rS360514: Factor some code out of nfsm_dissct() into separate functions..
Factor some code out of nfsm_dissct() into separate functions.
May 1 2020, 12:36 AM

Apr 30 2020

rmacklem committed rS360487: Merge in an up to date kernel from head..
Merge in an up to date kernel from head.
Apr 30 2020, 3:59 AM

Apr 28 2020

rmacklem committed rS360426: Merge in the recent change to replace the Mac OS/X uio_XX macros from head..
Merge in the recent change to replace the Mac OS/X uio_XX macros from head.
Apr 28 2020, 2:14 AM
rmacklem committed rS360424: Get rid of uio_XXX macros used for the Mac OS/X port..
Get rid of uio_XXX macros used for the Mac OS/X port.
Apr 28 2020, 2:11 AM
rmacklem committed rS360419: Merge in an up to date kernel from head..
Merge in an up to date kernel from head.
Apr 28 2020, 12:44 AM

Apr 27 2020

rmacklem committed rS360416: Fix sosend_generic() so that it can handle a list of ext_pgs mbufs..
Fix sosend_generic() so that it can handle a list of ext_pgs mbufs.
Apr 27 2020, 11:55 PM

Apr 25 2020

rmacklem committed rS360324: Fix the krpc.ko build..
Fix the krpc.ko build.
Apr 25 2020, 9:41 PM
rmacklem committed rS360289: Remove Mac OS/X macros that did nothing for FreeBSD..
Remove Mac OS/X macros that did nothing for FreeBSD.
Apr 25 2020, 2:19 AM

Apr 24 2020

rmacklem created D24568: fix sosend_generic() so that it can handle a list of ext_pgs mbufs post r359919.
Apr 24 2020, 11:51 PM
rmacklem committed rS360264: Make the code work with post-r359919 ext_pgs mbufs..
Make the code work with post-r359919 ext_pgs mbufs.
Apr 24 2020, 2:55 PM

Apr 23 2020

rmacklem committed rS360216: Fix the updated kernel so that it will build post-r359919..
Fix the updated kernel so that it will build post-r359919.
Apr 23 2020, 4:59 AM

Apr 22 2020

rmacklem committed rS360212: Merge in an up to date kernel from head..
Merge in an up to date kernel from head.
Apr 22 2020, 11:57 PM
rmacklem committed rS360208: MFC: r359720.
MFC: r359720
Apr 22 2020, 9:15 PM
rmacklem committed rS360207: MFC: r359720.
MFC: r359720
Apr 22 2020, 9:08 PM
rmacklem committed rS360205: Make the NFSv4.n client's recovery from NFSERR_BADSESSION RFC5661 conformant..
Make the NFSv4.n client's recovery from NFSERR_BADSESSION RFC5661 conformant.
Apr 22 2020, 9:00 PM

Apr 21 2020

rmacklem committed rS360142: MFC: r359679.
MFC: r359679
Apr 21 2020, 5:00 AM
rmacklem committed rS360141: MFC: r359679.
MFC: r359679
Apr 21 2020, 4:47 AM

Apr 20 2020

rmacklem committed rS360110: MFC: r359643.
MFC: r359643
Apr 20 2020, 1:26 AM
rmacklem committed rS360109: MFC: r359643.
MFC: r359643
Apr 20 2020, 1:17 AM

Apr 18 2020

rmacklem committed rS360081: Change the type of "len" to avoid warnings..
Change the type of "len" to avoid warnings.
Apr 18 2020, 11:47 PM

Apr 17 2020

rmacklem committed rS360056: Replace all occurrences of mbuf_t with "struct mbuf *"..
Replace all occurrences of mbuf_t with "struct mbuf *".
Apr 17 2020, 9:34 PM
rmacklem committed rS360055: Replace all instances of the typedef mbuf_t with "struct mbuf *"..
Replace all instances of the typedef mbuf_t with "struct mbuf *".
Apr 17 2020, 9:18 PM
rmacklem committed rS360032: Add a sanity check for nes_numsecflavor to the NFS server..
Add a sanity check for nes_numsecflavor to the NFS server.
Apr 17 2020, 2:21 AM
rmacklem accepted D24408: ZFS should depend on XDR, not full RPC.

This looks fine to me.

Apr 17 2020, 12:02 AM