rmacklem (Rick Macklem)
User

Projects

User Details

User Since
Jan 13 2015, 10:58 PM (157 w, 1 d)

Recent Activity

Mon, Dec 25

rmacklem added a comment to D10385: Remove many write-only variables from kernel.

The ones for nfs look ok. (I have not reviewed the rest of them.)
I would suggest that they be done as separate commits.

Mon, Dec 25, 1:08 PM

Tue, Dec 19

rmacklem committed rS327008: MFC: r326544.
MFC: r326544
Tue, Dec 19, 11:00 PM
rmacklem committed rS327002: Merge in an up to date kernel from head..
Merge in an up to date kernel from head.
Tue, Dec 19, 10:09 PM

Dec 18 2017

rmacklem committed rS326952: MFC: r326544.
MFC: r326544
Dec 18 2017, 10:55 PM

Dec 9 2017

rmacklem committed rS326735: Define macros used by the pNFS server code..
Define macros used by the pNFS server code.
Dec 9 2017, 9:05 PM

Dec 6 2017

rmacklem added a comment to D13223: Factorize code by using struct sockaddr_storage to handle both ipv6 and ipv4.

It looks ok to me, but I am not familiar enough with socket handling to
be sure doing this is ok. As such, I suspect it's fine, but won't actually
accept it. (Someone else already has accepted it.)

Dec 6 2017, 9:23 PM

Dec 4 2017

rmacklem committed rS326545: Merge in an up to date kernel from head..
Merge in an up to date kernel from head.
Dec 4 2017, 10:46 PM
rmacklem added a comment to D13327: Count write delegations so nfsrv_checkgetattr() can just return if the count is 0.

Adding a KASSERT() to check for correct lock acquisition when incrementing/decrementing
the counter is more awkward than it might seem.
The obvious place for such a check would be nfsrv_freedeleg(), which is where
this counter is decremented. Unfortunately this function is called during module
unload, when there are no nfsd threads and no locks held.
The locations where the counter is incremented are all in rather long chunks of
code that is updating state. Putting a KASSERT() at the beginning of these chunks
could be done, but would be almost silly, since the call would be right after the
code that acquires the locking.

Dec 4 2017, 10:23 PM
rmacklem committed rS326544: Avoid the overhead of acquiring a lock in nfsrv_checkgetattr() when.
Avoid the overhead of acquiring a lock in nfsrv_checkgetattr() when
Dec 4 2017, 9:50 PM
rmacklem closed D13327: Count write delegations so nfsrv_checkgetattr() can just return if the count is 0.
Dec 4 2017, 9:50 PM

Dec 2 2017

rmacklem updated the diff for D13327: Count write delegations so nfsrv_checkgetattr() can just return if the count is 0.

Modify the patch to not use atomic ops, which do not appear to be needed.

Dec 2 2017, 10:19 PM
rmacklem added a comment to D13327: Count write delegations so nfsrv_checkgetattr() can just return if the count is 0.

Add an inline comment related to nfsd thread locking.

Dec 2 2017, 9:31 PM
rmacklem added a comment to D13327: Count write delegations so nfsrv_checkgetattr() can just return if the count is 0.

Added inline reply to kib@'s comment.

Dec 2 2017, 1:40 PM

Dec 1 2017

rmacklem created D13327: Count write delegations so nfsrv_checkgetattr() can just return if the count is 0.
Dec 1 2017, 10:25 PM

Nov 11 2017

rmacklem committed rS325701: Update the pNFS project tree to a current head kernel..
Update the pNFS project tree to a current head kernel.
Nov 11 2017, 3:02 AM

Nov 9 2017

rmacklem committed rS325575: Add the recent commit to stable/11 (r325341) that fixes dumping of addresses.
Add the recent commit to stable/11 (r325341) that fixes dumping of addresses
Nov 9 2017, 11:47 AM

Nov 5 2017

rmacklem committed rS325448: MFC: r324639.
MFC: r324639
Nov 5 2017, 8:28 PM

Nov 4 2017

rmacklem committed rS325407: MFC: r324506.
MFC: r324506
Nov 4 2017, 9:30 PM

Nov 2 2017

rmacklem committed rS325341: MFC: r324639.
MFC: r324639
Nov 2 2017, 8:29 PM

Oct 25 2017

rmacklem committed rS324997: MFC: r324506.
MFC: r324506
Oct 25 2017, 7:27 PM

Oct 16 2017

rmacklem committed rS324678: Change the pNFS server to use the taskqueue code (common with the client).
Change the pNFS server to use the taskqueue code (common with the client)
Oct 16 2017, 11:43 PM
rmacklem committed rS324677: Merge in a current kernel from head..
Merge in a current kernel from head.
Oct 16 2017, 11:40 PM
rmacklem committed rS324676: Use taskqueue(9) to do writes/commits to mirrored DSs concurrently..
Use taskqueue(9) to do writes/commits to mirrored DSs concurrently.
Oct 16 2017, 11:28 PM
rmacklem closed D12632: pNFS client concurrent mirror I/O patch.
Oct 16 2017, 11:28 PM

Oct 15 2017

rmacklem committed rS324639: Fix the client IP address reported by nfsdumpstate for 64bit arch and NFSv4.1..
Fix the client IP address reported by nfsdumpstate for 64bit arch and NFSv4.1.
Oct 15 2017, 10:22 PM

Oct 11 2017

rmacklem committed rS324545: MFC: r324074.
MFC: r324074
Oct 11 2017, 11:42 PM
rmacklem committed rS324544: MFC: r323978.
MFC: r323978
Oct 11 2017, 11:34 PM
rmacklem committed rS324543: MFC: r323689.
MFC: r323689
Oct 11 2017, 11:21 PM
rmacklem committed rS324530: Update the stable11 pNFS client/server..
Update the stable11 pNFS client/server.
Oct 11 2017, 1:33 PM
rmacklem committed rS324529: MFC: r324074.
MFC: r324074
Oct 11 2017, 1:20 PM

Oct 10 2017

rmacklem updated the diff for D12632: pNFS client concurrent mirror I/O patch.

This variant of the patch sets the default # of threads to 8 * mp_ncpus instead of
a fixed 32. The sysctl allows a sysadmin to override this default.
Suggested by Julian Eischler.

Oct 10 2017, 10:47 PM
rmacklem committed rS324506: Fix forced dismount when a pNFS mount is hung on a DS..
Fix forced dismount when a pNFS mount is hung on a DS.
Oct 10 2017, 9:06 PM
rmacklem updated the diff for D12632: pNFS client concurrent mirror I/O patch.

The previous patch had a fundamental flaw, which was the code slept
waiting on completion of each RPC, serializing them.
This version of the patch doesn't sleep waiting for completion until
after all the RPCs have been started.

Oct 10 2017, 1:39 AM

Oct 9 2017

rmacklem created D12632: pNFS client concurrent mirror I/O patch.
Oct 9 2017, 8:15 PM

Oct 8 2017

rmacklem committed rS324419: MFC: r323978.
MFC: r323978
Oct 8 2017, 9:20 PM

Oct 5 2017

rmacklem committed rS324339: Fix the build after the merge from head by adding "0" args for nfscl_reqstart()..
Fix the build after the merge from head by adding "0" args for nfscl_reqstart().
Oct 5 2017, 9:37 PM
rmacklem committed rS324337: Merge a current head kernel with the Flexible File Layout client in it..
Merge a current head kernel with the Flexible File Layout client in it.
Oct 5 2017, 8:39 PM
rmacklem committed rS324336: Add Flex File Layout support to the NFSv4.1 pNFS client..
Add Flex File Layout support to the NFSv4.1 pNFS client.
Oct 5 2017, 8:10 PM

Oct 4 2017

rmacklem committed rS324289: Add a few definitions for the Flex File Layout..
Add a few definitions for the Flex File Layout.
Oct 4 2017, 10:55 PM
rmacklem accepted D12572: Various pathconf() fixes..

NFS part looks ok to me. (I might have used UINT32_MAX instead of 0xffffffff for NFS_MAX_LINK, but
that's a very minor nit..)

Oct 4 2017, 1:19 PM

Oct 3 2017

rmacklem accepted D12502: mountd: Convert exportlist to SLIST.

I've accepted this. As bapt@ noted, it loses the alphabetical order.
I don't know if that matters. I believe it means that the reply to
"showmount -e" will not be alphabetically ordered. Does any
client care? I don't know.

Oct 3 2017, 11:45 PM
rmacklem accepted D12504: mountd: Convert mountlist to SLIST.

Looks ok to me. I think the only effect is a change in the order of entries in the list
and I don't believe that matters.

Oct 3 2017, 11:39 PM

Oct 2 2017

rmacklem committed rS324183: Fix the pNFS Flex File Layout client so that it doesn't do LayoutCommit.
Fix the pNFS Flex File Layout client so that it doesn't do LayoutCommit
Oct 2 2017, 12:09 AM
rmacklem committed rS324182: Get rid of a bogus KASSERT() incorrectly copied to nfsrpc_writedsmir()..
Get rid of a bogus KASSERT() incorrectly copied to nfsrpc_writedsmir().
Oct 2 2017, 12:02 AM

Oct 1 2017

rmacklem committed rS324180: MFC: r323689.
MFC: r323689
Oct 1 2017, 9:45 PM

Sep 29 2017

rmacklem committed rS324111: Add support for Flex File Layout to the pNFS client structures..
Add support for Flex File Layout to the pNFS client structures.
Sep 29 2017, 11:13 PM

Sep 28 2017

rmacklem committed rS324091: Add the NFS client state flag that enables Flexible File Layout..
Add the NFS client state flag that enables Flexible File Layout.
Sep 28 2017, 11:05 PM
rmacklem committed rS324090: Change nfsv4_getipaddr() and nfsrpc_fillsa() to not use sockaddr_storage..
Change nfsv4_getipaddr() and nfsrpc_fillsa() to not use sockaddr_storage.
Sep 28 2017, 10:33 PM

Sep 27 2017

rmacklem committed rS324074: Fix a memory leak that occurred in the pNFS client..
Fix a memory leak that occurred in the pNFS client.
Sep 27 2017, 11:23 PM

Sep 26 2017

rmacklem committed rS324040: Add major and minor version arguments to nfscl_reqstart()..
Add major and minor version arguments to nfscl_reqstart().
Sep 26 2017, 11:42 PM
rmacklem committed rS324025: Add support for Flex File Layout to the client..
Add support for Flex File Layout to the client.
Sep 26 2017, 8:27 PM

Sep 24 2017

rmacklem committed rS323978: Change a panic to an error return..
Change a panic to an error return.
Sep 24 2017, 8:05 PM
rmacklem committed rS323974: Remove 0 filling from nfsm_uiombuflist()..
Remove 0 filling from nfsm_uiombuflist().
Sep 24 2017, 7:43 PM

Sep 21 2017

rmacklem committed rS323841: Add a few definitions for Flex File Layout for pNFS..
Add a few definitions for Flex File Layout for pNFS.
Sep 21 2017, 12:41 AM

Sep 19 2017

rmacklem committed rS323783: Make the nfsrpc_layoutget() function a static..
Make the nfsrpc_layoutget() function a static.
Sep 19 2017, 11:29 PM
rmacklem committed rS323780: Add a new function called nfsm_uiombuflist(), similar to nfsm_uiombuf()..
Add a new function called nfsm_uiombuflist(), similar to nfsm_uiombuf().
Sep 19 2017, 9:31 PM
rmacklem committed rS323779: Simplify nfsrpc_layoutreturn() args..
Simplify nfsrpc_layoutreturn() args.
Sep 19 2017, 8:45 PM
rmacklem committed rS323775: Simplify nfsrpc_layoutcommit() args..
Simplify nfsrpc_layoutcommit() args.
Sep 19 2017, 8:18 PM

Sep 17 2017

rmacklem committed rS323689: Fix bogus FREAD with NFSV4OPEN_ACCESSREAD. No functional change..
Fix bogus FREAD with NFSV4OPEN_ACCESSREAD. No functional change.
Sep 17 2017, 10:18 PM

Sep 4 2017

rmacklem committed rS323163: Fix pnfsdsfile to handle mirrors..
Fix pnfsdsfile to handle mirrors.
Sep 4 2017, 9:18 PM
rmacklem committed rS323162: Fix pnfsdsfile to handle mirrors..
Fix pnfsdsfile to handle mirrors.
Sep 4 2017, 9:14 PM
rmacklem committed rS323159: Fix handling of the case where one of the mirrors is no longer online..
Fix handling of the case where one of the mirrors is no longer online.
Sep 4 2017, 8:27 PM
rmacklem committed rS323158: Fix handling of the case where one of the mirrors is no longer online..
Fix handling of the case where one of the mirrors is no longer online.
Sep 4 2017, 8:23 PM

Sep 3 2017

rmacklem committed rS323150: Change the ffsd_stateid.seqid field in the Flex File Layout to be 0, so.
Change the ffsd_stateid.seqid field in the Flex File Layout to be 0, so
Sep 3 2017, 10:03 PM
rmacklem committed rS323149: Change the ffsd_stateid.seqid field in the Flex File Layout to be 0, so.
Change the ffsd_stateid.seqid field in the Flex File Layout to be 0, so
Sep 3 2017, 10:01 PM

Aug 25 2017

rmacklem committed rS322911: Update the kernel to stable/11/sys..
Update the kernel to stable/11/sys.
Aug 25 2017, 11:10 PM
rmacklem committed rS322910: MFC: r321689.
MFC: r321689
Aug 25 2017, 10:59 PM
rmacklem committed rS322909: MFC: r321688.
MFC: r321688
Aug 25 2017, 10:53 PM
rmacklem committed rS322908: MFC: r321675.
MFC: r321675
Aug 25 2017, 10:45 PM
rmacklem committed rS322907: MFC: r321628.
MFC: r321628
Aug 25 2017, 10:40 PM
rmacklem committed rS322905: Fix a few things related to Flex File Layout. The XDR needed to be fixed.
Fix a few things related to Flex File Layout. The XDR needed to be fixed
Aug 25 2017, 9:53 PM
rmacklem committed rS322904: Fix a few things related to Flex File Layout. The XDR needed to be fixed.
Fix a few things related to Flex File Layout. The XDR needed to be fixed
Aug 25 2017, 9:43 PM

Aug 19 2017

rmacklem added a comment to D12083: Do not drop NFS vnode lock when performing consistency checks..

This version looks fine to me.
Thanks for doing this, rick.

Aug 19 2017, 9:39 PM
rmacklem accepted D12083: Do not drop NFS vnode lock when performing consistency checks..

I've accepted this revision, but I do have one concern.
If a future code change resulted in the vnode lock changing from shared->exclusive
before the ncl_downgrade_vnlock(), it would erroneously do an unlock of this
new lock.

  • If you left ncl_upgrade_vnlock() returning oldlock and passed that into ncl_downgrade_lock() to use to decide whether or not to unlock the new lock, this would be avoided.
Aug 19 2017, 8:15 PM
rmacklem committed rS322681: Set nfsrv_doflexfile == 1 when there are mirrors, since mirrors aren't.
Set nfsrv_doflexfile == 1 when there are mirrors, since mirrors aren't
Aug 19 2017, 12:40 AM
rmacklem committed rS322679: Set nfsrv_doflexfile == 1 when there are mirrors, since File Layout doesn't.
Set nfsrv_doflexfile == 1 when there are mirrors, since File Layout doesn't
Aug 19 2017, 12:37 AM

Aug 18 2017

rmacklem committed rS322642: Add the '#' delimiter for use with the "-p" option to indicate that the.
Add the '#' delimiter for use with the "-p" option to indicate that the
Aug 18 2017, 1:34 AM
rmacklem committed rS322641: Add the '#' delimiter for use with the "-p" option to indicate that the.
Add the '#' delimiter for use with the "-p" option to indicate that the
Aug 18 2017, 1:31 AM
rmacklem committed rS322640: Fix the searches of the device id lists so that they include the mirror.
Fix the searches of the device id lists so that they include the mirror
Aug 18 2017, 1:24 AM
rmacklem committed rS322639: Fix the searches of the device id lists so that they include the mirror.
Fix the searches of the device id lists so that they include the mirror
Aug 18 2017, 1:20 AM

Aug 17 2017

rmacklem committed rS322603: Add support for mirrors to the Setattr RPC proxies to the DS data file..
Add support for mirrors to the Setattr RPC proxies to the DS data file.
Aug 17 2017, 12:21 AM
rmacklem committed rS322602: Add support for mirrors to the Setattr RPC proxies to the DS data file..
Add support for mirrors to the Setattr RPC proxies to the DS data file.
Aug 17 2017, 12:16 AM

Aug 16 2017

rmacklem committed rS322599: Add the hook for setting ACLs on the DS data files, which was missed during.
Add the hook for setting ACLs on the DS data files, which was missed during
Aug 16 2017, 10:49 PM
rmacklem committed rS322598: Add the hook for setting ACLs on the DS data files, which was missed during.
Add the hook for setting ACLs on the DS data files, which was missed during
Aug 16 2017, 10:47 PM
rmacklem committed rS322595: Cleanup of the code changes for support of mirrors. Mostly indentation changes.
Cleanup of the code changes for support of mirrors. Mostly indentation changes
Aug 16 2017, 8:29 PM
rmacklem committed rS322594: Cleanup of the code changes for support of mirrors. Mostly indentation changes.
Cleanup of the code changes for support of mirrors. Mostly indentation changes
Aug 16 2017, 8:24 PM
rmacklem committed rS322554: Add support for DS writes to mirrors. Also, modify the code that handles.
Add support for DS writes to mirrors. Also, modify the code that handles
Aug 16 2017, 12:05 AM
rmacklem committed rS322553: Add support for DS writes to mirrors. Also, modify the code that handles.
Add support for DS writes to mirrors. Also, modify the code that handles
Aug 16 2017, 12:00 AM

Aug 14 2017

rmacklem committed rS322519: Modify nfsrv_pnfsremovesetup() and nfsrv_pnfsremove(), factoring out the part.
Modify nfsrv_pnfsremovesetup() and nfsrv_pnfsremove(), factoring out the part
Aug 14 2017, 8:53 PM
rmacklem committed rS322518: Modify nfsrv_pnfsremovesetup() and nfsrv_pnfsremove(), factoring out the part.
Modify nfsrv_pnfsremovesetup() and nfsrv_pnfsremove(), factoring out the part
Aug 14 2017, 8:47 PM

Aug 13 2017

rmacklem committed rS322469: Modify nfsrv_pnfscreate(), factoring out the part that does the Open RPC.
Modify nfsrv_pnfscreate(), factoring out the part that does the Open RPC
Aug 13 2017, 6:41 PM
rmacklem committed rS322468: Modify nfsrv_pnfscreate(), factoring out the part that does the Open RPC.
Modify nfsrv_pnfscreate(), factoring out the part that does the Open RPC
Aug 13 2017, 6:35 PM

Aug 11 2017

rmacklem committed rS322421: Fix nfsrv_dsgetsockmnt() so that it handles the mirrors. Also, change.
Fix nfsrv_dsgetsockmnt() so that it handles the mirrors. Also, change
Aug 11 2017, 11:12 PM
rmacklem committed rS322420: Fix nfsrv_dsgetsockmnt() so that it handles the mirrors. Also, change.
Fix nfsrv_dsgetsockmnt() so that it handles the mirrors. Also, change
Aug 11 2017, 11:08 PM

Aug 10 2017

rmacklem committed rS322385: Fix the arguments for nfsrv_dsgetsockmnt() to handle mirrors..
Fix the arguments for nfsrv_dsgetsockmnt() to handle mirrors.
Aug 10 2017, 11:45 PM
rmacklem committed rS322384: Fix up the arguments for nfsrv_dsgetsockmnt() to handle mirrors..
Fix up the arguments for nfsrv_dsgetsockmnt() to handle mirrors.
Aug 10 2017, 11:39 PM
rmacklem committed rS322379: Add some handling of mirror limits..
Add some handling of mirror limits.
Aug 10 2017, 10:00 PM
rmacklem committed rS322378: Add some handling of mirror limits..
Add some handling of mirror limits.
Aug 10 2017, 9:58 PM
rmacklem committed rS322334: Add support for mirrors to nfsrv_pnfscreate(), which creates the data storage.
Add support for mirrors to nfsrv_pnfscreate(), which creates the data storage
Aug 10 2017, 12:39 AM
rmacklem committed rS322333: Add support for mirrors to nfsrv_pnfscreate(), which creates the data storage.
Add support for mirrors to nfsrv_pnfscreate(), which creates the data storage
Aug 10 2017, 12:33 AM