Page MenuHomeFreeBSD

rmacklem (Rick Macklem)
User

Projects

User Details

User Since
Jan 13 2015, 10:58 PM (301 w, 4 d)

Recent Activity

Today

rmacklem requested review of D26938: Update mountd and nfsd rc.d scripts to use the "-R" option added by r375026.
Sun, Oct 25, 12:10 AM · rc

Yesterday

rmacklem committed rS367027: Update man page for -R option added by r376026..
Update man page for -R option added by r376026.
Sat, Oct 24, 10:52 PM
rmacklem closed D26746: Add a -R option to mountd so that it can be run without rpcbind for an NFSv4 only server.
Sat, Oct 24, 10:48 PM
rmacklem committed rS367026: Add "-R" option to tell mountd to not register with rpcbind..
Add "-R" option to tell mountd to not register with rpcbind.
Sat, Oct 24, 10:48 PM

Fri, Oct 23

rmacklem added a reviewer for D26746: Add a -R option to mountd so that it can be run without rpcbind for an NFSv4 only server: asomers.

Added asomers@ in case he'd like ot review this.

Fri, Oct 23, 11:39 PM
rmacklem accepted D26920: nfsstat: delete unused fields.

Seems ok to me.
There have already been commits that changed this
output format and no one has reported problems
because of that.
As such, I don't think this format change will
cause people problems.

Fri, Oct 23, 11:38 PM

Tue, Oct 20

rmacklem closed D26342: Add a check for LCL_NEEDSCONFIRM to nfsrv_checkgetattr().

This patch has been committed as r365703. It didn't get automatically
closed for some reason.

Tue, Oct 20, 1:01 AM

Mon, Oct 19

rmacklem committed rS366825: Update the setup doc to recognize that snapshots will have everything.
Update the setup doc to recognize that snapshots will have everything
Mon, Oct 19, 2:12 AM
rmacklem committed rS366824: Fix a minor grammatical error. No semantics change intended..
Fix a minor grammatical error. No semantics change intended.
Mon, Oct 19, 1:52 AM
rmacklem committed rS366823: Wrap a line that exceeded 80chars. No semantics changes..
Wrap a line that exceeded 80chars. No semantics changes.
Mon, Oct 19, 1:50 AM

Tue, Oct 13

rmacklem updated the diff for D26746: Add a -R option to mountd so that it can be run without rpcbind for an NFSv4 only server.

Fix a bug where the sig_mask being used as the
argument to sigsuspend() was set to the wrong
bits, where SIGHUP was blocked.

Tue, Oct 13, 12:49 AM

Mon, Oct 12

rmacklem requested review of D26746: Add a -R option to mountd so that it can be run without rpcbind for an NFSv4 only server.
Mon, Oct 12, 2:15 AM

Sat, Oct 10

rmacklem closed D26521: fix mountd.c so that it does not allocate 4K for credential groups unless a large groups list is needed.
Sat, Oct 10, 12:02 AM
rmacklem committed rS366595: Modify mountd.c so that it does not always malloc 4K for the map credentials..
Modify mountd.c so that it does not always malloc 4K for the map credentials.
Sat, Oct 10, 12:02 AM

Fri, Oct 9

rmacklem closed D26620: fix vn_generic_copy_file_range() so that it will return if a signal needs to processed.
Fri, Oct 9, 1:04 AM
rmacklem committed rS366557: Make vn_generic_copy_file_range() interruptible via a signal..
Make vn_generic_copy_file_range() interruptible via a signal.
Fri, Oct 9, 1:04 AM

Sun, Oct 4

rmacklem updated the diff for D26521: fix mountd.c so that it does not allocate 4K for credential groups unless a large groups list is needed.

Updated with changes as suggested by kib@ and freqlabs@.

Sun, Oct 4, 10:42 PM

Fri, Oct 2

rmacklem updated the diff for D26620: fix vn_generic_copy_file_range() so that it will return if a signal needs to processed.

Use the variant of sig_intr() in D26628.

Fri, Oct 2, 3:34 PM

Thu, Oct 1

rmacklem requested review of D26620: fix vn_generic_copy_file_range() so that it will return if a signal needs to processed.
Thu, Oct 1, 2:25 AM
rmacklem committed rS366303: Modify the NFSv4.2 VOP_COPY_FILE_RANGE() client call to return after one.
Modify the NFSv4.2 VOP_COPY_FILE_RANGE() client call to return after one
Thu, Oct 1, 12:47 AM
rmacklem committed rS366302: Clip the "len" argument to vn_generic_copy_file_range() at a.
Clip the "len" argument to vn_generic_copy_file_range() at a
Thu, Oct 1, 12:34 AM
rmacklem closed D26570: clip the len being copied by copy_file_range() to an exact multiple of hole size.
Thu, Oct 1, 12:34 AM
rmacklem abandoned D26571: Modify vn_generic_copy_file_range() so that it will return after approximately 1second.

Well, when I looked at a wireshark trace of copying a 1Gbyte file,
it turns out that it is the Commit RPC (the one that does VOP_FSYNC())
that takes the time and not the Copy RPC, so using time on the
Copy RPC is useless.

Thu, Oct 1, 12:14 AM

Wed, Sep 30

rmacklem added a comment to D26571: Modify vn_generic_copy_file_range() so that it will return after approximately 1second.

Updated the inline comments.

Wed, Sep 30, 2:36 AM
rmacklem updated the diff for D26571: Modify vn_generic_copy_file_range() so that it will return after approximately 1second.

Made the changes suggested by asomers@

Wed, Sep 30, 2:30 AM
rmacklem committed rS366278: Make copy_file_range(2) Linux compatible for overflow of offset + len..
Make copy_file_range(2) Linux compatible for overflow of offset + len.
Wed, Sep 30, 2:18 AM
rmacklem closed D26569: fix copy_file_range(2) so that it handles the case where input offset + len would wrap around.
Wed, Sep 30, 2:18 AM

Tue, Sep 29

rmacklem committed rS366256: MFS: r366238.
MFS: r366238
Tue, Sep 29, 3:10 PM
rmacklem updated the diff for D26570: clip the len being copied by copy_file_range() to an exact multiple of hole size.

Change the blksize test to handle the special case
where _PC_MIN_HOLE_SIZE is returned as 1.
As well as asomers@ suggested change, I also
changed the blksize code just below it.

Tue, Sep 29, 2:47 AM
rmacklem committed rS366241: MFC: r366189.
MFC: r366189
Tue, Sep 29, 2:03 AM
rmacklem committed rS366238: MFC: r366189.
MFC: r366189
Tue, Sep 29, 1:53 AM
rmacklem updated the diff for D26570: clip the len being copied by copy_file_range() to an exact multiple of hole size.

Use rounddown() as suggested by asomers@.

Tue, Sep 29, 1:05 AM
rmacklem updated the diff for D26570: clip the len being copied by copy_file_range() to an exact multiple of hole size.

Fixed the calculation to take *inoffp into account,
as suggested by asomers@.

Tue, Sep 29, 12:59 AM
rmacklem added inline comments to D26569: fix copy_file_range(2) so that it handles the case where input offset + len would wrap around.
Tue, Sep 29, 12:49 AM

Mon, Sep 28

rmacklem updated the diff for D26569: fix copy_file_range(2) so that it handles the case where input offset + len would wrap around.

Add a check for len being clipped down to 0.
No sense in doing the VOP call for this case.

Mon, Sep 28, 4:30 PM
rmacklem added inline comments to D26569: fix copy_file_range(2) so that it handles the case where input offset + len would wrap around.
Mon, Sep 28, 4:17 PM
rmacklem updated the diff for D26569: fix copy_file_range(2) so that it handles the case where input offset + len would wrap around.

Change handling of a wrap around of *outoffp + len
to clip "len" instead of return EINVAL.

Mon, Sep 28, 4:14 PM
rmacklem added a comment to D26571: Modify vn_generic_copy_file_range() so that it will return after approximately 1second.

Although there is no explicit statement in the NFS
RFCs indicating an upper limit on an RPC response
time, the assumption is that the server will reply
in a "reasonable time".
--> I think 1second is a reasonable time limit,

although some might argue it should be less
than that.

--> In NFSv4.2, a client can optionally specify the

  Copy operation be done "asynchronously",
  where the server replies to the Copy RPC when
  it is started and then does a server->client
  callback to notify completion.
  I have not implemented that, since I believe
  that the Linux server only does this for Copies
  between servers, which FreeBSD does not
  know how to do.
  Without the "asynchronous" option
, the Copy time needs to be limited
  to ensure a "timely" RPC reply.
Mon, Sep 28, 3:38 PM
rmacklem added inline comments to D26569: fix copy_file_range(2) so that it handles the case where input offset + len would wrap around.
Mon, Sep 28, 3:19 PM
rmacklem added a comment to D26571: Modify vn_generic_copy_file_range() so that it will return after approximately 1second.

The problem with using the "check for signals" approach
is that it won't work for the NFS server.
--> The NFS server will still need the 1sec timeout.
The VOP call can probably get away with using a
kernel only "flags" bit to indicate whether it should
use "1sec" vs "signal pending", but I'm not sure
if such semantics is overkill (the overhead of doing
1 syscall/sec isn't particularly high for a copy
like this.
Do others think this extra complexity is worth it?

Mon, Sep 28, 3:11 PM
rmacklem added a comment to D26571: Modify vn_generic_copy_file_range() so that it will return after approximately 1second.

Ok, so I have no idea how to do that.
Any suggestions?

Mon, Sep 28, 1:44 AM
rmacklem requested review of D26571: Modify vn_generic_copy_file_range() so that it will return after approximately 1second.
Mon, Sep 28, 1:30 AM
rmacklem requested review of D26570: clip the len being copied by copy_file_range() to an exact multiple of hole size.
Mon, Sep 28, 1:24 AM
rmacklem requested review of D26569: fix copy_file_range(2) so that it handles the case where input offset + len would wrap around.
Mon, Sep 28, 1:19 AM

Sat, Sep 26

rmacklem committed rS366189: Bjorn reported a problem where the Linux NFSv4.1 client is.
Bjorn reported a problem where the Linux NFSv4.1 client is
Sat, Sep 26, 11:05 PM

Sep 25 2020

rmacklem committed rS366134: MFC: r365895.
MFC: r365895
Sep 25 2020, 12:58 AM

Sep 24 2020

rmacklem committed rS366120: MFS: r366050, r366117.
MFS: r366050, r366117
Sep 24 2020, 4:21 PM
rmacklem committed rS366117: MFC: r365895.
MFC: r365895
Sep 24 2020, 3:35 PM
rmacklem committed rS366116: MFS: r365703.
MFS: r365703
Sep 24 2020, 2:59 PM

Sep 23 2020

rmacklem added a comment to D26533: Fix some signed/unsigned comparison warnings in NFS.

Looks fine to me, but I've never had anything to do
with this code.
I think trasz@ was the author of the nfsv4 acl code,
so you might want to ask him?

Sep 23 2020, 11:18 PM
rmacklem committed rS366052: MFC: r365789.
MFC: r365789
Sep 23 2020, 1:56 AM
rmacklem committed rS366050: MFC: r365789.
MFC: r365789
Sep 23 2020, 1:50 AM

Sep 22 2020

rmacklem added a reviewer for D26521: fix mountd.c so that it does not allocate 4K for credential groups unless a large groups list is needed: freqlabs.
Sep 22 2020, 2:26 AM
rmacklem requested review of D26521: fix mountd.c so that it does not allocate 4K for credential groups unless a large groups list is needed.
Sep 22 2020, 2:25 AM

Sep 21 2020

rmacklem committed rS365936: Add patch files for the nfsclient, nfscbd and nfsd /etc/rc.d scripts..
Add patch files for the nfsclient, nfscbd and nfsd /etc/rc.d scripts.
Sep 21 2020, 3:16 AM
rmacklem committed rS365935: MFC: r365703.
MFC: r365703
Sep 21 2020, 1:39 AM
rmacklem committed rS365934: MFC: r365703.
MFC: r365703
Sep 21 2020, 12:50 AM

Sep 19 2020

rmacklem updated the diff for D26241: update exports.5 to include information on the TLS export options.

Added a STANDARDS section, as suggested by gbe@.

Sep 19 2020, 1:10 AM

Sep 18 2020

rmacklem committed rS365895: Fix a LOR between the NFS server and server side krpc..
Fix a LOR between the NFS server and server side krpc.
Sep 18 2020, 11:53 PM
rmacklem committed rS365866: Factor out several functions from the daemons and put them in common files.
Factor out several functions from the daemons and put them in common files
Sep 18 2020, 1:11 AM

Sep 17 2020

rmacklem committed rS365828: Oops, used the wrong free() function to free a X509 certificate..
Oops, used the wrong free() function to free a X509 certificate.
Sep 17 2020, 2:04 AM
rmacklem committed rS365827: Update man pages with a STANDARDS section..
Update man pages with a STANDARDS section.
Sep 17 2020, 1:23 AM
rmacklem committed rS365825: Update the rpc.tlsclntd man page to indicate that extant connections that.
Update the rpc.tlsclntd man page to indicate that extant connections that
Sep 17 2020, 12:03 AM

Sep 16 2020

rmacklem committed rS365824: Update the rpc.tlsservd man page to indicate that extant connections that.
Update the rpc.tlsservd man page to indicate that extant connections that
Sep 16 2020, 11:59 PM
rmacklem committed rS365823: Add support for checking extant connections when the CRL is reloaded and.
Add support for checking extant connections when the CRL is reloaded and
Sep 16 2020, 11:36 PM
rmacklem committed rS365822: Add a check for the CRL file being used to rpctls_checkcrl()..
Add a check for the CRL file being used to rpctls_checkcrl().
Sep 16 2020, 11:31 PM
rmacklem committed rS365818: Add support to the rpc.tlsservd daemon for shutting down connections that.
Add support to the rpc.tlsservd daemon for shutting down connections that
Sep 16 2020, 10:42 PM
rmacklem committed rS365789: Fix a LOR between the NFS server and server side krpc..
Fix a LOR between the NFS server and server side krpc.
Sep 16 2020, 2:25 AM

Sep 15 2020

rmacklem added a comment to D26241: update exports.5 to include information on the TLS export options.

Added some replies to inline comments.

Sep 15 2020, 12:02 AM

Sep 14 2020

rmacklem committed rS365703: Fix a case where the NFSv4.0 server might crash if delegations are enabled..
Fix a case where the NFSv4.0 server might crash if delegations are enabled.
Sep 14 2020, 12:44 AM

Sep 10 2020

rmacklem accepted D26377: cp: use copy_file_range(2).

Looks fine to me.

Sep 10 2020, 1:47 AM

Sep 6 2020

rmacklem added a comment to D26342: Add a check for LCL_NEEDSCONFIRM to nfsrv_checkgetattr().

Interesting. SetClientID arguments are roughly:
A) - an identifier string (that should never change for a given client)
B) - a verifier that should change whenever the client looses state information

(usually a reboot)

C) - a host IP address for the server to use to do a connection to the

client for callbacks
Sep 6 2020, 3:36 AM
rmacklem added a comment to D26342: Add a check for LCL_NEEDSCONFIRM to nfsrv_checkgetattr().

Well, you are correct, in that other callers may
need similar fixes. (ie. Should never be called if
the ClientID is unconfirmed.)
--> For NFSv4.0, the only two are CBRECALL, to

 recall a delegation. This occurs when a
 conflicting open occurs and the check in
 nfsrv_checkopen() should be sufficient.
CBNULL, which is done during confirmation
to check for a callback path. (Again handled
by the current code, since it is done after the
LCL_NEEDSCONFIRM flag is cleared with the
global exclusive lock held.

--> There are Layout related CBs in NFSv4.1, but

since those use an established connection
with a session, I think they are ok, but I will
take a look.
Sep 6 2020, 1:02 AM
rmacklem committed rS365372: Delete the kernel sources, since all changes are merged into head..
Delete the kernel sources, since all changes are merged into head.
Sep 6 2020, 12:43 AM

Sep 5 2020

rmacklem requested review of D26342: Add a check for LCL_NEEDSCONFIRM to nfsrv_checkgetattr().
Sep 5 2020, 11:11 PM
rmacklem committed rS365355: Fix a potential memory leak in the NFS over TLS handling code..
Fix a potential memory leak in the NFS over TLS handling code.
Sep 5 2020, 12:51 AM
rmacklem committed rS365353: Remove the old version of the rc.d startup scripts for the daemons..
Remove the old version of the rc.d startup scripts for the daemons.
Sep 5 2020, 12:28 AM
rmacklem committed rS365352: Remove the old version of the rpctls daemons, plus mountd..
Remove the old version of the rpctls daemons, plus mountd.
Sep 5 2020, 12:27 AM

Sep 4 2020

rmacklem committed rS365324: Add a line to the setup doc to make sure that the scripts are executable..
Add a line to the setup doc to make sure that the scripts are executable.
Sep 4 2020, 2:22 AM
rmacklem committed rS365323: Fix the path name of the certificate directory in the man page..
Fix the path name of the certificate directory in the man page.
Sep 4 2020, 12:47 AM

Sep 3 2020

rmacklem committed rS365314: Update the setup doc for startup of the daemons..
Update the setup doc for startup of the daemons.
Sep 3 2020, 10:20 PM
rmacklem committed rS365313: Update the setup document for the renamed daemons..
Update the setup document for the renamed daemons.
Sep 3 2020, 10:11 PM
rmacklem committed rS365312: Add the rc.d scripts for the renamed daemons..
Add the rc.d scripts for the renamed daemons.
Sep 3 2020, 10:02 PM
rmacklem committed rS365311: Add the renamed server daemon. Also add long options for those who like them..
Add the renamed server daemon. Also add long options for those who like them.
Sep 3 2020, 9:58 PM
rmacklem committed rS365310: Add the renamed client daemon. Also, add long options for those who like them..
Add the renamed client daemon. Also, add long options for those who like them.
Sep 3 2020, 9:52 PM
rmacklem committed rS365309: Add entries for the OID used for NFS-over-TLS "user@domain"..
Add entries for the OID used for NFS-over-TLS "user@domain".
Sep 3 2020, 8:43 PM
rmacklem closed D26225: add an entry for X.509 certificate subjAltName otherName field.
Sep 3 2020, 8:43 PM
rmacklem added a reviewer for D26225: add an entry for X.509 certificate subjAltName otherName field: gordon.
Sep 3 2020, 1:43 AM
rmacklem added a comment to D26225: add an entry for X.509 certificate subjAltName otherName field.

Modify the entry to be NFS specific and add a comment
w.r.t. where it is handled, per inline comment.

Sep 3 2020, 1:42 AM
rmacklem updated the diff for D26225: add an entry for X.509 certificate subjAltName otherName field.

Although it is not really NFS specific, NFS is probably the
only use case that will happen in my lifetime, so define
it as NFS specific and comment w.r.t. where it is handled.

Sep 3 2020, 1:40 AM

Sep 2 2020

rmacklem updated the diff for D26262: Document the "tls" mount_nfs option..

Change the daemon's name from rpctlscd to rpc.tlsclntd
to avoid confusion with the server side daemon.

Sep 2 2020, 2:16 AM
rmacklem updated the diff for D26241: update exports.5 to include information on the TLS export options.

Rename rpctlssd to rpc.tlsservd, since that seemed to
be the preferred name for the daemon and this
hopefully will avoid confusion with the one for
the client side.

Sep 2 2020, 2:12 AM
rmacklem committed rS365232: Fix the standalone build of the nfscl and nfsd modules..
Fix the standalone build of the nfscl and nfsd modules.
Sep 2 2020, 1:29 AM

Sep 1 2020

rmacklem updated the diff for D26262: Document the "tls" mount_nfs option..

Remove "the" and "daemon" as suggested by bjk@
for the exports.5 patch.

Sep 1 2020, 2:44 AM
rmacklem added a comment to D26241: update exports.5 to include information on the TLS export options.

Replied to inline comment and asked if rpc.tlssd would be preferable
to rpctlssd?

Sep 1 2020, 2:33 AM
rmacklem updated the diff for D26241: update exports.5 to include information on the TLS export options.

Take "the" and "daemon" out as suggested by bjk@.

Sep 1 2020, 2:30 AM
rmacklem requested review of D26262: Document the "tls" mount_nfs option..
Sep 1 2020, 1:34 AM
rmacklem committed rS365020: Add a check to test for the case of the "tls" option being used with "udp"..
Add a check to test for the case of the "tls" option being used with "udp".
Sep 1 2020, 1:13 AM
rmacklem committed rS365019: Add a check to test for the case of the "tls" option being used with "udp"..
Add a check to test for the case of the "tls" option being used with "udp".
Sep 1 2020, 1:10 AM

Aug 31 2020

rmacklem requested review of D26241: update exports.5 to include information on the TLS export options.
Aug 31 2020, 2:02 AM