Page MenuHomeFreeBSD

rmacklem (Rick Macklem)
User

Projects

User Details

User Since
Jan 13 2015, 10:58 PM (266 w, 11 h)

Recent Activity

Mon, Feb 17

rmacklem committed rS358056: Update rpctlscd so that the "-t" option can be used to strip off the.
Update rpctlscd so that the "-t" option can be used to strip off the
Mon, Feb 17, 9:34 PM
rmacklem committed rS358055: Update the last three NFS files for ext_pgs and TLS support..
Update the last three NFS files for ext_pgs and TLS support.
Mon, Feb 17, 9:29 PM
rmacklem committed rS358054: Add a field for new mount options only done via nmount(2), since all.
Add a field for new mount options only done via nmount(2), since all
Mon, Feb 17, 9:15 PM
rmacklem committed rS358053: Update nfs_clrpcops.c to handle ext_pgs mbufs, including the additional.
Update nfs_clrpcops.c to handle ext_pgs mbufs, including the additional
Mon, Feb 17, 9:11 PM
rmacklem committed rS358052: Get rid of the extra argument to NFSVOPUNLOCK()..
Get rid of the extra argument to NFSVOPUNLOCK().
Mon, Feb 17, 9:02 PM
rmacklem committed rS358051: Update sys/fs/nfsserver sources so that they handle ext_pgs mbufs..
Update sys/fs/nfsserver sources so that they handle ext_pgs mbufs.
Mon, Feb 17, 8:58 PM
rmacklem committed rS358050: Update nfsport.h. I haven't yet decided what to do about NFSVOPUNLOCK(),.
Update nfsport.h. I haven't yet decided what to do about NFSVOPUNLOCK(),
Mon, Feb 17, 8:35 PM
rmacklem committed rS358043: Fix the NFS code so that it can handle ext_pgs mbufs. This is quite a.
Fix the NFS code so that it can handle ext_pgs mbufs. This is quite a
Mon, Feb 17, 8:20 PM
rmacklem committed rS358040: Add two functions to kern_mbuf.c used by the RPC-over-TLS to.
Add two functions to kern_mbuf.c used by the RPC-over-TLS to
Mon, Feb 17, 8:09 PM
rmacklem committed rS358039: Fix rpctls_impl.c for handling of cases where TLS won't work..
Fix rpctls_impl.c for handling of cases where TLS won't work.
Mon, Feb 17, 8:02 PM
rmacklem committed rS358038: Update the krpc for nfs-over-tls..
Update the krpc for nfs-over-tls.
Mon, Feb 17, 7:51 PM
rmacklem committed rS358037: MFC: r357149.
MFC: r357149
Mon, Feb 17, 7:40 PM
rmacklem committed rS358036: MFC: r357149.
MFC: r357149
Mon, Feb 17, 7:33 PM
rmacklem committed rS358035: MFC: r357149.
MFC: r357149
Mon, Feb 17, 7:31 PM

Fri, Feb 7

rmacklem added a comment to D23573: O_SEARCH test: mark revokex an expected fail on NFS.

I believe you are correct. NFS is not POSIX compliant, since it checks
permissions on read/readdir and not just open.

Fri, Feb 7, 10:29 PM

Sun, Jan 26

rmacklem committed rS357157: Add the rpctlscd and rpctlssd daemons to usr.sbin..
Add the rpctlscd and rpctlssd daemons to usr.sbin.
Sun, Jan 26, 7:38 PM
rmacklem committed rS357156: Just enable NFS-over-TLS always for testing..
Just enable NFS-over-TLS always for testing.
Sun, Jan 26, 7:16 PM
rmacklem committed rS357155: Update sys/conf/files to build the new files for RPC-over-TLS..
Update sys/conf/files to build the new files for RPC-over-TLS.
Sun, Jan 26, 7:08 PM
rmacklem committed rS357154: Add some new files for the RPC-over-TLS kernel rpc..
Add some new files for the RPC-over-TLS kernel rpc.
Sun, Jan 26, 6:57 PM
rmacklem committed rS357152: Patch the kernel RPC files for handling RPC-over-TLS..
Patch the kernel RPC files for handling RPC-over-TLS.
Sun, Jan 26, 6:43 PM
rmacklem committed rS357150: Set up a projects area for the NFS over TLS project..
Set up a projects area for the NFS over TLS project.
Sun, Jan 26, 6:13 PM
rmacklem committed rS357151: Add the usr.sbin subtree to projects/nfs-over-tls..
Add the usr.sbin subtree to projects/nfs-over-tls.
Sun, Jan 26, 6:09 PM
rmacklem committed rS357149: Fix a crash in the NFSv4 server..
Fix a crash in the NFSv4 server.
Sun, Jan 26, 5:59 PM

Dec 31 2019

rmacklem committed rS356244: Update the man page to reflect that "-M" and "-N" are deprecated and ignored..
Update the man page to reflect that "-M" and "-N" are deprecated and ignored.
Dec 31 2019, 10:25 PM
rmacklem committed rS356242: Get rid of old nfsstat options no longer used..
Get rid of old nfsstat options no longer used.
Dec 31 2019, 10:19 PM
rmacklem committed rS356239: MFC: r356066.
MFC: r356066
Dec 31 2019, 6:28 PM
rmacklem committed rS356238: MFC: r356066.
MFC: r356066
Dec 31 2019, 6:10 PM
rmacklem committed rS356219: Switch r356210 to use gone_in() instead of printf()..
Switch r356210 to use gone_in() instead of printf().
Dec 31 2019, 5:39 AM
rmacklem committed rS356213: Replace .h files included from old NFS directories with the new NFS ones..
Replace .h files included from old NFS directories with the new NFS ones.
Dec 31 2019, 12:07 AM

Dec 30 2019

rmacklem committed rS356210: Add warning printf w.r.t. removal of sys/nfs/nfs_lock.c..
Add warning printf w.r.t. removal of sys/nfs/nfs_lock.c.
Dec 30 2019, 10:39 PM
rmacklem committed rS356190: MFC: r355530.
MFC: r355530
Dec 30 2019, 12:04 AM

Dec 29 2019

rmacklem committed rS356189: MFC: r355509.
MFC: r355509
Dec 29 2019, 11:56 PM
rmacklem committed rS356188: MFC: r355509.
MFC: r355509
Dec 29 2019, 11:49 PM
rmacklem updated the diff for D22933: get rid of Giant in nfs_lock.c.

This version of the patch just deleted p_nlminfo instead of
replacing it with p_spare.
The offsets in kern_thread.c have been adjusted, which the
comment indicates is sufficient for a change to "struct proc" in head.

Dec 29 2019, 11:28 PM
rmacklem added a comment to D22933: get rid of Giant in nfs_lock.c.

I'll update the patch with a version that doesn't have p_spare in a day or two.

Dec 29 2019, 6:16 AM
rmacklem updated the diff for D22933: get rid of Giant in nfs_lock.c.

One file got missed for the previous version of the deletion patch.

Dec 29 2019, 6:08 AM
rmacklem updated the diff for D22933: get rid of Giant in nfs_lock.c.

This patch is completely different than the previous one.
It prepares the source tree for removal of sys/nfs/nfs_lock.c,
since this code uses Giant and has not been running by default
since May 2008.

Dec 29 2019, 12:21 AM

Dec 28 2019

rmacklem committed rS356161: MFC: r355194.
MFC: r355194
Dec 28 2019, 10:32 PM
rmacklem committed rS356160: MFC: r355194.
MFC: r355194
Dec 28 2019, 10:24 PM
rmacklem added a comment to D22933: get rid of Giant in nfs_lock.c.

Well, you might get a chuckle about this...
Turns out this code that I've been hacking to get rid of Giant
never gets executed.

Dec 28 2019, 12:08 AM

Dec 27 2019

rmacklem added a comment to D22933: get rid of Giant in nfs_lock.c.

Further to kib@'s comment, here is how I understand the algorithm.
nfs_dolock() is called when a process does a file lock request on an NFSv3
mount that doesn't have the "nolockd" mount option.
It locked Giant to protect the code in lines 283-294 (before patch), but
except for the rare case where the malloc(M_WAITOK) in nfslock_send()
slept, held it until the tsleep() call at line#325.

Dec 27 2019, 10:54 PM
rmacklem updated the diff for D22933: get rid of Giant in nfs_lock.c.

This version of the patch recodes the loop so that I think it is more readable.
It does not really change the semantics in a significant way.
I chose not to unlock/relock the mutex around nfslock_send(), since the
unpatched version would normally only unlock/relock Giant at the tsleep() call.
(Yes, it is possible that there would have been a sleep and associated unlock/relock
of Giant in the unpatch nfslock_send() via the malloc(..M_WAITOK), but it wouldn't
normally have occurred.)

Dec 27 2019, 10:25 PM
rmacklem added a comment to D22933: get rid of Giant in nfs_lock.c.

I think your understanding is correct, in that the locking is to protect
use of p_nlminfo.
If I read it correctly, nlminfo_release() is only called from code in exit1()
when the process is terminated, so it would no longer be doing any locking.
(It is kind of a weird hack, where nlminfo_release_p is set to nlminfo_release()
and then nlminfo_release_p is checked for non-NULL and called during process exit.)

Dec 27 2019, 4:58 PM
rmacklem created D22933: get rid of Giant in nfs_lock.c.
Dec 27 2019, 12:31 AM

Dec 26 2019

rmacklem committed rS356099: Change NFSv4.1 and NFSv4.2 error strings to start with lower case letter..
Change NFSv4.1 and NFSv4.2 error strings to start with lower case letter.
Dec 26 2019, 9:07 PM

Dec 25 2019

rmacklem committed rS356084: Add NFSv4.1 and NFSv4.2 errors to nfsv4_errstr.h..
Add NFSv4.1 and NFSv4.2 errors to nfsv4_errstr.h.
Dec 25 2019, 10:25 PM
rmacklem committed rS356066: Fix nfsmount() so that it will return NFSERR_MINORVERMISMATCH..
Fix nfsmount() so that it will return NFSERR_MINORVERMISMATCH.
Dec 25 2019, 1:15 AM

Dec 22 2019

rmacklem committed rS355993: Update the nfsstat man page to reflect r355992..
Update the nfsstat man page to reflect r355992.
Dec 22 2019, 12:36 AM
rmacklem committed rS355992: Update nfsstat to list the NFSv4.2 procedures and operations..
Update nfsstat to list the NFSv4.2 procedures and operations.
Dec 22 2019, 12:12 AM

Dec 20 2019

rmacklem committed rS355967: MFC: r355157, r355161.
MFC: r355157, r355161
Dec 20 2019, 11:08 PM
rmacklem committed rS355966: MFC: r355157, r355161.
MFC: r355157, r355161
Dec 20 2019, 10:53 PM
rmacklem committed rS355960: Update the man page to reflect the addition of NFSv4.2 (r355677)..
Update the man page to reflect the addition of NFSv4.2 (r355677).
Dec 20 2019, 9:45 PM
rmacklem committed rS355958: Update the man page to reflect the addition of NFSv4.2 (r355677)..
Update the man page to reflect the addition of NFSv4.2 (r355677).
Dec 20 2019, 9:41 PM
rmacklem committed rS355956: Update the man page to reflect the addition of NFSv4.2 (r355677)..
Update the man page to reflect the addition of NFSv4.2 (r355677).
Dec 20 2019, 9:31 PM
rmacklem committed rS355954: Update the man page to reflect the addition of NFSv4.2 (r355677)..
Update the man page to reflect the addition of NFSv4.2 (r355677).
Dec 20 2019, 9:25 PM

Dec 14 2019

rmacklem committed rS355758: Update the mount_nfs.8 man page to include NFSv4.2..
Update the mount_nfs.8 man page to include NFSv4.2.
Dec 14 2019, 9:49 PM

Dec 13 2019

rmacklem committed rS355733: Silence some "might not be initialized" warnings for riscv64..
Silence some "might not be initialized" warnings for riscv64.
Dec 13 2019, 9:38 PM
rmacklem committed rS355715: Add an entry to RELNOTES for r355677..
Add an entry to RELNOTES for r355677.
Dec 13 2019, 4:29 PM
rmacklem committed rS355684: Add some more initializations to quiet riscv build..
Add some more initializations to quiet riscv build.
Dec 13 2019, 1:34 AM
rmacklem committed rS355682: Fix the build for MAC not defined and a couple of might not be initialized..
Fix the build for MAC not defined and a couple of might not be initialized.
Dec 13 2019, 12:45 AM
rmacklem committed rS355681: r355677 requires that vop_stdioctl() be global so it can be called from NFS..
r355677 requires that vop_stdioctl() be global so it can be called from NFS.
Dec 13 2019, 12:14 AM

Dec 12 2019

rmacklem committed rS355679: Bump __FreeBSD_version since r355677 changes the internal interface.
Bump __FreeBSD_version since r355677 changes the internal interface
Dec 12 2019, 11:37 PM
rmacklem committed rS355678: Add an entry to UPDATING for r355677..
Add an entry to UPDATING for r355677.
Dec 12 2019, 11:33 PM
rmacklem committed rS355677: Add support for NFSv4.2 to the NFS client and server..
Add support for NFSv4.2 to the NFS client and server.
Dec 12 2019, 11:23 PM
rmacklem committed rS355675: Merge in an up to date kernel from head..
Merge in an up to date kernel from head.
Dec 12 2019, 10:37 PM
rmacklem committed rS355674: MFC: r354989.
MFC: r354989
Dec 12 2019, 10:00 PM

Dec 8 2019

rmacklem committed rS355539: Merge in an up to date kernel from head..
Merge in an up to date kernel from head.
Dec 8 2019, 10:37 PM
rmacklem committed rS355530: Delete an unused external declaration..
Delete an unused external declaration.
Dec 8 2019, 4:59 PM
rmacklem committed rS355509: Fix kernel handling of a NFSERR_MINORVERSMISMATCH NFSv4 server reply..
Fix kernel handling of a NFSERR_MINORVERSMISMATCH NFSv4 server reply.
Dec 8 2019, 12:06 AM

Dec 7 2019

rmacklem committed rS355507: Add some definitions for NFSv4.2 which will be used by subsequent commits..
Add some definitions for NFSv4.2 which will be used by subsequent commits.
Dec 7 2019, 11:14 PM
rmacklem committed rS355479: Set the XATTRSUPPORT attribute bit for NFSv4.2, always cleared for now..
Set the XATTRSUPPORT attribute bit for NFSv4.2, always cleared for now.
Dec 7 2019, 1:10 AM

Dec 6 2019

rmacklem committed rS355472: Add a couple of definitions for NFSv4.2 and update macros to use them..
Add a couple of definitions for NFSv4.2 and update macros to use them.
Dec 6 2019, 11:51 PM
rmacklem committed rS355435: Add some definitions for NFSv4.2 which will be used by subsequent commits..
Add some definitions for NFSv4.2 which will be used by subsequent commits.
Dec 6 2019, 1:53 AM

Dec 4 2019

rmacklem committed rS355406: Add some definitions for NFSv4.2 which will be used by subsequent commits..
Add some definitions for NFSv4.2 which will be used by subsequent commits.
Dec 4 2019, 11:24 PM

Dec 2 2019

rmacklem committed rS355278: Merge in an up to date head kernel..
Merge in an up to date head kernel.
Dec 2 2019, 12:12 AM

Nov 28 2019

rmacklem committed rS355194: Fix two races while handling nfsuserd daemon start/stop..
Fix two races while handling nfsuserd daemon start/stop.
Nov 28 2019, 11:34 PM
rmacklem closed D22377: fix two races in kernel handling of the nfsuserd daemon.
Nov 28 2019, 11:34 PM
rmacklem committed rS355161: Change r355157 to make svc_rpc_gss_lifetime_max a static..
Change r355157 to make svc_rpc_gss_lifetime_max a static.
Nov 28 2019, 2:19 AM
rmacklem committed rS355157: Add a cap on credential lifetime for Kerberized NFS..
Add a cap on credential lifetime for Kerberized NFS.
Nov 28 2019, 2:05 AM

Nov 25 2019

rmacklem committed rS355090: Merge in an up to date kernel from head/current..
Merge in an up to date kernel from head/current.
Nov 25 2019, 3:24 PM

Nov 22 2019

rmacklem committed rS354989: Fix the pNFS server's reporting of SpaceUsed (va_bytes)..
Fix the pNFS server's reporting of SpaceUsed (va_bytes).
Nov 22 2019, 12:23 AM

Nov 17 2019

rmacklem committed rS354784: Add support for Allocate to the pNFS server..
Add support for Allocate to the pNFS server.
Nov 17 2019, 3:54 AM

Nov 16 2019

rmacklem updated the diff for D22377: fix two races in kernel handling of the nfsuserd daemon.

Add a check for nfsrv_nfsuserd == STARTSTOP to the wakeup(), to avoid extraneous
wakeup() calls.
Also add a KASSERT() for nfsrv_userdupcalls.

Nov 16 2019, 4:31 PM
rmacklem updated the diff for D22377: fix two races in kernel handling of the nfsuserd daemon.

Oops, I've realized there are other fields of nfsrv_nfsuserdsock that are
used by newnfs_request(), so holding a reference count on *nr_client isn't
sufficient.

Nov 16 2019, 6:37 AM
rmacklem updated the diff for D22377: fix two races in kernel handling of the nfsuserd daemon.

Move the NFSUNLOCKNAMEID() up so that it only updates the nr_client field
before unlocking and add a comment related to this.

Nov 16 2019, 2:24 AM
rmacklem added a comment to D22377: fix two races in kernel handling of the nfsuserd daemon.

Updated my inline comment reply.

Nov 16 2019, 1:03 AM
rmacklem added a comment to D22377: fix two races in kernel handling of the nfsuserd daemon.

Replied to inline comments.

Nov 16 2019, 12:50 AM

Nov 15 2019

rmacklem created D22377: fix two races in kernel handling of the nfsuserd daemon.
Nov 15 2019, 1:09 AM

Nov 10 2019

rmacklem committed rS354576: Update the VOP_COPY_FILE_RANGE man page to reflect the semantic change.
Update the VOP_COPY_FILE_RANGE man page to reflect the semantic change
Nov 10 2019, 1:21 AM
rmacklem committed rS354575: Update the copy_file_range man page to reflect the semantic change.
Update the copy_file_range man page to reflect the semantic change
Nov 10 2019, 1:13 AM
rmacklem committed rS354574: Update copy_file_range(2) to be Linux5 compatible..
Update copy_file_range(2) to be Linux5 compatible.
Nov 10 2019, 1:08 AM

Nov 9 2019

rmacklem committed rS354567: Merge in an up to date kernel from head..
Merge in an up to date kernel from head.
Nov 9 2019, 12:17 AM

Nov 8 2019

rmacklem committed rS354566: Update the VOP_COPY_FILE_RANGE.9 man page to reflect the semantic change.
Update the VOP_COPY_FILE_RANGE.9 man page to reflect the semantic change
Nov 8 2019, 11:58 PM
rmacklem committed rS354565: Update the copy_file_range.2 man page to reflect the semantic change.
Update the copy_file_range.2 man page to reflect the semantic change
Nov 8 2019, 11:49 PM
rmacklem committed rS354564: Update copy_file_range(2) to be Linux5 compatible..
Update copy_file_range(2) to be Linux5 compatible.
Nov 8 2019, 11:39 PM
rmacklem committed rS354528: Fix the man page to correctly describe the use of the "len" argument..
Fix the man page to correctly describe the use of the "len" argument.
Nov 8 2019, 6:40 AM

Nov 4 2019

rmacklem committed rS354329: Fix up the NFSv4.2 client/server for pNFS..
Fix up the NFSv4.2 client/server for pNFS.
Nov 4 2019, 6:16 AM

Nov 3 2019

rmacklem committed rS354274: Fix vnode locking for the case where Seek is proxied to the DS server..
Fix vnode locking for the case where Seek is proxied to the DS server.
Nov 3 2019, 3:16 AM
rmacklem committed rS354271: Fix lsextattr for the case where there are no attributes..
Fix lsextattr for the case where there are no attributes.
Nov 3 2019, 2:17 AM

Oct 30 2019

rmacklem committed rS354164: MFC: r352736.
MFC: r352736
Oct 30 2019, 1:57 AM