Page MenuHomeFreeBSD

rmacklem (Rick Macklem)
User

Projects

User Details

User Since
Jan 13 2015, 10:58 PM (340 w, 6 d)

Recent Activity

Sun, Jul 25

rmacklem committed R10:8e24b25b67bb: nfscl: Avoid KASSERT() panic in cache_enter_time() (authored by rmacklem).
nfscl: Avoid KASSERT() panic in cache_enter_time()
Sun, Jul 25, 9:49 PM

Tue, Jul 20

rmacklem committed R10:7685f8344d9a: nfscl: Send stateid.seqid of 0 for NFSv4.1/4.2 mounts (authored by rmacklem).
nfscl: Send stateid.seqid of 0 for NFSv4.1/4.2 mounts
Tue, Jul 20, 12:39 AM

Fri, Jul 16

rmacklem committed R10:be7c64704edf: RELNOTES: Add an entry for commit ee29e6f31111 (authored by rmacklem).
RELNOTES: Add an entry for commit ee29e6f31111
Fri, Jul 16, 10:37 PM
rmacklem committed R10:7fa21b6dc6ed: UPDATING: Add entry for commit ee29e6f31111 (authored by rmacklem).
UPDATING: Add entry for commit ee29e6f31111
Fri, Jul 16, 10:27 PM
rmacklem committed R10:fad3f322efb5: param.h: Bump __FreeBSD_version to 1400026 for commit ee29e6f31111 (authored by rmacklem).
param.h: Bump __FreeBSD_version to 1400026 for commit ee29e6f31111
Fri, Jul 16, 10:17 PM
rmacklem closed D30826: create a sysctl so that the maximum I/O size on the NFS server can be increased to 1Mbyte.
Fri, Jul 16, 10:09 PM
rmacklem committed R10:ee29e6f31111: nfsd: Add sysctl to set maximum I/O size up to 1Mbyte (authored by rmacklem).
nfsd: Add sysctl to set maximum I/O size up to 1Mbyte
Fri, Jul 16, 10:09 PM
rmacklem added inline comments to D30826: create a sysctl so that the maximum I/O size on the NFS server can be increased to 1Mbyte.
Fri, Jul 16, 2:03 AM
rmacklem updated the diff for D30826: create a sysctl so that the maximum I/O size on the NFS server can be increased to 1Mbyte.

Change the comment that describes the kern.ipc.maxsockbuf
suggested value, in order to clarify what the calculation is.

Fri, Jul 16, 2:01 AM

Thu, Jul 15

rmacklem added a comment to D30826: create a sysctl so that the maximum I/O size on the NFS server can be increased to 1Mbyte.

Yes, since kern.maxsockbuf can be set in sysctl.conf, I wanted
vfs.nfsd.srvmaxio to be set that way as well.
It can also be changed without rebooting the server, by stopping
and restarting the nfsd.

Thu, Jul 15, 3:33 AM
rmacklem added a comment to D30826: create a sysctl so that the maximum I/O size on the NFS server can be increased to 1Mbyte.

Just fyi Dave, the change that makes nfs_bufpackets global was
just MFC'd to stable/13. It was in a commit already applied
to "main".

Thu, Jul 15, 2:09 AM
rmacklem added a comment to D30826: create a sysctl so that the maximum I/O size on the NFS server can be increased to 1Mbyte.

Made inline comment on calculation.

Thu, Jul 15, 2:00 AM

Wed, Jul 14

rmacklem committed R10:cd2e5ae71bb1: nfscl: Improve "Consider increasing kern.ipc.maxsockbuf" message (authored by rmacklem).
nfscl: Improve "Consider increasing kern.ipc.maxsockbuf" message
Wed, Jul 14, 8:49 PM
rmacklem committed R10:7f5508fe78d1: nfscl: Avoid KASSERT() panic in cache_enter_time() (authored by rmacklem).
nfscl: Avoid KASSERT() panic in cache_enter_time()
Wed, Jul 14, 8:37 PM

Tue, Jul 13

rmacklem accepted D31167: nfsclient: Avoid copying uninitialized bytes into statfs.

This looks ok to me. It does assume that "mnt_stat" is initialized '0', but that is the case.

Tue, Jul 13, 11:46 PM

Sun, Jul 11

rmacklem committed R10:ac0343b88ddc: RELNOTES: Add an entry for commit 8a04edfdcbd2 (authored by rmacklem).
RELNOTES: Add an entry for commit 8a04edfdcbd2
Sun, Jul 11, 10:48 PM
rmacklem committed R10:e5c2f39823d1: UPDATING: Add an entry for commit 8a04edfdcbd2 (authored by rmacklem).
UPDATING: Add an entry for commit 8a04edfdcbd2
Sun, Jul 11, 10:42 PM
rmacklem committed R10:50f2705d2674: mount_nfs.8: Update the man page for commit a145cf3f73c7 (authored by rmacklem).
mount_nfs.8: Update the man page for commit a145cf3f73c7
Sun, Jul 11, 10:34 PM
rmacklem committed R10:8a04edfdcbd2: nfscl: Change the default minor version for NFSv4 mounts (authored by rmacklem).
nfscl: Change the default minor version for NFSv4 mounts
Sun, Jul 11, 10:31 PM
rmacklem committed R10:4488c8c34ba3: mount_nfs.8: Add information for "nconnect" to man page (authored by rmacklem).
mount_nfs.8: Add information for "nconnect" to man page
Sun, Jul 11, 8:38 PM
rmacklem closed D31135: add information on the "nconnect" mount option to the man page.
Sun, Jul 11, 8:37 PM
rmacklem added a reviewer for D30826: create a sysctl so that the maximum I/O size on the NFS server can be increased to 1Mbyte: markj.
Sun, Jul 11, 12:48 AM
rmacklem updated the diff for D30826: create a sysctl so that the maximum I/O size on the NFS server can be increased to 1Mbyte.

Add locking using NFSD_LOCK()/NFSD_UNLOCK() to
the sysctl function to ensure that the nfsd threads are
not running when vfs.nfsd.srvmaxio is updated.

Sun, Jul 11, 12:47 AM
rmacklem requested review of D31135: add information on the "nconnect" mount option to the man page.
Sun, Jul 11, 12:23 AM

Fri, Jul 9

rmacklem committed R10:bd597b814933: UPDATING: Add an entry for commit 1e0a518d6548 (authored by rmacklem).
UPDATING: Add an entry for commit 1e0a518d6548
Fri, Jul 9, 1:34 AM
rmacklem closed D30970: add a "nconnect" mount option to the NFS client.
Fri, Jul 9, 12:44 AM
rmacklem committed R10:1e0a518d6548: nfscl: Add a Linux compatible "nconnect" mount option (authored by rmacklem).
nfscl: Add a Linux compatible "nconnect" mount option
Fri, Jul 9, 12:44 AM

Wed, Jul 7

rmacklem added inline comments to D30970: add a "nconnect" mount option to the NFS client.
Wed, Jul 7, 8:31 PM
rmacklem updated the diff for D30970: add a "nconnect" mount option to the NFS client.

I had used NFSLOCKMNT(nmp) instead of atomic..() because I wanted
to maintain nm_nextaconn at < nm_aconnect and couldn't do "%" via
an atomic.

Wed, Jul 7, 8:21 PM
rmacklem added inline comments to D30970: add a "nconnect" mount option to the NFS client.
Wed, Jul 7, 12:43 AM
rmacklem updated the diff for D30970: add a "nconnect" mount option to the NFS client.

As suggested by markj@, this patch redefines the fields in
struct nfsmount as additional connections, to somewhat simplify
the code.
nm_nconnect renamed to nm_aconnect
nm_nextnconn renamed to nm_nextaconn

Wed, Jul 7, 12:39 AM

Tue, Jul 6

rmacklem added inline comments to D30970: add a "nconnect" mount option to the NFS client.
Tue, Jul 6, 11:33 PM
rmacklem updated the diff for D30970: add a "nconnect" mount option to the NFS client.

If the last catch was good, this one is a great catch.
I'm a little embarrassed that I didn't think to make
manipulation of nm_nextnconn MP-safe.

Tue, Jul 6, 11:15 PM
rmacklem added inline comments to D30970: add a "nconnect" mount option to the NFS client.
Tue, Jul 6, 12:52 AM
rmacklem updated the diff for D30970: add a "nconnect" mount option to the NFS client.

Add NFSPROC_READDIRPLUS to the list of RPCs
with large messages as suggested by markj@.

Tue, Jul 6, 12:41 AM

Mon, Jul 5

rmacklem updated the diff for D30970: add a "nconnect" mount option to the NFS client.

This patch depends on the property that the NFS
server sends the RPC reply on the same TCP connection
as the one the request was received on. Although the
FreeBSD server always does this, it is only required
for NFSv4.1/4.2 (RFC 5661)

Mon, Jul 5, 3:24 AM

Thu, Jul 1

rmacklem updated the diff for D30970: add a "nconnect" mount option to the NFS client.

This comment was imbedded in a recent email message on linu-nfs@vger.kernel.org.
Although other posters felt more evidence was needed to determine this,
it at least suggests that separating the large RPC messages from the small ones may
improve performance under certain circumstances.

The original issue described was how a high read/write process on the
client could slow another process trying to do heavy metadata
operations (like walking the filesystem). Using a different mount to
the same multi-homed server seems to help a lot (probably because of
the independent slot table).

Thu, Jul 1, 11:23 PM
rmacklem requested review of D30970: add a "nconnect" mount option to the NFS client.
Thu, Jul 1, 1:35 AM

Wed, Jun 30

rmacklem committed R10:c5f4772c66d2: nfscl: Improve "Consider increasing kern.ipc.maxsockbuf" message (authored by rmacklem).
nfscl: Improve "Consider increasing kern.ipc.maxsockbuf" message
Wed, Jun 30, 10:20 PM
rmacklem committed R10:a5b5a24d1abe: nfscl: Make NFSv4.0 client acquisition NFSv4.1/4.2 compatible (authored by rmacklem).
nfscl: Make NFSv4.0 client acquisition NFSv4.1/4.2 compatible
Wed, Jun 30, 1:20 AM

Jun 26 2021

rmacklem committed R10:368799beba4a: UPDATING: Add an entry for commit 6ae32cc8182f (authored by rmacklem).
UPDATING: Add an entry for commit 6ae32cc8182f
Jun 26 2021, 11:56 PM
rmacklem committed R10:489236b04748: param.h: Bump __FreeBSD_version for commit 6ae32cc8182f (authored by rmacklem).
param.h: Bump __FreeBSD_version for commit 6ae32cc8182f
Jun 26 2021, 11:52 PM
rmacklem committed R10:6ae32cc8182f: krpc: Acquire ref count of CLIENT for backchannel use (authored by rmacklem).
krpc: Acquire ref count of CLIENT for backchannel use
Jun 26 2021, 11:42 PM
rmacklem committed R10:88878ea4e410: nfscl: Fix generation of va_fsid for a tree of NFSv4 server file systems (authored by rmacklem).
nfscl: Fix generation of va_fsid for a tree of NFSv4 server file systems
Jun 26 2021, 11:38 PM
rmacklem committed R10:d6805ab0df54: UPDATING: Add entry for commit 841006678745 (authored by rmacklem).
UPDATING: Add entry for commit 841006678745
Jun 26 2021, 11:23 PM
rmacklem committed R10:eb3397588e1b: param.h: Bump __FreeBSD_version to 1300510 for commit 841006678745 (authored by rmacklem).
param.h: Bump __FreeBSD_version to 1300510 for commit 841006678745
Jun 26 2021, 11:17 PM
rmacklem committed R10:841006678745: krpc: Acquire ref count of CLIENT for backchannel use (authored by rmacklem).
krpc: Acquire ref count of CLIENT for backchannel use
Jun 26 2021, 11:09 PM
rmacklem committed R10:6c5dae287ee7: nfscl: Add a "has acquired a delegation" flag for delegations (authored by rmacklem).
nfscl: Add a "has acquired a delegation" flag for delegations
Jun 26 2021, 11:05 PM
rmacklem committed R10:b1caf1920f83: nfscl: Fix generation of va_fsid for a tree of NFSv4 server file systems (authored by rmacklem).
nfscl: Fix generation of va_fsid for a tree of NFSv4 server file systems
Jun 26 2021, 11:02 PM
rmacklem committed R10:6078d52fa12a: nfsd: Fix NFSv4.1/4.2 Secinfo_no_name when security flavors empty (authored by rmacklem).
nfsd: Fix NFSv4.1/4.2 Secinfo_no_name when security flavors empty
Jun 26 2021, 11:00 PM
rmacklem committed R10:9f581cbd5aac: nfsd: Fix when NFSERR_WRONGSEC may be replied to NFSv4 clients (authored by rmacklem).
nfsd: Fix when NFSERR_WRONGSEC may be replied to NFSv4 clients
Jun 26 2021, 10:57 PM
rmacklem committed R10:54ccbc9bb6c5: nfsd: Pre-parse the next NFSv4 operation number for put FH operations (authored by rmacklem).
nfsd: Pre-parse the next NFSv4 operation number for put FH operations
Jun 26 2021, 10:54 PM
rmacklem committed R10:92500ec0c45c: nfsd: Fix the failure return for non-fh NFSv4 operations (authored by rmacklem).
nfsd: Fix the failure return for non-fh NFSv4 operations
Jun 26 2021, 10:51 PM
rmacklem committed R10:0da79992428f: nfsd: Delete extraneous NFSv4 root checks (authored by rmacklem).
nfsd: Delete extraneous NFSv4 root checks
Jun 26 2021, 10:47 PM
rmacklem committed R10:3747e3b28ee6: nfsd: Add support for the NFSv4.1/4.2 Secinfo_no_name operation (authored by rmacklem).
nfsd: Add support for the NFSv4.1/4.2 Secinfo_no_name operation
Jun 26 2021, 10:44 PM
rmacklem closed D30768: update the mount_nfs.8 man page for a change in default minor version for NFSv4.
Jun 26 2021, 9:13 PM
rmacklem committed R10:b413b03597db: mount_nfs.8: Update the man page for commit a145cf3f73c7 (authored by rmacklem).
mount_nfs.8: Update the man page for commit a145cf3f73c7
Jun 26 2021, 9:13 PM

Jun 25 2021

rmacklem added inline comments to D30768: update the mount_nfs.8 man page for a change in default minor version for NFSv4.
Jun 25 2021, 11:35 PM
rmacklem updated the diff for D30768: update the mount_nfs.8 man page for a change in default minor version for NFSv4.

Fixed nfsstat to be 1 instead of 8.

Jun 25 2021, 11:34 PM
rmacklem added a comment to D30768: update the mount_nfs.8 man page for a change in default minor version for NFSv4.

Sorry, I don't understand your comment. mount_nfs.8.sav is
simply the old (what is in "main") version that is being patched.

Jun 25 2021, 9:04 PM
rmacklem added a reviewer for D30768: update the mount_nfs.8 man page for a change in default minor version for NFSv4: otis.
Jun 25 2021, 2:34 PM
rmacklem committed R10:b49ba74deeb7: nfscl: Add entries to UPDATING and RELNOTES for commit a145cf3f73c7 (authored by rmacklem).
nfscl: Add entries to UPDATING and RELNOTES for commit a145cf3f73c7
Jun 25 2021, 2:15 AM
rmacklem committed R10:a145cf3f73c7: nfscl: Change the default minor version for NFSv4 mounts (authored by rmacklem).
nfscl: Change the default minor version for NFSv4 mounts
Jun 25 2021, 1:56 AM

Jun 20 2021

rmacklem updated the diff for D30826: create a sysctl so that the maximum I/O size on the NFS server can be increased to 1Mbyte.

Add printf()s indicating why setting vfs.nfsd.srvmaxio failed.

Jun 20 2021, 5:18 AM
rmacklem requested review of D30826: create a sysctl so that the maximum I/O size on the NFS server can be increased to 1Mbyte.
Jun 20 2021, 4:47 AM

Jun 16 2021

rmacklem committed R10:aed98fa5acb1: nfscl: Make NFSv4.0 client acquisition NFSv4.1/4.2 compatible (authored by rmacklem).
nfscl: Make NFSv4.0 client acquisition NFSv4.1/4.2 compatible
Jun 16 2021, 12:52 AM

Jun 15 2021

rmacklem requested review of D30768: update the mount_nfs.8 man page for a change in default minor version for NFSv4.
Jun 15 2021, 12:44 AM

Jun 12 2021

rmacklem committed R10:5860696e69ec: UPDATING: Add entry for __FreeBSD_version bump to 1400022 (authored by rmacklem).
UPDATING: Add entry for __FreeBSD_version bump to 1400022
Jun 12 2021, 2:03 AM
rmacklem committed R10:40cc9a3a6b81: param.h: Bump __FreeBSD_version to 1400022 (authored by rmacklem).
param.h: Bump __FreeBSD_version to 1400022
Jun 12 2021, 1:57 AM
rmacklem committed R10:972883b9e06e: nfscl: Use hash lists to improve expected search performance for opens (authored by rmacklem).
nfscl: Use hash lists to improve expected search performance for opens
Jun 12 2021, 1:31 AM
rmacklem committed R10:624a723a955b: nfscl: Use hash lists to improve expected search performance for opens (authored by rmacklem).
nfscl: Use hash lists to improve expected search performance for opens
Jun 12 2021, 1:23 AM
rmacklem committed R10:e1a907a25cfa: krpc: Acquire ref count of CLIENT for backchannel use (authored by rmacklem).
krpc: Acquire ref count of CLIENT for backchannel use
Jun 12 2021, 12:02 AM
rmacklem closed D30153: acquire a reference count on the CLIENT structure for callbacks in the server krpc.
Jun 12 2021, 12:02 AM

Jun 9 2021

rmacklem committed R10:5e5ca4c8fc53: nfscl: Add a "has acquired a delegation" flag for delegations (authored by rmacklem).
nfscl: Add a "has acquired a delegation" flag for delegations
Jun 9 2021, 3:04 PM

Jun 8 2021

rmacklem updated the diff for D30153: acquire a reference count on the CLIENT structure for callbacks in the server krpc.

Update comments to clarify what xp_p2 points to
on both the server (client end for callbacks) and
client (server end for callbacks).

Jun 8 2021, 12:35 AM

Jun 7 2021

rmacklem committed R10:03c81af24920: nfscl: Fix generation of va_fsid for a tree of NFSv4 server file systems (authored by rmacklem).
nfscl: Fix generation of va_fsid for a tree of NFSv4 server file systems
Jun 7 2021, 8:52 PM
rmacklem closed D30660: fix va_fsid in the NFSv4 client for a tree of server file systems.
Jun 7 2021, 8:52 PM
rmacklem added a comment to D30660: fix va_fsid in the NFSv4 client for a tree of server file systems.

I just did a little experiment where I had the server file systems
mounted in a shallow tree (side by side under the exported root)
and where all these server file systems (other than the root) were
assigned the same va_fsid.

Jun 7 2021, 12:54 AM

Jun 6 2021

rmacklem added inline comments to D30660: fix va_fsid in the NFSv4 client for a tree of server file systems.
Jun 6 2021, 11:49 PM
rmacklem added a comment to D30660: fix va_fsid in the NFSv4 client for a tree of server file systems.

Everything in your comment is correct.

Jun 6 2021, 11:48 PM
rmacklem requested review of D30660: fix va_fsid in the NFSv4 client for a tree of server file systems.
Jun 6 2021, 2:41 PM

Jun 5 2021

rmacklem committed R10:a5df139ec614: nfsd: Fix when NFSERR_WRONGSEC may be replied to NFSv4 clients (authored by rmacklem).
nfsd: Fix when NFSERR_WRONGSEC may be replied to NFSv4 clients
Jun 5 2021, 11:59 PM
rmacklem committed R10:56e9d8e38e7e: nfsd: Fix NFSv4.1/4.2 Secinfo_no_name when security flavors empty (authored by rmacklem).
nfsd: Fix NFSv4.1/4.2 Secinfo_no_name when security flavors empty
Jun 5 2021, 3:35 AM
rmacklem committed R10:4fee353bcb45: nfscl: Add hash lists for the NFSv4 opens (authored by rmacklem).
nfscl: Add hash lists for the NFSv4 opens
Jun 5 2021, 1:20 AM

Jun 4 2021

rmacklem committed R10:d224f05fcfc1: nfsd: Pre-parse the next NFSv4 operation number for put FH operations (authored by rmacklem).
nfsd: Pre-parse the next NFSv4 operation number for put FH operations
Jun 4 2021, 3:54 AM
rmacklem committed R10:b1461cdd30a9: nfsd: Add support for CLAIM_DELEG_PREV_FH to the NFSv4.1/4.2 Open (authored by rmacklem).
nfsd: Add support for CLAIM_DELEG_PREV_FH to the NFSv4.1/4.2 Open
Jun 4 2021, 3:35 AM
rmacklem committed R10:5713766d6317: nfsd: Add support for CLAIM_DELEG_PREV_FH to the NFSv4.1/4.2 Open (authored by rmacklem).
nfsd: Add support for CLAIM_DELEG_PREV_FH to the NFSv4.1/4.2 Open
Jun 4 2021, 3:31 AM
rmacklem committed R10:8513b4f15362: nfscl: Fix NFSv4.1/4.2 mount recovery from an expired lease (authored by rmacklem).
nfscl: Fix NFSv4.1/4.2 mount recovery from an expired lease
Jun 4 2021, 3:22 AM

Jun 3 2021

rmacklem added a reverting change for R10:5a8b2c5a46df: nfscl: Fix NFSv4.1/4.2 mount recovery from an expired lease: R10:7f527ae46b06: nfscl: Revert commit 5a8b2c5a46dffa3828ad16abee36ac4676f741bf.
Jun 3 2021, 1:17 AM
rmacklem committed R10:7f527ae46b06: nfscl: Revert commit 5a8b2c5a46dffa3828ad16abee36ac4676f741bf (authored by rmacklem).
nfscl: Revert commit 5a8b2c5a46dffa3828ad16abee36ac4676f741bf
Jun 3 2021, 1:17 AM
rmacklem committed R10:5a8b2c5a46df: nfscl: Fix NFSv4.1/4.2 mount recovery from an expired lease (authored by rmacklem).
nfscl: Fix NFSv4.1/4.2 mount recovery from an expired lease
Jun 3 2021, 12:05 AM

Jun 2 2021

rmacklem committed R10:4775325dd661: nfscl: Fix NFSv4.1/4.2 mount recovery from an expired lease (authored by rmacklem).
nfscl: Fix NFSv4.1/4.2 mount recovery from an expired lease
Jun 2 2021, 11:58 PM
rmacklem committed R10:984c71f90300: nfsd: Fix the failure return for non-fh NFSv4 operations (authored by rmacklem).
nfsd: Fix the failure return for non-fh NFSv4 operations
Jun 2 2021, 10:32 PM

Jun 1 2021

rmacklem committed R10:1d4afcaca282: nfsd: Delete extraneous NFSv4 root checks (authored by rmacklem).
nfsd: Delete extraneous NFSv4 root checks
Jun 1 2021, 2:45 AM
rmacklem committed R10:2f6ce1167391: nfsd: Add support for CLAIM_DELEG_CUR_FH to the NFSv4.1/4.2 Open (authored by rmacklem).
nfsd: Add support for CLAIM_DELEG_CUR_FH to the NFSv4.1/4.2 Open
Jun 1 2021, 1:44 AM
rmacklem committed R10:a604806bf73f: nfsd: Reduce the callback timeout to 800msec (authored by rmacklem).
nfsd: Reduce the callback timeout to 800msec
Jun 1 2021, 1:42 AM
rmacklem committed R10:628d207646a8: nfsd: Add support for CLAIM_DELEG_CUR_FH to the NFSv4.1/4.2 Open (authored by rmacklem).
nfsd: Add support for CLAIM_DELEG_CUR_FH to the NFSv4.1/4.2 Open
Jun 1 2021, 1:38 AM
rmacklem committed R10:4ce25ce4776f: nfsd: Reduce the callback timeout to 800msec (authored by rmacklem).
nfsd: Reduce the callback timeout to 800msec
Jun 1 2021, 1:32 AM

May 31 2021

rmacklem committed R10:645f01722694: NFSv4 server: Re-establish the delegation recall timeout (authored by rmacklem).
NFSv4 server: Re-establish the delegation recall timeout
May 31 2021, 3:43 AM
rmacklem committed R10:4a4a174959ce: NFSv4 server: Re-establish the delegation recall timeout (authored by rmacklem).
NFSv4 server: Re-establish the delegation recall timeout
May 31 2021, 3:38 AM