vfs_cache.c: Use CACHE_FPL_SUPPORTED_CN_FLAGS
ClosedPublic
Actions

Authored by rmacklem on May 26 2025, 2:07 AM.

Details

Reviewers

kib
markj
olce

Commits

rG0596b4a3d42f: vfs_cache.c: Use CACHE_FPL_SUPPORTED_CN_FLAGS

Summary

Commit 2ec2ba7e232d added some code to cache_can_fplookup()
which worked (ensuring an abort when OPENNNAMED was set),
but showed I didn't understand what
CACHE_FPL_SUPPORTED_CN_FLAGS was used for.

This patch cleans it up.

Test Plan

Tested on a system where ZFS is patched to do named
attributes.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rmacklem created this revision.May 26 2025, 2:07 AM

Herald added a subscriber: imp. · View Herald TranscriptMay 26 2025, 2:07 AM

rmacklem requested review of this revision.May 26 2025, 2:07 AM

markj accepted this revision.May 26 2025, 2:28 AM

This revision is now accepted and ready to land.May 26 2025, 2:28 AM

markj added inline comments.May 26 2025, 2:29 AM

sys/kern/vfs_cache.c
4459	It's a bug that I did not include NAMEILOOKUP here. But due to a different bug that I just discovered, that flag is inadvertently cleared some of the time before we even get here. I'll post patches for these issues shortly.