Page MenuHomeFreeBSD

ZFSUmbrella
ActivePublic

Details

Description

Various work on OpenZFS and ZFS/FreeBSD.

Recent Activity

Fri, Dec 14

bcr updated the diff for D18541: Add ZFS usage examples to the freebsd-tips file.

Update with suggestions by Dru.

Fri, Dec 14, 7:17 PM · ZFS
dru added a comment to D18541: Add ZFS usage examples to the freebsd-tips file.

These look great!

Fri, Dec 14, 7:14 PM · ZFS

Thu, Dec 13

bcr created D18541: Add ZFS usage examples to the freebsd-tips file.
Thu, Dec 13, 6:20 PM · ZFS

Nov 9 2018

mav added a member for ZFS: mav.
Nov 9 2018, 5:59 PM

Oct 12 2018

mav closed D17523: Make ZFS indirect (removed) vdevs support TRIM.
Oct 12 2018, 3:14 PM · ZFS
allanjude accepted D17523: Make ZFS indirect (removed) vdevs support TRIM.
Oct 12 2018, 2:00 AM · ZFS
allanjude added inline comments to D17523: Make ZFS indirect (removed) vdevs support TRIM.
Oct 12 2018, 1:48 AM · ZFS

Oct 11 2018

mav added inline comments to D17523: Make ZFS indirect (removed) vdevs support TRIM.
Oct 11 2018, 9:16 PM · ZFS
sef added inline comments to D17523: Make ZFS indirect (removed) vdevs support TRIM.
Oct 11 2018, 9:13 PM · ZFS
mav created D17523: Make ZFS indirect (removed) vdevs support TRIM.
Oct 11 2018, 9:06 PM · ZFS

Aug 29 2018

slw_zxy.spb.ru added a comment to D7538: Correct adaptation ZFS ARC memory pressure to FreeBSD.
  1. ARC don't rised, memory pressure does not arise, page daemon not activated.

The ARC is not growing after 8, but the ARC hit rate is too low. Why is it not growing? Is it because the free_memory < (arc_c >> arc_no_grow_shift) condition is true, or is there some other reason?

Aug 29 2018, 7:57 PM · ZFS
markj added a comment to D7538: Correct adaptation ZFS ARC memory pressure to FreeBSD.
In D7538#361135, @markj wrote:

No, lots of memory in mbuf cache independ of memory pressure/page daemon in my workload:

  1. net workload raise
  2. mbuf consumption rise
  3. free memory reduction
  4. ARC reacts to free memory reduction by ARC reduction
  5. net workload reduction started
  6. mbuf released to zone cache
  7. free memory don't raised
  8. ARC don't rised, memory pressure does not arise, page daemon not activated.
Aug 29 2018, 7:37 PM · ZFS

Aug 28 2018

slw_zxy.spb.ru added a comment to D7538: Correct adaptation ZFS ARC memory pressure to FreeBSD.
In D7538#361135, @markj wrote:

To be clear, I'm just stating that r332365 changed zfs_arc_free_target to be equal vm_cnt.v_free_target. It looks to me that this is equivalent to the change you made to arc_available_memory(EXCLUDE_ZONE_CACHE), where v_free_target is referenced directly.

No.

arc_available_memory(EXCLUDE_ZONE_CACHE) check conditions for memory pressure, check how many free memory see by OS (and kmem cache not counted for this).

Yes, which is exactly what the computation freemem - zfs_arc_free_target is. If you expand these definitions, it is vm_cnt.v_free_count - vm_cnt.v_free_target, where v_free_count does not include UMA caches. When v_free_count < v_free_target, the system is under memory pressure, and the page daemon attempts to free pages until v_free_count >= v_free_target. In -CURRENT, you can think of needfree as being the same as v_free_target - v_free_target when this difference is positive. In stable branches this is not quite true.

Aug 28 2018, 11:12 PM · ZFS
markj added a comment to D7538: Correct adaptation ZFS ARC memory pressure to FreeBSD.

To be clear, I'm just stating that r332365 changed zfs_arc_free_target to be equal vm_cnt.v_free_target. It looks to me that this is equivalent to the change you made to arc_available_memory(EXCLUDE_ZONE_CACHE), where v_free_target is referenced directly.

No.

arc_available_memory(EXCLUDE_ZONE_CACHE) check conditions for memory pressure, check how many free memory see by OS (and kmem cache not counted for this).

Aug 28 2018, 9:04 PM · ZFS

Aug 23 2018

slw_zxy.spb.ru added a comment to D7538: Correct adaptation ZFS ARC memory pressure to FreeBSD.

To be clear, I'm just stating that r332365 changed zfs_arc_free_target to be equal vm_cnt.v_free_target. It looks to me that this is equivalent to the change you made to arc_available_memory(EXCLUDE_ZONE_CACHE), where v_free_target is referenced directly.

Aug 23 2018, 10:04 PM · ZFS
markj added a comment to D7538: Correct adaptation ZFS ARC memory pressure to FreeBSD.
In D7538#358922, @markj wrote:
  • The FMR_NEEDFREE target in -CURRENT is now the same as in this patch (though I didn't realize that when I made the change). See r332365.

Are you sure? A im still see 'r = FMR_LOTSFREE;' at line 4624

r332365: Discussed. Not very impotant. I am don't touch this is patch, may be zfs_arc_free_target is badly nameed (this target used as zfs_arc_min_free_target and I am use for my setup v_free_targetx1.4).
Any way, this is sysctl and can be tuned.

Aug 23 2018, 3:12 PM · ZFS
slw_zxy.spb.ru added a comment to D7538: Correct adaptation ZFS ARC memory pressure to FreeBSD.
In D7538#358922, @markj wrote:

Sorry that this review has stalled lately. I would like to compare this patch to what's in -CURRENT, which has evolved a fair bit since the patch was updated. Once that picture is more clear, we can focus on stable/11.

Aug 23 2018, 1:26 PM · ZFS

Aug 22 2018

markj added a comment to D7538: Correct adaptation ZFS ARC memory pressure to FreeBSD.

Sorry that this review has stalled lately. I would like to compare this patch to what's in -CURRENT, which has evolved a fair bit since the patch was updated. Once that picture is more clear, we can focus on stable/11.

Aug 22 2018, 10:33 PM · ZFS

Aug 7 2018

mmacy added a reviewer for D7538: Correct adaptation ZFS ARC memory pressure to FreeBSD: jeff.
Aug 7 2018, 9:26 PM · ZFS
rdeiriar_gmail.com added a comment to D7538: Correct adaptation ZFS ARC memory pressure to FreeBSD.

I can confirm that the patch solves the issues as described in the "lightly loaded system eats swap space" thread on freebsd-stable mailing list.
On one of my desktop systems the issue is particularly noticeable as the disk subsystem is rather slow, the system became unusable after a
weekend sitting idle. I have not experienced the issues anymore after applying the patch

Aug 7 2018, 5:04 PM · ZFS

Jul 9 2018

peixotocassiano_gmail.com added a comment to D7538: Correct adaptation ZFS ARC memory pressure to FreeBSD.

Hi there,

Jul 9 2018, 1:41 PM · ZFS

Jul 7 2018

me_cschwarz.com added a comment to D15748: Support destroy of multiple bookmarks on a single dataset..

What else is preventing this from getting merged?

Jul 7 2018, 9:02 PM · ZFS

Jun 30 2018

allanjude added a reviewer for D7538: Correct adaptation ZFS ARC memory pressure to FreeBSD: sef.
Jun 30 2018, 3:41 PM · ZFS

Jun 18 2018

FreeBSD_ShaneWare.Biz added a comment to D7538: Correct adaptation ZFS ARC memory pressure to FreeBSD.

I am looking at your comment for PR163461. 70-80% of wired memory don't have direct relation to system slowdown or hard reset (for example "Mem: 3107M Active, 10G Inact, 231G Wired, 42K Buf, 5802M Free" and no slowdown), thes symptomps are caused by very low free_memory.
In my patch I try to convert unused wired ARC memory to system-wide free memory early.

Jun 18 2018, 10:21 PM · ZFS
slw_zxy.spb.ru added a comment to D7538: Correct adaptation ZFS ARC memory pressure to FreeBSD.

I have come to realise that there is another issue related to this, the default arc_max being wired ram that is not counted in max_wired means a default setup is allowed to wire more than the physical ram installed.

See my comment here for more explanation.

Jun 18 2018, 1:53 PM · ZFS
FreeBSD_ShaneWare.Biz added a comment to D7538: Correct adaptation ZFS ARC memory pressure to FreeBSD.

I have applied this patch to stable/11 r334820 and have been running without issue for 10 days.

Jun 18 2018, 7:49 AM · ZFS

Jun 16 2018

sef closed D15562: ZFS sorted scans.
Jun 16 2018, 7:51 AM · ZFS

Jun 14 2018

me_cschwarz.com added a comment to D15748: Support destroy of multiple bookmarks on a single dataset..

Checked all 'Done' boxes, hope this is the way to use Phabricator ¯\_(ツ)_/¯

Jun 14 2018, 7:17 PM · ZFS
me_cschwarz.com updated the diff for D15748: Support destroy of multiple bookmarks on a single dataset..

Apply suggestions from review round 0.

Jun 14 2018, 7:15 PM · ZFS

Jun 12 2018

bcr added a comment to D15748: Support destroy of multiple bookmarks on a single dataset..

Thanks for the screenshot comparing the two man page renderings. I'm good with both ways.

Jun 12 2018, 7:31 PM · ZFS
me_cschwarz.com added a comment to D15748: Support destroy of multiple bookmarks on a single dataset..

Addressed all complaints marked 'Done' in my private tree, will post a revision once @bcr responds to how I should handle the newline style vs. whitespace issue.

Jun 12 2018, 7:19 PM · ZFS

Jun 11 2018

mahrens requested changes to D15748: Support destroy of multiple bookmarks on a single dataset..
Jun 11 2018, 5:49 PM · ZFS
bcr added a comment to D15748: Support destroy of multiple bookmarks on a single dataset..

Man page nit.

Jun 11 2018, 5:27 PM · ZFS
allanjude added a comment to D15748: Support destroy of multiple bookmarks on a single dataset..

Adding range support for holds and bookmarks has been on my todo list for a while now.

Jun 11 2018, 2:35 AM · ZFS

Jun 10 2018

me_cschwarz.com retitled D15748: Support destroy of multiple bookmarks on a single dataset. from Summary: Support destroy of multiple bookmarks on a single dataset. to Support destroy of multiple bookmarks on a single dataset..
Jun 10 2018, 9:27 PM · ZFS

Jun 8 2018

mav accepted D15562: ZFS sorted scans.
Jun 8 2018, 7:59 PM · ZFS
sef added a comment to D15562: ZFS sorted scans.

Checked in as r334844.

Jun 8 2018, 5:39 PM · ZFS
sef updated the diff for D15562: ZFS sorted scans.

Alexander pointed out that what I'd undone a change (range_tree_create()) because I'd ported from our 11-base system. Fixed that, and scrubbed a system a few times.

Jun 8 2018, 2:18 PM · ZFS

May 26 2018

sef added a comment to D15562: ZFS sorted scans.
In D15562#329076, @mav wrote:

I don't think it is a very good idea to merge two pretty much independent ZoL commits into one FreeBSD commit. It could have sense if the first one would be significantly broken and second fixed the issue, but priority upgrade implemented in second commit is only a performance optimization, mostly unrelated to scrub even, in which case having it separate would make commit history cleaner for later comparison.

May 26 2018, 3:06 AM · ZFS
mav added a comment to D15562: ZFS sorted scans.

I don't think it is a very good idea to merge two pretty much independent ZoL commits into one FreeBSD commit. It could have sense if the first one would be significantly broken and second fixed the issue, but priority upgrade implemented in second commit is only a performance optimization, mostly unrelated to scrub even, in which case having it separate would make commit history cleaner for later comparison.

May 26 2018, 3:03 AM · ZFS
sef updated the diff for D15562: ZFS sorted scans.

A late sequential-scan-related patch was mentioned when I created the PR for OpenZFS, it's at https://github.com/zfsonlinux/zfs/commit/a8b2e30685c9214c

May 26 2018, 2:42 AM · ZFS

May 25 2018

sef added a comment to D15562: ZFS sorted scans.
In D15562#328648, @avg wrote:

Just a quick question, is this the same change that was recently presented at OpenZFS summit (http://open-zfs.org/w/images/a/a0/Saso_-_resilver_update.pdf)?
Or an alternative to it?

May 25 2018, 6:33 AM · ZFS
avg added a comment to D15562: ZFS sorted scans.

Just a quick question, is this the same change that was recently presented at OpenZFS summit (http://open-zfs.org/w/images/a/a0/Saso_-_resilver_update.pdf)?
Or an alternative to it?

May 25 2018, 6:31 AM · ZFS

May 24 2018

sef created D15562: ZFS sorted scans.
May 24 2018, 8:00 PM · ZFS

May 22 2018

slw_zxy.spb.ru updated the diff for D7538: Correct adaptation ZFS ARC memory pressure to FreeBSD.

Unified for -stable and current now

May 22 2018, 3:49 PM · ZFS
lev added a comment to D7538: Correct adaptation ZFS ARC memory pressure to FreeBSD.

It is only solution to live-lock problem I encounter on my server when there are massive-parallel fast download.

May 22 2018, 3:19 PM · ZFS

May 15 2018

mmacy added a watcher for ZFS: mmacy.
May 15 2018, 1:13 AM

May 11 2018

slw_zxy.spb.ru updated the diff for D7538: Correct adaptation ZFS ARC memory pressure to FreeBSD.

Update to latest -STABLE changes

May 11 2018, 10:16 PM · ZFS

Apr 27 2018

kpraveen.lkml_gmail.com added a watcher for ZFS: kpraveen.lkml_gmail.com.
Apr 27 2018, 9:45 AM

Mar 14 2018

anthoine.bourgeois_blade-group.com added reviewers for D14669: Fix move handling of zvol devices out of txg sync thread: pjd, smh, ZFS.
Mar 14 2018, 10:31 AM · ZFS