Various work on OpenZFS and ZFS/FreeBSD.
Tue, Feb 19
Thu, Feb 14
Let me try to contact George again.
Wed, Feb 13
Tue, Feb 12
While I see the problem you are fixing, the fix looks ugly to me, that is why I would look for something nicer. I agree that according to logic of remove_reference() dropping last reference for header in ghost state is a failure, but how can remove_reference() be called before the arc_access() just on following line? I would guess from description telling about the case of prefetch read it should happen no sooner then we actually initiate the I/O, which is done much later then those two lines. So while I agree it is somewhat odd to have buffer for header in ghost state, is that a criminal.
Wed, Feb 6
Thu, Jan 24
Thank you for the additions! Just my $0.05 worth of nit picks post commit.
Jan 17 2019
Update the diff based on Allan's comments. I've decided to remove the newsyslog compression example. This might be something better suited for the handbook. In it's place, I've added Allan's zfs snapshot range deletion examples. I've also changed the date in the custom property example to a more prominent date. ;-)
Jan 15 2019
Thanks for your feedback, @allanjude. I'll work on an updated patch that incorporates it.
Dec 23 2018
Adding more reviewers for more pairs of eyes for eventual approval.
Dec 14 2018
Update with suggestions by Dru.
These look great!
Dec 13 2018
Nov 9 2018
Oct 12 2018
Oct 11 2018
Aug 29 2018
- ARC don't rised, memory pressure does not arise, page daemon not activated.
The ARC is not growing after 8, but the ARC hit rate is too low. Why is it not growing? Is it because the free_memory < (arc_c >> arc_no_grow_shift) condition is true, or is there some other reason?
Aug 28 2018
Aug 23 2018
To be clear, I'm just stating that r332365 changed zfs_arc_free_target to be equal vm_cnt.v_free_target. It looks to me that this is equivalent to the change you made to arc_available_memory(EXCLUDE_ZONE_CACHE), where v_free_target is referenced directly.
Aug 22 2018
Sorry that this review has stalled lately. I would like to compare this patch to what's in -CURRENT, which has evolved a fair bit since the patch was updated. Once that picture is more clear, we can focus on stable/11.
Aug 7 2018
I can confirm that the patch solves the issues as described in the "lightly loaded system eats swap space" thread on freebsd-stable mailing list.
On one of my desktop systems the issue is particularly noticeable as the disk subsystem is rather slow, the system became unusable after a
weekend sitting idle. I have not experienced the issues anymore after applying the patch
Jul 9 2018
Jul 7 2018
What else is preventing this from getting merged?
Jun 30 2018
Jun 18 2018
I have come to realise that there is another issue related to this, the default arc_max being wired ram that is not counted in max_wired means a default setup is allowed to wire more than the physical ram installed.
See my comment here for more explanation.
I have applied this patch to stable/11 r334820 and have been running without issue for 10 days.
Jun 16 2018
Jun 14 2018
Checked all 'Done' boxes, hope this is the way to use Phabricator ¯\_(ツ)_/¯
Apply suggestions from review round 0.
Jun 12 2018
Thanks for the screenshot comparing the two man page renderings. I'm good with both ways.
Addressed all complaints marked 'Done' in my private tree, will post a revision once @bcr responds to how I should handle the newline style vs. whitespace issue.
Jun 11 2018
Man page nit.
Adding range support for holds and bookmarks has been on my todo list for a while now.