Page MenuHomeFreeBSD

avg (Andriy Gapon)
User

Projects

User Details

User Since
Jun 4 2014, 6:42 AM (271 w, 5 d)

Recent Activity

Today

avg committed rS351209: MFC r350893: Allow ZVOL bookmarks to be listed recursively.
MFC r350893: Allow ZVOL bookmarks to be listed recursively
Mon, Aug 19, 7:47 AM
avg committed rS351208: MFC r350893: Allow ZVOL bookmarks to be listed recursively.
MFC r350893: Allow ZVOL bookmarks to be listed recursively
Mon, Aug 19, 7:45 AM
avg committed rS351207: MFC r350701,r350702: rc.8: add a reference to service(8).
MFC r350701,r350702: rc.8: add a reference to service(8)
Mon, Aug 19, 7:42 AM
avg committed rS351206: MFC r350701,r350702: rc.8: add a reference to service(8).
MFC r350701,r350702: rc.8: add a reference to service(8)
Mon, Aug 19, 7:40 AM

Sat, Aug 17

avg committed rS351168: zfs_vget: fix vnode reference count leak in error path.
zfs_vget: fix vnode reference count leak in error path
Sat, Aug 17, 9:23 AM

Thu, Aug 15

avg added a comment to D21237: MFV r350898: 8423 8199 7432 Implement large_dnode pool feature.

At least userland builds (not sure about kernels yet) on 32-bit platforms are broken because of missing atomic_swap_64.

Thu, Aug 15, 3:42 PM
avg committed rS351077: Revert r351076 and r351074 because of atomic_swap_64 on 32-bit platforms.
Revert r351076 and r351074 because of atomic_swap_64 on 32-bit platforms
Thu, Aug 15, 3:28 PM
avg committed rS351076: MFV r351075: 10406 large_dnode changes broke zfs recv of legacy stream.
MFV r351075: 10406 large_dnode changes broke zfs recv of legacy stream
Thu, Aug 15, 3:11 PM
avg committed rS351075: 10406 large_dnode changes broke zfs recv of legacy stream.
10406 large_dnode changes broke zfs recv of legacy stream
Thu, Aug 15, 3:07 PM
avg committed rS351074: MFV r350898: 8423 8199 7432 Implement large_dnode pool feature.
MFV r350898: 8423 8199 7432 Implement large_dnode pool feature
Thu, Aug 15, 2:57 PM

Tue, Aug 13

avg added a comment to D21236: MFV r350898: 8423 8199 7432 Implement large_dnode pool feature.
In D21236#461601, @jhb wrote:

I think you did an svn merge or the like that set a crap ton of properties on lots of subdirectories? The affected files list from the original e-mail seemed to start off by listing every single directory in the source tree.

Tue, Aug 13, 6:28 AM

Mon, Aug 12

avg created D21237: MFV r350898: 8423 8199 7432 Implement large_dnode pool feature.
Mon, Aug 12, 8:21 PM
avg added a comment to D21236: MFV r350898: 8423 8199 7432 Implement large_dnode pool feature.

I am not sure what happened. Looks like arc or phabricator went a little bit nuts.

Mon, Aug 12, 8:19 PM
avg created D21236: MFV r350898: 8423 8199 7432 Implement large_dnode pool feature.
Mon, Aug 12, 8:18 PM
avg committed rS350898: 8423 8199 7432 Implement large_dnode pool feature.
8423 8199 7432 Implement large_dnode pool feature
Mon, Aug 12, 12:06 PM
avg committed rS350897: MFV r350896: 6585 sha512, skein, and edonr have an unenforced dependency on….
MFV r350896: 6585 sha512, skein, and edonr have an unenforced dependency on…
Mon, Aug 12, 11:42 AM
avg committed rS350896: 6585 sha512, skein, and edonr have an unenforced dependency on extensible….
6585 sha512, skein, and edonr have an unenforced dependency on extensible…
Mon, Aug 12, 11:27 AM
avg committed rS350894: a stop gap fix for a race between dnode_hold and dnode_sync_free.
a stop gap fix for a race between dnode_hold and dnode_sync_free
Mon, Aug 12, 10:30 AM
avg committed rS350893: Allow ZVOL bookmarks to be listed recursively.
Allow ZVOL bookmarks to be listed recursively
Mon, Aug 12, 10:01 AM
avg committed rS350892: MFC r349571: upgrade the warning printf-s in bus accessors to KASSERT-s, take 2.
MFC r349571: upgrade the warning printf-s in bus accessors to KASSERT-s, take 2
Mon, Aug 12, 9:20 AM
avg committed rS350891: MFC r350025: bge: check that the bus is a pci bus before using it as such.
MFC r350025: bge: check that the bus is a pci bus before using it as such
Mon, Aug 12, 8:45 AM
avg committed rS350890: MFC r350025: bge: check that the bus is a pci bus before using it as such.
MFC r350025: bge: check that the bus is a pci bus before using it as such
Mon, Aug 12, 8:43 AM
avg committed rS350889: MFC r349886: linuxcommon: add module version.
MFC r349886: linuxcommon: add module version
Mon, Aug 12, 8:38 AM
avg committed rS350888: MFC r349886: linuxcommon: add module version.
MFC r349886: linuxcommon: add module version
Mon, Aug 12, 8:36 AM
avg committed rS350887: MFC r349883: owc_gpiobus: small formatting cleanup.
MFC r349883: owc_gpiobus: small formatting cleanup
Mon, Aug 12, 8:32 AM
avg committed rS350886: MFC r349883: owc_gpiobus: small formatting cleanup.
MFC r349883: owc_gpiobus: small formatting cleanup
Mon, Aug 12, 8:28 AM
avg created D21222: shutdown_halt: make sure that watchdog timer is stopped.
Mon, Aug 12, 8:25 AM
avg created D21221: add ability to set watchdog timeout for a shutdown.
Mon, Aug 12, 7:34 AM

Wed, Aug 7

avg committed rS350702: rc.8: fix a typo in r350701.
rc.8: fix a typo in r350701
Wed, Aug 7, 9:20 PM
avg committed rS350701: rc.8: add a reference to service(8).
rc.8: add a reference to service(8)
Wed, Aug 7, 9:08 PM

Jul 16 2019

avg committed rS350047: MFC r349579: nctgpio: change default pin names to those used by the datasheet(s).
MFC r349579: nctgpio: change default pin names to those used by the datasheet(s)
Jul 16 2019, 4:02 PM
avg committed rS350046: MFC r349579: nctgpio: change default pin names to those used by the datasheet(s).
MFC r349579: nctgpio: change default pin names to those used by the datasheet(s)
Jul 16 2019, 4:02 PM
avg committed rS350045: MFC r349460: gpiobus: provide a new hint, pin_list.
MFC r349460: gpiobus: provide a new hint, pin_list
Jul 16 2019, 3:58 PM
avg committed rS350044: MFC r349460: gpiobus: provide a new hint, pin_list.
MFC r349460: gpiobus: provide a new hint, pin_list
Jul 16 2019, 3:52 PM
avg committed rS350042: MFC r349428,r349433: owc_gpiobus: clean / fix up the driver module things.
MFC r349428,r349433: owc_gpiobus: clean / fix up the driver module things
Jul 16 2019, 3:49 PM
avg committed rS350041: MFC r349428,r349433: owc_gpiobus: clean / fix up the driver module things.
MFC r349428,r349433: owc_gpiobus: clean / fix up the driver module things
Jul 16 2019, 3:48 PM
avg committed rS350040: MFC r349408: gpio.4: document device hints common to all devices on gpiobus.
MFC r349408: gpio.4: document device hints common to all devices on gpiobus
Jul 16 2019, 3:45 PM
avg committed rS350039: MFC r349408: gpio.4: document device hints common to all devices on gpiobus.
MFC r349408: gpio.4: document device hints common to all devices on gpiobus
Jul 16 2019, 3:44 PM
avg committed rS350036: MFC r349406: owc.4: document how to set up the 1-wire bus on a device.hints….
MFC r349406: owc.4: document how to set up the 1-wire bus on a device.hints…
Jul 16 2019, 3:37 PM
avg committed rS350035: MFC r349406: owc.4: document how to set up the 1-wire bus on a device.hints….
MFC r349406: owc.4: document how to set up the 1-wire bus on a device.hints…
Jul 16 2019, 3:36 PM
avg committed rS350034: MFC r348688: first step towards enforcing must-succeed semantics for bus….
MFC r348688: first step towards enforcing must-succeed semantics for bus…
Jul 16 2019, 3:29 PM
avg committed rS350031: MFC r348355: revert r273728 and parts of r306589, iicbus no-stop by default….
MFC r348355: revert r273728 and parts of r306589, iicbus no-stop by default…
Jul 16 2019, 3:02 PM
avg committed rS350030: MFC r348355: revert r273728 and parts of r306589, iicbus no-stop by default….
MFC r348355: revert r273728 and parts of r306589, iicbus no-stop by default…
Jul 16 2019, 2:59 PM
avg committed rS350025: bge: check that the bus is a pci bus before using it as such.
bge: check that the bus is a pci bus before using it as such
Jul 16 2019, 8:37 AM

Jul 10 2019

avg committed rS349886: linuxcommon: add module version.
linuxcommon: add module version
Jul 10 2019, 1:47 PM
avg committed rS349883: owc_gpiobus: small formatting cleanup.
owc_gpiobus: small formatting cleanup
Jul 10 2019, 12:40 PM

Jul 8 2019

avg added a comment to D20880: Fix gcc build for superio(4).

I agree.
Thank you!

Jul 8 2019, 3:17 PM
avg added a comment to D20880: Fix gcc build for superio(4).

I did not add the default case, because I wanted a compiler to let me know when I forget to add a new type to that switch.
It sucks that the gcc does not realize that the code after the switch is not reachable.
But I guess that we have to please it.

Jul 8 2019, 1:22 PM

Jul 1 2019

avg committed rS349580: add superio driver.
add superio driver
Jul 1 2019, 5:05 PM
avg closed D8175: add superio driver.
Jul 1 2019, 5:05 PM
avg added a comment to D8175: add superio driver.

oops, forgot to update the header file

Jul 1 2019, 4:26 PM
avg added a comment to D8175: add superio driver.

clean up

Jul 1 2019, 4:24 PM
avg added a comment to D8175: add superio driver.
  • add "gpio" child type
  • add Nuvoton devices that are supported by nctgpio driver
  • change how Nuvoton device IDs are matched as for some higher bits of revision ID register are actually a part of a device ID
  • account for the fact that Nuvoton SuperIOs use multiple bits in the Device Enable register
  • change how known devices are defined
  • move child's "type" from the location string to the pnp string, suggested by jhb
Jul 1 2019, 4:20 PM
avg added a comment to D8175: add superio driver.

rebase

Jul 1 2019, 4:09 PM
avg committed rS349579: nctgpio: change default pin names to those used by the datasheet(s).
nctgpio: change default pin names to those used by the datasheet(s)
Jul 1 2019, 3:44 PM
avg committed rS349571: upgrade the warning printf-s in bus accessors to KASSERT-s, take 2.
upgrade the warning printf-s in bus accessors to KASSERT-s, take 2
Jul 1 2019, 6:23 AM

Jun 27 2019

avg added a comment to D8175: add superio driver.
In D8175#449725, @jhb wrote:

So I looked this over and I think the general approach is ok. I would probably prefer either 2) or 3) as I think that is simpler than 1). acpi_perf for 1) ends up being problematic. My only question about 3) is what kind of ivars would you provide that other drivers would bid on? If there aren't good ones, then named drivers ala 2) is probably simpler to work with. If the layout is fixed for each chip you could perhaps have an ivar that is an enum of functions (GPIO, watchdog, etc.) and use that for 3) instead of names I guess. If there is some kind of decent ivar that makes sense for differentiating devices, then I'd be fine with 3) over 2) I think.

Jun 27 2019, 8:11 PM
avg committed rS349461: revert r349460, printf -> KASSERT in bus.h, until I can fix it.
revert r349460, printf -> KASSERT in bus.h, until I can fix it
Jun 27 2019, 3:52 PM
avg committed rS349460: gpiobus: provide a new hint, pin_list.
gpiobus: provide a new hint, pin_list
Jun 27 2019, 3:46 PM
Herald added a reviewer for D20459: gpiobus: provide a new hint, pin_list: manpages.
Jun 27 2019, 3:46 PM
avg committed rS349459: upgrade the warning printf-s in bus accessors to KASSERT-s.
upgrade the warning printf-s in bus accessors to KASSERT-s
Jun 27 2019, 3:07 PM

Jun 26 2019

avg committed rS349433: fix up r349428, fix a typo made during "fdt" removal.
fix up r349428, fix a typo made during "fdt" removal
Jun 26 2019, 5:38 PM
avg added a comment to D20458: first step towards enforcing must-succeed semantics for bus accessors.

That's a good point, Warner.
Thanks!

Jun 26 2019, 5:18 PM
avg committed rS349428: owc_gpiobus: clean / fix up the driver module things.
owc_gpiobus: clean / fix up the driver module things
Jun 26 2019, 5:17 PM
avg committed rS349408: gpio.4: document device hints common to all devices on gpiobus.
gpio.4: document device hints common to all devices on gpiobus
Jun 26 2019, 7:38 AM
avg committed rS349407: fix up r349406, add missing .El.
fix up r349406, add missing .El
Jun 26 2019, 7:09 AM
avg committed rS349406: owc.4: document how to set up the 1-wire bus on a device.hints system.
owc.4: document how to set up the 1-wire bus on a device.hints system
Jun 26 2019, 6:40 AM
avg added a comment to D20458: first step towards enforcing must-succeed semantics for bus accessors.
In D20458#447325, @cem wrote:

We could create a _systm.h which can be included from bus.h without quite as much as pollution as all of systm.h. It's still some pollution but not as severe. I've wanted systm.h stuff in headers before.
We could instead just require systm.h be included at the top, like param.h. This option is not super appealing to me.
Whatever is needed from systm.h could be moved to another header? This probably breaks some consumers, but not all.

Jun 26 2019, 6:11 AM

Jun 20 2019

avg committed rS349227: drm2/intel_iic: stop using iicbus_set_nostop.
drm2/intel_iic: stop using iicbus_set_nostop
Jun 20 2019, 9:23 AM
avg committed rS349224: drm2/intel_iic: stop using iicbus_set_nostop.
drm2/intel_iic: stop using iicbus_set_nostop
Jun 20 2019, 6:54 AM

Jun 19 2019

avg committed rS349216: MFC r348772: Restore ARC MFU/MRU pressure.
MFC r348772: Restore ARC MFU/MRU pressure
Jun 19 2019, 8:29 PM
avg committed rS349215: MFC r348772: Restore ARC MFU/MRU pressure.
MFC r348772: Restore ARC MFU/MRU pressure
Jun 19 2019, 8:27 PM
avg committed rS349214: MFC r348228: amdgpio: fix reading status of input pins.
MFC r348228: amdgpio: fix reading status of input pins
Jun 19 2019, 8:21 PM
avg committed rS349213: MFC r348228: amdgpio: fix reading status of input pins.
MFC r348228: amdgpio: fix reading status of input pins
Jun 19 2019, 8:20 PM
avg committed rS349212: FC r348227: amdgpio: remove new line symbols from pin names.
FC r348227: amdgpio: remove new line symbols from pin names
Jun 19 2019, 8:19 PM
avg committed rS349211: MFC r348227: amdgpio: remove new line symbols from pin names.
MFC r348227: amdgpio: remove new line symbols from pin names
Jun 19 2019, 8:18 PM
avg committed rS349210: MFC r348159: add mrsas_shutdown method.
MFC r348159: add mrsas_shutdown method
Jun 19 2019, 8:16 PM
avg committed rS349209: MFC r348159: add mrsas_shutdown method.
MFC r348159: add mrsas_shutdown method
Jun 19 2019, 8:16 PM
avg committed rS349208: MFC r348153-r348155: gpioled: add a new hint for initial state.
MFC r348153-r348155: gpioled: add a new hint for initial state
Jun 19 2019, 8:12 PM
avg committed rS349207: MFC r348152: Add USB ID for CP2112.
MFC r348152: Add USB ID for CP2112
Jun 19 2019, 8:09 PM
avg committed rS349206: MFC r348152: Add USB ID for CP2112.
MFC r348152: Add USB ID for CP2112
Jun 19 2019, 8:05 PM
avg committed rS349205: MFC r345411: intpm: change translation of HBA error status to smbus(4) errors.
MFC r345411: intpm: change translation of HBA error status to smbus(4) errors
Jun 19 2019, 8:03 PM
avg committed rS349204: MFC r344360,r344361: zpool.8: document -D flag for zpool status.
MFC r344360,r344361: zpool.8: document -D flag for zpool status
Jun 19 2019, 8:01 PM
avg committed rS349203: MFC r344359: fix userland illumos taskq code to pass relative timeout to….
MFC r344359: fix userland illumos taskq code to pass relative timeout to…
Jun 19 2019, 7:58 PM
avg added a comment to D20459: gpiobus: provide a new hint, pin_list.

Anyone interested?
Opinions, comments?

Jun 19 2019, 3:08 PM
avg added a comment to D20458: first step towards enforcing must-succeed semantics for bus accessors.

I encountered a technical problem trying to replace the printf with KASSERT.
bus.h does not include systm.h and there are multiple places where bus.h is included before systm.h (or systm.h not included at all).
I am not looking forward to hear from Bruce Evans about yet another namespace pollution, but I am not sure what would be the best here.
Some options:

Jun 19 2019, 3:08 PM

Jun 7 2019

avg updated the diff for D8175: add superio driver.

rebase to the recent head

Jun 7 2019, 8:06 AM
avg committed rS348772: Restore ARC MFU/MRU pressure.
Restore ARC MFU/MRU pressure
Jun 7 2019, 6:36 AM
avg closed D19094: Restore ARC MFU/MRU pressure.
Jun 7 2019, 6:36 AM · ZFS
avg accepted D19094: Restore ARC MFU/MRU pressure.
Jun 7 2019, 6:08 AM · ZFS

Jun 6 2019

avg created D20535: mpsutil slot set status.
Jun 6 2019, 2:58 PM
avg committed rS348735: MFC r348153-r348155: gpioled: add a new hint for initial state.
MFC r348153-r348155: gpioled: add a new hint for initial state
Jun 6 2019, 11:42 AM
avg committed rS348734: MFC r345411: intpm: change translation of HBA error status to smbus(4) errors.
MFC r345411: intpm: change translation of HBA error status to smbus(4) errors
Jun 6 2019, 11:39 AM
avg committed rS348733: MFC r344361: zpool.8: sort zpool status flags in the same order as in illumos….
MFC r344361: zpool.8: sort zpool status flags in the same order as in illumos…
Jun 6 2019, 11:37 AM
avg committed rS348732: MFC r344360: zpool.8: document -D flag for zpool status.
MFC r344360: zpool.8: document -D flag for zpool status
Jun 6 2019, 11:35 AM
avg committed rS348731: MFC r344359: fix userland illumos taskq code to pass relative timeout to….
MFC r344359: fix userland illumos taskq code to pass relative timeout to…
Jun 6 2019, 11:32 AM
avg added a comment to D18485: Fix ZFS ztest(1) dies through failed assertion.

I would check the chunksize at the beginning of the function and pick a new random value if the current value is less than SPA_MINBLOCKSIZE * 2.
There could also be a comment explaining why that is done.
Adding four individual checks rather than a single one seems to be suboptimal.

Jun 6 2019, 11:18 AM
avg added a comment to D19094: Restore ARC MFU/MRU pressure.

Sorry, I myself went missing for a long while.
Yes, I can commit this change.

Jun 6 2019, 11:08 AM · ZFS

Jun 5 2019

avg committed rS348688: first step towards enforcing must-succeed semantics for bus accessors.
first step towards enforcing must-succeed semantics for bus accessors
Jun 5 2019, 1:18 PM
avg closed D20458: first step towards enforcing must-succeed semantics for bus accessors.
Jun 5 2019, 1:18 PM