Page MenuHomeFreeBSD

avg (Andriy Gapon)
User

Projects

User Details

User Since
Jun 4 2014, 6:42 AM (372 w, 6 d)

Recent Activity

Wed, Jul 21

avg added a comment to D31215: led: call led state functions in a context with no locks held.

@wulf , I considered that well. But if we use a dedicate taskqueue then it means having a thread anyway. And I didnd't want to put potentially slow LED operations on one of the global taskqueues.

Wed, Jul 21, 7:38 AM

Mon, Jul 19

avg added a comment to D31215: led: call led state functions in a context with no locks held.

@adrian , in my opinion two things guarantee correct operation:

  • the current element can never be removed (thanks to in_use)
  • an iteration is always done with the lock held

So, whatever perturbations might happen while the lock is dropped, they should settle down before the next iteration.

Mon, Jul 19, 7:23 PM
avg added a comment to D31215: led: call led state functions in a context with no locks held.

@adrian , I thought that I took care of that via the in_use flag.
Could you please look again?

Mon, Jul 19, 5:30 PM
avg added a comment to D31215: led: call led state functions in a context with no locks held.

Yeah, me too... but doing it directly from a callout puts a lot of restrictions.
I considered creating and destroying the thread dynamically as "blinkers" are added and removed.
I can implement that if you think it would be better than having the thread permanently.

Mon, Jul 19, 8:15 AM
avg added a comment to D31215: led: call led state functions in a context with no locks held.

Tested this with D30787 where LEDs are controlled via I²C and had no issues with turning the LEDs on / off and making then blink in various combinations and sequences.
No crashes, no LORs, no WITNESS warnings.

Mon, Jul 19, 8:10 AM
avg added reviewers for D31215: led: call led state functions in a context with no locks held: phk, gonzo, loos, adrian, mav, ganbold.
Mon, Jul 19, 8:04 AM
avg requested review of D31215: led: call led state functions in a context with no locks held.
Mon, Jul 19, 8:01 AM
avg added reviewers for D31214: gpioloed: no need for locking in this driver: gonzo, adrian, loos.
Mon, Jul 19, 8:00 AM
avg requested review of D31214: gpioloed: no need for locking in this driver.
Mon, Jul 19, 7:58 AM
avg committed R10:038279d2a86f: rtwn: make sure to not write in upper bits of txdseq (authored by avg).
rtwn: make sure to not write in upper bits of txdseq
Mon, Jul 19, 6:50 AM
avg committed R10:c5fa78d35d71: rtwn: make sure to not write in upper bits of txdseq (authored by avg).
rtwn: make sure to not write in upper bits of txdseq
Mon, Jul 19, 6:46 AM

Mon, Jul 12

avg committed R10:66c183f43f0c: mmc_cam_sim_default_action: do not touch the ccb after dispatching it (authored by avg).
mmc_cam_sim_default_action: do not touch the ccb after dispatching it
Mon, Jul 12, 6:32 PM

Jun 21 2021

avg committed R10:7544c1d20d8b: rtwn: make sure to not write in upper bits of txdseq (authored by avg).
rtwn: make sure to not write in upper bits of txdseq
Jun 21 2021, 8:07 AM
avg closed D30814: rtwn: make sure to not write in upper bits of txdseq.
Jun 21 2021, 8:07 AM
avg added a comment to D30787: rk805: add support for controlling two output pins via gpio interface.

I cannot think of any way.
rk_i2c needs to sleep to wait for an interrupt.
led(8) uses a non-sleepable mutex.

Jun 21 2021, 8:02 AM

Jun 18 2021

avg added reviewers for D30814: rtwn: make sure to not write in upper bits of txdseq: adrian, avos, bz, kevlo.
Jun 18 2021, 3:02 PM
avg requested review of D30814: rtwn: make sure to not write in upper bits of txdseq.
Jun 18 2021, 3:00 PM

Jun 17 2021

avg updated the diff for D30786: rk805: add system poweroff support.

address reviews for rk805 poweroff support

Jun 17 2021, 7:05 AM

Jun 16 2021

avg added inline comments to D30786: rk805: add system poweroff support.
Jun 16 2021, 2:49 PM
avg added reviewers for D30787: rk805: add support for controlling two output pins via gpio interface: peterj, gonzo. avg added 1 blocking reviewer(s) for D30787: rk805: add support for controlling two output pins via gpio interface: manu.
Jun 16 2021, 10:55 AM
avg requested review of D30787: rk805: add support for controlling two output pins via gpio interface.
Jun 16 2021, 10:53 AM
avg added reviewers for D30786: rk805: add system poweroff support: peterj, bz. avg added 1 blocking reviewer(s) for D30786: rk805: add system poweroff support: manu.
Jun 16 2021, 10:52 AM
avg committed R10:0dc7e55dcb0e: rc.d: liberate powerd from ACPI dependency (authored by avg).
rc.d: liberate powerd from ACPI dependency
Jun 16 2021, 10:50 AM
avg requested review of D30786: rk805: add system poweroff support.
Jun 16 2021, 10:49 AM
avg committed R10:e7ca75cb75be: rc.d: liberate powerd from ACPI dependency (authored by avg).
rc.d: liberate powerd from ACPI dependency
Jun 16 2021, 10:47 AM
avg committed R10:118ff4e9b3f1: rk3328_cru: fix a typo in the SCLK_I2S2 gate definition (authored by avg).
rk3328_cru: fix a typo in the SCLK_I2S2 gate definition
Jun 16 2021, 10:43 AM

Jun 9 2021

avg committed R10:ffc5dc788f05: rk3328_cru: fix a typo in the SCLK_I2S2 gate definition (authored by avg).
rk3328_cru: fix a typo in the SCLK_I2S2 gate definition
Jun 9 2021, 9:43 AM
avg committed R10:20eb6bd8c598: rc.d: liberate powerd from ACPI dependency (authored by avg).
rc.d: liberate powerd from ACPI dependency
Jun 9 2021, 9:42 AM

May 31 2021

avg requested review of D30579: bsd.port.mk: fix setting of FLAVOR in _FLAVOR_RECURSIVE_SH.
May 31 2021, 4:22 PM

May 21 2021

avg committed R10:9120716d91d4: storvsc: fix auto-sense reporting (authored by avg).
storvsc: fix auto-sense reporting
May 21 2021, 1:53 PM
avg committed R10:4b9d54e2aeca: mpsutil: extend show adapter information, add NCQ control (authored by Daniel Austin <freebsd-ports@dan.me.uk>).
mpsutil: extend show adapter information, add NCQ control
May 21 2021, 1:45 PM
avg committed R10:4a7dcb174ce8: storvsc: fix auto-sense reporting (authored by avg).
storvsc: fix auto-sense reporting
May 21 2021, 10:33 AM
avg committed R10:2def2de60a6d: PCI hot-plug: use dedicated taskqueue for device attach / detach (authored by avg).
PCI hot-plug: use dedicated taskqueue for device attach / detach
May 21 2021, 10:32 AM
avg committed R10:395bc3598b47: mpsutil: extend show adapter information, add NCQ control (authored by Daniel Austin <freebsd-ports@dan.me.uk>).
mpsutil: extend show adapter information, add NCQ control
May 21 2021, 10:30 AM
avg committed R10:d7d4592ada54: PCI hot-plug: use dedicated taskqueue for device attach / detach (authored by avg).
PCI hot-plug: use dedicated taskqueue for device attach / detach
May 21 2021, 10:29 AM

May 7 2021

avg committed R10:e2ea6942ab31: mpsutil: extend show adapter information, add NCQ control (authored by Daniel Austin <freebsd-ports@dan.me.uk>).
mpsutil: extend show adapter information, add NCQ control
May 7 2021, 12:24 PM
avg committed R10:8afecefd57c5: storvsc: fix auto-sense reporting (authored by avg).
storvsc: fix auto-sense reporting
May 7 2021, 7:20 AM
avg closed D30124: storvsc: fix auto-sense reporting.
May 7 2021, 7:20 AM

May 6 2021

avg closed D30144: PCI hot-plug: use dedicated taskqueue for device attach / detach.
May 6 2021, 6:53 PM
avg committed R10:12588ce02dd8: PCI hot-plug: use dedicated taskqueue for device attach / detach (authored by avg).
PCI hot-plug: use dedicated taskqueue for device attach / detach
May 6 2021, 6:53 PM
avg updated the summary of D30144: PCI hot-plug: use dedicated taskqueue for device attach / detach.
May 6 2021, 5:58 AM
avg added reviewers for D30144: PCI hot-plug: use dedicated taskqueue for device attach / detach: imp, jhb, chuck, mav, scottl.
May 6 2021, 5:57 AM
avg requested review of D30144: PCI hot-plug: use dedicated taskqueue for device attach / detach.
May 6 2021, 5:55 AM

May 5 2021

avg added reviewers for D30124: storvsc: fix auto-sense reporting: whu, decui_microsoft.com, imp.
May 5 2021, 2:16 PM
avg requested review of D30124: storvsc: fix auto-sense reporting.
May 5 2021, 2:14 PM
avg added a comment to D26311: gpioled_acpi: driver for GPIO controlled LEDs declared using ACPI _DSD.

The only reason is that I thought that I could do some things better but never got around to actually working on them.
Specifically, I don't like having so many walk+callback patterns. Especially for _DSD.
I hoped that I would be able to represent it as an nvlist or something similar.

May 5 2021, 7:36 AM
avg added a comment to D26311: gpioled_acpi: driver for GPIO controlled LEDs declared using ACPI _DSD.

@mm , do you have amdgpio driver? Has it attached?

May 5 2021, 6:54 AM

May 3 2021

avg committed R10:0a28a6a608d0: gpioc_detach: fix freeing of wrong pointers (authored by avg).
gpioc_detach: fix freeing of wrong pointers
May 3 2021, 8:16 PM
avg committed R10:dec9f377531d: gpioc_detach: fix freeing of wrong pointers (authored by avg).
gpioc_detach: fix freeing of wrong pointers
May 3 2021, 8:12 PM

Apr 15 2021

avg added a comment to D29758: mmc_da: restore HS200 support that was present in MMCCAM branch.

@kibab , you still may want to fix this pseudo-loop: https://github.com/kibab/freebsd/blob/mmccam-current/sys/cam/mmc/mmc_da.c#L1638
Maybe the last 'else' was supposed to be 'else if' ?

Apr 15 2021, 8:44 AM
avg added a comment to D29758: mmc_da: restore HS200 support that was present in MMCCAM branch.

I think that I needed that patch because earlier I had a lot of bits from https://github.com/kibab/freebsd/tree/mmccam-current in my tree and now I don't.
Specifically, @kibab's mmc_set_timing supports a lot more timings and so on.

Apr 15 2021, 8:40 AM
avg abandoned D29758: mmc_da: restore HS200 support that was present in MMCCAM branch.
Apr 15 2021, 8:20 AM
avg added a comment to D29758: mmc_da: restore HS200 support that was present in MMCCAM branch.

And in fact, it seems that I do not need that change anymore.

Apr 15 2021, 8:20 AM
avg added a comment to D29758: mmc_da: restore HS200 support that was present in MMCCAM branch.
In D29758#667600, @manu wrote:

For the 1.2V report it's probably the same problem as the one fixed by 1a96c1434f4b4487126f13ede29e67ad44a8776a

Apr 15 2021, 8:06 AM

Apr 14 2021

avg added a comment to D29758: mmc_da: restore HS200 support that was present in MMCCAM branch.

Yes, most likely.

Apr 14 2021, 6:07 PM
avg added a comment to D29758: mmc_da: restore HS200 support that was present in MMCCAM branch.

Is this the information you asked for?

# camcontrol devlist -v       
scbus0 on aw_mmc_sim0 bus 0:
scbus1 on aw_mmc_sim1 bus 0:
<SDIO card>                        at scbus1 target 0 lun 0 (sdiob0,pass1)
scbus2 on aw_mmc_sim2 bus 0:
<MMCHC 8GME4R 0.1 SN 4DAD8E5D MFG 09/200>  at scbus2 target 0 lun 0 (sdda0,pass0)
scbus-1 on xpt0 bus 0:
<>                                 at scbus-1 target -1 lun ffffffff (xpt0)
Apr 14 2021, 3:14 PM
avg requested review of D29758: mmc_da: restore HS200 support that was present in MMCCAM branch.
Apr 14 2021, 9:56 AM

Mar 31 2021

avg accepted D29513: lock_delay(9): improve interaction with restrict_starvation.

LGTM. Thank you!

Mar 31 2021, 2:39 PM

Mar 23 2021

avg committed R10:395e612b7bb1: pchtherm: fix a wrong bit and a wrong register use (authored by Michal Vanco <michal.vanco@gmail.com>).
pchtherm: fix a wrong bit and a wrong register use
Mar 23 2021, 11:03 AM
avg committed R10:3c6b59567f61: gpioc_detach: fix freeing of wrong pointers (authored by avg).
gpioc_detach: fix freeing of wrong pointers
Mar 23 2021, 10:50 AM

Mar 5 2021

avg committed R10:5084dde5f087: pchtherm: fix a wrong bit and a wrong register use (authored by Michal Vanco <michal.vanco@gmail.com>).
pchtherm: fix a wrong bit and a wrong register use
Mar 5 2021, 9:04 AM
avg added a comment to D24077: New driver pchtherm(4), PCH installed thermal sensor..

fix man page.
Add files.x86 entry to static configuration.

Mar 5 2021, 8:53 AM

Feb 18 2021

avg accepted D28769: kobj: avoid gcc -Wcast-function-type.

LGTM. Thank you.

Feb 18 2021, 9:13 AM

Jan 20 2021

avg accepted D28196: hconf(4): Do not fetch report before writing new usage values back..

LGTM. Thank you!
I did not realize that hardware can be this quirky.

Jan 20 2021, 12:41 PM

Jan 19 2021

avg committed R10:2c98edd6d6c7: htu21: driver for HTU21D I2C temperature and humidity sensor (authored by avg).
htu21: driver for HTU21D I2C temperature and humidity sensor
Jan 19 2021, 1:12 PM

Dec 18 2020

avg accepted D27653: acpi_wmi: Allow attachment to ACPI node if EC is not found. .
Dec 18 2020, 9:32 AM

Dec 13 2020

avg committed R9:b0d9f04266c0: add myself to authors.ent (first commit) (authored by avg).
add myself to authors.ent (first commit)
Dec 13 2020, 6:06 PM
avg committed R9:b7acae7d968f: further add myself to documentation (authored by avg).
further add myself to documentation
Dec 13 2020, 6:06 PM
avg committed R9:bbeeb6d23b57: further add myself to www pages (authored by avg).
further add myself to www pages
Dec 13 2020, 5:42 PM

Dec 11 2020

avg accepted D27570: superio,wbwd: Add Nuvoton NCT6796.

LGTM.

Dec 11 2020, 1:41 PM

Dec 10 2020

avg added a comment to D27535: Handle return from KDB_WHY_TRAP on arm and mips.

It's been a while since I touched that kind of code, but I think that this change is good.

Dec 10 2020, 3:24 PM

Dec 3 2020

avg committed rS368300: dtrace: honor LC_NUMERIC for %'d and alike, and LC_TIME for %T.
dtrace: honor LC_NUMERIC for %'d and alike, and LC_TIME for %T
Dec 3 2020, 11:59 AM

Oct 28 2020

avg committed rS367098: MFC r365943: aw_usbphy: add support for device mode operation.
MFC r365943: aw_usbphy: add support for device mode operation
Oct 28 2020, 11:40 AM

Oct 19 2020

avg committed rS366827: MFC r365402: musb/allwinner: add support for configuring phy as well as device….
MFC r365402: musb/allwinner: add support for configuring phy as well as device…
Oct 19 2020, 7:03 AM
avg committed rS366826: MFC r365401: musb/allwinner: add H3 support.
MFC r365401: musb/allwinner: add H3 support
Oct 19 2020, 6:44 AM

Oct 16 2020

avg committed rS366746: MFC r366140: aw_pwm: fix programming of the period.
MFC r366140: aw_pwm: fix programming of the period
Oct 16 2020, 6:42 AM
avg committed rS366745: MFC r366138: aw_pwm: remove the busy bit check.
MFC r366138: aw_pwm: remove the busy bit check
Oct 16 2020, 6:41 AM

Oct 12 2020

avg accepted D26470: Limit workaround for errata E400 to appropriate AMD cpus..
Oct 12 2020, 2:17 PM · x86
avg committed rP552123: retire my older email address.
retire my older email address
Oct 12 2020, 12:15 PM
avg committed rS366646: MFC r365397: twsi: some variants clear interrupt flag by writing 0, others by….
MFC r365397: twsi: some variants clear interrupt flag by writing 0, others by…
Oct 12 2020, 11:40 AM
avg committed rS366645: MFC r363021 by manu: twsi: Fix for > Allwinner A20.
MFC r363021 by manu: twsi: Fix for > Allwinner A20
Oct 12 2020, 11:34 AM
avg committed rS366643: MFC r366144: pwm(8): fix potential duty overflow, use unsigneds for period and….
MFC r366144: pwm(8): fix potential duty overflow, use unsigneds for period and…
Oct 12 2020, 11:05 AM
avg committed rS366642: MFC r366142: aw_pwm: add a check and some comments related to long periods.
MFC r366142: aw_pwm: add a check and some comments related to long periods
Oct 12 2020, 11:03 AM
avg committed rS366641: MFC r366141: aw_pwm: ensure sane configuration, just in case.
MFC r366141: aw_pwm: ensure sane configuration, just in case
Oct 12 2020, 11:02 AM
avg committed rS366640: MFC r366139: aw_pwm: fix selection of the prescaler.
MFC r366139: aw_pwm: fix selection of the prescaler
Oct 12 2020, 10:58 AM
avg committed rS366639: MFC r366137: aw_pwm: trivially add H3 support.
MFC r366137: aw_pwm: trivially add H3 support
Oct 12 2020, 10:55 AM
avg committed rS366638: MFC r365400: musb/allwinner: apply register filter in awusbdrd_bs_r_2() as well.
MFC r365400: musb/allwinner: apply register filter in awusbdrd_bs_r_2() as well
Oct 12 2020, 10:53 AM
avg committed rS366637: MFC r365398,r365399: Allwinner USB DRD support (musb_otg).
MFC r365398,r365399: Allwinner USB DRD support (musb_otg)
Oct 12 2020, 10:51 AM

Oct 7 2020

avg updated the diff for D26049: [PREVIEW] twsi: fixes, improvements, cleanups.

rebase

Oct 7 2020, 6:30 AM

Oct 2 2020

avg committed rS366359: MFC r366143: pwm(8): do not exit with failure after successfully reading….
MFC r366143: pwm(8): do not exit with failure after successfully reading…
Oct 2 2020, 12:49 PM
avg committed rS366358: MFC r365396: twsi: use tsleep instead of pause for better responsiveness.
MFC r365396: twsi: use tsleep instead of pause for better responsiveness
Oct 2 2020, 12:48 PM
avg committed rS366357: MFC r365290: move definition of hw.i2c sysctl node from iicbb to iicbus.
MFC r365290: move definition of hw.i2c sysctl node from iicbb to iicbus
Oct 2 2020, 12:46 PM

Sep 25 2020

avg committed rS366144: pwm(8): fix potential duty overflow, use unsigneds for period and duty.
pwm(8): fix potential duty overflow, use unsigneds for period and duty
Sep 25 2020, 7:55 AM
avg committed rS366143: pwm(8): do not exit with failure after successfully reading configuration.
pwm(8): do not exit with failure after successfully reading configuration
Sep 25 2020, 7:55 AM
avg committed rS366142: aw_pwm: add a check and some comments related to long periods.
aw_pwm: add a check and some comments related to long periods
Sep 25 2020, 7:42 AM
avg committed rS366141: aw_pwm: ensure sane configuration, just in case.
aw_pwm: ensure sane configuration, just in case
Sep 25 2020, 7:41 AM
avg committed rS366140: aw_pwm: fix programming of the period.
aw_pwm: fix programming of the period
Sep 25 2020, 7:40 AM
avg committed rS366139: aw_pwm: fix selection of the prescaler.
aw_pwm: fix selection of the prescaler
Sep 25 2020, 7:40 AM
avg committed rS366138: aw_pwm: remove the busy bit check.
aw_pwm: remove the busy bit check
Sep 25 2020, 7:39 AM
avg committed rS366137: aw_pwm: trivially add H3 support.
aw_pwm: trivially add H3 support
Sep 25 2020, 7:39 AM