avg (Andriy Gapon)
User

Projects

User Details

User Since
Jun 4 2014, 6:42 AM (180 w, 4 d)

Recent Activity

Fri, Nov 17

avg committed rS325932: MFC r325610: MFV r325609: 7531 Assign correct flags to prefetched buffers.
MFC r325610: MFV r325609: 7531 Assign correct flags to prefetched buffers
Fri, Nov 17, 10:13 AM
avg committed rS325931: MFC r325610: MFV r325609: 7531 Assign correct flags to prefetched buffers.
MFC r325610: MFV r325609: 7531 Assign correct flags to prefetched buffers
Fri, Nov 17, 10:10 AM

Thu, Nov 16

avg committed rS325915: MFC r325035: MFV r325013,r325034: 640 number_to_scaled_string is duplicated in….
MFC r325035: MFV r325013,r325034: 640 number_to_scaled_string is duplicated in…
Thu, Nov 16, 11:36 PM
avg committed rS325914: MFC r325035: MFV r325013,r325034: 640 number_to_scaled_string is duplicated in….
MFC r325035: MFV r325013,r325034: 640 number_to_scaled_string is duplicated in…
Thu, Nov 16, 11:27 PM
avg committed rS325913: MFC r325228: vdev_geom_close: close errored consumer even if vdev_reopening is….
MFC r325228: vdev_geom_close: close errored consumer even if vdev_reopening is…
Thu, Nov 16, 11:02 PM
avg committed rS325912: MFC r325228: vdev_geom_close: close errored consumer even if vdev_reopening is….
MFC r325228: vdev_geom_close: close errored consumer even if vdev_reopening is…
Thu, Nov 16, 10:59 PM
avg committed rS325911: MFC r325608: MFV r325607: 8607 zfs: variable set but not used.
MFC r325608: MFV r325607: 8607 zfs: variable set but not used
Thu, Nov 16, 10:53 PM
avg committed rS325910: MFC r325606: MFV r325605: 8713 Buffer overflow in dsl_dataset_name().
MFC r325606: MFV r325605: 8713 Buffer overflow in dsl_dataset_name()
Thu, Nov 16, 10:48 PM
avg committed rS325909: MFC r325606: MFV r325605: 8713 Buffer overflow in dsl_dataset_name().
MFC r325606: MFV r325605: 8713 Buffer overflow in dsl_dataset_name()
Thu, Nov 16, 10:45 PM
avg committed rS325908: MFC r325227,r325272: geom_slice: do not destroy softc until providers are gone.
MFC r325227,r325272: geom_slice: do not destroy softc until providers are gone
Thu, Nov 16, 10:37 PM
avg committed rS325907: MFC r325227,r325272: geom_slice: do not destroy softc until providers are gone.
MFC r325227,r325272: geom_slice: do not destroy softc until providers are gone
Thu, Nov 16, 10:25 PM
avg committed rS325906: procstat: fix a crash with -k -a options.
procstat: fix a crash with -k -a options
Thu, Nov 16, 10:15 PM
avg added a comment to D13088: zpool: cannot anymore import cache device which doesn't contain a previos ZFS vdev label.

I agree with Allan's suggestion. I suspect that ENOMEM could come as a signal to one of earlier ioctls to increase the buffer size for an output nvlist.
E.g. look at lzc_ioctl.
So, if the problem lies in first setting errno but not clearing it after a successful call, then the problem should be fixed at its source.

Thu, Nov 16, 9:01 PM

Sun, Nov 12

avg added a comment to D12797: extend illumos compatibility log_sysevent to support more nvlist types.

I've just had an accident and got some log messages that demonstrates how the patch formats an event with a nested nvlist:

Nov 11 07:10:21 trant ZFS: checksum mismatch, zpool=pond path=/dev/ada2p3 offset=1465774328832 size=12288
Sun, Nov 12, 8:29 AM

Thu, Nov 9

avg updated the summary of D8911: basic infrastructure for simple sensors.
Thu, Nov 9, 9:39 PM
avg committed rS325610: MFV r325609: 7531 Assign correct flags to prefetched buffers.
MFV r325609: 7531 Assign correct flags to prefetched buffers
Thu, Nov 9, 6:22 PM
avg committed rS325609: 7531 Assign correct flags to prefetched buffers.
7531 Assign correct flags to prefetched buffers
Thu, Nov 9, 6:21 PM
avg committed rS325608: MFV r325607: 8607 zfs: variable set but not used.
MFV r325607: 8607 zfs: variable set but not used
Thu, Nov 9, 6:14 PM
avg committed rS325607: 8607 zfs: variable set but not used.
8607 zfs: variable set but not used
Thu, Nov 9, 6:13 PM
avg committed rS325606: MFV r325605: 8713 Buffer overflow in dsl_dataset_name().
MFV r325605: 8713 Buffer overflow in dsl_dataset_name()
Thu, Nov 9, 6:12 PM
avg committed rS325605: 8713 Buffer overflow in dsl_dataset_name().
8713 Buffer overflow in dsl_dataset_name()
Thu, Nov 9, 6:06 PM

Wed, Nov 8

avg committed rS325541: MFC r324195: MFV r323795: 8604 Avoid unnecessary work search in VFS when….
MFC r324195: MFV r323795: 8604 Avoid unnecessary work search in VFS when…
Wed, Nov 8, 9:37 AM
avg committed rS325540: MFC r324757: remove spa_sync_on assert from spa_async_thread_vd.
MFC r324757: remove spa_sync_on assert from spa_async_thread_vd
Wed, Nov 8, 9:35 AM
avg committed rS325539: MFC r324757: remove spa_sync_on assert from spa_async_thread_vd.
MFC r324757: remove spa_sync_on assert from spa_async_thread_vd
Wed, Nov 8, 9:25 AM
avg committed rS325538: MFC r324197: MFV r323913: 8600 ZFS channel programs - snapshot.
MFC r324197: MFV r323913: 8600 ZFS channel programs - snapshot
Wed, Nov 8, 9:22 AM
avg committed rS325537: MFC r324196: MFV r323912: 8592 ZFS channel programs - rollback.
MFC r324196: MFV r323912: 8592 ZFS channel programs - rollback
Wed, Nov 8, 9:16 AM
avg committed rS325536: MFC r324170: MFV r323794: 8605 zfs channel programs: zfs.exists undocumented….
MFC r324170: MFV r323794: 8605 zfs channel programs: zfs.exists undocumented…
Wed, Nov 8, 9:15 AM
avg committed rS325535: MFC r324168: MFV r323531: 8521 nvlist memory leak in get_clones_stat() and….
MFC r324168: MFV r323531: 8521 nvlist memory leak in get_clones_stat() and…
Wed, Nov 8, 9:11 AM
avg committed rS325534: MFC r324163: MFV r323530,r323533,r323534: 7431 ZFS Channel Programs, and….
MFC r324163: MFV r323530,r323533,r323534: 7431 ZFS Channel Programs, and…
Wed, Nov 8, 8:54 AM

Tue, Nov 7

avg committed rS325486: Add an UPDATING entry for the posix_fallocate/ZFS change, r325320.
Add an UPDATING entry for the posix_fallocate/ZFS change, r325320
Tue, Nov 7, 4:02 PM
avg committed rS325477: Belatedly upgrade Eugene Grosbein (eugen) to a src committer..
Belatedly upgrade Eugene Grosbein (eugen) to a src committer.
Tue, Nov 7, 3:51 PM
avg added a member for committers: eugen_grosbein.net.
Tue, Nov 7, 3:51 PM

Thu, Nov 2

avg committed rS325338: loader: fix BOOTSRC -> BOOTOBJ in a library path.
loader: fix BOOTSRC -> BOOTOBJ in a library path
Thu, Nov 2, 7:46 PM
avg committed rS325320: Disable posix_fallocate(2) for ZFS.
Disable posix_fallocate(2) for ZFS
Thu, Nov 2, 1:49 PM

Wed, Nov 1

avg committed rS325272: geom_slice: fix r325227, protect against multiple calls to g_slice_free.
geom_slice: fix r325227, protect against multiple calls to g_slice_free
Wed, Nov 1, 10:53 AM

Tue, Oct 31

avg closed D12731: vdev_geom_close: close errored consumer even if vdev_reopening is set.
Tue, Oct 31, 10:15 AM
avg committed rS325228: vdev_geom_close: close errored consumer even if vdev_reopening is set.
vdev_geom_close: close errored consumer even if vdev_reopening is set
Tue, Oct 31, 10:15 AM
avg committed rS325227: geom_slice: do not destroy softc until providers are gone.
geom_slice: do not destroy softc until providers are gone
Tue, Oct 31, 10:10 AM
avg closed D12809: geom_slice: do not destroy softc until providers are gone.
Tue, Oct 31, 10:10 AM
avg committed rS325226: MFC r324957: iscsi_shutdown_post: do nothing if panic-ing.
MFC r324957: iscsi_shutdown_post: do nothing if panic-ing
Tue, Oct 31, 9:59 AM
avg committed rS325225: MFC r324957: iscsi_shutdown_post: do nothing if panic-ing.
MFC r324957: iscsi_shutdown_post: do nothing if panic-ing
Tue, Oct 31, 9:58 AM
avg committed rS325224: MFC r324694: never retry oustanding requests when terminating iscsi session.
MFC r324694: never retry oustanding requests when terminating iscsi session
Tue, Oct 31, 9:57 AM
avg committed rS325223: MFC r324694: never retry oustanding requests when terminating iscsi session.
MFC r324694: never retry oustanding requests when terminating iscsi session
Tue, Oct 31, 9:56 AM
avg committed rS325222: MFC r324689: iscsi: do not hold the global lock while tearing down a session.
MFC r324689: iscsi: do not hold the global lock while tearing down a session
Tue, Oct 31, 9:55 AM
avg committed rS325221: MFC r324689: iscsi: do not hold the global lock while tearing down a session.
MFC r324689: iscsi: do not hold the global lock while tearing down a session
Tue, Oct 31, 9:55 AM

Mon, Oct 30

avg committed rS325155: MFC r324425: illumos mutex_init: use SX_NEW instead of bzero.
MFC r324425: illumos mutex_init: use SX_NEW instead of bzero
Mon, Oct 30, 10:41 AM
avg committed rS325154: MFC r324350: zdb.8: replace with the slighly modified upstream version.
MFC r324350: zdb.8: replace with the slighly modified upstream version
Mon, Oct 30, 10:39 AM
avg committed rS325153: MFC r324349: MFV r322235: 8067 zdb should be able to dump literal embedded….
MFC r324349: MFV r322235: 8067 zdb should be able to dump literal embedded…
Mon, Oct 30, 10:37 AM
avg committed rS325152: MFC r324348: MFV r316934: 7340 receive manual origin should override automatic….
MFC r324348: MFV r316934: 7340 receive manual origin should override automatic…
Mon, Oct 30, 10:35 AM
avg committed rS325151: MFC r324348: MFV r316934: 7340 receive manual origin should override automatic….
MFC r324348: MFV r316934: 7340 receive manual origin should override automatic…
Mon, Oct 30, 10:35 AM
avg committed rS325150: MFC r324347: MFV r316933: 5142 libzfs support raidz root pool (loader project).
MFC r324347: MFV r316933: 5142 libzfs support raidz root pool (loader project)
Mon, Oct 30, 10:33 AM
avg committed rS325149: MFC r324347: MFV r316933: 5142 libzfs support raidz root pool (loader project).
MFC r324347: MFV r316933: 5142 libzfs support raidz root pool (loader project)
Mon, Oct 30, 10:32 AM
avg committed rS325148: MFC r324346: MFV r316931: 6268 zfs diff confused by moving a file to another….
MFC r324346: MFV r316931: 6268 zfs diff confused by moving a file to another…
Mon, Oct 30, 10:29 AM
avg committed rS325147: MFC r324346: MFV r316931: 6268 zfs diff confused by moving a file to another….
MFC r324346: MFV r316931: 6268 zfs diff confused by moving a file to another…
Mon, Oct 30, 10:29 AM
avg committed rS325140: MFC r324345: MFV r316877: 7571 non-present readonly numeric ZFS props do not….
MFC r324345: MFV r316877: 7571 non-present readonly numeric ZFS props do not…
Mon, Oct 30, 9:02 AM
avg committed rS325139: MFC r324345: MFV r316877: 7571 non-present readonly numeric ZFS props do not….
MFC r324345: MFV r316877: 7571 non-present readonly numeric ZFS props do not…
Mon, Oct 30, 9:01 AM
avg committed rS325138: MFC r324344: MFV r316864: 6392 zdb: introduce -V for verbatim import.
MFC r324344: MFV r316864: 6392 zdb: introduce -V for verbatim import
Mon, Oct 30, 8:58 AM
avg committed rS325136: MFC r324343: MFV r316862: 6410 teach zdb to perform object lookups by path.
MFC r324343: MFV r316862: 6410 teach zdb to perform object lookups by path
Mon, Oct 30, 8:56 AM
avg committed rS325132: MFC r324011, r324016: MFV r323535: 8585 improve batching done in zil_commit().
MFC r324011, r324016: MFV r323535: 8585 improve batching done in zil_commit()
Mon, Oct 30, 8:53 AM
avg abandoned D12797: extend illumos compatibility log_sysevent to support more nvlist types.

Based on the very good points in the feedback I now see that I haven't thought through any of the tough points of supporting those three additional types.
Given that currently they are not passed to the fm compatibility code, it probably makes sense to avoid them in the future rather than struggling to support them.

Mon, Oct 30, 7:48 AM
avg updated the diff for D12809: geom_slice: do not destroy softc until providers are gone.

Further simplify based on suggestions from mav; no need for nopen.

Mon, Oct 30, 7:41 AM

Sun, Oct 29

avg added a comment to D12809: geom_slice: do not destroy softc until providers are gone.
In D12809#266162, @mav wrote:

The idea looks fine, but logic of gsp->nopen and d_nopen in g_slice_access() looks over-engineered. I suppose gsp->nopen will never be above 1 here.

Sun, Oct 29, 8:11 PM
avg added a comment to D12809: geom_slice: do not destroy softc until providers are gone.
In D12809#266149, @mav wrote:
In D12809#266148, @avg wrote:

Just to clarify, do you mean adding tracking of the open provider count into g_slice_access ?

Yes. You may see, for example, how gmultipath uses sc->sc_opened.

Sun, Oct 29, 9:32 AM
avg updated the diff for D12809: geom_slice: do not destroy softc until providers are gone.

Track opens instead of depending on providergone, per mav's suggestion.

Sun, Oct 29, 9:29 AM
avg added a comment to D12809: geom_slice: do not destroy softc until providers are gone.

@mav thank you for the suggestion! Just to clarify, do you mean adding tracking of the open provider count into g_slice_access ?

Sun, Oct 29, 8:55 AM
avg added inline comments to D12809: geom_slice: do not destroy softc until providers are gone.
Sun, Oct 29, 7:37 AM

Sat, Oct 28

avg added a comment to D12797: extend illumos compatibility log_sysevent to support more nvlist types.

Can you give some examples of the output?

Sat, Oct 28, 1:28 PM

Fri, Oct 27

avg created D12809: geom_slice: do not destroy softc until providers are gone.
Fri, Oct 27, 1:20 PM
avg committed rS325035: MFV r325013,r325034: 640 number_to_scaled_string is duplicated in several….
MFV r325013,r325034: 640 number_to_scaled_string is duplicated in several…
Fri, Oct 27, 12:37 PM
avg committed rS325034: follow up to r325013, add libcmdutils.h to the vendor area.
follow up to r325013, add libcmdutils.h to the vendor area
Fri, Oct 27, 11:27 AM

Thu, Oct 26

avg committed rS325013: 640 number_to_scaled_string is duplicated in several commands.
640 number_to_scaled_string is duplicated in several commands
Thu, Oct 26, 4:20 PM
avg created D12797: extend illumos compatibility log_sysevent to support more nvlist types.
Thu, Oct 26, 4:12 PM
avg accepted D12791: zfsd should be able to online an L2ARC that disappears and returns.

LGTM. Thank you!

Thu, Oct 26, 3:09 PM

Tue, Oct 24

avg committed rS324957: iscsi_shutdown_post: do nothing if panic-ing.
iscsi_shutdown_post: do nothing if panic-ing
Tue, Oct 24, 2:59 PM

Oct 19 2017

avg created D12731: vdev_geom_close: close errored consumer even if vdev_reopening is set.
Oct 19 2017, 8:53 PM
avg committed rS324757: remove spa_sync_on assert from spa_async_thread_vd.
remove spa_sync_on assert from spa_async_thread_vd
Oct 19 2017, 4:36 PM
avg committed rS324751: MFC r324590: i2c(8): clean up and clarify read operation.
MFC r324590: i2c(8): clean up and clarify read operation
Oct 19 2017, 8:17 AM
avg committed rS324750: Really MFC r309357,r309409: Speling fixes and fix line endings for err_msg….
Really MFC r309357,r309409: Speling fixes and fix line endings for err_msg…
Oct 19 2017, 8:16 AM
avg committed rS324749: MFC r324311: sysctl-s in a module should be accessible only when the module is….
MFC r324311: sysctl-s in a module should be accessible only when the module is…
Oct 19 2017, 8:00 AM
avg committed rS324748: MFC r324311: sysctl-s in a module should be accessible only when the module is….
MFC r324311: sysctl-s in a module should be accessible only when the module is…
Oct 19 2017, 7:54 AM
avg committed rS324747: MFC r324312: fix the misleading log facility used in devd/zfs.conf.
MFC r324312: fix the misleading log facility used in devd/zfs.conf
Oct 19 2017, 7:23 AM
avg committed rS324746: MFC r324312: fix the misleading log facility used in devd/zfs.conf.
MFC r324312: fix the misleading log facility used in devd/zfs.conf
Oct 19 2017, 7:23 AM
avg committed rS324745: MFC r324309: remove heuristic error detection from ddi_strto*().
MFC r324309: remove heuristic error detection from ddi_strto*()
Oct 19 2017, 7:21 AM
avg committed rS324744: MFC r324309: remove heuristic error detection from ddi_strto*().
MFC r324309: remove heuristic error detection from ddi_strto*()
Oct 19 2017, 7:21 AM

Oct 17 2017

avg closed D12653: no need to retry oustanding requests when terminating a session.
Oct 17 2017, 4:04 PM
avg committed rS324694: never retry oustanding requests when terminating iscsi session.
never retry oustanding requests when terminating iscsi session
Oct 17 2017, 4:04 PM
avg committed rS324689: iscsi: do not hold the global lock while tearing down a session.
iscsi: do not hold the global lock while tearing down a session
Oct 17 2017, 3:39 PM
avg closed D12652: iscsi: do not hold the global lock while tearing down a session.
Oct 17 2017, 3:39 PM

Oct 13 2017

avg created D12653: no need to retry oustanding requests when terminating a session.
Oct 13 2017, 12:03 PM
avg created D12652: iscsi: do not hold the global lock while tearing down a session.
Oct 13 2017, 11:52 AM
avg committed rS324591: remove process and jail directory machinations from dounmount.
remove process and jail directory machinations from dounmount
Oct 13 2017, 9:42 AM
avg closed D12366: remove process and jail directory machinations from dounmount.
Oct 13 2017, 9:42 AM
avg committed rS324590: i2c(8): clean up and clarify read operation.
i2c(8): clean up and clarify read operation
Oct 13 2017, 9:22 AM
avg closed D12331: i2c(8): clean up and clarify read operation.
Oct 13 2017, 9:22 AM
avg committed rS324589: MFC r323612: gmirror: treat ENXIO as disk disconnect, not media error.
MFC r323612: gmirror: treat ENXIO as disk disconnect, not media error
Oct 13 2017, 9:14 AM
avg committed rS324588: MFC r323612: gmirror: treat ENXIO as disk disconnect, not media error.
MFC r323612: gmirror: treat ENXIO as disk disconnect, not media error
Oct 13 2017, 9:13 AM
avg committed rS324587: MFC r323528: MFV r323527: 5815 libzpool's panic function doesn't set global….
MFC r323528: MFV r323527: 5815 libzpool's panic function doesn't set global…
Oct 13 2017, 9:11 AM
avg committed rS324586: MFC r323528: MFV r323527: 5815 libzpool's panic function doesn't set global….
MFC r323528: MFV r323527: 5815 libzpool's panic function doesn't set global…
Oct 13 2017, 9:11 AM
avg committed rS324585: MFC r323525: MFV r323523: 8331 zfs_unshare returns wrong error code for smb….
MFC r323525: MFV r323523: 8331 zfs_unshare returns wrong error code for smb…
Oct 13 2017, 9:08 AM
avg committed rS324584: MFC r323525: MFV r323523: 8331 zfs_unshare returns wrong error code for smb….
MFC r323525: MFV r323523: 8331 zfs_unshare returns wrong error code for smb…
Oct 13 2017, 9:07 AM