avg (Andriy Gapon)
User

Projects

User Details

User Since
Jun 4 2014, 6:42 AM (172 w, 1 d)

Recent Activity

Today

avg accepted D12435: Protect ng_iface(4) private data.

But please wait for a node from @mav.

Thu, Sep 21, 4:37 PM
avg added a comment to D12435: Protect ng_iface(4) private data.

Other than the NULL pointer check, looks good to me.
Thank you!

Thu, Sep 21, 4:08 PM

Yesterday

avg accepted D12228: Clear G_CF_ORPHAN when attaching..
Wed, Sep 20, 9:37 PM
avg created D12420: fix the misleading log facility used in devd/zfs.conf.
Wed, Sep 20, 11:00 AM
avg committed rS323797: add vfs_zfs.abd_chunk_size tunable.
add vfs_zfs.abd_chunk_size tunable
Wed, Sep 20, 8:36 AM
avg committed rS323796: fix memory leak in g_bio zone introduced in r320452, another ABD fallout.
fix memory leak in g_bio zone introduced in r320452, another ABD fallout
Wed, Sep 20, 8:27 AM
avg committed rS323795: 8604 Avoid unnecessary work search in VFS when unmounting snapshots.
8604 Avoid unnecessary work search in VFS when unmounting snapshots
Wed, Sep 20, 7:28 AM
avg committed rS323794: 8605 zfs channel programs: zfs.exists undocumented and non-working.
8605 zfs channel programs: zfs.exists undocumented and non-working
Wed, Sep 20, 7:28 AM
avg committed rS323793: MFV r323792: 8602 remove unused "dp_early_sync_tasks" field from "dsl_pool"….
MFV r323792: 8602 remove unused "dp_early_sync_tasks" field from "dsl_pool"…
Wed, Sep 20, 7:27 AM
avg committed rS323792: 8602 remove unused "dp_early_sync_tasks" field from "dsl_pool" structure.
8602 remove unused "dp_early_sync_tasks" field from "dsl_pool" structure
Wed, Sep 20, 7:25 AM
avg committed rS323791: MFV r323790: 8567 Inconsistent return value in zpool_read_label.
MFV r323790: 8567 Inconsistent return value in zpool_read_label
Wed, Sep 20, 7:24 AM
avg committed rS323790: 8567 Inconsistent return value in zpool_read_label.
8567 Inconsistent return value in zpool_read_label
Wed, Sep 20, 7:18 AM
avg committed rS323789: 8473 scrub does not detect errors on active spares.
8473 scrub does not detect errors on active spares
Wed, Sep 20, 6:35 AM
avg committed rS323788: MFC r323540: jedec_ts: add many more devices from various vendors.
MFC r323540: jedec_ts: add many more devices from various vendors
Wed, Sep 20, 6:29 AM
avg committed rS323787: MFC r323540: jedec_ts: add many more devices from various vendors.
MFC r323540: jedec_ts: add many more devices from various vendors
Wed, Sep 20, 6:28 AM

Tue, Sep 19

avg committed rS323762: MFC r323482: zfs_ctldir: remove obsolete / bogus ARGSUSED lint directives.
MFC r323482: zfs_ctldir: remove obsolete / bogus ARGSUSED lint directives
Tue, Sep 19, 12:44 PM
avg committed rS323761: MFC r323482: zfs_ctldir: remove obsolete / bogus ARGSUSED lint directives.
MFC r323482: zfs_ctldir: remove obsolete / bogus ARGSUSED lint directives
Tue, Sep 19, 9:40 AM
avg committed rS323760: MFC r323435: MFV r323111: 8569 problem with inline functions in abd.h.
MFC r323435: MFV r323111: 8569 problem with inline functions in abd.h
Tue, Sep 19, 9:35 AM
avg committed rS323759: MFC r322241: MFV r322240: 8491 uberblock on-disk padding to reserve space for….
MFC r322241: MFV r322240: 8491 uberblock on-disk padding to reserve space for…
Tue, Sep 19, 9:26 AM
avg committed rS323758: MFC r322241: MFV r322240: 8491 uberblock on-disk padding to reserve space for….
MFC r322241: MFV r322240: 8491 uberblock on-disk padding to reserve space for…
Tue, Sep 19, 9:24 AM
avg committed rS323757: MFC r322230: MFV r322229: 7600 zfs rollback should pass target snapshot to….
MFC r322230: MFV r322229: 7600 zfs rollback should pass target snapshot to…
Tue, Sep 19, 9:19 AM
avg committed rS323756: MFC r322228: MFV r322227: 8377 Panic in bookmark deletion.
MFC r322228: MFV r322227: 8377 Panic in bookmark deletion
Tue, Sep 19, 9:15 AM
avg committed rS323755: MFC r322228: MFV r322227: 8377 Panic in bookmark deletion.
MFC r322228: MFV r322227: 8377 Panic in bookmark deletion
Tue, Sep 19, 9:11 AM
avg committed rS323754: MFC r322222: MFV r322221: 7910 l2arc_write_buffers() may write beyond target_sz.
MFC r322222: MFV r322221: 7910 l2arc_write_buffers() may write beyond target_sz
Tue, Sep 19, 9:08 AM
avg committed rS323753: MFC r322234: zfs: no need for __DECONST after abd constification in r322233.
MFC r322234: zfs: no need for __DECONST after abd constification in r322233
Tue, Sep 19, 9:04 AM
avg committed rS323752: MFC r322239: MFV r322238: 7915 checks in l2arc_evict could use some cleaning up.
MFC r322239: MFV r322238: 7915 checks in l2arc_evict could use some cleaning up
Tue, Sep 19, 9:02 AM
avg committed rS323751: MFC r322218: MFV r322217: 8418 zfs_prop_get_table() call in zfs_validate_name()….
MFC r322218: MFV r322217: 8418 zfs_prop_get_table() call in zfs_validate_name()…
Tue, Sep 19, 8:59 AM
avg committed rS323750: MFC r322237: MFV r322236: 8126 ztest assertion failed in dbuf_dirty due to….
MFC r322237: MFV r322236: 8126 ztest assertion failed in dbuf_dirty due to…
Tue, Sep 19, 8:57 AM
avg committed rS323749: MFC r322233: MFV r322232: 8426 mark immutable buffer arguments as such in abd.h.
MFC r322233: MFV r322232: 8426 mark immutable buffer arguments as such in abd.h
Tue, Sep 19, 8:55 AM
avg committed rS323748: MFC r322226: MFV r322223: 8378 crash due to bp in-memory modification of….
MFC r322226: MFV r322223: 8378 crash due to bp in-memory modification of…
Tue, Sep 19, 8:53 AM
avg committed rS323747: MFC r321471: spa_import_rootpool should be able to handle an imported root pool.
MFC r321471: spa_import_rootpool should be able to handle an imported root pool
Tue, Sep 19, 8:43 AM
avg committed rS323746: MFC r321471: spa_import_rootpool should be able to handle an imported root pool.
MFC r321471: spa_import_rootpool should be able to handle an imported root pool
Tue, Sep 19, 8:43 AM
avg committed rS323745: MFC r320352: zfs: port vdev_file part of illumos change 3306.
MFC r320352: zfs: port vdev_file part of illumos change 3306
Tue, Sep 19, 8:40 AM
avg committed rS323744: MFC r320151: remove bogus declaration of malloc from tcp_wrappers.
MFC r320151: remove bogus declaration of malloc from tcp_wrappers
Tue, Sep 19, 8:34 AM
avg committed rS323743: MFC r320151: remove bogus declaration of malloc from tcp_wrappers.
MFC r320151: remove bogus declaration of malloc from tcp_wrappers
Tue, Sep 19, 8:34 AM
avg committed rS323742: MFC r320266: jedec_ts: add support for devices manufactured by IDT.
MFC r320266: jedec_ts: add support for devices manufactured by IDT
Tue, Sep 19, 8:30 AM
avg committed rS323741: MFC r320266: jedec_ts: add support for devices manufactured by IDT.
MFC r320266: jedec_ts: add support for devices manufactured by IDT
Tue, Sep 19, 8:29 AM
avg committed rS323740: MFV r320195: bhyveload: correctly query size of disks.
MFV r320195: bhyveload: correctly query size of disks
Tue, Sep 19, 8:20 AM
avg committed rS323739: MFV r320195: bhyveload: correctly query size of disks.
MFV r320195: bhyveload: correctly query size of disks
Tue, Sep 19, 8:19 AM
avg committed rS323737: MFV r318962: Allow PROBE_SPINUP to fail in CAM ATA transport.
MFV r318962: Allow PROBE_SPINUP to fail in CAM ATA transport
Tue, Sep 19, 7:39 AM
avg committed rS323736: MFV r318962: Allow PROBE_SPINUP to fail in CAM ATA transport.
MFV r318962: Allow PROBE_SPINUP to fail in CAM ATA transport
Tue, Sep 19, 7:39 AM
avg committed rS323735: MFC r319746,r319747,r319769: 8269 dtrace stddev aggregation is normalized….
MFC r319746,r319747,r319769: 8269 dtrace stddev aggregation is normalized…
Tue, Sep 19, 7:32 AM
avg committed rS323734: MFC r319746,r319747,r319769: 8269 dtrace stddev aggregation is normalized….
MFC r319746,r319747,r319769: 8269 dtrace stddev aggregation is normalized…
Tue, Sep 19, 7:31 AM
avg committed rS323733: MFC r319212: fix indentation.
MFC r319212: fix indentation
Tue, Sep 19, 7:19 AM
avg committed rS323732: MFC r319212: fix indentation.
MFC r319212: fix indentation
Tue, Sep 19, 7:18 AM

Mon, Sep 18

avg accepted D11779: Use nstosbt() instead of multiplying by SBT_1NS to avoid roundoff errors..

LGTM. Thanks!

Mon, Sep 18, 6:31 AM

Fri, Sep 15

avg updated the diff for D12355: MFV r323535: 8585 improve batching done in zil_commit().

a better solution to sbintime_t vs hrtime_t

Fri, Sep 15, 8:49 PM
avg updated subscribers of D12355: MFV r323535: 8585 improve batching done in zil_commit().
Fri, Sep 15, 6:37 PM
avg updated the diff for D12366: remove process and jail directory machinations from dounmount.

no need to get a root vnode of the mp to check if it is rootvnode

Fri, Sep 15, 2:10 PM
avg added inline comments to D12366: remove process and jail directory machinations from dounmount.
Fri, Sep 15, 2:06 PM
avg committed rS323612: gmirror: treat ENXIO as disk disconnect, not media error.
gmirror: treat ENXIO as disk disconnect, not media error
Fri, Sep 15, 1:57 PM
avg closed D9463: gmirror: treat ENXIO as disk disconnect, not media error.
Fri, Sep 15, 1:57 PM
avg added inline comments to D9463: gmirror: treat ENXIO as disk disconnect, not media error.
Fri, Sep 15, 1:47 PM
avg updated the diff for D9463: gmirror: treat ENXIO as disk disconnect, not media error.

use _NOW suffix instead of more cryptic _IM

Fri, Sep 15, 1:16 PM
avg accepted D12163: [RFC]: decrement needfree by the amount of evicted cache.

LGTM

Fri, Sep 15, 12:58 PM
avg added a comment to D12330: "Long" filename support changes.
In D12330#255757, @cem wrote:

It seems that ZFS (which we don't use) has some ABI dependency on these constants via zfs_cmd, and this change breaks a CTASSERT on line 202 of zfs_ioctl.c. For some reason passing 3 MAXPATHLENs and 1 MAXNAMELEN via ioctl is too much. Someone would need to figure out how to fix ZFS to use this patch.

Fri, Sep 15, 12:36 PM

Thu, Sep 14

avg added a comment to D12367: do not spoil a geom label if it can not be modified via its underlying provider.

@marcel I never intended for "persistent" to mean "can never change". I only meant it to mean that, using Andrey's example, opening md0p1 for writing can not result in its label changing.
However, I did miss the fact that gpart control interface operates by explicitly spoiling consumers attached to modified partitions. I thought that the partitions themselves were spoiled and the consumers became orphaned.
So, this was a hole in my original design that Andrey pointed out.
But I think that it does not invalidate the general idea.
It's unfortunate that both the opening of md0p1 for writing and the re-labeling of md0p1 use the same mechanism, the spoiling, to convey the actions to consumers.

Thu, Sep 14, 5:22 PM
avg added a comment to D12367: do not spoil a geom label if it can not be modified via its underlying provider.

@ae initially I was a little bit confused about your example, but now I see what you mean.
It seems that "GEOM::media" attribute change is posted for consumers that do not get spoiled.
Maybe the g_label code can make use of that fact.
Here is a very rough change that seems to do the job:

static void
g_label_attrchanged(struct g_consumer *cp, const char *attr)
{
        struct g_class *mp;
        struct g_provider *pp;
Thu, Sep 14, 4:14 PM
avg created D12367: do not spoil a geom label if it can not be modified via its underlying provider.
Thu, Sep 14, 12:01 PM
avg created D12366: remove process and jail directory machinations from dounmount.
Thu, Sep 14, 11:54 AM
avg committed rS323578: dounmount: do not release the mount point's reference on the covered vnode.
dounmount: do not release the mount point's reference on the covered vnode
Thu, Sep 14, 8:47 AM
avg closed D12329: dounmount: do not release the mount point's reference on the covered vnode.
Thu, Sep 14, 8:47 AM

Wed, Sep 13

avg closed D11730: jedec_ts: add many more devices from various vendors.
Wed, Sep 13, 1:03 PM
avg committed rS323540: jedec_ts: add many more devices from various vendors.
jedec_ts: add many more devices from various vendors
Wed, Sep 13, 1:03 PM
avg accepted D12342: Fix keg_large_init() for internal zones.

LGTM.

Wed, Sep 13, 11:53 AM
avg updated the summary of D12355: MFV r323535: 8585 improve batching done in zil_commit().
Wed, Sep 13, 11:49 AM
avg created D12355: MFV r323535: 8585 improve batching done in zil_commit().
Wed, Sep 13, 11:41 AM
avg committed rS323535: 8585 improve batching done in zil_commit().
8585 improve batching done in zil_commit()
Wed, Sep 13, 11:00 AM
avg committed rS323534: 8590 memory leak in dsl_destroy_snapshots_nvl().
8590 memory leak in dsl_destroy_snapshots_nvl()
Wed, Sep 13, 10:58 AM
avg committed rS323533: 8552 ZFS LUA code uses floating point math.
8552 ZFS LUA code uses floating point math
Wed, Sep 13, 10:56 AM
avg committed rS323531: 8521 nvlist memory leak in get_clones_stat() and spa_load_best().
8521 nvlist memory leak in get_clones_stat() and spa_load_best()
Wed, Sep 13, 10:55 AM
avg committed rS323530: 7431 ZFS Channel Programs.
7431 ZFS Channel Programs
Wed, Sep 13, 10:46 AM
avg committed rS323529: 5115 Want Intel 40GbE NIC driver for illumos.
5115 Want Intel 40GbE NIC driver for illumos
Wed, Sep 13, 10:42 AM
avg committed rS323528: MFV r323527: 5815 libzpool's panic function doesn't set global panicstr….
MFV r323527: 5815 libzpool's panic function doesn't set global panicstr…
Wed, Sep 13, 10:34 AM
avg committed rS323527: 5815 libzpool's panic function doesn't set global panicstr, ::status not as….
5815 libzpool's panic function doesn't set global panicstr, ::status not as…
Wed, Sep 13, 10:33 AM
avg committed rS323526: 8376 cached v_path should be kept fresh.
8376 cached v_path should be kept fresh
Wed, Sep 13, 10:26 AM
avg committed rS323525: MFV r323523: 8331 zfs_unshare returns wrong error code for smb unshare failure.
MFV r323523: 8331 zfs_unshare returns wrong error code for smb unshare failure
Wed, Sep 13, 10:24 AM
avg committed rS323524: MFV r316932: 6280 libzfs: unshare_one() could fail with EZFS_SHARENFSFAILED.
MFV r316932: 6280 libzfs: unshare_one() could fail with EZFS_SHARENFSFAILED
Wed, Sep 13, 10:22 AM
avg committed rS323523: 8331 zfs_unshare returns wrong error code for smb unshare failure.
8331 zfs_unshare returns wrong error code for smb unshare failure
Wed, Sep 13, 10:17 AM
avg committed rS323522: slightly simplify zfs_vptocnp.
slightly simplify zfs_vptocnp
Wed, Sep 13, 7:10 AM
avg added a comment to D12330: "Long" filename support changes.
In D12330#255757, @cem wrote:

It seems that ZFS (which we don't use) has some ABI dependency on these constants via zfs_cmd, and this change breaks a CTASSERT on line 202 of zfs_ioctl.c. For some reason passing 3 MAXPATHLENs and 1 MAXNAMELEN via ioctl is too much. Someone would need to figure out how to fix ZFS to use this patch.

Wed, Sep 13, 6:19 AM

Tue, Sep 12

avg committed rD50831: replace my about-to-expire pgp key with a new one.
replace my about-to-expire pgp key with a new one
Tue, Sep 12, 9:06 PM
avg committed rS323491: fix a fallout from the ZTOV tightening, r323479.
fix a fallout from the ZTOV tightening, r323479
Tue, Sep 12, 1:21 PM
avg updated the diff for D9463: gmirror: treat ENXIO as disk disconnect, not media error.

immediately bump sync-id on a write failure

Tue, Sep 12, 12:15 PM
avg updated the diff for D12329: dounmount: do not release the mount point's reference on the covered vnode.

clear mnt_vnodecovered before calling vfs_mount_destroy in case of the mount failure,
that's safe to do because the new struct mount is not visible to the outside world

Tue, Sep 12, 10:53 AM
avg added inline comments to D12329: dounmount: do not release the mount point's reference on the covered vnode.
Tue, Sep 12, 9:29 AM
avg added reviewers for D12331: i2c(8): clean up and clarify read operation: ian, imp, zbb.
Tue, Sep 12, 7:44 AM
avg created D12331: i2c(8): clean up and clarify read operation.
Tue, Sep 12, 7:42 AM
avg updated the diff for D11730: jedec_ts: add many more devices from various vendors.

move hardware probing to the device probe method

Tue, Sep 12, 6:20 AM
avg added a reviewer for D12329: dounmount: do not release the mount point's reference on the covered vnode: mckusick.
Tue, Sep 12, 6:09 AM
avg created D12329: dounmount: do not release the mount point's reference on the covered vnode.
Tue, Sep 12, 6:08 AM
avg committed rS323483: zfsctl_snapdir_lookup should be able to handle an uncovered vnode.
zfsctl_snapdir_lookup should be able to handle an uncovered vnode
Tue, Sep 12, 6:07 AM
avg committed rS323482: zfs_ctldir: remove obsolete / bogus ARGSUSED lint directives.
zfs_ctldir: remove obsolete / bogus ARGSUSED lint directives
Tue, Sep 12, 6:05 AM
avg committed rS323481: zfsvfs_hold: assert that the busied filesystem can not be unmounted.
zfsvfs_hold: assert that the busied filesystem can not be unmounted
Tue, Sep 12, 6:05 AM
avg committed rS323480: zfs_get_vfs: reference a requested filesystem instead of vfs_busy-ing it.
zfs_get_vfs: reference a requested filesystem instead of vfs_busy-ing it
Tue, Sep 12, 6:04 AM
avg committed rS323479: zfs: tighten debug versions of ZTOV and VTOZ.
zfs: tighten debug versions of ZTOV and VTOZ
Tue, Sep 12, 6:02 AM

Mon, Sep 11

avg accepted D12320: x86 MCA: Extract CMCI support predicate into function.

LGTM

Mon, Sep 11, 8:08 PM
avg added a comment to D12321: MCA: Expand AMD Thresholding support to cover all banks.

The reason I originally implemented the feature only for Bank 4 is that in the public BKDG for family 10h MC0_MISC to MC3_MISC are specified as read-only all zero-s. And MC5_MISC is documented to have an unspecified value. So, I thought why bother...
For example:

MSR0000_0403 DC Machine Check Miscellaneous Register (MC0_MISC)
This register is read-only, reset: 0000 0000 0000 0000h.

Mon, Sep 11, 8:07 PM
avg accepted D12288: loader should support large_dnode.

LGTM

Mon, Sep 11, 12:27 PM
avg committed rS323435: MFV r323111: 8569 problem with inline functions in abd.h.
MFV r323111: 8569 problem with inline functions in abd.h
Mon, Sep 11, 12:16 PM