Page MenuHomeFreeBSD

avg (Andriy Gapon)
User

Projects

User Details

User Since
Jun 4 2014, 6:42 AM (298 w, 3 h)

Recent Activity

Mon, Feb 3

avg updated the diff for D23478: rework how ZVOLs are updated in response to DSL operations.

Add Actifio copyright to files where I made verbatim copies of the
corresponding code from ZoL.

Mon, Feb 3, 1:00 PM
avg abandoned D7179: move handling of zvol devices out of txg sync thread.

Abandoned in favor of D23478.

Mon, Feb 3, 12:55 PM
avg created D23478: rework how ZVOLs are updated in response to DSL operations.
Mon, Feb 3, 12:52 PM
avg abandoned D22313: hv_snapshot: port Linux patch, increase timeout of vss backup operations.

Looks like the proposed change does not improve anything, so time to abandon.

Mon, Feb 3, 12:47 PM

Thu, Jan 23

avg committed rS357042: vmxnet3: add support for RSS kernel option.
vmxnet3: add support for RSS kernel option
Thu, Jan 23, 11:05 AM
avg closed D23147: Try to fix vmxnet3 when RSS option is enabled.
Thu, Jan 23, 11:05 AM
avg committed rS357040: virtio_scsi: use max target ID plus one as the initiator ID.
virtio_scsi: use max target ID plus one as the initiator ID
Thu, Jan 23, 10:14 AM

Jan 15 2020

avg added inline comments to D23147: Try to fix vmxnet3 when RSS option is enabled.
Jan 15 2020, 7:23 AM
avg updated the diff for D23147: Try to fix vmxnet3 when RSS option is enabled.

fix brain-o

Jan 15 2020, 7:19 AM

Jan 14 2020

avg updated the diff for D23147: Try to fix vmxnet3 when RSS option is enabled.

Always configure the virtual NIC to use Toeplitz algorithm.

Jan 14 2020, 4:58 PM
avg committed rS356730: storvsc: port a Linux patch, properly set residual data length on errors.
storvsc: port a Linux patch, properly set residual data length on errors
Jan 14 2020, 1:20 PM
avg closed D22312: storvsc: port a Linux patch, properly set residual data length on errors.
Jan 14 2020, 1:20 PM

Jan 13 2020

avg added inline comments to D23147: Try to fix vmxnet3 when RSS option is enabled.
Jan 13 2020, 8:03 AM

Jan 12 2020

avg created D23147: Try to fix vmxnet3 when RSS option is enabled.
Jan 12 2020, 7:49 PM
avg accepted D22967: vmx: fix initialization of TSO related descriptor fields.

LGTM.
This change has been tested by Panzura.

Jan 12 2020, 7:47 PM

Dec 13 2019

avg committed rS355736: zfs boot: fix a crash in a rarely taken path in fzap_lookup.
zfs boot: fix a crash in a rarely taken path in fzap_lookup
Dec 13 2019, 10:04 PM

Dec 11 2019

avg added a reviewer for D22597: Use a callout instead of timeout(9) for delayed zio's.: glebius.
Dec 11 2019, 10:19 PM
avg accepted D22597: Use a callout instead of timeout(9) for delayed zio's..
Dec 11 2019, 10:18 PM
avg committed rS355611: add a sanity check to the system call registration code.
add a sanity check to the system call registration code
Dec 11 2019, 3:52 PM

Dec 3 2019

avg committed rS355325: devstat_selectdevs: resize dev_select only after copying data out of it.
devstat_selectdevs: resize dev_select only after copying data out of it
Dec 3 2019, 9:48 AM
avg committed rS355321: MFC r354349: if_ixv: disable RSS configuration on 82599 and X540 VFs.
MFC r354349: if_ixv: disable RSS configuration on 82599 and X540 VFs
Dec 3 2019, 7:22 AM
avg committed rS355320: MFC r354849: hyperv/storvsc: stash a pointer to hv_storvsc_request in ccb.
MFC r354849: hyperv/storvsc: stash a pointer to hv_storvsc_request in ccb
Dec 3 2019, 7:20 AM
avg committed rS355319: MFC r354638: teach db_nextframe/x86 about [X]xen_intr_upcall interrupt handler.
MFC r354638: teach db_nextframe/x86 about [X]xen_intr_upcall interrupt handler
Dec 3 2019, 7:19 AM

Dec 2 2019

avg added inline comments to D22597: Use a callout instead of timeout(9) for delayed zio's..
Dec 2 2019, 11:15 AM
avg accepted D22597: Use a callout instead of timeout(9) for delayed zio's..

The change looks good to me.
Regarding other topics mentioned, I do not think that the code in stable branches is going away soon.
Also, while I am hopeful that the ZoF code lands before FreeBSD 13, I do not see any harm in improving the current ZFS code before that.
And having plan B is always nice.

Dec 2 2019, 11:10 AM
avg committed rS355283: MFC r354436: MFV r354377: 10554 Implemented zpool sync command.
MFC r354436: MFV r354377: 10554 Implemented zpool sync command
Dec 2 2019, 7:40 AM
avg committed rS355282: MFC r354627: db_nextframe/i386: reduce the number of special frame types.
MFC r354627: db_nextframe/i386: reduce the number of special frame types
Dec 2 2019, 7:22 AM
avg committed rS355281: MFC r354886: zpool.8: remove a paragraph about quorum disks.
MFC r354886: zpool.8: remove a paragraph about quorum disks
Dec 2 2019, 7:20 AM

Nov 28 2019

avg accepted D22377: fix two races in kernel handling of the nfsuserd daemon.

This has been tested by Panzura QA.
They could not reproduce the original problem and no regressions were found.

Nov 28 2019, 6:38 AM

Nov 25 2019

avg committed rS355081: MFC r354619: db_nextframe/amd64: remove TRAP_INTERRUPT frame type.
MFC r354619: db_nextframe/amd64: remove TRAP_INTERRUPT frame type
Nov 25 2019, 6:17 AM

Nov 22 2019

avg added a comment to D22312: storvsc: port a Linux patch, properly set residual data length on errors.

Ping.

Nov 22 2019, 7:32 AM

Nov 21 2019

avg committed rS354962: disabled resilver_defer feature leads to looping resilvers.
disabled resilver_defer feature leads to looping resilvers
Nov 21 2019, 2:14 PM
avg committed rS354961: 10952 defer new resilvers and misc. resilver-related fixes.
10952 defer new resilvers and misc. resilver-related fixes
Nov 21 2019, 2:11 PM
avg committed rS354960: 10829 zpool-features.5 add missing .RE.
10829 zpool-features.5 add missing .RE
Nov 21 2019, 2:09 PM
avg committed rS354959: 11056 vdev_disk_io_start will panic the system if ldi_strategy returns an error..
11056 vdev_disk_io_start will panic the system if ldi_strategy returns an error.
Nov 21 2019, 2:05 PM
avg committed rS354958: 11051 zfs miscounts BP_IS_EMBEDDED blocks during scan..
11051 zfs miscounts BP_IS_EMBEDDED blocks during scan.
Nov 21 2019, 2:04 PM
avg committed rS354957: 10853 spa_sync, vs_alloc can underflow and checkpoint test fixes.
10853 spa_sync, vs_alloc can underflow and checkpoint test fixes
Nov 21 2019, 2:03 PM
avg committed rS354955: 10900 Fix estimated scrub completion time.
10900 Fix estimated scrub completion time
Nov 21 2019, 2:01 PM
avg committed rS354954: 10566 Multiple DVA Scrubbing Fix.
10566 Multiple DVA Scrubbing Fix
Nov 21 2019, 2:00 PM
avg committed rS354953: 10573 define TASKQID_INVALID as (taskq_id)0.
10573 define TASKQID_INVALID as (taskq_id)0
Nov 21 2019, 1:59 PM
avg committed rS354949: 10405 Implement ZFS sorted scans.
10405 Implement ZFS sorted scans
Nov 21 2019, 1:46 PM
avg committed rS354948: MFV r354383: 10592 misc. metaslab and vdev related ZoL bug fixes.
MFV r354383: 10592 misc. metaslab and vdev related ZoL bug fixes
Nov 21 2019, 1:35 PM
avg committed rS354941: MFV r354382,r354385: 10601 10757 Pool allocation classes.
MFV r354382,r354385: 10601 10757 Pool allocation classes
Nov 21 2019, 8:20 AM
avg committed rS354940: MFC r354212: iicbb: allow longer SCL low timeout and other improvements.
MFC r354212: iicbb: allow longer SCL low timeout and other improvements
Nov 21 2019, 7:48 AM

Nov 20 2019

avg committed rS354886: zpool.8: remove a paragraph about quorum disks.
zpool.8: remove a paragraph about quorum disks
Nov 20 2019, 8:56 AM
avg committed rS354885: fix up r354804, resolve merge conflicts in zpool.8.
fix up r354804, resolve merge conflicts in zpool.8
Nov 20 2019, 8:49 AM
avg committed rS354884: MFC r351812: mpsutil slot set status.
MFC r351812: mpsutil slot set status
Nov 20 2019, 8:44 AM
avg committed rS354883: MFC r353887: nctgpio: improve performance (latency) of operation.
MFC r353887: nctgpio: improve performance (latency) of operation
Nov 20 2019, 8:41 AM
avg committed rS354882: MFC r354205: Remove redundant hw sysctl declaration..
MFC r354205: Remove redundant hw sysctl declaration.
Nov 20 2019, 8:39 AM
avg committed rS354881: MFC r354183: ow(4): clean up stray white space.
MFC r354183: ow(4): clean up stray white space
Nov 20 2019, 8:37 AM
avg committed rS354880: MFC r354181: ow(4): protocol timings can now be changed as sysctl-s / tunables.
MFC r354181: ow(4): protocol timings can now be changed as sysctl-s / tunables
Nov 20 2019, 8:36 AM
avg committed rS354879: MFC r354180: ow(4): increase regular mode recovery time, t_rec, to 15 us.
MFC r354180: ow(4): increase regular mode recovery time, t_rec, to 15 us
Nov 20 2019, 8:34 AM
avg abandoned D22329: create_storvsc_request: stash a pointer to hv_storvsc_request in ccb.
Nov 20 2019, 8:27 AM
avg added a comment to D22329: create_storvsc_request: stash a pointer to hv_storvsc_request in ccb.

Committed in rS354849

Nov 20 2019, 8:26 AM

Nov 19 2019

avg committed rS354849: hyperv/storvsc: stash a pointer to hv_storvsc_request in ccb.
hyperv/storvsc: stash a pointer to hv_storvsc_request in ccb
Nov 19 2019, 7:21 AM
avg committed rS354848: MFC r353618,r353625,r353627: MFV r353617: 9425 allow channel programs to be….
MFC r353618,r353625,r353627: MFV r353617: 9425 allow channel programs to be…
Nov 19 2019, 7:19 AM

Nov 18 2019

avg committed rS354807: fix up r354804, add new ZFS file mmp.c to kernel files.
fix up r354804, add new ZFS file mmp.c to kernel files
Nov 18 2019, 10:47 AM
avg committed rS354806: fix up r354804, link zstreamdump with libzfs.
fix up r354804, link zstreamdump with libzfs
Nov 18 2019, 10:34 AM
avg committed rS354804: MFV r354378,r354379,r354386: 10499 Multi-modifier protection (MMP).
MFV r354378,r354379,r354386: 10499 Multi-modifier protection (MMP)
Nov 18 2019, 9:38 AM

Nov 15 2019

avg added inline comments to D22377: fix two races in kernel handling of the nfsuserd daemon.
Nov 15 2019, 10:21 AM
avg committed rS354725: MFC r353039: add ability to set watchdog timeout for a shutdown.
MFC r353039: add ability to set watchdog timeout for a shutdown
Nov 15 2019, 7:01 AM

Nov 13 2019

avg committed rS354677: MFC r353748: remove wmb() call from x86 cpu_reset().
MFC r353748: remove wmb() call from x86 cpu_reset()
Nov 13 2019, 7:43 AM
avg committed rS354676: MFC r353747: vmm: remove a wmb() call.
MFC r353747: vmm: remove a wmb() call
Nov 13 2019, 7:41 AM
avg committed rS354675: MFC r353636: MFV r353630: 10809 Performance optimization of AVL tree comparator….
MFC r353636: MFV r353630: 10809 Performance optimization of AVL tree comparator…
Nov 13 2019, 7:39 AM

Nov 12 2019

avg accepted D22321: i386: stop guessing the address of the trap frame in ddb backtrace..

Looks great!

Nov 12 2019, 3:46 PM
avg committed rS354640: MFC r354437: fix zpool list property names.
MFC r354437: fix zpool list property names
Nov 12 2019, 2:08 PM
avg created D22329: create_storvsc_request: stash a pointer to hv_storvsc_request in ccb.
Nov 12 2019, 1:44 PM
avg accepted D22321: i386: stop guessing the address of the trap frame in ddb backtrace..

Looks good to me in general.

Nov 12 2019, 12:10 PM
avg committed rS354638: teach db_nextframe/x86 about [X]xen_intr_upcall interrupt handler.
teach db_nextframe/x86 about [X]xen_intr_upcall interrupt handler
Nov 12 2019, 11:00 AM
avg committed rS354636: allow NO_CLEAN builds to work after opensolaris_atomic.S removal in r354634.
allow NO_CLEAN builds to work after opensolaris_atomic.S removal in r354634
Nov 12 2019, 10:22 AM
avg committed rS354634: MFC r353381: emulate illumos membar_producer with atomic_thread_fence_rel.
MFC r353381: emulate illumos membar_producer with atomic_thread_fence_rel
Nov 12 2019, 9:55 AM

Nov 11 2019

avg added a comment to D22303: db_nextframe/i386: reduce the number of special frame types.

Thank you for the comments and suggestions.
I updated the comment per John's suggestion (but the tf formula) and took the path forward suggested by Kostik.

Nov 11 2019, 7:08 PM
avg committed rS354627: db_nextframe/i386: reduce the number of special frame types.
db_nextframe/i386: reduce the number of special frame types
Nov 11 2019, 7:06 PM
avg closed D22303: db_nextframe/i386: reduce the number of special frame types.
Nov 11 2019, 7:06 PM
avg added inline comments to D22303: db_nextframe/i386: reduce the number of special frame types.
Nov 11 2019, 5:18 PM
avg committed rS354619: db_nextframe/amd64: remove TRAP_INTERRUPT frame type.
db_nextframe/amd64: remove TRAP_INTERRUPT frame type
Nov 11 2019, 5:11 PM
avg closed D22305: db_nextframe/amd64: remove TRAP_INTERRUPT frame type.
Nov 11 2019, 5:11 PM
avg added inline comments to D22303: db_nextframe/i386: reduce the number of special frame types.
Nov 11 2019, 5:05 PM
avg added a comment to D22303: db_nextframe/i386: reduce the number of special frame types.
In D22303#487872, @kib wrote:

Ok, I think I am convinced enough. As result, I do not like this code even more.
Wouldn't it be much more reliable and simpler if we set %ebp in syscall/trap/interrupt entry code to point to the beginning of struct trapframe ? Then it would just work to get tf as (struct trapframe *)(*fp->f_frame) ?

Nov 11 2019, 4:13 PM
avg updated the summary of D22312: storvsc: port a Linux patch, properly set residual data length on errors.
Nov 11 2019, 1:35 PM
avg updated the diff for D22312: storvsc: port a Linux patch, properly set residual data length on errors.

add a missing header change

Nov 11 2019, 1:34 PM
avg created D22313: hv_snapshot: port Linux patch, increase timeout of vss backup operations.
Nov 11 2019, 1:29 PM
avg created D22312: storvsc: port a Linux patch, properly set residual data length on errors.
Nov 11 2019, 1:23 PM

Nov 10 2019

avg created D22305: db_nextframe/amd64: remove TRAP_INTERRUPT frame type.
Nov 10 2019, 11:48 AM
avg created D22303: db_nextframe/i386: reduce the number of special frame types.
Nov 10 2019, 11:39 AM

Nov 8 2019

avg committed rS354534: MFC r353340,r353340: cleanup of illumos compatibility atomics.
MFC r353340,r353340: cleanup of illumos compatibility atomics
Nov 8 2019, 12:06 PM
avg committed rS354532: MFC r354065: gpioiic: set output after switching to output mode....
MFC r354065: gpioiic: set output after switching to output mode...
Nov 8 2019, 7:56 AM
avg committed rS354531: MFC r354077,r354078: owc_gpiobus_read_data: add recovery time to the read slot.
MFC r354077,r354078: owc_gpiobus_read_data: add recovery time to the read slot
Nov 8 2019, 7:38 AM
avg committed rS354530: MFC r354076: owc_gpiobus_read_data: compare times in sbintime_t units.
MFC r354076: owc_gpiobus_read_data: compare times in sbintime_t units
Nov 8 2019, 7:36 AM
avg committed rS354529: MFC r354069: owc_gpiobus_read_data: disable preemption earlier.
MFC r354069: owc_gpiobus_read_data: disable preemption earlier
Nov 8 2019, 7:35 AM

Nov 7 2019

avg committed rS354489: revert r354482, checking for XENHVM was a wrong way of checking for Xen.
revert r354482, checking for XENHVM was a wrong way of checking for Xen
Nov 7 2019, 9:43 PM
avg committed rS354482: IPI_TRACE is not really supported on xen.
IPI_TRACE is not really supported on xen
Nov 7 2019, 9:15 PM
avg committed rS354437: fix zpool list property names.
fix zpool list property names
Nov 7 2019, 11:51 AM
avg committed rS354436: MFV r354377: 10554 Implemented zpool sync command.
MFV r354377: 10554 Implemented zpool sync command
Nov 7 2019, 11:18 AM
avg committed rS354434: add a note about nctgpio and wbwd move to superio.
add a note about nctgpio and wbwd move to superio
Nov 7 2019, 7:22 AM
avg committed rS354433: add a note about nctgpio and wbwd move to superio.
add a note about nctgpio and wbwd move to superio
Nov 7 2019, 7:21 AM
avg committed rS354432: MFC r353645,r353677: wbwd: move to superio(4) bus.
MFC r353645,r353677: wbwd: move to superio(4) bus
Nov 7 2019, 7:15 AM
avg committed rS354430: MFC r353643: move nctgpio to superio(4) bus.
MFC r353643: move nctgpio to superio(4) bus
Nov 7 2019, 7:09 AM

Nov 6 2019

avg committed rS354386: 11770 additional mmp fixes.
11770 additional mmp fixes
Nov 6 2019, 9:09 AM
avg committed rS354385: 11541 allocation_classes feature must be enabled to add log device.
11541 allocation_classes feature must be enabled to add log device
Nov 6 2019, 9:05 AM