Page MenuHomeFreeBSD

avg (Andriy Gapon)
User

Projects

User Details

User Since
Jun 4 2014, 6:42 AM (224 w, 2 d)

Recent Activity

Wed, Sep 19

avg accepted D17208: Fix state of dquot-less vnodes after failed quotaoff..

ZFS part looks good to me.

Wed, Sep 19, 12:48 PM

Mon, Sep 17

avg accepted D17202: Fix the nvpair leak in vdev_geom_read_config()..

LGTM. Thank you!

Mon, Sep 17, 3:55 PM

Thu, Aug 23

avg added inline comments to D16720: Designware I2C: Fix IO Timeout issue with I2C controller in AMD platforms.
Thu, Aug 23, 7:01 AM

Aug 17 2018

avg updated the diff for D15755: add support for marking interrupt handlers as suspended.
  • add a barrier function to ensure that the interrupt handling code sees that a handler is suspended after intr_event_suspend_handler() returns
Aug 17 2018, 2:57 PM

Aug 9 2018

avg committed rS337528: add an option for ddb ps command to print process arguments.
add an option for ddb ps command to print process arguments
Aug 9 2018, 11:21 AM
avg closed D16603: Print arguments in ddb ps command.
Aug 9 2018, 11:21 AM
avg accepted D16603: Print arguments in ddb ps command.
Aug 9 2018, 11:12 AM
avg added a comment to D16603: Print arguments in ddb ps command.

Terry, thank you!

Aug 9 2018, 10:21 AM
avg added a comment to D16603: Print arguments in ddb ps command.

I've just tested this and I see a couple of issues.

Aug 9 2018, 9:20 AM

Aug 6 2018

avg updated the diff for D15755: add support for marking interrupt handlers as suspended.

rebase

Aug 6 2018, 1:02 PM
avg added reviewers for D16603: Print arguments in ddb ps command: kib, jhb.
Aug 6 2018, 8:45 AM

Aug 3 2018

avg committed rS337255: safer wait-free iteration of shared interrupt handlers.
safer wait-free iteration of shared interrupt handlers
Aug 3 2018, 2:27 PM
avg closed D15905: safer wait-free iteration of shared interrupt handlers.
Aug 3 2018, 2:27 PM

Aug 2 2018

avg committed rS337123: fix a typo resulting in a wrong variable in kern_syscall_deregister.
fix a typo resulting in a wrong variable in kern_syscall_deregister
Aug 2 2018, 9:42 AM
avg committed rS337122: MFC r336641: fix incorrect operator in the AUDITPIPE_SET_QLIMIT bounds check.
MFC r336641: fix incorrect operator in the AUDITPIPE_SET_QLIMIT bounds check
Aug 2 2018, 9:32 AM
avg committed rS337121: MFC r335934: remove unneeded inclusion of sys/interrupt.h from several files.
MFC r335934: remove unneeded inclusion of sys/interrupt.h from several files
Aug 2 2018, 9:29 AM
avg committed rS337118: MFC r334786: x86: reorganize code that deals with unexpected NMI-s.
MFC r334786: x86: reorganize code that deals with unexpected NMI-s
Aug 2 2018, 9:00 AM
avg committed rS337117: MFC r334479: call AcpiLeaveSleepStatePrep after re-enabling interrupts.
MFC r334479: call AcpiLeaveSleepStatePrep after re-enabling interrupts
Aug 2 2018, 8:58 AM
avg added a comment to D15905: safer wait-free iteration of shared interrupt handlers.

I am considering all previous requests for changes as outdated and I am going to commit this.
Please state if you still have any objections.

Aug 2 2018, 5:36 AM

Aug 1 2018

avg accepted D16537: Remove jedec_ts(4)..
Aug 1 2018, 6:14 AM

Jul 31 2018

avg added a comment to D16459: bsnmpd(1): optimize interface description processing.

I'm going to commit latest revision soon unless an objection is raised.

Jul 31 2018, 7:15 AM

Jul 27 2018

avg added a comment to D15905: safer wait-free iteration of shared interrupt handlers.
In D15905#348331, @cem wrote:

It was this: https://reviews.freebsd.org/D15905#338982

Which has been completed. I don't know of a way in phabricator to un-request changes other than approving, which isn't quite the same thing.

Jul 27 2018, 5:52 AM
avg added a comment to D16459: bsnmpd(1): optimize interface description processing.

Well, the standard says (0 ..64) and that means from zero to 64.
Also, my impression is that, according to the RFC, ifAlias is something that should be settable over SNMP and it should be persistent.

Jul 27 2018, 5:31 AM
avg removed a reviewer for D16459: bsnmpd(1): optimize interface description processing: avg.
Jul 27 2018, 5:23 AM

Jul 26 2018

avg accepted D16459: bsnmpd(1): optimize interface description processing.
Jul 26 2018, 4:29 PM
avg added a comment to D16459: bsnmpd(1): optimize interface description processing.

Some comments inline, but in general looks good to me.
Thanks!

Jul 26 2018, 3:38 PM
avg updated the diff for D15905: safer wait-free iteration of shared interrupt handlers.

remove TESTING / KFAIL code

Jul 26 2018, 12:36 PM

Jul 24 2018

avg updated the diff for D15905: safer wait-free iteration of shared interrupt handlers.

Per suggestions from Samy Al Bahra:

Jul 24 2018, 12:04 PM
avg accepted D16412: Deprecate jedec_ts(4) and point users to jedec_dimm(4) instead..
Jul 24 2018, 7:10 AM

Jul 23 2018

avg added a comment to D15905: safer wait-free iteration of shared interrupt handlers.

@cem, you are shown as having requested a change but looking into the comment history I am not sure what that change might be.
Could you please clarify?

Jul 23 2018, 5:28 PM
avg added inline comments to D15905: safer wait-free iteration of shared interrupt handlers.
Jul 23 2018, 5:26 PM
avg committed rS336641: fix incorrect operator in the AUDITPIPE_SET_QLIMIT bounds check.
fix incorrect operator in the AUDITPIPE_SET_QLIMIT bounds check
Jul 23 2018, 4:56 PM
avg updated the diff for D15905: safer wait-free iteration of shared interrupt handlers.

rebase

Jul 23 2018, 4:28 PM
avg added inline comments to D15905: safer wait-free iteration of shared interrupt handlers.
Jul 23 2018, 4:02 PM
avg committed rS336639: follow-up to r336635, update TAILQ to CK_SLIST for ie_handlers.
follow-up to r336635, update TAILQ to CK_SLIST for ie_handlers
Jul 23 2018, 3:37 PM
avg committed rS336635: change interrupt event's list of handlers from TAILQ to CK_SLIST.
change interrupt event's list of handlers from TAILQ to CK_SLIST
Jul 23 2018, 12:51 PM
avg closed D16016: change interrupt event's list of handler from TAILQ to SLIST.
Jul 23 2018, 12:51 PM
avg committed rS336634: MFV CK@r336629: Import CK as of commit 1c1f9901c2dea7a883342cd03d3906a1bc482583.
MFV CK@r336629: Import CK as of commit 1c1f9901c2dea7a883342cd03d3906a1bc482583
Jul 23 2018, 11:21 AM
avg committed rS336630: Tag import of CK as of commit 1c1f9901c2dea7a883342cd03d3906a1bc482583.
Tag import of CK as of commit 1c1f9901c2dea7a883342cd03d3906a1bc482583
Jul 23 2018, 7:49 AM
avg committed rS336629: Import CK as of commit 1c1f9901c2dea7a883342cd03d3906a1bc482583.
Import CK as of commit 1c1f9901c2dea7a883342cd03d3906a1bc482583
Jul 23 2018, 7:31 AM

Jul 16 2018

avg added inline comments to D16016: change interrupt event's list of handler from TAILQ to SLIST.
Jul 16 2018, 7:50 AM

Jul 15 2018

avg added inline comments to D15905: safer wait-free iteration of shared interrupt handlers.
Jul 15 2018, 4:02 PM

Jul 10 2018

avg added inline comments to D16016: change interrupt event's list of handler from TAILQ to SLIST.
Jul 10 2018, 3:08 PM

Jul 4 2018

avg updated the diff for D16016: change interrupt event's list of handler from TAILQ to SLIST.

Use CK_SLIST instead of SLIST to avoid a need for hand-rolled list
operations with fences.
This change adds CK_SLIST_{INSERT,REMOVE}_PREVPTR.

Jul 4 2018, 11:12 AM
avg accepted D16120: ig(4): add support for Apollo Lake I2C controllers.
Jul 4 2018, 10:58 AM
avg added a comment to D16120: ig(4): add support for Apollo Lake I2C controllers.

LGTM, thanks!
Maybe also add MODULE_PNP_INFO now that the IDs are in a table?

Jul 4 2018, 10:58 AM
avg committed rS335934: remove unneeded inclusion of sys/interrupt.h from several files.
remove unneeded inclusion of sys/interrupt.h from several files
Jul 4 2018, 9:07 AM

Jun 27 2018

avg updated the diff for D15905: safer wait-free iteration of shared interrupt handlers.

fix a mismerge

Jun 27 2018, 1:58 PM
avg added inline comments to D15905: safer wait-free iteration of shared interrupt handlers.
Jun 27 2018, 1:55 PM

Jun 26 2018

avg added inline comments to D15905: safer wait-free iteration of shared interrupt handlers.
Jun 26 2018, 8:14 PM
avg added inline comments to D16016: change interrupt event's list of handler from TAILQ to SLIST.
Jun 26 2018, 7:41 PM
avg added inline comments to D16016: change interrupt event's list of handler from TAILQ to SLIST.
Jun 26 2018, 4:00 PM
avg added a comment to D15985: Reduce unnecessary preemption, add a preemption knob for timeshare, fix missing NEEDRESCHED.
In D15985#339084, @jeff wrote:

The majority of the patch is actually unrelated to the specific issue. Only the timeshare delta and tdq_runq_elevate are for the problem. The others were just issues I noticed when reviewing the code while looking into this issue. I can break them off and commit them one at a time if it becomes more clear. I'm not even certain I want to commit the timeshare_delta as it is because I am hoping someone may suggest a more elegant fix.

Jun 26 2018, 10:55 AM
avg added a comment to D15630: HPET-based NMI (debug) watchdog.
In D15630#339073, @dch wrote:

also to confirm it works for me - just used it to get a crash dump from a system freeze. many thanks!

Jun 26 2018, 10:54 AM
avg added a child revision for D16016: change interrupt event's list of handler from TAILQ to SLIST: D15905: safer wait-free iteration of shared interrupt handlers.
Jun 26 2018, 10:52 AM
avg added a parent revision for D15905: safer wait-free iteration of shared interrupt handlers: D16016: change interrupt event's list of handler from TAILQ to SLIST.
Jun 26 2018, 10:52 AM
avg updated the diff for D15905: safer wait-free iteration of shared interrupt handlers.

rebase on top of D16016

Jun 26 2018, 10:51 AM
avg added a comment to D15905: safer wait-free iteration of shared interrupt handlers.
In D15905#338982, @cem wrote:

Please update with TAILQ->SLIST patch removed so it's easier for reviewers to see the meat of the change. (And then I'd ask for 24h.)

Jun 26 2018, 9:22 AM
avg created D16016: change interrupt event's list of handler from TAILQ to SLIST.
Jun 26 2018, 9:21 AM
avg committed rS335659: MFC r334340: add support for console resuming, implement it for uart, use on x86.
MFC r334340: add support for console resuming, implement it for uart, use on x86
Jun 26 2018, 9:04 AM
avg committed rS335658: MFC r333268: for bus suspend, detach and shutdown iterate children in reverse….
MFC r333268: for bus suspend, detach and shutdown iterate children in reverse…
Jun 26 2018, 8:56 AM
avg committed rS335657: MFC r334204,r334338: re-synchronize TSC-s on SMP systems after resume.
MFC r334204,r334338: re-synchronize TSC-s on SMP systems after resume
Jun 26 2018, 8:36 AM
avg committed rS335656: MFC r333994: stop and restart kernel event timers in the suspend / resume cycle.
MFC r333994: stop and restart kernel event timers in the suspend / resume cycle
Jun 26 2018, 8:31 AM
avg updated the diff for D15630: HPET-based NMI (debug) watchdog.

slide up to rS335655

Jun 26 2018, 8:30 AM
avg added a comment to D15985: Reduce unnecessary preemption, add a preemption knob for timeshare, fix missing NEEDRESCHED.
In D15985#338992, @jeff wrote:

I had just forgotten about IPI_AST but I like the way I have implemented it here better. It gives the remote scheduler a chance to look at what's going on and make a new decision.

Jun 26 2018, 7:49 AM

Jun 25 2018

avg added a comment to D15905: safer wait-free iteration of shared interrupt handlers.

Stop me or I will commit this.
I will [pretend to] ignore any post-commit comments from the reviewers too.

Jun 25 2018, 7:47 PM
avg added a comment to D15985: Reduce unnecessary preemption, add a preemption knob for timeshare, fix missing NEEDRESCHED.

Also, what's a practical difference between TDF_NEEDRESCHED + IPI_AST and IPI_PREEMPT ?

Jun 25 2018, 5:16 PM
avg added a comment to D15985: Reduce unnecessary preemption, add a preemption knob for timeshare, fix missing NEEDRESCHED.

Hmm, now I see a difference between 4BSD and ULE.
If kick_other_cpu does not preempt the remote CPU, then it does this:

pcpu->pc_curthread->td_flags |= TDF_NEEDRESCHED;
ipi_cpu(cpuid, IPI_AST);

On the other hand, tdq_notify either preempts or does nothing at all.

Jun 25 2018, 5:14 PM
avg added a comment to D15985: Reduce unnecessary preemption, add a preemption knob for timeshare, fix missing NEEDRESCHED.

@jeff I do not completely understand why in this scenario cksum runs behind the loop. Does cksum get a priority worse than the loop?
Otherwise, I would expect that even without preemption TDF_NEEDRESCHED would produce a similar effect.

Jun 25 2018, 4:57 PM
avg committed rS335628: MFC r333638: calibrate lapic timer in native_lapic_setup.
MFC r333638: calibrate lapic timer in native_lapic_setup
Jun 25 2018, 9:20 AM
avg committed rS335627: MFC r334002: uchcom: extend hardware support to version 0x30.
MFC r334002: uchcom: extend hardware support to version 0x30
Jun 25 2018, 8:57 AM
avg committed rS335626: MFC r334002: uchcom: extend hardware support to version 0x30.
MFC r334002: uchcom: extend hardware support to version 0x30
Jun 25 2018, 8:56 AM
avg committed rS335625: MFC r334001: uchcom: remove UCHCOM_REG_BREAK2 alias of UCHCOM_REG_LCR1.
MFC r334001: uchcom: remove UCHCOM_REG_BREAK2 alias of UCHCOM_REG_LCR1
Jun 25 2018, 8:55 AM
avg committed rS335624: MFC r334001: uchcom: remove UCHCOM_REG_BREAK2 alias of UCHCOM_REG_LCR1.
MFC r334001: uchcom: remove UCHCOM_REG_BREAK2 alias of UCHCOM_REG_LCR1
Jun 25 2018, 8:54 AM
avg committed rS335623: MFC r334000: uchcom: reject parity and double stop bits as unsupported.
MFC r334000: uchcom: reject parity and double stop bits as unsupported
Jun 25 2018, 8:53 AM
avg committed rS335622: MFC r334000: uchcom: reject parity and double stop bits as unsupported.
MFC r334000: uchcom: reject parity and double stop bits as unsupported
Jun 25 2018, 8:53 AM
avg committed rS335621: MFC r333999: uchcom: add a hardware configuration tweak seen in Linux code.
MFC r333999: uchcom: add a hardware configuration tweak seen in Linux code
Jun 25 2018, 8:50 AM
avg committed rS335620: MFC r333999: uchcom: add a hardware configuration tweak seen in Linux code.
MFC r333999: uchcom: add a hardware configuration tweak seen in Linux code
Jun 25 2018, 8:50 AM
avg committed rS335619: MFC r333998: uchcom: add DPRINTF-s to aid debugging of the driver.
MFC r333998: uchcom: add DPRINTF-s to aid debugging of the driver
Jun 25 2018, 8:49 AM
avg committed rS335618: MFC r333998: uchcom: add DPRINTF-s to aid debugging of the driver.
MFC r333998: uchcom: add DPRINTF-s to aid debugging of the driver
Jun 25 2018, 8:48 AM
avg committed rS335617: MFC r333997: uchcom: report detected product based on USB product ID.
MFC r333997: uchcom: report detected product based on USB product ID
Jun 25 2018, 8:48 AM
avg committed rS335616: MFC r333997: uchcom: report detected product based on USB product ID.
MFC r333997: uchcom: report detected product based on USB product ID
Jun 25 2018, 8:47 AM

Jun 22 2018

avg committed rS335557: MFC r333667: followup to r332730/r332752: set kdb_why to "trap" for fatal traps.
MFC r333667: followup to r332730/r332752: set kdb_why to "trap" for fatal traps
Jun 22 2018, 11:16 AM
avg committed rS335556: MFC r333667: followup to r332730/r332752: set kdb_why to "trap" for fatal traps.
MFC r333667: followup to r332730/r332752: set kdb_why to "trap" for fatal traps
Jun 22 2018, 10:49 AM
avg committed rS335555: MFC r333321,r333707: x86 cpususpend_handler: call wbinvd after setting suspend….
MFC r333321,r333707: x86 cpususpend_handler: call wbinvd after setting suspend…
Jun 22 2018, 10:44 AM
avg committed rS335554: MFC r332918, r333222: go deeper for ACPI suspend bounce test.
MFC r332918, r333222: go deeper for ACPI suspend bounce test
Jun 22 2018, 10:39 AM
avg created D15964: subr_bus: add a list of attached children to record their order.
Jun 22 2018, 10:21 AM
avg committed rS335549: Revert r335546 as temporary pool name feature has not been merged.
Revert r335546 as temporary pool name feature has not been merged
Jun 22 2018, 10:13 AM
avg committed rS335546: MFC r333630: Fix 'zpool create -t <tempname>'.
MFC r333630: Fix 'zpool create -t <tempname>'
Jun 22 2018, 9:41 AM
avg committed rS335545: MFC r333630: Fix 'zpool create -t <tempname>'.
MFC r333630: Fix 'zpool create -t <tempname>'
Jun 22 2018, 9:37 AM
avg committed rS335544: MFC r334785: expand descriptions of x86 panic_on_nmi and kdb_on_nmi sysctls.
MFC r334785: expand descriptions of x86 panic_on_nmi and kdb_on_nmi sysctls
Jun 22 2018, 9:29 AM
avg committed rS335543: MFC r333269: amdsbwd: fix reboot status reporting.
MFC r333269: amdsbwd: fix reboot status reporting
Jun 22 2018, 9:26 AM
avg committed rS335542: MFC r333269: amdsbwd: fix reboot status reporting.
MFC r333269: amdsbwd: fix reboot status reporting
Jun 22 2018, 9:25 AM
avg committed rS335541: MFC r333243: opensolaris system_taskq does not need to run at maximum priority.
MFC r333243: opensolaris system_taskq does not need to run at maximum priority
Jun 22 2018, 9:23 AM
avg committed rS335540: MFC r333243: opensolaris system_taskq does not need to run at maximum priority.
MFC r333243: opensolaris system_taskq does not need to run at maximum priority
Jun 22 2018, 9:22 AM
avg committed rS335538: MFC r333212: amdsbwd: add suspend and resume methods.
MFC r333212: amdsbwd: add suspend and resume methods
Jun 22 2018, 9:21 AM
avg committed rS335537: MFC r333212: amdsbwd: add suspend and resume methods.
MFC r333212: amdsbwd: add suspend and resume methods
Jun 22 2018, 9:20 AM
avg committed rS335536: MFC r332816: call racct_proc_ucred_changed() under the proc lock.
MFC r332816: call racct_proc_ucred_changed() under the proc lock
Jun 22 2018, 9:19 AM
avg committed rS335534: MFC r333209: hpet: use macros instead of magic values for the timer mode.
MFC r333209: hpet: use macros instead of magic values for the timer mode
Jun 22 2018, 9:10 AM
avg committed rS335533: MFC r333209: hpet: use macros instead of magic values for the timer mode.
MFC r333209: hpet: use macros instead of magic values for the timer mode
Jun 22 2018, 9:08 AM