Page MenuHomeFreeBSD

avg (Andriy Gapon)
User

Projects

User Details

User Since
Jun 4 2014, 6:42 AM (262 w, 5 d)

Recent Activity

Fri, Jun 7

avg updated the diff for D8175: add superio driver.

rebase to the recent head

Fri, Jun 7, 8:06 AM
avg committed rS348772: Restore ARC MFU/MRU pressure.
Restore ARC MFU/MRU pressure
Fri, Jun 7, 6:36 AM
avg closed D19094: Restore ARC MFU/MRU pressure.
Fri, Jun 7, 6:36 AM · ZFS
avg accepted D19094: Restore ARC MFU/MRU pressure.
Fri, Jun 7, 6:08 AM · ZFS

Thu, Jun 6

avg created D20535: mpsutil slot set status.
Thu, Jun 6, 2:58 PM
avg committed rS348735: MFC r348153-r348155: gpioled: add a new hint for initial state.
MFC r348153-r348155: gpioled: add a new hint for initial state
Thu, Jun 6, 11:42 AM
avg committed rS348734: MFC r345411: intpm: change translation of HBA error status to smbus(4) errors.
MFC r345411: intpm: change translation of HBA error status to smbus(4) errors
Thu, Jun 6, 11:39 AM
avg committed rS348733: MFC r344361: zpool.8: sort zpool status flags in the same order as in illumos….
MFC r344361: zpool.8: sort zpool status flags in the same order as in illumos…
Thu, Jun 6, 11:37 AM
avg committed rS348732: MFC r344360: zpool.8: document -D flag for zpool status.
MFC r344360: zpool.8: document -D flag for zpool status
Thu, Jun 6, 11:35 AM
avg committed rS348731: MFC r344359: fix userland illumos taskq code to pass relative timeout to….
MFC r344359: fix userland illumos taskq code to pass relative timeout to…
Thu, Jun 6, 11:32 AM
avg added a comment to D18485: Fix ZFS ztest(1) dies through failed assertion.

I would check the chunksize at the beginning of the function and pick a new random value if the current value is less than SPA_MINBLOCKSIZE * 2.
There could also be a comment explaining why that is done.
Adding four individual checks rather than a single one seems to be suboptimal.

Thu, Jun 6, 11:18 AM
avg added a comment to D19094: Restore ARC MFU/MRU pressure.

Sorry, I myself went missing for a long while.
Yes, I can commit this change.

Thu, Jun 6, 11:08 AM · ZFS

Wed, Jun 5

avg committed rS348688: first step towards enforcing must-succeed semantics for bus accessors.
first step towards enforcing must-succeed semantics for bus accessors
Wed, Jun 5, 1:18 PM
avg closed D20458: first step towards enforcing must-succeed semantics for bus accessors.
Wed, Jun 5, 1:18 PM
avg added a comment to D20458: first step towards enforcing must-succeed semantics for bus accessors.

Also, another thing that I realized is that this defensive code won't help much if a bus defines BUS1_IVAR_X and a child device requests BUS2_IVAR_Y when BUS1_IVAR_X == BUS2_IVAR_Y.
BUS_READ_IVAR / BUS_WRITE_IVAR may succeed in that case but the result could be meaningless.

Wed, Jun 5, 1:12 PM
avg added a comment to D20458: first step towards enforcing must-succeed semantics for bus accessors.

I would like to commit this change as is now. And then change printf to KASSERT in a week rather than in a month.
Hope that no one would object.

Wed, Jun 5, 1:03 PM

Wed, May 29

avg created D20459: gpiobus: provide a new hint, pin_list.
Wed, May 29, 10:58 AM
avg created D20458: first step towards enforcing must-succeed semantics for bus accessors.
Wed, May 29, 9:54 AM
avg committed rS348355: revert r273728 and parts of r306589, iicbus no-stop by default feature.
revert r273728 and parts of r306589, iicbus no-stop by default feature
Wed, May 29, 9:08 AM

Fri, May 24

avg committed rS348229: amdgpio: small formatting cleanup.
amdgpio: small formatting cleanup
Fri, May 24, 6:07 AM
avg committed rS348228: amdgpio: fix reading status of input pins.
amdgpio: fix reading status of input pins
Fri, May 24, 6:06 AM
avg committed rS348227: amdgpio: remove new line symbols from pin names.
amdgpio: remove new line symbols from pin names
Fri, May 24, 6:03 AM

Thu, May 23

avg committed rS348159: add mrsas_shutdown method.
add mrsas_shutdown method
Thu, May 23, 12:51 PM
avg closed D19817: add mrsas_shutdown method.
Thu, May 23, 12:51 PM
avg committed rS348155: gpioled: fix the manual page update in r348154.
gpioled: fix the manual page update in r348154
Thu, May 23, 11:35 AM
avg committed rS348154: gpioled: update the manual page after r348153.
gpioled: update the manual page after r348153
Thu, May 23, 11:21 AM
avg committed rS348153: gpioled: add a new hint for initial state.
gpioled: add a new hint for initial state
Thu, May 23, 11:15 AM
avg committed rS348152: Add USB ID for CP2112.
Add USB ID for CP2112
Thu, May 23, 11:06 AM

Wed, May 22

avg committed rS348108: acpi_hpet: restore support for timers defined only in HPET table.
acpi_hpet: restore support for timers defined only in HPET table
Wed, May 22, 8:30 AM

Apr 25 2019

avg resigned from D19888: GNU grep: use --color=auto by default.
Apr 25 2019, 8:07 PM
avg added a comment to D20019: x86: Halt non-BSP CPUs on panic IPI_STOP.

A belated note that it is possible use monitor/mwait mechanism to get the power saving and inter-processor signaling at the same time.
I once had it implemented, but that code is quite out of date now. Also, it was interleaved with another, unrelated change.
Some bits:

Apr 25 2019, 7:58 AM

Apr 10 2019

avg added a comment to D18670: Minor speedup for load_kld function.

If the zfs.ko module is loaded, a zfs module exists in the kernel, but I suspect that zfs doesn't exist in a kernel with it compiled in; only zfsctrl, based on what avg has suggested

Once again, you are confusing a name of a loadable file with a name of a module. Which is not surprising as that duality is confusing. E.g., a single loadable file can contains multiple modules.
Whether ZFS is compiled into the kernel or loaded via zfs.ko, the module name is still zfsctrl. It's the module name.

Apr 10 2019, 12:04 PM

Apr 9 2019

avg added inline comments to D19817: add mrsas_shutdown method.
Apr 9 2019, 7:07 PM
avg added a comment to D19817: add mrsas_shutdown method.
In D19817#426388, @imp wrote:

This looks good to me, however I'd wait a few days to see if Scott can spot something that I can't.

Apr 9 2019, 7:05 PM
avg updated the diff for D19817: add mrsas_shutdown method.

remove a wrong panicstr check that was left by accident

Apr 9 2019, 1:36 PM

Apr 8 2019

avg added a reviewer for D19817: add mrsas_shutdown method: scottl.
Apr 8 2019, 6:20 PM

Apr 6 2019

avg added a comment to D19833: pci_cfgreg.c: Use io port config access for early boot time..
In D19833#425585, @kib wrote:
In D19833#425441, @avg wrote:

LGTM.
I wonder if the pci_cfgregopen problem reported for AMD Ryzen systems has a similar cause...

What is the Ryzen problem ? This issue can only occur when config space is accessed before pmap is initialized, and I am only aware of pci_early_quirks which do that, which might falls to MCFG access only on some Intels.

Apr 6 2019, 4:14 PM

Apr 5 2019

avg accepted D19833: pci_cfgreg.c: Use io port config access for early boot time..
Apr 5 2019, 9:55 PM
avg added a comment to D19833: pci_cfgreg.c: Use io port config access for early boot time..

I wonder if the pci_cfgregopen problem reported for AMD Ryzen systems has a similar cause...

Apr 5 2019, 8:46 PM

Apr 4 2019

avg added inline comments to D19817: add mrsas_shutdown method.
Apr 4 2019, 5:46 PM
avg updated the diff for D19817: add mrsas_shutdown method.
  • update
Apr 4 2019, 6:57 AM
avg created D19817: add mrsas_shutdown method.
Apr 4 2019, 6:51 AM

Mar 22 2019

avg committed rS345418: Revert r345410, VOP_FSYNC change in ZFS vdev_file.
Revert r345410, VOP_FSYNC change in ZFS vdev_file
Mar 22 2019, 5:44 PM
avg committed rS345411: intpm: change translation of HBA error status to smbus(4) errors.
intpm: change translation of HBA error status to smbus(4) errors
Mar 22 2019, 10:38 AM
avg committed rS345410: ZFS vdev_file: use correct value for waitfor parameter of VOP_FSYNC.
ZFS vdev_file: use correct value for waitfor parameter of VOP_FSYNC
Mar 22 2019, 9:12 AM

Mar 11 2019

avg added a comment to D19094: Restore ARC MFU/MRU pressure.

No more replays?

Mar 11 2019, 9:39 AM · ZFS

Mar 2 2019

avg added a comment to D19153: Handle SIGPIPE in gssd, and limit kgssapi RPC retries.

Thank you, Rick!

Mar 2 2019, 9:42 AM

Mar 1 2019

avg added a comment to D19153: Handle SIGPIPE in gssd, and limit kgssapi RPC retries.

Somewhat belated question, would it make sense to mark the client created in sys_gssd_syscall() as interruptible?

Mar 1 2019, 9:03 AM

Feb 25 2019

avg removed a reviewer for D18977: units(1): Refactor the manual and update usage information: Src Committers.

I consider using the whole "Src committers" group as a reviewer to be inappropriate.
Especially for a change in a minor utility.

Feb 25 2019, 4:24 PM

Feb 22 2019

avg accepted D19098: Parallel zfs mounting.

I haven't thoroughly examined the change, but the procedure you followed sounds good to me.
And if it works, then it is good enough for me.

Feb 22 2019, 11:57 AM

Feb 21 2019

avg added a comment to D19094: Restore ARC MFU/MRU pressure.

Do you succesefull contact George?

Feb 21 2019, 5:36 PM · ZFS

Feb 20 2019

avg committed rS344361: zpool.8: sort zpool status flags in the same order as in illumos manual.
zpool.8: sort zpool status flags in the same order as in illumos manual
Feb 20 2019, 1:37 PM
avg committed rS344360: zpool.8: document -D flag for zpool status.
zpool.8: document -D flag for zpool status
Feb 20 2019, 1:34 PM
avg committed rS344359: fix userland illumos taskq code to pass relative timeout to cv_timedwait.
fix userland illumos taskq code to pass relative timeout to cv_timedwait
Feb 20 2019, 1:19 PM

Feb 14 2019

avg added a comment to D19094: Restore ARC MFU/MRU pressure.

Let me try to contact George again.

Feb 14 2019, 12:27 PM · ZFS

Jan 30 2019

avg accepted D19029: Remove unecessary "All rights reserved" from files under my or Panasas's copyright..

Not an expert on these matter, but I have no problem with the change.
Thanks!

Jan 30 2019, 9:21 AM

Jan 29 2019

avg added a comment to D19008: zfsbootcfg(8): Rewrite to use libbe.

Or if a "boot pool" setup is used (kernel is loaded from one pool, root is mounted from another). Or if reboot -r has been run prior to zfsbootcfg.

Jan 29 2019, 6:19 AM

Jan 28 2019

avg committed rS343523: MFC r342170: add support for marking interrupt handlers as suspended.
MFC r342170: add support for marking interrupt handlers as suspended
Jan 28 2019, 9:45 AM

Jan 11 2019

avg committed rS342943: MFC r342525: MFV r342469: 9630 add lzc_rename and lzc_destroy to libzfs_core.
MFC r342525: MFV r342469: 9630 add lzc_rename and lzc_destroy to libzfs_core
Jan 11 2019, 12:18 PM
avg committed rS342942: MFC r342525: MFV r342469: 9630 add lzc_rename and lzc_destroy to libzfs_core.
MFC r342525: MFV r342469: 9630 add lzc_rename and lzc_destroy to libzfs_core
Jan 11 2019, 11:49 AM
avg committed rS342941: MFC r342541: MFV r342532: 5882 Temporary pool names.
MFC r342541: MFV r342532: 5882 Temporary pool names
Jan 11 2019, 11:46 AM
avg committed rS342940: MFC r342541: MFV r342532: 5882 Temporary pool names.
MFC r342541: MFV r342532: 5882 Temporary pool names
Jan 11 2019, 11:45 AM
avg committed rS342939: MFC r342169: add a knob that disables detection of write protected disks.
MFC r342169: add a knob that disables detection of write protected disks
Jan 11 2019, 11:43 AM
avg committed rS342938: MFC r342169: add a knob that disables detection of write protected disks.
MFC r342169: add a knob that disables detection of write protected disks
Jan 11 2019, 11:42 AM

Dec 28 2018

avg committed rS342569: MFC r342193: ichwd: add a few assertions about tco_version.
MFC r342193: ichwd: add a few assertions about tco_version
Dec 28 2018, 8:53 AM
avg committed rS342568: MFC r342193: ichwd: add a few assertions about tco_version.
MFC r342193: ichwd: add a few assertions about tco_version
Dec 28 2018, 8:53 AM
avg committed rS342567: MFC r342073: ichwd: add Sunrise Point-LP ID.
MFC r342073: ichwd: add Sunrise Point-LP ID
Dec 28 2018, 8:50 AM
avg committed rS342566: MFC r342073: ichwd: add Sunrise Point-LP ID.
MFC r342073: ichwd: add Sunrise Point-LP ID
Dec 28 2018, 8:50 AM
avg committed rS342565: MFC r342072: ichwd: add support for clearing No Reboot bit in TCOv4.
MFC r342072: ichwd: add support for clearing No Reboot bit in TCOv4
Dec 28 2018, 8:48 AM
avg committed rS342564: MFC r342072: ichwd: add support for clearing No Reboot bit in TCOv4.
MFC r342072: ichwd: add support for clearing No Reboot bit in TCOv4
Dec 28 2018, 8:48 AM

Dec 26 2018

avg committed rS342541: MFV r342532: 5882 Temporary pool names.
MFV r342532: 5882 Temporary pool names
Dec 26 2018, 11:03 AM
avg committed rS342532: 5882 Temporary pool names.
5882 Temporary pool names
Dec 26 2018, 10:41 AM
avg committed rS342525: MFV r342469: 9630 add lzc_rename and lzc_destroy to libzfs_core.
MFV r342469: 9630 add lzc_rename and lzc_destroy to libzfs_core
Dec 26 2018, 10:37 AM
avg committed rS342473: MFC r342204: cyapa.4, isl.4: cross-reference and document use of….
MFC r342204: cyapa.4, isl.4: cross-reference and document use of…
Dec 26 2018, 9:23 AM
avg committed rS342472: MFC r342204: cyapa.4, isl.4: cross-reference and document use of….
MFC r342204: cyapa.4, isl.4: cross-reference and document use of…
Dec 26 2018, 9:22 AM
avg committed rS342471: MFC r341681: daprobedone: announce if a disk is write-protected.
MFC r341681: daprobedone: announce if a disk is write-protected
Dec 26 2018, 9:19 AM
avg committed rS342470: MFC r341681: daprobedone: announce if a disk is write-protected.
MFC r341681: daprobedone: announce if a disk is write-protected
Dec 26 2018, 9:16 AM
avg committed rS342469: 9630 add lzc_rename and lzc_destroy to libzfs_core.
9630 add lzc_rename and lzc_destroy to libzfs_core
Dec 26 2018, 7:57 AM

Dec 20 2018

avg committed rS342278: MFC r341632: acpi_{Device,Battery}IsPresent: restore pre-r330957 behaviour.
MFC r341632: acpi_{Device,Battery}IsPresent: restore pre-r330957 behaviour
Dec 20 2018, 8:45 AM

Dec 18 2018

avg committed rS342204: cyapa.4, isl.4: cross-reference and document use of chromebook_platform(4).
cyapa.4, isl.4: cross-reference and document use of chromebook_platform(4)
Dec 18 2018, 9:43 PM
avg committed rS342193: ichwd: add a few assertions about tco_version.
ichwd: add a few assertions about tco_version
Dec 18 2018, 5:18 PM
avg updated the summary of D18420: add a method to defer destruction of if_softc to if_destroy.
Dec 18 2018, 3:20 PM

Dec 17 2018

avg committed rS342179: fix formatting and style in ig4iic_acpi_probe afetr r339754.
fix formatting and style in ig4iic_acpi_probe afetr r339754
Dec 17 2018, 9:33 PM
avg committed rS342170: add support for marking interrupt handlers as suspended.
add support for marking interrupt handlers as suspended
Dec 17 2018, 5:11 PM
avg closed D15755: add support for marking interrupt handlers as suspended.
Dec 17 2018, 5:11 PM
avg committed rS342169: add a knob that disables detection of write protected disks.
add a knob that disables detection of write protected disks
Dec 17 2018, 4:02 PM
avg closed D18496: add a knob that disables detection of write protected disks.
Dec 17 2018, 4:02 PM

Dec 15 2018

avg added inline comments to D18496: add a knob that disables detection of write protected disks.
Dec 15 2018, 1:59 PM
avg added a comment to D18420: add a method to defer destruction of if_softc to if_destroy.

At work we decided to use the approach of if_gif / if_gre.
So, we don't really need this change.
But if people find it useful (e.g. @ae) and no one objects (looking at @bz), then I would like to commit this change and to merge if we have a spare field.

Dec 15 2018, 1:46 PM

Dec 14 2018

avg committed rS342073: ichwd: add Sunrise Point-LP ID.
ichwd: add Sunrise Point-LP ID
Dec 14 2018, 9:30 AM
avg committed rS342072: ichwd: add support for clearing No Reboot bit in TCOv4.
ichwd: add support for clearing No Reboot bit in TCOv4
Dec 14 2018, 9:28 AM

Dec 10 2018

avg updated the diff for D18496: add a knob that disables detection of write protected disks.

correct description of the new sysctl

Dec 10 2018, 8:26 AM
avg added a comment to D18496: add a knob that disables detection of write protected disks.

While here, I also fixed setting of the next state in the case of malloc failure in DA_STATE_PROBE_WP.

Dec 10 2018, 8:23 AM
avg created D18496: add a knob that disables detection of write protected disks.
Dec 10 2018, 8:21 AM
avg added a comment to D18494: Revert to using the upstream zpool-features(7) man page.

Unfortunately, I disagree with this change. I think that it is backwards.
illumos has already translated their zfs.1m and zpool.1m to mdoc format, so I assume that that's the direction they are moving in.
I'd rather help them with that in this case as well.
IMO, that would be a better way to overcome the divergence.

Dec 10 2018, 7:27 AM

Dec 7 2018

avg committed rS341696: acpi_MatchHid: use ACPI_MATCHHID_NOMATCH instead of FALSE.
acpi_MatchHid: use ACPI_MATCHHID_NOMATCH instead of FALSE
Dec 7 2018, 4:08 PM
avg committed rS341695: aibs: fix a typo in the probe method that was introduced in r339754.
aibs: fix a typo in the probe method that was introduced in r339754
Dec 7 2018, 4:04 PM
avg committed rS341681: daprobedone: announce if a disk is write-protected.
daprobedone: announce if a disk is write-protected
Dec 7 2018, 12:04 PM
avg updated the diff for D15755: add support for marking interrupt handlers as suspended.
  • add and make use of rman_{get,set}_irq_cookie() and a new field r_irq_cookie to back them
  • slide up head
Dec 7 2018, 11:02 AM

Dec 6 2018

avg added inline comments to D15755: add support for marking interrupt handlers as suspended.
Dec 6 2018, 2:35 PM