Page MenuHomeFreeBSD

avg (Andriy Gapon)
User

Projects

User Details

User Since
Jun 4 2014, 6:42 AM (313 w, 1 d)

Recent Activity

Today

avg added inline comments to D25128: hdac_intr_handler: keep working until global interrupt status clears.
Thu, Jun 4, 1:58 PM
avg added inline comments to D25128: hdac_intr_handler: keep working until global interrupt status clears.
Thu, Jun 4, 1:46 PM
avg committed rS361788: superio: do not assume that current LDN cannot change after config exit.
superio: do not assume that current LDN cannot change after config exit
Thu, Jun 4, 1:18 PM
avg closed D25014: ifconfig.8: fix cpability and flag descriptions for list scan / sta.
Thu, Jun 4, 1:07 PM
avg committed rS361787: ifconfig.8: fix cpability and flag descriptions for list scan / sta.
ifconfig.8: fix cpability and flag descriptions for list scan / sta
Thu, Jun 4, 1:07 PM
avg committed rS361786: MFC r361273: iwm: improve rfkill handling.
MFC r361273: iwm: improve rfkill handling
Thu, Jun 4, 1:03 PM
avg updated the summary of D25128: hdac_intr_handler: keep working until global interrupt status clears.
Thu, Jun 4, 7:09 AM
avg updated the summary of D25128: hdac_intr_handler: keep working until global interrupt status clears.
Thu, Jun 4, 7:03 AM
avg requested review of D25128: hdac_intr_handler: keep working until global interrupt status clears.
Thu, Jun 4, 7:00 AM
avg added inline comments to D17772: Add hack to allow users to bypass pin widget initialization..
Thu, Jun 4, 6:55 AM
avg added a comment to D17772: Add hack to allow users to bypass pin widget initialization..

This is probably completely wrong on multiple levels, but this certainly does allow me to use my headphones again on my Skylake Intel HDA box.

sysctl.conf:dev.hdaa.0.init_clear=0

Thu, Jun 4, 6:54 AM

Tue, Jun 2

avg added a comment to D24989: netinet: Generate a random RSS key on boot..
Tue, Jun 2, 8:30 AM · csprng, network

Mon, Jun 1

avg added a comment to D24989: netinet: Generate a random RSS key on boot..

I have a vague memory, maybe wrong, that commonly used fixed RSS keys were selected because they had some property (-ies).
So, maybe just being random is not good enough?
I think that hypothetical rss_isbadkey was mentioned for a reason?

Mon, Jun 1, 10:17 AM · csprng, network

Fri, May 29

avg closed D25028: do not enable pci bridge decoding on resume until I/O windows are restored.
Fri, May 29, 7:51 AM
avg committed rS361621: do not enable pci bridge decoding on resume until I/O windows are restored.
do not enable pci bridge decoding on resume until I/O windows are restored
Fri, May 29, 7:51 AM
avg closed D25027: corefile_open_last: don't keep a locked vnode while locking other ones.
Fri, May 29, 7:44 AM
avg committed rS361620: corefile_open_last: don't keep a locked vnode while locking other ones.
corefile_open_last: don't keep a locked vnode while locking other ones
Fri, May 29, 7:44 AM
avg committed rS361619: MFC r361364: net80211: post RTM_IFINFO notification after toggling….
MFC r361364: net80211: post RTM_IFINFO notification after toggling…
Fri, May 29, 7:39 AM
avg committed rS361618: MFC r361330: libprocstat: fix reading of file descriptor table via kvm.
MFC r361330: libprocstat: fix reading of file descriptor table via kvm
Fri, May 29, 7:37 AM

Thu, May 28

avg added a comment to D25028: do not enable pci bridge decoding on resume until I/O windows are restored.

John, I know that you would prefer something grander.
Do you at least not object to this change ?

Thu, May 28, 7:02 PM

Wed, May 27

avg requested review of D25028: do not enable pci bridge decoding on resume until I/O windows are restored.
Wed, May 27, 1:02 PM
avg added a comment to D25027: corefile_open_last: don't keep a locked vnode while locking other ones.

Just in case:

(kgdb) tid 101533
(kgdb) bt
#0  sched_switch (td=0xfffffe00b4f85500, flags=<optimized out>) at /usr/devel/git/motil/sys/kern/sched_ule.c:2147
#1  0xffffffff807e4de2 in mi_switch (flags=260) at /usr/devel/git/motil/sys/kern/kern_synch.c:542
#2  0xffffffff80831916 in sleepq_switch (wchan=0xfffff80085627bd8, pri=<optimized out>) at /usr/devel/git/motil/sys/kern/subr_sleepqueue.c:625
#3  0xffffffff807acb61 in sleeplk (lk=0xfffff80085627bd8, flags=532480, ilk=<optimized out>, wmesg=<optimized out>, pri=<optimized out>, timo=51, queue=0) at /usr/devel/git/motil/sys/kern/kern_lock.c:295
#4  0xffffffff807ab19f in lockmgr_xlock_hard (lk=0xfffff80085627bd8, flags=<unavailable>, ilk=0x0, file=0xffffffff80c40f02 "/usr/devel/git/motil/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c", line=1438, 
    lwa=0xfffff80085627bd8) at /usr/devel/git/motil/sys/kern/kern_lock.c:841
#5  0xffffffff808c3c64 in VOP_LOCK1 (vp=0xfffff80085627b70, flags=532480, file=0xffffffff80c40f02 "/usr/devel/git/motil/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c", line=1438) at ./vnode_if.h:879
#6  _vn_lock (vp=0xfffff80085627b70, flags=532480, file=0xffffffff80c40f02 "/usr/devel/git/motil/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c", line=1438) at /usr/devel/git/motil/sys/kern/vfs_vnops.c:1613
#7  0xffffffff8045ef27 in zfs_lookup_lock (dvp=0xfffff8000bc1c5b8, vp=0xfffff80085627b70, name=0xfffffe00b07cb3b0 "kcminit.1001.00.core", lkflags=532480)
    at /usr/devel/git/motil/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c:1438
#8  zfs_lookup (dvp=<optimized out>, nm=0xfffffe00b07cb3b0 "kcminit.1001.00.core", vpp=<optimized out>, cnp=0xfffffe00b07cb8a0, nameiop=1, cr=<optimized out>, td=<optimized out>, flags=0, cached=1)
    at /usr/devel/git/motil/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c:1612
#9  0xffffffff8045f60d in zfs_freebsd_lookup (ap=0xfffffe00b07cb4e0, cached=<error reading variable: Cannot access memory at address 0x1>) at /usr/devel/git/motil/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c:4922
#10 zfs_freebsd_cachedlookup (ap=0xfffffe00b07cb4e0) at /usr/devel/git/motil/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c:4930
#11 0xffffffff80898248 in VOP_CACHEDLOOKUP (dvp=0xfffff8000bc1c5b8, vpp=0xfffffe00b07cb870, cnp=0xfffffe00b07cb8a0) at ./vnode_if.h:80
#12 vfs_cache_lookup (ap=<optimized out>) at /usr/devel/git/motil/sys/kern/vfs_cache.c:2149
#13 0xffffffff808a22c1 in VOP_LOOKUP (dvp=0xfffff8000bc1c5b8, vpp=0xfffffe00b07cb870, cnp=0xfffffe00b07cb8a0) at ./vnode_if.h:54
#14 lookup (ndp=0xfffffe00b07cb810) at /usr/devel/git/motil/sys/kern/vfs_lookup.c:951
#15 0xffffffff808a17f3 in namei (ndp=0xfffffe00b07cb810) at /usr/devel/git/motil/sys/kern/vfs_lookup.c:512
#16 0xffffffff808c314b in vn_open_cred (ndp=0xfffffe00b07cb810, flagp=0xfffffe00b07cba4c, cmode=384, vn_open_flags=5, cred=0xfffff801edb7a000, fp=0x0) at /usr/devel/git/motil/sys/kern/vfs_vnops.c:226
#17 0xffffffff807dcec4 in corefile_open_last (td=<optimized out>, name=<optimized out>, indexpos=<optimized out>, indexlen=<optimized out>, ncores=<optimized out>, vpp=<optimized out>)
    at /usr/devel/git/motil/sys/kern/kern_sig.c:3434
#18 corefile_open (comm=0xfffff80013c098f0 "kcminit", uid=<optimized out>, pid=<optimized out>, td=0xfffffe00b4f85500, compress=0, signum=5, vpp=<optimized out>, namep=<optimized out>)
    at /usr/devel/git/motil/sys/kern/kern_sig.c:3585
#19 coredump (td=0xfffffe00b4f85500) at /usr/devel/git/motil/sys/kern/kern_sig.c:3669
#20 sigexit (td=0xfffffe00b4f85500, sig=6) at /usr/devel/git/motil/sys/kern/kern_sig.c:3211
#21 0xffffffff807ddc3c in postsig (sig=6) at /usr/devel/git/motil/sys/kern/kern_sig.c:3109
#22 0xffffffff8083969b in ast (framep=0xfffffe00b07cbc00) at /usr/devel/git/motil/sys/kern/subr_trap.c:336
Wed, May 27, 12:42 PM
avg requested review of D25027: corefile_open_last: don't keep a locked vnode while locking other ones.
Wed, May 27, 12:35 PM

Tue, May 26

avg updated the diff for D25014: ifconfig.8: fix cpability and flag descriptions for list scan / sta.

fix a typo

Tue, May 26, 9:05 AM
avg added a comment to D25014: ifconfig.8: fix cpability and flag descriptions for list scan / sta.

Some of the new description can use additional explanation, but I am not sufficiently fluent with WiFi concepts to do that.

Tue, May 26, 9:03 AM
avg requested review of D25014: ifconfig.8: fix cpability and flag descriptions for list scan / sta.
Tue, May 26, 9:00 AM
avg committed rS361496: MFC r360956: zfs allow/unallow should work with numeric uid/gid.
MFC r360956: zfs allow/unallow should work with numeric uid/gid
Tue, May 26, 5:56 AM
avg committed rS361495: MFC r360657: acpi_video: support systems without non-essential methods.
MFC r360657: acpi_video: support systems without non-essential methods
Tue, May 26, 5:54 AM

Sun, May 24

avg committed rS361434: libprocstat: try to fix fallout from r361363.
libprocstat: try to fix fallout from r361363
Sun, May 24, 2:54 PM

Fri, May 22

avg committed rS361391: MFC r354941,r354948: 10601 10757 Pool allocation classes.
MFC r354941,r354948: 10601 10757 Pool allocation classes
Fri, May 22, 4:51 PM
avg committed rS361383: MFC r354804,r354806,r354807,r354885: 10499 Multi-modifier protection (MMP).
MFC r354804,r354806,r354807,r354885: 10499 Multi-modifier protection (MMP)
Fri, May 22, 1:27 PM
avg committed rS361377: MFC r354333,r354359: zfs: enable SPA_PROCESS on the kernel side.
MFC r354333,r354359: zfs: enable SPA_PROCESS on the kernel side
Fri, May 22, 12:26 PM
avg committed rS361376: MFC r353679: document taskqueue_start_threads_in_proc.
MFC r353679: document taskqueue_start_threads_in_proc
Fri, May 22, 12:21 PM
avg committed rS361375: MFC r361006: linuxkpi: print stack trace in WARN_ON macros.
MFC r361006: linuxkpi: print stack trace in WARN_ON macros
Fri, May 22, 12:10 PM
avg committed rS361374: MFC r361002: snd_hda: fix typos related to quirks set via 'config' tunable.
MFC r361002: snd_hda: fix typos related to quirks set via 'config' tunable
Fri, May 22, 12:09 PM
avg committed rS361373: MFC r361001: sound/hda: newer AMD devices still require the same PCIe snoop.
MFC r361001: sound/hda: newer AMD devices still require the same PCIe snoop
Fri, May 22, 12:07 PM
avg committed rS361372: MFC r360779: gpioiic_attach: fix a NULL pointer crash on hints-based systems.
MFC r360779: gpioiic_attach: fix a NULL pointer crash on hints-based systems
Fri, May 22, 12:05 PM
avg committed rS361371: MFC r360692: usbhid: add several missing usages from Digitizer page.
MFC r360692: usbhid: add several missing usages from Digitizer page
Fri, May 22, 12:03 PM
avg committed rS361370: MFC r360499: ig4iic_acpi_probe: remove set but unused variable.
MFC r360499: ig4iic_acpi_probe: remove set but unused variable
Fri, May 22, 12:01 PM
avg committed rS361369: MFC r360246: acpi_video: fix a crash in detach with an LCD output.
MFC r360246: acpi_video: fix a crash in detach with an LCD output
Fri, May 22, 12:00 PM
avg committed rS361368: MFC r360242: acpi_iicbus: set device description in the probe method.
MFC r360242: acpi_iicbus: set device description in the probe method
Fri, May 22, 11:58 AM
avg committed rS361367: MFC r360241: ig4: ensure that drivers always attach in correct order.
MFC r360241: ig4: ensure that drivers always attach in correct order
Fri, May 22, 11:56 AM
avg committed rS361366: MFC r358381: use ZFS_MAX_DATASET_NAME_LEN instead of MAXPATHLEN for dataset….
MFC r358381: use ZFS_MAX_DATASET_NAME_LEN instead of MAXPATHLEN for dataset…
Fri, May 22, 11:53 AM
avg committed rS361365: MFC r358380,r358382: dsl_dataset_promote_sync: populate 'oldname' before using….
MFC r358380,r358382: dsl_dataset_promote_sync: populate 'oldname' before using…
Fri, May 22, 11:41 AM
avg closed D24925: net80211: post RTM_IFINFO notification after toggling IFF_DRV_RUNNING.
Fri, May 22, 11:26 AM
avg committed rS361364: net80211: post RTM_IFINFO notification after toggling IFF_DRV_RUNNING.
net80211: post RTM_IFINFO notification after toggling IFF_DRV_RUNNING
Fri, May 22, 11:26 AM
avg committed rS361363: libprocstat: fix ZFS support.
libprocstat: fix ZFS support
Fri, May 22, 11:20 AM
avg closed D24941: libprocstat: fix ZFS support.
Fri, May 22, 11:20 AM

Thu, May 21

avg added inline comments to D24941: libprocstat: fix ZFS support.
Thu, May 21, 8:35 PM
avg updated the diff for D24941: libprocstat: fix ZFS support.

address markj's feedback

Thu, May 21, 4:04 PM
avg added a comment to D24941: libprocstat: fix ZFS support.

Thank you for the feedback.
Working on it.

Thu, May 21, 4:02 PM
avg updated the diff for D24941: libprocstat: fix ZFS support.

catch up with the fact that zfs.c is a "normal" file now

Thu, May 21, 2:08 PM
avg requested review of D24941: libprocstat: fix ZFS support.
Thu, May 21, 2:03 PM
avg committed rS361330: libprocstat: fix reading of file descriptor table via kvm.
libprocstat: fix reading of file descriptor table via kvm
Thu, May 21, 1:46 PM
avg added a comment to D24925: net80211: post RTM_IFINFO notification after toggling IFF_DRV_RUNNING.

@adrian, is this closer to what you have in mind?
Thanks!

Thu, May 21, 8:05 AM
avg updated the diff for D24925: net80211: post RTM_IFINFO notification after toggling IFF_DRV_RUNNING.

do not call rt_ifmsg directly, wrap it under ieee80211_notify_ifnet_change

Thu, May 21, 8:04 AM

Wed, May 20

avg added a comment to D24839: Don't block on the range lock in zfs_getpages()..

Mark, thank you very much for this!
I think that this change is good.
I still wonder if we can do some trick to avoid busying valid pages.
Maybe there is some way to be more sloppy when checking the validity.
E.g., we could possibly rely on a fact that with ZFS the range lock makes sure the validity cannot change because both page-in and page-out would need to lock the range.

Wed, May 20, 8:22 AM
avg closed D24923: iwm: improve rfkill handling.
Wed, May 20, 8:15 AM
avg committed rS361273: iwm: improve rfkill handling.
iwm: improve rfkill handling
Wed, May 20, 8:15 AM
avg requested review of D24925: net80211: post RTM_IFINFO notification after toggling IFF_DRV_RUNNING.
Wed, May 20, 6:53 AM

Tue, May 19

avg requested review of D24923: iwm: improve rfkill handling.
Tue, May 19, 10:36 PM

Wed, May 13

avg committed rS361006: linuxkpi: print stack trace in WARN_ON macros.
linuxkpi: print stack trace in WARN_ON macros
Wed, May 13, 7:48 AM
avg added a comment to D24779: linuxkpi: print stack trace in WARN_ON macros.

Should this be under INVARIANTS?

Wed, May 13, 7:37 AM
avg committed rS361002: snd_hda: fix typos related to quirks set via 'config' tunable.
snd_hda: fix typos related to quirks set via 'config' tunable
Wed, May 13, 6:26 AM
avg committed rS361001: sound/hda: newer AMD devices still require the same PCIe snoop.
sound/hda: newer AMD devices still require the same PCIe snoop
Wed, May 13, 6:25 AM

Tue, May 12

avg committed rS360957: amd64/pmap: unbreak !NUMA case for fictitious pages.
amd64/pmap: unbreak !NUMA case for fictitious pages
Tue, May 12, 9:32 AM
avg committed rS360956: zfs allow/unallow should work with numeric uid/gid.
zfs allow/unallow should work with numeric uid/gid
Tue, May 12, 9:05 AM
avg abandoned D15964: subr_bus: add a list of attached children to record their order.

No feedback in long time.

Tue, May 12, 7:53 AM

Thu, May 7

avg updated the diff for D24733: teach ena driver about RSS kernel option.

update the module makefile

Thu, May 7, 1:24 PM
avg committed rS360779: gpioiic_attach: fix a NULL pointer crash on hints-based systems.
gpioiic_attach: fix a NULL pointer crash on hints-based systems
Thu, May 7, 1:12 PM

Wed, May 6

avg committed rS360692: usbhid: add several missing usages from Digitizer page.
usbhid: add several missing usages from Digitizer page
Wed, May 6, 3:24 PM
avg requested review of D24733: teach ena driver about RSS kernel option.
Wed, May 6, 8:45 AM

May 5 2020

avg committed rS360657: acpi_video: try our best to work on systems without non-essential methods.
acpi_video: try our best to work on systems without non-essential methods
May 5 2020, 12:14 PM
avg closed D24653: acpi_video: try our best to work on systems without non-essential methods.
May 5 2020, 12:14 PM

May 4 2020

avg updated the diff for D24653: acpi_video: try our best to work on systems without non-essential methods.

rebase on the latest tree

May 4 2020, 12:51 PM
avg added a comment to D24653: acpi_video: try our best to work on systems without non-essential methods.

Yeah, I think that it is better to use _BQC whenever it is actually provided because there can be multiple ways to control the brightness.
The more I look into this the more quirks I discover.
Some systems handle brightness keys completely in firmware, some post ACPI events, some post custom events via WMI.
On some systems _BCM actually changes the brightness (it's handled by the firmware); on some systems _BCM is just another level of indirection -- it just posts more events to be handled elsewhere (e.g., via ATIF with AMD's video).
I think that Linux drifts towards converting brightness events to evdev brightness key events and then letting the userland handle those keys. The actual brightness controls are exposed as sysfs backlight nodes and they cab be hooked to ACPI video (_BCM) or directly to graphics drivers or something vendor specific, etc.

May 4 2020, 8:20 AM

May 1 2020

avg updated the test plan for D24653: acpi_video: try our best to work on systems without non-essential methods.
May 1 2020, 5:00 PM
avg added a reviewer for D24653: acpi_video: try our best to work on systems without non-essential methods: manu.
May 1 2020, 4:49 PM
avg updated subscribers of D24653: acpi_video: try our best to work on systems without non-essential methods.
May 1 2020, 4:47 PM
avg requested review of D24653: acpi_video: try our best to work on systems without non-essential methods.
May 1 2020, 4:46 PM

Apr 30 2020

avg committed rS360499: ig4iic_acpi_probe: remove set but unused variable.
ig4iic_acpi_probe: remove set but unused variable
Apr 30 2020, 3:45 PM

Apr 24 2020

avg committed rS360248: ccp: add a new hardware ID, found on AMD Ryzen 3 3200U.
ccp: add a new hardware ID, found on AMD Ryzen 3 3200U
Apr 24 2020, 10:21 AM
avg committed rS360246: acpi_video: fix a crash in detach with an LCD output.
acpi_video: fix a crash in detach with an LCD output
Apr 24 2020, 9:32 AM
avg committed rS360242: acpi_iicbus: set device description in the probe method.
acpi_iicbus: set device description in the probe method
Apr 24 2020, 7:55 AM
avg committed rS360241: ig4: ensure that drivers always attach in correct order.
ig4: ensure that drivers always attach in correct order
Apr 24 2020, 7:49 AM

Apr 18 2020

avg accepted D24488: zfs-program.8: fix orphan .Xr.
Apr 18 2020, 8:36 PM
avg added a comment to D24488: zfs-program.8: fix orphan .Xr.

LGTM!

Apr 18 2020, 8:36 PM

Mar 6 2020

avg accepted D23986: zfs dmu_read: loosen the assertion..

Looks good as far as my knowledge of the recent VM changes goes.
Thank you very much!

Mar 6 2020, 1:52 PM

Mar 3 2020

avg accepted D23945: Fix iflib zero-length fragment handling.

LGTM.
I assume that a change to vmxnet3 that takes advantage of this improvement is coming.

Mar 3 2020, 4:17 PM
avg accepted D23943: Fix iflib freelist state corruption.

We came to the same conclusion at Panzura and used a similar fix.

Mar 3 2020, 4:12 PM

Feb 28 2020

avg abandoned D23852: scsi_scan_bus: ignore Initiator ID for SAS transport in.

I like Ken's suggestion on PIM_NO_INIT_ID.

Feb 28 2020, 3:24 PM

Feb 27 2020

avg added a comment to D23852: scsi_scan_bus: ignore Initiator ID for SAS transport in.

@mav , I do not know much about this but I would expect that if an initiator can also be a target then its target ID -- which, if I understand correctly, you suggest to be treated as an initiator ID -- would be from a different namespace than IDs of its targets. That is, I think that for a SAS initiator it is impossible to see itself as a target (where a target ID is typically also some made up number derived from the actual SAS topology).

Feb 27 2020, 10:16 PM
avg committed rS358388: MFC r355325: devstat_selectdevs: resize dev_select only after copying data.
MFC r355325: devstat_selectdevs: resize dev_select only after copying data
Feb 27 2020, 3:22 PM
avg created D23852: scsi_scan_bus: ignore Initiator ID for SAS transport in.
Feb 27 2020, 3:20 PM
avg committed rS358386: MFC r357042: vmxnet3: add support for RSS kernel option.
MFC r357042: vmxnet3: add support for RSS kernel option
Feb 27 2020, 3:09 PM
avg committed rS358385: MFC r357040: virtio_scsi: use max target ID plus one as the initiator ID.
MFC r357040: virtio_scsi: use max target ID plus one as the initiator ID
Feb 27 2020, 2:53 PM
avg committed rS358384: MFC r356730: storvsc: properly set residual data length on errors.
MFC r356730: storvsc: properly set residual data length on errors
Feb 27 2020, 2:50 PM
avg committed rS358383: MFC r355736: zfs boot: fix a crash in a rarely taken path in fzap_lookup.
MFC r355736: zfs boot: fix a crash in a rarely taken path in fzap_lookup
Feb 27 2020, 2:48 PM
avg updated the diff for D23478: rework how ZVOLs are updated in response to DSL operations.

Move creation of a "minor" from dsl_dataset_snapshot_sync_impl() to
dsl_dataset_snapshot_sync(). The former is also used by
dsl_dataset_snapshot_tmp_sync() and we do not need to create minors for
temporary snapshots. They are used only by zfs diff against a filesystem (via
ZFS_IOC_TMP_SNAPSHOT).

Feb 27 2020, 2:41 PM
avg updated the diff for D23478: rework how ZVOLs are updated in response to DSL operations.

rebase to r358382

Feb 27 2020, 2:30 PM