Page MenuHomeFreeBSD

avg (Andriy Gapon)
User

Projects

User Details

User Since
Jun 4 2014, 6:42 AM (524 w, 3 d)

Recent Activity

Thu, Jun 20

avg accepted D45649: dtrace: Add a partial implementation of dtrace_getarg() on arm64.
Thu, Jun 20, 4:58 AM
avg accepted D45647: Document and subtlely change the zfs.mount_snapshot jail parameter.

I would subtly change the title :-)
Otherwise, looks good to me.

Thu, Jun 20, 4:57 AM · Jails, ZFS

Fri, Jun 14

avg accepted D44483: sdt: Prototype implementation of SDT probes using hot-patching.
Fri, Jun 14, 9:12 AM

Wed, Jun 5

avg accepted D45494: powerof2: replace loops with fls or ilog2.

Looks good to me.

Wed, Jun 5, 7:23 AM

Tue, Jun 4

avg accepted D45483: x86: simplify ceil(log2(x)) function.

Looks good to me.
A bit ashamed that I could not figure that fls(x - 1) does the job if zero is handled as a special case.

Tue, Jun 4, 5:30 PM

Apr 21 2024

avg committed rG43bf62a364c1: aw_gpio: temporarily switch to input function if read in eint mode (authored by avg).
aw_gpio: temporarily switch to input function if read in eint mode
Apr 21 2024, 12:32 PM
avg committed rG9c444571ab94: aw_gpio: temporarily switch to input function if read in eint mode (authored by avg).
aw_gpio: temporarily switch to input function if read in eint mode
Apr 21 2024, 12:32 PM
avg added a comment to D33647: dtrace: make 'ring' and 'fill' policies imply 'noswitch' flag.

All should be done. Thank you for reporting and diagnosing the problem.

Apr 21 2024, 12:30 PM
avg added a reverting change for rGe92491d95ff3: dtrace: make 'ring' and 'fill' policies imply 'noswitch' flag: rGf12a50fed2df: Revert "dtrace: make 'ring' and 'fill' policies imply 'noswitch' flag".
Apr 21 2024, 12:29 PM
avg committed rGf12a50fed2df: Revert "dtrace: make 'ring' and 'fill' policies imply 'noswitch' flag" (authored by avg).
Revert "dtrace: make 'ring' and 'fill' policies imply 'noswitch' flag"
Apr 21 2024, 12:29 PM
avg added a reverting change for rGe92491d95ff3: dtrace: make 'ring' and 'fill' policies imply 'noswitch' flag: rG73c9d514236e: Revert "dtrace: make 'ring' and 'fill' policies imply 'noswitch' flag".
Apr 21 2024, 12:29 PM
avg committed rG73c9d514236e: Revert "dtrace: make 'ring' and 'fill' policies imply 'noswitch' flag" (authored by avg).
Revert "dtrace: make 'ring' and 'fill' policies imply 'noswitch' flag"
Apr 21 2024, 12:28 PM
avg added a reverting change for rGe92491d95ff3: dtrace: make 'ring' and 'fill' policies imply 'noswitch' flag: rGb9827c007a7a: Revert "dtrace: make 'ring' and 'fill' policies imply 'noswitch' flag".
Apr 21 2024, 12:27 PM
avg committed rGb9827c007a7a: Revert "dtrace: make 'ring' and 'fill' policies imply 'noswitch' flag" (authored by avg).
Revert "dtrace: make 'ring' and 'fill' policies imply 'noswitch' flag"
Apr 21 2024, 12:27 PM

Apr 8 2024

avg added a comment to D33647: dtrace: make 'ring' and 'fill' policies imply 'noswitch' flag.

Looks like I assumed too much without paying attention to the scratch buffer.
I'll revert the change.

Apr 8 2024, 2:04 PM

Mar 16 2024

avg committed rG0cb72c25b01a: psci: split off psci_reboot from psci_shutdown (authored by avg).
psci: split off psci_reboot from psci_shutdown
Mar 16 2024, 3:17 PM
avg committed rGbf11fee6a5cf: ata_da: add quirk to disable NCQ TRIM for Samsung 860/870 SSDs (authored by avg).
ata_da: add quirk to disable NCQ TRIM for Samsung 860/870 SSDs
Mar 16 2024, 3:17 PM
avg committed rG721b91d1715e: syscon_power: do reboot after shutdown_panic is executed (authored by avg).
syscon_power: do reboot after shutdown_panic is executed
Mar 16 2024, 3:17 PM
avg committed rG50aa22323424: scsi_da: add 4K quirks for Samsung SSD 860 and 870 (authored by avg).
scsi_da: add 4K quirks for Samsung SSD 860 and 870
Mar 16 2024, 3:17 PM
avg committed rG1269b002038c: rk8xx_poweroff: enable power-cycling on support hardware (authored by avg).
rk8xx_poweroff: enable power-cycling on support hardware
Mar 16 2024, 3:17 PM
avg committed rG98ee1305b692: ugen: fix USB_IFACE_DRIVER_ACTIVE after detaching a driver (authored by avg).
ugen: fix USB_IFACE_DRIVER_ACTIVE after detaching a driver
Mar 16 2024, 3:17 PM
avg committed rGd463f7c7a726: psci: split off psci_reboot from psci_shutdown (authored by avg).
psci: split off psci_reboot from psci_shutdown
Mar 16 2024, 3:17 PM
avg committed rGb2681df2294b: syscon_power: do reboot after shutdown_panic is executed (authored by avg).
syscon_power: do reboot after shutdown_panic is executed
Mar 16 2024, 3:17 PM
avg committed rG4eab6e77fc2a: ata_da: add quirk to disable NCQ TRIM for Samsung 860/870 SSDs (authored by avg).
ata_da: add quirk to disable NCQ TRIM for Samsung 860/870 SSDs
Mar 16 2024, 3:17 PM
avg committed rG2e88c5c4b426: scsi_da: add 4K quirks for Samsung SSD 860 and 870 (authored by avg).
scsi_da: add 4K quirks for Samsung SSD 860 and 870
Mar 16 2024, 3:17 PM
avg committed rG5578ace4a174: ugen: fix USB_IFACE_DRIVER_ACTIVE after detaching a driver (authored by avg).
ugen: fix USB_IFACE_DRIVER_ACTIVE after detaching a driver
Mar 16 2024, 3:17 PM

Feb 19 2024

avg closed D43960: ugen: fix USB_IFACE_DRIVER_ACTIVE after detaching a driver.
Feb 19 2024, 10:45 AM
avg committed rG8f374fa528d7: ugen: fix USB_IFACE_DRIVER_ACTIVE after detaching a driver (authored by avg).
ugen: fix USB_IFACE_DRIVER_ACTIVE after detaching a driver
Feb 19 2024, 10:45 AM
avg committed rGb7dce5b8e988: scsi_da: add 4K quirks for Samsung SSD 860 and 870 (authored by avg).
scsi_da: add 4K quirks for Samsung SSD 860 and 870
Feb 19 2024, 10:28 AM
avg committed rGc01af41c3c8f: ata_da: add quirk to disable NCQ TRIM for Samsung 860/870 SSDs (authored by avg).
ata_da: add quirk to disable NCQ TRIM for Samsung 860/870 SSDs
Feb 19 2024, 10:09 AM
avg closed D43961: ata_da: add quirk to disable NCQ TRIM for Samsung 860/870 SSDs.
Feb 19 2024, 10:09 AM
avg updated the diff for D43961: ata_da: add quirk to disable NCQ TRIM for Samsung 860/870 SSDs.

update description

Feb 19 2024, 10:03 AM
avg added a comment to D43961: ata_da: add quirk to disable NCQ TRIM for Samsung 860/870 SSDs.

Based on earlier entries for Samsung 8x0 drives in ata_da.c and scsi_da.c it seems that a separate entry per model line was a preference.
But combing multiple entries is also okay.
However, I'd like to do it as a separate commit a bit later, unless you want to do that yourself.

Feb 19 2024, 9:56 AM
avg committed rG75316a59b39e: rdmsr_safe/wrmsr_safe: handle pcb_onfault nesting (authored by avg).
rdmsr_safe/wrmsr_safe: handle pcb_onfault nesting
Feb 19 2024, 9:52 AM

Feb 18 2024

avg added a comment to D43961: ata_da: add quirk to disable NCQ TRIM for Samsung 860/870 SSDs.
In D43961#1002853, @imp wrote:

These aren't listed in Linux but I'm OK with them here

Feb 18 2024, 4:57 PM
avg added a comment to D43961: ata_da: add quirk to disable NCQ TRIM for Samsung 860/870 SSDs.

The controller is

ahci2@pci0:0:17:0:      class=0x010601 rev=0x40 hdr=0x00 vendor=0x1002 device=0x4391 subvendor=0x1043 subdevice=0x84dd
    vendor     = 'Advanced Micro Devices, Inc. [AMD/ATI]'
    device     = 'SB7x0/SB8x0/SB9x0 SATA Controller [AHCI mode]'
    class      = mass storage
    subclass   = SATA
Feb 18 2024, 4:47 PM
avg added a comment to D43961: ata_da: add quirk to disable NCQ TRIM for Samsung 860/870 SSDs.

Just want to comment that based on the errors I initially thought that the problem was a bad cable or SATA port, so I tried a few cables and a few ports on the motherboard, all with the same result.
Then I searched the internet and found some reports for the SSD model.
Then I tried attaching the SSD to an LSI SAS 2308 controller and all problem immediately went away.
Then I added the quirk and the problem got fixed for connecting to on-board SATA as well.

Feb 18 2024, 4:42 PM
avg committed rGa044cf60bd37: rk8xx_poweroff: add parentheses missed in 8b408fc6f2 (authored by avg).
rk8xx_poweroff: add parentheses missed in 8b408fc6f2
Feb 18 2024, 4:30 PM
avg added a comment to D43961: ata_da: add quirk to disable NCQ TRIM for Samsung 860/870 SSDs.

I should clarify that I didn't see just silent data corruption, there were read and write errors as well.

Feb 18 2024, 3:56 PM
avg added a comment to D43961: ata_da: add quirk to disable NCQ TRIM for Samsung 860/870 SSDs.

I first-hand experienced problems with a device identified as Samsung SSD 870 EVO 250GB SVT02B6Q.
I inferred that 860 is also affected based on the Linux bug report and on a similar problem with 850 as well.

Feb 18 2024, 3:51 PM
avg requested review of D43961: ata_da: add quirk to disable NCQ TRIM for Samsung 860/870 SSDs.
Feb 18 2024, 3:47 PM
avg added inline comments to D43960: ugen: fix USB_IFACE_DRIVER_ACTIVE after detaching a driver.
Feb 18 2024, 3:45 PM
avg requested review of D43960: ugen: fix USB_IFACE_DRIVER_ACTIVE after detaching a driver.
Feb 18 2024, 2:50 PM
avg committed rG5f7312a0d70c: syscon_power: do reboot after shutdown_panic is executed (authored by avg).
syscon_power: do reboot after shutdown_panic is executed
Feb 18 2024, 2:39 PM
avg committed rG0f354b2b588b: psci: split off psci_reboot from psci_shutdown (authored by avg).
psci: split off psci_reboot from psci_shutdown
Feb 18 2024, 2:39 PM
avg committed rG8b408fc6f2f6: rk8xx_poweroff: enable power-cycling on support hardware (authored by avg).
rk8xx_poweroff: enable power-cycling on support hardware
Feb 18 2024, 2:09 PM
avg committed rGb98558e69b0a: aw_gpio: temporarily switch to input function if read in eint mode (authored by avg).
aw_gpio: temporarily switch to input function if read in eint mode
Feb 18 2024, 1:58 PM

Feb 17 2024

avg committed rG854db1db3f81: run acpi_shutdown_final later to give other handlers a chance (authored by avg).
run acpi_shutdown_final later to give other handlers a chance
Feb 17 2024, 7:59 PM
avg committed rG5d24ae53b622: rdmsr_safe/wrmsr_safe: handle pcb_onfault nesting (authored by avg).
rdmsr_safe/wrmsr_safe: handle pcb_onfault nesting
Feb 17 2024, 7:23 PM
avg committed rGa669851b3516: subr_bus: report DEVICE_SUSPEND failures (authored by avg).
subr_bus: report DEVICE_SUSPEND failures
Feb 17 2024, 7:23 PM
avg committed rG1b92999e67b6: efibootmgr: fix potential endless loop with -v (authored by avg).
efibootmgr: fix potential endless loop with -v
Feb 17 2024, 7:23 PM
avg committed rGf0ed49921c28: dtrace: make 'ring' and 'fill' policies imply 'noswitch' flag (authored by avg).
dtrace: make 'ring' and 'fill' policies imply 'noswitch' flag
Feb 17 2024, 7:23 PM
avg committed rG4df1b9cc2bff: hdaa_pcmchannel_setup: do not advertise AC3 8+0 (authored by avg).
hdaa_pcmchannel_setup: do not advertise AC3 8+0
Feb 17 2024, 7:23 PM
avg committed rGfaa59e9ab402: ichsmb: fix block read operation (authored by avg).
ichsmb: fix block read operation
Feb 17 2024, 7:23 PM
avg committed rG9ca7451d86dc: change ipmi watchdog to awlays stop when system is halted (authored by avg).
change ipmi watchdog to awlays stop when system is halted
Feb 17 2024, 7:23 PM
avg committed rG392953c490da: fix signature of ipmi_shutdown_event (authored by avg).
fix signature of ipmi_shutdown_event
Feb 17 2024, 7:23 PM
avg committed rGa4e1bf22796a: mmc_fdt_parse: remove redundant bootverbose check (authored by avg).
mmc_fdt_parse: remove redundant bootverbose check
Feb 17 2024, 7:23 PM
avg committed rGb44d933e2617: dwmmc: fix a typo (authored by avg).
dwmmc: fix a typo
Feb 17 2024, 7:23 PM
avg committed rG929db0457513: gpiopower: trigger low, high and both edges (authored by avg).
gpiopower: trigger low, high and both edges
Feb 17 2024, 7:23 PM
avg committed rGbad04f1ebc3a: add allwinner overlays for enabling additional USB ports (authored by avg).
add allwinner overlays for enabling additional USB ports
Feb 17 2024, 7:23 PM
avg committed rGbd51dc9408d2: usbdevs: add Ralink RT7601 aka MT7601 (authored by avg).
usbdevs: add Ralink RT7601 aka MT7601
Feb 17 2024, 7:23 PM
avg committed rGac918f4354e0: ds1307: restore hints-based configuration on FDT systems (authored by avg).
ds1307: restore hints-based configuration on FDT systems
Feb 17 2024, 7:22 PM
avg committed rGb46dedfa48ef: run acpi_shutdown_final later to give other handlers a chance (authored by avg).
run acpi_shutdown_final later to give other handlers a chance
Feb 17 2024, 3:28 PM
avg committed rG007b84e6c159: rdmsr_safe/wrmsr_safe: handle pcb_onfault nesting (authored by avg).
rdmsr_safe/wrmsr_safe: handle pcb_onfault nesting
Feb 17 2024, 3:14 PM
avg committed rG4cb348eaf6ac: subr_bus: report DEVICE_SUSPEND failures (authored by avg).
subr_bus: report DEVICE_SUSPEND failures
Feb 17 2024, 3:13 PM
avg committed rG191462cb674c: efibootmgr: fix potential endless loop with -v (authored by avg).
efibootmgr: fix potential endless loop with -v
Feb 17 2024, 3:13 PM
avg committed rG782b71ccfb1c: hdaa_pcmchannel_setup: do not advertise AC3 8+0 (authored by avg).
hdaa_pcmchannel_setup: do not advertise AC3 8+0
Feb 17 2024, 3:13 PM
avg committed rGfb9c50f983ff: dtrace: make 'ring' and 'fill' policies imply 'noswitch' flag (authored by avg).
dtrace: make 'ring' and 'fill' policies imply 'noswitch' flag
Feb 17 2024, 3:13 PM
avg committed rGa9bab712eb10: ichsmb: fix block read operation (authored by avg).
ichsmb: fix block read operation
Feb 17 2024, 3:13 PM
avg committed rGb5d826b1b6bc: change ipmi watchdog to awlays stop when system is halted (authored by avg).
change ipmi watchdog to awlays stop when system is halted
Feb 17 2024, 3:13 PM
avg committed rGe009f28ea46d: fix signature of ipmi_shutdown_event (authored by avg).
fix signature of ipmi_shutdown_event
Feb 17 2024, 3:13 PM
avg committed rG96b8d8a62bd7: dwmmc: fix a typo (authored by avg).
dwmmc: fix a typo
Feb 17 2024, 3:13 PM
avg committed rGcd5038b62ec2: mmc_fdt_parse: remove redundant bootverbose check (authored by avg).
mmc_fdt_parse: remove redundant bootverbose check
Feb 17 2024, 3:13 PM
avg committed rG1dd72f26e3a3: rk_i2s: remove unused definition (authored by avg).
rk_i2s: remove unused definition
Feb 17 2024, 3:13 PM
avg committed rG52dfb8b11453: rk_i2s: change interrupt type from MISC to AV (audio/video) (authored by avg).
rk_i2s: change interrupt type from MISC to AV (audio/video)
Feb 17 2024, 3:13 PM
avg committed rG7742d4d404db: rk3328_codec: remove diagostic printfs (authored by avg).
rk3328_codec: remove diagostic printfs
Feb 17 2024, 3:13 PM
avg committed rGd6e54e538e83: audio_soc: set "status" as being at simplebus (authored by avg).
audio_soc: set "status" as being at simplebus
Feb 17 2024, 3:13 PM
avg committed rG87a7011b0974: add allwinner overlays for enabling additional USB ports (authored by avg).
add allwinner overlays for enabling additional USB ports
Feb 17 2024, 3:13 PM
avg committed rG1595c09ee252: gpiopower: trigger low, high and both edges (authored by avg).
gpiopower: trigger low, high and both edges
Feb 17 2024, 3:13 PM
avg committed rG2036512135c9: usbdevs: add Ralink RT7601 aka MT7601 (authored by avg).
usbdevs: add Ralink RT7601 aka MT7601
Feb 17 2024, 3:13 PM
avg committed rG1efdba436281: ds1307: restore hints-based configuration on FDT systems (authored by avg).
ds1307: restore hints-based configuration on FDT systems
Feb 17 2024, 3:13 PM

Feb 6 2024

avg committed rGe4ab361e5394: fix poweroff regression from 9cdf326b4f by delaying shutdown_halt (authored by avg).
fix poweroff regression from 9cdf326b4f by delaying shutdown_halt
Feb 6 2024, 9:42 AM

Jan 30 2024

avg committed rG486b265a8fb6: rdmsr_safe/wrmsr_safe: handle pcb_onfault nesting (authored by avg).
rdmsr_safe/wrmsr_safe: handle pcb_onfault nesting
Jan 30 2024, 6:47 AM
avg closed D43639: rdmsr_safe/wrmsr_safe: handle pcb_onfault nesting.
Jan 30 2024, 6:47 AM
avg accepted D43650: cd: Remove commented-out code.
Jan 30 2024, 6:41 AM

Jan 29 2024

avg updated the diff for D43639: rdmsr_safe/wrmsr_safe: handle pcb_onfault nesting.

restore previous handler in the error path

Jan 29 2024, 5:31 PM
avg added inline comments to D43639: rdmsr_safe/wrmsr_safe: handle pcb_onfault nesting.
Jan 29 2024, 4:16 PM
avg added a comment to D43639: rdmsr_safe/wrmsr_safe: handle pcb_onfault nesting.

@kib , thank you for the feedback.

Jan 29 2024, 7:10 AM

Jan 28 2024

avg abandoned D33647: dtrace: make 'ring' and 'fill' policies imply 'noswitch' flag.

Committed in e92491d95ff.

Jan 28 2024, 9:58 PM
avg abandoned D33302: zfs boot: prefer a pool with bootfs set for a boot pool.

While controlling which pool is a boot via bootfs property sounds useful, it adds yet another degree of freedom in the boot configuration.
I don't want legacy "BIOS" boot and EFI boot to diverge and I don't have time to work on the EFI ZFS boot code.
I think that this change was good, but I think that we can manage just fine without it.
So, I am withdrawing it.

Jan 28 2024, 9:56 PM
avg abandoned D26049: [PREVIEW] twsi: fixes, improvements, cleanups.

This has been committed in ff1e8581806f7 and other commits.

Jan 28 2024, 9:51 PM
avg requested review of D43639: rdmsr_safe/wrmsr_safe: handle pcb_onfault nesting.
Jan 28 2024, 9:37 PM
avg committed rG4d1161f094dd: subr_bus: report DEVICE_SUSPEND failures (authored by avg).
subr_bus: report DEVICE_SUSPEND failures
Jan 28 2024, 1:22 PM
avg committed rGbf87d4a4bfaa: efibootmgr: fix potential endless loop with -v (authored by avg).
efibootmgr: fix potential endless loop with -v
Jan 28 2024, 1:21 PM
avg committed rGc053a56c0f5d: hdaa_pcmchannel_setup: do not advertise AC3 8+0 (authored by avg).
hdaa_pcmchannel_setup: do not advertise AC3 8+0
Jan 28 2024, 1:19 PM
avg committed rGe92491d95ff3: dtrace: make 'ring' and 'fill' policies imply 'noswitch' flag (authored by avg).
dtrace: make 'ring' and 'fill' policies imply 'noswitch' flag
Jan 28 2024, 1:16 PM
avg committed rG9cdf326b4fae: run acpi_shutdown_final later to give other handlers a chance (authored by avg).
run acpi_shutdown_final later to give other handlers a chance
Jan 28 2024, 1:14 PM
avg committed rGcbf7c81b608b: ichsmb: fix block read operation (authored by avg).
ichsmb: fix block read operation
Jan 28 2024, 12:55 PM
avg committed rG8fdb26160160: change ipmi watchdog to awlays stop when system is halted (authored by avg).
change ipmi watchdog to awlays stop when system is halted
Jan 28 2024, 12:48 PM
avg committed rG90dc7889825d: fix signature of ipmi_shutdown_event (authored by avg).
fix signature of ipmi_shutdown_event
Jan 28 2024, 12:45 PM