Page MenuHomeFreeBSD

avg (Andriy Gapon)
User

Projects

User Details

User Since
Jun 4 2014, 6:42 AM (235 w, 5 d)

Recent Activity

Today

avg updated the diff for D18496: add a knob that disables detection of write protected disks.

correct description of the new sysctl

Mon, Dec 10, 8:26 AM
avg added a comment to D18496: add a knob that disables detection of write protected disks.

While here, I also fixed setting of the next state in the case of malloc failure in DA_STATE_PROBE_WP.

Mon, Dec 10, 8:23 AM
avg created D18496: add a knob that disables detection of write protected disks.
Mon, Dec 10, 8:21 AM
avg added a comment to D18494: Revert to using the upstream zpool-features(7) man page.

Unfortunately, I disagree with this change. I think that it is backwards.
illumos has already translated their zfs.1m and zpool.1m to mdoc format, so I assume that that's the direction they are moving in.
I'd rather help them with that in this case as well.
IMO, that would be a better way to overcome the divergence.

Mon, Dec 10, 7:27 AM

Fri, Dec 7

avg committed rS341696: acpi_MatchHid: use ACPI_MATCHHID_NOMATCH instead of FALSE.
acpi_MatchHid: use ACPI_MATCHHID_NOMATCH instead of FALSE
Fri, Dec 7, 4:08 PM
avg committed rS341695: aibs: fix a typo in the probe method that was introduced in r339754.
aibs: fix a typo in the probe method that was introduced in r339754
Fri, Dec 7, 4:04 PM
avg committed rS341681: daprobedone: announce if a disk is write-protected.
daprobedone: announce if a disk is write-protected
Fri, Dec 7, 12:04 PM
avg updated the diff for D15755: add support for marking interrupt handlers as suspended.
  • add and make use of rman_{get,set}_irq_cookie() and a new field r_irq_cookie to back them
  • slide up head
Fri, Dec 7, 11:02 AM

Thu, Dec 6

avg added inline comments to D15755: add support for marking interrupt handlers as suspended.
Thu, Dec 6, 2:35 PM
avg committed rS341633: MFC r336641: fix incorrect operator in the AUDITPIPE_SET_QLIMIT bounds check.
MFC r336641: fix incorrect operator in the AUDITPIPE_SET_QLIMIT bounds check
Thu, Dec 6, 1:33 PM
avg committed rS341632: acpi_{Device,Battery}IsPresent: restore pre-r330957 behaviour.
acpi_{Device,Battery}IsPresent: restore pre-r330957 behaviour
Thu, Dec 6, 12:34 PM
avg added a reviewer for D7179: move handling of zvol devices out of txg sync thread: mav.
Thu, Dec 6, 8:35 AM

Tue, Dec 4

avg added a comment to D18420: add a method to defer destruction of if_softc to if_destroy.
In D18420#392363, @ae wrote:

I'm inclined to agree. For tunneling interfaces I used global per-driver sx lock to prevent concurrent ioctl invocation. I think these drivers are not affected by this problem.

Tue, Dec 4, 12:15 PM
avg added a comment to D18420: add a method to defer destruction of if_softc to if_destroy.
In D18420#392349, @ae wrote:

Can you provide an example, what another driver needs such method? Maybe it is enough to fix the problem locally in if_lagg for first time?

Tue, Dec 4, 11:03 AM

Mon, Dec 3

avg added a comment to D18420: add a method to defer destruction of if_softc to if_destroy.
In D18420#392053, @bz wrote:

Sorry but my understanding is that this could possibly free the softc even before lagg_clone_destroy() has finished, couldn't it?

Mon, Dec 3, 4:35 PM
avg created D18420: add a method to defer destruction of if_softc to if_destroy.
Mon, Dec 3, 1:24 PM
avg added a member for x86: avg.
Mon, Dec 3, 1:24 PM
avg added a member for Src Committers: avg.
Mon, Dec 3, 1:24 PM
avg removed a member for bhyve: avg.
Mon, Dec 3, 1:20 PM
avg accepted D18391: zfs: we can boot from dataset with large_dnode enabled.
Mon, Dec 3, 1:17 PM

Fri, Nov 30

avg added a comment to D18391: zfs: we can boot from dataset with large_dnode enabled.

Maybe rather than removing the code it would be better to ifdef it out?
But not sure. What are plans for illumos in this respect?

Fri, Nov 30, 11:30 AM

Wed, Nov 21

avg updated subscribers of D17465: Socket level scheduling support for Multi Socket system.

Scheduler should be aware of the topology of socket also as to keep threads in same socket if possible while migration as

Wed, Nov 21, 6:18 AM

Tue, Nov 20

avg added a comment to D17465: Socket level scheduling support for Multi Socket system.

I see what the change does but not why. Could you please provide some rationale?

Tue, Nov 20, 6:58 AM

Mon, Nov 19

avg committed rS340626: MFC r339595: nfsrvd_readdirplus: for some errors, do not fail the entire request.
MFC r339595: nfsrvd_readdirplus: for some errors, do not fail the entire request
Mon, Nov 19, 10:01 AM

Nov 6 2018

avg committed rS340190: MFC r339591: ichwd: add support for TCO watchdog timer in Lewisburg PCH (C620).
MFC r339591: ichwd: add support for TCO watchdog timer in Lewisburg PCH (C620)
Nov 6 2018, 5:31 PM
avg committed rS340184: MFC r339595: nfsrvd_readdirplus: for some errors, do not fail the entire request.
MFC r339595: nfsrvd_readdirplus: for some errors, do not fail the entire request
Nov 6 2018, 2:23 PM
avg committed rS340183: MFC r339595: nfsrvd_readdirplus: for some errors, do not fail the entire request.
MFC r339595: nfsrvd_readdirplus: for some errors, do not fail the entire request
Nov 6 2018, 2:21 PM
avg committed rS340182: MFC r339591: ichwd: add support for TCO watchdog timer in Lewisburg PCH (C620).
MFC r339591: ichwd: add support for TCO watchdog timer in Lewisburg PCH (C620)
Nov 6 2018, 1:54 PM

Oct 31 2018

avg accepted D17768: Don't enter DDB for fatal traps before panic by default..
Oct 31 2018, 7:41 AM

Oct 29 2018

avg committed rS339858: MFC r337528: add an option for ddb ps command to print process arguments.
MFC r337528: add an option for ddb ps command to print process arguments
Oct 29 2018, 12:48 PM
avg committed rS339857: MFC r337528: add an option for ddb ps command to print process arguments.
MFC r337528: add an option for ddb ps command to print process arguments
Oct 29 2018, 12:47 PM
avg committed rS339856: MFC r303648: Fix ddb "show proc" to show full arguments.
MFC r303648: Fix ddb "show proc" to show full arguments
Oct 29 2018, 12:45 PM
avg committed rS339855: MFC r303648: Fix ddb "show proc" to show full arguments.
MFC r303648: Fix ddb "show proc" to show full arguments
Oct 29 2018, 12:42 PM

Oct 23 2018

avg committed rS339650: MFC r336634: MFV CK@r336629: Import CK as of commit….
MFC r336634: MFV CK@r336629: Import CK as of commit…
Oct 23 2018, 1:13 PM

Oct 22 2018

avg committed rS339597: MFC r334189: Import CK as of commit 0f017230ccc86929f56bf44ef2dca93d7df8076b.
MFC r334189: Import CK as of commit 0f017230ccc86929f56bf44ef2dca93d7df8076b
Oct 22 2018, 3:54 PM
avg committed rS339595: nfsrvd_readdirplus: for some errors, do not fail the entire request.
nfsrvd_readdirplus: for some errors, do not fail the entire request
Oct 22 2018, 3:33 PM
avg closed D15424: nfsrvd_readdirplus: for some errors, skip an entry instead of failing the request.
Oct 22 2018, 3:33 PM
avg committed rS339591: ichwd: add support for TCO watchdog timer in Lewisburg PCH (C620).
ichwd: add support for TCO watchdog timer in Lewisburg PCH (C620)
Oct 22 2018, 2:44 PM
avg closed D17585: ichwd: add support for TCO watchdog timer in Lewisburg PCH (C620).
Oct 22 2018, 2:44 PM

Oct 19 2018

avg added a comment to D17585: ichwd: add support for TCO watchdog timer in Lewisburg PCH (C620).
In D17585#375321, @mav wrote:

I have no particular objections, just quietly sighing that this area remains so tangled. I haven't investigated the area much recently, but it seems like WDAT-based attach could be cleaner, if it is a widespread standard and does not conflict too badly with existing drivers. Having watchdog drivers enabled in FreeNAS for years we had huge number of complains, caused by random platform specifics, and obtaining some valid configuration directly from platform in face of this table could be priceless.

Oct 19 2018, 5:08 PM

Oct 16 2018

avg updated the summary of D17585: ichwd: add support for TCO watchdog timer in Lewisburg PCH (C620).
Oct 16 2018, 2:40 PM
avg added a comment to D17585: ichwd: add support for TCO watchdog timer in Lewisburg PCH (C620).

Another note is that the test system has a BIOS option to enable the watchdog support. That option does not seem to affect the hardware configuration in any way, but when it is enabled the firmware generates WDAT (WatchDog Action Table) ACPI table. I see that Linux now has a driver for that table:
https://github.com/torvalds/linux/commits/master/drivers/watchdog/wdat_wdt.c

Oct 16 2018, 2:38 PM
avg created D17585: ichwd: add support for TCO watchdog timer in Lewisburg PCH (C620).
Oct 16 2018, 2:18 PM

Oct 10 2018

avg added inline comments to D17494: Add missing ZFS sysctls.
Oct 10 2018, 6:38 AM
avg added a comment to D17482: bhyve: emulate CLFLUSH and CLFLUSHOPT..

Looks good to me.

Oct 10 2018, 5:50 AM
avg added a reviewer for D17482: bhyve: emulate CLFLUSH and CLFLUSHOPT.: bhyve.
Oct 10 2018, 5:49 AM
avg accepted D17494: Add missing ZFS sysctls.

LGTM. The change is trivial enough.

Oct 10 2018, 5:30 AM
avg added a comment to D17460: Resolve a ZFS hang.

I am really happy that this simple change greatly reduces the chances of hitting the problem.
My understanding of it is in the bug report.

Oct 10 2018, 5:27 AM

Sep 19 2018

avg accepted D17208: Fix state of dquot-less vnodes after failed quotaoff..

ZFS part looks good to me.

Sep 19 2018, 12:48 PM

Sep 17 2018

avg accepted D17202: Fix the nvpair leak in vdev_geom_read_config()..

LGTM. Thank you!

Sep 17 2018, 3:55 PM

Aug 23 2018

avg added inline comments to D16720: Designware I2C: Fix IO Timeout issue with I2C controller in AMD platforms.
Aug 23 2018, 7:01 AM

Aug 17 2018

avg updated the diff for D15755: add support for marking interrupt handlers as suspended.
  • add a barrier function to ensure that the interrupt handling code sees that a handler is suspended after intr_event_suspend_handler() returns
Aug 17 2018, 2:57 PM

Aug 9 2018

avg committed rS337528: add an option for ddb ps command to print process arguments.
add an option for ddb ps command to print process arguments
Aug 9 2018, 11:21 AM
avg closed D16603: Print arguments in ddb ps command.
Aug 9 2018, 11:21 AM
avg accepted D16603: Print arguments in ddb ps command.
Aug 9 2018, 11:12 AM
avg added a comment to D16603: Print arguments in ddb ps command.

Terry, thank you!

Aug 9 2018, 10:21 AM
avg added a comment to D16603: Print arguments in ddb ps command.

I've just tested this and I see a couple of issues.

Aug 9 2018, 9:20 AM

Aug 6 2018

avg updated the diff for D15755: add support for marking interrupt handlers as suspended.

rebase

Aug 6 2018, 1:02 PM
avg added reviewers for D16603: Print arguments in ddb ps command: kib, jhb.
Aug 6 2018, 8:45 AM

Aug 3 2018

avg committed rS337255: safer wait-free iteration of shared interrupt handlers.
safer wait-free iteration of shared interrupt handlers
Aug 3 2018, 2:27 PM
avg closed D15905: safer wait-free iteration of shared interrupt handlers.
Aug 3 2018, 2:27 PM

Aug 2 2018

avg committed rS337123: fix a typo resulting in a wrong variable in kern_syscall_deregister.
fix a typo resulting in a wrong variable in kern_syscall_deregister
Aug 2 2018, 9:42 AM
avg committed rS337122: MFC r336641: fix incorrect operator in the AUDITPIPE_SET_QLIMIT bounds check.
MFC r336641: fix incorrect operator in the AUDITPIPE_SET_QLIMIT bounds check
Aug 2 2018, 9:32 AM
avg committed rS337121: MFC r335934: remove unneeded inclusion of sys/interrupt.h from several files.
MFC r335934: remove unneeded inclusion of sys/interrupt.h from several files
Aug 2 2018, 9:29 AM
avg committed rS337118: MFC r334786: x86: reorganize code that deals with unexpected NMI-s.
MFC r334786: x86: reorganize code that deals with unexpected NMI-s
Aug 2 2018, 9:00 AM
avg committed rS337117: MFC r334479: call AcpiLeaveSleepStatePrep after re-enabling interrupts.
MFC r334479: call AcpiLeaveSleepStatePrep after re-enabling interrupts
Aug 2 2018, 8:58 AM
avg added a comment to D15905: safer wait-free iteration of shared interrupt handlers.

I am considering all previous requests for changes as outdated and I am going to commit this.
Please state if you still have any objections.

Aug 2 2018, 5:36 AM

Aug 1 2018

avg accepted D16537: Remove jedec_ts(4)..
Aug 1 2018, 6:14 AM

Jul 31 2018

avg added a comment to D16459: bsnmpd(1): optimize interface description processing.

I'm going to commit latest revision soon unless an objection is raised.

Jul 31 2018, 7:15 AM

Jul 27 2018

avg added a comment to D15905: safer wait-free iteration of shared interrupt handlers.
In D15905#348331, @cem wrote:

It was this: https://reviews.freebsd.org/D15905#338982

Which has been completed. I don't know of a way in phabricator to un-request changes other than approving, which isn't quite the same thing.

Jul 27 2018, 5:52 AM
avg added a comment to D16459: bsnmpd(1): optimize interface description processing.

Well, the standard says (0 ..64) and that means from zero to 64.
Also, my impression is that, according to the RFC, ifAlias is something that should be settable over SNMP and it should be persistent.

Jul 27 2018, 5:31 AM
avg removed a reviewer for D16459: bsnmpd(1): optimize interface description processing: avg.
Jul 27 2018, 5:23 AM

Jul 26 2018

avg accepted D16459: bsnmpd(1): optimize interface description processing.
Jul 26 2018, 4:29 PM
avg added a comment to D16459: bsnmpd(1): optimize interface description processing.

Some comments inline, but in general looks good to me.
Thanks!

Jul 26 2018, 3:38 PM
avg updated the diff for D15905: safer wait-free iteration of shared interrupt handlers.

remove TESTING / KFAIL code

Jul 26 2018, 12:36 PM

Jul 24 2018

avg updated the diff for D15905: safer wait-free iteration of shared interrupt handlers.

Per suggestions from Samy Al Bahra:

Jul 24 2018, 12:04 PM
avg accepted D16412: Deprecate jedec_ts(4) and point users to jedec_dimm(4) instead..
Jul 24 2018, 7:10 AM

Jul 23 2018

avg added a comment to D15905: safer wait-free iteration of shared interrupt handlers.

@cem, you are shown as having requested a change but looking into the comment history I am not sure what that change might be.
Could you please clarify?

Jul 23 2018, 5:28 PM
avg added inline comments to D15905: safer wait-free iteration of shared interrupt handlers.
Jul 23 2018, 5:26 PM
avg committed rS336641: fix incorrect operator in the AUDITPIPE_SET_QLIMIT bounds check.
fix incorrect operator in the AUDITPIPE_SET_QLIMIT bounds check
Jul 23 2018, 4:56 PM
avg updated the diff for D15905: safer wait-free iteration of shared interrupt handlers.

rebase

Jul 23 2018, 4:28 PM
avg added inline comments to D15905: safer wait-free iteration of shared interrupt handlers.
Jul 23 2018, 4:02 PM
avg committed rS336639: follow-up to r336635, update TAILQ to CK_SLIST for ie_handlers.
follow-up to r336635, update TAILQ to CK_SLIST for ie_handlers
Jul 23 2018, 3:37 PM
avg committed rS336635: change interrupt event's list of handlers from TAILQ to CK_SLIST.
change interrupt event's list of handlers from TAILQ to CK_SLIST
Jul 23 2018, 12:51 PM
avg closed D16016: change interrupt event's list of handler from TAILQ to SLIST.
Jul 23 2018, 12:51 PM
avg committed rS336634: MFV CK@r336629: Import CK as of commit 1c1f9901c2dea7a883342cd03d3906a1bc482583.
MFV CK@r336629: Import CK as of commit 1c1f9901c2dea7a883342cd03d3906a1bc482583
Jul 23 2018, 11:21 AM
avg committed rS336630: Tag import of CK as of commit 1c1f9901c2dea7a883342cd03d3906a1bc482583.
Tag import of CK as of commit 1c1f9901c2dea7a883342cd03d3906a1bc482583
Jul 23 2018, 7:49 AM
avg committed rS336629: Import CK as of commit 1c1f9901c2dea7a883342cd03d3906a1bc482583.
Import CK as of commit 1c1f9901c2dea7a883342cd03d3906a1bc482583
Jul 23 2018, 7:31 AM

Jul 16 2018

avg added inline comments to D16016: change interrupt event's list of handler from TAILQ to SLIST.
Jul 16 2018, 7:50 AM

Jul 15 2018

avg added inline comments to D15905: safer wait-free iteration of shared interrupt handlers.
Jul 15 2018, 4:02 PM

Jul 10 2018

avg added inline comments to D16016: change interrupt event's list of handler from TAILQ to SLIST.
Jul 10 2018, 3:08 PM

Jul 4 2018

avg updated the diff for D16016: change interrupt event's list of handler from TAILQ to SLIST.

Use CK_SLIST instead of SLIST to avoid a need for hand-rolled list
operations with fences.
This change adds CK_SLIST_{INSERT,REMOVE}_PREVPTR.

Jul 4 2018, 11:12 AM
avg accepted D16120: ig(4): add support for Apollo Lake I2C controllers.
Jul 4 2018, 10:58 AM
avg added a comment to D16120: ig(4): add support for Apollo Lake I2C controllers.

LGTM, thanks!
Maybe also add MODULE_PNP_INFO now that the IDs are in a table?

Jul 4 2018, 10:58 AM
avg committed rS335934: remove unneeded inclusion of sys/interrupt.h from several files.
remove unneeded inclusion of sys/interrupt.h from several files
Jul 4 2018, 9:07 AM

Jun 27 2018

avg updated the diff for D15905: safer wait-free iteration of shared interrupt handlers.

fix a mismerge

Jun 27 2018, 1:58 PM
avg added inline comments to D15905: safer wait-free iteration of shared interrupt handlers.
Jun 27 2018, 1:55 PM

Jun 26 2018

avg added inline comments to D15905: safer wait-free iteration of shared interrupt handlers.
Jun 26 2018, 8:14 PM
avg added inline comments to D16016: change interrupt event's list of handler from TAILQ to SLIST.
Jun 26 2018, 7:41 PM
avg added inline comments to D16016: change interrupt event's list of handler from TAILQ to SLIST.
Jun 26 2018, 4:00 PM