- User Since
- Jun 4 2014, 6:42 AM (197 w, 6 d)
Fri, Mar 16
use SYSCTL_BOOL for a boolean knob (suggested by @cem)
document autoro in mount.8
Thu, Mar 15
- do not allow automatic r/o fallback by default.
- add a new mount option, autoro, to request the fallback.
- provide a new sysctl, vfs.default_autoro, to enable the automatic fallback by default; the fallback is attempted only if none of ro, rw, noro, norw, rdonly is specified.
just rebase on a newer header
Wed, Mar 14
Mon, Mar 12
Wed, Mar 7
Mon, Mar 5
Alan, by the way, do you plan to open an upstream issue and a PR to upstream this change?
Sun, Mar 4
Improvements suggested by Mark.
Drop in favor of D14533.
Sat, Mar 3
Fri, Mar 2
I see. I think that Alan would be the best person.
But if Alan is busy with something else then I can make the change.
I think that solution is good for now. I have only a tiny bit of a doubt about setting errno to zero when returning an error indication (-1).
Maybe we should rather set it to ENOENT to mean that the label is not found.
I think that all C library functions that return a generic failure code like -1 (as opposed to a specific error code) set errno to non-zero.
I think that any errno value other than ENOMEM should work.
Surprised that Alan has never been added as he is the author of the zpool_read_label change in question.
Thu, Mar 1
Wed, Feb 28
Tue, Feb 27
Generally looks good, but I have many code style comments and a couple of functional comments.
Gonna do another round after the issues are addressed.
Meanwhile other people start reporting similar or same problems:
I want to replace this proposal with D14533.
Thu, Feb 22
Wed, Feb 21
Mon, Feb 19
Feb 16 2018
Tested on a system with DDR3 memory, looks good!
A code review is on my to do list.
Feb 15 2018
Feb 14 2018
LGTM. Thank you!