Page MenuHomeFreeBSD

avg (Andriy Gapon)
User

Projects

User Details

User Since
Jun 4 2014, 6:42 AM (279 w, 4 d)

Recent Activity

Fri, Oct 11

avg added a comment to D21978: vmm: remove a wmb() call.

I think that the formal correctness is achieved by rendezvous_mtx.
That wmb() was for the benefit of code like:

if (rendezvous_func != NULL) {
  ...
  mtx_lock(rendezvous_mtx);
  // do real things with rendezvous_func
  mtx_unlock(rendezvous_mtx);
}

That is, rendezvous_func is assigned and used always under rendezvous_mtx.
Access outside of the lock are only to check it for being set.

Fri, Oct 11, 5:56 PM
avg committed rS353442: fix up r353340, don't assume that fcmpset has strong semantics.
fix up r353340, don't assume that fcmpset has strong semantics
Fri, Oct 11, 5:01 PM
avg committed rS353434: man4/Makefile: fix sorting for a number of entries starting with 'v'.
man4/Makefile: fix sorting for a number of entries starting with 'v'
Fri, Oct 11, 12:04 PM
avg created D21980: move nctgpio to superio(4) bus.
Fri, Oct 11, 11:36 AM
avg committed rS353433: fix a typo in superio.4.
fix a typo in superio.4
Fri, Oct 11, 11:31 AM
avg updated the diff for D21979: wbwd: move to superio(4) bus.

oops, typo

Fri, Oct 11, 11:22 AM
avg created D21979: wbwd: move to superio(4) bus.
Fri, Oct 11, 11:21 AM
avg closed D21958: add manual pages for the superio driver and interface.
Fri, Oct 11, 11:13 AM
avg committed rS353432: add superio.4 and superio.9 manual pages.
add superio.4 and superio.9 manual pages
Fri, Oct 11, 11:13 AM
avg created D21978: vmm: remove a wmb() call.
Fri, Oct 11, 8:28 AM
avg added a comment to D21958: add manual pages for the superio driver and interface.

@yuripv , I noted that you ended your suggestions with question marks...
I am not a native speaker, so I am not sure if definite or indefinite article is more appropriate in those sentences.

Fri, Oct 11, 5:50 AM

Thu, Oct 10

avg updated the diff for D21958: add manual pages for the superio driver and interface.

man4 makefile too

Thu, Oct 10, 8:40 AM
avg updated the diff for D21958: add manual pages for the superio driver and interface.

add makefile changes

Thu, Oct 10, 8:39 AM
avg added a comment to D21958: add manual pages for the superio driver and interface.

Hmm, I see that superio.9 could become a first conditionally installed manual page in man9.
Is that okay?
Or would it be better to merge superio.9 into superio.4?
I see a couple of examples in man4, e.g., cpufreq.4.

Thu, Oct 10, 8:21 AM
avg added a comment to D21958: add manual pages for the superio driver and interface.

Thank you very much for the review!
Problems should be fixed now.

Thu, Oct 10, 8:07 AM
avg updated the diff for D21958: add manual pages for the superio driver and interface.

cleanups based on the review

Thu, Oct 10, 8:07 AM
avg committed rS353382: remove unrelated files accidentally committed in r353381.
remove unrelated files accidentally committed in r353381
Thu, Oct 10, 7:41 AM
avg committed rS353381: emulate illumos membar_producer with atomic_thread_fence_rel.
emulate illumos membar_producer with atomic_thread_fence_rel
Thu, Oct 10, 7:39 AM

Wed, Oct 9

avg created D21958: add manual pages for the superio driver and interface.
Wed, Oct 9, 3:36 PM
avg committed rS353343: zfs: remove gratuitous divergence from other openzfs flavours.
zfs: remove gratuitous divergence from other openzfs flavours
Wed, Oct 9, 11:58 AM
avg committed rS353342: zfs: remove incorrect warning about boot support for large_dnode.
zfs: remove incorrect warning about boot support for large_dnode
Wed, Oct 9, 11:46 AM
avg committed rS353341: zfs: document large_dnode feature.
zfs: document large_dnode feature
Wed, Oct 9, 11:34 AM
avg committed rS353340: cleanup of illumos compatibility atomics.
cleanup of illumos compatibility atomics
Wed, Oct 9, 11:26 AM
avg committed rS353339: MFC r352591: MFZoL: Retire send space estimation via ZFS_IOC_SEND.
MFC r352591: MFZoL: Retire send space estimation via ZFS_IOC_SEND
Wed, Oct 9, 9:50 AM
avg committed rS353338: MFC r352580 by sef: Fix a regression introduced in r344601.
MFC r352580 by sef: Fix a regression introduced in r344601
Wed, Oct 9, 9:47 AM
avg committed rS353337: MFC r352591: MFZoL: Retire send space estimation via ZFS_IOC_SEND.
MFC r352591: MFZoL: Retire send space estimation via ZFS_IOC_SEND
Wed, Oct 9, 9:40 AM

Tue, Oct 8

avg added a comment to D21886: Add USB support for location based device unit numbers.

My use case for something like this is a USB-serial console server where I might have 16 different USB-serial adapters attached to various USB hubs; I intended to address it by using the serial number in each device.

Tue, Oct 8, 3:16 PM
avg committed rS353304: zfs: use atomic_load_64 to read atomic variable in dmu_object_alloc_impl.
zfs: use atomic_load_64 to read atomic variable in dmu_object_alloc_impl
Tue, Oct 8, 11:28 AM
avg committed rS353301: i386: hide more of atomic 64-bit definitions under _KERNEL.
i386: hide more of atomic 64-bit definitions under _KERNEL
Tue, Oct 8, 10:50 AM

Mon, Oct 7

avg committed rS353270: fix up r353168, add atomic_swap_64 to i386 version of opensolaris_atomic.S.
fix up r353168, add atomic_swap_64 to i386 version of opensolaris_atomic.S
Mon, Oct 7, 12:53 PM
avg committed rS353176: MFV r350898, r351075: 8423 8199 7432 Implement large_dnode pool feature.
MFV r350898, r351075: 8423 8199 7432 Implement large_dnode pool feature
Mon, Oct 7, 8:14 AM
avg committed rS353168: ZFS: unconditionally use atomic_swap_64.
ZFS: unconditionally use atomic_swap_64
Mon, Oct 7, 8:01 AM
avg committed rS353167: ZFS: add emulation of atomic_swap_64 and atomic_load_64.
ZFS: add emulation of atomic_swap_64 and atomic_load_64
Mon, Oct 7, 7:54 AM
avg committed rS353166: add atomic_load_64 for mipsn32.
add atomic_load_64 for mipsn32
Mon, Oct 7, 7:42 AM
avg committed rS353165: align use of cp15_pmccntr_get with its availability.
align use of cp15_pmccntr_get with its availability
Mon, Oct 7, 7:38 AM

Fri, Oct 4

avg added a comment to D21886: Add USB support for location based device unit numbers.

I see.
I think that the problem can be solved quite easily with devd, but maybe it's not good for embedded solutions.
Also, I am not sure how stable the unit numbers are going to be with respect to add-in USB controllers and external USB hubs.

Fri, Oct 4, 9:24 PM
avg added a comment to D21886: Add USB support for location based device unit numbers.

Why is this needed at all? What's the motivation?

Fri, Oct 4, 1:23 PM

Thu, Oct 3

avg committed rS353039: add ability to set watchdog timeout for a shutdown.
add ability to set watchdog timeout for a shutdown
Thu, Oct 3, 11:23 AM
avg closed D21221: add ability to set watchdog timeout for a shutdown.
Thu, Oct 3, 11:23 AM
avg closed D21795: ZFS: add bookmark renaming.
Thu, Oct 3, 11:09 AM
avg committed rS353037: ZFS: add bookmark renaming.
ZFS: add bookmark renaming
Thu, Oct 3, 11:09 AM

Wed, Oct 2

avg committed rS353005: MFS12 r352896: vt: fix problems with trying to switch to a closed VT.
MFS12 r352896: vt: fix problems with trying to switch to a closed VT
Wed, Oct 2, 1:37 PM
avg committed rS353003: MFS12 r352721: print summary line for space estimate of zfs send from bookmark.
MFS12 r352721: print summary line for space estimate of zfs send from bookmark
Wed, Oct 2, 1:25 PM

Mon, Sep 30

avg committed rS352905: Merge from stable/12 r352723: fix dsl_scan_ds_clone_swapped logic.
Merge from stable/12 r352723: fix dsl_scan_ds_clone_swapped logic
Mon, Sep 30, 3:09 PM
avg updated the diff for D9720: zfs: enable SPA_PROCESS on the kernel side.

rebase

Mon, Sep 30, 2:45 PM
avg committed rS352901: Merge from stable/12 r352595: Add -vnP support to 'zfs send' for bookmarks.
Merge from stable/12 r352595: Add -vnP support to 'zfs send' for bookmarks
Mon, Sep 30, 2:19 PM
avg updated the diff for D21795: ZFS: add bookmark renaming.
  • drop redundant name checks
  • move name checks to the check function
Mon, Sep 30, 2:16 PM
avg added inline comments to D21795: ZFS: add bookmark renaming.
Mon, Sep 30, 2:08 PM
avg committed rS352897: MFC r352505: vt: fix problems with trying to switch to a closed VT.
MFC r352505: vt: fix problems with trying to switch to a closed VT
Mon, Sep 30, 1:34 PM
avg committed rS352896: MFC r352505: vt: fix problems with trying to switch to a closed VT.
MFC r352505: vt: fix problems with trying to switch to a closed VT
Mon, Sep 30, 1:33 PM
avg added a comment to D21705: if_ixv: disable RSS configuration on 82599 and X540 VFs.

Any feedback at all?

Mon, Sep 30, 1:21 PM

Wed, Sep 25

avg created D21795: ZFS: add bookmark renaming.
Wed, Sep 25, 8:24 PM
avg committed rS352724: MFC r352506: fix dsl_scan_ds_clone_swapped logic.
MFC r352506: fix dsl_scan_ds_clone_swapped logic
Wed, Sep 25, 8:02 PM
avg committed rS352723: MFC r352506: fix dsl_scan_ds_clone_swapped logic.
MFC r352506: fix dsl_scan_ds_clone_swapped logic
Wed, Sep 25, 8:01 PM
avg committed rS352722: MFC r352590: print summary line for space estimate of zfs send from bookmark.
MFC r352590: print summary line for space estimate of zfs send from bookmark
Wed, Sep 25, 7:56 PM
avg committed rS352721: MFC r352590: print summary line for space estimate of zfs send from bookmark.
MFC r352590: print summary line for space estimate of zfs send from bookmark
Wed, Sep 25, 7:56 PM
avg committed rS352719: MFC r351810: shutdown_halt: make sure that watchdog timer is stopped.
MFC r351810: shutdown_halt: make sure that watchdog timer is stopped
Wed, Sep 25, 7:52 PM
avg committed rS352718: MFC r351810: shutdown_halt: make sure that watchdog timer is stopped.
MFC r351810: shutdown_halt: make sure that watchdog timer is stopped
Wed, Sep 25, 7:51 PM
avg committed rS352717: MFC r351601: scsi_cd: whitespace cleanup.
MFC r351601: scsi_cd: whitespace cleanup
Wed, Sep 25, 7:50 PM
avg committed rS352716: MFC r351601: scsi_cd: whitespace cleanup.
MFC r351601: scsi_cd: whitespace cleanup
Wed, Sep 25, 7:48 PM
avg committed rS352715: MFC r351599,r351600: scsi_cd: make the media check asynchronous.
MFC r351599,r351600: scsi_cd: make the media check asynchronous
Wed, Sep 25, 7:46 PM
avg committed rS352714: MFC r351599,r351600: scsi_cd: make the media check asynchronous.
MFC r351599,r351600: scsi_cd: make the media check asynchronous
Wed, Sep 25, 7:46 PM

Sun, Sep 22

avg committed rS352598: MFC r352447,r352449,r352507: MFZoL: Add -vnP support to 'zfs send' for bookmarks.
MFC r352447,r352449,r352507: MFZoL: Add -vnP support to 'zfs send' for bookmarks
Sun, Sep 22, 3:00 PM
avg committed rS352595: MFC r352447,r352449,r352507: MFZoL: Add -vnP support to 'zfs send' for bookmarks.
MFC r352447,r352449,r352507: MFZoL: Add -vnP support to 'zfs send' for bookmarks
Sun, Sep 22, 11:40 AM
avg committed rS352591: MFZoL: Retire send space estimation via ZFS_IOC_SEND.
MFZoL: Retire send space estimation via ZFS_IOC_SEND
Sun, Sep 22, 8:45 AM
avg committed rS352590: print summary line for space estimate of zfs send from bookmark.
print summary line for space estimate of zfs send from bookmark
Sun, Sep 22, 8:34 AM

Thu, Sep 19

avg accepted D21709: Fix zfs send -v, -P, -n, and -V again.

The change itself looks good to me.
Thank you!

Thu, Sep 19, 1:17 PM
avg committed rS352507: update zfs send usage help with r352447.
update zfs send usage help with r352447
Thu, Sep 19, 9:48 AM
avg committed rS352506: fix dsl_scan_ds_clone_swapped logic.
fix dsl_scan_ds_clone_swapped logic
Thu, Sep 19, 9:44 AM
avg committed rS352505: vt: fix problems with trying to switch to a closed VT.
vt: fix problems with trying to switch to a closed VT
Thu, Sep 19, 9:22 AM
avg closed D21704: vt: fix problems with trying to switch to a closed VT.
Thu, Sep 19, 9:22 AM
avg added a comment to D21709: Fix zfs send -v, -P, -n, and -V again.

A general comment: I hope the current review summary will not be a commit message :)

Thu, Sep 19, 5:15 AM

Wed, Sep 18

avg abandoned D18420: add a method to defer destruction of if_softc to if_destroy.
Wed, Sep 18, 12:50 PM
avg updated the summary of D21705: if_ixv: disable RSS configuration on 82599 and X540 VFs.
Wed, Sep 18, 12:45 PM
avg added inline comments to D21705: if_ixv: disable RSS configuration on 82599 and X540 VFs.
Wed, Sep 18, 12:43 PM
avg added inline comments to D21705: if_ixv: disable RSS configuration on 82599 and X540 VFs.
Wed, Sep 18, 12:39 PM
avg created D21705: if_ixv: disable RSS configuration on 82599 and X540 VFs.
Wed, Sep 18, 12:36 PM
avg created D21704: vt: fix problems with trying to switch to a closed VT.
Wed, Sep 18, 12:19 PM

Tue, Sep 17

avg committed rS352449: fixup up fallout from r352447 in libbe.
fixup up fallout from r352447 in libbe
Tue, Sep 17, 2:16 PM
avg committed rS352447: MFZoL: Add -vnP support to 'zfs send' for bookmarks.
MFZoL: Add -vnP support to 'zfs send' for bookmarks
Tue, Sep 17, 1:58 PM

Mon, Sep 16

avg committed rS352376: MFC r351803: ZFS: Always refuse receving non-resume stream when resume state….
MFC r351803: ZFS: Always refuse receving non-resume stream when resume state…
Mon, Sep 16, 5:29 AM
avg committed rS352375: MFC r351803: ZFS: Always refuse receving non-resume stream when resume state….
MFC r351803: ZFS: Always refuse receving non-resume stream when resume state…
Mon, Sep 16, 5:25 AM

Sat, Sep 14

avg added a comment to D21660: Ask sync(8) to sync multiple times.
In D21660#472250, @sef wrote:

That's why you can request different numbers. If you want.

Sat, Sep 14, 8:48 PM
avg added a comment to D21660: Ask sync(8) to sync multiple times.

So, maybe you'd better debug and fix that problem.
Or add a sleep instead of additional sync-s. And how do you know that 3 will always be enough?
Or maybe the problem was with concurrent writes somewhere else and in some cases even a million sync-s would not be enough...

Sat, Sep 14, 8:42 PM
avg added a comment to D21660: Ask sync(8) to sync multiple times.
In D21660#472237, @sef wrote:

Because I was making changes that happened in zfs on sync 8-). I was using multiple syncs to ensure everything did get synced out, and then examining status and structures. (And depending on timing, not everything did get synced out on the first one.)

Sat, Sep 14, 8:36 PM
avg added a comment to D21660: Ask sync(8) to sync multiple times.

I think that a need for sync ; sync ; sync is greatly exaggerated.
If you think that it's useful and sync 3 would be an improvement, then could you please explain why?
And without referring to "old wives' tales" :-)

Sat, Sep 14, 8:25 PM

Sep 6 2019

avg committed rS351933: MFC r351593: zfs_ioc_snapshot: check user-prop permissions on snapshotted….
MFC r351593: zfs_ioc_snapshot: check user-prop permissions on snapshotted…
Sep 6 2019, 12:30 PM
avg committed rS351932: MFC r351593: zfs_ioc_snapshot: check user-prop permissions on snapshotted….
MFC r351593: zfs_ioc_snapshot: check user-prop permissions on snapshotted…
Sep 6 2019, 12:28 PM
avg accepted D21529: Adding WMI embedded Binary MOF object interface driver..

Looks good to me.

Sep 6 2019, 9:56 AM
avg added a comment to D21529: Adding WMI embedded Binary MOF object interface driver..

A couple more nits.

Sep 6 2019, 8:08 AM
avg added inline comments to D21529: Adding WMI embedded Binary MOF object interface driver..
Sep 6 2019, 5:38 AM

Sep 5 2019

avg added a comment to D21529: Adding WMI embedded Binary MOF object interface driver..

If this driver just provides a single sysctl, then I think that it would be simpler to add that sysctl to acpi_wmi.
Do you plan to have any other functionality in acpi_wmi_bmof?

Sep 5 2019, 6:25 AM

Sep 4 2019

avg committed rS351812: mpsutil slot set status.
mpsutil slot set status
Sep 4 2019, 1:48 PM
avg closed D20535: mpsutil slot set status.
Sep 4 2019, 1:48 PM
avg committed rS351810: shutdown_halt: make sure that watchdog timer is stopped.
shutdown_halt: make sure that watchdog timer is stopped
Sep 4 2019, 1:27 PM
avg closed D21222: shutdown_halt: make sure that watchdog timer is stopped.
Sep 4 2019, 1:27 PM
avg committed rS351809: MFC r351213: assert that td_lk_slocks is not leaked upon return from kernel.
MFC r351213: assert that td_lk_slocks is not leaked upon return from kernel
Sep 4 2019, 9:54 AM
avg committed rS351808: MFC r351213: assert that td_lk_slocks is not leaked upon return from kernel.
MFC r351213: assert that td_lk_slocks is not leaked upon return from kernel
Sep 4 2019, 9:54 AM
avg committed rS351807: MFC r351168: zfs_vget: fix vnode reference count leak in error path.
MFC r351168: zfs_vget: fix vnode reference count leak in error path
Sep 4 2019, 8:48 AM
avg committed rS351806: MFC r351168: zfs_vget: fix vnode reference count leak in error path.
MFC r351168: zfs_vget: fix vnode reference count leak in error path
Sep 4 2019, 8:47 AM