Page MenuHomeFreeBSD

avg (Andriy Gapon)
User

Projects

User Details

User Since
Jun 4 2014, 6:42 AM (414 w, 4 d)

Recent Activity

Feb 17 2022

avg committed R10:4328d67d2542: mmc_da: create disk(9) for pre-2.0 SD cards (authored by avg).
mmc_da: create disk(9) for pre-2.0 SD cards
Feb 17 2022, 6:58 AM
avg committed R10:6b3071c70e64: mmc_da: create disk(9) for pre-2.0 SD cards (authored by avg).
mmc_da: create disk(9) for pre-2.0 SD cards
Feb 17 2022, 6:58 AM
avg committed R10:77eb3a831ec0: g_mirror: don't fail reads while losing next-to-last disk (authored by avg).
g_mirror: don't fail reads while losing next-to-last disk
Feb 17 2022, 6:56 AM
avg committed R10:cb702452adeb: g_mirror: don't fail reads while losing next-to-last disk (authored by avg).
g_mirror: don't fail reads while losing next-to-last disk
Feb 17 2022, 6:49 AM

Feb 16 2022

avg committed R10:af8b51b0bac9: aw_mmc: add crash dumping support in MMCCAM mode (authored by avg).
aw_mmc: add crash dumping support in MMCCAM mode
Feb 16 2022, 7:59 AM
avg committed R10:1a93b2288cb1: liberate wdog_kern_pat call from SW_WATCHDOG in arm minimdump code (authored by avg).
liberate wdog_kern_pat call from SW_WATCHDOG in arm minimdump code
Feb 16 2022, 7:58 AM
avg committed R10:e32acf95ea25: cam_get_device: resolve path links before parsing device name (authored by avg).
cam_get_device: resolve path links before parsing device name
Feb 16 2022, 7:54 AM

Feb 9 2022

avg committed R10:c238600e3789: add overlay for enabling i2c1 on allwinner h3 (authored by avg).
add overlay for enabling i2c1 on allwinner h3
Feb 9 2022, 9:41 AM
avg committed R10:aa460944533a: add overlay for enabling spi0 on allwinner h3 (authored by avg).
add overlay for enabling spi0 on allwinner h3
Feb 9 2022, 9:41 AM
avg committed R10:0237541d1520: add overlay for enabling i2c1 on allwinner h3 (authored by avg).
add overlay for enabling i2c1 on allwinner h3
Feb 9 2022, 9:37 AM
avg committed R10:ea331a2ef468: add overlay for enabling serial1 / uart1 on rk3328 (authored by avg).
add overlay for enabling serial1 / uart1 on rk3328
Feb 9 2022, 9:36 AM
avg committed R10:b8db946c3b44: add overlay for enabling spi0 on allwinner h3 (authored by avg).
add overlay for enabling spi0 on allwinner h3
Feb 9 2022, 9:36 AM
avg committed R10:b4a16940b909: add overlay for enabling i2c0 on rk3328 (authored by avg).
add overlay for enabling i2c0 on rk3328
Feb 9 2022, 9:36 AM

Feb 8 2022

avg committed R10:36dbd166887d: dt_unring_buf: set dtbd_oldest to the start of the first record (authored by avg).
dt_unring_buf: set dtbd_oldest to the start of the first record
Feb 8 2022, 4:17 PM
avg committed R10:b76c31036687: schedgraph.py: port to Python 3 (authored by avg).
schedgraph.py: port to Python 3
Feb 8 2022, 4:17 PM
avg committed R10:cbc3c3f0d79f: dt_unring_buf: set dtbd_oldest to the start of the first record (authored by avg).
dt_unring_buf: set dtbd_oldest to the start of the first record
Feb 8 2022, 4:16 PM
avg committed R10:eee25e8417cf: schedgraph.py: port to Python 3 (authored by avg).
schedgraph.py: port to Python 3
Feb 8 2022, 4:16 PM

Feb 4 2022

avg resigned from D34171: Restore access to "user.*" variables in sysctlbyname().
Feb 4 2022, 10:23 PM

Feb 2 2022

avg committed R10:8934d3e7b9b9: sdhci: fix dumping support in MMCCAM configuration (authored by avg).
sdhci: fix dumping support in MMCCAM configuration
Feb 2 2022, 6:52 AM

Feb 1 2022

avg added a comment to D34117: hdac: Handle interrupts racing with device suspend.

@imp , I am not sure if we are disagreeing about anything.
I just explained why the current code the way it is (for shared interrupts).
And stated that the non-shared interrupts case is different.

Feb 1 2022, 4:05 PM
avg added a comment to D34117: hdac: Handle interrupts racing with device suspend.
In D34117#771775, @imp wrote:

But it does not make sense for exclusive interrupts: how the hardware can generate an interrupt if it's not sufficiently resumed yet?

You assume a binary condition in the resume function. Maybe the hardware needs interrupts to properly resume the device after restoring a few registers?

Feb 1 2022, 2:27 PM
avg committed R10:08bc6b60c354: dwwdt: make it actually useful (authored by avg).
dwwdt: make it actually useful
Feb 1 2022, 8:13 AM
avg committed R10:eacdf85d4410: dtrace: add a knob to control maximum size of principal buffers (authored by avg).
dtrace: add a knob to control maximum size of principal buffers
Feb 1 2022, 8:13 AM
avg added a comment to D34117: hdac: Handle interrupts racing with device suspend.

So this fails for at least nvme: pci_resume_child() un-suspends interrupts after resuming devices, but nvme_pci_resume() depends on having working admin interrupts, in nvme_ctrlr_identify(). It's not obvious to me exactly why we need to resume the driver before enabling interrupts. Reording fixes the problem on my laptop at least.

Feb 1 2022, 6:45 AM

Jan 31 2022

avg added a comment to D34117: hdac: Handle interrupts racing with device suspend.

I still tend to think it's better to avoid the unlocked intsts read in hdac_intr_handler().

Jan 31 2022, 9:47 PM
avg added a comment to D34117: hdac: Handle interrupts racing with device suspend.

Yes, rid 0 is for legacy PCI interrupts and rids >= 1 are for MSI / MSI-X.
So, indeed, a proper barrier would require iterating over all active interrupt resources.

Jan 31 2022, 9:32 PM
avg added a comment to D34117: hdac: Handle interrupts racing with device suspend.

@markj , hmm, maybe 82a5a2752724 should be extended to non-shared interrupts to prevent races between an interrupt handler and a suspend method?

Jan 31 2022, 9:19 PM

Jan 30 2022

avg added inline comments to D34094: Update superiotool to latest version.
Jan 30 2022, 10:03 AM
avg added inline comments to D34094: Update superiotool to latest version.
Jan 30 2022, 9:49 AM

Jan 27 2022

avg committed R10:6fd84a627fa0: mmc_da: create disk(9) for pre-2.0 SD cards (authored by avg).
mmc_da: create disk(9) for pre-2.0 SD cards
Jan 27 2022, 5:03 PM
avg committed R10:5d5f44623eb3: g_mirror: don't fail reads while losing next-to-last disk (authored by avg).
g_mirror: don't fail reads while losing next-to-last disk
Jan 27 2022, 11:27 AM

Jan 26 2022

avg added a comment to D33707: iic: return errnos to userspace instead of IIC_ error numbers.

I am a bit torn on this.
On the one hand, I like the simplicity that comes from returning errno codes to userland.
On the other hand, recently I had to write a program that had to use "low level" ioctl-s like I2CSTART and I needed to be able to distinguish IIC_ENOACK from other bus conditions.
In any case, the current state of matters where a return value can be either an errno code or an IIC code is clearly a mess.

Jan 26 2022, 2:15 PM
avg committed R10:f4a041af299c: add overlay for enabling spi0 on allwinner h3 (authored by avg).
add overlay for enabling spi0 on allwinner h3
Jan 26 2022, 9:43 AM
avg committed R10:a471646a0802: add overlay for enabling i2c1 on allwinner h3 (authored by avg).
add overlay for enabling i2c1 on allwinner h3
Jan 26 2022, 9:43 AM
avg committed R10:173d0fb61672: add overlay for enabling serial1 / uart1 on rk3328 (authored by avg).
add overlay for enabling serial1 / uart1 on rk3328
Jan 26 2022, 9:34 AM
avg committed R10:f41f98f0f07c: add overlay for enabling i2c0 on rk3328 (authored by avg).
add overlay for enabling i2c0 on rk3328
Jan 26 2022, 9:34 AM
avg committed R10:1abf1e8c6b13: cam_get_device: resolve path links before parsing device name (authored by avg).
cam_get_device: resolve path links before parsing device name
Jan 26 2022, 9:27 AM
avg committed R10:46f4697fb76e: mmc_da: use MMC_SECTOR_SIZE constant in place of literals (authored by avg).
mmc_da: use MMC_SECTOR_SIZE constant in place of literals
Jan 26 2022, 7:35 AM
avg committed R10:94ff1d9cc8ff: sdhci: fix dumping support in MMCCAM configuration (authored by avg).
sdhci: fix dumping support in MMCCAM configuration
Jan 26 2022, 7:33 AM
avg committed R10:098780e8fe98: mmc_da: use MMC_SECTOR_SIZE constant in place of literals (authored by avg).
mmc_da: use MMC_SECTOR_SIZE constant in place of literals
Jan 26 2022, 7:31 AM
avg committed R10:79c3478e76c3: mmc_da: implement d_dump method, sddadump (authored by avg).
mmc_da: implement d_dump method, sddadump
Jan 26 2022, 7:29 AM

Jan 25 2022

avg committed R10:e0cc1ce7c086: smp_targeted_tlb_shootdown has to pin the CPU on i386 (authored by avg).
smp_targeted_tlb_shootdown has to pin the CPU on i386
Jan 25 2022, 10:39 AM
avg closed D33980: smp_targeted_tlb_shootdown has to pin the CPU on i386.
Jan 25 2022, 10:39 AM
avg committed R10:9f8b984392f2: add and use defintions for ATA power modes (authored by avg).
add and use defintions for ATA power modes
Jan 25 2022, 7:49 AM
avg committed R10:82acfc0d7838: add and use defintions for ATA power modes (authored by avg).
add and use defintions for ATA power modes
Jan 25 2022, 7:48 AM

Jan 22 2022

avg added a comment to D33980: smp_targeted_tlb_shootdown has to pin the CPU on i386.
In D33980#768547, @kib wrote:

Did you consider putting sched_pin() at the caller' side, same as on amd64?
I do not insist, just curios: IMO i386 on 12 ought to get as little efforts as possible.

Jan 22 2022, 9:42 AM

Jan 21 2022

avg committed R10:e265658e4e36: rc: make ctld depend on NETWORKING (authored by trasz).
rc: make ctld depend on NETWORKING
Jan 21 2022, 7:48 AM
avg committed R10:c0163f4abef0: rc: make ctld depend on NETWORKING (authored by trasz).
rc: make ctld depend on NETWORKING
Jan 21 2022, 7:46 AM
avg requested review of D33980: smp_targeted_tlb_shootdown has to pin the CPU on i386.
Jan 21 2022, 7:36 AM
avg committed R10:c902b6082a84: adaspindown: check disk power mode before sending IDLE command (authored by avg).
adaspindown: check disk power mode before sending IDLE command
Jan 21 2022, 7:02 AM
avg committed R10:89ac48cf3ba1: adaspindown: check disk power mode before sending IDLE command (authored by avg).
adaspindown: check disk power mode before sending IDLE command
Jan 21 2022, 7:02 AM

Jan 19 2022

avg committed R10:9fe892e8fab2: mmc_da: remove write-only local variables (authored by avg).
mmc_da: remove write-only local variables
Jan 19 2022, 7:05 AM
avg committed R10:08956b8362af: mmc_da: remove write-only local variables (authored by avg).
mmc_da: remove write-only local variables
Jan 19 2022, 7:02 AM

Jan 12 2022

avg committed R10:dfb1c97ab973: mmc_da: remove write-only local variables (authored by avg).
mmc_da: remove write-only local variables
Jan 12 2022, 7:19 AM
avg committed R10:60b7d5a24a8f: mmc_da: use MMC_SECTOR_SIZE constant in place of literals (authored by avg).
mmc_da: use MMC_SECTOR_SIZE constant in place of literals
Jan 12 2022, 7:16 AM
avg closed D33843: mmc_da: implement d_dump method, sddadump.
Jan 12 2022, 7:04 AM
avg committed R10:44682688f038: mmc_da: implement d_dump method, sddadump (authored by avg).
mmc_da: implement d_dump method, sddadump
Jan 12 2022, 7:04 AM

Jan 11 2022

avg added inline comments to D33843: mmc_da: implement d_dump method, sddadump.
Jan 11 2022, 8:30 PM
avg updated the diff for D33843: mmc_da: implement d_dump method, sddadump.

address comments from mav

Jan 11 2022, 7:04 PM
avg added inline comments to D33843: mmc_da: implement d_dump method, sddadump.
Jan 11 2022, 3:43 PM
avg added inline comments to D33843: mmc_da: implement d_dump method, sddadump.
Jan 11 2022, 3:40 PM
avg added inline comments to D33843: mmc_da: implement d_dump method, sddadump.
Jan 11 2022, 3:12 PM
avg committed R10:94f4afd7720b: rk805 / rk808: re-add system poweroff support (authored by avg).
rk805 / rk808: re-add system poweroff support
Jan 11 2022, 2:26 PM
avg closed D33844: rk805: re-add system poweroff support.
Jan 11 2022, 2:25 PM
avg added a comment to D33844: rk805: re-add system poweroff support.

@manu , not sure if this is the approach that you had in mind.
But I think it's better to discuss based on some concrete code rather than abstractly.
Thank you.

Jan 11 2022, 2:09 PM
avg requested review of D33844: rk805: re-add system poweroff support.
Jan 11 2022, 2:08 PM
avg updated the test plan for D33843: mmc_da: implement d_dump method, sddadump.
Jan 11 2022, 2:06 PM
avg requested review of D33843: mmc_da: implement d_dump method, sddadump.
Jan 11 2022, 2:02 PM
avg committed R10:ee900888c42f: dwwdt: make it actually useful (authored by avg).
dwwdt: make it actually useful
Jan 11 2022, 1:57 PM
avg closed D33534: dwwdt: make it actually useful.
Jan 11 2022, 1:57 PM
avg committed R10:7fdf0e883567: dtrace: add a knob to control maximum size of principal buffers (authored by avg).
dtrace: add a knob to control maximum size of principal buffers
Jan 11 2022, 1:52 PM
avg committed R10:256c8c5df2a4: dt_unring_buf: set dtbd_oldest to the start of the first record (authored by avg).
dt_unring_buf: set dtbd_oldest to the start of the first record
Jan 11 2022, 1:52 PM
avg closed D33648: dtrace: add a knob to control maximum size of principal buffers.
Jan 11 2022, 1:52 PM
avg closed D33649: dt_unring_buf: set dtbd_oldest to the start of the first record.
Jan 11 2022, 1:52 PM
avg committed R10:75bc7150f4b8: add and use defintions for ATA power modes (authored by avg).
add and use defintions for ATA power modes
Jan 11 2022, 1:43 PM
avg closed D33646: add and use defintions for ATA power modes.
Jan 11 2022, 1:42 PM
avg committed R10:7e8ed296e120: schedgraph.py: port to Python 3 (authored by avg).
schedgraph.py: port to Python 3
Jan 11 2022, 1:37 PM
avg closed D33626: schedgraph.py: port to Python 3.
Jan 11 2022, 1:37 PM
avg added a comment to D33534: dwwdt: make it actually useful.

Ping.

Jan 11 2022, 1:28 PM
avg committed R10:ce99de0241ef: add exuberant ctags tags file to gitignore (authored by avg).
add exuberant ctags tags file to gitignore
Jan 11 2022, 1:27 PM
avg committed R10:884938e769f1: add exuberant ctags tags file to gitignore (authored by avg).
add exuberant ctags tags file to gitignore
Jan 11 2022, 1:26 PM
avg accepted D33817: crashinfo: Source a list of python scripts into kgdb.

LGTM!
At work we have an extension that allows to dump (and save) both a text dump and a vmcore at the same time.
We use that to easily capture from ddb things that are hard (but not impossible) to get with kgdb.
The path you open here is a great alternative to that.

Jan 11 2022, 7:33 AM

Jan 8 2022

avg accepted D33794: gitignore: ignore vim swap files & .rej/.orig.

LGTM. My only comment is that I am not sure if the file really has any sorting order, but there is some resemblance of it, so maybe it's worthwhile keeping it.

Jan 8 2022, 9:00 PM

Jan 3 2022

avg committed R10:1e7b0dc00076: aw_spi: improve I/O stability (authored by avg).
aw_spi: improve I/O stability
Jan 3 2022, 8:52 AM
avg committed R10:2de66371338b: aw_spi: improve I/O stability (authored by avg).
aw_spi: improve I/O stability
Jan 3 2022, 8:48 AM

Dec 29 2021

avg added a comment to D33648: dtrace: add a knob to control maximum size of principal buffers.

Does it test things like setting bufsize to a significant portion of total memory?
Might be worthwhile testing that directly.

Dec 29 2021, 3:38 PM
avg added a comment to D33648: dtrace: add a knob to control maximum size of principal buffers.

I have no objection to this change, but did you ever try to remove the check entirely? I wonder if some of the patches imported from illumos have mitigated the need for this check. I'll try running the test suite with that change at least.

Dec 29 2021, 2:06 PM
avg added inline comments to D33648: dtrace: add a knob to control maximum size of principal buffers.
Dec 29 2021, 2:04 PM
avg committed R10:7963d46bb8cb: sys/queue.h: move trashing from SLIST_REMOVE to REMOVE_AFTER, REMOVE_HEAD (authored by avg).
sys/queue.h: move trashing from SLIST_REMOVE to REMOVE_AFTER, REMOVE_HEAD
Dec 29 2021, 8:23 AM
avg committed R10:aacff95603ed: sys/queue.h: move trashing from SLIST_REMOVE to REMOVE_AFTER, REMOVE_HEAD (authored by avg).
sys/queue.h: move trashing from SLIST_REMOVE to REMOVE_AFTER, REMOVE_HEAD
Dec 29 2021, 8:18 AM

Dec 27 2021

avg committed R10:e1f84822b249: amdsbwd: always enable watchdog register decoding (authored by avg).
amdsbwd: always enable watchdog register decoding
Dec 27 2021, 12:02 PM
avg committed R10:01409400eb11: vmxnet3: skip zero-length descriptor in the middle of a packet (authored by avg).
vmxnet3: skip zero-length descriptor in the middle of a packet
Dec 27 2021, 12:02 PM
avg committed R10:bf206683a865: amdsbwd: always enable watchdog register decoding (authored by avg).
amdsbwd: always enable watchdog register decoding
Dec 27 2021, 11:39 AM
avg committed R10:96097be6a8f7: vmxnet3: skip zero-length descriptor in the middle of a packet (authored by avg).
vmxnet3: skip zero-length descriptor in the middle of a packet
Dec 27 2021, 11:39 AM

Dec 26 2021

avg committed R10:ace3370392f8: add exuberant ctags tags file to gitignore (authored by avg).
add exuberant ctags tags file to gitignore
Dec 26 2021, 10:24 AM
avg committed R10:7b1bf3c12c23: twsi: use twsi_error() to handle wrong bus status when starting (authored by avg).
twsi: use twsi_error() to handle wrong bus status when starting
Dec 26 2021, 10:16 AM
avg committed R10:fe3c0370dafa: twsi: use twsi_error() to handle wrong bus status when starting (authored by avg).
twsi: use twsi_error() to handle wrong bus status when starting
Dec 26 2021, 10:16 AM

Dec 25 2021

avg committed R10:a8915e46ee12: mmc_sim: fix setting of the mutex name (authored by avg).
mmc_sim: fix setting of the mutex name
Dec 25 2021, 9:11 AM

Dec 24 2021

avg added a comment to D33649: dt_unring_buf: set dtbd_oldest to the start of the first record.

Thank you, Toomas.
Could you please run this change by illumos folks as well?
It seems that my emails to developer@lists.illumos.org are not reaching the list.

Dec 24 2021, 11:03 AM
avg added inline comments to D33648: dtrace: add a knob to control maximum size of principal buffers.
Dec 24 2021, 10:55 AM