All should be done. Thank you for reporting and diagnosing the problem.

Looks like I assumed too much without paying attention to the scratch buffer.
I'll revert the change.

update description

Based on earlier entries for Samsung 8x0 drives in ata_da.c and scsi_da.c it seems that a separate entry per model line was a preference.
But combing multiple entries is also okay.
However, I'd like to do it as a separate commit a bit later, unless you want to do that yourself.

In D43961#1002853, @imp wrote:

These aren't listed in Linux but I'm OK with them here

The controller is

ahci2@pci0:0:17:0:      class=0x010601 rev=0x40 hdr=0x00 vendor=0x1002 device=0x4391 subvendor=0x1043 subdevice=0x84dd
    vendor     = 'Advanced Micro Devices, Inc. [AMD/ATI]'
    device     = 'SB7x0/SB8x0/SB9x0 SATA Controller [AHCI mode]'
    class      = mass storage
    subclass   = SATA

Just want to comment that based on the errors I initially thought that the problem was a bad cable or SATA port, so I tried a few cables and a few ports on the motherboard, all with the same result.
Then I searched the internet and found some reports for the SSD model.
Then I tried attaching the SSD to an LSI SAS 2308 controller and all problem immediately went away.
Then I added the quirk and the problem got fixed for connecting to on-board SATA as well.

I should clarify that I didn't see just silent data corruption, there were read and write errors as well.

I first-hand experienced problems with a device identified as Samsung SSD 870 EVO 250GB SVT02B6Q.
I inferred that 860 is also affected based on the Linux bug report and on a similar problem with 850 as well.

restore previous handler in the error path

@kib , thank you for the feedback.

Committed in e92491d95ff.

While controlling which pool is a boot via bootfs property sounds useful, it adds yet another degree of freedom in the boot configuration.
I don't want legacy "BIOS" boot and EFI boot to diverge and I don't have time to work on the EFI ZFS boot code.
I think that this change was good, but I think that we can manage just fine without it.
So, I am withdrawing it.

This has been committed in ff1e8581806f7 and other commits.