Page MenuHomeFreeBSD
Differential D45649

dtrace: Add a partial implementation of dtrace_getarg() on arm64
ClosedPublic
Actions

Authored by markj on Wed, Jun 19, 9:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 27, 12:21 AM
Unknown Object (File)
Wed, Jun 26, 10:42 PM
Unknown Object (File)
Fri, Jun 21, 5:51 PM
Unknown Object (File)
Fri, Jun 21, 8:39 AM
Unknown Object (File)
Fri, Jun 21, 8:39 AM
Unknown Object (File)
Fri, Jun 21, 5:24 AM
Unknown Object (File)
Fri, Jun 21, 12:56 AM
Unknown Object (File)
Fri, Jun 21, 12:56 AM
View All 12 Files
Subscribers
domagoj.stolfa_gmail.com
emaste
imp

Details

Reviewers
andrew
gnn
avg
domagoj.stolfa_gmail.com
Group Reviewers
DTrace
Commits
rGbae00433f013: dtrace: Add a partial implementation of dtrace_getarg() on arm64
Summary

For invop providers (i.e., fbt and kinst) we can simply reach into the
invop trapframe to fetch argument registers for arguments 0-7; for
argument 8 and beyond we have to read the value off of the stack.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Wed, Jun 19, 9:49 PM
Herald added a reviewer: andrew. · View Herald TranscriptWed, Jun 19, 9:49 PM
Herald added a reviewer: gnn. · View Herald Transcript
Herald added subscribers: emaste, imp. · View Herald Transcript
markj requested review of this revision.Wed, Jun 19, 9:49 PM
Harbormaster completed remote builds in B58251: Diff 140011.Wed, Jun 19, 9:49 PM
avg accepted this revision as: avg.Thu, Jun 20, 4:58 AM
This revision is now accepted and ready to land.Thu, Jun 20, 4:58 AM
domagoj.stolfa_gmail.com added a subscriber: domagoj.stolfa_gmail.com.Thu, Jun 20, 1:25 PM
domagoj.stolfa_gmail.com added inline comments.
sys/cddl/dev/dtrace/aarch64/dtrace_isa.c
257

Is it maybe worth KASSERTing alignment of tf_sp here?

markj added inline comments.Thu, Jun 20, 1:27 PM
sys/cddl/dev/dtrace/aarch64/dtrace_isa.c
257

A KASSERT is probably too strong, but we should set a dtrace error flag if the alignment isn't right.

domagoj.stolfa_gmail.com added inline comments.Thu, Jun 20, 1:32 PM
sys/cddl/dev/dtrace/aarch64/dtrace_isa.c
257

Yeah, that sounds like a better idea :).

markj updated this revision to Diff 140035.Thu, Jun 20, 1:36 PM
markj marked 2 inline comments as done.

Check alignment. Reduce the amount of casting we do.

This revision now requires review to proceed.Thu, Jun 20, 1:36 PM
Harbormaster completed remote builds in B58265: Diff 140035.Thu, Jun 20, 1:36 PM
domagoj.stolfa_gmail.com accepted this revision.Thu, Jun 20, 1:38 PM
This revision is now accepted and ready to land.Thu, Jun 20, 1:38 PM
Closed by commit rGbae00433f013: dtrace: Add a partial implementation of dtrace_getarg() on arm64 (authored by markj). · Explain WhyThu, Jun 20, 4:46 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rGbae00433f013: dtrace: Add a partial implementation of dtrace_getarg() on arm64.

Revision Contents
Changeset List

PathSize
sys/
cddl/
dev/
dtrace/
aarch64/
33 lines

Diff 140040

View Options

sys/cddl/dev/dtrace/aarch64/dtrace_isa.c

Loading...