For invop providers (i.e., fbt and kinst) we can simply reach into the
invop trapframe to fetch argument registers for arguments 0-7; for
argument 8 and beyond we have to read the value off of the stack.
Details
Details
- Reviewers
andrew gnn avg domagoj.stolfa_gmail.com - Group Reviewers
DTrace - Commits
- rGbae00433f013: dtrace: Add a partial implementation of dtrace_getarg() on arm64
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 58251 Build 55139: arc lint + arc unit
Event Timeline
sys/cddl/dev/dtrace/aarch64/dtrace_isa.c | ||
---|---|---|
257 | Is it maybe worth KASSERTing alignment of tf_sp here? |
sys/cddl/dev/dtrace/aarch64/dtrace_isa.c | ||
---|---|---|
257 | A KASSERT is probably too strong, but we should set a dtrace error flag if the alignment isn't right. |
sys/cddl/dev/dtrace/aarch64/dtrace_isa.c | ||
---|---|---|
257 | Yeah, that sounds like a better idea :). |