Page MenuHomeFreeBSD

domagoj.stolfa_gmail.com (Domagoj Stolfa)
User

Projects

User Details

User Since
Sep 8 2016, 3:21 PM (403 w, 3 h)

Recent Activity

Thu, May 2

domagoj.stolfa_gmail.com accepted D44483: sdt: Prototype implementation of SDT probes using hot-patching.
Thu, May 2, 1:37 PM

Apr 22 2024

domagoj.stolfa_gmail.com accepted D44483: sdt: Prototype implementation of SDT probes using hot-patching.

I ran the tests with this applied on amd64, had a few kmods load/unload concurrently for a while and looked through the concurrency around the patching code. Everything seems to work fine on my end.

Apr 22 2024, 8:53 PM

Apr 21 2024

domagoj.stolfa_gmail.com added a comment to D33647: dtrace: make 'ring' and 'fill' policies imply 'noswitch' flag.

@avg It looks like this hit stable as well so will also need to be reverted before the release is cut: https://cgit.freebsd.org/src/commit/?h=stable/14&id=fb9c50f983ff6bdd6f33a22ae7d5b391435dd02a

Apr 21 2024, 1:33 AM

Apr 7 2024

domagoj.stolfa_gmail.com added a comment to D33647: dtrace: make 'ring' and 'fill' policies imply 'noswitch' flag.

Looking at the code a little bit further, it seems that

Apr 7 2024, 2:28 PM
domagoj.stolfa_gmail.com updated subscribers of D33647: dtrace: make 'ring' and 'fill' policies imply 'noswitch' flag.

@avg This seems to introduce a kernel panic when -x bufpolicy=ring is used:

Apr 7 2024, 1:53 PM

Feb 26 2024

domagoj.stolfa_gmail.com added inline comments to D44080: rtld-elf: report cause of failure to load the hints file.
Feb 26 2024, 6:12 PM

Jan 2 2024

domagoj.stolfa_gmail.com updated the diff for D41745: dtrace: Add the 'oformat' libdtrace option..

Missing comma in man page.

Jan 2 2024, 7:35 PM · DTrace
domagoj.stolfa_gmail.com updated the diff for D41745: dtrace: Add the 'oformat' libdtrace option..

Address @markj's comments.

Jan 2 2024, 7:31 PM · DTrace

Dec 8 2023

domagoj.stolfa_gmail.com updated the diff for D41745: dtrace: Add the 'oformat' libdtrace option..

Update the diff to address a few output alignment issues when not using structured output via xo_emit(). Without the added xo_flush() calls, the output from xo_emit() would be printed after all the other output is printed via fprintf(). Also added a comment explaining why xo_flush() is called in those situations.

Dec 8 2023, 4:05 PM · DTrace

Nov 1 2023

domagoj.stolfa_gmail.com added a comment to D41745: dtrace: Add the 'oformat' libdtrace option..

That's pretty terrible, given that all flavors of xo_emit* turn into the same codepath (xo_do_emit). Can you isolate this into something I can debug, or send me your current patch (phil@freebsd.org) and I'll see if I can do it?

Nov 1 2023, 5:44 PM · DTrace
domagoj.stolfa_gmail.com added a comment to D41745: dtrace: Add the 'oformat' libdtrace option..

@phil I've tried to do a basic implementation using xo_create_to_file and then implementing dt_emit() by redirecting buffered output and sprintf output to the regular printf output (it becomes dt_vprintf since i have a va_list instead of variadic arguments). However, I've noticed that if I do regular text output using

Nov 1 2023, 3:00 PM · DTrace

Oct 20 2023

domagoj.stolfa_gmail.com added inline comments to D41745: dtrace: Add the 'oformat' libdtrace option..
Oct 20 2023, 7:56 PM · DTrace
domagoj.stolfa_gmail.com added inline comments to D41745: dtrace: Add the 'oformat' libdtrace option..
Oct 20 2023, 10:16 AM · DTrace

Oct 19 2023

domagoj.stolfa_gmail.com updated the diff for D41745: dtrace: Add the 'oformat' libdtrace option..

Update the diff. This diff should address the following:

Oct 19 2023, 1:29 PM · DTrace

Oct 18 2023

domagoj.stolfa_gmail.com added inline comments to D41745: dtrace: Add the 'oformat' libdtrace option..
Oct 18 2023, 7:23 PM · DTrace
domagoj.stolfa_gmail.com added a comment to D41745: dtrace: Add the 'oformat' libdtrace option..

Thanks for the detailed reviews @markj and @phil! The libxo clarifications have been very helpful, much appreciated. I've added a few comments in places that can be discussed independently and will aim to update the diff addressing the comments sometime this week.

Oct 18 2023, 3:59 PM · DTrace

Sep 8 2023

domagoj.stolfa_gmail.com updated the diff for D41745: dtrace: Add the 'oformat' libdtrace option..

Add missing information to the man page and fix some bits in it (e.g. using .Fn for action names).

Sep 8 2023, 12:39 AM · DTrace
domagoj.stolfa_gmail.com updated the summary of D41745: dtrace: Add the 'oformat' libdtrace option..
Sep 8 2023, 12:17 AM · DTrace
domagoj.stolfa_gmail.com updated the diff for D41745: dtrace: Add the 'oformat' libdtrace option..

Updated the diff with documentation in the dtrace(1) man page, as well as a bug fix when it comes to naming aggregations. Namely, min, max, sum and count were all called count in the final output due to missing checks. These are now addressed.

Sep 8 2023, 12:16 AM · DTrace

Sep 7 2023

domagoj.stolfa_gmail.com added a comment to D41745: dtrace: Add the 'oformat' libdtrace option..

I suggest to think about adding --libxo foo as an alias to -x oformat=foo to make things more inline with what is actually done for, e.g., netstat(1).

Sep 7 2023, 12:15 PM · DTrace

Sep 6 2023

domagoj.stolfa_gmail.com updated the diff for D41745: dtrace: Add the 'oformat' libdtrace option..

Attempt #2 at addressing @markj's comments... Forgot one gettimeofday

Sep 6 2023, 6:25 PM · DTrace
domagoj.stolfa_gmail.com updated the diff for D41745: dtrace: Add the 'oformat' libdtrace option..

Address some comments by @markj. The man page comment is still true, as I will be updating that when all the documentation comes in.

Sep 6 2023, 6:21 PM · DTrace
domagoj.stolfa_gmail.com added a comment to D41745: dtrace: Add the 'oformat' libdtrace option..

I don't see a reason to avoid adding it to dtrace.1?

Sep 6 2023, 5:18 PM · DTrace

Sep 5 2023

domagoj.stolfa_gmail.com updated the summary of D41745: dtrace: Add the 'oformat' libdtrace option..
Sep 5 2023, 8:58 PM · DTrace
domagoj.stolfa_gmail.com updated the summary of D41745: dtrace: Add the 'oformat' libdtrace option..
Sep 5 2023, 8:38 PM · DTrace
domagoj.stolfa_gmail.com requested review of D41745: dtrace: Add the 'oformat' libdtrace option..
Sep 5 2023, 8:36 PM · DTrace
domagoj.stolfa_gmail.com edited P610 libdtrace oformat example.
Sep 5 2023, 8:05 PM
domagoj.stolfa_gmail.com created P610 libdtrace oformat example.
Sep 5 2023, 8:04 PM

Sep 4 2023

domagoj.stolfa_gmail.com updated the diff for D41722: dtrace: Fix a kernel panic in printm()..

That's true, it's late :). Updated the diff. Thanks!

Sep 4 2023, 9:26 PM
domagoj.stolfa_gmail.com requested review of D41722: dtrace: Fix a kernel panic in printm()..
Sep 4 2023, 9:02 PM

Aug 25 2023

domagoj.stolfa_gmail.com requested review of D41595: dtrace: Remove $FreeBSD$ from genmakefiles.sh..
Aug 25 2023, 6:35 PM · DTrace

Jul 25 2023

domagoj.stolfa_gmail.com updated the diff for D41157: dtrace: Add WITH_DTRACE_ASAN..

Add a missing newline to the option file and regenerate src.conf.5.

Jul 25 2023, 7:07 PM
domagoj.stolfa_gmail.com updated the diff for D41157: dtrace: Add WITH_DTRACE_ASAN..

Remove a leftover .\".

Jul 25 2023, 6:59 PM
domagoj.stolfa_gmail.com updated the diff for D41157: dtrace: Add WITH_DTRACE_ASAN..

Address the comments by markj and emaste.

Jul 25 2023, 5:58 PM

Jul 24 2023

domagoj.stolfa_gmail.com updated the diff for D41157: dtrace: Add WITH_DTRACE_ASAN..

Add tools/build/options/WITH_DTRACE_ASAN and update src.conf.

Jul 24 2023, 7:04 PM
domagoj.stolfa_gmail.com requested review of D41157: dtrace: Add WITH_DTRACE_ASAN..
Jul 24 2023, 6:18 PM

Jan 24 2023

domagoj.stolfa_gmail.com requested review of D38176: dtrace: Improve a verifier error message..
Jan 24 2023, 12:34 AM

Dec 7 2022

domagoj.stolfa_gmail.com accepted D37619: kinst: Add per-CPU interrupt trampolines.

Tested it on my end and it works. Code also looks good to me. Thanks!

Dec 7 2022, 9:36 PM

Mar 5 2022

domagoj.stolfa_gmail.com accepted D34362: linker: Permit CTFv3 containers.
Mar 5 2022, 11:13 AM
domagoj.stolfa_gmail.com accepted D34360: ctf: Add definitions for CTFv3.

I've read through the man page changes twice and couldn't find anything wrong. LGTM but maybe a read through by someone from docs would be a good idea.

Mar 5 2022, 1:55 AM
domagoj.stolfa_gmail.com accepted D34358: ctf: Import ctf.h from OpenBSD.
Mar 5 2022, 1:43 AM

Mar 2 2022

domagoj.stolfa_gmail.com added a comment to D34363: libctf: Handle CTFv3 containers.

Both seem reasonable to me. I'll aim to run some more tests with this and look it over one more time in detail by Friday and flag if I find anything, but overall looks good to me. Thanks for working on this!

Mar 2 2022, 2:40 PM
domagoj.stolfa_gmail.com added a comment to D34363: libctf: Handle CTFv3 containers.

Overall the patch looks good to me. I've run all of this under ASAN + UBSAN (with the full patch set applied) and nothing was flagged in this code as problematic when running the DTrace test suite and the FreeBSD build. I feel like it might be a good idea to properly restructure the code around CTFv2 and CTFv3 to account for other versions in the API rather than relying on the "else" case always being v3, but aside from that LGTM. @markj: what do you think about the alignment warning/error propagation?

Mar 2 2022, 2:07 PM
domagoj.stolfa_gmail.com added inline comments to D34360: ctf: Add definitions for CTFv3.
Mar 2 2022, 1:08 PM

Feb 24 2022

domagoj.stolfa_gmail.com requested changes to D34360: ctf: Add definitions for CTFv3.

The code looks good to me, but it probably needs man page changes like @debdrup mentioned. I also wonder if adding a comment at the top of the header somewhere simply stating what CTFv2 and CTFv3 are and how they differ at a high level makes sense. Perhaps in one or two short sentences so that if someone unfamiliar with CTF wants to simply use the header knows what they're working with without needing to read through a fairly detailed man page? Do you have any thoughts on this?

Feb 24 2022, 2:23 PM
domagoj.stolfa_gmail.com added a comment to D34358: ctf: Import ctf.h from OpenBSD.

The original CTF header has a bunch of useful comments describing the format. Perhaps these things should be included in this header too? While I appreciate that this is an import, those comments have helped me quite a bit when dealing with CTF and IMO should be included.

There is a ctf.5 man page that describes the format in much more detail than the comments did. I haven't updated it yet for v3 but will do so. Do you think it is sufficient to reference the man page here?

Feb 24 2022, 2:16 PM
domagoj.stolfa_gmail.com accepted D34359: linker: Simplify CTF container handling.

This looks good to me. Thanks!

Feb 24 2022, 2:10 PM
domagoj.stolfa_gmail.com added a comment to D34358: ctf: Import ctf.h from OpenBSD.

The original CTF header has a bunch of useful comments describing the format. Perhaps these things should be included in this header too? While I appreciate that this is an import, those comments have helped me quite a bit when dealing with CTF and IMO should be included.

Feb 24 2022, 2:07 PM

Dec 10 2021

domagoj.stolfa_gmail.com requested review of D33378: dtrace: Disable getf() as it is broken on FreeBSD..
Dec 10 2021, 7:26 PM

Sep 23 2021

domagoj.stolfa_gmail.com accepted D31494: developers-handbook: update the section on Remote GDB.
In D31494#723995, @jhb wrote:

Thanks for writing this up @mhorne, much appreciated! I've left a few comments from my experience of setting it up with QEMU + KVM today and the confusion I had while reading the existing documentation, as well as the confusion that I would probably have while reading this.

I wonder if it might make sense to explicitly state that the procedure for virtualization gdb stubs may be different depending on which hypervisor/emulator is being used, and then in follow-up commits (by you or anyone else really) document the procedure for each given hypervisor?

Right, the process for remote gdb is a little different when you are using a hypervisor, mainly because the hypervisor can pause execution automatically when it detects that a client has connected to its gdb stub. For the gdb stub implemented by the kernel, we must force a trap into the debugger in order to detect that a client has detected. That is why this chapter lists extra steps that you did not need.

I didn't come up with any text to really highlight this difference, but I think it will be easier to do once we add a separate [sub]section for remote gdb using bhyve/kvm/whatever. You can suggest specific text for the intro paragraph if you like.

Yes, I think we will want to add a separate section for bare-metal debugging with a hypervisor vs using serial to talk to the in-kernel stub which is what this currently documents.

Sep 23 2021, 6:36 PM

Sep 12 2021

domagoj.stolfa_gmail.com added a comment to D31494: developers-handbook: update the section on Remote GDB.

Thanks for writing this up @mhorne, much appreciated! I've left a few comments from my experience of setting it up with QEMU + KVM today and the confusion I had while reading the existing documentation, as well as the confusion that I would probably have while reading this.

Sep 12 2021, 8:56 PM

Sep 4 2021

domagoj.stolfa_gmail.com accepted D30286: kqueue: add EV_KEEPUDATA flag.

@jhb Any chance you could push this? I've been using this for months and it's worked well for me.

Sep 4 2021, 10:51 PM

Jun 16 2021

domagoj.stolfa_gmail.com added a comment to D30778: dtrace: fix an out of bound read and a NULL pointer increment.

If there are any tags, e.g., sponsored by, please add them to the review description and I'll commit.

You can add a Signed-off-by: domagoj.stolfa@gmail.com if you'd like

I prefer not to since we don't have a policy around it, at least not yet. If you prefer to have it, then I'll keep it.

Jun 16 2021, 3:45 PM · DTrace
domagoj.stolfa_gmail.com updated the summary of D30778: dtrace: fix an out of bound read and a NULL pointer increment.
Jun 16 2021, 3:02 PM · DTrace
domagoj.stolfa_gmail.com updated the summary of D30778: dtrace: fix an out of bound read and a NULL pointer increment.
Jun 16 2021, 3:02 PM · DTrace
domagoj.stolfa_gmail.com added a comment to D30778: dtrace: fix an out of bound read and a NULL pointer increment.

If there are any tags, e.g., sponsored by, please add them to the review description and I'll commit.

Jun 16 2021, 3:01 PM · DTrace

Jun 15 2021

domagoj.stolfa_gmail.com requested review of D30778: dtrace: fix an out of bound read and a NULL pointer increment.
Jun 15 2021, 8:20 PM · DTrace

May 27 2021

domagoj.stolfa_gmail.com accepted D30255: style: Relax 80 column rule.

This seems reasonable to me.

May 27 2021, 5:58 PM

May 16 2021

domagoj.stolfa_gmail.com added a comment to D30286: kqueue: add EV_KEEPUDATA flag.

I've been using this locally and found it *extremely* useful, and frankly was quite surprised when I found out that EV_ENABLE/EV_DISABLE trashed udata originally.

May 16 2021, 12:29 PM

May 13 2021

domagoj.stolfa_gmail.com added a comment to D30255: style: Relax 80 column rule.
In D30255#679519, @sef wrote:

I still use an 80 character limit, and an 80 character-wide Terminal window.

Usually my opinion means everyone else has moved on :).

May 13 2021, 10:15 PM
domagoj.stolfa_gmail.com updated the diff for D30248: run uncrustify over vtfontcvt.c.

Remove a whole bunch of noise compared to the previous diff.

May 13 2021, 3:58 PM
domagoj.stolfa_gmail.com edited P500 uncrustify freebsd.cfg.
May 13 2021, 3:58 PM
domagoj.stolfa_gmail.com updated the summary of D30248: run uncrustify over vtfontcvt.c.
May 13 2021, 3:47 PM
domagoj.stolfa_gmail.com created P500 uncrustify freebsd.cfg.
May 13 2021, 3:46 PM
domagoj.stolfa_gmail.com updated the diff for D30248: run uncrustify over vtfontcvt.c.

Update the diff with -U999999

May 13 2021, 3:43 PM
domagoj.stolfa_gmail.com added inline comments to D30248: run uncrustify over vtfontcvt.c.
May 13 2021, 3:41 PM
domagoj.stolfa_gmail.com requested review of D30248: run uncrustify over vtfontcvt.c.
May 13 2021, 3:16 PM

Apr 1 2021

domagoj.stolfa_gmail.com updated the diff for D29541: DTrace: document the "nolibs" option.
Apr 1 2021, 10:28 PM · DTrace
domagoj.stolfa_gmail.com added inline comments to D29541: DTrace: document the "nolibs" option.
Apr 1 2021, 9:50 PM · DTrace
domagoj.stolfa_gmail.com updated the diff for D29541: DTrace: document the "nolibs" option.

@markj 's comments.

Apr 1 2021, 9:50 PM · DTrace
domagoj.stolfa_gmail.com added inline comments to D29541: DTrace: document the "nolibs" option.
Apr 1 2021, 9:22 PM · DTrace
domagoj.stolfa_gmail.com updated the diff for D29541: DTrace: document the "nolibs" option.

Added -x libdir and -x syslibdir as suggested by @markj

Apr 1 2021, 9:21 PM · DTrace
domagoj.stolfa_gmail.com requested review of D29541: DTrace: document the "nolibs" option.
Apr 1 2021, 8:50 PM · DTrace

Mar 27 2021

domagoj.stolfa_gmail.com added inline comments to D29435: CTF: Fix an out-of-bounds read.
Mar 27 2021, 6:02 PM · DTrace
domagoj.stolfa_gmail.com updated the diff for D29435: CTF: Fix an out-of-bounds read.
Mar 27 2021, 6:01 PM · DTrace
domagoj.stolfa_gmail.com added a comment to D29435: CTF: Fix an out-of-bounds read.

(Please let me know if you'd like me to commit this.)

Mar 27 2021, 3:43 PM · DTrace

Mar 26 2021

domagoj.stolfa_gmail.com requested review of D29435: CTF: Fix an out-of-bounds read.
Mar 26 2021, 7:18 PM · DTrace

Aug 27 2018

domagoj.stolfa_gmail.com added a comment to D16921: Attempt to support multiple tracepoints with the same address..

I think it would be nicer to instead keep all tracepoints for a given address on a linked list, with a single hash table entry for all of them. fbt_invop() would invoke dtrace_probe() for each probe associated with the tracepoint, which should be fine so long as there aren't many. (With ifuncs there will be 2.)

Perhaps we could even bunch them into a bounded array (or a vector-like implementation) and check it at fbt load-time in order to avoid indirection? A linked list is unlikely to be too painful given all the membars and indirection happening in dynamic variable implementation -- but nonetheless would degrade performance :-).

I think it's acceptable for the time being since, as I pointed out, there are at most 2 probes for a given tracepoint currently. The FBT hash table is itself cache-unfriendly, and I'd rather fix the performance problems there holistically. Here's the distribution of hash chain lengths on a system with a fairly stripped-down kernel:

5395 0
9755 1
8748 2
5244 3
2369 4
 876 5
 280 6
  73 7
  24 8
   3 9
   1 10
Aug 27 2018, 6:28 PM
domagoj.stolfa_gmail.com added a comment to D16921: Attempt to support multiple tracepoints with the same address..

I think it would be nicer to instead keep all tracepoints for a given address on a linked list, with a single hash table entry for all of them. fbt_invop() would invoke dtrace_probe() for each probe associated with the tracepoint, which should be fine so long as there aren't many. (With ifuncs there will be 2.)

Aug 27 2018, 5:15 PM
domagoj.stolfa_gmail.com added a comment to D16921: Attempt to support multiple tracepoints with the same address..

Why "additional"? The problem exists regardless since fbt_invop() returns after the first matching tracepoint. The problem was invisible before ifuncs since before that all tracepoints had distinct addresses. This patch just hides the problem in the common case.

Aug 27 2018, 4:38 PM
domagoj.stolfa_gmail.com added a comment to D16921: Attempt to support multiple tracepoints with the same address..

I'm a little worried that this may cause additional confusion if someone expects multiple probes to fire at that point. I wonder if a better workaround would be to just add a warning message whenever DTrace is called, or perhaps when someone calls dtrace -l, in the man page or something along the lines until we fix? Is there a reason we can't fix this in 13 and MFC the changes?

Aug 27 2018, 4:25 PM

May 8 2018

domagoj.stolfa_gmail.com updated the diff for D15359: DTrace aarch64: Avoid calling unwind_frame() in the probe context.

Preemptively remove a redundant check for INKERNEL(fp).

May 8 2018, 9:23 PM · arm64, DTrace
domagoj.stolfa_gmail.com added a comment to D15359: DTrace aarch64: Avoid calling unwind_frame() in the probe context.

Why not just exclude it in fbt_provide_module_function? I'd prefer we keep the unwinding code together, maybe with a comment that it may be called from such a context.

May 8 2018, 9:22 PM · arm64, DTrace
domagoj.stolfa_gmail.com added a comment to D15359: DTrace aarch64: Avoid calling unwind_frame() in the probe context.

however, in the future a patch that enabled instrumentation of inlined functions could accidentally break DTrace on aarch64.

Was the problem found while working on such a patch? :)

May 8 2018, 8:55 PM · arm64, DTrace
domagoj.stolfa_gmail.com updated the summary of D15359: DTrace aarch64: Avoid calling unwind_frame() in the probe context.
May 8 2018, 8:51 PM · arm64, DTrace
domagoj.stolfa_gmail.com created D15359: DTrace aarch64: Avoid calling unwind_frame() in the probe context.
May 8 2018, 8:37 PM · arm64, DTrace

Apr 30 2018

domagoj.stolfa_gmail.com accepted D15221: Disable connectat/bindat with AT_FDCWD parameter in capabilities mode.

Had a quick skim, but LGTM.

Apr 30 2018, 4:05 PM · capsicum

Apr 21 2018

domagoj.stolfa_gmail.com added inline comments to D15150: Split procfs_attr into multiple functions.
Apr 21 2018, 7:54 PM

Apr 12 2018

domagoj.stolfa_gmail.com added a comment to D14656: Add SDT probes to the VMX VMexit interface.

Is this good to land? Thanks!

Apr 12 2018, 4:31 PM · DTrace, bhyve

Apr 6 2018

domagoj.stolfa_gmail.com updated the diff for D14863: DTrace: Add an invariant to check for recursion in dtrace_probe().

Address the other comments by @markj and fix a misleading word in the dtrace_probe_exit() comment.

Apr 6 2018, 5:11 PM
domagoj.stolfa_gmail.com removed 1 blocking reviewer(s) for D14863: DTrace: Add an invariant to check for recursion in dtrace_probe(): gnn.
Apr 6 2018, 4:51 PM
domagoj.stolfa_gmail.com updated the diff for D14863: DTrace: Add an invariant to check for recursion in dtrace_probe().

Address comments by @markj.

Apr 6 2018, 4:50 PM

Apr 4 2018

domagoj.stolfa_gmail.com added inline comments to D9988: Add support for a copyoutmbuf() subroutine for DTrace..
Apr 4 2018, 6:02 PM
domagoj.stolfa_gmail.com added inline comments to D9988: Add support for a copyoutmbuf() subroutine for DTrace..
Apr 4 2018, 4:32 PM

Apr 3 2018

domagoj.stolfa_gmail.com added a comment to D14863: DTrace: Add an invariant to check for recursion in dtrace_probe().

Is there anything else I can do for this to land?

Apr 3 2018, 9:55 PM

Mar 28 2018

domagoj.stolfa_gmail.com added a comment to D14656: Add SDT probes to the VMX VMexit interface.

Should I make any more changes for this to land? As an aside note: I've tried to make the interface as simple as possible to use with the args[0-2] being consistent.

Mar 28 2018, 3:11 PM · DTrace, bhyve

Mar 27 2018

domagoj.stolfa_gmail.com abandoned D14862: Make INVARIANTS enable DEBUG in DTrace.
In D14862#312653, @avg wrote:

FWIW, rS253996 is what I did to translate INVARIANTS to DEBUG for ZFS.
Seems like the commit even touched some dtrace modules.

Mar 27 2018, 5:04 PM
domagoj.stolfa_gmail.com updated the diff for D14862: Make INVARIANTS enable DEBUG in DTrace.

Update the diff based on comments from @markj.

Mar 27 2018, 4:49 PM
domagoj.stolfa_gmail.com added inline comments to D14862: Make INVARIANTS enable DEBUG in DTrace.
Mar 27 2018, 4:44 PM

Mar 26 2018

domagoj.stolfa_gmail.com updated the summary of D14863: DTrace: Add an invariant to check for recursion in dtrace_probe().
Mar 26 2018, 11:25 PM