Page MenuHomeFreeBSD

Disable connectat/bindat with AT_FDCWD parameter in capabilities mode
ClosedPublic

Authored by jan.kokemueller_gmail.com on Apr 28 2018, 6:09 AM.
Referenced Files
Unknown Object (File)
Fri, Sep 11, 3:19 AM
Unknown Object (File)
Sat, Sep 5, 7:04 AM
Unknown Object (File)
Sat, Sep 5, 2:08 AM
Unknown Object (File)
Fri, Sep 4, 10:55 PM
Unknown Object (File)
Fri, Sep 4, 6:14 AM
Unknown Object (File)
Fri, Sep 4, 1:36 AM
Unknown Object (File)
Thu, Sep 3, 6:34 AM
Unknown Object (File)
Wed, Sep 2, 9:07 PM

Details

Summary

Currently it is possible to connect a socket by calling "connectat(AT_FDCWD, ...)" even in capabilties mode. This combination should probably be treated the same as a call to connect (i.e. forbidden in capabilities mode).

This patch disables connectat/bindat with AT_FDCWD in capabilities mode, fixes up the documentation and adds some tests.

See also https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=222632.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Thank you, I will try to review soon and have added some other Capsicum folks.

If you upload again please include full context, via git diff -U9999 or svn diff -x-U99999 or similar.

This revision is now accepted and ready to land.Apr 30 2018, 4:05 PM

connectat/bindat description updated in rS333119

This revision was automatically updated to reflect the committed changes.