Page MenuHomeFreeBSD

oshogbo (Mariusz Zaborski)
User

Projects

User Details

User Since
Aug 19 2014, 3:56 PM (432 w, 5 d)

Recent Activity

Tue, Nov 15

oshogbo added a comment to D36259: rc: also run NAME_setup on NAME_reload.

Sorry for so late review.
Should we also add it to rc.subr(8) man page?

Tue, Nov 15, 7:29 PM · rc

Sun, Nov 13

oshogbo committed rG134b047d3e93: logger: fix builds without casper (authored by oshogbo).
logger: fix builds without casper
Sun, Nov 13, 7:51 PM

Fri, Nov 11

oshogbo closed D36210: rc: add a manual entry for ${name}_setup.
Fri, Nov 11, 9:24 PM · rc
oshogbo committed rGb05e7e702293: rc: add a manual entry for ${name}_setup (authored by franco_opnsense.org).
rc: add a manual entry for ${name}_setup
Fri, Nov 11, 9:24 PM

Thu, Nov 10

oshogbo accepted D36402: Remove dead code in the cscope target.
Thu, Nov 10, 10:55 AM

Oct 19 2022

oshogbo added a comment to D23744: Added casper service to logger.

Should be fixed with: af3297898720af2f2ed18d18d45ea6bf50d55ef1

Oct 19 2022, 2:04 PM
oshogbo committed rGaf3297898720: logger: fix builds without casper (authored by oshogbo).
logger: fix builds without casper
Oct 19 2022, 2:03 PM

Oct 1 2022

oshogbo committed rG6da5e5d649ba: seq: fix style nits (authored by oshogbo).
seq: fix style nits
Oct 1 2022, 10:09 AM
oshogbo committed rG94c4f663bab5: seq: fix potential NULL ptr reference (authored by oshogbo).
seq: fix potential NULL ptr reference
Oct 1 2022, 10:09 AM

Sep 30 2022

oshogbo added a comment to D36210: rc: add a manual entry for ${name}_setup.

@0mp are you happy with the fixed version?

Sep 30 2022, 12:15 PM · rc

Sep 29 2022

oshogbo committed rG26573e2c7f4b: cap_netdb: Fix description style (authored by oshogbo).
cap_netdb: Fix description style
Sep 29 2022, 5:53 PM
oshogbo committed rGfacd6b58d5f8: libcapser: Add reference to cap_netdb (authored by oshogbo).
libcapser: Add reference to cap_netdb
Sep 29 2022, 5:52 PM

Sep 26 2022

oshogbo accepted D36709: geom_part: Fix potential integer overflow when checking size of the table.

I don't think we treat this as a security issue.

Sep 26 2022, 10:43 AM

Aug 17 2022

oshogbo added a reviewer for D36210: rc: add a manual entry for ${name}_setup: cperciva.
Aug 17 2022, 11:34 AM · rc

Aug 15 2022

oshogbo committed rGc9be47b34dd8: rc: add ${name}_setup script support (authored by franco_opnsense.org).
rc: add ${name}_setup script support
Aug 15 2022, 2:43 PM

Aug 1 2022

oshogbo accepted D36006: rc: add ${name}_setup script support.
Aug 1 2022, 9:42 AM · rc

Jul 18 2022

oshogbo added inline comments to D35823: Upgrade FreeBSD features page.
Jul 18 2022, 9:01 AM

Jul 7 2022

oshogbo accepted D35747: rc.subr: Make sure oomprotect protects existing children.

The change LGTM.
That said I would suggest committing this as submited by: Mike Walker, not as a co-authored as he did the heavy lifting in this change.

Jul 7 2022, 9:40 PM

Jul 5 2022

oshogbo added inline comments to D35574: xargs: terminate if line replacement cannot be constructed.
Jul 5 2022, 3:16 PM

Jun 27 2022

oshogbo added inline comments to D35574: xargs: terminate if line replacement cannot be constructed.
Jun 27 2022, 2:33 PM

Apr 18 2022

oshogbo accepted D34945: capsicum: briefly describe capabilities in man page.

IMHO its on point.
Please remember to bump Dd.

Apr 18 2022, 8:52 PM

Mar 20 2022

oshogbo committed rG1e9ce60a6d75: cap_fileargs: silence warnings of unused variable (authored by oshogbo).
cap_fileargs: silence warnings of unused variable
Mar 20 2022, 10:24 AM

Mar 19 2022

oshogbo committed rGe7023af434e2: touch: don't leak descriptor if fstat(2) fails (authored by oshogbo).
touch: don't leak descriptor if fstat(2) fails
Mar 19 2022, 1:18 PM

Mar 17 2022

oshogbo added inline comments to D34547: bhyve - snapshot capsicum integration[Part 1].
Mar 17 2022, 3:46 PM
oshogbo added inline comments to D34547: bhyve - snapshot capsicum integration[Part 1].
Mar 17 2022, 3:07 PM
oshogbo added inline comments to D34547: bhyve - snapshot capsicum integration[Part 1].
Mar 17 2022, 3:02 PM

Mar 12 2022

oshogbo added a comment to D34263: etcupdate: check passwords after resolving conflicts.

Ping.

Mar 12 2022, 10:52 AM
oshogbo committed rGcb54c500d0e1: touch: don't leak descriptor if fstat(2) fails (authored by oshogbo).
touch: don't leak descriptor if fstat(2) fails
Mar 12 2022, 10:44 AM
oshogbo committed rG2b0d4ae9ce61: cap_net: plug memory leak (authored by oshogbo).
cap_net: plug memory leak
Mar 12 2022, 10:30 AM
oshogbo committed rG2c1ade6cd608: cap_net: fix verification of bind permission (authored by oshogbo).
cap_net: fix verification of bind permission
Mar 12 2022, 10:30 AM
oshogbo committed R9:d1b85b5ab578: Update a PGP key for def. (authored by def).
Update a PGP key for def.
Mar 12 2022, 10:23 AM

Feb 18 2022

oshogbo added inline comments to D34263: etcupdate: check passwords after resolving conflicts.
Feb 18 2022, 5:27 PM
oshogbo added inline comments to D34263: etcupdate: check passwords after resolving conflicts.
Feb 18 2022, 5:24 PM

Feb 15 2022

oshogbo updated the diff for D34263: etcupdate: check passwords after resolving conflicts.

Yeach, I totaly forgot about this part @jhb.

Feb 15 2022, 9:07 AM

Feb 13 2022

oshogbo added inline comments to D34263: etcupdate: check passwords after resolving conflicts.
Feb 13 2022, 10:23 PM
oshogbo updated the diff for D34263: etcupdate: check passwords after resolving conflicts.

Fix typo in comment, spotted by @emaste.

Feb 13 2022, 10:23 PM
oshogbo added reviewers for D34263: etcupdate: check passwords after resolving conflicts: emaste, markj, jhb.
Feb 13 2022, 9:08 PM
oshogbo updated the diff for D34263: etcupdate: check passwords after resolving conflicts.

Style.

Feb 13 2022, 9:06 PM
oshogbo requested review of D34263: etcupdate: check passwords after resolving conflicts.
Feb 13 2022, 9:03 PM

Jan 10 2022

oshogbo accepted D33795: tail: add test for tail -F against newsyslog rotation.

LGTM.

Jan 10 2022, 6:05 PM

Dec 15 2021

oshogbo closed D30062: www/chromium: fix obtaining HOST_NAME_MAX.
Dec 15 2021, 6:40 PM · Ports Committers, Contributor Reviewers (ports)
oshogbo committed R11:a33ecd73b409: www/chromium: fix obtaining HOST_NAME_MAX (authored by a.wolk_fudosecurity.com).
www/chromium: fix obtaining HOST_NAME_MAX
Dec 15 2021, 6:40 PM

Dec 14 2021

oshogbo committed rGf45ca435bd2c: cap_net: fix verification of bind permission (authored by oshogbo).
cap_net: fix verification of bind permission
Dec 14 2021, 11:03 AM
oshogbo committed rG88910b8b7b14: cap_net: plug memory leak (authored by oshogbo).
cap_net: plug memory leak
Dec 14 2021, 11:03 AM
oshogbo accepted D30064: devel/electron11: fix obtaining HOST_NAME_MAX.

Thank you @tagattie !

Dec 14 2021, 10:33 AM · Ports Committers, Contributor Reviewers (ports)

Dec 13 2021

oshogbo closed D30667: fix tail -f on stdin.

Thank you @markj

Dec 13 2021, 6:43 PM
oshogbo added a comment to D30064: devel/electron11: fix obtaining HOST_NAME_MAX.

@tagattie any plan to review this?

Dec 13 2021, 3:04 PM · Ports Committers, Contributor Reviewers (ports)
oshogbo accepted D30667: fix tail -f on stdin.

Pong @swills . Do you plan yo commit this change?

Dec 13 2021, 3:02 PM
oshogbo accepted D20577: Add information on how to load GEOM_MIRROR into the kernel at boot time and while the system is running to the SYNOPSIS section of gmirror.8 .
Dec 13 2021, 3:01 PM

Nov 22 2021

oshogbo added a comment to D32722: libnv: read entire datagram in nvlist_recv().

Feel free to commit this.

Nov 22 2021, 1:31 PM

Nov 15 2021

oshogbo added a comment to D32976: Initial clean up the language in the manual pages..

Wow, thank you, @gnn, for looking at this. I appreciate that!

Nov 15 2021, 4:17 PM

Nov 8 2021

oshogbo committed rG748a707fe609: libc: fix the test (authored by oshogbo).
libc: fix the test
Nov 8 2021, 11:34 AM

Nov 7 2021

oshogbo committed rG597b02675751: libc: add clearenv function (authored by oshogbo).
libc: add clearenv function
Nov 7 2021, 3:20 PM
oshogbo closed D28223: libc: add cleanenv function.
Nov 7 2021, 3:20 PM

Nov 3 2021

oshogbo updated subscribers of D32722: libnv: read entire datagram in nvlist_recv().

@lwhsu Is those settings ok with our tests machines?

Nov 3 2021, 4:12 PM

Oct 29 2021

oshogbo added a comment to D32722: libnv: read entire datagram in nvlist_recv().

Could you also add test for this case?

Oct 29 2021, 9:07 AM

Oct 7 2021

oshogbo committed rG824bbb9a4082: diff: consider two files with same inodes as identical (authored by oshogbo).
diff: consider two files with same inodes as identical
Oct 7 2021, 3:10 PM

Sep 14 2021

oshogbo added a comment to D31382: lib/libc: Fix uninitialized value in __setenv().

Oh. Right.
I didn't noticed that after realloc the memory is not cleaned.
Yes, I also would go with @delphij suggestion.

Sep 14 2021, 9:00 AM

Sep 13 2021

oshogbo committed rGe673ac3ffbfb: libnv: Fix array unpack endianness logic (authored by sg2342_googlemail.com).
libnv: Fix array unpack endianness logic
Sep 13 2021, 7:26 PM
oshogbo accepted D31382: lib/libc: Fix uninitialized value in __setenv().

If I understand correctly, the envVars with the putenv can't be reused.
So the putenv actually is set to 0 (as we are doing calloc'ing the memory needed for envVars), and we are 0 memory when we needed.
So besides the unhappy MK_UBSAN, there are no functional changes, as well as there is no security implication.
If I'm wrong at some of these statements, please correct me.

Sep 13 2021, 6:57 PM

Aug 30 2021

oshogbo added inline comments to D20300: Introducing pdopen..
Aug 30 2021, 3:37 PM
oshogbo added inline comments to D20300: Introducing pdopen..
Aug 30 2021, 2:55 PM
oshogbo added inline comments to D31727: geom_gate: ensure readprov is null-terminated.
Aug 30 2021, 2:27 PM

Aug 27 2021

oshogbo updated the diff for D20300: Introducing pdopen..

Address @markj review.
Cover the wait issue.
Add test cases.

Aug 27 2021, 9:48 AM

Aug 21 2021

oshogbo committed rG3a92927bb69f: bhyve: change a default address from ANY to localhost (authored by oshogbo).
bhyve: change a default address from ANY to localhost
Aug 21 2021, 5:43 PM
oshogbo closed D29607: byhve: add option to specify IP address for gdb.
Aug 21 2021, 5:43 PM
oshogbo committed rG2cdff9918e79: byhve: add option to specify IP address for gdb (authored by oshogbo).
byhve: add option to specify IP address for gdb
Aug 21 2021, 5:43 PM

Jul 23 2021

oshogbo added inline comments to D31266: dumpon: Fix -v causing error when configuring an encrypted dump.
Jul 23 2021, 9:33 AM

Jul 9 2021

oshogbo committed rG24c681a7f6d6: grep: fix combination of quite and count flag (authored by oshogbo).
grep: fix combination of quite and count flag
Jul 9 2021, 12:10 PM
oshogbo closed D31108: grep: fix combination of quite and count flag.
Jul 9 2021, 12:10 PM

Jul 8 2021

oshogbo requested review of D31108: grep: fix combination of quite and count flag.
Jul 8 2021, 11:45 AM

Jul 6 2021

oshogbo committed rGeed85dd1ad31: libnv: optimize nvlist size calculation (authored by oshogbo).
libnv: optimize nvlist size calculation
Jul 6 2021, 6:27 PM
oshogbo committed rGddab4ee61002: libnv: fix revert (authored by oshogbo).
libnv: fix revert
Jul 6 2021, 6:27 PM
oshogbo committed rG6c33105c1a81: libnv: fix double free (authored by oshogbo).
libnv: fix double free
Jul 6 2021, 6:27 PM
oshogbo committed rGbc2bc8ee6e18: libnv: fix memory leaks (authored by oshogbo).
libnv: fix memory leaks
Jul 6 2021, 6:26 PM
oshogbo committed rGdc876a5bcd46: libnv: fix memory leaks (authored by oshogbo).
libnv: fix memory leaks
Jul 6 2021, 6:26 PM
oshogbo committed rGff339365be13: libnv: optimize nvlist size calculation (authored by oshogbo).
libnv: optimize nvlist size calculation
Jul 6 2021, 5:54 PM
oshogbo committed rGb907e9d9a149: libnv: fix revert (authored by oshogbo).
libnv: fix revert
Jul 6 2021, 5:54 PM
oshogbo committed rG4c79391a7fa4: libnv: fix double free (authored by oshogbo).
libnv: fix double free
Jul 6 2021, 5:54 PM
oshogbo committed rGf98545c7e991: libnv: fix memory leaks (authored by oshogbo).
libnv: fix memory leaks
Jul 6 2021, 5:53 PM

Jul 5 2021

oshogbo accepted D31038: rtld/tests: Avoid function name conflict with libc opendir().

We have fdopendir in libc I wonder if this won't be confusing. Maybe we should rename this to something like rtld_opendir.
But whatever name your choose this LGTM.

Jul 5 2021, 9:33 AM

Jun 24 2021

oshogbo committed rG6ba108e52d17: rc.subr: use _pidcmd to determine pid for protect (authored by oshogbo).
rc.subr: use _pidcmd to determine pid for protect
Jun 24 2021, 6:16 PM
oshogbo closed D30367: rc.subr: use _pidcmd to determine pid for protect.
Jun 24 2021, 6:16 PM · rc
oshogbo accepted D30367: rc.subr: use _pidcmd to determine pid for protect.
Jun 24 2021, 6:12 PM · rc

Jun 18 2021

oshogbo added a comment to D26958: sockstat: Use libcasper to capsicumize.

Fixes are on haed.

Jun 18 2021, 4:13 PM
oshogbo committed rG7ad30f58dd63: sockstat: use cap_pwd (authored by oshogbo).
sockstat: use cap_pwd
Jun 18 2021, 4:13 PM
oshogbo committed rGbfb5947bb1e9: sockstat: fix core dump (authored by oshogbo).
sockstat: fix core dump
Jun 18 2021, 4:13 PM
oshogbo added a comment to D26958: sockstat: Use libcasper to capsicumize.

Hello Oliver,

Jun 18 2021, 10:19 AM
oshogbo committed rGb4fe6fbab236: libcasper: add missing unistd.h (authored by oshogbo).
libcasper: add missing unistd.h
Jun 18 2021, 9:44 AM

Jun 17 2021

oshogbo added a comment to D26958: sockstat: Use libcasper to capsicumize.

Hello Oliver,

Jun 17 2021, 8:49 PM

Jun 15 2021

oshogbo committed rG6c0a51837f4b: libcasper: fix descriptors numbers (authored by oshogbo).
libcasper: fix descriptors numbers
Jun 15 2021, 6:31 PM
oshogbo committed rG4e2ae05c3ae8: libcasper: fix descriptors numbers (authored by oshogbo).
libcasper: fix descriptors numbers
Jun 15 2021, 6:24 PM
oshogbo committed rG934e10b4a388: libcasper: fix descriptors numbers (authored by oshogbo).
libcasper: fix descriptors numbers
Jun 15 2021, 6:18 PM

Jun 13 2021

oshogbo updated the diff for D29607: byhve: add option to specify IP address for gdb.

Address @jhb comments (I hope).

Jun 13 2021, 6:18 PM

Jun 11 2021

oshogbo added inline comments to D30667: fix tail -f on stdin.
Jun 11 2021, 7:20 PM
oshogbo added a comment to D30667: fix tail -f on stdin.

Hym its works for me.

Jun 11 2021, 7:14 PM
oshogbo added a comment to D30667: fix tail -f on stdin.

Can you provide some more context?

Jun 11 2021, 7:02 PM
oshogbo committed rG89d5cbb82294: libnv: optimize nvlist size calculation (authored by oshogbo).
libnv: optimize nvlist size calculation
Jun 11 2021, 3:52 PM

Jun 10 2021

oshogbo committed rGaa310ebfba3d: libcasper: fix descriptors numbers (authored by oshogbo).
libcasper: fix descriptors numbers
Jun 10 2021, 10:42 AM

Jun 5 2021

oshogbo added a comment to D28223: libc: add cleanenv function.

@secteam ping?

Jun 5 2021, 5:00 PM