@kib

Yes, thats make sense. Thank you.

kib@ thank you. Moved to libuitl.

Move to libuitl

Update description.

Add more context to the file.

Sorry for the delay.

@imp Have you had a chance to look into this?

Use sizeof.

Fix description

LGTM.
Nice catch.

I don't mind also moving them simply to /lib.

The idea for a separate directory was that we would have many libcasper helpers, and the /lib will get crowdy.
The Casper libraries are quite limited in number so I'm not sure if it's worth it to keep a separate directory here.

Hym, sorry, last time it showed me that you almost added the whole sys/kern/kern_procctl.c. I guess it was some glitch in phabricator.

Are you sure this patch is correctly generated?
I know that you said you want the review of the general idea, but still..

One more thing.
I'm not sure what commit msg you want to use.
So as a side note, many people give in the first line a oneliner containing the module/subsystem name and a meaningful description.
So for this case, you can use the following:

nv: improve the style in one of the examples

or

libnv: improve the style in one of the examples

LGTM.

The diffs should be generated with the full context:

git diff -U99999

I think this requires more explanation.
Without this define the casper will work and use standard definition instead of "secure" implementation prepared for capsicum.
This allow to build a tools for FreeBSD without capsicum/casper support - for example for rescue or bootstrap.
Simply putting this define in front of includes will break this behaviour.

Sorry for so late review.
Should we also add it to rc.subr(8) man page?

Should be fixed with: af3297898720af2f2ed18d18d45ea6bf50d55ef1

@0mp are you happy with the fixed version?

I don't think we treat this as a security issue.

The change LGTM.
That said I would suggest committing this as submited by: Mike Walker, not as a co-authored as he did the heavy lifting in this change.

IMHO its on point.
Please remember to bump Dd.

Ping.

Yeach, I totaly forgot about this part @jhb.

Fix typo in comment, spotted by @emaste.

Style.