User Details
- User Since
- Aug 19 2014, 3:56 PM (474 w, 3 d)
Wed, Sep 6
Aug 7 2023
May 29 2023
May 15 2023
Yes, thats make sense. Thank you.
May 12 2023
kib@ thank you. Moved to libuitl.
Move to libuitl
May 7 2023
Update description.
May 6 2023
Add more context to the file.
May 2 2023
Apr 27 2023
Sorry for the delay.
Apr 26 2023
Apr 21 2023
Apr 17 2023
@imp Have you had a chance to look into this?
Apr 13 2023
Fix description
Apr 4 2023
LGTM.
Nice catch.
Mar 24 2023
I don't mind also moving them simply to /lib.
The idea for a separate directory was that we would have many libcasper helpers, and the /lib will get crowdy.
The Casper libraries are quite limited in number so I'm not sure if it's worth it to keep a separate directory here.
Feb 14 2023
Feb 13 2023
Feb 10 2023
Feb 8 2023
Feb 7 2023
Feb 3 2023
Hym, sorry, last time it showed me that you almost added the whole sys/kern/kern_procctl.c. I guess it was some glitch in phabricator.
Feb 2 2023
Are you sure this patch is correctly generated?
I know that you said you want the review of the general idea, but still..
Jan 31 2023
One more thing.
I'm not sure what commit msg you want to use.
So as a side note, many people give in the first line a oneliner containing the module/subsystem name and a meaningful description.
So for this case, you can use the following:
nv: improve the style in one of the examples
or
libnv: improve the style in one of the examples
The diffs should be generated with the full context:
git diff -U99999
Dec 19 2022
I think this requires more explanation.
Without this define the casper will work and use standard definition instead of "secure" implementation prepared for capsicum.
This allow to build a tools for FreeBSD without capsicum/casper support - for example for rescue or bootstrap.
Simply putting this define in front of includes will break this behaviour.
Dec 8 2022
Nov 15 2022
Sorry for so late review.
Should we also add it to rc.subr(8) man page?
Nov 13 2022
Nov 11 2022
Nov 10 2022
Oct 19 2022
Should be fixed with: af3297898720af2f2ed18d18d45ea6bf50d55ef1
Oct 1 2022
Sep 30 2022
@0mp are you happy with the fixed version?
Sep 29 2022
Sep 26 2022
I don't think we treat this as a security issue.
Aug 17 2022
Aug 15 2022
Aug 1 2022
Jul 18 2022
Jul 7 2022
The change LGTM.
That said I would suggest committing this as submited by: Mike Walker, not as a co-authored as he did the heavy lifting in this change.
Jul 5 2022
Jun 27 2022
Apr 18 2022
IMHO its on point.
Please remember to bump Dd.
Mar 20 2022
Mar 19 2022
Mar 17 2022
Mar 12 2022
Ping.
Feb 18 2022
Feb 15 2022
Yeach, I totaly forgot about this part @jhb.
Feb 13 2022
Fix typo in comment, spotted by @emaste.
Style.