Page MenuHomeFreeBSD

oshogbo (Mariusz Zaborski)
User

Projects

User Details

User Since
Aug 19 2014, 3:56 PM (380 w, 2 d)

Recent Activity

Mon, Nov 22

oshogbo added a comment to D32722: libnv: read entire datagram in nvlist_recv().

Feel free to commit this.

Mon, Nov 22, 1:31 PM

Mon, Nov 15

oshogbo added a comment to D32976: Initial clean up the language in the manual pages..

Wow, thank you, @gnn, for looking at this. I appreciate that!

Mon, Nov 15, 4:17 PM

Mon, Nov 8

oshogbo committed R10:748a707fe609: libc: fix the test (authored by oshogbo).
libc: fix the test
Mon, Nov 8, 11:34 AM

Sun, Nov 7

oshogbo committed R10:597b02675751: libc: add clearenv function (authored by oshogbo).
libc: add clearenv function
Sun, Nov 7, 3:20 PM
oshogbo closed D28223: libc: add cleanenv function.
Sun, Nov 7, 3:20 PM

Wed, Nov 3

oshogbo updated subscribers of D32722: libnv: read entire datagram in nvlist_recv().

@lwhsu Is those settings ok with our tests machines?

Wed, Nov 3, 4:12 PM

Oct 29 2021

oshogbo added a comment to D32722: libnv: read entire datagram in nvlist_recv().

Could you also add test for this case?

Oct 29 2021, 9:07 AM

Oct 7 2021

oshogbo committed R10:824bbb9a4082: diff: consider two files with same inodes as identical (authored by oshogbo).
diff: consider two files with same inodes as identical
Oct 7 2021, 3:10 PM

Sep 14 2021

oshogbo added a comment to D31382: lib/libc: Fix uninitialized value in __setenv().

Oh. Right.
I didn't noticed that after realloc the memory is not cleaned.
Yes, I also would go with @delphij suggestion.

Sep 14 2021, 9:00 AM

Sep 13 2021

oshogbo committed R10:e673ac3ffbfb: libnv: Fix array unpack endianness logic (authored by sg2342_googlemail.com).
libnv: Fix array unpack endianness logic
Sep 13 2021, 7:26 PM
oshogbo accepted D31382: lib/libc: Fix uninitialized value in __setenv().

If I understand correctly, the envVars with the putenv can't be reused.
So the putenv actually is set to 0 (as we are doing calloc'ing the memory needed for envVars), and we are 0 memory when we needed.
So besides the unhappy MK_UBSAN, there are no functional changes, as well as there is no security implication.
If I'm wrong at some of these statements, please correct me.

Sep 13 2021, 6:57 PM

Aug 30 2021

oshogbo added inline comments to D20300: Introducing pdopen..
Aug 30 2021, 3:37 PM
oshogbo added inline comments to D20300: Introducing pdopen..
Aug 30 2021, 2:55 PM
oshogbo added inline comments to D31727: geom_gate: ensure readprov is null-terminated.
Aug 30 2021, 2:27 PM

Aug 27 2021

oshogbo updated the diff for D20300: Introducing pdopen..

Address @markj review.
Cover the wait issue.
Add test cases.

Aug 27 2021, 9:48 AM

Aug 21 2021

oshogbo committed R10:3a92927bb69f: bhyve: change a default address from ANY to localhost (authored by oshogbo).
bhyve: change a default address from ANY to localhost
Aug 21 2021, 5:43 PM
oshogbo closed D29607: byhve: add option to specify IP address for gdb.
Aug 21 2021, 5:43 PM
oshogbo committed R10:2cdff9918e79: byhve: add option to specify IP address for gdb (authored by oshogbo).
byhve: add option to specify IP address for gdb
Aug 21 2021, 5:43 PM

Jul 23 2021

oshogbo added inline comments to D31266: dumpon: Fix -v causing error when configuring an encrypted dump.
Jul 23 2021, 9:33 AM

Jul 9 2021

oshogbo committed R10:24c681a7f6d6: grep: fix combination of quite and count flag (authored by oshogbo).
grep: fix combination of quite and count flag
Jul 9 2021, 12:10 PM
oshogbo closed D31108: grep: fix combination of quite and count flag.
Jul 9 2021, 12:10 PM

Jul 8 2021

oshogbo requested review of D31108: grep: fix combination of quite and count flag.
Jul 8 2021, 11:45 AM

Jul 6 2021

oshogbo committed R10:eed85dd1ad31: libnv: optimize nvlist size calculation (authored by oshogbo).
libnv: optimize nvlist size calculation
Jul 6 2021, 6:27 PM
oshogbo committed R10:ddab4ee61002: libnv: fix revert (authored by oshogbo).
libnv: fix revert
Jul 6 2021, 6:27 PM
oshogbo committed R10:6c33105c1a81: libnv: fix double free (authored by oshogbo).
libnv: fix double free
Jul 6 2021, 6:27 PM
oshogbo committed R10:bc2bc8ee6e18: libnv: fix memory leaks (authored by oshogbo).
libnv: fix memory leaks
Jul 6 2021, 6:26 PM
oshogbo committed R10:dc876a5bcd46: libnv: fix memory leaks (authored by oshogbo).
libnv: fix memory leaks
Jul 6 2021, 6:26 PM
oshogbo committed R10:ff339365be13: libnv: optimize nvlist size calculation (authored by oshogbo).
libnv: optimize nvlist size calculation
Jul 6 2021, 5:54 PM
oshogbo committed R10:b907e9d9a149: libnv: fix revert (authored by oshogbo).
libnv: fix revert
Jul 6 2021, 5:54 PM
oshogbo committed R10:4c79391a7fa4: libnv: fix double free (authored by oshogbo).
libnv: fix double free
Jul 6 2021, 5:54 PM
oshogbo committed R10:f98545c7e991: libnv: fix memory leaks (authored by oshogbo).
libnv: fix memory leaks
Jul 6 2021, 5:53 PM

Jul 5 2021

oshogbo accepted D31038: rtld/tests: Avoid function name conflict with libc opendir().

We have fdopendir in libc I wonder if this won't be confusing. Maybe we should rename this to something like rtld_opendir.
But whatever name your choose this LGTM.

Jul 5 2021, 9:33 AM

Jun 24 2021

oshogbo committed R10:6ba108e52d17: rc.subr: use _pidcmd to determine pid for protect (authored by oshogbo).
rc.subr: use _pidcmd to determine pid for protect
Jun 24 2021, 6:16 PM
oshogbo closed D30367: rc.subr: use _pidcmd to determine pid for protect.
Jun 24 2021, 6:16 PM · rc
oshogbo accepted D30367: rc.subr: use _pidcmd to determine pid for protect.
Jun 24 2021, 6:12 PM · rc

Jun 18 2021

oshogbo added a comment to D26958: sockstat: Use libcasper to capsicumize.

Fixes are on haed.

Jun 18 2021, 4:13 PM
oshogbo committed R10:7ad30f58dd63: sockstat: use cap_pwd (authored by oshogbo).
sockstat: use cap_pwd
Jun 18 2021, 4:13 PM
oshogbo committed R10:bfb5947bb1e9: sockstat: fix core dump (authored by oshogbo).
sockstat: fix core dump
Jun 18 2021, 4:13 PM
oshogbo added a comment to D26958: sockstat: Use libcasper to capsicumize.

Hello Oliver,

Jun 18 2021, 10:19 AM
oshogbo committed R10:b4fe6fbab236: libcasper: add missing unistd.h (authored by oshogbo).
libcasper: add missing unistd.h
Jun 18 2021, 9:44 AM

Jun 17 2021

oshogbo added a comment to D26958: sockstat: Use libcasper to capsicumize.

Hello Oliver,

Jun 17 2021, 8:49 PM

Jun 15 2021

oshogbo committed R10:6c0a51837f4b: libcasper: fix descriptors numbers (authored by oshogbo).
libcasper: fix descriptors numbers
Jun 15 2021, 6:31 PM
oshogbo committed R10:4e2ae05c3ae8: libcasper: fix descriptors numbers (authored by oshogbo).
libcasper: fix descriptors numbers
Jun 15 2021, 6:24 PM
oshogbo committed R10:934e10b4a388: libcasper: fix descriptors numbers (authored by oshogbo).
libcasper: fix descriptors numbers
Jun 15 2021, 6:18 PM

Jun 13 2021

oshogbo updated the diff for D29607: byhve: add option to specify IP address for gdb.

Address @jhb comments (I hope).

Jun 13 2021, 6:18 PM

Jun 11 2021

oshogbo added inline comments to D30667: fix tail -f on stdin.
Jun 11 2021, 7:20 PM
oshogbo added a comment to D30667: fix tail -f on stdin.

Hym its works for me.

Jun 11 2021, 7:14 PM
oshogbo added a comment to D30667: fix tail -f on stdin.

Can you provide some more context?

Jun 11 2021, 7:02 PM
oshogbo committed R10:89d5cbb82294: libnv: optimize nvlist size calculation (authored by oshogbo).
libnv: optimize nvlist size calculation
Jun 11 2021, 3:52 PM

Jun 10 2021

oshogbo committed R10:aa310ebfba3d: libcasper: fix descriptors numbers (authored by oshogbo).
libcasper: fix descriptors numbers
Jun 10 2021, 10:42 AM

Jun 5 2021

oshogbo added a comment to D28223: libc: add cleanenv function.

@secteam ping?

Jun 5 2021, 5:00 PM

Jun 1 2021

oshogbo accepted D26958: sockstat: Use libcasper to capsicumize.

Yes. This looks go to me.

Jun 1 2021, 1:49 PM

May 22 2021

oshogbo updated the diff for D28223: libc: add cleanenv function.

Address @scf and @emaste suggestions.

May 22 2021, 7:44 PM

May 20 2021

oshogbo added inline comments to D29824: rtsold: Extend casper to support various interface operations.
May 20 2021, 9:03 AM

May 19 2021

oshogbo accepted D29824: rtsold: Extend casper to support various interface operations.

In general it's a great work.
Minor requests.

May 19 2021, 9:45 PM
oshogbo added inline comments to D28223: libc: add cleanenv function.
May 19 2021, 9:21 PM
oshogbo abandoned D29343: flopen: simplify the code.
May 19 2021, 9:19 PM

Apr 27 2021

oshogbo added a comment to D28223: libc: add cleanenv function.

@scf secteam Can I proceed with this?

Apr 27 2021, 9:24 AM

Apr 9 2021

oshogbo added inline comments to D29607: byhve: add option to specify IP address for gdb.
Apr 9 2021, 5:59 PM
oshogbo updated the diff for D29607: byhve: add option to specify IP address for gdb.

Address @jhb suggestions.

Apr 9 2021, 5:57 PM

Apr 7 2021

oshogbo committed R10:2b1d0c0087a9: fileargs: fix double caching of the same file (authored by oshogbo).
fileargs: fix double caching of the same file
Apr 7 2021, 7:18 PM
oshogbo added inline comments to D29607: byhve: add option to specify IP address for gdb.
Apr 7 2021, 7:58 AM

Apr 6 2021

oshogbo added a reviewer for D29607: byhve: add option to specify IP address for gdb: jhb.
Apr 6 2021, 3:39 PM
oshogbo requested review of D29607: byhve: add option to specify IP address for gdb.
Apr 6 2021, 3:37 PM
oshogbo added a comment to D28223: libc: add cleanenv function.

Ping?

Apr 6 2021, 10:09 AM
oshogbo accepted D24832: libcasper: Create a minimal cap_netdb service.

LGTM.
Do you have commit bit or should I commit this?

Apr 6 2021, 8:21 AM · capsicum
oshogbo accepted D29423: capsicum: Limit socket operations in capability mode.

LGTM.
I prefer this approach then forbidding whole socket syscall.

Apr 6 2021, 8:21 AM
oshogbo accepted D29556: libnv: Allow use in non-sleepable contexts.
Apr 6 2021, 8:12 AM

Apr 1 2021

oshogbo added a comment to D29523: traceroute6: Fix rights for rcvsock.

After addressing @zlei.huang_gmail.com points - LGTM.

Apr 1 2021, 10:36 AM
oshogbo added a comment to D29423: capsicum: Limit socket operations in capability mode.

Some minor notes.
Thank you for working on this.

Apr 1 2021, 10:36 AM

Mar 24 2021

oshogbo committed R10:e086aff91c24: rtld: fix the man page (authored by oshogbo).
rtld: fix the man page
Mar 24 2021, 11:51 PM
oshogbo closed D29334: rtld: introduce PRELOAD_FDS.
Mar 24 2021, 10:41 PM
oshogbo committed R10:f90218886fc8: rtld: introduce PRELOAD_FDS (authored by oshogbo).
rtld: introduce PRELOAD_FDS
Mar 24 2021, 10:41 PM
oshogbo committed R10:852a88a1d925: rtld: style nits (authored by oshogbo).
rtld: style nits
Mar 24 2021, 10:41 PM
oshogbo added a comment to D29343: flopen: simplify the code.

Thank you @kib for explanation, I will analyze this further.

Mar 24 2021, 5:34 PM

Mar 19 2021

oshogbo added reviewers for D29343: flopen: simplify the code: kib, des.
Mar 19 2021, 10:04 PM
oshogbo requested review of D29343: flopen: simplify the code.
Mar 19 2021, 10:00 PM
oshogbo added inline comments to D29334: rtld: introduce PRELOAD_FDS.
Mar 19 2021, 11:10 AM

Mar 18 2021

oshogbo committed R10:c145b7954656: zfs: bring back possibility to rewind the checkpoint from (authored by oshogbo).
zfs: bring back possibility to rewind the checkpoint from
Mar 18 2021, 11:04 PM
oshogbo committed R10:6bbca5ca3a66: zfs: bring back possibility to rewind the checkpoint from (authored by oshogbo).
zfs: bring back possibility to rewind the checkpoint from
Mar 18 2021, 9:13 PM
oshogbo added reviewers for D29334: rtld: introduce PRELOAD_FDS: markj, jonathan.
Mar 18 2021, 8:45 PM
oshogbo updated the diff for D29334: rtld: introduce PRELOAD_FDS.
Mar 18 2021, 8:43 PM
oshogbo retitled D29334: rtld: introduce PRELOAD_FDS from rtld: intrdouce PRELOAD_FDS to rtld: introduce PRELOAD_FDS.
Mar 18 2021, 8:43 PM
oshogbo requested review of D29334: rtld: introduce PRELOAD_FDS.
Mar 18 2021, 8:40 PM
oshogbo abandoned D29333: rtld: intrdouce PRELOAD_FDS.
Mar 18 2021, 8:40 PM
oshogbo requested review of D29333: rtld: intrdouce PRELOAD_FDS.
Mar 18 2021, 8:39 PM

Mar 17 2021

oshogbo added inline comments to D28223: libc: add cleanenv function.
Mar 17 2021, 10:03 PM
oshogbo updated the diff for D28223: libc: add cleanenv function.

Address scf@ suggestions.

Mar 17 2021, 10:03 PM

Mar 13 2021

oshogbo added a comment to D28223: libc: add cleanenv function.

Ping?

Mar 13 2021, 12:07 PM
oshogbo committed R10:653ed678c703: zfs: bring back possibility to rewind the checkpoint from (authored by oshogbo).
zfs: bring back possibility to rewind the checkpoint from
Mar 13 2021, 12:01 PM

Mar 1 2021

oshogbo committed R10:05b267e23257: service: respect nojailvnet keyword (authored by oshogbo).
service: respect nojailvnet keyword
Mar 1 2021, 10:36 PM

Feb 16 2021

oshogbo added inline comments to D28699: lookup: in capability mode, silently strengthen BENEATH to RBENEATH.
Feb 16 2021, 6:34 PM
oshogbo added a comment to D28698: lookup: fix inverted condition for test to allow dotdot..

Ups sorry I just wanted to comment it without accepting it.

Feb 16 2021, 6:23 PM
oshogbo accepted D28698: lookup: fix inverted condition for test to allow dotdot..

Shouldn't we return here a ECAPMODE ?
In capability mode there isn't any way where dot dot is valid right?

Feb 16 2021, 6:22 PM

Jan 26 2021

oshogbo accepted D28341: Do not run cap_fileargs tests if build without capsicum capabilities.
Jan 26 2021, 6:29 PM

Jan 21 2021

oshogbo added a comment to D28223: libc: add cleanenv function.

@0mp Thanks I addressed that.

Jan 21 2021, 5:35 PM
oshogbo updated the diff for D28223: libc: add cleanenv function.

Update diff.

Jan 21 2021, 5:33 PM

Jan 20 2021

oshogbo committed R10:0614d7396798: cat: style nits (authored by oshogbo).
cat: style nits
Jan 20 2021, 5:48 PM

Jan 18 2021

oshogbo added a reviewer for D28223: libc: add cleanenv function: secteam.
Jan 18 2021, 6:19 PM
oshogbo updated the diff for D28223: libc: add cleanenv function.

Thank you @kib for hints!

Jan 18 2021, 6:19 PM