Sorry for so late review.
Should we also add it to rc.subr(8) man page?

Should be fixed with: af3297898720af2f2ed18d18d45ea6bf50d55ef1

@0mp are you happy with the fixed version?

I don't think we treat this as a security issue.

The change LGTM.
That said I would suggest committing this as submited by: Mike Walker, not as a co-authored as he did the heavy lifting in this change.

IMHO its on point.
Please remember to bump Dd.

Ping.

Yeach, I totaly forgot about this part @jhb.

Fix typo in comment, spotted by @emaste.

Style.

LGTM.

Thank you @tagattie !

Thank you @markj

@tagattie any plan to review this?

Pong @swills . Do you plan yo commit this change?

Feel free to commit this.

Wow, thank you, @gnn, for looking at this. I appreciate that!

@lwhsu Is those settings ok with our tests machines?

Could you also add test for this case?

Oh. Right.
I didn't noticed that after realloc the memory is not cleaned.
Yes, I also would go with @delphij suggestion.

If I understand correctly, the envVars with the putenv can't be reused.
So the putenv actually is set to 0 (as we are doing calloc'ing the memory needed for envVars), and we are 0 memory when we needed.
So besides the unhappy MK_UBSAN, there are no functional changes, as well as there is no security implication.
If I'm wrong at some of these statements, please correct me.

Address @markj review.
Cover the wait issue.
Add test cases.

We have fdopendir in libc I wonder if this won't be confusing. Maybe we should rename this to something like rtld_opendir.
But whatever name your choose this LGTM.

Fixes are on haed.

Hello Oliver,

Hello Oliver,

Address @jhb comments (I hope).

Hym its works for me.

Can you provide some more context?

@secteam ping?