Page MenuHomeFreeBSD

oshogbo (Mariusz Zaborski)
User

Projects

User Details

User Since
Aug 19 2014, 3:56 PM (474 w, 3 d)

Recent Activity

Wed, Sep 6

oshogbo accepted D41761: libcasper: reference system.fileargs service.
Wed, Sep 6, 1:50 PM

Aug 7 2023

oshogbo committed rG2ea65afbd11d: md5: extend capabilites (authored by oshogbo).
md5: extend capabilites
Aug 7 2023, 12:19 PM
oshogbo closed D41348: md5: extend capabilites.
Aug 7 2023, 12:19 PM
oshogbo requested review of D41348: md5: extend capabilites.
Aug 7 2023, 11:11 AM

May 29 2023

oshogbo committed rG097e721ff4f2: geli: fix typo (authored by oshogbo).
geli: fix typo
May 29 2023, 3:43 PM

May 15 2023

oshogbo added a comment to D39994: libutil: move ftime to libutil.

@kib

May 15 2023, 11:09 AM
oshogbo updated the diff for D39994: libutil: move ftime to libutil.

Yes, thats make sense. Thank you.

May 15 2023, 9:04 AM
oshogbo committed rG06db6a9dce81: geli: fix typo (authored by oshogbo).
geli: fix typo
May 15 2023, 8:47 AM

May 12 2023

oshogbo updated the diff for D39994: libutil: move ftime to libutil.

kib@ thank you. Moved to libuitl.

May 12 2023, 2:27 PM
oshogbo updated the diff for D39994: libutil: move ftime to libutil.

Move to libuitl

May 12 2023, 2:05 PM
oshogbo updated the summary of D39994: libutil: move ftime to libutil.
May 12 2023, 2:05 PM
oshogbo retitled D39994: libutil: move ftime to libutil from libc: move ftime to libc to libutil: move ftime to libutil.
May 12 2023, 2:05 PM

May 7 2023

oshogbo added a reviewer for D39994: libutil: move ftime to libutil: kib.
May 7 2023, 11:47 AM
oshogbo updated the summary of D39994: libutil: move ftime to libutil.
May 7 2023, 11:47 AM
oshogbo updated the diff for D39994: libutil: move ftime to libutil.

Update description.

May 7 2023, 11:45 AM
oshogbo requested review of D39994: libutil: move ftime to libutil.
May 7 2023, 11:39 AM
oshogbo closed D39989: Document when the namespace was created.
May 7 2023, 9:50 AM
oshogbo committed rG95950880ade0: libc: document when the namespace was created (authored by oshogbo).
libc: document when the namespace was created
May 7 2023, 9:50 AM

May 6 2023

oshogbo updated the diff for D39989: Document when the namespace was created.

Add more context to the file.

May 6 2023, 2:32 PM
oshogbo requested review of D39989: Document when the namespace was created.
May 6 2023, 2:30 PM

May 2 2023

oshogbo committed rG834fdebb56fb: mpr: don't use hardcoded value in debug branch (authored by oshogbo).
mpr: don't use hardcoded value in debug branch
May 2 2023, 12:23 PM
oshogbo committed rGe7a3a08febd0: mpr: fix copying of event_mask (authored by oshogbo).
mpr: fix copying of event_mask
May 2 2023, 12:23 PM
oshogbo committed rG485005801104: mpr: don't use hardcoded value in debug branch (authored by oshogbo).
mpr: don't use hardcoded value in debug branch
May 2 2023, 12:21 PM
oshogbo committed rG2de69df6f398: mpr: fix copying of event_mask (authored by oshogbo).
mpr: fix copying of event_mask
May 2 2023, 12:21 PM

Apr 27 2023

oshogbo accepted D39242: cap_net tests: Skip tests if there is no connectivity.

Sorry for the delay.

Apr 27 2023, 7:53 AM

Apr 26 2023

oshogbo accepted D39829: Allow vfork(2) in capsicum(4) capability mode.
Apr 26 2023, 1:29 PM

Apr 21 2023

oshogbo committed rG444c6615459e: mpr: don't use hardcoded value in debug branch (authored by oshogbo).
mpr: don't use hardcoded value in debug branch
Apr 21 2023, 8:03 AM
oshogbo committed rGea6597c38c77: mpr: fix copying of event_mask (authored by oshogbo).
mpr: fix copying of event_mask
Apr 21 2023, 8:03 AM
oshogbo closed D39562: mpr: fix copying of event_mask.
Apr 21 2023, 8:02 AM

Apr 17 2023

oshogbo added a comment to D39562: mpr: fix copying of event_mask.

@imp Have you had a chance to look into this?

Apr 17 2023, 4:02 PM
oshogbo accepted D39613: zfs: Add vfs.zfs.bclone_enabled sysctl..
Apr 17 2023, 10:27 AM

Apr 13 2023

oshogbo added inline comments to D39562: mpr: fix copying of event_mask.
Apr 13 2023, 7:10 PM
oshogbo updated the diff for D39562: mpr: fix copying of event_mask.

Use sizeof.

Apr 13 2023, 7:09 PM
oshogbo added a reviewer for D39562: mpr: fix copying of event_mask: thj.
Apr 13 2023, 6:45 PM
oshogbo updated the summary of D39562: mpr: fix copying of event_mask.
Apr 13 2023, 6:44 PM
oshogbo updated the diff for D39562: mpr: fix copying of event_mask.

Fix description

Apr 13 2023, 6:43 PM
oshogbo retitled D39562: mpr: fix copying of event_mask from mpr: fix conversion to big endian to mpr: fix copying of event_mask.
Apr 13 2023, 6:43 PM
oshogbo requested review of D39562: mpr: fix copying of event_mask.
Apr 13 2023, 6:40 PM

Apr 4 2023

oshogbo accepted D39347: cap_dns, cap_net: fix host and service buffer handling.

LGTM.
Nice catch.

Apr 4 2023, 6:18 PM

Mar 24 2023

oshogbo accepted D39222: Add /lib/capser to the rpath for anything linked against libcasper helpers..

I don't mind also moving them simply to /lib.

Mar 24 2023, 10:52 AM
oshogbo added a comment to D39245: libcasper: Move helper libraries from /lib/casper to /lib..

The idea for a separate directory was that we would have many libcasper helpers, and the /lib will get crowdy.
The Casper libraries are quite limited in number so I'm not sure if it's worth it to keep a separate directory here.

Mar 24 2023, 10:51 AM
oshogbo accepted D39241: cap_dns tests: Convert to ATF, avoid failing when lookups don't resolve.
Mar 24 2023, 10:48 AM
oshogbo added inline comments to D39242: cap_net tests: Skip tests if there is no connectivity.
Mar 24 2023, 10:47 AM

Feb 14 2023

oshogbo committed rGf09f828a41d8: ahci: increase timout (authored by oshogbo).
ahci: increase timout
Feb 14 2023, 11:18 PM

Feb 13 2023

oshogbo committed rG65bab39e140f: ahci: increase timout (authored by oshogbo).
ahci: increase timout
Feb 13 2023, 11:45 PM

Feb 10 2023

oshogbo committed rG346483b1f104: ahci: increase timout (authored by oshogbo).
ahci: increase timout
Feb 10 2023, 4:10 PM
oshogbo closed D38413: ahci: increase timout.
Feb 10 2023, 4:10 PM
oshogbo updated the diff for D38413: ahci: increase timout.
Feb 10 2023, 12:35 AM

Feb 8 2023

oshogbo added inline comments to D38413: ahci: increase timout.
Feb 8 2023, 2:14 PM
oshogbo updated the diff for D38413: ahci: increase timout.
Feb 8 2023, 2:14 PM

Feb 7 2023

oshogbo updated the diff for D38413: ahci: increase timout.
Feb 7 2023, 2:09 PM
oshogbo updated the diff for D38413: ahci: increase timout.
Feb 7 2023, 2:08 PM
oshogbo updated the summary of D38413: ahci: increase timout.
Feb 7 2023, 12:39 PM
oshogbo requested review of D38413: ahci: increase timout.
Feb 7 2023, 12:37 PM

Feb 3 2023

oshogbo added a comment to D38351: [RFC/Proposal] Mechanism for in-kernel AT_FDCWD substitution with provided FD for oblivious sandboxing with Capsicum.

Hym, sorry, last time it showed me that you almost added the whole sys/kern/kern_procctl.c. I guess it was some glitch in phabricator.

Feb 3 2023, 6:50 PM

Feb 2 2023

oshogbo added a comment to D38351: [RFC/Proposal] Mechanism for in-kernel AT_FDCWD substitution with provided FD for oblivious sandboxing with Capsicum.

Are you sure this patch is correctly generated?
I know that you said you want the review of the general idea, but still..

Feb 2 2023, 10:13 AM

Jan 31 2023

oshogbo added a comment to D38287: Improve the style in one of the examples..

One more thing.
I'm not sure what commit msg you want to use.
So as a side note, many people give in the first line a oneliner containing the module/subsystem name and a meaningful description.
So for this case, you can use the following:

nv: improve the style in one of the examples

or

libnv: improve the style in one of the examples
Jan 31 2023, 12:59 AM
oshogbo accepted D38288: Remove single-use variable..

LGTM.

Jan 31 2023, 12:44 AM
oshogbo added a comment to D38287: Improve the style in one of the examples..

The diffs should be generated with the full context:

git diff -U99999
Jan 31 2023, 12:43 AM
oshogbo accepted D38287: Improve the style in one of the examples..
Jan 31 2023, 12:43 AM

Dec 19 2022

oshogbo added a comment to D37752: Document the need to define WITH_CASPER when using casper services.

I think this requires more explanation.
Without this define the casper will work and use standard definition instead of "secure" implementation prepared for capsicum.
This allow to build a tools for FreeBSD without capsicum/casper support - for example for rescue or bootstrap.
Simply putting this define in front of includes will break this behaviour.

Dec 19 2022, 11:39 PM

Dec 8 2022

oshogbo accepted D37586: [skip ci] improvements to cap_sysctl.3.
Dec 8 2022, 7:30 PM

Nov 15 2022

oshogbo added a comment to D36259: rc: also run NAME_setup on NAME_reload.

Sorry for so late review.
Should we also add it to rc.subr(8) man page?

Nov 15 2022, 7:29 PM · rc

Nov 13 2022

oshogbo committed rG134b047d3e93: logger: fix builds without casper (authored by oshogbo).
logger: fix builds without casper
Nov 13 2022, 7:51 PM

Nov 11 2022

oshogbo closed D36210: rc: add a manual entry for ${name}_setup.
Nov 11 2022, 9:24 PM · rc
oshogbo committed rGb05e7e702293: rc: add a manual entry for ${name}_setup (authored by franco_opnsense.org).
rc: add a manual entry for ${name}_setup
Nov 11 2022, 9:24 PM

Nov 10 2022

oshogbo accepted D36402: Remove dead code in the cscope target.
Nov 10 2022, 10:55 AM

Oct 19 2022

oshogbo added a comment to D23744: Added casper service to logger.

Should be fixed with: af3297898720af2f2ed18d18d45ea6bf50d55ef1

Oct 19 2022, 2:04 PM
oshogbo committed rGaf3297898720: logger: fix builds without casper (authored by oshogbo).
logger: fix builds without casper
Oct 19 2022, 2:03 PM

Oct 1 2022

oshogbo committed rG6da5e5d649ba: seq: fix style nits (authored by oshogbo).
seq: fix style nits
Oct 1 2022, 10:09 AM
oshogbo committed rG94c4f663bab5: seq: fix potential NULL ptr reference (authored by oshogbo).
seq: fix potential NULL ptr reference
Oct 1 2022, 10:09 AM

Sep 30 2022

oshogbo added a comment to D36210: rc: add a manual entry for ${name}_setup.

@0mp are you happy with the fixed version?

Sep 30 2022, 12:15 PM · rc

Sep 29 2022

oshogbo committed rG26573e2c7f4b: cap_netdb: Fix description style (authored by oshogbo).
cap_netdb: Fix description style
Sep 29 2022, 5:53 PM
oshogbo committed rGfacd6b58d5f8: libcapser: Add reference to cap_netdb (authored by oshogbo).
libcapser: Add reference to cap_netdb
Sep 29 2022, 5:52 PM

Sep 26 2022

oshogbo accepted D36709: geom_part: Fix potential integer overflow when checking size of the table.

I don't think we treat this as a security issue.

Sep 26 2022, 10:43 AM

Aug 17 2022

oshogbo added a reviewer for D36210: rc: add a manual entry for ${name}_setup: cperciva.
Aug 17 2022, 11:34 AM · rc

Aug 15 2022

oshogbo committed rGc9be47b34dd8: rc: add ${name}_setup script support (authored by franco_opnsense.org).
rc: add ${name}_setup script support
Aug 15 2022, 2:43 PM

Aug 1 2022

oshogbo accepted D36006: rc: add ${name}_setup script support.
Aug 1 2022, 9:42 AM · rc

Jul 18 2022

oshogbo added inline comments to D35823: Upgrade FreeBSD features page.
Jul 18 2022, 9:01 AM

Jul 7 2022

oshogbo accepted D35747: rc.subr: Make sure oomprotect protects existing children.

The change LGTM.
That said I would suggest committing this as submited by: Mike Walker, not as a co-authored as he did the heavy lifting in this change.

Jul 7 2022, 9:40 PM

Jul 5 2022

oshogbo added inline comments to D35574: xargs: terminate if line replacement cannot be constructed.
Jul 5 2022, 3:16 PM

Jun 27 2022

oshogbo added inline comments to D35574: xargs: terminate if line replacement cannot be constructed.
Jun 27 2022, 2:33 PM

Apr 18 2022

oshogbo accepted D34945: capsicum: briefly describe capabilities in man page.

IMHO its on point.
Please remember to bump Dd.

Apr 18 2022, 8:52 PM

Mar 20 2022

oshogbo committed rG1e9ce60a6d75: cap_fileargs: silence warnings of unused variable (authored by oshogbo).
cap_fileargs: silence warnings of unused variable
Mar 20 2022, 10:24 AM

Mar 19 2022

oshogbo committed rGe7023af434e2: touch: don't leak descriptor if fstat(2) fails (authored by oshogbo).
touch: don't leak descriptor if fstat(2) fails
Mar 19 2022, 1:18 PM

Mar 17 2022

oshogbo added inline comments to D34547: bhyve - snapshot capsicum integration[Part 1].
Mar 17 2022, 3:46 PM
oshogbo added inline comments to D34547: bhyve - snapshot capsicum integration[Part 1].
Mar 17 2022, 3:07 PM
oshogbo added inline comments to D34547: bhyve - snapshot capsicum integration[Part 1].
Mar 17 2022, 3:02 PM

Mar 12 2022

oshogbo added a comment to D34263: etcupdate: check passwords after resolving conflicts.

Ping.

Mar 12 2022, 10:52 AM
oshogbo committed rGcb54c500d0e1: touch: don't leak descriptor if fstat(2) fails (authored by oshogbo).
touch: don't leak descriptor if fstat(2) fails
Mar 12 2022, 10:44 AM
oshogbo committed rG2b0d4ae9ce61: cap_net: plug memory leak (authored by oshogbo).
cap_net: plug memory leak
Mar 12 2022, 10:30 AM
oshogbo committed rG2c1ade6cd608: cap_net: fix verification of bind permission (authored by oshogbo).
cap_net: fix verification of bind permission
Mar 12 2022, 10:30 AM
oshogbo committed R9:d1b85b5ab578: Update a PGP key for def. (authored by def).
Update a PGP key for def.
Mar 12 2022, 10:23 AM

Feb 18 2022

oshogbo added inline comments to D34263: etcupdate: check passwords after resolving conflicts.
Feb 18 2022, 5:27 PM
oshogbo added inline comments to D34263: etcupdate: check passwords after resolving conflicts.
Feb 18 2022, 5:24 PM

Feb 15 2022

oshogbo updated the diff for D34263: etcupdate: check passwords after resolving conflicts.

Yeach, I totaly forgot about this part @jhb.

Feb 15 2022, 9:07 AM

Feb 13 2022

oshogbo added inline comments to D34263: etcupdate: check passwords after resolving conflicts.
Feb 13 2022, 10:23 PM
oshogbo updated the diff for D34263: etcupdate: check passwords after resolving conflicts.

Fix typo in comment, spotted by @emaste.

Feb 13 2022, 10:23 PM
oshogbo added reviewers for D34263: etcupdate: check passwords after resolving conflicts: emaste, markj, jhb.
Feb 13 2022, 9:08 PM
oshogbo updated the diff for D34263: etcupdate: check passwords after resolving conflicts.

Style.

Feb 13 2022, 9:06 PM