capsicumUmbrella
ActivePublic

Recent Activity

Sun, Sep 17

oshogbo added inline comments to D8753: Introduce libcaspermock.
Sun, Sep 17, 10:14 AM · capsicum
oshogbo updated the diff for D8753: Introduce libcaspermock.
Sun, Sep 17, 10:14 AM · capsicum

Fri, Aug 25

emaste added inline comments to D8753: Introduce libcaspermock.
Fri, Aug 25, 1:42 PM · capsicum

Aug 16 2017

oshogbo added inline comments to D8753: Introduce libcaspermock.
Aug 16 2017, 6:42 PM · capsicum
oshogbo updated the diff for D8753: Introduce libcaspermock.

Update with -U9999.

Aug 16 2017, 6:40 PM · capsicum

Aug 15 2017

cem accepted D8754: Convert ping to use libcaspermock when Casper is disabled..
Aug 15 2017, 6:21 PM · capsicum
cem added a comment to D8753: Introduce libcaspermock.

Would you please upload a diff with full context (-U9999)? Thanks.

Aug 15 2017, 6:17 PM · capsicum

Aug 10 2017

oshogbo updated the diff for D8754: Convert ping to use libcaspermock when Casper is disabled..

Update to new libcasper version.

Aug 10 2017, 5:42 PM · capsicum
oshogbo updated the diff for D8753: Introduce libcaspermock.

Hi Guys :)

Aug 10 2017, 5:41 PM · capsicum

Jul 8 2017

lwhsu added a watcher for capsicum: lwhsu.
Jul 8 2017, 11:11 PM

Feb 18 2017

bkidney_briankidney.ca added a watcher for capsicum: bkidney_briankidney.ca.
Feb 18 2017, 12:52 AM

Jan 20 2017

tommi.pernila_iki.fi added a watcher for capsicum: tommi.pernila_iki.fi.
Jan 20 2017, 12:08 PM

Dec 16 2016

ed added a comment to D8753: Introduce libcaspermock.

Maybe what I'm about to say is blasphemy in our circles, but it looks like this tries to solve a problem that an object oriented programming language with virtual functions (C++) could easily solve. libcasper's header file would provide declarations for abstract base classes for all sorts of handles. Then there are two implementations of these classes: one that acts as a no-op and one that is actually built on top of Capsicum. That way there is no need to resort to linker tricks.

Dec 16 2016, 9:27 PM · capsicum

Dec 15 2016

bapt added a comment to D8753: Introduce libcaspermock.

I don't really much like this approach, plus there is a high risk to have libcaspermock and libcasper out of sync

Dec 15 2016, 10:29 PM · capsicum

Dec 12 2016

robak closed D8543: Capsicumise dd by committing rS309921: Fix regression when stdin/out/err fds are are overridden by shell..
Dec 12 2016, 6:56 PM · capsicum
kib closed D8746: Enable lookup_cap_dotdot and lookup_cap_dotdot_nonlocal by default. by committing rS309887: Enable lookup_cap_dotdot and lookup_cap_dotdot_nonlocal..
Dec 12 2016, 11:12 AM · capsicum
ngie accepted D8543: Capsicumise dd.

The changes proposed seem ok, in so long as it addresses the regression I reported on svn-src-all@.

Dec 12 2016, 9:18 AM · capsicum
ngie reopened D8543: Capsicumise dd.
Dec 12 2016, 9:17 AM · capsicum
robak added a comment to D8543: Capsicumise dd.

@ngie Thoughts? I'd like to commit this and move on to other things, so review/approval is highly appreciated.

Dec 12 2016, 9:06 AM · capsicum
cem added a comment to D8753: Introduce libcaspermock.

The only situation I can think of where you would like to have two libraries is when you would install something from ports which you don't want to use Casper and your base system is using Casper.

Dec 12 2016, 7:29 AM · capsicum
oshogbo added a comment to D8753: Introduce libcaspermock.

The behavior of few functions are a little bit different libcasper and libcaspermock but this still could be merged somehow.
The only situation I can think of where you would like to have two libraries is when you would install something from ports which you don't want to use Casper and your base system is using Casper.

Dec 12 2016, 7:20 AM · capsicum
cem added a comment to D8753: Introduce libcaspermock.

Why do we need a separate library for this? Why not just turn MK_CASPER=no into the equivalent of cap_enable() -> false?

Dec 12 2016, 2:35 AM · capsicum
cem added inline comments to D8754: Convert ping to use libcaspermock when Casper is disabled..
Dec 12 2016, 2:32 AM · capsicum

Dec 11 2016

oshogbo updated D8753: Introduce libcaspermock.
Dec 11 2016, 11:54 PM · capsicum
oshogbo added a comment to D8753: Introduce libcaspermock.

Example of usage: https://reviews.freebsd.org/D8754

Dec 11 2016, 11:53 PM · capsicum
oshogbo added a comment to D8754: Convert ping to use libcaspermock when Casper is disabled..
Dec 11 2016, 11:52 PM · capsicum
oshogbo retitled D8754: Convert ping to use libcaspermock when Casper is disabled. from to Convert ping to use libcaspermock when Casper is disabled..
Dec 11 2016, 11:52 PM · capsicum
oshogbo retitled D8753: Introduce libcaspermock from to Introduce libcaspermock.
Dec 11 2016, 11:50 PM · capsicum
cem accepted D8746: Enable lookup_cap_dotdot and lookup_cap_dotdot_nonlocal by default..
Dec 11 2016, 6:38 PM · capsicum
kib added inline comments to D8746: Enable lookup_cap_dotdot and lookup_cap_dotdot_nonlocal by default..
Dec 11 2016, 6:23 PM · capsicum
cem added a comment to D8746: Enable lookup_cap_dotdot and lookup_cap_dotdot_nonlocal by default..
In D8746#181220, @cem wrote:

For local dotdot lookups in capsicum mode, I think it will be very easy to add some unit tests confirming correct behavior.

Dec 11 2016, 4:08 AM · capsicum
cem added a comment to D8746: Enable lookup_cap_dotdot and lookup_cap_dotdot_nonlocal by default..

For local dotdot lookups in capsicum mode, I think it will be very easy to add some unit tests confirming correct behavior.

Dec 11 2016, 3:16 AM · capsicum

Dec 10 2016

cem added inline comments to D8746: Enable lookup_cap_dotdot and lookup_cap_dotdot_nonlocal by default..
Dec 10 2016, 10:08 PM · capsicum
pawel.biernacki-gmail.com updated the diff for D8543: Capsicumise dd.

Fix regression when stdin/out/err fds are are overridden by shell.
Found by Kyua tests.

Dec 10 2016, 2:57 PM · capsicum
kib retitled D8746: Enable lookup_cap_dotdot and lookup_cap_dotdot_nonlocal by default. from to Enable lookup_cap_dotdot and lookup_cap_dotdot_nonlocal by default..
Dec 10 2016, 10:10 AM · capsicum

Dec 9 2016

robak closed D8543: Capsicumise dd by committing rS309735: Capsicum support for dd(1).
Dec 9 2016, 2:51 PM · capsicum
oshogbo accepted D8543: Capsicumise dd.
Dec 9 2016, 2:24 PM · capsicum
robak added a comment to D8543: Capsicumise dd.

Guys, are we happy with the state of things? I am keen to commit it, given relevant approval is provided.

Dec 9 2016, 1:37 PM · capsicum

Dec 7 2016

pawel.biernacki-gmail.com updated the diff for D8543: Capsicumise dd.

Update diff with one that survived building head@r309672:

  1. buildword && buildkernel on FreeBSD 10.3-R i386
  2. universe on FreeBSD 11.0-R amd64
Dec 7 2016, 10:52 PM · capsicum

Dec 6 2016

imp accepted D8543: Capsicumise dd.

Should have ticked 'accept'

Dec 6 2016, 10:24 PM · capsicum
imp added a comment to D8543: Capsicumise dd.

Since dd was removed from bootstrap in 309412, can this be recommitted?

Dec 6 2016, 10:24 PM · capsicum
pawel.biernacki-gmail.com added a comment to D8543: Capsicumise dd.

Since dd was removed from bootstrap in 309412, can this be recommitted?

Dec 6 2016, 6:41 PM · capsicum

Nov 21 2016

pawel.biernacki-gmail.com added a comment to D8543: Capsicumise dd.

As I see libcapsicum is header only https://svnweb.freebsd.org/base/head/lib/libcapsicum/Makefile?revision=306726&view=markup.
The breakage was obviously caused by lack of that header in installed system older than 12-C.

Nov 21 2016, 8:34 PM · capsicum
imp added a comment to D8543: Capsicumise dd.

See https://reviews.freebsd.org/D8605 for one possible resolution

Nov 21 2016, 7:43 PM · capsicum
imp requested changes to D8543: Capsicumise dd.

I think we should have a fake libcapiscim that's all defeined as no-op success functions and add that to libegacy. We don't need to install the full libcapsicim and there's ordering issues trying to do so.

Nov 21 2016, 7:36 PM · capsicum
oshogbo added a comment to D8543: Capsicumise dd.

Thanks for you work, but I like more your previus patch :)
So I would like to fix the problem with that patch in a little different meaner basically install libcapsicum.
I will do that today, and replay your patch.

Nov 21 2016, 12:49 PM · capsicum
robak added a reviewer for D8543: Capsicumise dd: adrian.
Nov 21 2016, 12:23 PM · capsicum
robak reopened D8543: Capsicumise dd.

Reopening due to dd/build toolchain issues.

Nov 21 2016, 12:18 PM · capsicum
pawel.biernacki-gmail.com updated the diff for D8543: Capsicumise dd.

Make it compile on older releases as dd is part of bootstrap and pre 12-C don't have capsicum_helpers.h installed.

Nov 21 2016, 12:06 PM · capsicum

Nov 18 2016

robak closed D8543: Capsicumise dd by committing rS308810: Capsicum support for dd(1).
Nov 18 2016, 9:10 PM · capsicum