Page MenuHomeFreeBSD

def (Konrad Witaszczyk)
User

Projects

User Details

User Since
Sep 22 2014, 7:39 PM (427 w, 3 d)

Recent Activity

Tue, Nov 15

def added a comment to D37359: Always cast vop_F_args to vop_generic_args.
In D37359#849134, @kib wrote:

I believe all uses of &ap->a_gen are mine, and the casts are historic.
Isn't it more reliable to avoid cast and explicitly take the address of the generic member? Either case depends on the generic being the first member of the vop_arg struct for now.

Anyway, I am curious about your choice of the cast, Is it due to the calculated number of each case in the source?

Tue, Nov 15, 12:44 PM

Fri, Nov 11

def committed rGf0d122573451: Remove dead code in the cscope target (authored by def).
Remove dead code in the cscope target
Fri, Nov 11, 3:55 PM
def closed D36402: Remove dead code in the cscope target.
Fri, Nov 11, 3:54 PM
def added inline comments to D36402: Remove dead code in the cscope target.
Fri, Nov 11, 1:10 PM
def updated the diff for D36402: Remove dead code in the cscope target.

Remove the style change.

Fri, Nov 11, 1:09 PM
def added a reviewer for D37359: Always cast vop_F_args to vop_generic_args: jrtc27.
Fri, Nov 11, 1:07 PM
def added reviewers for D37359: Always cast vop_F_args to vop_generic_args: jhb, kib, oshogbo.
Fri, Nov 11, 1:06 PM
def requested review of D37359: Always cast vop_F_args to vop_generic_args.
Fri, Nov 11, 1:05 PM

Thu, Nov 10

def added a comment to D36402: Remove dead code in the cscope target.
In D36402#836213, @jhb wrote:

Hmm, does cscope fail because the directory name doesn't exist? (I confess to always using ALL_ARCH=yes myself)

Thu, Nov 10, 10:53 AM

Sep 9 2022

def edited reviewers for D36402: Remove dead code in the cscope target, added: oshogbo; removed: pjd.
Sep 9 2022, 2:27 PM

Aug 31 2022

def added a reviewer for D36402: Remove dead code in the cscope target: pjd.
Aug 31 2022, 4:39 PM
def updated the summary of D36402: Remove dead code in the cscope target.
Aug 31 2022, 11:34 AM
def added reviewers for D36402: Remove dead code in the cscope target: imp, jhb.
Aug 31 2022, 11:30 AM
def requested review of D36402: Remove dead code in the cscope target.
Aug 31 2022, 11:29 AM

Apr 10 2022

def added inline comments to D34338: textproc/libxml2: Update to 2.9.13 and migrate to CMake.
Apr 10 2022, 3:05 PM

Aug 26 2018

def added inline comments to D16900: Refactor crashinfo(8) script before extending its functionality..
Aug 26 2018, 11:07 PM
def updated the diff for D16900: Refactor crashinfo(8) script before extending its functionality..

This update fixes typos, style and changes die() to write messages to stderr.

Aug 26 2018, 11:07 PM

Aug 25 2018

def updated the summary of D16900: Refactor crashinfo(8) script before extending its functionality..
Aug 25 2018, 3:03 PM
def created D16900: Refactor crashinfo(8) script before extending its functionality..
Aug 25 2018, 3:00 PM

Jan 29 2018

def committed rS328535: Fix misspelling of encryptedcore..
Fix misspelling of encryptedcore.
Jan 29 2018, 9:21 AM

Aug 6 2017

def accepted D11603: Shift some of the EKCD funcs around to keep them grouped together..
Aug 6 2017, 3:51 PM
def accepted D11584: Factor out common kerneldump code into dump_start()/dump_finish()..
Aug 6 2017, 3:50 PM

Aug 3 2017

def added a comment to D11722: Move dump offset tracking into MI code..

I'm using a script to test kernel dumps in bhyve. It exercises combinations of minidumps vs. full dumps, compression, encryption, and dump device sector size.

Aug 3 2017, 11:26 AM
def accepted D11647: Remove some unneeded subroutines for padding writes to dump devices..
Aug 3 2017, 9:43 AM
def added inline comments to D11603: Shift some of the EKCD funcs around to keep them grouped together..
Aug 3 2017, 9:26 AM
def added inline comments to D11584: Factor out common kerneldump code into dump_start()/dump_finish()..
Aug 3 2017, 9:22 AM

Aug 2 2017

def added inline comments to D11603: Shift some of the EKCD funcs around to keep them grouped together..
Aug 2 2017, 3:56 PM
def added inline comments to D11584: Factor out common kerneldump code into dump_start()/dump_finish()..
Aug 2 2017, 3:06 PM

Jul 31 2017

def added inline comments to D11584: Factor out common kerneldump code into dump_start()/dump_finish()..
Jul 31 2017, 8:15 PM

Feb 8 2017

def committed rS313459: Don't decrypt a core if a vmcore file already exists by default..
Don't decrypt a core if a vmcore file already exists by default.
Feb 8 2017, 11:17 PM

Feb 4 2017

def committed rS313195: Fix bugs found by Coverity in decryptcore(8) and savecore(8):.
Fix bugs found by Coverity in decryptcore(8) and savecore(8):
Feb 4 2017, 2:10 PM

Dec 10 2016

def committed rS309818: Add support for encrypted kernel crash dumps..
Add support for encrypted kernel crash dumps.
Dec 10 2016, 4:21 PM
def closed D4712: Encrypted kernel crash dumps. by committing rS309818: Add support for encrypted kernel crash dumps..
Dec 10 2016, 4:21 PM

Nov 14 2016

def committed rS308641: Move text dump version as it's not an architecture version..
Move text dump version as it's not an architecture version.
Nov 14 2016, 12:56 PM

Nov 12 2016

def committed rS308576: Add myself (def) as a src committer and pjd as my mentor..
Add myself (def) as a src committer and pjd as my mentor.
Nov 12 2016, 6:04 PM
def committed rD49656: Add myself (def) as a src committer..
Add myself (def) as a src committer.
Nov 12 2016, 6:02 PM

Aug 16 2016

def added inline comments to D4712: Encrypted kernel crash dumps..
Aug 16 2016, 12:12 PM
def updated the diff for D4712: Encrypted kernel crash dumps..

This revision fixes alignment of the kdc_dumpkey member of the kerneldumpcrypto structure and uses roundup2 macro to round a kernel dump key size.

Aug 16 2016, 12:10 PM

Aug 15 2016

def added inline comments to D4712: Encrypted kernel crash dumps..
Aug 15 2016, 2:08 PM
def updated the diff for D4712: Encrypted kernel crash dumps..

The patch was updated to fix two problems:

  • Use a packed structure instead of writing a kernel dump key structure byte per byte;
  • Allocate require memory using malloc(9) when it's safe to do that which is during a dump device setup.
Aug 15 2016, 2:06 PM

Jul 31 2016

def added inline comments to D4712: Encrypted kernel crash dumps..
Jul 31 2016, 8:44 PM
def added inline comments to D4712: Encrypted kernel crash dumps..
Jul 31 2016, 7:40 PM
def updated the diff for D4712: Encrypted kernel crash dumps..

I've merged the changes from HEAD. The current patch is against r303588 [1]. The main changes include:

  • ambrisko submitted a patch to write crash dumps on dump devices with a block size other than 512B. EKCD should be compatible with these changes now;
  • DIOCSKERNELDUMP_FREEBSD10 became DIOCSKERNELDUMP_FREEBSD11 as we already have FreeBSD 12.0-CURRENT;
  • DIOCSKERNELDUMP ioctl has a new number as a new DIOCZONECMD ioctl was introduced in [3].
Jul 31 2016, 7:28 PM

Apr 14 2016

def added reviewers for D4712: Encrypted kernel crash dumps.: emaste, cem.
Apr 14 2016, 8:28 PM
def added a comment to D4712: Encrypted kernel crash dumps..

Thanks for the review. I sent some replies to the inline comments.

Apr 14 2016, 8:27 PM
def updated the diff for D4712: Encrypted kernel crash dumps..
Apr 14 2016, 8:03 PM

Apr 2 2016

def added a comment to D4712: Encrypted kernel crash dumps..
In D4712#124230, @cem wrote:
In D4712#123472, @def wrote:
In D4712#99936, @kib wrote:

Still, I have a question. You choice was to modify the dump code, which resulted in spreading the patch over the MI dump and all MD minidump code. Semi-obvious alternate approach is to introduce a geom which would write the generated encrypted symmetric key into the first block and write data block N into encrypted block N+1 of the underlying provider. Then you do not have to touch the kernel dump code at all.

I agree with kib@. It would be nice not to have separate userspace tools here.

In fact we already have encrypted GEOM providers (g_eli, ...). All we lack is a way to dump core through them—maybe? I'm not even sure we lack that.

The kerneldumpkey structure has an arbitrary size.

I am sure this is not a problem in practice. An AES key is far smaller than 512 bytes.

Apr 2 2016, 5:58 PM

Mar 30 2016

def added reviewers for D4712: Encrypted kernel crash dumps.: jhb, kib, delphij.
Mar 30 2016, 2:42 AM
def added a comment to D4712: Encrypted kernel crash dumps..
In D4712#99936, @kib wrote:

I looked over the patch, it looks fine to me.

Still, I have a question. You choice was to modify the dump code, which resulted in spreading the patch over the MI dump and all MD minidump code. Semi-obvious alternate approach is to introduce a geom which would write the generated encrypted symmetric key into the first block and write data block N into encrypted block N+1 of the underlying provider. Then you do not have to touch the kernel dump code at all.

Is it possible technically ?

Mar 30 2016, 2:40 AM
def added inline comments to D4712: Encrypted kernel crash dumps..
Mar 30 2016, 2:32 AM
def updated the diff for D4712: Encrypted kernel crash dumps..
Mar 30 2016, 2:19 AM

Dec 26 2015

def updated D4712: Encrypted kernel crash dumps..
Dec 26 2015, 2:51 PM
def retitled D4712: Encrypted kernel crash dumps. from to Encrypted kernel crash dumps..
Dec 26 2015, 2:43 PM

Oct 16 2015

def added a comment to D2587: Disable free space checking in savecore..

I have made some inline comments. I think a partial vmcore shouldn't be removed because another panic might happen before a user tries to run savecore manually again.

Oct 16 2015, 10:51 PM