Page MenuHomeFreeBSD

GSoC StudentsOrganization
ActivePublic

Watchers

  • This project does not have any watchers.

Recent Activity

Aug 28 2017

paggas1_yandex.com updated the diff for D11322: Tests for pfctl.

Reverted to previous version (last update was a mistake).

Aug 28 2017, 11:50 PM · GSoC Students
paggas1_yandex.com updated the diff for D11322: Tests for pfctl.

New version.

Aug 28 2017, 11:46 PM · GSoC Students

Jul 15 2017

Diffusion closed D11322: Tests for pfctl by committing rS321030: pfctl parser tests.
Jul 15 2017, 7:22 PM · GSoC Students

Jul 13 2017

paggas1_yandex.com updated the diff for D11322: Tests for pfctl.

Added workaround so that the test files get installed correctly.

Jul 13 2017, 11:50 PM · GSoC Students
kristof added a comment to D11322: Tests for pfctl.

I ran into issues with 'install world' with this patch. I think you also want the following:

Jul 13 2017, 10:19 AM · GSoC Students
paggas1_yandex.com added a comment to D11322: Tests for pfctl.

I think you're also missing the connection in the pfctl makefile. I've been looking at sbin/mdconfig as an example and it has this:

.if ${MK_TESTS} != "no"
SUBDIR+=    tests
.endif
Jul 13 2017, 2:51 AM · GSoC Students
paggas1_yandex.com added a comment to D11322: Tests for pfctl.

It might also be worth seeing if you can add a couple of tests for ALTQ.
That's also interesting to consider because ALTQ is an optional feature and might not be available in the running kernel.
That'd mean you'd have to have test metadata to figure out if you can sensibly run the test on this system or not (presumably kyua understands the concept of a skipped test).

Jul 13 2017, 2:47 AM · GSoC Students
paggas1_yandex.com updated the diff for D11322: Tests for pfctl.

Fixed various issues.

Jul 13 2017, 2:44 AM · GSoC Students

Jul 12 2017

kristof added a comment to D11322: Tests for pfctl.

I think you're also missing the connection in the pfctl makefile. I've been looking at sbin/mdconfig as an example and it has this:

Jul 12 2017, 8:45 PM · GSoC Students
paggas1_yandex.com updated the summary of D11322: Tests for pfctl.
Jul 12 2017, 5:22 PM · GSoC Students
paggas1_yandex.com updated the diff for D11322: Tests for pfctl.

Removed hardcoded binary path. Also moved tests under src/sbin/pfctl/tests.

Jul 12 2017, 5:20 PM · GSoC Students

Jul 11 2017

paggas1_yandex.com updated the diff for D11322: Tests for pfctl.

Use pfctl from PATH, instead of custom location.

Jul 11 2017, 11:55 PM · GSoC Students
paggas1_yandex.com updated the diff for D11322: Tests for pfctl.

Added tests/sbin/Kyuafile. 'make install' as root still fails because of missing directories under '/usr/tests'.

Jul 11 2017, 12:37 PM · GSoC Students
paggas1_yandex.com retitled D11322: Tests for pfctl from Preliminary tests for pfctl to Tests for pfctl.
Jul 11 2017, 12:35 PM · GSoC Students

Jul 10 2017

kristof added a comment to D11322: Tests for pfctl.

This also appears to be missing the integration with the other tests. It can only be used by running it directly from the tests/sbin/pfctl directory.

Jul 10 2017, 1:33 PM · GSoC Students

Jul 9 2017

kristof added inline comments to D11322: Tests for pfctl.
Jul 9 2017, 9:10 AM · GSoC Students

Jul 8 2017

paggas1_yandex.com updated the diff for D11322: Tests for pfctl.

Uploaded correct diff.

Jul 8 2017, 5:31 PM · GSoC Students
kristof added a comment to D11322: Tests for pfctl.

Cleaned-up version, with improved test descriptions.

Jul 8 2017, 9:10 AM · GSoC Students

Jul 7 2017

paggas1_yandex.com updated the diff for D11322: Tests for pfctl.

Cleaned-up version, with improved test descriptions.

Jul 7 2017, 11:58 PM · GSoC Students

Jun 29 2017

paggas1_yandex.com added a comment to D11322: Tests for pfctl.

Den 2017-06-28 kl. 20:14, skrev kristof (Kristof Provost):

kristof added a comment.

It'd also be good to include the changes required to hook up the sbin/pfctl/Kyuafile to the tests Kyuafile.
Your GitHub repo has a symlink to get recursive behaviour out of Kyua, but there's basically no other symlinks in the repo, so let's avoid that. I'd add a simple include Kyuafile, like ./contrib/atf/Kyuafile does.

Done! I've changed the Kyuafiles now, and started using Makefiles
extensively. This also means that tests can be installed to /usr/tests
and run from there, or run from the source directory.

INLINE COMMENTS

pfctl_test.sh:32
+ atf_test_case "pf${i}"
+ eval "pf${i}_head () { atf_set descr $(pf${i}_descr) ; }"
+ eval "pf${i}_body () { \

Wouldn't this allow descriptions with spaces (and optionally multiline):

eval "pf${if}_head() { atf_set descr \"$(pf${i}_descr)\" ; }"

I also wonder if it wouldn't be better to put the description in a per-test file. pf1004.descr for example.

That is true, it was mostly a quick solution. I did the change above
and it works now.

test_altq.c:3
+
+#include <sys/types.h>
+#include <net/if.h>

This file isn't used yet, right? I'd leave that out of this, and add it in a subsequent patch.

I have removed it now.

Jun 29 2017, 1:22 AM · GSoC Students

Jun 28 2017

kristof added a comment to D11322: Tests for pfctl.

It'd also be good to include the changes required to hook up the sbin/pfctl/Kyuafile to the tests Kyuafile.
Your GitHub repo has a symlink to get recursive behaviour out of Kyua, but there's basically no other symlinks in the repo, so let's avoid that. I'd add a simple include Kyuafile, like ./contrib/atf/Kyuafile does.

Jun 28 2017, 8:14 PM · GSoC Students
paggas1_yandex.com updated the diff for D11322: Tests for pfctl.

Added a small utility that checks for ALTQ support in the kernel. Also improved integration with the build system.

Jun 28 2017, 6:19 PM · GSoC Students

Jun 26 2017

paggas1_yandex.com updated the diff for D11322: Tests for pfctl.

tests/sbin/pfctl: improved test descriptions

Jun 26 2017, 10:16 PM · GSoC Students
paggas1_yandex.com updated the diff for D11322: Tests for pfctl.

tests/sbin/pfctl: removed empty tests

Jun 26 2017, 5:14 PM · GSoC Students

Jun 25 2017

kristof added a comment to D11322: Tests for pfctl.

It might also be worth seeing if you can add a couple of tests for ALTQ.
That's also interesting to consider because ALTQ is an optional feature and might not be available in the running kernel.
That'd mean you'd have to have test metadata to figure out if you can sensibly run the test on this system or not (presumably kyua understands the concept of a skipped test).

Jun 25 2017, 1:49 PM · GSoC Students

Jun 23 2017

paggas1_yandex.com added a reviewer for D11322: Tests for pfctl: kristof.
Jun 23 2017, 12:22 PM · GSoC Students
paggas1_yandex.com removed a reviewer for D11322: Tests for pfctl: paggas1_yandex.com.
Jun 23 2017, 12:22 PM · GSoC Students
paggas1_yandex.com created D11322: Tests for pfctl.
Jun 23 2017, 12:21 PM · GSoC Students

Oct 5 2016

oshogbo closed D7247: Manpage for dnvlist.
Oct 5 2016, 7:01 PM · manpages, GSoC Students
oshogbo accepted D7247: Manpage for dnvlist.
Oct 5 2016, 7:01 PM · manpages, GSoC Students

Aug 27 2016

oshogbo closed D7249: Manpage for cnvlist by committing rS304910: Introduce cnv man page..
Aug 27 2016, 1:48 PM · manpages, GSoC Students

Aug 26 2016

wblock added a comment to D7249: Manpage for cnvlist.

Missing that one "and", but otherwise looks good. Thanks!

Aug 26 2016, 2:49 PM · manpages, GSoC Students

Aug 18 2016

brueffer added inline comments to D7247: Manpage for dnvlist.
Aug 18 2016, 2:34 PM · manpages, GSoC Students
starak.adam_gmail.com updated the diff for D7249: Manpage for cnvlist.
Aug 18 2016, 2:29 PM · manpages, GSoC Students
starak.adam_gmail.com updated the diff for D7247: Manpage for dnvlist.
Aug 18 2016, 2:29 PM · manpages, GSoC Students
starak.adam_gmail.com added a comment to D7247: Manpage for dnvlist.

updated

Aug 18 2016, 2:26 PM · manpages, GSoC Students
starak.adam_gmail.com added a comment to D7249: Manpage for cnvlist.

updated

Aug 18 2016, 2:12 PM · manpages, GSoC Students

Aug 12 2016

wblock added inline comments to D7249: Manpage for cnvlist.
Aug 12 2016, 4:07 PM · manpages, GSoC Students

Aug 9 2016

brueffer added inline comments to D7247: Manpage for dnvlist.
Aug 9 2016, 12:03 PM · manpages, GSoC Students
starak.adam_gmail.com updated the diff for D7247: Manpage for dnvlist.

Update. Sorry for last diff. I reversed commits.

Aug 9 2016, 11:54 AM · manpages, GSoC Students
starak.adam_gmail.com updated the diff for D7249: Manpage for cnvlist.

updated. Sorry for the last diff.

Aug 9 2016, 11:42 AM · manpages, GSoC Students
starak.adam_gmail.com added a comment to D7249: Manpage for cnvlist.

oops. updated

Aug 9 2016, 11:39 AM · manpages, GSoC Students
starak.adam_gmail.com added a comment to D7247: Manpage for dnvlist.

oops, i put the commits wrong way. Updated

Aug 9 2016, 11:25 AM · manpages, GSoC Students

Aug 8 2016

jilles added a comment to D7249: Manpage for cnvlist.

It seems a bit strange to refer to close(2) and free(3) from a section 9 (kernel) man page since those functions cannot be called from the kernel. The nv(9) man page already in -current seems to have the same problem. Ideally, the man page would describe the differences between the kernel and userland versions of the APIs.

Aug 8 2016, 9:58 PM · manpages, GSoC Students
cem accepted D7247: Manpage for dnvlist.

LGTM, modulo nits below.

Aug 8 2016, 4:36 PM · manpages, GSoC Students
cem accepted D7249: Manpage for cnvlist.

Have you run igor(1) against your page?

Aug 8 2016, 4:27 PM · manpages, GSoC Students
cem added a comment to D7249: Manpage for cnvlist.

I think you uploaded an empty or reversed diff on accident. Phabricator shows the file as deleted instead of added. :-)

Aug 8 2016, 4:21 PM · manpages, GSoC Students
starak.adam_gmail.com updated the diff for D7247: Manpage for dnvlist.

update

Aug 8 2016, 8:20 AM · manpages, GSoC Students
starak.adam_gmail.com updated the diff for D7249: Manpage for cnvlist.

updated and added example

Aug 8 2016, 8:19 AM · manpages, GSoC Students
oshogbo added inline comments to D7247: Manpage for dnvlist.
Aug 8 2016, 7:34 AM · manpages, GSoC Students