Page MenuHomeFreeBSD

pjd (Pawel Jakub Dawidek)
User

Projects

User Details

User Since
Sep 26 2014, 6:56 AM (507 w, 3 d)

Recent Activity

Wed, Jun 12

pjd updated the diff for D45243: Introduce fcopydata() and fcopydata_sig() functions..

Fix bootstrapping on macOS.

Wed, Jun 12, 3:33 PM

Fri, May 24

pjd updated the diff for D45243: Introduce fcopydata() and fcopydata_sig() functions..

Fix bootstraping on macOS.

Fri, May 24, 7:04 AM

Thu, May 23

pjd committed rG56a8aca83ab5: Stop treating size 0 as unknown size in vnode_create_vobject(). (authored by pjd).
Stop treating size 0 as unknown size in vnode_create_vobject().
Thu, May 23, 6:09 AM
pjd closed D45244: Stop treating size 0 as unknown size in vnode_create_vobject()..
Thu, May 23, 6:09 AM

Wed, May 22

pjd updated the diff for D45244: Stop treating size 0 as unknown size in vnode_create_vobject()..

Remove blank lines at the begining of functions with no local variables.

Wed, May 22, 7:43 AM
pjd updated the diff for D45244: Stop treating size 0 as unknown size in vnode_create_vobject()..

Add a comment explaining why we check mediasize this late.

Wed, May 22, 5:05 AM
pjd committed rG61e3e1776d40: capsicum: SIGTRAP is delivered also on ECAPMODE error. (authored by pjd).
capsicum: SIGTRAP is delivered also on ECAPMODE error.
Wed, May 22, 4:53 AM
pjd committed rGff4fc43afdea: Fix build. (authored by pjd).
Fix build.
Wed, May 22, 3:57 AM
pjd committed rG31223e68e299: Simplify the code. (authored by pjd).
Simplify the code.
Wed, May 22, 3:04 AM
pjd closed D45247: Simplify the code..
Wed, May 22, 3:04 AM
pjd updated the diff for D45244: Stop treating size 0 as unknown size in vnode_create_vobject()..

Updated wrong review. Bring back the proper patch.

Wed, May 22, 2:59 AM
pjd updated the diff for D45243: Introduce fcopydata() and fcopydata_sig() functions..

Compilation fix.

Wed, May 22, 2:57 AM
pjd updated the diff for D45244: Stop treating size 0 as unknown size in vnode_create_vobject()..

Compilation fix.

Wed, May 22, 2:57 AM

Tue, May 21

pjd added a comment to D45243: Introduce fcopydata() and fcopydata_sig() functions..
In D45243#1033059, @des wrote:
In D45243#1032859, @pjd wrote:
In D45243#1032364, @des wrote:

Have you considered implementing Apple's copyfile API?

I did, but I cannot commit that much time to implement it.

I'm not suggesting implementing the full API; just COPYFILE_DATA and COPYFILE_STAT and a handful of modifiers (COPYFILE_DATA_SPARSE, COPYFILE_EXCL, COPYFILE_MOVE, COPYFILE_NOFOLLOW, COPYFILE_UNLINK) should suffice. I'd offer to help, but I've seen the source code (it's on GitHub under APSL) so I probably shouldn't.

Tue, May 21, 10:52 PM

Mon, May 20

pjd added inline comments to D45244: Stop treating size 0 as unknown size in vnode_create_vobject()..
Mon, May 20, 9:10 PM
pjd updated the diff for D45244: Stop treating size 0 as unknown size in vnode_create_vobject()..

Remove too aggressive assert.

Mon, May 20, 9:09 PM
pjd updated the diff for D45244: Stop treating size 0 as unknown size in vnode_create_vobject()..

Add a missing argument to VNASSERT().

Mon, May 20, 8:44 PM
pjd updated the diff for D45244: Stop treating size 0 as unknown size in vnode_create_vobject()..

Use VNASSERT() instead of KASSERT().

Mon, May 20, 8:38 PM
pjd added inline comments to D45244: Stop treating size 0 as unknown size in vnode_create_vobject()..
Mon, May 20, 8:35 PM
pjd added a comment to D45243: Introduce fcopydata() and fcopydata_sig() functions..
In D45243#1032364, @des wrote:

Have you considered implementing Apple's copyfile API?

Mon, May 20, 6:57 PM
pjd updated the diff for D45244: Stop treating size 0 as unknown size in vnode_create_vobject()..
  • Rename vnode_disk_create_vobject() to vnode_create_disk_vobject().
  • Improve assertions.
Mon, May 20, 6:01 PM
pjd updated the diff for D45244: Stop treating size 0 as unknown size in vnode_create_vobject()..
  • Introduce dedicated vnode_disk_create_vobject() for use by g_vfs_open(), so we don't have to do vn_isdisk() checks for regular files.
Mon, May 20, 7:04 AM
pjd added inline comments to D45244: Stop treating size 0 as unknown size in vnode_create_vobject()..
Mon, May 20, 6:12 AM
pjd added inline comments to D45244: Stop treating size 0 as unknown size in vnode_create_vobject()..
Mon, May 20, 5:53 AM

Sun, May 19

pjd added reviewers for D45247: Simplify the code.: oshogbo, allanjude.
Sun, May 19, 1:59 AM
pjd requested review of D45247: Simplify the code..
Sun, May 19, 1:58 AM
pjd updated the diff for D45243: Introduce fcopydata() and fcopydata_sig() functions..

Fall back to read(2)/write(2) in case of EBADF and EISDIR.

Sun, May 19, 1:56 AM
pjd added a reviewer for D45243: Introduce fcopydata() and fcopydata_sig() functions.: des.
Sun, May 19, 1:46 AM
pjd updated the diff for D45244: Stop treating size 0 as unknown size in vnode_create_vobject()..

Style.

Sun, May 19, 1:41 AM
pjd updated the diff for D45244: Stop treating size 0 as unknown size in vnode_create_vobject()..
  • Don't call vn_getsize_locked() in case of VNODE_NO_SIZE.
  • Assume we can have a disk for both cases (size == 0 and size == VNODE_NO_SIZE).
Sun, May 19, 1:39 AM
pjd added reviewers for D45244: Stop treating size 0 as unknown size in vnode_create_vobject().: kib, oshogbo, allanjude.
Sun, May 19, 1:22 AM
pjd requested review of D45244: Stop treating size 0 as unknown size in vnode_create_vobject()..
Sun, May 19, 1:21 AM
pjd added reviewers for D45243: Introduce fcopydata() and fcopydata_sig() functions.: mm, oshogbo, allanjude.
Sun, May 19, 1:02 AM
pjd requested review of D45243: Introduce fcopydata() and fcopydata_sig() functions..
Sun, May 19, 1:02 AM

Jan 22 2024

pjd added reviewers for D43547: capsicum: SIGTRAP is delivered also on ECAPMODE error.: oshogbo, allanjude.
Jan 22 2024, 9:39 PM
pjd requested review of D43547: capsicum: SIGTRAP is delivered also on ECAPMODE error..
Jan 22 2024, 9:38 PM

Jan 21 2024

pjd added inline comments to D43488: kern: Implement lockless method for obtaining new PID..
Jan 21 2024, 9:16 PM

Jan 20 2024

pjd added reviewers for D43496: Don't hardcode maximum PID.: allanjude, oshogbo.
Jan 20 2024, 10:31 PM
pjd accepted D43529: Add kern_openatfp(9).
Jan 20 2024, 10:21 PM
pjd requested changes to D43529: Add kern_openatfp(9).

Thank you for working on this!

Jan 20 2024, 9:59 PM
pjd updated the diff for D43496: Don't hardcode maximum PID..

Remove compatibility code from libc.

Jan 20 2024, 7:11 AM

Jan 18 2024

pjd added a comment to D43488: kern: Implement lockless method for obtaining new PID..
In D43488#991394, @mjg wrote:

What's the motivation here? If you are running into scalability problems, it has to be allproc and proctree locks (amongst others).

Jan 18 2024, 4:20 PM
pjd added reviewers for D43496: Don't hardcode maximum PID.: kib, markj, mjg.
Jan 18 2024, 4:10 PM
pjd requested review of D43496: Don't hardcode maximum PID..
Jan 18 2024, 4:08 PM
pjd updated the summary of D43487: bitset(9): Implement BIT_ISSET_ATOMIC(), BIT_FFC() and BIT_FFC_AT()..
Jan 18 2024, 4:46 AM
pjd added reviewers for D43488: kern: Implement lockless method for obtaining new PID.: kib, markj, mjg.
Jan 18 2024, 4:46 AM
pjd added a comment to D43487: bitset(9): Implement BIT_ISSET_ATOMIC(), BIT_FFC() and BIT_FFC_AT()..

PoC, still missing bitset(9) manual page update. Part of: https://reviews.freebsd.org/D43488

Jan 18 2024, 4:37 AM
pjd requested review of D43488: kern: Implement lockless method for obtaining new PID..
Jan 18 2024, 4:35 AM
pjd requested review of D43487: bitset(9): Implement BIT_ISSET_ATOMIC(), BIT_FFC() and BIT_FFC_AT()..
Jan 18 2024, 4:35 AM

Jan 17 2024

pjd committed rG41ac0b4ce00b: Fix the build. (authored by pjd).
Fix the build.
Jan 17 2024, 7:00 PM
pjd committed rGf1d0a0cbecf2: jail: Fix information leak. (authored by pjd).
jail: Fix information leak.
Jan 17 2024, 5:50 PM

Dec 30 2023

pjd committed rG1b8d70b2eb71: kern: Introduce kern.pid_max_limit sysctl. (authored by pjd).
kern: Introduce kern.pid_max_limit sysctl.
Dec 30 2023, 6:20 AM
pjd closed D43077: Don't hardcode maximum PID..
Dec 30 2023, 6:20 AM

Dec 28 2023

pjd added inline comments to D43077: Don't hardcode maximum PID..
Dec 28 2023, 7:44 AM

Dec 26 2023

pjd added inline comments to D43077: Don't hardcode maximum PID..
Dec 26 2023, 12:15 AM

Dec 22 2023

pjd updated the diff for D43077: Don't hardcode maximum PID..

Introduce kern.pid_max_limit.

Dec 22 2023, 6:59 AM
pjd committed rGeb4d13126d85: seq(1): Put separator only between the elements. (authored by pjd).
seq(1): Put separator only between the elements.
Dec 22 2023, 5:56 AM
pjd closed D43094: seq(1): Put separator only between the elements..
Dec 22 2023, 5:56 AM

Dec 19 2023

pjd added reviewers for D43094: seq(1): Put separator only between the elements.: oshogbo, allanjude, emaste.
Dec 19 2023, 2:48 AM
pjd requested review of D43094: seq(1): Put separator only between the elements..
Dec 19 2023, 2:46 AM
pjd updated the diff for D43077: Don't hardcode maximum PID..

Remove MAX_PID check from pkill.

Dec 19 2023, 2:37 AM

Dec 18 2023

pjd added inline comments to D43077: Don't hardcode maximum PID..
Dec 18 2023, 10:16 PM
pjd added inline comments to D43077: Don't hardcode maximum PID..
Dec 18 2023, 9:41 PM

Dec 16 2023

pjd updated the summary of D43077: Don't hardcode maximum PID..
Dec 16 2023, 11:54 PM
pjd committed rG6f3e9bac4d46: vm: Plug umtx shm object leak. (authored by pjd).
vm: Plug umtx shm object leak.
Dec 16 2023, 1:19 PM
pjd closed D43073: vm: Plug umtx shm object leak..
Dec 16 2023, 1:19 PM
pjd added a comment to D43077: Don't hardcode maximum PID..
In D43077#982025, @kib wrote:

For NO_PID, also look at usr.sbin/bsnmpd/modules/snmp_hostres/hostres_swrun_tbl.c and contrib/sendmail/src/sendmail.h (later is probably fine).

Dec 16 2023, 8:24 AM
pjd updated the diff for D43077: Don't hardcode maximum PID..

Add missing include.

Dec 16 2023, 7:48 AM
pjd updated the diff for D43077: Don't hardcode maximum PID..
  • Remove hardcoded PID_MAX from sched_{g,s}etaffinity().
  • Remove hardcoded NO_PID from bsnmpd.
Dec 16 2023, 7:41 AM
pjd added a comment to D43077: Don't hardcode maximum PID..
In D43077#982024, @kib wrote:

If you manually upload diffs, please generate them with something like git diff -U999999 <whatever> so that the full content is available.

Dec 16 2023, 7:18 AM
pjd updated the diff for D43077: Don't hardcode maximum PID..
Dec 16 2023, 5:36 AM
pjd retitled D43077: Don't hardcode maximum PID. from Don't use hardcoded PID_MAX value. to Don't hardcode maximum PID..
Dec 16 2023, 5:34 AM
pjd requested review of D43077: Don't hardcode maximum PID..
Dec 16 2023, 2:10 AM
pjd abandoned D43076: top(1): Use kern.pid_max instead of hardcoded value..
Dec 16 2023, 1:44 AM
pjd abandoned D43075: pkill(1): Use kern.pid_max instead of harcoded value..
Dec 16 2023, 1:44 AM
pjd abandoned D43074: Make PID_MAX visible from userspace..
Dec 16 2023, 1:44 AM
pjd requested review of D43076: top(1): Use kern.pid_max instead of hardcoded value..
Dec 16 2023, 1:43 AM
pjd requested review of D43075: pkill(1): Use kern.pid_max instead of harcoded value..
Dec 16 2023, 1:43 AM
pjd requested review of D43074: Make PID_MAX visible from userspace..
Dec 16 2023, 1:43 AM
pjd added reviewers for D43073: vm: Plug umtx shm object leak.: oshogbo, allanjude, kib.
Dec 16 2023, 12:37 AM
pjd requested review of D43073: vm: Plug umtx shm object leak..
Dec 16 2023, 12:35 AM

Jun 20 2023

pjd requested changes to D26484: /etc/rc: optionally turn on new 'rcorder -p' option to run rc scripts in parallel. .
Jun 20 2023, 10:53 PM

Apr 17 2023

pjd committed rG068913e4ba3d: zfs: Add vfs.zfs.bclone_enabled sysctl. (authored by pjd).
zfs: Add vfs.zfs.bclone_enabled sysctl.
Apr 17 2023, 10:40 AM
pjd closed D39613: zfs: Add vfs.zfs.bclone_enabled sysctl..
Apr 17 2023, 10:39 AM
pjd requested review of D39613: zfs: Add vfs.zfs.bclone_enabled sysctl..
Apr 17 2023, 9:53 AM
pjd committed rG1959e122d932: zfs: Merge https://github.com/openzfs/zfs/pull/14739 (authored by pjd).
zfs: Merge https://github.com/openzfs/zfs/pull/14739
Apr 17 2023, 9:26 AM
pjd committed rGe0bb19992556: zfs: cherry-pick openzfs/zfs@c71fe7164 (authored by pjd).
zfs: cherry-pick openzfs/zfs@c71fe7164
Apr 17 2023, 9:26 AM

Apr 5 2023

pjd added a comment to D39419: zfs: Call vn_generic_copy_file_range() if block_cloning disabled.

We shouldn't make the code more complex and less readable just to optimize for some rare edge cases. If someone disables block cloning, they are most likely not too concerned with performance and trying to avoid an extra vnode lock at the expense of code readability is, in my opinion, the wrong approach.

Apr 5 2023, 8:43 AM
pjd accepted D39418: zfs: Fix null ap->a_fsizetd NULL pointer derefernce.

Thank you for the fix!

Apr 5 2023, 7:05 AM

Mar 13 2023

pjd added a comment to D38814: Call VOP_COPY_FILE_RANGE() for the same file system type..
In D38814#884116, @mjg wrote:

I think this is a step backwards and it is not what I suggested.

For example now any fs which does not provide it's own primitive will take a trip through returning EOPNOTSUPP when it can be avoided.

I suggested everyone handling as much as they can and otherwise punting to vn_generic_copy_file_range or a differently named fallback with the same result.

To further illustrate the win in nullfs case, consider the following with 2 nullfs mount points:

  1. we land in null_copy_file_range or whatever
  2. both target vnodes get "unwrapped"
  3. the vop gets invoked in vnode1 with both as arguments and we are done here

With the proposed patch it will be instead:

  1. we land in null_copy_file_range or whatever
  2. both target vnodes get found + refed
  3. the vop returns EOPNOTSUPP
  4. the routine unrefs vnodes and returns
  5. ... now vn_generic_copy_file_range will keep calling VOP_READ and VOP_WRITE while looking up + refing (and unrefing) vnodes for each call
Mar 13 2023, 9:59 AM

Mar 1 2023

pjd added a comment to D38814: Call VOP_COPY_FILE_RANGE() for the same file system type..

LGTM. But is there any file system that you expect to support cross-mountpoint copy_file_range ?

Mar 1 2023, 11:32 AM

Feb 27 2023

pjd requested review of D38814: Call VOP_COPY_FILE_RANGE() for the same file system type..
Feb 27 2023, 10:13 PM
pjd added a comment to D38803: vfs: Allow VOP_COPY_FILE_RANGE() to work across mount points..
In D38803#883156, @mjg wrote:

My grep fails to find any existing custom routines, I'm guessing one for zfs will be showing up later. I think this also means there is no worry of any backwards-incompatible breakage.

Feb 27 2023, 9:44 PM
pjd requested review of D38803: vfs: Allow VOP_COPY_FILE_RANGE() to work across mount points..
Feb 27 2023, 2:44 AM

Feb 3 2023

pjd accepted D35767: hastd: use zlib's crc32 implementation..
Feb 3 2023, 1:04 AM
pjd committed rGc54d240eb1a0: kern_prot.c p_candebug(): Remove single-use variable. (authored by pjd).
kern_prot.c p_candebug(): Remove single-use variable.
Feb 3 2023, 1:01 AM
pjd committed rG14ba79255be8: nv.9: Improve style in one of the examples. (authored by pjd).
nv.9: Improve style in one of the examples.
Feb 3 2023, 1:01 AM
pjd closed D38288: Remove single-use variable..
Feb 3 2023, 1:01 AM
pjd closed D38287: Improve the style in one of the examples..
Feb 3 2023, 1:01 AM

Jan 31 2023

pjd updated the diff for D38288: Remove single-use variable..

Use larger context for the diff to include the entire function.

Jan 31 2023, 12:21 AM