Page MenuHomeFreeBSD

pjd (Pawel Jakub Dawidek)
User

Projects

User Details

User Since
Sep 26 2014, 6:56 AM (269 w, 16 h)

Recent Activity

Tue, Nov 19

pjd added inline comments to D22306: zfs: add option for forcible unmounting dataset while receiving snapshot..
Tue, Nov 19, 6:55 AM

Oct 12 2019

pjd updated the diff for D21807: VirtIO SCSI online disk resize.

After discussion with mav@, add ASCQs for PARAMETERS CHANGED and MODE PARAMETERS CHANGED, similar to Linux and Windows. Also add a comment describing those values.

Oct 12 2019, 7:16 AM

Oct 7 2019

pjd added a comment to D21807: VirtIO SCSI online disk resize.
In D21807#476635, @mav wrote:
In D21807#476430, @pjd wrote:

I see. Though they both handle 3 statuses, not just one.

Oct 7 2019, 6:01 PM

Sep 27 2019

pjd added a comment to D21807: VirtIO SCSI online disk resize.
In D21807#476253, @mav wrote:
In D21807#476160, @pjd wrote:

What do you mean by 'too strict parsing of ASC/ASCQ'?

I mean that considering the codes are passed and they are called ASC/ASCQ in specification, there potentially may be other ones too, for which CAM may have own more specific handling ideas, and I believe it is not a SIM driver duty to handle details of SCSI protocol. I don't object your implementation, just thinking out loud whether it could it be done better/otherwise.

Sep 27 2019, 6:27 PM
pjd added a comment to D21807: VirtIO SCSI online disk resize.
In D21807#476017, @mav wrote:

This virtio API looks ugly. They conform themselves that device should also report normal UNIT ATTENTION with the same status, which is already handled by CAM DA driver. If we assume that device does generate UNIT ATTENTION, then we should be able to make cam send TUR request to see it by using AC_SCSI_AEN async. Alternatively, it is possible to simulate UNIT ATTENTION receive by using AC_UNIT_ATTENTION with fake CCB, including ASC/ASCQ received from virtio API. Your method should also work, but what I don\t very like it too strict parsing ASC/ASCQ and sending not exactly correct async.

Sep 27 2019, 5:39 AM

Sep 26 2019

pjd created D21807: VirtIO SCSI online disk resize.
Sep 26 2019, 7:23 PM

Apr 9 2019

pjd added a comment to D19854: Fix geli device cleanup.
In D19854#426191, @ngie wrote:
In D19854#426189, @pjd wrote:

Do you mind elaborating why cleaning up like that is wrong? The reason I did it was to avoid creating multiple md devices. Here we only have 8 iterations of the loop, but I could easly imagine tests were I'd have hundreds and cleaning as I go would be a good thing then, IMHO. But maybe I'm missing something obvious here, so if you could explain that would be great. Thanks.
PS. The patch is fine.

Long story short is that it was doubling up the cleanup process.
It would allocate the device in body function, clean it up in the body function, then try to clean up the same device in the cleanup function, failing because it didn't exist in a state that could be deallocated/detached.

Apr 9 2019, 7:20 AM
pjd accepted D19854: Fix geli device cleanup.

Do you mind elaborating why cleaning up like that is wrong? The reason I did it was to avoid creating multiple md devices. Here we only have 8 iterations of the loop, but I could easly imagine tests were I'd have hundreds and cleaning as I go would be a good thing then, IMHO. But maybe I'm missing something obvious here, so if you could explain that would be great. Thanks.

Apr 9 2019, 5:44 AM

Apr 4 2019

pjd committed rS345864: Implement tests for online expansion:.
Implement tests for online expansion:
Apr 4 2019, 12:05 AM

Apr 3 2019

pjd committed rS345863: Update configure tests after addition of the online expansion..
Update configure tests after addition of the online expansion.
Apr 3 2019, 11:59 PM
pjd committed rS345862: Implement automatic online expansion of GELI providers - if the underlying.
Implement automatic online expansion of GELI providers - if the underlying
Apr 3 2019, 11:57 PM
pjd committed rS345861: - Add missing -T (notrim) option to the label subcommand..
- Add missing -T (notrim) option to the label subcommand.
Apr 3 2019, 11:51 PM

Mar 30 2019

pjd committed rS345728: If the autoexpand pool property is turned on and vdev is healthy try to.
If the autoexpand pool property is turned on and vdev is healthy try to
Mar 30 2019, 7:29 AM
pjd committed rS345727: Introduce new event SIZECHANGE within GEOM system to inform about GEOM.
Introduce new event SIZECHANGE within GEOM system to inform about GEOM
Mar 30 2019, 7:24 AM
pjd committed rS345726: Implement support for online disk capacity changes..
Implement support for online disk capacity changes.
Mar 30 2019, 7:20 AM

Mar 1 2019

pjd committed rS344690: Improve readability of the code by making it explicit where the 'c' variable.
Improve readability of the code by making it explicit where the 'c' variable
Mar 1 2019, 5:54 AM

Feb 20 2019

pjd committed rS344325: Simplify the code. No functional changes..
Simplify the code. No functional changes.
Feb 20 2019, 12:25 AM

Feb 19 2019

pjd committed rS344320: Simplify the code..
Simplify the code.
Feb 19 2019, 11:53 PM
pjd committed rS344319: Correct typo in the comment..
Correct typo in the comment.
Feb 19 2019, 11:44 PM
pjd committed rS344318: Change assertion to log the incorrect io_type we've got..
Change assertion to log the incorrect io_type we've got.
Feb 19 2019, 11:43 PM
pjd committed rS344317: Grabage-collect no longer used variable..
Grabage-collect no longer used variable.
Feb 19 2019, 11:41 PM
pjd committed rS344316: The way ZFS searches for its vdevs is the following: first it looks for.
The way ZFS searches for its vdevs is the following: first it looks for
Feb 19 2019, 11:36 PM
pjd committed rS344314: In the vdev_geom_open_by_path() function we assume that vdev path starts.
In the vdev_geom_open_by_path() function we assume that vdev path starts
Feb 19 2019, 11:22 PM

Jan 9 2019

pjd committed rS342873: In r316006 the getstrfromtype_locked() function was modified to return.
In r316006 the getstrfromtype_locked() function was modified to return
Jan 9 2019, 1:16 AM

Dec 7 2018

pjd committed rS341675: Consider the following situation:.
Consider the following situation:
Dec 7 2018, 3:14 AM

Oct 20 2018

pjd accepted D16930: Fix casper limitations.

Change looks good, my only suggestion would be to use maybe NAME2ADDR and ADDR2NAME, so the intentions are obvious.

Oct 20 2018, 11:08 PM

Oct 4 2018

pjd committed rS339178: Remove invalid comments and correct some typos..
Remove invalid comments and correct some typos.
Oct 4 2018, 5:57 AM
pjd committed rS339177: When the adist_free list is empty and we lose connection to the receiver we.
When the adist_free list is empty and we lose connection to the receiver we
Oct 4 2018, 5:55 AM
pjd committed rS339176: When we look for a new trail file there might be a race between find trail.
When we look for a new trail file there might be a race between find trail
Oct 4 2018, 5:48 AM

Jul 13 2018

pjd added inline comments to D16202: libradius(3) IPv6 support.
Jul 13 2018, 2:02 PM

Jul 10 2018

pjd updated the diff for D16202: libradius(3) IPv6 support.

Revert style changes.
Remove #ifdef INET checks from radlib.h, it prevents some consumers from compiling.
Implement some of oshogbo suggestions.

Jul 10 2018, 3:11 PM
pjd added inline comments to D16202: libradius(3) IPv6 support.
Jul 10 2018, 3:09 PM
pjd updated the diff for D16202: libradius(3) IPv6 support.
  • Allow for optional compilation without IPv4 or IPv6 support.
  • Make it possible to use IPv6 addresses in configuration file.
  • Call getaddrinfo(3) with flags set to AI_ADDRCONFIG.
Jul 10 2018, 1:39 AM
pjd added a comment to D16202: libradius(3) IPv6 support.

You are probably talking about this one: https://markmail.org/message/e3zkukh7oggutrvw
I've tried it, but it is very out-dated and has some bugs. It also keeps server on a TAILQ, which is nice, but I don't think it should be combined. The nice thing about that patch was to add multiple servers when a hostname resolves to multiple IP addresses, which I also implemented.

Jul 10 2018, 12:30 AM

Jul 9 2018

pjd created D16202: libradius(3) IPv6 support.
Jul 9 2018, 11:49 PM
pjd accepted D11531: geom_gate: enable resize.
Jul 9 2018, 11:18 PM

Feb 3 2017

pjd added a comment to D7804: Set minimum GELI pkcsv5 iterations.

I agree with delphij that we should not introduce lower limit.

Feb 3 2017, 9:38 PM
pjd accepted D8236: improve PBKDF2 performance.
Feb 3 2017, 9:36 PM
pjd accepted D9423: Switch hastd to using libmd instead of openssl for sha256.

Looks good, but I agree that hastctl should use libmd too in that case.

Feb 3 2017, 9:28 PM
pjd accepted D8576: Defer startup of gjournal switcher kproc..
Feb 3 2017, 9:26 PM
pjd added a comment to D9396: geli attach multiple providers (with kernel changes).

Could you please explain why you implemented that in the kernel and not in userland geli command?

Feb 3 2017, 9:24 PM

Nov 8 2016

pjd committed rS308439: Please welcome Konrad Witaszczyk (def@) as a new source committer..
Please welcome Konrad Witaszczyk (def@) as a new source committer.
Nov 8 2016, 9:54 AM

May 31 2016

pjd committed rS301036: Release Mariusz Zaborski (oshogbo) from mentorship..
Release Mariusz Zaborski (oshogbo) from mentorship.
May 31 2016, 12:39 PM

Apr 3 2016

pjd added inline comments to D4712: Encrypted kernel crash dumps..
Apr 3 2016, 2:06 AM

Apr 2 2016

pjd added a comment to D4712: Encrypted kernel crash dumps..
In D4712#124230, @cem wrote:

I agree with kib@. It would be nice not to have separate userspace tools here.
In fact we already have encrypted GEOM providers (g_eli, ...). All we lack is a way to dump core through them—maybe? I'm not even sure we lack that.

Apr 2 2016, 9:16 PM
pjd added a comment to D4712: Encrypted kernel crash dumps..
In D4712#99936, @kib wrote:

I looked over the patch, it looks fine to me.
Still, I have a question. You choice was to modify the dump code, which resulted in spreading the patch over the MI dump and all MD minidump code. Semi-obvious alternate approach is to introduce a geom which would write the generated encrypted symmetric key into the first block and write data block N into encrypted block N+1 of the underlying provider. Then you do not have to touch the kernel dump code at all.
Is it possible technically ?

Apr 2 2016, 9:10 PM

Feb 24 2016

pjd added a comment to D4926: Optimize geli's algorithm to taste devices at boot.

Hi Pascal.

Feb 24 2016, 4:03 PM

Dec 29 2015

pjd closed D3814: aio_waitcomplete(2) should not sleep when timeout is not NULL, but set to 0..
Dec 29 2015, 4:20 PM
pjd added inline comments to D4712: Encrypted kernel crash dumps..
Dec 29 2015, 12:52 AM
pjd added inline comments to D4712: Encrypted kernel crash dumps..
Dec 29 2015, 12:39 AM
pjd added a comment to D4699: Make sys/geom/eli more easily reusable in userspace.

It looks good overall, but please be sure you run GELI regression tests. Thanks!

Dec 29 2015, 12:24 AM

Dec 16 2015

pjd committed rS292310: Keep maintainance of GELI and make it clear which directories I'm interested in..
Keep maintainance of GELI and make it clear which directories I'm interested in.
Dec 16 2015, 1:06 AM

Oct 25 2015

pjd committed rS289941: The aio_waitcomplete(2) syscall should not sleep when the given timeout.
The aio_waitcomplete(2) syscall should not sleep when the given timeout
Oct 25 2015, 6:48 PM

Oct 21 2015

pjd updated the diff for D3814: aio_waitcomplete(2) should not sleep when timeout is not NULL, but set to 0..

Thanks John, both good suggestions.

Oct 21 2015, 9:27 PM

Oct 5 2015

pjd retitled D3814: aio_waitcomplete(2) should not sleep when timeout is not NULL, but set to 0. from to aio_waitcomplete(2) should not sleep when timeout is not NULL, but set to 0..
Oct 5 2015, 5:04 PM
pjd accepted D1888: Extend the unit test to fix the bug caught in r277925.
Oct 5 2015, 4:53 PM

Oct 4 2015

pjd committed rS288644: Add a little, but very useful script for use with programs that work using an.
Add a little, but very useful script for use with programs that work using an
Oct 4 2015, 12:40 AM

Aug 8 2015

pjd committed rS286445: Allow to disable BIO_DELETE passthru in fstab for swap-on-geli devices by.
Allow to disable BIO_DELETE passthru in fstab for swap-on-geli devices by
Aug 8 2015, 9:57 AM
pjd committed rS286444: Enable BIO_DELETE passthru in GELI, so TRIM/UNMAP can work as expected when.
Enable BIO_DELETE passthru in GELI, so TRIM/UNMAP can work as expected when
Aug 8 2015, 9:51 AM

Aug 6 2015

pjd committed rS286373: After crypto_dispatch() bio might be already delivered and destroyed,.
After crypto_dispatch() bio might be already delivered and destroyed,
Aug 6 2015, 5:13 PM

Jul 10 2015

pjd committed rS285363: Spoil even can happen for some time now even on providers opened exclusively.
Spoil even can happen for some time now even on providers opened exclusively
Jul 10 2015, 7:27 PM

Jul 2 2015

pjd committed rS285024: Properly propagate errors in metadata reading..
Properly propagate errors in metadata reading.
Jul 2 2015, 10:57 AM
pjd committed rS285023: Allow to omit keyfile number for the first keyfile..
Allow to omit keyfile number for the first keyfile.
Jul 2 2015, 10:55 AM

Jun 2 2015

pjd committed rS283928: MFC r265950 (by thomas):.
MFC r265950 (by thomas):
Jun 2 2015, 8:30 PM

Apr 22 2015

pjd committed rS281856: Welcome Mariusz Zaborski (oshogbo) as a new src committer. Mariusz will be.
Welcome Mariusz Zaborski (oshogbo) as a new src committer. Mariusz will be
Apr 22 2015, 4:06 PM

Feb 19 2015

pjd added inline comments to D1879: Don't allocate memory for operations that do not insert.
Feb 19 2015, 8:50 AM
pjd added a comment to D1878: Add function to force an nvlist into the error state.

Other that the minor nit above, it looks good.

Feb 19 2015, 8:44 AM
pjd added inline comments to D1877: Implement asprintf in libkern.
Feb 19 2015, 8:41 AM
pjd accepted D1876: Add tests for dnvlist_take_*.

Looks good.

Feb 19 2015, 8:39 AM
pjd accepted D1875: Add tests for dnv_get_*.

Looks good.

Feb 19 2015, 8:37 AM
pjd accepted D1874: Add tests for nvlist_free* functions.

Looks good.

Feb 19 2015, 8:32 AM
pjd accepted D1873: Add tests for nvlist_take_*.

Looks good.

Feb 19 2015, 8:31 AM
pjd accepted D1871: Add tests for nvlist_pack/unpack.
Feb 19 2015, 7:58 AM
pjd accepted D1872: Add test cases for nvlist_move_*.

Looks good to me.

Feb 19 2015, 7:49 AM
pjd added a comment to D1871: Add tests for nvlist_pack/unpack.

Looks good to me.

Feb 19 2015, 7:48 AM
pjd added inline comments to D1870: Add tests for nvlist_clone.
Feb 19 2015, 7:41 AM
pjd added a comment to D1869: Tests of basic nvlist add functions.

I like it.

Feb 19 2015, 7:36 AM
pjd added a comment to D1868: Make libnv headers includable from C++.

Looks good to me, apart from the small nit above.

Feb 19 2015, 7:23 AM

Nov 16 2014

pjd added a comment to D1009: Enter capability mode and limit descriptors in elfdump(1).

Overall looks good to me. I do agree with Jonathan that we should also limit std descriptors. You can find example in the go_daemon() function in sbin/dhclient/dhclient.c.

Nov 16 2014, 5:53 AM

Nov 12 2014

pjd accepted D1150: Fix geom help output.

Macro goatforit:

Nov 12 2014, 10:50 PM