pjd (Pawel Jakub Dawidek)
User

Projects

User Details

User Since
Sep 26 2014, 6:56 AM (165 w, 19 h)

Recent Activity

Feb 3 2017

pjd added a comment to D7804: Set minimum GELI pkcsv5 iterations.

I agree with delphij that we should not introduce lower limit.

Feb 3 2017, 9:38 PM
pjd accepted D8236: improve PBKDF2 performance.
Feb 3 2017, 9:36 PM
pjd accepted D9423: Switch hastd to using libmd instead of openssl for sha256.

Looks good, but I agree that hastctl should use libmd too in that case.

Feb 3 2017, 9:28 PM
pjd accepted D8576: Defer startup of gjournal switcher kproc..
Feb 3 2017, 9:26 PM
pjd added a comment to D9396: geli attach multiple providers (with kernel changes).

Could you please explain why you implemented that in the kernel and not in userland geli command?

Feb 3 2017, 9:24 PM

Nov 8 2016

pjd committed rS308439: Please welcome Konrad Witaszczyk (def@) as a new source committer..
Please welcome Konrad Witaszczyk (def@) as a new source committer.
Nov 8 2016, 9:54 AM

May 31 2016

pjd committed rS301036: Release Mariusz Zaborski (oshogbo) from mentorship..
Release Mariusz Zaborski (oshogbo) from mentorship.
May 31 2016, 12:39 PM

Apr 3 2016

pjd added inline comments to D4712: Encrypted kernel crash dumps..
Apr 3 2016, 2:06 AM

Apr 2 2016

pjd added a comment to D4712: Encrypted kernel crash dumps..
In D4712#124230, @cem wrote:

I agree with kib@. It would be nice not to have separate userspace tools here.

In fact we already have encrypted GEOM providers (g_eli, ...). All we lack is a way to dump core through them—maybe? I'm not even sure we lack that.

Apr 2 2016, 9:16 PM
pjd added a comment to D4712: Encrypted kernel crash dumps..
In D4712#99936, @kib wrote:

I looked over the patch, it looks fine to me.

Still, I have a question. You choice was to modify the dump code, which resulted in spreading the patch over the MI dump and all MD minidump code. Semi-obvious alternate approach is to introduce a geom which would write the generated encrypted symmetric key into the first block and write data block N into encrypted block N+1 of the underlying provider. Then you do not have to touch the kernel dump code at all.

Is it possible technically ?

Apr 2 2016, 9:10 PM

Feb 24 2016

pjd added a comment to D4926: Optimize geli's algorithm to taste devices at boot.

Hi Pascal.

Feb 24 2016, 4:03 PM

Dec 29 2015

pjd closed D3814: aio_waitcomplete(2) should not sleep when timeout is not NULL, but set to 0..
Dec 29 2015, 4:20 PM
pjd added inline comments to D4712: Encrypted kernel crash dumps..
Dec 29 2015, 12:52 AM
pjd added inline comments to D4712: Encrypted kernel crash dumps..
Dec 29 2015, 12:39 AM
pjd added a comment to D4699: Make sys/geom/eli more easily reusable in userspace.

It looks good overall, but please be sure you run GELI regression tests. Thanks!

Dec 29 2015, 12:24 AM

Dec 16 2015

pjd committed rS292310: Keep maintainance of GELI and make it clear which directories I'm interested in..
Keep maintainance of GELI and make it clear which directories I'm interested in.
Dec 16 2015, 1:06 AM

Oct 25 2015

pjd committed rS289941: The aio_waitcomplete(2) syscall should not sleep when the given timeout.
The aio_waitcomplete(2) syscall should not sleep when the given timeout
Oct 25 2015, 6:48 PM

Oct 21 2015

pjd updated the diff for D3814: aio_waitcomplete(2) should not sleep when timeout is not NULL, but set to 0..

Thanks John, both good suggestions.

Oct 21 2015, 9:27 PM

Oct 5 2015

pjd retitled D3814: aio_waitcomplete(2) should not sleep when timeout is not NULL, but set to 0. from to aio_waitcomplete(2) should not sleep when timeout is not NULL, but set to 0..
Oct 5 2015, 5:04 PM
pjd accepted D1888: Extend the unit test to fix the bug caught in r277925.
Oct 5 2015, 4:53 PM

Oct 4 2015

pjd committed rS288644: Add a little, but very useful script for use with programs that work using an.
Add a little, but very useful script for use with programs that work using an
Oct 4 2015, 12:40 AM

Aug 8 2015

pjd committed rS286445: Allow to disable BIO_DELETE passthru in fstab for swap-on-geli devices by.
Allow to disable BIO_DELETE passthru in fstab for swap-on-geli devices by
Aug 8 2015, 9:57 AM
pjd committed rS286444: Enable BIO_DELETE passthru in GELI, so TRIM/UNMAP can work as expected when.
Enable BIO_DELETE passthru in GELI, so TRIM/UNMAP can work as expected when
Aug 8 2015, 9:51 AM

Aug 6 2015

pjd committed rS286373: After crypto_dispatch() bio might be already delivered and destroyed,.
After crypto_dispatch() bio might be already delivered and destroyed,
Aug 6 2015, 5:13 PM

Jul 10 2015

pjd committed rS285363: Spoil even can happen for some time now even on providers opened exclusively.
Spoil even can happen for some time now even on providers opened exclusively
Jul 10 2015, 7:27 PM

Jul 2 2015

pjd committed rS285024: Properly propagate errors in metadata reading..
Properly propagate errors in metadata reading.
Jul 2 2015, 10:57 AM
pjd committed rS285023: Allow to omit keyfile number for the first keyfile..
Allow to omit keyfile number for the first keyfile.
Jul 2 2015, 10:55 AM

Jun 2 2015

pjd committed rS283928: MFC r265950 (by thomas):.
MFC r265950 (by thomas):
Jun 2 2015, 8:30 PM

Apr 22 2015

pjd committed rS281856: Welcome Mariusz Zaborski (oshogbo) as a new src committer. Mariusz will be.
Welcome Mariusz Zaborski (oshogbo) as a new src committer. Mariusz will be
Apr 22 2015, 4:06 PM

Feb 19 2015

pjd added inline comments to D1879: Don't allocate memory for operations that do not insert.
Feb 19 2015, 8:50 AM
pjd added a comment to D1878: Add function to force an nvlist into the error state.

Other that the minor nit above, it looks good.

Feb 19 2015, 8:44 AM
pjd added inline comments to D1877: Implement asprintf in libkern.
Feb 19 2015, 8:41 AM
pjd accepted D1876: Add tests for dnvlist_take_*.

Looks good.

Feb 19 2015, 8:39 AM
pjd accepted D1875: Add tests for dnv_get_*.

Looks good.

Feb 19 2015, 8:37 AM
pjd accepted D1874: Add tests for nvlist_free* functions.

Looks good.

Feb 19 2015, 8:32 AM
pjd accepted D1873: Add tests for nvlist_take_*.

Looks good.

Feb 19 2015, 8:31 AM
pjd accepted D1871: Add tests for nvlist_pack/unpack.
Feb 19 2015, 7:58 AM
pjd accepted D1872: Add test cases for nvlist_move_*.

Looks good to me.

Feb 19 2015, 7:49 AM
pjd added a comment to D1871: Add tests for nvlist_pack/unpack.

Looks good to me.

Feb 19 2015, 7:48 AM
pjd added inline comments to D1870: Add tests for nvlist_clone.
Feb 19 2015, 7:41 AM
pjd added a comment to D1869: Tests of basic nvlist add functions.

I like it.

Feb 19 2015, 7:36 AM
pjd added a comment to D1868: Make libnv headers includable from C++.

Looks good to me, apart from the small nit above.

Feb 19 2015, 7:23 AM

Nov 16 2014

pjd added a comment to D1009: Enter capability mode and limit descriptors in elfdump(1).

Overall looks good to me. I do agree with Jonathan that we should also limit std descriptors. You can find example in the go_daemon() function in sbin/dhclient/dhclient.c.

Nov 16 2014, 5:53 AM

Nov 12 2014

pjd accepted D1150: Fix geom help output.

Macro goatforit:

Nov 12 2014, 10:50 PM