- User Since
- Sep 26 2014, 6:56 AM (220 w, 10 h)
Fri, Dec 7
Oct 20 2018
Change looks good, my only suggestion would be to use maybe NAME2ADDR and ADDR2NAME, so the intentions are obvious.
Oct 4 2018
Jul 13 2018
Jul 10 2018
Revert style changes.
Remove #ifdef INET checks from radlib.h, it prevents some consumers from compiling.
Implement some of oshogbo suggestions.
- Allow for optional compilation without IPv4 or IPv6 support.
- Make it possible to use IPv6 addresses in configuration file.
- Call getaddrinfo(3) with flags set to AI_ADDRCONFIG.
You are probably talking about this one: https://markmail.org/message/e3zkukh7oggutrvw
I've tried it, but it is very out-dated and has some bugs. It also keeps server on a TAILQ, which is nice, but I don't think it should be combined. The nice thing about that patch was to add multiple servers when a hostname resolves to multiple IP addresses, which I also implemented.
Jul 9 2018
Feb 3 2017
I agree with delphij that we should not introduce lower limit.
Looks good, but I agree that hastctl should use libmd too in that case.
Could you please explain why you implemented that in the kernel and not in userland geli command?
Nov 8 2016
May 31 2016
Apr 3 2016
Apr 2 2016
Feb 24 2016
Dec 29 2015
It looks good overall, but please be sure you run GELI regression tests. Thanks!
Dec 16 2015
Oct 25 2015
Oct 21 2015
Thanks John, both good suggestions.
Oct 5 2015
Oct 4 2015
Aug 8 2015
Aug 6 2015
Jul 10 2015
Jul 2 2015
Jun 2 2015
Apr 22 2015
Feb 19 2015
Other that the minor nit above, it looks good.
Looks good to me.
Looks good to me, apart from the small nit above.
Nov 16 2014
Overall looks good to me. I do agree with Jonathan that we should also limit std descriptors. You can find example in the go_daemon() function in sbin/dhclient/dhclient.c.