Differential D43529

Add kern_openatfp(9)
ClosedPublic
Actions

Authored by kib on Jan 20 2024, 8:39 PM.

Tags

None

Referenced Files

	F139172876: D43529.id133106.diff
	Mon, Dec 8, 10:25 PM

	Unknown Object (File)
	Tue, Dec 2, 5:02 PM

	Unknown Object (File)
	Thu, Nov 27, 8:03 AM

	Unknown Object (File)
	Sun, Nov 23, 6:52 AM

	Unknown Object (File)
	Sun, Nov 23, 6:48 AM

	Unknown Object (File)
	Sun, Nov 23, 6:48 AM

	Unknown Object (File)
	Sun, Nov 23, 6:48 AM

	Unknown Object (File)
	Sun, Nov 23, 6:48 AM

Subscribers

Details

Reviewers

markj
pjd

Commits

rGc662306e19ce: Add kern_openatfp(9)
rG2a284076ecb4: kern_openat(): rename fd argument to dirfd
rG3d59b93b207e: kern_openat(): minor style fixes

Summary

See https://github.com/openzfs/zfs/pull/15630

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Jan 20 2024, 8:39 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 20 2024, 8:39 PM

kib requested review of this revision.Jan 20 2024, 8:39 PM

Thank you for working on this!

sys/kern/vfs_syscalls.c
1234	Personally I'd just add 'return (0)' here and eliminate 'else' below, which would reduce the diff. I also don't see '*fpp = fp' anywhere.

This revision now requires changes to proceed.Jan 20 2024, 9:59 PM

Do assign *fpp.

Herald added subscribers: glebius, melifaro, ae. · View Herald TranscriptJan 20 2024, 10:14 PM

Fix diff generation.

pjd accepted this revision.Jan 20 2024, 10:21 PM

This revision is now accepted and ready to land.Jan 20 2024, 10:21 PM

markj added inline comments.Jan 22 2024, 2:51 PM

sys/kern/vfs_syscalls.c
1116
1275	Is there a specific scenario you are guarding against here?

kib marked 2 inline comments as done.Jan 22 2024, 10:00 PM

kib added inline comments.

sys/kern/vfs_syscalls.c
1275	Recursing into VFS, which we sort of explicitly enable there with a backdoor into filesystem driver VOP_CREATE/VOP_OPEN. It is similar how td_fpop is handled for devfs, to avoid unlikely but hard to diagnose surprises.

markj accepted this revision.Jan 23 2024, 2:33 PM

Closed by commit rG3d59b93b207e: kern_openat(): minor style fixes (authored by kib). · Explain WhyJan 24 2024, 5:13 AM

This revision was automatically updated to reflect the committed changes.

kib marked an inline comment as done.

kib added a commit: rG3d59b93b207e: kern_openat(): minor style fixes.

kib added a commit: rG2a284076ecb4: kern_openat(): rename fd argument to dirfd.

kib added a commit: rGc662306e19ce: Add kern_openatfp(9).

GitHub <noreply@github.com> mentioned this in rGa4bf6baaeb70: Fix file descriptor leak on pool import..Jan 24 2024, 11:39 AM

Brian Behlendorf <behlendorf1@llnl.gov> mentioned this in rG3425484eb907: Fix file descriptor leak on pool import..Feb 23 2024, 10:40 AM

Revision Contents
Changeset List

Path

Size

sys/

kern/

6 lines

Diff 133252

sys/kern/vfs_syscalls.c

Loading...