sbin/nos-tun: correct SIOCDIFADDR calls to use ifreq
ClosedPublic
Actions

Authored by def on Jul 18 2024, 2:57 PM.

Tags

None

Referenced Files

	F166267623: D46017.diff
	Wed, Aug 12, 3:23 PM

	F166267605: D46017.diff
	Wed, Aug 12, 3:23 PM

	Unknown Object (File)
	Tue, Aug 11, 7:16 PM

	Unknown Object (File)
	Sun, Aug 9, 10:03 AM

	Unknown Object (File)
	Sun, Aug 2, 5:02 AM

	Unknown Object (File)
	Sun, Aug 2, 4:04 AM

	Unknown Object (File)
	Sat, Aug 1, 6:15 AM

	Unknown Object (File)
	Sat, Aug 1, 1:27 AM

View All Files

Subscribers

imp

Details

Reviewers

brooks
oshogbo
phk
jhb

Commits

rGbb8fa2ef83c9: sbin/nos-tun: correct SIOCDIFADDR calls to use ifreq

Summary

The SIOCDIFADDR ioctl takes an ifreq structure object, not an ifaliasreq
structure object, as its argument.

Obtained from: CheriBSD

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

def created this revision.Jul 18 2024, 2:57 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 18 2024, 2:57 PM

def requested review of this revision.Jul 18 2024, 2:57 PM

Harbormaster completed remote builds in B58700: Diff 141072.Jul 18 2024, 2:57 PM

brooks accepted this revision.Jul 18 2024, 9:04 PM

This revision is now accepted and ready to land.Jul 18 2024, 9:04 PM

def mentioned this in D46018: usr.sbin/ppp: correct SIOCDIFADDR{,_IN6} calls to use {,in6_}ifreq.Jul 19 2024, 3:51 PM

jhb accepted this revision.Jul 19 2024, 3:53 PM

oshogbo accepted this revision.Jul 22 2024, 7:23 AM

Closed by commit rGbb8fa2ef83c9: sbin/nos-tun: correct SIOCDIFADDR calls to use ifreq (authored by def). · Explain WhyJul 22 2024, 10:04 AM

This revision was automatically updated to reflect the committed changes.

def added a commit: rGbb8fa2ef83c9: sbin/nos-tun: correct SIOCDIFADDR calls to use ifreq.

Revision Contents
Changeset List

Path

Size

sbin/

nos-tun/

nos-tun.c

8 lines

Diff 141213

View Options

sbin/nos-tun: correct SIOCDIFADDR calls to use ifreqClosedPublicActions