dtrace/arm64: properly traverse the symbol table

[def]

Summary

dtrace/arm64: properly traverse the symbol table

LINKER_EACH_FUNCTION_NAMEVAL() stops processing the symbol table if a
callback function returns a non-zero value.

The fbt_provide_module_function() callback should not return 1 when
ignoring symbols. Instead, always return 0, as in dtrace/x86.

[markj]

It would be nice to add a Fixes tag here.

[def]

Include Fixes in the commit message.

[def]

In D53399#1219487, @markj wrote:

It would be nice to add a Fixes tag here.

@markj Does it make sense now?

[jrtc27]

You need to actually edit the description in Phabricator; arc diff won't do it for you if you just amend the commit locally.

[def]

In D53399#1219906, @jrtc27 wrote:

You need to actually edit the description in Phabricator; arc diff won't do it for you if you just amend the commit locally.

When I try to update the review description, I get the error:

The value you have entered in "Summary" can not be parsed unambiguously when rendered in a commit message. Edit the message so that keywords like "Summary:" and "Test Plan:" do not appear at the beginning of lines. Parsed keys: reviewedByPHIDs, revisionID.

I updated it instead not to include any tags from the commit message -- the commit itself is fixed now.

[markj]

In D53399#1219983, @def wrote:

In D53399#1219906, @jrtc27 wrote:

You need to actually edit the description in Phabricator; arc diff won't do it for you if you just amend the commit locally.

When I try to update the review description, I get the error:

The value you have entered in "Summary" can not be parsed unambiguously when rendered in a commit message. Edit the message so that keywords like "Summary:" and "Test Plan:" do not appear at the beginning of lines. Parsed keys: reviewedByPHIDs, revisionID.

I updated it instead not to include any tags from the commit message -- the commit itself is fixed now.

Hum, ok. Maybe point to the commit on github or similar? If you're confident it's right just go ahead and push.

[def]

In D53399#1220059, @markj wrote:

In D53399#1219983, @def wrote:

In D53399#1219906, @jrtc27 wrote:

You need to actually edit the description in Phabricator; arc diff won't do it for you if you just amend the commit locally.

When I try to update the review description, I get the error:

The value you have entered in "Summary" can not be parsed unambiguously when rendered in a commit message. Edit the message so that keywords like "Summary:" and "Test Plan:" do not appear at the beginning of lines. Parsed keys: reviewedByPHIDs, revisionID.

I updated it instead not to include any tags from the commit message -- the commit itself is fixed now.

Hum, ok. Maybe point to the commit on github or similar? If you're confident it's right just go ahead and push.

If you click the Commits tab in the Revision Contents section in this review, you will see the current commit message. A GitHub page for this commit is:
https://github.com/kwitaszczyk/freebsd-src/commit/374e36799bab1803ae6d0205e06bbc802668c11f

[markj]

In D53399#1220341, @def wrote:

In D53399#1220059, @markj wrote:

In D53399#1219983, @def wrote:

In D53399#1219906, @jrtc27 wrote:

You need to actually edit the description in Phabricator; arc diff won't do it for you if you just amend the commit locally.

When I try to update the review description, I get the error:

The value you have entered in "Summary" can not be parsed unambiguously when rendered in a commit message. Edit the message so that keywords like "Summary:" and "Test Plan:" do not appear at the beginning of lines. Parsed keys: reviewedByPHIDs, revisionID.

I updated it instead not to include any tags from the commit message -- the commit itself is fixed now.

Hum, ok. Maybe point to the commit on github or similar? If you're confident it's right just go ahead and push.

If you click the Commits tab in the Revision Contents section in this review, you will see the current commit message. A GitHub page for this commit is:
https://github.com/kwitaszczyk/freebsd-src/commit/374e36799bab1803ae6d0205e06bbc802668c11f

Perfect, thank you.