Page MenuHomeFreeBSD

rwatson (Robert Watson)
User

Projects (9)

User Details

User Since
Jul 28 2014, 7:43 PM (366 w, 9 h)

Recent Activity

May 30 2021

rwatson updated subscribers of D30550: RISC-V pmap: remove incorrect assertions in pmap_demote_l2_locked.
May 30 2021, 2:47 PM · riscv

Apr 25 2021

rwatson committed R10:8e491aaeac6e: Add code examples to cpuset(2), and improve cross referencing. (authored by rwatson).
Add code examples to cpuset(2), and improve cross referencing.
Apr 25 2021, 2:22 PM
rwatson closed D27803: Add a code example to cpuset(2) showing how to modify the affinity of the current process. Improve cross referencing..
Apr 25 2021, 2:22 PM
rwatson added inline comments to D27803: Add a code example to cpuset(2) showing how to modify the affinity of the current process. Improve cross referencing..
Apr 25 2021, 7:49 AM
rwatson updated the diff for D27803: Add a code example to cpuset(2) showing how to modify the affinity of the current process. Improve cross referencing..
  • Fix grammar nit spotted by @jrtc27.
Apr 25 2021, 7:48 AM

Apr 24 2021

rwatson committed R10:af14713d49fd: Support run-time configuration of the PIPE_MINDIRECT threshold. (authored by rwatson).
Support run-time configuration of the PIPE_MINDIRECT threshold.
Apr 24 2021, 7:05 PM
rwatson closed D29819: Support run-time configuration of the PIPE_MINDIRECT threshold..
Apr 24 2021, 7:05 PM
rwatson updated the diff for D29819: Support run-time configuration of the PIPE_MINDIRECT threshold..
  • Style fix: Differentiate arbitrary integer values from booleans.
Apr 24 2021, 3:32 PM

Apr 23 2021

rwatson updated the diff for D29819: Support run-time configuration of the PIPE_MINDIRECT threshold..

Type consistency.

Apr 23 2021, 10:13 PM
rwatson updated the diff for D29819: Support run-time configuration of the PIPE_MINDIRECT threshold..

Whitespace fix.

Apr 23 2021, 10:11 PM
rwatson updated the diff for D29819: Support run-time configuration of the PIPE_MINDIRECT threshold..

Use a sysctl handler to limit possible values of kern.ipc.pipe_mindirect.

Apr 23 2021, 10:10 PM

Apr 18 2021

rwatson added a comment to D29819: Support run-time configuration of the PIPE_MINDIRECT threshold..

pipe.h has:

/*
 * PIPE_MINDIRECT MUST be smaller than PIPE_SIZE and MUST be bigger
 * than PIPE_BUF.
 */

Do we need to do any validation of the value?

Apr 18 2021, 3:10 PM
rwatson requested review of D29819: Support run-time configuration of the PIPE_MINDIRECT threshold..
Apr 18 2021, 11:52 AM

Apr 11 2021

rwatson updated the diff for D27803: Add a code example to cpuset(2) showing how to modify the affinity of the current process. Improve cross referencing..

Sundry tweaks from @jrtc27.

Apr 11 2021, 10:09 AM

Mar 26 2021

rwatson added a comment to D27971: Remove history.immutable from .arcconfig.

Workaround: arc set-config --local history.immutable false. However that won't work if you have a git worktree :( To work around that you need to patch arcanist since upstream doesn't want any contributions (https://secure.phabricator.com/D21438)

I haven't had time to check this, but if we really need to patch arc, we can patch it locally in ports.

Mar 26 2021, 11:04 PM

Mar 23 2021

rwatson closed D29369: Teach DTrace that unaligned accesses are allowed on aarch64, not just x86..
Mar 23 2021, 12:00 AM

Mar 22 2021

rwatson committed R10:fb581531c1a0: Teach DTrace that unaligned accesses are OK on aarch64, not just x86. (authored by rwatson).
Teach DTrace that unaligned accesses are OK on aarch64, not just x86.
Mar 22 2021, 11:59 PM
rwatson committed R10:599fb1d198ec: Tune DTrace 'aframes' for the FBT and profile providers on arm64. (authored by rwatson).
Tune DTrace 'aframes' for the FBT and profile providers on arm64.
Mar 22 2021, 11:51 PM
rwatson added a comment to D29369: Teach DTrace that unaligned accesses are allowed on aarch64, not just x86..

I wonder if we should be checking for __NO_STRICT_ALIGNMENT (and defining it for architectures other than x86)

Mar 22 2021, 1:29 PM
rwatson updated subscribers of D29369: Teach DTrace that unaligned accesses are allowed on aarch64, not just x86..
Mar 22 2021, 1:51 AM
rwatson requested review of D29369: Teach DTrace that unaligned accesses are allowed on aarch64, not just x86..
Mar 22 2021, 1:51 AM

Mar 21 2021

rwatson added a reviewer for D29356: Tune DTrace 'aframes' for the FBT and profile providers on arm64.: ARM.
Mar 21 2021, 1:43 PM
rwatson added a reviewer for D29356: Tune DTrace 'aframes' for the FBT and profile providers on arm64.: DTrace.
Mar 21 2021, 12:08 AM
rwatson requested review of D29356: Tune DTrace 'aframes' for the FBT and profile providers on arm64..
Mar 21 2021, 12:08 AM

Feb 28 2021

rwatson added inline comments to D28980: Add VOP_READ_PGCACHE(9).
Feb 28 2021, 11:11 PM
rwatson accepted D28980: Add VOP_READ_PGCACHE(9).
Feb 28 2021, 6:13 PM
rwatson requested changes to D28980: Add VOP_READ_PGCACHE(9).
Feb 28 2021, 10:21 AM

Feb 27 2021

rwatson committed R10:a9f11355038c: Add Xrefs to the new VOP_SETLABEL(9) from mac(9) and vnode(9). (authored by rwatson).
Add Xrefs to the new VOP_SETLABEL(9) from mac(9) and vnode(9).
Feb 27 2021, 4:55 PM
rwatson committed R10:7bfd84444e6f: Provide a man page for VOP_SETLABEL(9). (authored by rwatson).
Provide a man page for VOP_SETLABEL(9).
Feb 27 2021, 4:53 PM
rwatson committed R10:a92c6b24c0e9: Add a comment on why the call to mac_vnode_relabel() might be in the wrong (authored by rwatson).
Add a comment on why the call to mac_vnode_relabel() might be in the wrong
Feb 27 2021, 4:26 PM

Feb 25 2021

rwatson committed R10:97bfffafda88: Reimplement FreeBSD/arm64 dtrace_gethrtime() to use the system timer. (authored by rwatson).
Reimplement FreeBSD/arm64 dtrace_gethrtime() to use the system timer.
Feb 25 2021, 10:32 PM
rwatson committed R10:bbcdd9faca55: Reimplemen FreeBSD/arm64 dtrace_gethrtime() to use the system timer. (authored by rwatson).
Reimplemen FreeBSD/arm64 dtrace_gethrtime() to use the system timer.
Feb 25 2021, 9:42 PM
rwatson closed D28723: Reimplement dtrace_gethrtime() on arm64 to use the cycle counter..
Feb 25 2021, 9:42 PM

Feb 19 2021

rwatson committed R10:c3feaeaa32c9: Reimplement the arm64 dtrace_gethrtime(), which provides the (authored by rwatson).
Reimplement the arm64 dtrace_gethrtime(), which provides the
Feb 19 2021, 7:55 PM

Feb 18 2021

rwatson updated the diff for D28723: Reimplement dtrace_gethrtime() on arm64 to use the cycle counter..
  • Rename local variable as it holds the systen clock count rather than the cycle counter.
Feb 18 2021, 10:52 PM

Feb 17 2021

rwatson added a comment to D28723: Reimplement dtrace_gethrtime() on arm64 to use the cycle counter..

Is dtrace_gethrtime run while pinned to a single CPU? My readding of the spec is that it should be identical over all cores as it's based on the system counter, although it this is not the case it could lead to interesting results.

Certainly in the DTrace probe context, the thread is pinned and has interrupts disabled. However, I will check and see if it’s possibly called from non-probe contexts. However, my reading was that this counter should be OK to use in this way. I also confirmed on the RPi4 that the rate is invariant despite CPU clock frequency changes, across multi core.

Feb 17 2021, 10:13 PM
rwatson added a comment to D28723: Reimplement dtrace_gethrtime() on arm64 to use the cycle counter..

Is dtrace_gethrtime run while pinned to a single CPU? My readding of the spec is that it should be identical over all cores as it's based on the system counter, although it this is not the case it could lead to interesting results.

Feb 17 2021, 8:50 PM
rwatson added a comment to D28723: Reimplement dtrace_gethrtime() on arm64 to use the cycle counter..
In D28723#643374, @imp wrote:

Seems legit, so long as freq is returned in GHz

freq is Hz, the 1000000000UL is to turn the s into ns.

Feb 17 2021, 8:47 PM
rwatson updated subscribers of D28723: Reimplement dtrace_gethrtime() on arm64 to use the cycle counter..
Feb 17 2021, 2:21 AM
rwatson requested review of D28723: Reimplement dtrace_gethrtime() on arm64 to use the cycle counter..
Feb 17 2021, 2:20 AM

Feb 14 2021

rwatson accepted D28658: procstat: distinguish vm map guards in procstat vm output..

LGTM. Thanks!

Feb 14 2021, 12:46 AM

Jan 24 2021

rwatson added a comment to D27803: Add a code example to cpuset(2) showing how to modify the affinity of the current process. Improve cross referencing..

I’d like to think about committing this, if folk wouldn’t mind updating their reviews, with the following commit message:

Jan 24 2021, 12:13 AM
rwatson updated the diff for D27803: Add a code example to cpuset(2) showing how to modify the affinity of the current process. Improve cross referencing..

Update to reflect correct calendar year (courtesy @jrtc27).

Jan 24 2021, 12:12 AM

Jan 19 2021

rwatson committed R10:adc96a51a553: Add a new FreeBSD/arm64 kernel configuration, GENERIC-MMCCAM-NODEBUG, (authored by rwatson).
Add a new FreeBSD/arm64 kernel configuration, GENERIC-MMCCAM-NODEBUG,
Jan 19 2021, 10:26 PM
rwatson closed D28091: Add -NODEBUG variant of GENERIC-MMCCAM kernel configuration..
Jan 19 2021, 10:26 PM

Jan 16 2021

rwatson added a comment to D27803: Add a code example to cpuset(2) showing how to modify the affinity of the current process. Improve cross referencing..

I've made a number of updates to the patch as a result of comments and suggestions. It would be especially useful if @jeff could review the code and descriptions to make sure I've correctly interpreted his comments and also not written buggy code.

Jan 16 2021, 1:20 PM
rwatson updated the diff for D27803: Add a code example to cpuset(2) showing how to modify the affinity of the current process. Improve cross referencing..

Actually use CPU 0 as suggested in the comments, not CPU 1.

Jan 16 2021, 1:19 PM
rwatson added a comment to D27803: Add a code example to cpuset(2) showing how to modify the affinity of the current process. Improve cross referencing..

Comments from @kevans now (believed) addressed relating to cpuset(9) macros.

Jan 16 2021, 1:10 PM
rwatson updated the diff for D27803: Add a code example to cpuset(2) showing how to modify the affinity of the current process. Improve cross referencing..

Based on comments from @kevans, explicitly Xref cpuset(2), and correct
mention of CPU_CLR(9) to CPU_ZERO(9).

Jan 16 2021, 1:10 PM
rwatson added a comment to D27803: Add a code example to cpuset(2) showing how to modify the affinity of the current process. Improve cross referencing..

Some updates on the patch correcting problems found by @0mp and @jrtc27. Thanks!

Jan 16 2021, 1:04 PM
rwatson updated the diff for D27803: Add a code example to cpuset(2) showing how to modify the affinity of the current process. Improve cross referencing..

Improve whitespace conformance to style(9), courtesy @jrtc27.

Jan 16 2021, 1:03 PM
rwatson updated the diff for D27803: Add a code example to cpuset(2) showing how to modify the affinity of the current process. Improve cross referencing..

Following feedback from jeff, break the example into two:

Jan 16 2021, 1:02 PM
rwatson updated the diff for D28091: Add -NODEBUG variant of GENERIC-MMCCAM kernel configuration..

Following R10:6eebda3bbad9, update this patch to use std.nodebug, which is
much preferred.

Jan 16 2021, 12:44 PM

Jan 13 2021

rwatson added a comment to D28091: Add -NODEBUG variant of GENERIC-MMCCAM kernel configuration..

Hm, my instinct would be to make it include GENERIC-MMCCAM instead and then turn of debugging, especially given the name.

Jan 13 2021, 10:20 PM

Jan 11 2021

rwatson closed D27766: Various changes to DTrace FBT to avoid crashed on FreeBSD/arm64..
Jan 11 2021, 3:45 PM · arm64, DTrace
rwatson committed R10:30b68ecda84e: Changes that improve DTrace FBT reliability on freebsd/arm64: (authored by rwatson).
Changes that improve DTrace FBT reliability on freebsd/arm64:
Jan 11 2021, 3:45 PM
rwatson updated the diff for D27766: Various changes to DTrace FBT to avoid crashed on FreeBSD/arm64..

Trim exclusion of memcpy() and bcopy() as @andrew's in-progress patch to
avoid improper FBT instrumentation of functions without conventional stack
frames now solves that problem in a better way.

Jan 11 2021, 3:38 PM · arm64, DTrace
rwatson updated the diff for D28091: Add -NODEBUG variant of GENERIC-MMCCAM kernel configuration..

Update comment for new kernel name.

Jan 11 2021, 2:56 PM
rwatson added a reviewer for D27766: Various changes to DTrace FBT to avoid crashed on FreeBSD/arm64.: jrtc27.
Jan 11 2021, 8:51 AM · arm64, DTrace
rwatson requested review of D28091: Add -NODEBUG variant of GENERIC-MMCCAM kernel configuration..
Jan 11 2021, 8:38 AM

Jan 10 2021

rwatson added a comment to D27766: Various changes to DTrace FBT to avoid crashed on FreeBSD/arm64..

Candidate commit message (will update Reviewed by notes as needed):

Jan 10 2021, 12:34 PM · arm64, DTrace
rwatson updated the diff for D27766: Various changes to DTrace FBT to avoid crashed on FreeBSD/arm64..

Updates to candidate commit message.

Jan 10 2021, 12:32 PM · arm64, DTrace
rwatson abandoned D27945: Improvements to HWPMC support on FreeBSD/arm64 to handle counter wraparound.

A modified version of this merged in recent changes by @andrew.

Jan 10 2021, 12:24 PM · arm64
rwatson committed R10:4f2cbaf3cd59: Track pipe(2) reads and writes as rusage message receives and sends, a (authored by rwatson).
Track pipe(2) reads and writes as rusage message receives and sends, a
Jan 10 2021, 12:17 PM
rwatson closed D27878: Track pipe(3) I/O in rusage.
Jan 10 2021, 12:17 PM
rwatson added inline comments to D27766: Various changes to DTrace FBT to avoid crashed on FreeBSD/arm64..
Jan 10 2021, 9:50 AM · arm64, DTrace
rwatson updated the diff for D27766: Various changes to DTrace FBT to avoid crashed on FreeBSD/arm64..
  • Since non-aarch64 haven't required a memcpy() exclusion in the past, don't exclude it now.
Jan 10 2021, 9:48 AM · arm64, DTrace
rwatson updated the diff for D27766: Various changes to DTrace FBT to avoid crashed on FreeBSD/arm64..

Various fixes to the DTrace FBT provider on FreeBSD/arm64:

Jan 10 2021, 9:30 AM · arm64, DTrace

Jan 8 2021

rwatson added a comment to D27878: Track pipe(3) I/O in rusage.
In D27878#626721, @imp wrote:

I believe these are good places to add the accounting. They do assume that ANY read or ANY write, even one that also have an error, counts as a message rcv or snd, but I think that's OK.

Jan 8 2021, 10:23 PM
rwatson added inline comments to D27878: Track pipe(3) I/O in rusage.
Jan 8 2021, 10:04 PM
rwatson updated the diff for D27878: Track pipe(3) I/O in rusage.

Shift points where we count messages received or sent to the end of
pipe_read() and pipe_write() so that they count only messages that were
definitely processed. This is somewhat stronger semantics than are
provided for sockets, but since it costs neglibly more to do this, and
the results are potentially more useful, go with that.

Jan 8 2021, 10:02 PM

Jan 3 2021

rwatson retitled D27945: Improvements to HWPMC support on FreeBSD/arm64 to handle counter wraparound from Starting with a patch from Andrew Turner and Ruslan Bukin to improve HWPMCsupport for ARMv8-A counter wraparound: to Improvements to HWPMC support on FreeBSD/arm64 to handle counter wraparound.
Jan 3 2021, 9:29 PM · arm64
rwatson retitled D27945: Improvements to HWPMC support on FreeBSD/arm64 to handle counter wraparound from Starting with a patch from Andrew Turner and Ruslan Bukin to improve HWPMC support for ARMv8-A counter wraparound: to Starting with a patch from Andrew Turner and Ruslan Bukin to improve HWPMCsupport for ARMv8-A counter wraparound:.
Jan 3 2021, 9:29 PM · arm64
rwatson requested review of D27945: Improvements to HWPMC support on FreeBSD/arm64 to handle counter wraparound.
Jan 3 2021, 9:27 PM · arm64

Jan 2 2021

rwatson added a comment to D27727: arm64: gdb(4) stub.

An FYI rather than a review: I'm using these patches successfully on my RPi4, and it's proving invaluable. I'm eager to see these committed back to the main tree as soon as everyone feels ready.

Jan 2 2021, 2:03 PM

Jan 1 2021

rwatson added inline comments to D27766: Various changes to DTrace FBT to avoid crashed on FreeBSD/arm64..
Jan 1 2021, 1:25 PM · arm64, DTrace
rwatson updated the diff for D27878: Track pipe(3) I/O in rusage.

Move to freebsd/main from old freebsd/master.

Jan 1 2021, 1:15 PM
rwatson retitled D27878: Track pipe(3) I/O in rusage from Track pipe(2) reads and writes as rusage message receives and sends, a feature misplaced during the transition from BSD 4.4's socket implementation to the optimised FreeBSD pipe implementation. to Track pipe(3) I/O in rusage.
Jan 1 2021, 12:40 PM
rwatson requested review of D27878: Track pipe(3) I/O in rusage.
Jan 1 2021, 12:38 PM

Dec 28 2020

rwatson requested review of D27803: Add a code example to cpuset(2) showing how to modify the affinity of the current process. Improve cross referencing..
Dec 28 2020, 10:43 PM

Dec 26 2020

rwatson added a reviewer for D27766: Various changes to DTrace FBT to avoid crashed on FreeBSD/arm64.: kp.
Dec 26 2020, 5:15 PM · arm64, DTrace

Dec 24 2020

rwatson updated the summary of D27766: Various changes to DTrace FBT to avoid crashed on FreeBSD/arm64..
Dec 24 2020, 7:37 PM · arm64, DTrace
rwatson added a reviewer for D27766: Various changes to DTrace FBT to avoid crashed on FreeBSD/arm64.: andrew.
Dec 24 2020, 7:32 PM · arm64, DTrace
rwatson added projects to D27766: Various changes to DTrace FBT to avoid crashed on FreeBSD/arm64.: DTrace, arm64.
Dec 24 2020, 5:31 PM · arm64, DTrace
rwatson requested review of D27766: Various changes to DTrace FBT to avoid crashed on FreeBSD/arm64..
Dec 24 2020, 5:30 PM · arm64, DTrace

Dec 13 2020

rwatson committed R9:71a397515b90: De-contributor-ified myself, en-committer-ified myself. (authored by rwatson).
De-contributor-ified myself, en-committer-ified myself.
Dec 13 2020, 7:49 PM
rwatson committed R9:644efe1be98f: Per Nik's request, expand a little on the newsflash ``New Committer'' (authored by rwatson).
Per Nik's request, expand a little on the newsflash ``New Committer''
Dec 13 2020, 7:46 PM
rwatson committed R9:d25ba5059d56: o "Formulate a specific query" -> "Search problem reports", it's more (authored by rwatson).
o "Formulate a specific query" -> "Search problem reports", it's more
Dec 13 2020, 7:30 PM
rwatson committed R9:4c7d7aeca29c: Add myself to entity list. (authored by rwatson).
Add myself to entity list.
Dec 13 2020, 7:25 PM
rwatson committed R9:84c9a07e37eb: o Add the pipe implementation to the list of targets to lock. It isn't (authored by rwatson).
o Add the pipe implementation to the list of targets to lock. It isn't
Dec 13 2020, 7:25 PM
rwatson committed R9:154460de9548: Note that the sysctl tree is not locked down, nor are its access (authored by rwatson).
Note that the sysctl tree is not locked down, nor are its access
Dec 13 2020, 7:25 PM
rwatson committed R9:399b55743d78: Add fast-path Giant push-down activity for VOP_READ() and VOP_WRITE(). (authored by rwatson).
Add fast-path Giant push-down activity for VOP_READ() and VOP_WRITE().
Dec 13 2020, 7:25 PM
rwatson committed R9:0cca4ba83c24: Add a lock contention measuring tool to the list of desirable features (authored by rwatson).
Add a lock contention measuring tool to the list of desirable features
Dec 13 2020, 7:25 PM
rwatson committed R9:57835c436a27: Add an entity for Andrew Reiter, since he's interested in supporting (authored by rwatson).
Add an entity for Andrew Reiter, since he's interested in supporting
Dec 13 2020, 7:25 PM
rwatson committed R9:0b17eb790cd5: Note Matt's pushing down of Giant into the FreeBSD ABI in October of 2001. (authored by rwatson).
Note Matt's pushing down of Giant into the FreeBSD ABI in October of 2001.
Dec 13 2020, 7:25 PM
rwatson committed R9:d53dccad0972: Alfred has grabbed the pipe locking task. (authored by rwatson).
Alfred has grabbed the pipe locking task.
Dec 13 2020, 7:25 PM
rwatson committed R9:738d64226938: Update SMP task list (authored by rwatson).
Update SMP task list
Dec 13 2020, 7:25 PM
rwatson committed R9:2dffcf033895: Mark in three more pieces of on-going work: (authored by rwatson).
Mark in three more pieces of on-going work:
Dec 13 2020, 7:25 PM
rwatson committed R9:27fc24f84ec8: Break out two more items explicitly from the old 'proc locking' entry: (authored by rwatson).
Break out two more items explicitly from the old 'proc locking' entry:
Dec 13 2020, 7:25 PM
rwatson committed R9:6dc17a998bdb: Add some more items: (authored by rwatson).
Add some more items:
Dec 13 2020, 7:25 PM