Page MenuHomeFreeBSD

Teach DTrace that unaligned accesses are allowed on aarch64, not just x86.
ClosedPublic

Authored by rwatson on Mar 22 2021, 1:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 13 2024, 11:43 AM
Unknown Object (File)
Dec 20 2023, 6:03 AM
Unknown Object (File)
Dec 14 2023, 10:39 PM
Unknown Object (File)
Dec 13 2023, 2:22 AM
Unknown Object (File)
Oct 29 2023, 11:35 AM
Unknown Object (File)
Sep 17 2023, 6:13 PM
Unknown Object (File)
Sep 2 2023, 9:51 PM
Unknown Object (File)
Sep 2 2023, 9:05 PM

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I wonder if we should be checking for __NO_STRICT_ALIGNMENT (and defining it for architectures other than x86)

I wonder if we should be checking for __NO_STRICT_ALIGNMENT (and defining it for architectures other than x86)

Hmm. I didn't know that existed.

I think it is the right goal, but I don't think we should aim for it in this patch. Not least, I'm not easily set up to test the various other cases covered by that define currently.

This revision is now accepted and ready to land.Mar 22 2021, 1:42 PM

I wonder if we should be checking for __NO_STRICT_ALIGNMENT (and defining it for architectures other than x86)

Hmm. I didn't know that existed.

I think it is the right goal, but I don't think we should aim for it in this patch. Not least, I'm not easily set up to test the various other cases covered by that define currently.

Note that the architecture must be truly totally alignment-agnostic for __NO_STRICT_ALIGNMENT to work. If aarch64 still has restrictions on some instructions (such as ldm/stm) the compiler may generate those for accessing network data in unaligned packet headers (I ran into this on arm32, where ipv6 address accesses got optimized into ldm instructions to load all 16 bytes at once).