Page MenuHomeFreeBSD

ian (Ian Lepore)
User

Projects

User Details

User Since
May 11 2014, 1:02 PM (271 w, 4 h)

Recent Activity

Today

ian committed rS350203: Add support for setting the aging/frequency-offset register via sysctl..
Add support for setting the aging/frequency-offset register via sysctl.
Sun, Jul 21, 5:14 PM

Yesterday

ian committed rS350185: Rewrite the nxprtc chip init to extend battery life by using power-saving.
Rewrite the nxprtc chip init to extend battery life by using power-saving
Sat, Jul 20, 9:10 PM

Thu, Jul 18

ian committed rS350106: Fix a paste-o, set is212x = false for other chip types. Doh!.
Fix a paste-o, set is212x = false for other chip types. Doh!
Thu, Jul 18, 1:37 AM
ian committed rS350104: Handle the PCF2127 RTC chip the same as PCF2129 when init'ing the chip..
Handle the PCF2127 RTC chip the same as PCF2129 when init'ing the chip.
Thu, Jul 18, 1:31 AM

Tue, Jul 16

ian created D20975: Create a mechanism for encoding a system errno into the IIC_Exxxxx space.
Tue, Jul 16, 7:38 PM
D13293: Don't return IIC_Exxxxx status values to userspace is now accepted and ready to land.

Upon further reflection, I think the changes to iic(4) in this diff are correct and should be committed. The problem of iicbus_request_bus() returning an ambiguous mix of IIC_Exxxxx or errno values because of iicbus_poll() doing so is a separate problem and should be fixed separately.

Tue, Jul 16, 5:42 PM
D13293: Don't return IIC_Exxxxx status values to userspace now requires changes to proceed.

Unfortunately, the comment that says "all iicbus functions return IIC_Exxxxx status values" is incorrect. There is one exception which screws up this whole error-translation thing: iicbus_poll() can return an errno and the rather important errno values it might return, EINTR and ERESTART, have no corresponding IIC_Exxxxx value they could be translated to so that they can later be translated back.

Tue, Jul 16, 2:44 PM

Mon, Jul 15

ian committed rS350016: In nxprtc(4), use the countdown timer for better timekeeping resolution.
In nxprtc(4), use the countdown timer for better timekeeping resolution
Mon, Jul 15, 9:47 PM
ian committed rS350015: Fix nxprtc(4) on systems that support i2c repeat-start correctly..
Fix nxprtc(4) on systems that support i2c repeat-start correctly.
Mon, Jul 15, 9:41 PM

Sat, Jul 13

ian committed rS349976: Add an entry mentioning the permission/mode change to daily accounting files..
Add an entry mentioning the permission/mode change to daily accounting files.
Sat, Jul 13, 4:48 PM
ian committed rS349974: Limit access to system accounting files..
Limit access to system accounting files.
Sat, Jul 13, 4:08 PM
ian closed D20876: Limit access to system accounting files.
Sat, Jul 13, 4:07 PM
ian committed rD53250: Document bump to version 1300036 in r349972 for adding arm_drain_writebuf.
Document bump to version 1300036 in r349972 for adding arm_drain_writebuf
Sat, Jul 13, 3:49 PM
ian committed rS349972: Add arm_sync_icache() and arm_drain_writebuf() sysarch syscall wrappers..
Add arm_sync_icache() and arm_drain_writebuf() sysarch syscall wrappers.
Sat, Jul 13, 3:34 PM
ian closed D20906: Add arm_sync_icache() and arm_drain_writebuf() sysarch syscall wrappers..
Sat, Jul 13, 3:34 PM

Wed, Jul 10

ian added a comment to D20906: Add arm_sync_icache() and arm_drain_writebuf() sysarch syscall wrappers..

Add some details to the manpage about the barrier and cache operations performed by arm_drain_writebuf().

Wed, Jul 10, 11:02 PM
ian created D20906: Add arm_sync_icache() and arm_drain_writebuf() sysarch syscall wrappers..
Wed, Jul 10, 8:02 PM
ian committed rS349891: Reorganize the SRCS lists as one file per line, and then alphabetize them..
Reorganize the SRCS lists as one file per line, and then alphabetize them.
Wed, Jul 10, 7:33 PM
ian committed rS349887: De-pollute arm's sysarch.h..
De-pollute arm's sysarch.h.
Wed, Jul 10, 2:35 PM
ian committed rS349873: Add pwm.9, it was also deleted during the big round of pwm changes..
Add pwm.9, it was also deleted during the big round of pwm changes.
Wed, Jul 10, 3:45 AM

Tue, Jul 9

ian added a comment to D20764: Allow limiting the size of syslogd output files using options in syslog.conf.

So far there was more commenting on mailing lists than here. Summarizing the feedback from both venues so far...

Tue, Jul 9, 2:44 AM

Mon, Jul 8

D20878: handbook/security: Update the Process Accounting section. now requires changes to proceed.
Mon, Jul 8, 9:22 PM
ian committed rS349850: Restore the ability for i2c slave devices to do IO from their probe method..
Restore the ability for i2c slave devices to do IO from their probe method.
Mon, Jul 8, 8:27 PM
ian committed rS349839: Call device_unbusy() on the error exit path, because if iicbus_request_bus().
Call device_unbusy() on the error exit path, because if iicbus_request_bus()
Mon, Jul 8, 6:29 PM
ian committed rS349836: MFC r348120:.
MFC r348120:
Mon, Jul 8, 2:34 PM

Sun, Jul 7

ian added inline comments to D20876: Limit access to system accounting files.
Sun, Jul 7, 6:39 PM
ian added a comment to D20876: Limit access to system accounting files.

Use install to create the acct file with correct ownership and permissions instead of umask+touch.

Sun, Jul 7, 6:38 PM
ian created D20876: Limit access to system accounting files.
Sun, Jul 7, 5:56 PM
ian committed rS349807: Eliminate spurious periodic.daily error message for rotating accounting log..
Eliminate spurious periodic.daily error message for rotating accounting log.
Sun, Jul 7, 5:16 PM

Thu, Jun 27

D20762: Add an initial RELNOTES file. is now accepted and ready to land.

I love the clean simplicity of this after all the back and forth on mailing lists about markup languages and other complications that were far beyond this original simple vision.

Thu, Jun 27, 1:30 AM

Wed, Jun 26

ian committed rS349430: MFC r343826, r346698, r349057-r349060, r349073-r349077, r349080-r349086….
MFC r343826, r346698, r349057-r349060, r349073-r349077, r349080-r349086…
Wed, Jun 26, 5:29 PM
ian committed rS349425: MFC r340130, r340134:.
MFC r340130, r340134:
Wed, Jun 26, 4:38 PM
ian committed rS349415: MFC r341268, r342003-r342007, r342087-r342088, r342091.
MFC r341268, r342003-r342007, r342087-r342088, r342091
Wed, Jun 26, 3:34 PM

Tue, Jun 25

ian created D20764: Allow limiting the size of syslogd output files using options in syslog.conf.
Tue, Jun 25, 10:02 PM

Mon, Jun 24

ian committed rS349330: Add pwm devices to NOTES..
Add pwm devices to NOTES.
Mon, Jun 24, 2:40 AM
ian committed rS349329: Add gpio(4) and related drivers to NOTES..
Add gpio(4) and related drivers to NOTES.
Mon, Jun 24, 2:30 AM
ian committed rS349328: The gpiopps(4) driver currently has probe and attach code only for FDT based.
The gpiopps(4) driver currently has probe and attach code only for FDT based
Mon, Jun 24, 2:27 AM
ian committed rS349327: Build an armv7 LINT kernel in addition to armv5 LINT. You might think this.
Build an armv7 LINT kernel in addition to armv5 LINT. You might think this
Mon, Jun 24, 1:42 AM

Sun, Jun 23

ian committed rS349325: Allow compiling ukbdmap.h on arm, since it appears to work fine..
Allow compiling ukbdmap.h on arm, since it appears to work fine.
Sun, Jun 23, 9:17 PM
ian committed rS349319: Add some i2c slave-device drivers that were missing from NOTES..
Add some i2c slave-device drivers that were missing from NOTES.
Sun, Jun 23, 5:39 PM
ian committed rS349318: The sy8106a and syr827 drviers require FDT and the ext_resources subsystem..
The sy8106a and syr827 drviers require FDT and the ext_resources subsystem.
Sun, Jun 23, 5:38 PM
ian committed rS349317: Add the rtc8583 driver to conf/files. Also, move sy8106a from.
Add the rtc8583 driver to conf/files. Also, move sy8106a from
Sun, Jun 23, 5:24 PM
ian committed rS349316: Remove some unused header files from the ad7418 driver..
Remove some unused header files from the ad7418 driver.
Sun, Jun 23, 5:21 PM
ian committed rS349315: MFC r348740-r348741, r348995.
MFC r348740-r348741, r348995
Sun, Jun 23, 4:59 PM
ian committed rS349314: MFC r348169-r348170, r348172-r348173, r348183-r348184.
MFC r348169-r348170, r348172-r348173, r348183-r348184
Sun, Jun 23, 4:17 PM
ian committed rS349313: MFC r341386 (by manu):.
MFC r341386 (by manu):
Sun, Jun 23, 4:06 PM
ian committed rS349312: MFC r348141, r348143.
MFC r348141, r348143
Sun, Jun 23, 4:00 PM
ian committed rS349311: MFC r348123, r348164, r348166.
MFC r348123, r348164, r348166
Sun, Jun 23, 3:59 PM
ian committed rS349310: MFC r348120:.
MFC r348120:
Sun, Jun 23, 3:55 PM

Jun 21 2019

ian committed rS349273: Add pwm to the armv7 GENERIC kernel, it's now used by TI and Allwinner..
Add pwm to the armv7 GENERIC kernel, it's now used by TI and Allwinner.
Jun 21 2019, 3:45 PM
ian committed rS349272: Do some general cleanup and light wordsmithing..
Do some general cleanup and light wordsmithing.
Jun 21 2019, 3:12 PM
ian committed rS349271: Catch up with recent changes in pwmbus(9). The pwm(9) and pwmbus(9).
Catch up with recent changes in pwmbus(9). The pwm(9) and pwmbus(9)
Jun 21 2019, 2:46 PM
ian committed rS349270: Add support for the PWM(9) API. This allows configuring the pwm output using.
Add support for the PWM(9) API. This allows configuring the pwm output using
Jun 21 2019, 2:24 PM
ian committed rS349269: Some mundane tweaks and cleanups to help de-clutter the diffs of some.
Some mundane tweaks and cleanups to help de-clutter the diffs of some
Jun 21 2019, 2:01 PM
ian accepted D20715: Reduce namespace pollution from r349233.
Jun 21 2019, 1:00 AM

Jun 18 2019

ian committed rS349174: Handle labels specified with hints even on FDT systems. Hints are the.
Handle labels specified with hints even on FDT systems. Hints are the
Jun 18 2019, 5:05 PM
ian committed rS349168: Add a pwmc(4) manpage..
Add a pwmc(4) manpage.
Jun 18 2019, 4:32 AM
ian committed rS349167: Oops, it seems I left out the word 'cycle', fix it..
Oops, it seems I left out the word 'cycle', fix it.
Jun 18 2019, 2:27 AM
ian committed rS349166: Rearrange the argument checking and processing so that enable and disable.
Rearrange the argument checking and processing so that enable and disable
Jun 18 2019, 1:15 AM
ian committed rS349165: Explain the relationship between PWM hardware channels being controlled and.
Explain the relationship between PWM hardware channels being controlled and
Jun 18 2019, 12:17 AM
ian committed rS349164: Remove everything related to channels from the pwmc public interface, now.
Remove everything related to channels from the pwmc public interface, now
Jun 18 2019, 12:11 AM

Jun 17 2019

ian committed rS349145: Put periods at the ends of argument descriptions. Explain the relationship.
Put periods at the ends of argument descriptions. Explain the relationship
Jun 17 2019, 4:51 PM
ian committed rS349144: Follow changes in the pwmc(4) driver in relation to device filenames..
Follow changes in the pwmc(4) driver in relation to device filenames.
Jun 17 2019, 4:43 PM
ian committed rS349143: Put the pwmc cdev filenames under the pwm directory along with any label.
Put the pwmc cdev filenames under the pwm directory along with any label
Jun 17 2019, 4:27 PM
ian committed rS349132: Add back a const qualifier I somehow fumbled away between test-building.
Add back a const qualifier I somehow fumbled away between test-building
Jun 17 2019, 3:49 AM
ian committed rS349131: Implement the ofw_bus_get_node method in aw_pwm(4) so that ofw_pwmbus can.
Implement the ofw_bus_get_node method in aw_pwm(4) so that ofw_pwmbus can
Jun 17 2019, 3:40 AM
ian committed rS349130: Add ofw_pwmbus to enumerate pwmbus devices on systems configured with fdt.
Add ofw_pwmbus to enumerate pwmbus devices on systems configured with fdt
Jun 17 2019, 3:32 AM

Jun 16 2019

ian committed rS349119: Rework pwmbus and pwmc so that each child will handle a single PWM channel..
Rework pwmbus and pwmc so that each child will handle a single PWM channel.
Jun 16 2019, 7:44 PM
ian committed rS349116: In detach(), call bus_generic_detach() before deleting the iicbus child..
In detach(), call bus_generic_detach() before deleting the iicbus child.
Jun 16 2019, 4:03 PM
ian committed rS349115: Rename pwmbus.h to ofw_pwm.h, because after all the recent changes, there.
Rename pwmbus.h to ofw_pwm.h, because after all the recent changes, there
Jun 16 2019, 3:57 PM
ian committed rS349097: Build SoC-specific modules with GENERIC for the SoCs that have them..
Build SoC-specific modules with GENERIC for the SoCs that have them.
Jun 16 2019, 1:24 AM
ian committed rS349096: Add module makefiles for Texas Instruments ARM SoCs..
Add module makefiles for Texas Instruments ARM SoCs.
Jun 16 2019, 1:23 AM
ian committed rS349095: Split the dtb MODULES_EXTRA line to a series of += lines, making it easier.
Split the dtb MODULES_EXTRA line to a series of += lines, making it easier
Jun 16 2019, 1:06 AM
ian committed rS349094: Add module makefiles for pwm..
Add module makefiles for pwm.
Jun 16 2019, 12:53 AM
ian committed rS349093: This code no longer uses fdt/ofw stuff, no need to include ofw headers..
This code no longer uses fdt/ofw stuff, no need to include ofw headers.
Jun 16 2019, 12:43 AM
ian committed rS349092: Make channel number unsigned, and spell unsigned int u_int. This should.
Make channel number unsigned, and spell unsigned int u_int. This should
Jun 16 2019, 12:32 AM
ian committed rS349091: The pwm interface was replaced with pwmbus, include the right header file..
The pwm interface was replaced with pwmbus, include the right header file.
Jun 16 2019, 12:27 AM

Jun 15 2019

ian committed rS349088: Make pwm channel numbers unsigned..
Make pwm channel numbers unsigned.
Jun 15 2019, 11:02 PM
ian committed rS349086: Restructure the pwm device hirearchy and interfaces..
Restructure the pwm device hirearchy and interfaces.
Jun 15 2019, 10:25 PM
ian committed rS349085: Destroy the cdev on device detach. Also, make the driver and devclass.
Destroy the cdev on device detach. Also, make the driver and devclass
Jun 15 2019, 9:52 PM
ian committed rS349084: Rename the channel_max method to channel_count, because that's what it's.
Rename the channel_max method to channel_count, because that's what it's
Jun 15 2019, 9:36 PM
ian committed rS349083: Give the aw_pwm driver a module version..
Give the aw_pwm driver a module version.
Jun 15 2019, 9:31 PM
ian committed rS349082: Spell unsigned int as u_int and channel as chan; eliminates the need to wrap.
Spell unsigned int as u_int and channel as chan; eliminates the need to wrap
Jun 15 2019, 9:19 PM
ian committed rS349081: Unwrap prototype lines so that return type and function name are on the.
Unwrap prototype lines so that return type and function name are on the
Jun 15 2019, 8:54 PM
ian committed rS349080: Make pwmbus driver and devclass vars static; they're not mentioned in any.
Make pwmbus driver and devclass vars static; they're not mentioned in any
Jun 15 2019, 8:53 PM
ian committed rS349077: Add a missing #include. I suspect this used to get included via some header.
Add a missing #include. I suspect this used to get included via some header
Jun 15 2019, 8:20 PM
ian committed rS349076: Use device_delete_children() instead of a locally-rolled copy of it that.
Use device_delete_children() instead of a locally-rolled copy of it that
Jun 15 2019, 8:17 PM
ian committed rS349075: Remove pwmbus_attach_bus(), it no longer has any callers. Also remove a.
Remove pwmbus_attach_bus(), it no longer has any callers. Also remove a
Jun 15 2019, 8:13 PM
ian committed rS349074: Move/rename the sys/pwm.h header file to dev/pwm/pwmc.h. The file contains.
Move/rename the sys/pwm.h header file to dev/pwm/pwmc.h. The file contains
Jun 15 2019, 7:47 PM
ian committed rS349073: Do not include pwm.h here, it is purely a userland interface file containing.
Do not include pwm.h here, it is purely a userland interface file containing
Jun 15 2019, 7:43 PM
ian committed rS349072: Remove pcf8563reg.h, the driver it was associated with was replaced in 2017.
Remove pcf8563reg.h, the driver it was associated with was replaced in 2017
Jun 15 2019, 7:16 PM
ian committed rS349060: Handle failure to enable the clock or obtain its frequency..
Handle failure to enable the clock or obtain its frequency.
Jun 15 2019, 4:59 PM
ian committed rS349059: Don't call pwmbus_attach_bus(), because it may not be present if this.
Don't call pwmbus_attach_bus(), because it may not be present if this
Jun 15 2019, 4:56 PM
ian committed rS349058: In detach(), check for failure of bus_generic_detach(), only release.
In detach(), check for failure of bus_generic_detach(), only release
Jun 15 2019, 4:36 PM
ian committed rS349057: Allow pwm(9) components to be selected individually, while 'device pwm'.
Allow pwm(9) components to be selected individually, while 'device pwm'
Jun 15 2019, 4:16 PM

Jun 12 2019

ian committed rS348995: Don't attempt to include hwpmc support for armv6, we're missing some of the.
Don't attempt to include hwpmc support for armv6, we're missing some of the
Jun 12 2019, 4:05 PM

Jun 7 2019

ian added a comment to D20293: ucom(4): synchronously execute param changes.

I agree about that, but as you know the TTY layer holds a mutex while calling us, so sleeping is not allowed or am I wrong? You don't solve mutex problems by just dropping the TTY lock, that leaves races wide open.
I suggest a new method in the ttydevsw which drain any pending commands off the underlying layer, which can be called outside the tty_lock() so we don't mess with the TTY's internal state.

Jun 7 2019, 3:19 PM

Jun 6 2019

ian added a comment to D20293: ucom(4): synchronously execute param changes.

I understand you want synchronous behaviour, but how about implementing a drain command, which is called unlocked from the TTY layer, just before the end of the IOCTL return. Won't that fix the problems you see?

Jun 6 2019, 6:44 PM
ian added a comment to D20293: ucom(4): synchronously execute param changes.

I was going through the code putting "I think this one needs to be sync too" comments here and there. Then I realized I was pretty tagging every call to ucom_queue_command() as "needs to be sync".

Jun 6 2019, 6:15 PM
ian committed rS348741: For armv6 and armv7, build hwpmc_armv7.c as well as the base hwpmc_arm.c..
For armv6 and armv7, build hwpmc_armv7.c as well as the base hwpmc_arm.c.
Jun 6 2019, 3:22 PM