Page MenuHomeFreeBSD

ian (Ian Lepore)
Disabled

Projects

User Details

User Since
May 11 2014, 1:02 PM (394 w, 4 d)
Roles
Disabled

Recent Activity

Wed, Nov 10

ian added a comment to D32905: Add ETHER_ALIGN support to ng_device(4)..

If I understand correctly, the requirement is to align the IP header unconditional.
So there is no need for an extra message, but all other nodes might be urged to add this, too.

Wed, Nov 10, 7:38 PM
ian added a comment to D32905: Add ETHER_ALIGN support to ng_device(4)..

I don't understand what the alignment does in this case.
Does it fix a bug or is it an optimization?
What part of the code requires this alignment, is it the TCP/IP stack?
Because not only ng_eiface(4) can inject Ethernet packets into the network stack.

Just some other examples of unalligned packets with netgraph:
ng_device(4) -> ng_ether::upper(4) -> TCP/IP stack
ng_socket(4) -> ng_eiface -> TCP/IP stack

As I can see, ETHER_ALIGN is only used by network drivers. Is there any alignment requirement for network drivers or TCP/IP stack?

Other changes, I think you can commit:

  1. Support of the "getdevname".
  2. Automatically give the node name same as device name.
Wed, Nov 10, 3:37 PM

Oct 21 2021

ian added a comment to D30554: ofwbus: remove handling of resources from ofwbus.

Before these changes, ofw_bus was a simplebus that also did a bit of resource management. With the rman stuff gone, is there any difference at all between ofw_bus and simplebus?

Oct 21 2021, 3:03 AM
ian accepted D32357: arm: add an interrupt rman to nexus.

You already know I really dislike the default range, but I have no reason its use causes actual harm. For the moment, things need to go this way.

Oct 21 2021, 2:53 AM

Oct 17 2021

ian added inline comments to D32538: ipq4018: add initial IPQ4018/IPQ4019 support.
Oct 17 2021, 8:44 PM
ian added inline comments to D32538: ipq4018: add initial IPQ4018/IPQ4019 support.
Oct 17 2021, 6:24 PM

Oct 6 2021

ian committed R10:6fea4b82e7b8: Fix busdma resource leak on usb device detach. (authored by ian).
Fix busdma resource leak on usb device detach.
Oct 6 2021, 4:10 PM
ian committed R10:b1cca7436737: Fix busdma resource leak on usb device detach. (authored by ian).
Fix busdma resource leak on usb device detach.
Oct 6 2021, 3:39 PM

Sep 28 2021

ian committed R10:dc91a9715f8f: Fix busdma resource leak on usb device detach. (authored by ian).
Fix busdma resource leak on usb device detach.
Sep 28 2021, 7:32 PM
ian closed D32208: Fix busdma resource leak on usb device detach.
Sep 28 2021, 7:32 PM
ian committed R10:1acf73d54412: qoriq_therm.c: avoid a segfault on the error exit path. (authored by ian).
qoriq_therm.c: avoid a segfault on the error exit path.
Sep 28 2021, 6:23 PM
ian committed R10:ea5c0b7b140b: Add the clock for the imx8 thermal monitoring unit. (authored by ian).
Add the clock for the imx8 thermal monitoring unit.
Sep 28 2021, 5:53 PM
ian committed R10:5e6f76f3704f: Add ethernet to the standard drivers for imx8. (authored by ian).
Add ethernet to the standard drivers for imx8.
Sep 28 2021, 5:25 PM
ian requested review of D32208: Fix busdma resource leak on usb device detach.
Sep 28 2021, 4:20 PM

Sep 1 2021

ian accepted D31763: ppbus: Set the lock for pps interface, update to latest api.
Sep 1 2021, 6:54 PM
ian accepted D31763: ppbus: Set the lock for pps interface, update to latest api.

I would be a bit more wordy in the commit, something like;

Sep 1 2021, 5:56 PM
ian added inline comments to D31763: ppbus: Set the lock for pps interface, update to latest api.
Sep 1 2021, 3:03 PM

Aug 18 2021

ian accepted D31592: arm: hide busdma statistics behind ifdef ARM_BUSDMA_MAPLOAD_STATS.

I suspect these stats aren't much-used in the real world, and can't think of any reason not to do this.

Aug 18 2021, 2:29 PM

Jul 21 2021

ian added a comment to D31244: arm: Bump KSTACK_PAGES default to match i386/amd64.
In D31244#703740, @imp wrote:
In D31244#703721, @imp wrote:

ZFS is useful on these small memory beasts?

Unsure, @cem laid out some other real problems with the small stack size in the referenced commit https://reviews.freebsd.org/R10:3f6867ef6386435a52ec564780b91a47dd948b0c. Is there a significant drawback here versus the safety of a larger stack?

I don't believe there is a huge drawback, I just hit a big wall trying to set ZFS up years ago on older V7 gear and was wondering if things had changed with OpenZFS. This change would be a problem on the older armv5 gear due to its limitations on RAM. The v6/v7 machines start at 512MB and go up from there. They aren't memory constrained. The only detail I hesitate on would be if this increases overhead on context switches or something like that. I don't believe it will, so the change is fine, but I'd love to see what others say before making the change.

Jul 21 2021, 2:33 PM
ian accepted D31244: arm: Bump KSTACK_PAGES default to match i386/amd64.

This has been on my to-do list for ages. Several people who use zfs on 32-bit arm have requested it over the years.

Jul 21 2021, 1:01 AM

Mar 22 2021

ian added a comment to D29369: Teach DTrace that unaligned accesses are allowed on aarch64, not just x86..

I wonder if we should be checking for __NO_STRICT_ALIGNMENT (and defining it for architectures other than x86)

Hmm. I didn't know that existed.

I think it is the right goal, but I don't think we should aim for it in this patch. Not least, I'm not easily set up to test the various other cases covered by that define currently.

Mar 22 2021, 3:00 PM

Mar 18 2021

ian added a comment to D24339: Aux uart gets wrong clock speed on RPi4.

I don't understand the need to add new methods to ofw_if. The new methods are just extracting standard properties from a standard dtb in memory; if new functions are needed at all, why aren't they just a couple new convenience functions in ofw_subr.{c,h}?

Mar 18 2021, 8:53 PM

Feb 26 2021

ian accepted D28940: usr.sbin/newsyslog: Implement E newsyslog.conf entry flag.
Feb 26 2021, 7:32 PM

Dec 16 2020

ian committed rS368702: MFC 368585:.
MFC 368585:
Dec 16 2020, 5:09 PM

Dec 12 2020

ian closed D27398: Provide userland notification of gpio pin changes (aka "userland gpio interrupts")..
Dec 12 2020, 6:34 PM
ian committed rS368585: Provide userland notification of gpio pin changes ("userland gpio interrupts")..
Provide userland notification of gpio pin changes ("userland gpio interrupts").
Dec 12 2020, 6:34 PM
ian updated the diff for D27398: Provide userland notification of gpio pin changes (aka "userland gpio interrupts")..

A few last minor tweaks to the test program.

Dec 12 2020, 6:11 PM

Nov 30 2020

ian updated the diff for D27398: Provide userland notification of gpio pin changes (aka "userland gpio interrupts")..

This update adds the option to choose between detailed (the default) and summary reporting, and removes the restriction that only one pin-change event can occur between each call to read(2) without losing data. It also adds a new test/demo program, based on the test code written by Christian for the gsoc project.

Nov 30 2020, 9:27 PM

Nov 28 2020

ian added inline comments to D27398: Provide userland notification of gpio pin changes (aka "userland gpio interrupts")..
Nov 28 2020, 7:08 PM

Nov 27 2020

ian updated the diff for D27398: Provide userland notification of gpio pin changes (aka "userland gpio interrupts")..

Allow only edge-triggered interrupts, and only if they are supported on that pin according to the capabilities flags from the hardware driver.

Nov 27 2020, 7:54 PM
ian added a reviewer for D27398: Provide userland notification of gpio pin changes (aka "userland gpio interrupts").: markm.
Nov 27 2020, 6:06 PM
ian updated the diff for D27398: Provide userland notification of gpio pin changes (aka "userland gpio interrupts")..

Primarily style fixes, mostly reformating block comments to the freebsd standard.

Nov 27 2020, 6:01 PM
ian updated the diff for D27398: Provide userland notification of gpio pin changes (aka "userland gpio interrupts")..

Locking fixes. The original code had several places where an error-handling path would exit a function with a mutex unlocked that would be re-locked on a normal exit. There was also a place where an SLIST was traversed without holding the mutex that protects additions and deletions on that list.

Nov 27 2020, 5:56 PM
ian added a comment to D27398: Provide userland notification of gpio pin changes (aka "userland gpio interrupts")..

Just a note to mention that the initial diff is the exact code from https://github.com/ckraemer/freebsd/tree/gsoc2018, with a couple small tweaks to resolve conflicts due to the freebsd base code having changed a bit over the past two years.

Nov 27 2020, 5:52 PM
ian requested review of D27398: Provide userland notification of gpio pin changes (aka "userland gpio interrupts")..
Nov 27 2020, 5:50 PM

Nov 26 2020

ian committed rS368042: Add the firmware blob required to use the sdma hardware in the imx6.
Add the firmware blob required to use the sdma hardware in the imx6
Nov 26 2020, 1:41 AM

Nov 25 2020

ian committed rS368030: Extend the imx6 gpc->gic interrupt controller fixup of fdt data at runtime.
Extend the imx6 gpc->gic interrupt controller fixup of fdt data at runtime
Nov 25 2020, 8:05 PM
ian committed rS368029: Convert the imx6_snvs RTC driver to access registers via the syscon device..
Convert the imx6_snvs RTC driver to access registers via the syscon device.
Nov 25 2020, 7:10 PM
ian committed rS368028: Add the standard extres pseudo devices to the IMX6 kernel config..
Add the standard extres pseudo devices to the IMX6 kernel config.
Nov 25 2020, 7:08 PM
ian committed rS368026: A couple small fixes for the imx6_sdma driver....
A couple small fixes for the imx6_sdma driver...
Nov 25 2020, 6:09 PM
ian committed rS368021: Only attach the ti_scm_syscon driver when running on a compatible TI chip..
Only attach the ti_scm_syscon driver when running on a compatible TI chip.
Nov 25 2020, 3:45 PM

Nov 18 2020

ian accepted D27270: Remove NO_EVENTTIMERS support.
Nov 18 2020, 4:19 PM

Nov 15 2020

ian accepted D27218: arm: tune vmparam.h towards a little more modern.
Nov 15 2020, 6:21 PM

Oct 12 2020

ian committed rS366652: Bug fixes for the ads111x driver... make configurable gain and sample rate.
Bug fixes for the ads111x driver... make configurable gain and sample rate
Oct 12 2020, 6:03 PM

Sep 22 2020

ian committed rS366001: MFC r365729:.
MFC r365729:
Sep 22 2020, 3:01 PM
ian committed rS366000: MFC r365729:.
MFC r365729:
Sep 22 2020, 2:59 PM

Sep 14 2020

ian accepted D26431: Don't do the busy dance in icee_open/close.

Applied patch to freebsd 8 (which we use at $work but it has the icee.c source from -current) and freebsd 11 and it behaves as expected on our products.

Sep 14 2020, 11:16 PM
ian committed rS365729: Add product ID strings for a couple Microchip usb hubs. Also, update the.
Add product ID strings for a couple Microchip usb hubs. Also, update the
Sep 14 2020, 5:33 PM

Sep 3 2020

ian accepted D26302: Don't do the busy dance in icee_open/close.
In D26302#584718, @imp wrote:
In D26302#584633, @ian wrote:

So, what prevents "kldunload icee" while someone has the cdev open?

Nothing. Just like we don't do it for almost all other devices. If that's really needed, we should do it via the device_quesce mechanism.

Sep 3 2020, 2:54 PM

Sep 2 2020

ian added a comment to D26302: Don't do the busy dance in icee_open/close.

So, what prevents "kldunload icee" while someone has the cdev open?

Sep 2 2020, 7:59 PM
ian committed rS365274: In ltc430x(4), add the ability to configure control register 2 via FDT or.
In ltc430x(4), add the ability to configure control register 2 via FDT or
Sep 2 2020, 7:37 PM

Sep 1 2020

ian committed rS365058: Document the fact that you must set an i2c slave address as well as the.
Document the fact that you must set an i2c slave address as well as the
Sep 1 2020, 7:06 PM

Jul 26 2020

ian committed rS363576: Describe the value in the 're' column of vmstat(8) in terms of freebsd's vm.
Describe the value in the 're' column of vmstat(8) in terms of freebsd's vm
Jul 26 2020, 6:33 PM
ian committed rS363569: Remove commented-out lines describing the old never-implemented -t option..
Remove commented-out lines describing the old never-implemented -t option.
Jul 26 2020, 5:51 PM

Jul 19 2020

ian committed rS363330: The ds3231 RTC chip bitmask values for 12- versus 24-hour mode were reversed,.
The ds3231 RTC chip bitmask values for 12- versus 24-hour mode were reversed,
Jul 19 2020, 6:53 PM

Jun 18 2020

ian accepted D25312: Relax the rule against declaring variables in nested scopes..
In D25312#558270, @kib wrote:

I do not like it.

[...]

The argument that we have around a hundred places where the rule is already broken in fact confirms that most of our code confirms to the style(9) in this regard, since hundred places for several MLoCs of our own code is quite good ratio.

Jun 18 2020, 9:18 AM

Apr 2 2020

ian committed rS359574: Add the Cadence GEM ethernet driver to NOTES so that it gets built with.
Add the Cadence GEM ethernet driver to NOTES so that it gets built with
Apr 2 2020, 7:06 PM
ian closed D24226: Cadence GEM driver style clean-up..
Apr 2 2020, 5:58 PM
ian committed rS359571: Cadence GEM ethernet driver style clean-up, no functional changes..
Cadence GEM ethernet driver style clean-up, no functional changes.
Apr 2 2020, 5:57 PM

Mar 29 2020

ian committed rS359423: Add a missing suffix that was causing a whole word to get loaded instead.
Add a missing suffix that was causing a whole word to get loaded instead
Mar 29 2020, 5:30 PM

Mar 6 2020

ian added inline comments to D22692: Add support for the RK805/RK808 RTC.
Mar 6 2020, 6:38 PM

Feb 29 2020

ian added inline comments to D23894: dwmmc: Rework the DMA engine.
Feb 29 2020, 5:22 PM

Feb 10 2020

ian committed rS357709: Implement atomic_testandclear_{32,int,long} for 32-bit arm. Also, replace.
Implement atomic_testandclear_{32,int,long} for 32-bit arm. Also, replace
Feb 10 2020, 12:05 AM

Feb 1 2020

ian accepted D23392: More Secure Permissions for /root.

I believe 0750 is an ideal mode for the /root dir; it adds some security, and it seems unlikely that existing scripts or other automation people have in use will fail due to the change.

Feb 1 2020, 5:32 PM

Jan 17 2020

ian committed rS356854: MFC r356574:.
MFC r356574:
Jan 17 2020, 10:25 PM
ian committed rS356853: MFC r356295:.
MFC r356295:
Jan 17 2020, 10:21 PM
ian committed rS356838: MFC r356086, r356278, r356294, r356519, r356521-r356522, r356525-r356526.
MFC r356086, r356278, r356294, r356519, r356521-r356522, r356525-r356526
Jan 17 2020, 5:57 PM
ian committed rS356833: MFC r354709-r354710, r355069, r355439, r355780, r356273, r356472.
MFC r354709-r354710, r355069, r355439, r355780, r356273, r356472
Jan 17 2020, 3:55 PM

Jan 16 2020

ian accepted D23093: fdt_pinctrl: Add new methods for gpios.

After some discussion on irc we realized we don't need a get-capabilities interface between gpio and pinctrl, because both are soc-specific drivers, and the gpio driver already "knows" what capabilities the soc has.

Jan 16 2020, 8:55 PM

Jan 15 2020

ian accepted D23192: 2020-02-29 retire in-tree GPL dtc.
Jan 15 2020, 4:14 PM

Jan 14 2020

ian added a comment to D23093: fdt_pinctrl: Add new methods for gpios.

What kind of flags go into the flags arg? I suspect the quick answer is GPIO flags. The more complete answer is probably "some subset of gpio flags which differs from one device to another". That leads to the question of what to do on an attempt to set multiple flags where some are supported and some aren't.

Jan 14 2020, 4:41 AM

Jan 9 2020

ian committed rS356574: Remove scary-looking printf output that happens when you kldload dtrace on.
Remove scary-looking printf output that happens when you kldload dtrace on
Jan 9 2020, 10:52 PM
ian added a comment to D18307: Install llvm-objdump as objdump on Clang-using architectures (RFC review).

When replacing objdump with llvm-objdump came up on a mailing list, there was some opinion expressed that most users don't need objdump at all and should have to install a package to get it. But I find llvm-objdump to be a completely-usable replacement for gnu objdump that we've had in base for years. That leads me to think a knob such as WITH[OUT]_LLVM_OBJDUMP that defaults to WITHOUT might be a good solution for this.

Jan 9 2020, 4:38 PM

Jan 8 2020

ian committed rS356526: Remove some trailing whitespace; no functional changes..
Remove some trailing whitespace; no functional changes.
Jan 8 2020, 11:06 PM
ian committed rS356525: Split the code to find and add iicbus children out to its own function..
Split the code to find and add iicbus children out to its own function.
Jan 8 2020, 11:03 PM
ian committed rS356522: Change some KASSERT to device_printf + return EINVAL. There's no need to.
Change some KASSERT to device_printf + return EINVAL. There's no need to
Jan 8 2020, 10:48 PM
ian committed rS356521: Init sc->maxbus to -1, not 0. It represents the highest array index that.
Init sc->maxbus to -1, not 0. It represents the highest array index that
Jan 8 2020, 10:45 PM
ian committed rS356519: Ensure any reserved gpio pins get released if an early exit is taken.
Ensure any reserved gpio pins get released if an early exit is taken
Jan 8 2020, 10:06 PM

Jan 7 2020

ian committed rS356472: Add #ifdef option-test wrappers around another call to an arm/unwind.c.
Add #ifdef option-test wrappers around another call to an arm/unwind.c
Jan 7 2020, 9:13 PM
ian committed rS356461: MFC r336746, r336779.
MFC r336746, r336779
Jan 7 2020, 6:43 PM

Jan 2 2020

ian committed rS356295: Add the xdma framework and pl330 dma drivers to arm and arm64 lint builds..
Add the xdma framework and pl330 dma drivers to arm and arm64 lint builds.
Jan 2 2020, 10:27 PM
ian committed rS356294: Explicitly include sys/rman.h instead of relying on getting it via some.
Explicitly include sys/rman.h instead of relying on getting it via some
Jan 2 2020, 10:15 PM
ian committed rS356283: MFC r355860:.
MFC r355860:
Jan 2 2020, 7:55 PM
ian committed rS356282: MFC r347828 (by cem):.
MFC r347828 (by cem):
Jan 2 2020, 7:52 PM
ian closed D22891: Add support for i2c bus mux hardware..

Committed (forgot to link to phab) as r356278.

Jan 2 2020, 5:54 PM
ian committed rS356278: Add support for i2c bus mux hardware..
Add support for i2c bus mux hardware.
Jan 2 2020, 5:52 PM
ian committed rS356273: Since arm/unwind.c s conditionally compiled, only call functions in it.
Since arm/unwind.c s conditionally compiled, only call functions in it
Jan 2 2020, 3:38 PM

Jan 1 2020

ian added inline comments to D22891: Add support for i2c bus mux hardware..
Jan 1 2020, 9:48 PM
ian updated the diff for D22891: Add support for i2c bus mux hardware..

Remove the bus_select callback pointer and instead create an iicmux_if.m to define a bus_select method.

Jan 1 2020, 9:41 PM

Dec 31 2019

ian accepted D22945: openfirm: Add OF_device_unregister_xref.
In D22945#502734, @imp wrote:

So devices are just detached on unload, not deleted, so the device_t shouldn't be stale ever...

Of course, it would be better to have a newbus invalidate callback when deleting a device node, but until then, this is fine

Dec 31 2019, 6:00 PM

Dec 30 2019

ian committed rS356211: Set a "kernbase" symbol in 32-bit arm locore.S and use it with ldscript.arm..
Set a "kernbase" symbol in 32-bit arm locore.S and use it with ldscript.arm.
Dec 30 2019, 11:20 PM

Dec 29 2019

ian closed D22922: Eliminate generated ldscript for arm and arm64, and strip $a/$d marker symbols from linked kernel..

Committed as r356180

Dec 29 2019, 6:21 PM
ian committed rS356180: Eliminate the generated ldscript for arm and arm64, and strip $a/$d marker.
Eliminate the generated ldscript for arm and arm64, and strip $a/$d marker
Dec 29 2019, 6:17 PM

Dec 26 2019

ian accepted D22926: [gpioths] Fix GPIOTHS_DEBUG.

Doh! I totally missed that, thanks.

Dec 26 2019, 5:38 AM
ian added inline comments to D22891: Add support for i2c bus mux hardware..
Dec 26 2019, 2:35 AM
ian updated the diff for D22891: Add support for i2c bus mux hardware..

Uploaded a new diff with proper context.

Dec 26 2019, 2:29 AM
ian committed rS356086: Add comments to a couple i2c device lines..
Add comments to a couple i2c device lines.
Dec 26 2019, 2:22 AM
ian added inline comments to D22891: Add support for i2c bus mux hardware..
Dec 26 2019, 2:04 AM

Dec 25 2019

ian added inline comments to D22891: Add support for i2c bus mux hardware..
Dec 25 2019, 11:28 PM
ian added a comment to D22922: Eliminate generated ldscript for arm and arm64, and strip $a/$d marker symbols from linked kernel..
In D22922#502063, @imp wrote:

I like where this is going, and have a couple of questions...

Dec 25 2019, 10:47 PM