ian (Ian Lepore)
User

Projects

User Details

User Since
May 11 2014, 1:02 PM (218 w, 2 d)

Recent Activity

Mon, Jul 16

ian accepted D16292: zfsboot: fix build with WITHOUT_LOADER_GELI.

Ooops, sorry about that, I guess I never re-tested WITHOUT_LOADER_GELI after making various changes after the first rev.

Mon, Jul 16, 6:25 PM
ian updated the diff for D16050: Automatically run ntpd as non-root when possible..

Add requested logging when moving/changing files and dirs.

Mon, Jul 16, 5:58 PM

Sun, Jul 15

ian updated the diff for D16050: Automatically run ntpd as non-root when possible..

Fix a typo (s/driftopt-/driftopt=/) that made it through my initial testing.

Sun, Jul 15, 9:28 PM
ian updated the diff for D16050: Automatically run ntpd as non-root when possible..

While testing and redeveloping the previous version of the rc.d/ntpd changes, I came to the conclusion that automatically setting up a chroot in an rc.d script is complicated and fraught with potential peril. When I got the point of having a embedded awk program that parsed the ntp.conf file so I could figure out whether we needed to mount a devfs inside the chroot for PPS device access, I realized I was way down a too-complicated path.

Sun, Jul 15, 9:16 PM
ian created D16281: Make it possible to run ntpd as a non-root user, add ntpd uid and gid..
Sun, Jul 15, 8:47 PM

Sat, Jul 14

ian accepted D16245: Fix buildworld on FreeBSD 10.

This does indeed fix the problem with building 12 on a 10-stable system, can we please get it committed asap?

Sat, Jul 14, 5:55 PM
ian committed rS336283: Eliminate an unused var warning-error; the var is used only when parsing.
Eliminate an unused var warning-error; the var is used only when parsing
Sat, Jul 14, 4:33 PM

Fri, Jul 13

ian committed rS336256: Fix glitched indentation (and rewrap as needed due to deeper indent)..
Fix glitched indentation (and rewrap as needed due to deeper indent).
Fri, Jul 13, 6:58 PM
ian committed rS336252: Extend loader(8) geli support to all architectures and all disk-like devices..
Extend loader(8) geli support to all architectures and all disk-like devices.
Fri, Jul 13, 5:50 PM
ian closed D15743: Extend loader(8) geli support to all architectures and all disk-like devices..
Fri, Jul 13, 5:50 PM
ian added a comment to D15743: Extend loader(8) geli support to all architectures and all disk-like devices..

UEFI testing completed; this code now passes all the tests generated by tools/boot/rootgen.sh, and has also been tested on armv7 systems with ubldr. I think it is ready to commit.

Fri, Jul 13, 4:42 PM
ian committed rS336243: Make generated scripts executable..
Make generated scripts executable.
Fri, Jul 13, 4:38 PM
ian committed rS336242: More little fixes... fix a function name typo (eps vs esp), and cope with.
More little fixes... fix a function name typo (eps vs esp), and cope with
Fri, Jul 13, 4:33 PM
ian committed rS336241: Revert r336240, which contained unrelated changes accidentally committed..
Revert r336240, which contained unrelated changes accidentally committed.
Fri, Jul 13, 4:33 PM
ian committed rS336240: More little fixes... fix a function name typo (eps vs esp), and cope with.
More little fixes... fix a function name typo (eps vs esp), and cope with
Fri, Jul 13, 4:31 PM

Thu, Jul 12

ian committed rS336222: Wee fix: $dev is passed in to the function with the /dev prefix already in.
Wee fix: $dev is passed in to the function with the /dev prefix already in
Thu, Jul 12, 5:22 PM
ian added a comment to D16237: release: Remove some arm board release config.
In D16237#344541, @manu wrote:
In D16237#344539, @ian wrote:

Does this mean that cubox-humingboard images will no longer be available for download?

Yeah.
It is still popular enough so we leave it ?

Thu, Jul 12, 1:59 PM
ian added a comment to D16237: release: Remove some arm board release config.

Does this mean that cubox-humingboard images will no longer be available for download?

Thu, Jul 12, 1:28 PM

Wed, Jul 11

ian committed rS336216: Actually build and install the spigen.4 manpage..
Actually build and install the spigen.4 manpage.
Wed, Jul 11, 11:59 PM
ian committed rS336214: Add various spi devices to NOTES. Add some required options for building.
Add various spi devices to NOTES. Add some required options for building
Wed, Jul 11, 10:23 PM
ian committed rS336202: Enhancements and fixes for the spigen(4) driver....
Enhancements and fixes for the spigen(4) driver...
Wed, Jul 11, 5:54 PM

Tue, Jul 10

ian added inline comments to D16169: Rework sys/modules/Makefile to improve arch and option filtering..
Tue, Jul 10, 2:22 PM

Mon, Jul 9

ian committed rS336138: Add pnp info to the imx_spi driver..
Add pnp info to the imx_spi driver.
Mon, Jul 9, 7:00 PM
ian committed rS336137: Add a manpage for the imx_spi driver..
Add a manpage for the imx_spi driver.
Mon, Jul 9, 7:00 PM
ian updated the diff for D16198: Support installing manpages for multiple or alternate architecture(s)..

By popular demand (on irc), support a special MAN_ARCH value of "all" to install all available arches. Also, update the wording of the make.conf entry to use MACHINE and MACHINE_ARCH, to match the terms used in man(1).

Mon, Jul 9, 6:01 PM
ian created D16198: Support installing manpages for multiple or alternate architecture(s)..
Mon, Jul 9, 3:02 PM
ian committed rS336134: Add missing generated header file..
Add missing generated header file.
Mon, Jul 9, 2:18 PM

Sun, Jul 8

ian committed rS336112: Oops, fix a typo: imx_snvs should be imx6_snvs..
Oops, fix a typo: imx_snvs should be imx6_snvs.
Sun, Jul 8, 9:14 PM
ian committed rS336111: Move device statements out of std.imx* and into kernel config files..
Move device statements out of std.imx* and into kernel config files.
Sun, Jul 8, 9:10 PM
ian committed rS336096: Make the imx6_snvs driver usable as a module, add pnp info. Add a manpage..
Make the imx6_snvs driver usable as a module, add pnp info. Add a manpage.
Sun, Jul 8, 7:35 PM
ian committed rS336094: Catch up with improvements in RTC handling... It's no longer necessary to.
Catch up with improvements in RTC handling... It's no longer necessary to
Sun, Jul 8, 6:44 PM
ian committed rS336080: Create an aarch64 subdir under man4, now that we have aarch64 manpages..
Create an aarch64 subdir under man4, now that we have aarch64 manpages.
Sun, Jul 8, 1:29 AM
ian committed rS336079: Add pnp info to imx6_ahci, and add a module makefile, and a manpage for it..
Add pnp info to imx6_ahci, and add a module makefile, and a manpage for it.
Sun, Jul 8, 12:27 AM
ian committed rS336078: Move armv8crypto.4 into the aarch64 dir; should have been part of r336077..
Move armv8crypto.4 into the aarch64 dir; should have been part of r336077.
Sun, Jul 8, 12:02 AM

Sat, Jul 7

ian committed rS336077: Move arm- and aarch64-specific manpages into arch-specific directories..
Move arm- and aarch64-specific manpages into arch-specific directories.
Sat, Jul 7, 9:49 PM
ian committed rS336076: Add a manpage for the imx5/6 watchdog driver..
Add a manpage for the imx5/6 watchdog driver.
Sat, Jul 7, 8:43 PM
ian committed rS336073: Add support to the imx watchdog for the FDT "timeout-sec" property, by.
Add support to the imx watchdog for the FDT "timeout-sec" property, by
Sat, Jul 7, 7:10 PM
ian committed rS336072: Correctly calculate the value to put in the imx wdog countdown register..
Correctly calculate the value to put in the imx wdog countdown register.
Sat, Jul 7, 7:03 PM
ian committed rS336070: Add pnp info and a module makefile for the imx_wdog watchdog driver..
Add pnp info and a module makefile for the imx_wdog watchdog driver.
Sat, Jul 7, 5:25 PM
ian added a comment to D14646: Remove ufs-specific mountroot code that waited for devices..

My only worry is this: what if we had a zpool with devices that require different time to go online, and we mount rootfs while one of them is still offline? Wouldn't this result in a degraded root pool?

Sat, Jul 7, 4:02 PM
ian created D16169: Rework sys/modules/Makefile to improve arch and option filtering..
Sat, Jul 7, 1:38 AM

Fri, Jul 6

ian committed rS336052: Set .PATH to dev/usb/serial so that these modules compile again..
Set .PATH to dev/usb/serial so that these modules compile again.
Fri, Jul 6, 10:07 PM

Thu, Jul 5

ian committed rS335992: MFC r335283:.
MFC r335283:
Thu, Jul 5, 4:15 PM
ian committed rS335991: MFC r333255, r333260.
MFC r333255, r333260
Thu, Jul 5, 4:13 PM
ian committed rS335989: Detach all children before beginning to tear down the hardware, instead of.
Detach all children before beginning to tear down the hardware, instead of
Thu, Jul 5, 4:01 PM
ian committed rS335988: Add a missing call to usb_bus_mem_free_all() when detaching..
Add a missing call to usb_bus_mem_free_all() when detaching.
Thu, Jul 5, 3:52 PM
ian committed rS335985: Remove a test and early-out which just can't possibly be right. It causes.
Remove a test and early-out which just can't possibly be right. It causes
Thu, Jul 5, 3:34 PM
ian committed rS335982: Fix an out-of-bounds array access... the irq data for teardown is in two.
Fix an out-of-bounds array access... the irq data for teardown is in two
Thu, Jul 5, 2:10 PM

Wed, Jul 4

ian committed rS335952: MFC r335575, r335786.
MFC r335575, r335786
Wed, Jul 4, 2:12 PM
ian committed rS335950: MFC r335595-r335596.
MFC r335595-r335596
Wed, Jul 4, 2:10 PM
ian committed rS335949: MFC r335595-r335596.
MFC r335595-r335596
Wed, Jul 4, 2:04 PM
ian committed rS335948: MFC r335575, r335786-r335787.
MFC r335575, r335786-r335787
Wed, Jul 4, 2:02 PM
ian committed rS335947: MFC r335489:.
MFC r335489:
Wed, Jul 4, 1:58 PM
ian committed rS335946: MFC r335486:.
MFC r335486:
Wed, Jul 4, 1:56 PM
ian added a comment to D15743: Extend loader(8) geli support to all architectures and all disk-like devices..

I get compile errors trying to build the latest

Wed, Jul 4, 1:49 PM

Tue, Jul 3

ian updated the diff for D15743: Extend loader(8) geli support to all architectures and all disk-like devices..

Update the diff to fix a couple bugs.

Tue, Jul 3, 5:46 PM
ian committed rS335895: Fix the fstab entries for tests that have an efi partition in slice 1 and.
Fix the fstab entries for tests that have an efi partition in slice 1 and
Tue, Jul 3, 4:07 PM

Mon, Jul 2

ian committed rS335878: Doh! Commit the proper default values, not my local tweaks..
Doh! Commit the proper default values, not my local tweaks.
Mon, Jul 2, 10:59 PM
ian committed rS335877: Move the passphrase and iteration count into variables..
Move the passphrase and iteration count into variables.
Mon, Jul 2, 10:58 PM
ian committed rS335876: Allow making just one flavor of boot-test image based on cmdline args..
Allow making just one flavor of boot-test image based on cmdline args.
Mon, Jul 2, 10:52 PM

Fri, Jun 29

ian abandoned D15987: Make inside<->outside chroot symlinks for all files on the ntpd command line.

I am abandoning this change in favor of D16050 which is a more complete solution.

Fri, Jun 29, 2:37 PM

Thu, Jun 28

ian committed rS335787: When being verbose about various leapfile versions, also mention expiration..
When being verbose about various leapfile versions, also mention expiration.
Thu, Jun 28, 10:13 PM
ian committed rS335786: Rename variable ntp_tmp_leapfile to have a leading underbar, to distinguish.
Rename variable ntp_tmp_leapfile to have a leading underbar, to distinguish
Thu, Jun 28, 10:05 PM
ian added inline comments to D16050: Automatically run ntpd as non-root when possible..
Thu, Jun 28, 7:54 PM
ian added a comment to D16050: Automatically run ntpd as non-root when possible..

BTW, here's some information that took a while to figure out, so I want to capture it for future reference, somewhere other than a .txt file I'm sure to lose over time.

Thu, Jun 28, 6:41 PM
ian created D16050: Automatically run ntpd as non-root when possible..
Thu, Jun 28, 6:18 PM
ian committed rS335766: Add missing MODULE_VERSION() and MODULE_DEPEND()..
Add missing MODULE_VERSION() and MODULE_DEPEND().
Thu, Jun 28, 5:07 PM

Tue, Jun 26

ian added a comment to D15987: Make inside<->outside chroot symlinks for all files on the ntpd command line.

Okay, after some experimenting, here's what I've learned today...

Tue, Jun 26, 7:25 PM
ian added a comment to D15987: Make inside<->outside chroot symlinks for all files on the ntpd command line.

I think it's all moot, and we simply don't support dropping priveleges and running in a chroot at all. Part of the reason for that is that ntpd itself inappropriately binds those two concepts together. It will not chroot unless it can also drop root privs afterwards, and it will not drop root privs without linux, solaris, or netbsd-clockctl mechanisms to set the time. IMO, that's bogus, I think ntpd could chroot to limit its access to the filesystem without dropping root privs, but that's not how it's coded now.

Tue, Jun 26, 1:39 PM
ian added a comment to D15987: Make inside<->outside chroot symlinks for all files on the ntpd command line.

Well, it turns out the clockctl driver isn't an elegant solution whereby ntpd uses ioctl() calls to manipulate the clock based on filesytem permissions. Instead it's closer to a horrible hack where the clock setting functions in netbsd's libc react to EPERM errors by opening the clockctl device and doing it that way. I want no part of that. There are even netbsd email threads about how fragile the scheme is because of O_CLOEXEC and the order ntpd does things. And what it enables is basically a semi-solution, because once the daemon drops privs it's unable to bind to priveleged sockets, so if an interface goes down/up or you switch to a different wifi network or something, ntpd stops working until you manually restart it.

Tue, Jun 26, 12:42 AM

Mon, Jun 25

ian added a comment to D15987: Make inside<->outside chroot symlinks for all files on the ntpd command line.

The symlinks the script wants to set up link the inside-chroot files to the corresponding outside-chroot locations. I guess so you can do "vi /etc/ntp.conf" and be editing the real inside-chroot config file. It looks like the code we've got now is a straight import from netbsd in 2001 and untouched since then. Their code has been revised since then to do more setup of the chroot.

Mon, Jun 25, 9:02 PM
ian added a comment to D15987: Make inside<->outside chroot symlinks for all files on the ntpd command line.
In D15987#338950, @cy wrote:

What about the corresponding statements in ntp.conf? e.g.

leapfile "/var/db/ntpd.leap-seconds.list"
logfile "/var/log/ntpd"
keys "/var/db/ntp.keys"
Mon, Jun 25, 7:54 PM
ian accepted D15962: config(8): Add `envvar` support.

Wow, that named-state stuff was even easier than I thought, and it makes a much cleaner solution than the various hacks we considered.

Mon, Jun 25, 2:31 PM
ian updated the diff for D15987: Make inside<->outside chroot symlinks for all files on the ntpd command line.

Reworked to only try to make symlinks if there isn't already a file/dir/link at the target location.

Mon, Jun 25, 2:25 PM

Sun, Jun 24

ian committed rS335596: Fix a comment; the ntp leaplist file is updated periodically, but not weekly.
Fix a comment; the ntp leaplist file is updated periodically, but not weekly
Sun, Jun 24, 3:31 AM
ian committed rS335595: Modernize usage of "restrict" keyword in ntp.conf.
Modernize usage of "restrict" keyword in ntp.conf
Sun, Jun 24, 3:29 AM
ian closed D15974: Modernize usage of "restrict" keyword in ntp.conf.
Sun, Jun 24, 3:29 AM
ian created D15987: Make inside<->outside chroot symlinks for all files on the ntpd command line.
Sun, Jun 24, 2:54 AM

Sat, Jun 23

ian committed rS335594: Retrieve the bus clock speed and mode (polarity/phase) from the child device.
Retrieve the bus clock speed and mode (polarity/phase) from the child device
Sat, Jun 23, 11:44 PM
ian closed D15031: bcm2835_spi.c mod to support mode and clock in ivars from spibus.
Sat, Jun 23, 11:44 PM
ian accepted D15031: bcm2835_spi.c mod to support mode and clock in ivars from spibus.
Sat, Jun 23, 11:32 PM
ian committed rS335593: Add an example for displaying the manufacturer and size info from a.
Add an example for displaying the manufacturer and size info from a
Sat, Jun 23, 11:08 PM
ian committed rS335592: Add spi-max-frequency properties to all spigen nodes. This is a required.
Add spi-max-frequency properties to all spigen nodes. This is a required
Sat, Jun 23, 10:55 PM
ian committed rS335575: Use 'mv -f' in rc.d/ntpd to avoid spuriously halting the boot..
Use 'mv -f' in rc.d/ntpd to avoid spuriously halting the boot.
Sat, Jun 23, 2:42 AM
ian created D15974: Modernize usage of "restrict" keyword in ntp.conf.
Sat, Jun 23, 2:07 AM

Fri, Jun 22

ian added inline comments to D15962: config(8): Add `envvar` support.
Fri, Jun 22, 11:56 PM
ian added inline comments to D15962: config(8): Add `envvar` support.
Fri, Jun 22, 10:21 PM
ian committed rS335564: Add spigen(4) fdt data overlays for RPI-B, RPI-2..
Add spigen(4) fdt data overlays for RPI-B, RPI-2.
Fri, Jun 22, 8:45 PM
ian closed D15067: spigen overlays for RPI-B, RPI-2 in base (was: possible new port for spigen overlay for Raspberry Pi).
Fri, Jun 22, 8:45 PM
ian accepted D15067: spigen overlays for RPI-B, RPI-2 in base (was: possible new port for spigen overlay for Raspberry Pi).
Fri, Jun 22, 8:24 PM
ian committed rS335562: Eliminate a spurious panic on non-SMP systems (occurred on shutdown/reboot)..
Eliminate a spurious panic on non-SMP systems (occurred on shutdown/reboot).
Fri, Jun 22, 8:22 PM
ian added inline comments to D15962: config(8): Add `envvar` support.
Fri, Jun 22, 3:58 PM
ian committed rS335529: Eliminate gcc "shadowed declaration" warnings by using idx rather than.
Eliminate gcc "shadowed declaration" warnings by using idx rather than
Fri, Jun 22, 3:40 AM
ian closed D15029: new utility usr.sbin/spi.
Fri, Jun 22, 1:59 AM
ian committed rS335527: Add spi(8), a utility for communicating with a device on a SPI bus from.
Add spi(8), a utility for communicating with a device on a SPI bus from
Fri, Jun 22, 1:59 AM
ian accepted D15029: new utility usr.sbin/spi.
Fri, Jun 22, 1:52 AM

Thu, Jun 21

ian added inline comments to D15029: new utility usr.sbin/spi.
Thu, Jun 21, 9:46 PM
ian closed D15301: alter spigen device name to indicate cs as sub-unit.
Thu, Jun 21, 9:16 PM
ian committed rS335506: Incorporate bus and chip select numbers into spigen(4) cdev names. Rather.
Incorporate bus and chip select numbers into spigen(4) cdev names. Rather
Thu, Jun 21, 9:16 PM
ian accepted D15301: alter spigen device name to indicate cs as sub-unit.
Thu, Jun 21, 9:01 PM