Page MenuHomeFreeBSD

ian (Ian Lepore)
User

Projects

User Details

User Since
May 11 2014, 1:02 PM (232 w, 12 h)

Recent Activity

Sep 13 2018

ian committed rS338648: If a user skips the pre-world mergemaster, an installworld check.
If a user skips the pre-world mergemaster, an installworld check
Sep 13 2018, 3:16 PM

Sep 4 2018

ian accepted D17023: Support Capsicum on armv6/armv7.

This looks good to me (I assume it's been tested, I didn't try it myself).

Sep 4 2018, 9:50 PM

Sep 3 2018

ian added a comment to D6814: Add libfdt user space library.

This should be attached to the build, and used by the GNU dtc.

I'm wondering should libfdt be conditionally built and, if so, should it be based on MK_FDT and MK_GPL_DTC (since the dtc build will be using it after the suggested changes)?

Sep 3 2018, 3:09 PM

Aug 17 2018

ian added a comment to D16775: Make 'device crypto' lines more consistent..

If using option IPSEC (and I guess GELI and maybe other things) requires explicitly specifying device crypto, then shouldn't this change also cleanup and simplify sys/conf/files to remove "| ipsec | ipsec_support" from all the files that are optional on "crypto"?

Aug 17 2018, 4:38 PM

Aug 13 2018

ian committed rS337731: Export the eeprom device size via readonly sysctl. Also export the write.
Export the eeprom device size via readonly sysctl. Also export the write
Aug 13 2018, 11:53 PM
ian accepted D16702: Add pthread_get_name_np(3)..
Aug 13 2018, 4:28 PM
ian added inline comments to D16702: Add pthread_get_name_np(3)..
Aug 13 2018, 3:43 PM

Aug 11 2018

ian accepted D16661: Move NTP related files to usr.sbin/ntp/ntpd/.

This looks okay to me.

Aug 11 2018, 5:22 PM

Aug 8 2018

ian added a comment to D16507: build: skip the database check for the distributeworld target.
In D16507#353355, @gjb wrote:
In D16507#353346, @ian wrote:

As mentioned out-of-band, I added the ntpd UID/GID to work around this issue.

Added it to what? IMO, it's a really bad idea to paper over this mess, it just means we have to suffer all this pain again next time a user is added to the base system.

Sorry for the incomplete statement. Added to the build host so 'installworld' to the target chroot directories did not error.

I could have just upgraded the build host, but chose to apply a band-aid for this one case.

Aug 8 2018, 5:32 PM
ian added a comment to D16507: build: skip the database check for the distributeworld target.
In D16507#353334, @gjb wrote:

This is part of the 'ftp' target in the release directory that runs the release/scripts/mm-mtree.sh. I see that there are snapshots still being created without issues, so I wonder what runes are used inside of the cluster to generate the install media. Is something different from 'make -C release ftp' used to generate the install sets?

As mentioned out-of-band, I added the ntpd UID/GID to work around this issue.

Aug 8 2018, 5:09 PM

Aug 5 2018

ian committed rS337364: Document 64-bit arm in terms of arch name (aarch64) not machine (arm64)..
Document 64-bit arm in terms of arch name (aarch64) not machine (arm64).
Aug 5 2018, 10:24 PM

Jul 31 2018

ian accepted D16507: build: skip the database check for the distributeworld target.

I'm 'accepting' this revision in the sense that I think this is the right way to achieve unconditional use of users and groups from the source being installed, for the distributeworld target. I can't say whether doing so is a good idea or not in general, because I don't know much about the distributeworld target.

Jul 31 2018, 3:08 PM

Jul 30 2018

ian added a comment to D16507: build: skip the database check for the distributeworld target.

Hrm, I didn't intend for my previous comments to include the "request changes" flag, don't consider my comments to be blocking, I was just throwing them out there to see what other people think.

Jul 30 2018, 3:06 PM
ian requested changes to D16507: build: skip the database check for the distributeworld target.

I'm not sure what led to putting these changes where they're at in the makefile, it seems a bit unrelated to the things immediately surrounding it. It should be noted that for this change to work properly, the new lines must appear before line 833 (pre-patched, or 838 with this patch included). It might make more sense to move this change to just before line 833; that would make it a lot more clear what the real effect of this change is.

Jul 30 2018, 3:04 PM

Jul 29 2018

ian committed rS336869: The device ID tables are used only within the driver, make them static so.
The device ID tables are used only within the driver, make them static so
Jul 29 2018, 4:55 PM

Jul 27 2018

ian committed rS336779: Stop exporting __pw_scan and __pw_initpwd as freebsd-private libc functions.
Stop exporting __pw_scan and __pw_initpwd as freebsd-private libc functions
Jul 27 2018, 7:47 PM
ian committed rS336762: Remove some code that's no longer needed because it's now part of pw_scan(3)..
Remove some code that's no longer needed because it's now part of pw_scan(3).
Jul 27 2018, 3:17 PM

Jul 26 2018

ian committed rS336751: Re-apply r336625 which was reverted with r336638, now that the underlying.
Re-apply r336625 which was reverted with r336638, now that the underlying
Jul 26 2018, 8:03 PM
ian committed rS336746: Make pw_scan(3) more compatible with getpwent(3) et. al. when processing.
Make pw_scan(3) more compatible with getpwent(3) et. al. when processing
Jul 26 2018, 6:34 PM

Jul 24 2018

ian accepted D16434: Actually install bsd.dirs.mk.
Jul 24 2018, 10:16 PM

Jul 23 2018

ian committed rS336642: Revert r336619, it appears to cause problems with ssh, and probably other.
Revert r336619, it appears to cause problems with ssh, and probably other
Jul 23 2018, 5:26 PM
ian committed rS336638: Revert r336625 until I figure out why it worked with simple testing but.
Revert r336625 until I figure out why it worked with simple testing but
Jul 23 2018, 2:59 PM
ian committed rP475132: Add TrustedBSD MAC(4) support to ntpd..
Add TrustedBSD MAC(4) support to ntpd.
Jul 23 2018, 12:33 AM
ian closed D16396: Add TrustedBSD MAC(4) support to ntpd..
Jul 23 2018, 12:33 AM
ian added a comment to D16396: Add TrustedBSD MAC(4) support to ntpd..
In D16396#348104, @cy wrote:

Thanks. You can do ntp and ntp-devel in one commit.

Jul 23 2018, 12:19 AM

Jul 22 2018

ian committed rS336625: Make pw(8) showuser work the same with or without -R <path> for non-root.
Make pw(8) showuser work the same with or without -R <path> for non-root
Jul 22 2018, 11:41 PM
ian committed rS336619: Set the pw_class field to NULL when scanning the non-master passwd file..
Set the pw_class field to NULL when scanning the non-master passwd file.
Jul 22 2018, 10:34 PM
ian updated the diff for D16396: Add TrustedBSD MAC(4) support to ntpd..

Add PORTREVISION.

Jul 22 2018, 7:43 PM
ian created D16396: Add TrustedBSD MAC(4) support to ntpd..
Jul 22 2018, 6:20 PM
ian committed rS336608: Alpha-sort the list of user/group IDs to check at install time..
Alpha-sort the list of user/group IDs to check at install time.
Jul 22 2018, 4:51 PM
ian committed rS336607: Remove the .if ${MK_FOO} wrappers around the user/group ID checks. These.
Remove the .if ${MK_FOO} wrappers around the user/group ID checks. These
Jul 22 2018, 4:42 PM
ian committed rS336606: Add ntpd to the list of users not allowed to log into ftp..
Add ntpd to the list of users not allowed to log into ftp.
Jul 22 2018, 4:17 PM

Jul 21 2018

ian committed rS336583: Add option MAC to armv6 and armv7 kernels by default, it needs to be.
Add option MAC to armv6 and armv7 kernels by default, it needs to be
Jul 21 2018, 6:54 PM
ian committed rD52039: Document version 1200075..
Document version 1200075.
Jul 21 2018, 6:50 PM

Jul 20 2018

ian committed rS336562: Add a note about the new 'ntpd' userid, and the fact that rc.d/ntpd now.
Add a note about the new 'ntpd' userid, and the fact that rc.d/ntpd now
Jul 20 2018, 6:03 PM
ian accepted D16368: Fix `make` in sys/modules/spigen.

Oops, my bad, sorry about that. IMO, you should probably just commit changes like this without slowing down with a phab review.

Jul 20 2018, 5:44 PM
ian committed rS336553: Apply some late-arriving markup suggestions from the phab review, and add a.
Apply some late-arriving markup suggestions from the phab review, and add a
Jul 20 2018, 4:07 PM
ian added a comment to D16281: Make it possible to run ntpd as a non-root user, add ntpd uid and gid..
In D16281#347193, @bjk wrote:

Sorry to have missed this when it first came in; the mdoc could use some changes.

Jul 20 2018, 4:04 PM
ian committed rS336548: Support installing manpages for multiple or alternate architecture(s)..
Support installing manpages for multiple or alternate architecture(s).
Jul 20 2018, 2:23 PM
ian closed D16198: Support installing manpages for multiple or alternate architecture(s)..
Jul 20 2018, 2:23 PM
ian committed rS336547: Automatically run ntpd as non-root when possible..
Automatically run ntpd as non-root when possible.
Jul 20 2018, 1:59 PM
ian closed D16050: Automatically run ntpd as non-root when possible..
Jul 20 2018, 1:59 PM
ian committed rS336526: Add ntpd to the list of users/groups to check before installing..
Add ntpd to the list of users/groups to check before installing.
Jul 20 2018, 12:44 AM

Jul 19 2018

ian committed rS336525: Make it possible to run ntpd as a non-root user, add ntpd uid and gid..
Make it possible to run ntpd as a non-root user, add ntpd uid and gid.
Jul 19 2018, 11:55 PM
ian closed D16281: Make it possible to run ntpd as a non-root user, add ntpd uid and gid..
Jul 19 2018, 11:55 PM

Jul 18 2018

ian added inline comments to D16281: Make it possible to run ntpd as a non-root user, add ntpd uid and gid..
Jul 18 2018, 2:34 PM
ian added inline comments to D16050: Automatically run ntpd as non-root when possible..
Jul 18 2018, 2:31 PM
ian updated the diff for D16050: Automatically run ntpd as non-root when possible..

Fix the logic for handling mac(4)-not-in-kernel and mac_ntpd policy not-enabled. The last round of refactoring changed all this stuff to 'early return to run as root' and the logic for these checks got pasted from the old code without change.

Jul 18 2018, 2:29 PM

Jul 16 2018

ian accepted D16292: zfsboot: fix build with WITHOUT_LOADER_GELI.

Ooops, sorry about that, I guess I never re-tested WITHOUT_LOADER_GELI after making various changes after the first rev.

Jul 16 2018, 6:25 PM
ian updated the diff for D16050: Automatically run ntpd as non-root when possible..

Add requested logging when moving/changing files and dirs.

Jul 16 2018, 5:58 PM

Jul 15 2018

ian updated the diff for D16050: Automatically run ntpd as non-root when possible..

Fix a typo (s/driftopt-/driftopt=/) that made it through my initial testing.

Jul 15 2018, 9:28 PM
ian updated the diff for D16050: Automatically run ntpd as non-root when possible..

While testing and redeveloping the previous version of the rc.d/ntpd changes, I came to the conclusion that automatically setting up a chroot in an rc.d script is complicated and fraught with potential peril. When I got the point of having a embedded awk program that parsed the ntp.conf file so I could figure out whether we needed to mount a devfs inside the chroot for PPS device access, I realized I was way down a too-complicated path.

Jul 15 2018, 9:16 PM
ian created D16281: Make it possible to run ntpd as a non-root user, add ntpd uid and gid..
Jul 15 2018, 8:47 PM

Jul 14 2018

ian accepted D16245: Fix buildworld on FreeBSD 10.

This does indeed fix the problem with building 12 on a 10-stable system, can we please get it committed asap?

Jul 14 2018, 5:55 PM
ian committed rS336283: Eliminate an unused var warning-error; the var is used only when parsing.
Eliminate an unused var warning-error; the var is used only when parsing
Jul 14 2018, 4:33 PM

Jul 13 2018

ian committed rS336256: Fix glitched indentation (and rewrap as needed due to deeper indent)..
Fix glitched indentation (and rewrap as needed due to deeper indent).
Jul 13 2018, 6:58 PM
ian committed rS336252: Extend loader(8) geli support to all architectures and all disk-like devices..
Extend loader(8) geli support to all architectures and all disk-like devices.
Jul 13 2018, 5:50 PM
ian closed D15743: Extend loader(8) geli support to all architectures and all disk-like devices..
Jul 13 2018, 5:50 PM
ian added a comment to D15743: Extend loader(8) geli support to all architectures and all disk-like devices..

UEFI testing completed; this code now passes all the tests generated by tools/boot/rootgen.sh, and has also been tested on armv7 systems with ubldr. I think it is ready to commit.

Jul 13 2018, 4:42 PM
ian committed rS336243: Make generated scripts executable..
Make generated scripts executable.
Jul 13 2018, 4:38 PM
ian committed rS336242: More little fixes... fix a function name typo (eps vs esp), and cope with.
More little fixes... fix a function name typo (eps vs esp), and cope with
Jul 13 2018, 4:33 PM
ian committed rS336241: Revert r336240, which contained unrelated changes accidentally committed..
Revert r336240, which contained unrelated changes accidentally committed.
Jul 13 2018, 4:33 PM
ian committed rS336240: More little fixes... fix a function name typo (eps vs esp), and cope with.
More little fixes... fix a function name typo (eps vs esp), and cope with
Jul 13 2018, 4:31 PM

Jul 12 2018

ian committed rS336222: Wee fix: $dev is passed in to the function with the /dev prefix already in.
Wee fix: $dev is passed in to the function with the /dev prefix already in
Jul 12 2018, 5:22 PM
ian added a comment to D16237: release: Remove some arm board release config.
In D16237#344541, @manu wrote:
In D16237#344539, @ian wrote:

Does this mean that cubox-humingboard images will no longer be available for download?

Yeah.
It is still popular enough so we leave it ?

Jul 12 2018, 1:59 PM
ian added a comment to D16237: release: Remove some arm board release config.

Does this mean that cubox-humingboard images will no longer be available for download?

Jul 12 2018, 1:28 PM

Jul 11 2018

ian committed rS336216: Actually build and install the spigen.4 manpage..
Actually build and install the spigen.4 manpage.
Jul 11 2018, 11:59 PM
ian committed rS336214: Add various spi devices to NOTES. Add some required options for building.
Add various spi devices to NOTES. Add some required options for building
Jul 11 2018, 10:23 PM
ian committed rS336202: Enhancements and fixes for the spigen(4) driver....
Enhancements and fixes for the spigen(4) driver...
Jul 11 2018, 5:54 PM

Jul 10 2018

ian added inline comments to D16169: Rework sys/modules/Makefile to improve arch and option filtering..
Jul 10 2018, 2:22 PM

Jul 9 2018

ian committed rS336138: Add pnp info to the imx_spi driver..
Add pnp info to the imx_spi driver.
Jul 9 2018, 7:00 PM
ian committed rS336137: Add a manpage for the imx_spi driver..
Add a manpage for the imx_spi driver.
Jul 9 2018, 7:00 PM
ian updated the diff for D16198: Support installing manpages for multiple or alternate architecture(s)..

By popular demand (on irc), support a special MAN_ARCH value of "all" to install all available arches. Also, update the wording of the make.conf entry to use MACHINE and MACHINE_ARCH, to match the terms used in man(1).

Jul 9 2018, 6:01 PM
ian created D16198: Support installing manpages for multiple or alternate architecture(s)..
Jul 9 2018, 3:02 PM
ian committed rS336134: Add missing generated header file..
Add missing generated header file.
Jul 9 2018, 2:18 PM

Jul 8 2018

ian committed rS336112: Oops, fix a typo: imx_snvs should be imx6_snvs..
Oops, fix a typo: imx_snvs should be imx6_snvs.
Jul 8 2018, 9:14 PM
ian committed rS336111: Move device statements out of std.imx* and into kernel config files..
Move device statements out of std.imx* and into kernel config files.
Jul 8 2018, 9:10 PM
ian committed rS336096: Make the imx6_snvs driver usable as a module, add pnp info. Add a manpage..
Make the imx6_snvs driver usable as a module, add pnp info. Add a manpage.
Jul 8 2018, 7:35 PM
ian committed rS336094: Catch up with improvements in RTC handling... It's no longer necessary to.
Catch up with improvements in RTC handling... It's no longer necessary to
Jul 8 2018, 6:44 PM
ian committed rS336080: Create an aarch64 subdir under man4, now that we have aarch64 manpages..
Create an aarch64 subdir under man4, now that we have aarch64 manpages.
Jul 8 2018, 1:29 AM
ian committed rS336079: Add pnp info to imx6_ahci, and add a module makefile, and a manpage for it..
Add pnp info to imx6_ahci, and add a module makefile, and a manpage for it.
Jul 8 2018, 12:27 AM
ian committed rS336078: Move armv8crypto.4 into the aarch64 dir; should have been part of r336077..
Move armv8crypto.4 into the aarch64 dir; should have been part of r336077.
Jul 8 2018, 12:02 AM

Jul 7 2018

ian committed rS336077: Move arm- and aarch64-specific manpages into arch-specific directories..
Move arm- and aarch64-specific manpages into arch-specific directories.
Jul 7 2018, 9:49 PM
ian committed rS336076: Add a manpage for the imx5/6 watchdog driver..
Add a manpage for the imx5/6 watchdog driver.
Jul 7 2018, 8:43 PM
ian committed rS336073: Add support to the imx watchdog for the FDT "timeout-sec" property, by.
Add support to the imx watchdog for the FDT "timeout-sec" property, by
Jul 7 2018, 7:10 PM
ian committed rS336072: Correctly calculate the value to put in the imx wdog countdown register..
Correctly calculate the value to put in the imx wdog countdown register.
Jul 7 2018, 7:03 PM
ian committed rS336070: Add pnp info and a module makefile for the imx_wdog watchdog driver..
Add pnp info and a module makefile for the imx_wdog watchdog driver.
Jul 7 2018, 5:25 PM
ian added a comment to D14646: Remove ufs-specific mountroot code that waited for devices..

My only worry is this: what if we had a zpool with devices that require different time to go online, and we mount rootfs while one of them is still offline? Wouldn't this result in a degraded root pool?

Jul 7 2018, 4:02 PM
ian created D16169: Rework sys/modules/Makefile to improve arch and option filtering..
Jul 7 2018, 1:38 AM

Jul 6 2018

ian committed rS336052: Set .PATH to dev/usb/serial so that these modules compile again..
Set .PATH to dev/usb/serial so that these modules compile again.
Jul 6 2018, 10:07 PM

Jul 5 2018

ian committed rS335992: MFC r335283:.
MFC r335283:
Jul 5 2018, 4:15 PM
ian committed rS335991: MFC r333255, r333260.
MFC r333255, r333260
Jul 5 2018, 4:13 PM
ian committed rS335989: Detach all children before beginning to tear down the hardware, instead of.
Detach all children before beginning to tear down the hardware, instead of
Jul 5 2018, 4:01 PM
ian committed rS335988: Add a missing call to usb_bus_mem_free_all() when detaching..
Add a missing call to usb_bus_mem_free_all() when detaching.
Jul 5 2018, 3:52 PM
ian committed rS335985: Remove a test and early-out which just can't possibly be right. It causes.
Remove a test and early-out which just can't possibly be right. It causes
Jul 5 2018, 3:34 PM
ian committed rS335982: Fix an out-of-bounds array access... the irq data for teardown is in two.
Fix an out-of-bounds array access... the irq data for teardown is in two
Jul 5 2018, 2:10 PM

Jul 4 2018

ian committed rS335952: MFC r335575, r335786.
MFC r335575, r335786
Jul 4 2018, 2:12 PM
ian committed rS335950: MFC r335595-r335596.
MFC r335595-r335596
Jul 4 2018, 2:10 PM
ian committed rS335949: MFC r335595-r335596.
MFC r335595-r335596
Jul 4 2018, 2:04 PM
ian committed rS335948: MFC r335575, r335786-r335787.
MFC r335575, r335786-r335787
Jul 4 2018, 2:02 PM