Page MenuHomeFreeBSD

ian (Ian Lepore)
User

Projects

User Details

User Since
May 11 2014, 1:02 PM (253 w, 2 d)

Recent Activity

Mon, Mar 11

ian committed rS345000: Mark the imx_spi device busy while transfers are in progress, so that the.
Mark the imx_spi device busy while transfers are in progress, so that the
Mon, Mar 11, 3:07 AM
ian added inline comments to D19351: Allow kernel config to specify DTS/DTSO to build, and out-of-tree support.
Mon, Mar 11, 12:11 AM

Sun, Mar 10

ian updated the diff for D19535: Support device-independent labels for geom_flashmap slices..

Add the required change to sys/conf/files, missed in the first diff.

Sun, Mar 10, 11:29 PM
ian created D19535: Support device-independent labels for geom_flashmap slices..
Sun, Mar 10, 11:16 PM
ian committed rS344981: Give the mx25l device sole ownership of the name /dev/flash/spi* instead of.
Give the mx25l device sole ownership of the name /dev/flash/spi* instead of
Sun, Mar 10, 6:48 PM

Sat, Mar 2

ian committed rS344734: Allow the sector size of the disk device to be configured using hints or.
Allow the sector size of the disk device to be configured using hints or
Sat, Mar 2, 11:20 PM
ian committed rS344733: Add some comments. Give #define'd names to some scattered numbers. Change.
Add some comments. Give #define'd names to some scattered numbers. Change
Sat, Mar 2, 10:29 PM
ian committed rS344728: Bugfix: use a dummy buffer for the inactive side of a transfer..
Bugfix: use a dummy buffer for the inactive side of a transfer.
Sat, Mar 2, 8:59 PM

Fri, Mar 1

ian committed rS344686: Add another required header file..
Add another required header file.
Fri, Mar 1, 4:17 AM
ian committed rS344685: Add required header file to SRCS..
Add required header file to SRCS.
Fri, Mar 1, 3:10 AM
ian committed rS344684: Undo accidental part of r344681..
Undo accidental part of r344681.
Fri, Mar 1, 2:54 AM
ian committed rS344681: Build fdt support modules on systems that use fdt data..
Build fdt support modules on systems that use fdt data.
Fri, Mar 1, 2:31 AM

Wed, Feb 27

ian committed rS344616: Add support to fdt_slicer for the new style partition data documented in.
Add support to fdt_slicer for the new style partition data documented in
Wed, Feb 27, 4:58 AM
ian committed rS344615: Child nodes with a compatible property are not slices, according to the.
Child nodes with a compatible property are not slices, according to the
Wed, Feb 27, 4:19 AM
ian committed rS344614: Rename some functions and variables to have shorter names, which allows.
Rename some functions and variables to have shorter names, which allows
Wed, Feb 27, 4:16 AM

Tue, Feb 26

ian committed rS344612: Add a module dependency on fdt_slicer. Also, move the PNP_INFO to its more.
Add a module dependency on fdt_slicer. Also, move the PNP_INFO to its more
Tue, Feb 26, 10:53 PM
ian committed rS344611: Add a module dependency on fdt_slicer..
Add a module dependency on fdt_slicer.
Tue, Feb 26, 10:52 PM
ian committed rS344610: Add manpages for at45d(4) and mx25l(4)..
Add manpages for at45d(4) and mx25l(4).
Tue, Feb 26, 10:50 PM
ian committed rS344609: Make it possible to load fdt_slicer as a module (unloading works too fwiw)..
Make it possible to load fdt_slicer as a module (unloading works too fwiw).
Tue, Feb 26, 10:34 PM
ian committed rS344608: Update a comment to reflect reality; no functional changes..
Update a comment to reflect reality; no functional changes.
Tue, Feb 26, 10:08 PM
ian committed rS344607: Compile fdt_slicer and geom_flashmap when the at45d device is included..
Compile fdt_slicer and geom_flashmap when the at45d device is included.
Tue, Feb 26, 10:06 PM
ian committed rS344606: Add support for geom_flashmap by providing a getattr() for "SPI:device"..
Add support for geom_flashmap by providing a getattr() for "SPI:device".
Tue, Feb 26, 8:51 PM

Mon, Feb 25

ian committed rS344556: Set maximum bus clock speed from hints when attaching hinted spibus(4) children..
Set maximum bus clock speed from hints when attaching hinted spibus(4) children.
Mon, Feb 25, 11:50 PM
ian committed rS344529: Fix a paste-o that broke the build on all arches..
Fix a paste-o that broke the build on all arches.
Mon, Feb 25, 6:12 PM
ian committed rS344526: Resolve a name conflict when both SpiFlash and DataFlash devices are present..
Resolve a name conflict when both SpiFlash and DataFlash devices are present.
Mon, Feb 25, 5:30 PM
ian committed rS344525: Add a metadata entry for the AT45DB641E chip. This chip has the same 3-byte.
Add a metadata entry for the AT45DB641E chip. This chip has the same 3-byte
Mon, Feb 25, 4:40 PM
ian committed rS344523: Include the jedec "extended device information string" in the criteria used.
Include the jedec "extended device information string" in the criteria used
Mon, Feb 25, 4:21 PM
ian committed rS344507: Switch to using config_intrhook_oneshot(). That allows the error handling.
Switch to using config_intrhook_oneshot(). That allows the error handling
Mon, Feb 25, 3:29 AM

Sun, Feb 24

ian committed rS344506: Add support for probing/attaching on FDT-based systems..
Add support for probing/attaching on FDT-based systems.
Sun, Feb 24, 11:16 PM
ian committed rS344505: Add a functional detach() implementation to make module unloading possible..
Add a functional detach() implementation to make module unloading possible.
Sun, Feb 24, 11:09 PM
ian accepted D19314: Add ACPI support for RTC/CMOS device.

I don't know much about acpi, but from the viewpoint of what I know about the atrtc driver, this looks okay. Using rtcin/out_locked() as I mentioned above would be a small performance enhancement. I don't have a ton of free time these days and may not get around to reviewing a revised diff. I'm okay with making the changes I noted above or not; either way is fine with me.

Sun, Feb 24, 7:33 PM
ian updated the diff for D19262: Distinguish between "no partition" and "choose best partition" with a constant..

Fix a couple missed number->name changes.

Sun, Feb 24, 6:42 PM
ian added inline comments to D19262: Distinguish between "no partition" and "choose best partition" with a constant..
Sun, Feb 24, 6:26 PM

Wed, Feb 20

ian updated the diff for D19262: Distinguish between "no partition" and "choose best partition" with a constant..

Update comments to explain D_PARTWILD and use D_PARTISGPT instead of 255.

Wed, Feb 20, 3:38 AM
ian added a comment to D19243: loader: devopen() should probe partition 'a' from freebsd slice first.

I think this is not a good solution either. It feels like more of the same thing we've been doing for 20 years... finding a small clever hack that makes the current pain go away as an alternative to doing the larger cleanup that begs to be done.

Wed, Feb 20, 3:24 AM
ian created D19262: Distinguish between "no partition" and "choose best partition" with a constant..
Wed, Feb 20, 3:22 AM
ian committed rS344335: Fix the handling of legacy-format devices in the u-boot loaderdev variable..
Fix the handling of legacy-format devices in the u-boot loaderdev variable.
Wed, Feb 20, 3:01 AM

Mon, Feb 18

ian added a comment to D19238: loader: disk api should honor d_partition = -1 and open slice.
Mon, Feb 18, 9:50 PM
ian requested changes to D19238: loader: disk api should honor d_partition = -1 and open slice.

This is insufficient. Whether we like it or not, whether it's documented or not, it is an existing feature that disk_open() with partition set to any negative number means "use the first freebsd-ufs partition in the slice". This isn't documented anywhere, even the loader(8) manpage only says "the syntax for devices is odd". But if we change the current behavior, peoples' existing configurations can break, leaving them without access to a remote system, etc.

Mon, Feb 18, 9:30 PM
ian committed rS344267: Add a compatible string to match recent changes in the upstream dts..
Add a compatible string to match recent changes in the upstream dts.
Mon, Feb 18, 7:51 PM
ian committed rS344260: Allow the u-boot loaderdev env var to be formatted in the "usual" loader(8).
Allow the u-boot loaderdev env var to be formatted in the "usual" loader(8)
Mon, Feb 18, 5:12 PM
ian committed rS344255: Fix more places to use DEV_TYP_NONE instead of -1 to indicate 'no device'..
Fix more places to use DEV_TYP_NONE instead of -1 to indicate 'no device'.
Mon, Feb 18, 3:28 PM
ian committed rS344254: Use DEV_TYP_NONE instead of -1 to indicate no device was specified..
Use DEV_TYP_NONE instead of -1 to indicate no device was specified.
Mon, Feb 18, 3:09 PM

Feb 18 2019

ian committed rS344247: Make uboot_devdesc properly alias disk_devdesc, so that parsing the u-boot.
Make uboot_devdesc properly alias disk_devdesc, so that parsing the u-boot
Feb 18 2019, 4:45 AM

Feb 17 2019

ian committed rS344241: Garbage collection no-longer-used constant..
Garbage collection no-longer-used constant.
Feb 17 2019, 11:49 PM
ian committed rS344240: Make lsdev -v output line up in neat columns by using a fixed width for.
Make lsdev -v output line up in neat columns by using a fixed width for
Feb 17 2019, 11:46 PM
ian committed rS344239: Use a couple local variables to avoid repetitive long expressions that.
Use a couple local variables to avoid repetitive long expressions that
Feb 17 2019, 11:38 PM
ian committed rS344238: Restore loader(8)'s ability for lsdev to show partitions within a bsd slice..
Restore loader(8)'s ability for lsdev to show partitions within a bsd slice.
Feb 17 2019, 11:32 PM

Feb 5 2019

ian added inline comments to D19077: uart_dev_pl011: add EARLY_PRINTF support.
Feb 5 2019, 2:13 AM

Jan 7 2019

ian committed rS342850: Add a missing \n to a bootverbose printf..
Add a missing \n to a bootverbose printf.
Jan 7 2019, 4:36 PM

Dec 31 2018

ian committed rS342652: Support the SPI mode and bus clock frequency parameters set by the devices.
Support the SPI mode and bus clock frequency parameters set by the devices
Dec 31 2018, 4:01 PM
ian committed rS342639: When allocating a new keyboard at vt_upgrade() time, unwind any cngrabs.
When allocating a new keyboard at vt_upgrade() time, unwind any cngrabs
Dec 31 2018, 1:09 AM

Dec 6 2018

ian committed rS341651: Don't reference zfs-specific variables if LOADER_ZFS_SUPPORT is undefined.
Don't reference zfs-specific variables if LOADER_ZFS_SUPPORT is undefined
Dec 6 2018, 8:28 PM

Dec 4 2018

ian committed rS341473: Fix args cross-threading between gptboot(8) and loader(8) with zfs support..
Fix args cross-threading between gptboot(8) and loader(8) with zfs support.
Dec 4 2018, 4:45 PM

Dec 3 2018

ian committed rS341421: MFC r341071, r341160.
MFC r341071, r341160
Dec 3 2018, 4:09 AM
ian committed rS341420: Eliminate duplicated code and struct member definitions in the handoff.
Eliminate duplicated code and struct member definitions in the handoff
Dec 3 2018, 3:58 AM

Nov 28 2018

ian committed rS341160: Add comments describing the bootargs handoff between loader(8) and gptboot.
Add comments describing the bootargs handoff between loader(8) and gptboot
Nov 28 2018, 6:10 PM

Nov 27 2018

ian committed rS341071: Restore the ability to override the disk unit/partition at the boot: prompt.
Restore the ability to override the disk unit/partition at the boot: prompt
Nov 27 2018, 4:19 PM
ian committed rS341070: Revert r341069, I committed it to the wrong branch..
Revert r341069, I committed it to the wrong branch.
Nov 27 2018, 4:15 PM
ian committed rS341069: Restore the ability to override the disk unit/partition at the boot: prompt.
Restore the ability to override the disk unit/partition at the boot: prompt
Nov 27 2018, 4:11 PM

Sep 13 2018

ian committed rS338648: If a user skips the pre-world mergemaster, an installworld check.
If a user skips the pre-world mergemaster, an installworld check
Sep 13 2018, 3:16 PM

Sep 4 2018

ian accepted D17023: Support Capsicum on armv6/armv7.

This looks good to me (I assume it's been tested, I didn't try it myself).

Sep 4 2018, 9:50 PM

Sep 3 2018

ian added a comment to D6814: Add libfdt user space library.

This should be attached to the build, and used by the GNU dtc.

I'm wondering should libfdt be conditionally built and, if so, should it be based on MK_FDT and MK_GPL_DTC (since the dtc build will be using it after the suggested changes)?

Sep 3 2018, 3:09 PM

Aug 17 2018

ian added a comment to D16775: Make 'device crypto' lines more consistent..

If using option IPSEC (and I guess GELI and maybe other things) requires explicitly specifying device crypto, then shouldn't this change also cleanup and simplify sys/conf/files to remove "| ipsec | ipsec_support" from all the files that are optional on "crypto"?

Aug 17 2018, 4:38 PM

Aug 13 2018

ian committed rS337731: Export the eeprom device size via readonly sysctl. Also export the write.
Export the eeprom device size via readonly sysctl. Also export the write
Aug 13 2018, 11:53 PM
ian accepted D16702: Add pthread_get_name_np(3)..
Aug 13 2018, 4:28 PM
ian added inline comments to D16702: Add pthread_get_name_np(3)..
Aug 13 2018, 3:43 PM

Aug 11 2018

ian accepted D16661: Move NTP related files to usr.sbin/ntp/ntpd/.

This looks okay to me.

Aug 11 2018, 5:22 PM

Aug 8 2018

ian added a comment to D16507: build: skip the database check for the distributeworld target.
In D16507#353355, @gjb wrote:
In D16507#353346, @ian wrote:

As mentioned out-of-band, I added the ntpd UID/GID to work around this issue.

Added it to what? IMO, it's a really bad idea to paper over this mess, it just means we have to suffer all this pain again next time a user is added to the base system.

Sorry for the incomplete statement. Added to the build host so 'installworld' to the target chroot directories did not error.

I could have just upgraded the build host, but chose to apply a band-aid for this one case.

Aug 8 2018, 5:32 PM
ian added a comment to D16507: build: skip the database check for the distributeworld target.
In D16507#353334, @gjb wrote:

This is part of the 'ftp' target in the release directory that runs the release/scripts/mm-mtree.sh. I see that there are snapshots still being created without issues, so I wonder what runes are used inside of the cluster to generate the install media. Is something different from 'make -C release ftp' used to generate the install sets?

As mentioned out-of-band, I added the ntpd UID/GID to work around this issue.

Aug 8 2018, 5:09 PM

Aug 5 2018

ian committed rS337364: Document 64-bit arm in terms of arch name (aarch64) not machine (arm64)..
Document 64-bit arm in terms of arch name (aarch64) not machine (arm64).
Aug 5 2018, 10:24 PM

Jul 31 2018

ian accepted D16507: build: skip the database check for the distributeworld target.

I'm 'accepting' this revision in the sense that I think this is the right way to achieve unconditional use of users and groups from the source being installed, for the distributeworld target. I can't say whether doing so is a good idea or not in general, because I don't know much about the distributeworld target.

Jul 31 2018, 3:08 PM

Jul 30 2018

ian added a comment to D16507: build: skip the database check for the distributeworld target.

Hrm, I didn't intend for my previous comments to include the "request changes" flag, don't consider my comments to be blocking, I was just throwing them out there to see what other people think.

Jul 30 2018, 3:06 PM
ian requested changes to D16507: build: skip the database check for the distributeworld target.

I'm not sure what led to putting these changes where they're at in the makefile, it seems a bit unrelated to the things immediately surrounding it. It should be noted that for this change to work properly, the new lines must appear before line 833 (pre-patched, or 838 with this patch included). It might make more sense to move this change to just before line 833; that would make it a lot more clear what the real effect of this change is.

Jul 30 2018, 3:04 PM

Jul 29 2018

ian committed rS336869: The device ID tables are used only within the driver, make them static so.
The device ID tables are used only within the driver, make them static so
Jul 29 2018, 4:55 PM

Jul 27 2018

ian committed rS336779: Stop exporting __pw_scan and __pw_initpwd as freebsd-private libc functions.
Stop exporting __pw_scan and __pw_initpwd as freebsd-private libc functions
Jul 27 2018, 7:47 PM
ian committed rS336762: Remove some code that's no longer needed because it's now part of pw_scan(3)..
Remove some code that's no longer needed because it's now part of pw_scan(3).
Jul 27 2018, 3:17 PM

Jul 26 2018

ian committed rS336751: Re-apply r336625 which was reverted with r336638, now that the underlying.
Re-apply r336625 which was reverted with r336638, now that the underlying
Jul 26 2018, 8:03 PM
ian committed rS336746: Make pw_scan(3) more compatible with getpwent(3) et. al. when processing.
Make pw_scan(3) more compatible with getpwent(3) et. al. when processing
Jul 26 2018, 6:34 PM

Jul 24 2018

ian accepted D16434: Actually install bsd.dirs.mk.
Jul 24 2018, 10:16 PM

Jul 23 2018

ian committed rS336642: Revert r336619, it appears to cause problems with ssh, and probably other.
Revert r336619, it appears to cause problems with ssh, and probably other
Jul 23 2018, 5:26 PM
ian committed rS336638: Revert r336625 until I figure out why it worked with simple testing but.
Revert r336625 until I figure out why it worked with simple testing but
Jul 23 2018, 2:59 PM
ian committed rP475132: Add TrustedBSD MAC(4) support to ntpd..
Add TrustedBSD MAC(4) support to ntpd.
Jul 23 2018, 12:33 AM
ian closed D16396: Add TrustedBSD MAC(4) support to ntpd..
Jul 23 2018, 12:33 AM
ian added a comment to D16396: Add TrustedBSD MAC(4) support to ntpd..
In D16396#348104, @cy wrote:

Thanks. You can do ntp and ntp-devel in one commit.

Jul 23 2018, 12:19 AM

Jul 22 2018

ian committed rS336625: Make pw(8) showuser work the same with or without -R <path> for non-root.
Make pw(8) showuser work the same with or without -R <path> for non-root
Jul 22 2018, 11:41 PM
ian committed rS336619: Set the pw_class field to NULL when scanning the non-master passwd file..
Set the pw_class field to NULL when scanning the non-master passwd file.
Jul 22 2018, 10:34 PM
ian updated the diff for D16396: Add TrustedBSD MAC(4) support to ntpd..

Add PORTREVISION.

Jul 22 2018, 7:43 PM
ian created D16396: Add TrustedBSD MAC(4) support to ntpd..
Jul 22 2018, 6:20 PM
ian committed rS336608: Alpha-sort the list of user/group IDs to check at install time..
Alpha-sort the list of user/group IDs to check at install time.
Jul 22 2018, 4:51 PM
ian committed rS336607: Remove the .if ${MK_FOO} wrappers around the user/group ID checks. These.
Remove the .if ${MK_FOO} wrappers around the user/group ID checks. These
Jul 22 2018, 4:42 PM
ian committed rS336606: Add ntpd to the list of users not allowed to log into ftp..
Add ntpd to the list of users not allowed to log into ftp.
Jul 22 2018, 4:17 PM

Jul 21 2018

ian committed rS336583: Add option MAC to armv6 and armv7 kernels by default, it needs to be.
Add option MAC to armv6 and armv7 kernels by default, it needs to be
Jul 21 2018, 6:54 PM
ian committed rD52039: Document version 1200075..
Document version 1200075.
Jul 21 2018, 6:50 PM

Jul 20 2018

ian committed rS336562: Add a note about the new 'ntpd' userid, and the fact that rc.d/ntpd now.
Add a note about the new 'ntpd' userid, and the fact that rc.d/ntpd now
Jul 20 2018, 6:03 PM
ian accepted D16368: Fix `make` in sys/modules/spigen.

Oops, my bad, sorry about that. IMO, you should probably just commit changes like this without slowing down with a phab review.

Jul 20 2018, 5:44 PM
ian committed rS336553: Apply some late-arriving markup suggestions from the phab review, and add a.
Apply some late-arriving markup suggestions from the phab review, and add a
Jul 20 2018, 4:07 PM
ian added a comment to D16281: Make it possible to run ntpd as a non-root user, add ntpd uid and gid..
In D16281#347193, @bjk wrote:

Sorry to have missed this when it first came in; the mdoc could use some changes.

Jul 20 2018, 4:04 PM
ian committed rS336548: Support installing manpages for multiple or alternate architecture(s)..
Support installing manpages for multiple or alternate architecture(s).
Jul 20 2018, 2:23 PM
ian closed D16198: Support installing manpages for multiple or alternate architecture(s)..
Jul 20 2018, 2:23 PM