We don't need to do the busy dance for this driver. It's handled by
destroy_dev() entirely. Since all we did was busy/unbusy in
open/close, just delete them. We therefore don't need to track closes
either.
Details
Details
- Reviewers
• ian
Diff Detail
Diff Detail
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 33334 Build 30645: arc lint + arc unit
Event Timeline
Comment Actions
Nothing. Just like we don't do it for almost all other devices. If that's really needed, we should do it via the device_quesce mechanism.
Comment Actions
Huh. I didn't know about device_quiesce(), it might not have existed when I added the busy/unbusy to icee. There's no manpage describing it, but the implementation is easy enough to figure out (and I think it may be wrong, DS_ATTACHING state should probably yield EBUSY).
I guess I was just over-thinking things when I added the busy/unbusy to prevent unloading; repo archaeology shows I added them in the commit "Make icee usable as a module". I think I also didn't understand the TRACKCLOSE flag back then, and it should never have been included.