User Details
- User Since
- May 14 2014, 8:42 PM (561 w, 6 d)
Oct 7 2024
Looks OK to me.
Apr 12 2024
Mar 18 2024
Mar 17 2024
Update comment concerning testing using Steve Kargl's code. This code
needs GNU libraries, so cannot be committed to the source tree.
Mar 3 2024
Remove comment with low signal content.
Mar 2 2024
Take Andy's very good advice and avoid the wrapper function by
#define/#include magic.
Update reviewer list.
Shorten boilerplate in response to review.
Add phab URI.
Give this commit message a proper title
Mar 1 2024
Address review comments.
Fix minor spello in the commit message.
Jan 1 2024
Mar 6 2023
LGTM.
I don't have a major objection to this, but I'm nervous of the lower-numbered pools being favoured. I'm not formally requesting changes yet, as I could be persuaded that I'm wrong.
Aug 9 2022
Seems sensible.
Jul 27 2022
About time!
Jul 13 2022
I'd be happy to green-light this, but I also wonder if there is not a better way. For now, I'm at "no objection" for a merge, but with a request for further exploration of e.g. cached boot-time entropy stashing. (Could a VM do that?)
Feb 16 2022
Who is going to do the actual commit? I'm happy to do it if no-one else wants to? Whoever does it has csprng@ green-light.
Feb 3 2022
Accepting in retrospect. Thanks!
Jan 29 2022
Jan 28 2022
Jan 27 2022
Jan 17 2022
Jan 15 2022
Dec 15 2021
Dec 14 2021
I missed the move of imprecise.c to its new, temporary home in ld128.
This is two git commits - see the commit message.
Oct 13 2021
This looks safe enough to me.
Sep 22 2021
Sep 6 2021
Jul 27 2021
Testing this on an RPi4 would be nice, but it's not a dealbreaker.
Apr 11 2021
Apr 8 2021
Obvious technical debt removal. Please do this.
Obvious technical debt removal. Please do this!
Mar 7 2021
Mar 6 2021
Jan 2 2021
Dec 13 2020
Nov 28 2020
I'm keen on having this - a build is under way. DHYB, it may take a while.
Oct 7 2020
I'm happy to see this landed in disabled form.
I'm happy to see this landed in disabled form.
Sep 16 2020
LGTM.
Sep 1 2020
Aug 3 2020
I like this general idea very much! I'm a bit leery of the critical regions, but I admit that I don't understand them properly. I presume that in a PCPU environment they are fine.
Jul 27 2020
Jul 15 2020
Jul 5 2020
OK to close again.
That works, thanks! I'm at latest CURRENT, no backouts, my console works and so do my PCI ethernet port.
ECAM hacks? When are those likely to appear? :-)
With this patch in, AND the flashe given above, I get my console back!
Worse. Previously working console now broken. Current with this change backed out now broken.
Trying now. In the meanwhile, is there some place where the Collected Wisdom™ of all current mcbin firmware statusses, hints, binaries etc are kept?
Yup - my flash is a couple of months old, and a hand-rolled debug-version (not by me). The image you pointed to fails with checksum errors at boot, but it may have something to do with the way I made it. With the same MBR as the old one, I did:
This change breaks my MacchiattoBin DoubleShot. I've bisected to get to commit r362574, which is this. The symptoms are a hang right at the beginning of the boot, at this point:
Jul 1 2020
Happy with this.
Jun 21 2020
If a committer is needed, I'm happy to oblige, but I'll need testing time, and for that I need to build and boot. If Someone Else(™) can assure me that this works, I'll speed it up a bit.