User Details
- User Since
- May 14 2014, 8:42 PM (348 w, 4 d)
Sat, Jan 2
Dec 13 2020
Nov 28 2020
I'm keen on having this - a build is under way. DHYB, it may take a while.
Oct 7 2020
I'm happy to see this landed in disabled form.
I'm happy to see this landed in disabled form.
Sep 16 2020
LGTM.
Sep 1 2020
Aug 3 2020
I like this general idea very much! I'm a bit leery of the critical regions, but I admit that I don't understand them properly. I presume that in a PCPU environment they are fine.
Jul 27 2020
Jul 15 2020
Jul 5 2020
OK to close again.
That works, thanks! I'm at latest CURRENT, no backouts, my console works and so do my PCI ethernet port.
ECAM hacks? When are those likely to appear? :-)
With this patch in, AND the flashe given above, I get my console back!
Worse. Previously working console now broken. Current with this change backed out now broken.
Trying now. In the meanwhile, is there some place where the Collected Wisdom™ of all current mcbin firmware statusses, hints, binaries etc are kept?
Yup - my flash is a couple of months old, and a hand-rolled debug-version (not by me). The image you pointed to fails with checksum errors at boot, but it may have something to do with the way I made it. With the same MBR as the old one, I did:
This change breaks my MacchiattoBin DoubleShot. I've bisected to get to commit r362574, which is this. The symptoms are a hang right at the beginning of the boot, at this point:
Jul 1 2020
Happy with this.
Jun 21 2020
If a committer is needed, I'm happy to oblige, but I'll need testing time, and for that I need to build and boot. If Someone Else(™) can assure me that this works, I'll speed it up a bit.
Jun 18 2020
Jun 1 2020
Mar 5 2020
Jan 21 2020
Jan 12 2020
Jan 11 2020
LGTM, modulo delphij's comments.
Dec 29 2019
I like the direction this is going, but I'm still reading the design papers.
Dec 28 2019
I can't find anything to object to - but my epoch-fu is a bit lacking, so I'm trusting the other reviewers here.
Dec 25 2019
I'm delighted with the amount of OS-interface and locking code that is removed!
Dec 24 2019
This is a GREAT step forward, so I'm happy to accept it as such. The objection to #undefs is stylistic/idealistic, so you may ignore it at your pleasure.
Dec 19 2019
I've been running this locally too.
No-brainer.
Dec 1 2019
The whole change LGTM, but please go further and remove RANDOM_LOADABLE altogether if the consensus allows!
Nov 30 2019
Nov 23 2019
Nov 22 2019
Shows how much I know about sysctls :-)
Please upload diff with full context.
Nov 20 2019
No objection to the logic, just the user-facing wording needs to be "de-geeked" a bit! :-)
Clarifies the logic a bit. LGTM.
Aug 18 2019
Aug 11 2019
Very small complaints only.
Jul 31 2019
LGTM otherwise.
Jun 27 2019
Presuming all the testing works :-)
Jun 22 2019
Still LGTM :-)
Jun 20 2019
No objection from me.
Jun 9 2019
Jun 7 2019
None job, thanks!
Jun 3 2019
May 31 2019
May 30 2019
May 28 2019
May 23 2019
Good move!
May 19 2019
This is a step in a direction that I've been wanting to doo for quite some time; pin multiple output generators to processors. There is more, but I need to write it in detail first.
May 12 2019
Looks OK to me!
May 8 2019
I'm OK with this.
Apr 18 2019
LGTM.
Apr 11 2019
Against my better judgement, I kept the !DEV_RANDOM case as some folks insisted on being able to use preferred tools (ssh) even on insecure embedded hardware. I'm happy to se you fix it, if it means I don't get the flak ]:->
Apr 6 2019
Apr 5 2019
I'm happy with this, in principle. I defer on the kernel innards, but the general engineering looks sound.
Mar 29 2019
Accept with delphi's changes.
Mar 22 2019
OK. I like these diffs even better.
Mar 21 2019
You need the security officer's say-so. I have a personal wavier when I do such commits myself (as I wrote the main random device), but this is non-transferrable, as far as I know.
Mar 7 2019
Very good!
Mar 6 2019
Nice work! Out for interest, why make the output generator selectable? Why not switch completely to Chacha20?
Mar 1 2019
Overcome By Events.
I like this!
OK.
Looks good to me.