Page MenuHomeFreeBSD

markm (Mark R V Murray)
User

Projects

User Details

User Since
May 14 2014, 8:42 PM (296 w, 2 d)

Recent Activity

Sun, Jan 12

markm accepted D23130: getrandom(2): Add Linux GRND_INSECURE API flag.
Sun, Jan 12, 12:21 PM

Sat, Jan 11

markm added a comment to D22493: Support for bcm2838 RNG.

LGTM, modulo delphij's comments.

Sat, Jan 11, 11:27 AM · arm64

Sun, Dec 29

markm added a comment to D22839: random(4) fenestrasX: Push root seed version to arc4random(3).

I like the direction this is going, but I'm still reading the design papers.

Sun, Dec 29, 10:38 AM
markm accepted D22946: vmgenid(4): Integrate as a random(4) source.

LGTM

Sun, Dec 29, 10:27 AM

Sat, Dec 28

markm accepted D22489: random(4): Make entropy source deregistration safe.

I can't find anything to object to - but my epoch-fu is a bit lacking, so I'm trusting the other reviewers here.

Sat, Dec 28, 11:31 AM

Wed, Dec 25

markm accepted D22512: random(4): Simplify RANDOM_LOADABLE.

I'm delighted with the amount of OS-interface and locking code that is removed!

Wed, Dec 25, 12:32 PM

Tue, Dec 24

markm accepted D22512: random(4): Simplify RANDOM_LOADABLE.

This is a GREAT step forward, so I'm happy to accept it as such. The objection to #undefs is stylistic/idealistic, so you may ignore it at your pleasure.

Tue, Dec 24, 11:25 AM

Thu, Dec 19

markm accepted D22879: random(4): Fortuna: Enable concurrent generation by default for 13.

I've been running this locally too.

Thu, Dec 19, 11:54 PM
markm accepted D22878: random(4): Flip default Fortuna generator over to Chacha20.

No-brainer.

Thu, Dec 19, 11:52 PM

Dec 1 2019

markm accepted D22512: random(4): Simplify RANDOM_LOADABLE.

The whole change LGTM, but please go further and remove RANDOM_LOADABLE altogether if the consensus allows!

Dec 1 2019, 10:21 AM
markm added inline comments to D22512: random(4): Simplify RANDOM_LOADABLE.
Dec 1 2019, 10:17 AM

Nov 30 2019

markm accepted D22612: Reduce disk write load in /usr/libexec/save-entropy.

LGTM

Nov 30 2019, 9:21 AM

Nov 23 2019

markm accepted D22504: Add explicit SI_SUB_EPOCH.

*LIKE*

Nov 23 2019, 9:57 AM

Nov 22 2019

markm accepted D22482: random(4): Abstract loader entropy injection.
Nov 22 2019, 8:07 AM
markm accepted D22484: random(4): Use ordinary sysctl definitions.

Shows how much I know about sysctls :-)

Nov 22 2019, 8:05 AM
markm accepted D22455: random/ivy: Provide mechanism to read independent seed values from rdrand.
Nov 22 2019, 8:03 AM
markm accepted D22485: random(4): De-export random_sources list.
Nov 22 2019, 8:00 AM
markm accepted D22490: virtio_random(4): Drop no longer needed unload kludge.
Nov 22 2019, 7:59 AM
markm accepted D22481: random(4): Remove unused definitions.
Nov 22 2019, 7:57 AM
markm accepted D22489: random(4): Make entropy source deregistration safe.
Nov 22 2019, 7:57 AM
markm added a comment to D22493: Support for bcm2838 RNG.

Please upload diff with full context.

Nov 22 2019, 7:47 AM · arm64

Nov 20 2019

markm added inline comments to D22455: random/ivy: Provide mechanism to read independent seed values from rdrand.
Nov 20 2019, 9:28 PM
markm added a comment to D22455: random/ivy: Provide mechanism to read independent seed values from rdrand.

No objection to the logic, just the user-facing wording needs to be "de-geeked" a bit! :-)

Nov 20 2019, 8:36 AM
markm accepted D22454: random/ivy: Trivial refactoring.

Clarifies the logic a bit. LGTM.

Nov 20 2019, 8:28 AM

Aug 18 2019

markm accepted D21308: random(4): Reorder configuration of random source modules.
Aug 18 2019, 9:25 AM

Aug 11 2019

D21211: Change w(1) to compute FROM (host) field size dynamically is now accepted and ready to land.
Aug 11 2019, 6:33 PM
D21211: Change w(1) to compute FROM (host) field size dynamically is now accepted and ready to land.

Very small complaints only.

Aug 11 2019, 9:38 AM

Jul 31 2019

markm added a comment to D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

LGTM otherwise.

Jul 31 2019, 7:20 AM

Jun 27 2019

D20780: Add support for getting early entropy from the UEFI RNG protocol is now accepted and ready to land.

Presuming all the testing works :-)

Jun 27 2019, 6:26 PM · security, arm64

Jun 22 2019

markm added a comment to D19918: sys: Remove DEV_RANDOM device option.

Still LGTM :-)

Jun 22 2019, 8:59 AM

Jun 20 2019

D19918: sys: Remove DEV_RANDOM device option is now accepted and ready to land.

No objection from me.

Jun 20 2019, 7:37 AM

Jun 9 2019

markm accepted D20313: Fortuna: allow increased concurrency.
Jun 9 2019, 9:18 AM

Jun 7 2019

markm accepted D20312: random(4): Generalize algorithm-independent APIs.
Jun 7 2019, 6:22 PM
markm accepted D20392: random(4): Add regression tests for uint128 implementation, Chacha CTR.

None job, thanks!

Jun 7 2019, 6:21 PM

Jun 3 2019

markm accepted D20419: virtio_random(4): Fix random(4) integration.
Jun 3 2019, 5:29 PM

May 31 2019

markm accepted D20466: random(4): Fix RANDOM_LOADABLE build.
May 31 2019, 7:44 AM

May 30 2019

markm accepted D20466: random(4): Fix RANDOM_LOADABLE build.
May 30 2019, 7:24 AM

May 28 2019

markm accepted D20419: virtio_random(4): Fix random(4) integration.

Good catch!

May 28 2019, 7:18 AM

May 23 2019

markm added a comment to D20358: save-entropy(8), rc.d/random: Set nodump flag.

Good move!

May 23 2019, 8:54 AM

May 19 2019

markm accepted D20313: Fortuna: allow increased concurrency.

This is a step in a direction that I've been wanting to doo for quite some time; pin multiple output generators to processors. There is more, but I need to write it in detail first.

May 19 2019, 10:11 AM
markm added inline comments to D20312: random(4): Generalize algorithm-independent APIs.
May 19 2019, 10:04 AM
markm requested changes to D20312: random(4): Generalize algorithm-independent APIs.
May 19 2019, 9:47 AM

May 12 2019

markm accepted D19928: random(4): More thoroughly attempt to ensure seeding during priming.

Looks OK to me!

May 12 2019, 9:10 AM

May 8 2019

markm accepted D20195: random: Don't complain noisily when an entropy source is slow.

I'm OK with this.

May 8 2019, 7:26 AM

Apr 18 2019

markm accepted D19944: random(4): Restore availability tradeoff prior to r346250.

LGTM.

Apr 18 2019, 7:34 AM

Apr 11 2019

markm added a comment to D19744: random(4): Block read_random(9) on initial seeding.

Against my better judgement, I kept the !DEV_RANDOM case as some folks insisted on being able to use preferred tools (ssh) even on insecure embedded hardware. I'm happy to se you fix it, if it means I don't get the flak ]:->

Apr 11 2019, 9:09 AM

Apr 6 2019

markm committed rS345981: Backport fixes from FreeBSD-12 to help the random(4) device thread.
Backport fixes from FreeBSD-12 to help the random(4) device thread
Apr 6 2019, 9:00 AM

Apr 5 2019

markm accepted D19744: random(4): Block read_random(9) on initial seeding.

I'm happy with this, in principle. I defer on the kernel innards, but the general engineering looks sound.

Apr 5 2019, 11:05 AM

Mar 29 2019

markm accepted D19742: random(4): Attempt to persist entropy promptly.

Accept with delphi's changes.

Mar 29 2019, 9:31 AM

Mar 22 2019

markm accepted D19620: Add an option to use TPM as entropy source.

OK. I like these diffs even better.

Mar 22 2019, 4:55 PM

Mar 21 2019

markm added a comment to D19620: Add an option to use TPM as entropy source.

You need the security officer's say-so. I have a personal wavier when I do such commits myself (as I wrote the main random device), but this is non-transferrable, as far as I know.

Mar 21 2019, 3:00 PM
markm accepted D19620: Add an option to use TPM as entropy source.

LGTM.

Mar 21 2019, 1:00 PM

Mar 7 2019

markm accepted D19475: Fortuna: Add Chacha20 as an alternative stream cipher.

Very good!

Mar 7 2019, 12:06 PM

Mar 6 2019

markm added inline comments to D19475: Fortuna: Add Chacha20 as an alternative stream cipher.
Mar 6 2019, 9:14 AM
markm added a comment to D19475: Fortuna: Add Chacha20 as an alternative stream cipher.

Nice work! Out for interest, why make the output generator selectable? Why not switch completely to Chacha20?

Mar 6 2019, 9:08 AM

Mar 1 2019

markm abandoned D10440: Change arc4random(9) over to using 3-BSD licensed Chacha20..

Overcome By Events.

Mar 1 2019, 10:03 AM
markm accepted D19411: Fortuna: push CTR-mode loop down into randomdev hash.h interface.

I like this!

Mar 1 2019, 10:01 AM
markm accepted D19410: Embedded chacha: Add 0-bit iv + 128-bit counter build mode.

OK.

Mar 1 2019, 9:57 AM
markm accepted D19409: fortuna: Deduplicate kernel vs user includes.

Looks good to me.

Mar 1 2019, 9:55 AM

Nov 26 2018

markm committed rS341002: Add dependency to allow if_muge device to be only ethernet device in stripped….
Add dependency to allow if_muge device to be only ethernet device in stripped…
Nov 26 2018, 10:46 PM

Sep 20 2018

markm accepted D17252: random(4): Match enabled sources mask to build options.
Sep 20 2018, 7:31 AM

Sep 14 2018

markm accepted D17047: Fortuna: Add failpoints to simulate initial seeding conditions.
Sep 14 2018, 7:46 AM

Sep 7 2018

markm accepted D17049: random(4): Squash non-error timeout codes from tsleep(9).
Sep 7 2018, 6:08 PM
markm requested changes to D17047: Fortuna: Add failpoints to simulate initial seeding conditions.
Sep 7 2018, 6:07 PM

Sep 6 2018

markm accepted D16986: fortuna: Drop global lock to zero stack variables.
Sep 6 2018, 12:24 PM

Sep 2 2018

markm committed rD52196: Update to the key that I use..
Update to the key that I use.
Sep 2 2018, 10:09 AM

Sep 1 2018

markm added inline comments to D16986: fortuna: Drop global lock to zero stack variables.
Sep 1 2018, 7:19 PM
markm added inline comments to D16986: fortuna: Drop global lock to zero stack variables.
Sep 1 2018, 7:17 PM
markm accepted D16985: Fortuna: fix a correctness issue in reseed (fortuna_pre_read).
Sep 1 2018, 10:13 AM
markm accepted D16984: Fortuna: Fix a race to prevent reseed spamming.
Sep 1 2018, 10:10 AM
markm accepted D16983: random(4): Correct a bare zero to the appropriate enum.
Sep 1 2018, 10:07 AM
markm accepted D16982: random(4): Translate a comment requirement into a compile-time invariant.
Sep 1 2018, 10:05 AM

Aug 29 2018

markm accepted D16934: Fortuna: Clean up reseeding key material to closer match FS&K.
Aug 29 2018, 7:36 PM
markm accepted D16937: Fortuna: trivial static variable cleanup.

If it doesn't crash anything, then fine! I had stack problems at some point.

Aug 29 2018, 7:29 PM
markm accepted D16936: Fortuna: Add trivial assert to match FS&K definition.
Aug 29 2018, 7:28 PM
markm added inline comments to D16934: Fortuna: Clean up reseeding key material to closer match FS&K.
Aug 29 2018, 7:26 PM

Aug 26 2018

markm committed rS338324: Remove the Yarrow PRNG algorithm option in accordance with due notice.
Remove the Yarrow PRNG algorithm option in accordance with due notice
Aug 26 2018, 1:07 PM
markm closed D16898: Remove the Yarrow PRNG algorithm option in accordance with random(4)..

Commit r338324 closes this.

Aug 26 2018, 1:03 PM

Aug 25 2018

markm added inline comments to D16898: Remove the Yarrow PRNG algorithm option in accordance with random(4)..
Aug 25 2018, 11:02 PM
markm added inline comments to D16898: Remove the Yarrow PRNG algorithm option in accordance with random(4)..
Aug 25 2018, 10:42 PM
markm updated the diff for D16898: Remove the Yarrow PRNG algorithm option in accordance with random(4)..

Sigh. I think I have all cem@'s review comments done now.

Aug 25 2018, 10:39 PM
markm updated the diff for D16898: Remove the Yarrow PRNG algorithm option in accordance with random(4)..

Rebase to top of HEAD.

Aug 25 2018, 10:20 PM
markm added a comment to D16898: Remove the Yarrow PRNG algorithm option in accordance with random(4)..

Address cmem@'s review comments.

Aug 25 2018, 10:09 PM
markm updated the diff for D16898: Remove the Yarrow PRNG algorithm option in accordance with random(4)..

Adress some review concerns from cem@, and a few of my own while I'm here.

Aug 25 2018, 10:05 PM
markm added inline comments to D16898: Remove the Yarrow PRNG algorithm option in accordance with random(4)..
Aug 25 2018, 9:56 PM
markm added inline comments to D16898: Remove the Yarrow PRNG algorithm option in accordance with random(4)..
Aug 25 2018, 8:36 PM
markm updated the diff for D16898: Remove the Yarrow PRNG algorithm option in accordance with random(4)..

Fix documentation nit.

Aug 25 2018, 8:35 PM
markm updated the diff for D16898: Remove the Yarrow PRNG algorithm option in accordance with random(4)..

Add the "differential update" URI to the commit message.
Correct sys/conf/NOTES comment.

Aug 25 2018, 11:29 AM
markm added inline comments to rS338239: Add a special note to UPDATING for the devmatch stuff. While tested,.
Aug 25 2018, 8:35 AM
markm added inline comments to D16898: Remove the Yarrow PRNG algorithm option in accordance with random(4)..
Aug 25 2018, 8:33 AM
markm updated the summary of D16898: Remove the Yarrow PRNG algorithm option in accordance with random(4)..
Aug 25 2018, 8:30 AM
markm created D16898: Remove the Yarrow PRNG algorithm option in accordance with random(4)..
Aug 25 2018, 8:23 AM

Aug 24 2018

markm added a comment to D16873: Limit the harvest rate of "fast" entropy for random(4) so as not to overload the system..
In D16873#359829, @jmg wrote:

@delphij this is my comment copied over from https://reviews.freebsd.org/D16866?id=47165 that was unaddressed.

Aug 24 2018, 7:15 PM
markm closed D16873: Limit the harvest rate of "fast" entropy for random(4) so as not to overload the system..
Aug 24 2018, 2:54 PM
markm committed rS338293: Limit the amount of "fast" entropy. We don't need nearly as much.
Limit the amount of "fast" entropy. We don't need nearly as much
Aug 24 2018, 2:54 PM
markm committed rS338292: Fix braino of mine where the reseeds would happen far too often,.
Fix braino of mine where the reseeds would happen far too often,
Aug 24 2018, 2:54 PM
markm closed D16872: Fix excessive reseed rate in random(4)..
Aug 24 2018, 2:54 PM

Aug 23 2018

markm added a comment to D16872: Fix excessive reseed rate in random(4)..

Thanks folks! Tinderbox build going, then I'll commit.

Aug 23 2018, 7:19 PM
markm added a comment to D16873: Limit the harvest rate of "fast" entropy for random(4) so as not to overload the system..

Thanks folks! Tinderbox build going, then I'll commit.

Aug 23 2018, 7:19 PM
markm added inline comments to D16873: Limit the harvest rate of "fast" entropy for random(4) so as not to overload the system..
Aug 23 2018, 5:31 PM