Page MenuHomeFreeBSD

markm (Mark R V Murray)
User

Projects

User Details

User Since
May 14 2014, 8:42 PM (445 w, 4 d)

Recent Activity

Aug 9 2022

markm accepted D36088: arc4random(3): Reduce diff with OpenBSD..
Aug 9 2022, 8:13 AM
markm added a comment to D36088: arc4random(3): Reduce diff with OpenBSD..

Seems sensible.

Aug 9 2022, 8:12 AM

Jul 27 2022

markm accepted D35945: Style(9): Strengthen statements about not using K&R function definitions.

About time!

Jul 27 2022, 7:47 AM

Jul 13 2022

markm added a comment to D35802: random: Ingest extra fast entropy when !seeded.

I'd be happy to green-light this, but I also wonder if there is not a better way. For now, I'm at "no objection" for a merge, but with a request for further exploration of e.g. cached boot-time entropy stashing. (Could a VM do that?)

Jul 13 2022, 8:04 AM

Feb 16 2022

markm added a comment to D20780: Add support for getting early entropy from the UEFI RNG protocol.

Who is going to do the actual commit? I'm happy to do it if no-one else wants to? Whoever does it has csprng@ green-light.

Feb 16 2022, 6:16 PM · csprng, security, arm64

Feb 3 2022

markm accepted D34150: kern: harvest entropy from callouts.

Accepting in retrospect. Thanks!

Feb 3 2022, 9:08 AM

Jan 29 2022

markm accepted D20780: Add support for getting early entropy from the UEFI RNG protocol.
Jan 29 2022, 10:17 AM · csprng, security, arm64

Jan 28 2022

markm added inline comments to D20780: Add support for getting early entropy from the UEFI RNG protocol.
Jan 28 2022, 6:05 PM · csprng, security, arm64

Jan 27 2022

markm added inline comments to D20780: Add support for getting early entropy from the UEFI RNG protocol.
Jan 27 2022, 5:42 PM · csprng, security, arm64

Jan 17 2022

markm added a comment to D20780: Add support for getting early entropy from the UEFI RNG protocol.

err, I have not addressed the "isUEFIBoot" thing and the "This file needs a copyright / license at the top" thing…

Jan 17 2022, 8:42 AM · csprng, security, arm64

Jan 15 2022

markm added a comment to D20780: Add support for getting early entropy from the UEFI RNG protocol.

Is this waiting for anything else before it gets committed?

Jan 15 2022, 9:30 AM · csprng, security, arm64

Dec 15 2021

markm committed rG03a88e3de9c6: * lib/msun/Makefile b/lib/msun/Makefile: (authored by markm).
* lib/msun/Makefile b/lib/msun/Makefile:
Dec 15 2021, 6:39 PM
markm closed D33444: Improve accuracy and range of tgamma*(3).
Dec 15 2021, 6:39 PM
markm committed rG455b2ccda3df: * lib/msun/Makefile: (authored by markm).
* lib/msun/Makefile:
Dec 15 2021, 6:39 PM

Dec 14 2021

markm updated the summary of D33444: Improve accuracy and range of tgamma*(3).
Dec 14 2021, 10:29 PM
markm updated the diff for D33444: Improve accuracy and range of tgamma*(3).

I missed the move of imprecise.c to its new, temporary home in ld128.

Dec 14 2021, 10:18 PM
markm retitled D33444: Improve accuracy and range of tgamma*(3) from * lib/msun/Makefile: . Disconnect b_exp.c and b_log.c from the build. to Improve accuracy and range of tgamma*(3).
Dec 14 2021, 6:08 PM
markm added a comment to D33444: Improve accuracy and range of tgamma*(3).

This is two git commits - see the commit message.

Dec 14 2021, 6:04 PM
markm requested review of D33444: Improve accuracy and range of tgamma*(3).
Dec 14 2021, 6:03 PM

Oct 13 2021

markm added a comment to D32478: kern: random: use a spinlock for the reseed lock.

This looks safe enough to me.

Oct 13 2021, 8:00 AM

Sep 22 2021

markm accepted D32021: kern: random: reduce the rate at which we collect from fast entropy sources.
Sep 22 2021, 7:44 AM

Sep 6 2021

markm closed D31865: Fix powf()..
Sep 6 2021, 5:53 PM
markm committed rG292815eac623: Fix powf(). (authored by markm).
Fix powf().
Sep 6 2021, 5:53 PM
markm updated the summary of D31865: Fix powf()..
Sep 6 2021, 5:43 PM
markm updated the diff for D31865: Fix powf()..

Clean off file added in error.

Sep 6 2021, 5:41 PM
markm requested review of D31865: Fix powf()..
Sep 6 2021, 5:34 PM

Jul 27 2021

markm accepted D20780: Add support for getting early entropy from the UEFI RNG protocol.

Testing this on an RPi4 would be nice, but it's not a dealbreaker.

Jul 27 2021, 7:29 PM · csprng, security, arm64
markm added a project to D20780: Add support for getting early entropy from the UEFI RNG protocol: csprng.
Jul 27 2021, 7:28 PM · csprng, security, arm64
markm added a reviewer for D20780: Add support for getting early entropy from the UEFI RNG protocol: csprng.
Jul 27 2021, 7:26 PM · csprng, security, arm64
markm added inline comments to D20780: Add support for getting early entropy from the UEFI RNG protocol.
Jul 27 2021, 7:26 AM · csprng, security, arm64

Apr 11 2021

markm accepted D29634: hpt27xx: store the .o files directly in the tree.
Apr 11 2021, 7:07 PM

Apr 8 2021

markm accepted D29634: hpt27xx: store the .o files directly in the tree.

Obvious technical debt removal. Please do this.

Apr 8 2021, 7:02 AM
markm accepted D29632: hptnr: Store the .o files directly in the repo.

Obvious technical debt removal. Please do this!

Apr 8 2021, 6:59 AM

Mar 7 2021

markm committed rGcc011d871957: Remove the never-installed setchannel(1) utility. It only work(s|ed) (authored by markm).
Remove the never-installed setchannel(1) utility. It only work(s|ed)
Mar 7 2021, 12:31 AM
markm committed rGfbf8e3245201: Remove references to the now-removed bktr(4) driver. (authored by markm).
Remove references to the now-removed bktr(4) driver.
Mar 7 2021, 12:31 AM

Mar 6 2021

markm accepted D22493: Support for bcm2838 RNG.
Mar 6 2021, 10:56 AM · arm64

Jan 2 2021

markm committed rP559929: Updaye to v1.53.0. (20 years since the previous release!).
Updaye to v1.53.0. (20 years since the previous release!)
Jan 2 2021, 11:50 AM

Dec 13 2020

markm committed R9:9d213f91cef4: Correct typo. kadmin -> kadmind (authored by markm).
Correct typo. kadmin -> kadmind
Dec 13 2020, 8:16 PM
markm committed R9:4974d6ee7132: Change tha name if the primary international crypto archive from (authored by markm).
Change tha name if the primary international crypto archive from
Dec 13 2020, 8:16 PM
markm committed R9:0a39575384c7: Canonicalise and correct the ZA mirror site names and maintainers. (authored by markm).
Canonicalise and correct the ZA mirror site names and maintainers.
Dec 13 2020, 8:15 PM
markm committed R9:84976b6f7798: Add new South African mirror - ftp3. (authored by markm).
Add new South African mirror - ftp3.
Dec 13 2020, 8:15 PM
markm committed R9:2782ceb44d40: contrib: Add myself as International crypto repository manager. (authored by markm).
contrib: Add myself as International crypto repository manager.
Dec 13 2020, 8:09 PM
markm committed R9:ffe95fdaa468: Update to reflect a more accurate reality... (authored by markm).
Update to reflect a more accurate reality...
Dec 13 2020, 8:01 PM
markm committed R9:00b7404e7819: Add Gordon Greeff for his "peq" port. (authored by markm).
Add Gordon Greeff for his "peq" port.
Dec 13 2020, 7:56 PM
markm committed R9:2fb650b74f56: Update the bit about using SSH/Kerberos5 to connect to the FreeBSD (authored by markm).
Update the bit about using SSH/Kerberos5 to connect to the FreeBSD
Dec 13 2020, 7:53 PM
markm committed R9:1d36303c9d64: Update for OPIE use in CURRENT. (authored by markm).
Update for OPIE use in CURRENT.
Dec 13 2020, 7:31 PM
markm committed R9:41f37f0d8f0b: Document the FreeBSD version that has Perl 5.6.1. (authored by markm).
Document the FreeBSD version that has Perl 5.6.1.
Dec 13 2020, 7:24 PM
markm committed R9:255275af5f4b: Clarify the charter (a bit) for FreeBSD-Security. This list recently (authored by markm).
Clarify the charter (a bit) for FreeBSD-Security. This list recently
Dec 13 2020, 7:18 PM
markm committed R9:3232b2a04719: Register my desires in the donation department. (authored by markm).
Register my desires in the donation department.
Dec 13 2020, 7:17 PM
markm committed R9:e843ed424155: Document __FreeBSD_version 502105 for the extra-warnings NULL. (authored by markm).
Document __FreeBSD_version 502105 for the extra-warnings NULL.
Dec 13 2020, 6:49 PM
markm committed R9:10f5e291536d: Add to list of stuff I'm panhandling for. (authored by markm).
Add to list of stuff I'm panhandling for.
Dec 13 2020, 6:39 PM
markm committed R9:85806c3ba10e: Give Gary Jennejohn credit for his very generous donation of a (authored by markm).
Give Gary Jennejohn credit for his very generous donation of a
Dec 13 2020, 6:28 PM

Nov 28 2020

markm added a comment to D27398: Provide userland notification of gpio pin changes (aka "userland gpio interrupts")..

I'm keen on having this - a build is under way. DHYB, it may take a while.

Nov 28 2020, 5:11 PM

Oct 7 2020

markm accepted D22837: Add Fenestras X random(4) implementation.

I'm happy to see this landed in disabled form.

Oct 7 2020, 6:00 PM
markm accepted D22838: arc4random(9): Integrate with RANDOM_FENESTRASX push-reseed.

I'm happy to see this landed in disabled form.

Oct 7 2020, 5:58 PM

Sep 16 2020

markm accepted D26450: Remove APM (series of commits, but shown as one for review).
Sep 16 2020, 7:53 AM
markm added a comment to D26450: Remove APM (series of commits, but shown as one for review).

LGTM.

Sep 16 2020, 7:53 AM

Sep 1 2020

markm committed rS365028: Add a pointer to csprng@ for the CSPRNG driver. This is enforced anyway by.
Add a pointer to csprng@ for the CSPRNG driver. This is enforced anyway by
Sep 1 2020, 8:02 AM

Aug 3 2020

markm requested changes to D25916: Add prng(9) API.

I like this general idea very much! I'm a bit leery of the critical regions, but I admit that I don't understand them properly. I presume that in a PCPU environment they are fine.

Aug 3 2020, 6:31 PM

Jul 27 2020

markm accepted D25833: Remove AES-CBC ciphers from default server and client lists..
Jul 27 2020, 7:30 PM

Jul 15 2020

markm accepted D25312: Relax the rule against declaring variables in nested scopes..
Jul 15 2020, 7:49 AM

Jul 5 2020

markm accepted D25373: Fix AccessWidth and BitWidth parsing in SPCR table.

OK to close again.

Jul 5 2020, 3:56 PM · x86, arm64
markm added a comment to D25373: Fix AccessWidth and BitWidth parsing in SPCR table.

That works, thanks! I'm at latest CURRENT, no backouts, my console works and so do my PCI ethernet port.

Jul 5 2020, 3:56 PM · x86, arm64
markm added a comment to D25373: Fix AccessWidth and BitWidth parsing in SPCR table.

ECAM hacks? When are those likely to appear? :-)

Jul 5 2020, 3:10 PM · x86, arm64
markm added a comment to D25373: Fix AccessWidth and BitWidth parsing in SPCR table.

With this patch in, AND the flashe given above, I get my console back!

Jul 5 2020, 2:48 PM · x86, arm64
markm added a comment to D25373: Fix AccessWidth and BitWidth parsing in SPCR table.

Worse. Previously working console now broken. Current with this change backed out now broken.

Jul 5 2020, 2:31 PM · x86, arm64
markm added a comment to D25373: Fix AccessWidth and BitWidth parsing in SPCR table.

Trying now. In the meanwhile, is there some place where the Collected Wisdom™ of all current mcbin firmware statusses, hints, binaries etc are kept?

Jul 5 2020, 12:50 PM · x86, arm64
markm added a comment to D25373: Fix AccessWidth and BitWidth parsing in SPCR table.

Yup - my flash is a couple of months old, and a hand-rolled debug-version (not by me). The image you pointed to fails with checksum errors at boot, but it may have something to do with the way I made it. With the same MBR as the old one, I did:

Jul 5 2020, 12:21 PM · x86, arm64
markm reopened D25373: Fix AccessWidth and BitWidth parsing in SPCR table.

This change breaks my MacchiattoBin DoubleShot. I've bisected to get to commit r362574, which is this. The symptoms are a hang right at the beginning of the boot, at this point:

Jul 5 2020, 10:50 AM · x86, arm64

Jul 1 2020

markm accepted D25312: Relax the rule against declaring variables in nested scopes..

Happy with this.

Jul 1 2020, 11:20 PM

Jun 21 2020

markm added a comment to D22493: Support for bcm2838 RNG.

If a committer is needed, I'm happy to oblige, but I'll need testing time, and for that I need to build and boot. If Someone Else(™) can assure me that this works, I'll speed it up a bit.

Jun 21 2020, 9:42 AM · arm64

Jun 18 2020

markm accepted D25312: Relax the rule against declaring variables in nested scopes..
Jun 18 2020, 9:18 AM

Jun 1 2020

markm requested changes to D24989: netinet: Generate a random RSS key on boot..
Jun 1 2020, 8:14 AM · csprng, network

Mar 5 2020

markm committed rP527816: Relocate myself, after 18 years of being in the incorrect location!.
Relocate myself, after 18 years of being in the incorrect location!
Mar 5 2020, 8:47 AM

Jan 21 2020

markm accepted D23290: rand(3): Replace implementation with one backed by random(3) algorithm.
Jan 21 2020, 6:21 PM
markm accepted D23289: random(3): Abstract routines into _r versions on explicit state.
Jan 21 2020, 6:11 PM
markm accepted D23288: random(3): Abstract state into a single context object.
Jan 21 2020, 6:08 PM

Jan 12 2020

markm accepted D23130: getrandom(2): Add Linux GRND_INSECURE API flag.
Jan 12 2020, 12:21 PM

Jan 11 2020

markm added a comment to D22493: Support for bcm2838 RNG.

LGTM, modulo delphij's comments.

Jan 11 2020, 11:27 AM · arm64

Dec 29 2019

markm added a comment to D22839: random(4) fenestrasX: Push root seed version to arc4random(3).

I like the direction this is going, but I'm still reading the design papers.

Dec 29 2019, 10:38 AM
markm accepted D22946: vmgenid(4): Integrate as a random(4) source.

LGTM

Dec 29 2019, 10:27 AM

Dec 28 2019

markm accepted D22489: random(4): Make entropy source deregistration safe.

I can't find anything to object to - but my epoch-fu is a bit lacking, so I'm trusting the other reviewers here.

Dec 28 2019, 11:31 AM

Dec 25 2019

markm accepted D22512: random(4): Simplify RANDOM_LOADABLE.

I'm delighted with the amount of OS-interface and locking code that is removed!

Dec 25 2019, 12:32 PM

Dec 24 2019

markm accepted D22512: random(4): Simplify RANDOM_LOADABLE.

This is a GREAT step forward, so I'm happy to accept it as such. The objection to #undefs is stylistic/idealistic, so you may ignore it at your pleasure.

Dec 24 2019, 11:25 AM

Dec 19 2019

markm accepted D22879: random(4): Fortuna: Enable concurrent generation by default for 13.

I've been running this locally too.

Dec 19 2019, 11:54 PM
markm accepted D22878: random(4): Flip default Fortuna generator over to Chacha20.

No-brainer.

Dec 19 2019, 11:52 PM

Dec 1 2019

markm accepted D22512: random(4): Simplify RANDOM_LOADABLE.

The whole change LGTM, but please go further and remove RANDOM_LOADABLE altogether if the consensus allows!

Dec 1 2019, 10:21 AM
markm added inline comments to D22512: random(4): Simplify RANDOM_LOADABLE.
Dec 1 2019, 10:17 AM

Nov 30 2019

markm accepted D22612: Reduce disk write load in /usr/libexec/save-entropy.

LGTM

Nov 30 2019, 9:21 AM

Nov 23 2019

markm accepted D22504: Add explicit SI_SUB_EPOCH.

*LIKE*

Nov 23 2019, 9:57 AM

Nov 22 2019

markm accepted D22482: random(4): Abstract loader entropy injection.
Nov 22 2019, 8:07 AM
markm accepted D22484: random(4): Use ordinary sysctl definitions.

Shows how much I know about sysctls :-)

Nov 22 2019, 8:05 AM
markm accepted D22455: random/ivy: Provide mechanism to read independent seed values from rdrand.
Nov 22 2019, 8:03 AM
markm accepted D22485: random(4): De-export random_sources list.
Nov 22 2019, 8:00 AM
markm accepted D22490: virtio_random(4): Drop no longer needed unload kludge.
Nov 22 2019, 7:59 AM
markm accepted D22481: random(4): Remove unused definitions.
Nov 22 2019, 7:57 AM
markm accepted D22489: random(4): Make entropy source deregistration safe.
Nov 22 2019, 7:57 AM
markm added a comment to D22493: Support for bcm2838 RNG.

Please upload diff with full context.

Nov 22 2019, 7:47 AM · arm64

Nov 20 2019

markm added inline comments to D22455: random/ivy: Provide mechanism to read independent seed values from rdrand.
Nov 20 2019, 9:28 PM
markm added a comment to D22455: random/ivy: Provide mechanism to read independent seed values from rdrand.

No objection to the logic, just the user-facing wording needs to be "de-geeked" a bit! :-)

Nov 20 2019, 8:36 AM