Page MenuHomeFreeBSD

hptnr: Store the .o files directly in the repo
ClosedPublic

Authored by imp on Apr 8 2021, 3:27 AM.

Details

Summary

We no longer need to use uuencode to uuencode files in our tree. Store the .o
file directly instead. Adjust the build to cope with the new arrangement.

Note: This is one of many I plan to do. Let's hash out the right way to do this on this and then I'll do others.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

imp requested review of this revision.Apr 8 2021, 3:27 AM
imp created this revision.
imp added reviewers: markj, emaste.
sys/conf/files.x86
111

I wonder if we can just specify $M-elf.hptnr_lib.o directly?

sys/modules/hptnr/Makefile
10

Can we just do OBJS+=${MACHINE_ARCH}-elf.hptnr_lib.o?

sys/conf/files.x86
111

It's an interesting notion. However, I've not been able to make that work with config(8).
But it's worth a shot looking again.
Using the single line

+dev/hptnr/$M-elf.hptnr_lib.o   optional        htpnr

resulted in no htpbr_lib lines in the Makefile, but all the other hptnr lines were. So it's not completely straight forward.

sys/modules/hptnr/Makefile
10

${.SRCDIR} vs ${.OBJDIR} issues? I've not checked on this detail, though.

sys/conf/files.x86
111

spelling it right gets us a lot closer, though.

Ed's ideas proved to be good ideas.

imp marked an inline comment as done.Apr 8 2021, 4:57 AM

oops, didn't mean commit GENERIC

Yes, please. Remove this technical debt.

markm added a subscriber: markm.

Obvious technical debt removal. Please do this!

This revision is now accepted and ready to land.Apr 8 2021, 6:59 AM
bz requested changes to this revision.Apr 8 2021, 1:00 PM
bz added a subscriber: bz.

I may miss this but your current change request doesn't re-add the decoded i386 version?

This revision now requires changes to proceed.Apr 8 2021, 1:00 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 14 2021, 8:05 PM
This revision was automatically updated to reflect the committed changes.