Details

Reviewers

markj
emaste
markm
bz

Commits

rG5b20c5e1f8d5: hptnr: Store the .o files directly in the repo

Summary

We no longer need to use uuencode to uuencode files in our tree. Store the .o
file directly instead. Adjust the build to cope with the new arrangement.

Note: This is one of many I plan to do. Let's hash out the right way to do this on this and then I'll do others.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 38391
Build 35280: arc lint + arc unit

Event Timeline

imp requested review of this revision.Apr 8 2021, 3:27 AM

imp created this revision.

Harbormaster completed remote builds in B38390: Diff 86988.Apr 8 2021, 3:27 AM

imp edited the summary of this revision. (Show Details)Apr 8 2021, 3:28 AM

imp added reviewers: markj, emaste.

emaste added inline comments.Apr 8 2021, 3:40 AM

sys/conf/files.x86
112	I wonder if we can just specify `$M-elf.hptnr_lib.o` directly?
sys/modules/hptnr/Makefile
10	Can we just do `OBJS+=${MACHINE_ARCH}-elf.hptnr_lib.o`?

imp added inline comments.Apr 8 2021, 4:10 AM

sys/conf/files.x86
112	It's an interesting notion. However, I've not been able to make that work with config(8). But it's worth a shot looking again. Using the single line +dev/hptnr/$M-elf.hptnr_lib.o optional htpnr resulted in no htpbr_lib lines in the Makefile, but all the other hptnr lines were. So it's not completely straight forward.
sys/modules/hptnr/Makefile
10	${.SRCDIR} vs ${.OBJDIR} issues? I've not checked on this detail, though.

imp added inline comments.Apr 8 2021, 4:12 AM

sys/conf/files.x86
112	spelling it right gets us a lot closer, though.

Ed's ideas proved to be good ideas.

Harbormaster completed remote builds in B38391: Diff 86990.Apr 8 2021, 4:57 AM

imp marked an inline comment as done.Apr 8 2021, 4:57 AM

oops, didn't mean commit GENERIC

Harbormaster completed remote builds in B38392: Diff 86991.Apr 8 2021, 4:58 AM

also commit amd64 .o

Harbormaster completed remote builds in B38393: Diff 86992.Apr 8 2021, 5:02 AM

Yes, please. Remove this technical debt.

Obvious technical debt removal. Please do this!

This revision is now accepted and ready to land.Apr 8 2021, 6:59 AM

I may miss this but your current change request doesn't re-add the decoded i386 version?

This revision now requires changes to proceed.Apr 8 2021, 1:00 PM

LGTM modulo bz's point

add back i386 / rebase

Harbormaster completed remote builds in B38502: Diff 87256.Apr 11 2021, 4:48 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 14 2021, 8:05 PM

Closed by commit rG5b20c5e1f8d5: hptnr: Store the .o files directly in the repo (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG5b20c5e1f8d5: hptnr: Store the .o files directly in the repo.

hptnr: Store the .o files directly in the repo
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 86990

sys/conf/files.x86

sys/dev/hptnr/amd64-elf.hptnr_lib.o.uu

sys/dev/hptnr/i386-elf.hptnr_lib.o

sys/dev/hptnr/i386-elf.hptnr_lib.o.uu

sys/i386/conf/GENERIC

sys/modules/hptnr/Makefile

hptnr: Store the .o files directly in the repoClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 86990

sys/conf/files.x86

sys/dev/hptnr/amd64-elf.hptnr_lib.o.uu

sys/dev/hptnr/i386-elf.hptnr_lib.o

sys/dev/hptnr/i386-elf.hptnr_lib.o.uu

sys/i386/conf/GENERIC

sys/modules/hptnr/Makefile

hptnr: Store the .o files directly in the repo
ClosedPublic
Actions

Revision Contents
Changeset List