Page MenuHomeFreeBSD

amdrapl: Introduce amdrapl driver
Needs ReviewPublic

Authored by afscoelho_gmail.com on Mar 1 2026, 11:21 AM.
Tags
None
Referenced Files
F159680875: D55603.id172962.diff
Wed, Jun 17, 12:51 AM
Unknown Object (File)
Sat, Jun 6, 12:35 PM
Unknown Object (File)
Thu, Jun 4, 8:12 PM
Unknown Object (File)
Thu, Jun 4, 10:16 AM
Unknown Object (File)
Tue, Jun 2, 4:34 AM
Unknown Object (File)
Mon, Jun 1, 5:53 PM
Unknown Object (File)
Sun, May 31, 7:53 AM
Unknown Object (File)
May 15 2026, 5:58 AM

Details

Reviewers
aokblast

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 71128
Build 68011: arc lint + arc unit

Event Timeline

Quick response:

  1. also need to add to sys/modules/Makefile
  2. Do you have a plan to write a short man page?

Fix Makefile and use recursive lock to make witness happy

Quick response:

  1. also need to add to sys/modules/Makefile
  2. Do you have a plan to write a short man page?

Sure, but I am thinking about creating a uniform monitor interface for kernel sensors that can also be used by amdtemp and coretemp driver. So the sysctl may chages.

Hi @aokblast, I've found your rapl driver for amd and I'm interested in continuing the work. It's been sitting since March and I'd like to pick it up. Are you still planning to work on it, or would you be OK with me taking over? Thanks

Hi @aokblast, I've found your rapl driver for amd and I'm interested in continuing the work. It's been sitting since March and I'd like to pick it up. Are you still planning to work on it, or would you be OK with me taking over? Thanks

Hi, according to the PPR. This is all we can do for the Zen5 pre CPUs. The mailbox based features require AMD AI series CPU or Zen5 EPYC, which I am unable to test and debug. So don't hesitate to take this task.

Notice: I don't know whether we will merge this feature as RAPL has some known security flaws.

Hi @aokblast, thanks for starting amdrapl!. I've been working on top of this driver and would like to carry the review forward to land. Would you be willing to reassign this revision to me, or add me so I can arc update it? Happy to keep you as co-author on the commit (I've added a Co-authored-by: trailer crediting you). I did work that covers on-demand energy sampling and socket-aware package mapping for example

Hi @aokblast, just a heads-up that I've taken ownership of this revision to carry it forward. Thanks for laying the groundwork with the initial driver; I'll credit you with a Co-authored-by: trailer on the commit. I'll be pushing an updated diff shortly. Feel free to stay subscribed, your feedback is welcome!