Page MenuHomeFreeBSD

alfredo (Alfredo Dal'Ava Júnior)
User

Projects

User Details

User Since
Dec 7 2018, 3:31 PM (137 w, 2 h)

Recent Activity

Fri, Jun 25

alfredo abandoned D30793: powerpc64, powerpc64le: ZFS support as kernel builtin.

After discussion with @imp , we decided to try the "reroot" approach instead. It appears to be generic solution for other modules as well, and can be used on other platforms.
A new review entry will be created when it's ready for review.

Fri, Jun 25, 11:47 AM · PowerPC

Jun 17 2021

alfredo requested changes to D30797: powerpc64: make radix with superpages default.

For some reason this breaks the boot with VGA console on Blackbird.
I'm using D30626 locally, but reverted it as well. With D30626 reverted and adding kernel parameter 'hw.ofwfb.physaddr=0x000600c280000000' the kernel hangs as well with no output.

Jun 17 2021, 7:58 PM · PowerPC

Jun 16 2021

alfredo requested review of D30793: powerpc64, powerpc64le: ZFS support as kernel builtin.
Jun 16 2021, 9:21 PM · PowerPC

Jun 11 2021

alfredo updated the diff for D30626: ofwfb: fix vga/hdmi console during boot on powerpc64.
Jun 11 2021, 2:24 AM · PowerPC

Jun 3 2021

alfredo requested review of D30626: ofwfb: fix vga/hdmi console during boot on powerpc64.
Jun 3 2021, 7:00 AM · PowerPC

May 7 2021

alfredo committed R10:fb53b42e36a9: virtio-modern: fix PCI common read/write functions on big endian targets (authored by alfredo).
virtio-modern: fix PCI common read/write functions on big endian targets
May 7 2021, 2:55 AM
alfredo closed D28947: [POWERPC] Switch endian of common dev information.
May 7 2021, 2:55 AM · PowerPC
alfredo committed R10:7d45bf699dc6: mprutil: add big endian support (authored by alfredo).
mprutil: add big endian support
May 7 2021, 2:39 AM
alfredo committed R10:dca829138ca5: opal_console: fix serial console output corruption on powerpc64 (authored by alfredo).
opal_console: fix serial console output corruption on powerpc64
May 7 2021, 2:39 AM
alfredo committed R10:8d5898458818: powerpc: implement bus_map_resource and bus_unmap_resource DEVMETHODs (authored by alfredo).
powerpc: implement bus_map_resource and bus_unmap_resource DEVMETHODs
May 7 2021, 2:39 AM

May 4 2021

alfredo accepted D22824: msun fixes for SPE.

I don't have any SPE board to try it. Anyway it LGTM

May 4 2021, 8:24 PM

Apr 20 2021

alfredo closed D26040: Fix mprutil endianness.
Apr 20 2021, 7:23 PM · PowerPC
alfredo committed R10:fc9780fd41e7: mprutil: add big endian support (authored by alfredo).
mprutil: add big endian support
Apr 20 2021, 7:23 PM

Apr 16 2021

alfredo committed R10:b8bc6b7954e2: opal_console: fix serial console output corruption on powerpc64 (authored by alfredo).
opal_console: fix serial console output corruption on powerpc64
Apr 16 2021, 8:11 PM
alfredo closed D29063: [POWERPC] opal_console: fix serial console output corruption.
Apr 16 2021, 8:10 PM · PowerPC
alfredo updated the diff for D29063: [POWERPC] opal_console: fix serial console output corruption.

Break instead of return, keeping it consistent with previous code

Apr 16 2021, 12:05 PM · PowerPC

Apr 8 2021

alfredo added inline comments to D29063: [POWERPC] opal_console: fix serial console output corruption.
Apr 8 2021, 8:36 PM · PowerPC
alfredo updated the diff for D29063: [POWERPC] opal_console: fix serial console output corruption.

Update with reviewer comments
retested

Apr 8 2021, 8:36 PM · PowerPC

Mar 30 2021

alfredo accepted D28947: [POWERPC] Switch endian of common dev information.

Thanks Leonardo. I've being testing this patch, it looks good to me.

Mar 30 2021, 8:29 PM · PowerPC

Mar 29 2021

alfredo committed R10:befb0817bd5e: powerpc: implement bus_map_resource and bus_unmap_resource DEVMETHODs (authored by alfredo).
powerpc: implement bus_map_resource and bus_unmap_resource DEVMETHODs
Mar 29 2021, 8:41 PM
alfredo closed D28012: [POWERPC] add bus_map_resource and bus_unmap_resource DEVMETHODs.
Mar 29 2021, 8:41 PM · PowerPC

Mar 24 2021

alfredo updated the diff for D28012: [POWERPC] add bus_map_resource and bus_unmap_resource DEVMETHODs.

fix ident

Mar 24 2021, 9:04 PM · PowerPC

Mar 9 2021

alfredo committed R10:c80a1c1072d1: mpr: big-endian support (authored by alfredo).
mpr: big-endian support
Mar 9 2021, 9:35 PM
alfredo committed R10:2954aedb8e5c: [PowerPC64] add mpr to GENERIC64 and GENERIC64LE (authored by alfredo).
[PowerPC64] add mpr to GENERIC64 and GENERIC64LE
Mar 9 2021, 9:35 PM

Mar 8 2021

alfredo added a project to D28947: [POWERPC] Switch endian of common dev information: PowerPC.
Mar 8 2021, 10:01 PM · PowerPC

Mar 4 2021

alfredo edited reviewers for D28012: [POWERPC] add bus_map_resource and bus_unmap_resource DEVMETHODs, added: bryanv; removed: bdrewery.
Mar 4 2021, 6:24 PM · PowerPC
alfredo accepted D29000: ofwfb: export RGB offsets with FBIO_GETRGBOFFS.

LGTM

Mar 4 2021, 5:52 PM · PowerPC
alfredo updated the diff for D29063: [POWERPC] opal_console: fix serial console output corruption.

revert an unused change

Mar 4 2021, 4:32 PM · PowerPC
alfredo requested review of D29063: [POWERPC] opal_console: fix serial console output corruption.
Mar 4 2021, 4:29 PM · PowerPC

Mar 2 2021

alfredo committed R10:71900a794da0: mpr: big-endian support (authored by alfredo).
mpr: big-endian support
Mar 2 2021, 10:23 PM
alfredo committed R10:231633a2e900: [PowerPC64] add mpr to GENERIC64 and GENERIC64LE (authored by alfredo).
[PowerPC64] add mpr to GENERIC64 and GENERIC64LE
Mar 2 2021, 10:23 PM
alfredo closed D25785: Fix mpr driver endianness.
Mar 2 2021, 10:23 PM · PowerPC
alfredo accepted D26040: Fix mprutil endianness.

Also reviewed by Sreekanth Reddy (by e-mail)

Mar 2 2021, 11:03 AM · PowerPC
alfredo accepted D25785: Fix mpr driver endianness.

Also reviewed by Sreekanth Reddy (by e-mail)

Mar 2 2021, 11:02 AM · PowerPC

Feb 23 2021

alfredo updated the summary of D28012: [POWERPC] add bus_map_resource and bus_unmap_resource DEVMETHODs.
Feb 23 2021, 9:18 PM · PowerPC
alfredo updated the diff for D28012: [POWERPC] add bus_map_resource and bus_unmap_resource DEVMETHODs.

bus tag now match platform endian

Feb 23 2021, 9:16 PM · PowerPC
alfredo committed R10:07656628fdbc: ofwfb: fix incorrect colors on powerpc* and add new tunable parameters (authored by alfredo).
ofwfb: fix incorrect colors on powerpc* and add new tunable parameters
Feb 23 2021, 9:09 PM

Feb 22 2021

alfredo added a comment to D28776: powerpc/powerpc64: Enforce natural alignment in bcopy.
  • improved formatting
  • solution to the problem outlined by luporl

The alignment problem is solved, but this patch makes bcopy performance go down by a factor of 10. I think a third version of the code should be considered, restricting this patch only to POWER7 CPUs.

Feb 22 2021, 3:44 PM · PowerPC

Feb 19 2021

alfredo committed R10:a78bb831a17f: fbio: Use appropriate types for the physical and virtual framebuffer address (authored by alfredo).
fbio: Use appropriate types for the physical and virtual framebuffer address
Feb 19 2021, 8:56 PM
alfredo committed R10:50b7c1f530f1: ofwfb: fix incorrect colors on powerpc* and add new tunable parameters (authored by alfredo).
ofwfb: fix incorrect colors on powerpc* and add new tunable parameters
Feb 19 2021, 7:54 PM
alfredo closed D28604: ofwfb: fix incorrect colors on powerpc*, add new tunable parameters.
Feb 19 2021, 7:54 PM · PowerPC
alfredo added a comment to D28604: ofwfb: fix incorrect colors on powerpc*, add new tunable parameters.

Should be good for HEAD.

However, the fbio change should be tested on i386 PAE to make sure it doesn't cause binary incompatibility. If it does, we won't be able to MFC it as is.

Feb 19 2021, 2:15 AM · PowerPC

Feb 18 2021

alfredo committed R10:c3942b4284d1: [POWERPC64LE] add mrsas to GENERIC64LE (authored by alfredo).
[POWERPC64LE] add mrsas to GENERIC64LE
Feb 18 2021, 9:51 PM
alfredo committed R10:f49177221ace: mrsas: update man page (authored by alfredo).
mrsas: update man page
Feb 18 2021, 9:51 PM

Feb 16 2021

alfredo added a comment to D23809: [PowerPC] Fix sensor attachment on PowerBook5,3.

1 - right fan producing an annoying noise, with rear right exhaust RPM peaking at 640 RPM for one second and going down to zero for another 7 seconds, repeating it in a cycle

Feb 16 2021, 5:00 AM · PowerPC

Feb 15 2021

alfredo added a comment to D16653: libfdt: Update to 1.5.0.

Version 1.6.0 was released some time ago with some improvements for FreeBSD: https://git.kernel.org/pub/scm/utils/dtc/dtc.git/tag/?h=v1.6.0

Feb 15 2021, 11:13 PM
alfredo committed R10:928cbdbe3910: [POWERPC64LE] add mrsas to GENERIC64LE (authored by alfredo).
[POWERPC64LE] add mrsas to GENERIC64LE
Feb 15 2021, 2:38 PM
alfredo committed R10:467f2b64dbc3: mrsas: update man page (authored by alfredo).
mrsas: update man page
Feb 15 2021, 2:38 PM

Feb 12 2021

alfredo updated the summary of D28604: ofwfb: fix incorrect colors on powerpc*, add new tunable parameters.
Feb 12 2021, 3:06 PM · PowerPC
alfredo added a comment to D28604: ofwfb: fix incorrect colors on powerpc*, add new tunable parameters.

Also, double checked on an ATI-based powerbook g4 for comparison.

Feb 12 2021, 2:40 PM · PowerPC
alfredo updated the diff for D28604: ofwfb: fix incorrect colors on powerpc*, add new tunable parameters.

fix missing braces on powerpc64le

Feb 12 2021, 2:38 PM · PowerPC
alfredo requested review of D28604: ofwfb: fix incorrect colors on powerpc*, add new tunable parameters.
Feb 12 2021, 12:48 AM · PowerPC

Feb 9 2021

alfredo added a comment to D26040: Fix mprutil endianness.

@afscoelho_gmail.com, would you mind adding TODO section in usr.sbin/mpsutil/mpsutil.8 regarding flash operations not working on BE (timeout) ?
You can use D28475 as reference. It can be in a different review linked to this one (child revision).

Feb 9 2021, 1:35 PM · PowerPC
alfredo added a reviewer for D26040: Fix mprutil endianness: scottl.
Feb 9 2021, 1:29 PM · PowerPC
alfredo accepted D26040: Fix mprutil endianness.

Looks good to me. @scottl , would you like to take a look on this patch as well?

Feb 9 2021, 1:29 PM · PowerPC

Feb 5 2021

alfredo committed R10:eaffd270d872: [POWERPC64LE] add mrsas to GENERIC64LE (authored by alfredo).
[POWERPC64LE] add mrsas to GENERIC64LE
Feb 5 2021, 7:51 PM
alfredo closed D28475: mrsas: update man file and add driver to powerpc64le/GENERIC64LE.
Feb 5 2021, 7:51 PM · PowerPC
alfredo committed R10:20e1817f9a68: mrsas: update man page (authored by alfredo).
mrsas: update man page
Feb 5 2021, 7:51 PM
alfredo committed R10:b94f25eb626f: mrsas: unbreak i386 build (authored by alfredo).
mrsas: unbreak i386 build
Feb 5 2021, 7:12 PM
alfredo committed R10:6bf9668d9d02: mrsas: unbreak i386 build (authored by alfredo).
mrsas: unbreak i386 build
Feb 5 2021, 4:53 PM
alfredo committed R10:59fffbcf46ba: mrsas: unbreak i386 build (authored by alfredo).
mrsas: unbreak i386 build
Feb 5 2021, 3:56 PM
alfredo closed D28494: mrsas: unbreak i386 build.
Feb 5 2021, 3:56 PM
alfredo updated the test plan for D28494: mrsas: unbreak i386 build.
Feb 5 2021, 3:34 PM
alfredo updated the diff for D28494: mrsas: unbreak i386 build.

use just htole64

Feb 5 2021, 3:31 PM
alfredo updated the diff for D28494: mrsas: unbreak i386 build.

Book-E powerpc and i386 with PAE have a 64 bit bus_addr_t

Feb 5 2021, 1:38 PM
alfredo requested review of D28494: mrsas: unbreak i386 build.
Feb 5 2021, 12:34 PM

Feb 4 2021

alfredo requested review of D28475: mrsas: update man file and add driver to powerpc64le/GENERIC64LE.
Feb 4 2021, 3:26 AM · PowerPC
alfredo committed R10:37fed6c86003: [POWERPC64BE] add mrsas driver to GENERIC64 (authored by alfredo).
[POWERPC64BE] add mrsas driver to GENERIC64
Feb 4 2021, 3:01 AM
alfredo committed R10:d0982de778a6: [POWERPC64BE] mrsas: add big-endian support (authored by alfredo).
[POWERPC64BE] mrsas: add big-endian support
Feb 4 2021, 3:01 AM

Feb 3 2021

alfredo committed R10:9fac05ba79a4: [POWERPC64BE] add mrsas driver to GENERIC64 (authored by alfredo).
[POWERPC64BE] add mrsas driver to GENERIC64
Feb 3 2021, 10:09 PM
alfredo committed R10:e34a057ca6eb: [POWERPC64BE] mrsas: add big-endian support (authored by alfredo).
[POWERPC64BE] mrsas: add big-endian support
Feb 3 2021, 10:09 PM
alfredo closed D26531: mrsas: Add big-endian support.
Feb 3 2021, 10:09 PM · PowerPC

Feb 2 2021

alfredo added a comment to D26933: virtio_pci: Use the table BAR and PBA BAR from MSI-X cap.

can we get it committed and merge before 13.0 release? This patch will support the FreeBSD operating system running on alibabacloud's VM. And need another patch: D26915

Feb 2 2021, 8:54 PM

Jan 22 2021

alfredo accepted D26531: mrsas: Add big-endian support.

looks good to me

Jan 22 2021, 2:35 PM · PowerPC

Jan 21 2021

alfredo accepted D28046: gdb: only return signal values for powerpc's gdb_cpu_signal().

@mhorne looks good to me. I also look on other platforms and your patch makes sense.

Jan 21 2021, 8:43 PM

Jan 6 2021

alfredo added inline comments to D28012: [POWERPC] add bus_map_resource and bus_unmap_resource DEVMETHODs.
Jan 6 2021, 11:37 PM · PowerPC
alfredo requested review of D28012: [POWERPC] add bus_map_resource and bus_unmap_resource DEVMETHODs.
Jan 6 2021, 11:12 PM · PowerPC

Dec 30 2020

alfredo committed R10:4f250d9436af: [POWERPC64LE] enable IPMI using OPAL bus (authored by alfredo).
[POWERPC64LE] enable IPMI using OPAL bus
Dec 30 2020, 10:57 PM
alfredo closed D27443: [POWERPC64LE] enable IPMI using OPAL bus.
Dec 30 2020, 10:57 PM · PowerPC
alfredo updated the diff for D27443: [POWERPC64LE] enable IPMI using OPAL bus.

short version of comparison

Dec 30 2020, 10:50 PM · PowerPC
alfredo committed R10:6d2254bc922b: [POWERPC64LE] fix sysctl dev.opal_sensor.* on little-endian kernel (authored by alfredo).
[POWERPC64LE] fix sysctl dev.opal_sensor.* on little-endian kernel
Dec 30 2020, 10:10 PM

Dec 22 2020

alfredo updated the diff for D27365: [POWERPC64LE] fix sysctl dev.opal_sensor.* on little-endian kernel.

remove extra blank line

Dec 22 2020, 2:57 PM · PowerPC
alfredo updated the diff for D27365: [POWERPC64LE] fix sysctl dev.opal_sensor.* on little-endian kernel.

tries to have more meaningful error messages

Dec 22 2020, 2:55 PM · PowerPC

Dec 15 2020

alfredo added a reviewer for D26933: virtio_pci: Use the table BAR and PBA BAR from MSI-X cap: bryanv.
Dec 15 2020, 3:24 PM
alfredo accepted D26933: virtio_pci: Use the table BAR and PBA BAR from MSI-X cap.

I tested this patch on powerpc64 with virtio-legacy and it looks good to me.

Dec 15 2020, 3:24 PM

Dec 12 2020

alfredo accepted D27453: [PowerPC] Floating-point exception trap followup.
Dec 12 2020, 11:49 PM · PowerPC

Dec 3 2020

alfredo added inline comments to D27453: [PowerPC] Floating-point exception trap followup.
Dec 3 2020, 11:09 AM · PowerPC

Dec 2 2020

alfredo added a reviewer for D27443: [POWERPC64LE] enable IPMI using OPAL bus: jhibbits.
Dec 2 2020, 1:07 AM · PowerPC
alfredo requested review of D27443: [POWERPC64LE] enable IPMI using OPAL bus.
Dec 2 2020, 1:04 AM · PowerPC

Nov 26 2020

alfredo added inline comments to D19237: Fix TARGET_TRIPLE assembly and retrieve OS version automatically.
Nov 26 2020, 7:16 PM · PowerPC

Nov 25 2020

alfredo added reviewers for D19237: Fix TARGET_TRIPLE assembly and retrieve OS version automatically: arichardson, brooks.
Nov 25 2020, 9:19 PM · PowerPC

Nov 24 2020

alfredo added inline comments to D27365: [POWERPC64LE] fix sysctl dev.opal_sensor.* on little-endian kernel.
Nov 24 2020, 11:36 PM · PowerPC
alfredo requested review of D27365: [POWERPC64LE] fix sysctl dev.opal_sensor.* on little-endian kernel.
Nov 24 2020, 11:26 PM · PowerPC

Nov 20 2020

alfredo closed D27257: [POWERPC] set default kernel config for powerpc64le and powerpcspe variants.
Nov 20 2020, 7:09 PM · PowerPC
alfredo closed D27294: [POWERPC] print uprintf_signal 'type' field in hex.
Nov 20 2020, 7:09 PM · PowerPC
alfredo committed rS367908: [POWERPC] print uprintf_signal 'type' field in hex.
[POWERPC] print uprintf_signal 'type' field in hex
Nov 20 2020, 7:09 PM
alfredo committed rS367907: [POWERPC64LE,POWEPCSPE] set default kernel config for powerpc64le and….
[POWERPC64LE,POWEPCSPE] set default kernel config for powerpc64le and…
Nov 20 2020, 7:09 PM
alfredo requested review of D27294: [POWERPC] print uprintf_signal 'type' field in hex.
Nov 20 2020, 6:35 PM · PowerPC
alfredo added a comment to D27257: [POWERPC] set default kernel config for powerpc64le and powerpcspe variants.

@emaste do you also agree with latest change? (powerpcspe default config)

Nov 20 2020, 2:45 PM · PowerPC

Nov 18 2020

alfredo closed D27202: msun tests: use standard floating-point exception flags on lrint and fenv tests.
Nov 18 2020, 7:23 PM · PowerPC