Page MenuHomeFreeBSD

alfredo (Alfredo Dal'Ava Júnior)
User

Projects

User Details

User Since
Dec 7 2018, 3:31 PM (69 w, 3 d)

Recent Activity

Thu, Mar 26

alfredo committed rS359342: msun: swap words order instead of bits order on BIG ENDIAN.
msun: swap words order instead of bits order on BIG ENDIAN
Thu, Mar 26, 6:51 PM
alfredo closed D23926: Swap words order instead of bits order on BIG ENDIAN.
Thu, Mar 26, 6:51 PM

Wed, Mar 25

alfredo committed rS359309: so_reuseport_lb_test: correct setsockopt parameter size.
so_reuseport_lb_test: correct setsockopt parameter size
Wed, Mar 25, 8:20 PM
alfredo closed D24164: so_reuseport_lb_test: Changing the variable type of the optval parameter of the setsockopt function.
Wed, Mar 25, 8:20 PM · tests, PowerPC
alfredo accepted D23926: Swap words order instead of bits order on BIG ENDIAN.

LGTM

Wed, Mar 25, 7:44 PM

Tue, Mar 24

alfredo accepted D24164: so_reuseport_lb_test: Changing the variable type of the optval parameter of the setsockopt function.

Looks good to me

Tue, Mar 24, 2:24 PM · tests, PowerPC

Fri, Mar 20

alfredo added inline comments to D24102: Set moea64_bpvo_pool_size based on physical memory.
Fri, Mar 20, 2:41 PM · PowerPC
alfredo committed rS359160: [PowerPC] fix panic reading /dev/kmem on !DMAP machines.
[PowerPC] fix panic reading /dev/kmem on !DMAP machines
Fri, Mar 20, 11:51 AM
alfredo closed D23776: [PowerPC] fix panic reading /dev/kmem on !DMAP machines.
Fri, Mar 20, 11:51 AM · PowerPC

Mon, Mar 16

alfredo closed D24005: fix atp mouse driver attachment on powermac g4.
Mon, Mar 16, 1:53 PM · PowerPC
alfredo committed rS359015: atp: fix mouse attachment on PowerBook5,6 (G4).
atp: fix mouse attachment on PowerBook5,6 (G4)
Mon, Mar 16, 1:53 PM

Fri, Mar 13

alfredo added a comment to D23783: lib/libkvm: add kvm_read test.

Hi @ngie are you ok with the new "kvm_read_test" test?
I tested it on powerpc64 and amd64

Fri, Mar 13, 12:46 PM · PowerPC

Thu, Mar 12

alfredo updated the diff for D23776: [PowerPC] fix panic reading /dev/kmem on !DMAP machines.

Adresses reviewers suggestions.

Thu, Mar 12, 4:01 PM · PowerPC

Tue, Mar 10

alfredo added a comment to D24005: fix atp mouse driver attachment on powermac g4.

Tue, Mar 10, 1:35 AM · PowerPC

Mon, Mar 9

alfredo added a comment to D24005: fix atp mouse driver attachment on powermac g4.

Looks good to me. Can you provide dmesg?

Mon, Mar 9, 1:57 PM · PowerPC
alfredo created D24005: fix atp mouse driver attachment on powermac g4.
Mon, Mar 9, 11:37 AM · PowerPC

Mar 6 2020

alfredo accepted D23974: Enable ixl device on PowerPC64.

Looks good to me. Nice job fixing it in powerpc64!

Mar 6 2020, 5:17 PM · PowerPC

Mar 5 2020

alfredo accepted D23969: powerpc/powerpc64: Enforce natural alignment in memcpy.

I tested this patch with D23958/r358672 reverted. This solution makes optimized memcpy/bcopy code viable again on POWER7. It slows down some cases but it's a gain in overal, I think.

Mar 5 2020, 8:09 PM
alfredo committed rS358672: [PowerPC64] restrict memcpy/bcopy optimization to POWER ISA >=V2.07.
[PowerPC64] restrict memcpy/bcopy optimization to POWER ISA >=V2.07
Mar 5 2020, 2:13 PM
alfredo closed D23958: [PowerPC64] restrict memcpy/bcopy optimization to POWER ISA >=V2.07.
Mar 5 2020, 2:13 PM · PowerPC
alfredo added inline comments to D23776: [PowerPC] fix panic reading /dev/kmem on !DMAP machines.
Mar 5 2020, 1:04 PM · PowerPC
alfredo committed rS358670: [PowerPC64] fix uma_small_free panic.
[PowerPC64] fix uma_small_free panic
Mar 5 2020, 12:24 PM
alfredo closed D23931: [PowerPC64] fix uma_small_free panic.
Mar 5 2020, 12:24 PM · PowerPC

Mar 4 2020

alfredo updated the diff for D23958: [PowerPC64] restrict memcpy/bcopy optimization to POWER ISA >=V2.07.

Added code comments

Mar 4 2020, 5:54 PM · PowerPC
alfredo created D23958: [PowerPC64] restrict memcpy/bcopy optimization to POWER ISA >=V2.07.
Mar 4 2020, 5:50 PM · PowerPC
alfredo added a comment to D23931: [PowerPC64] fix uma_small_free panic.

System was running under load with latest change for almost 13 hours. Everything seems good.

Mar 4 2020, 2:15 PM · PowerPC
alfredo updated the diff for D23931: [PowerPC64] fix uma_small_free panic.

replaced pmap_extract by pmap_kextract

Mar 4 2020, 2:13 PM · PowerPC
alfredo added a comment to D23809: [PowerPC] Fix sensor attachment on PowerBook5,3.

I tried this patch on Powerbook5,6 with hwsensor-params-version=00 00 00 01 and didn't notice difference. With or without the patch I see the following behavior:

Mar 4 2020, 2:59 AM · PowerPC

Mar 2 2020

alfredo created D23931: [PowerPC64] fix uma_small_free panic.
Mar 2 2020, 9:37 PM · PowerPC

Feb 28 2020

alfredo updated the diff for D23776: [PowerPC] fix panic reading /dev/kmem on !DMAP machines.

updated to match behavior of amd64/arm64 when handling an error.

Feb 28 2020, 7:07 PM · PowerPC

Feb 27 2020

alfredo updated the diff for D23783: lib/libkvm: add kvm_read test.
Feb 27 2020, 7:15 PM · PowerPC
alfredo added a comment to D23783: lib/libkvm: add kvm_read test.
In D23783#523422, @ngie wrote:

One thing that isn't clear is why this sanity check is needed. Is this being specifically for platform integration issue with PowerPC64, or is there another better reason for why this needs to be done given the API? If for the latter reason and the item is well-documented, please add it. If not, this doesn't seem to serve much value and might be better implemented as a platform-specific regression test.
Please test this on amd64 as well as a sanity check, second.

Feb 27 2020, 12:11 PM · PowerPC

Feb 21 2020

alfredo updated the diff for D23776: [PowerPC] fix panic reading /dev/kmem on !DMAP machines.

test case improvement moved to D23783

Feb 21 2020, 4:41 PM · PowerPC
alfredo created D23783: lib/libkvm: add kvm_read test.
Feb 21 2020, 4:38 PM · PowerPC

Feb 20 2020

alfredo added reviewers for D23776: [PowerPC] fix panic reading /dev/kmem on !DMAP machines: nwhitehorn, jhb.
Feb 20 2020, 8:09 PM · PowerPC
alfredo added a reviewer for D23776: [PowerPC] fix panic reading /dev/kmem on !DMAP machines: bdragon.
Feb 20 2020, 7:38 PM · PowerPC
alfredo added reviewers for D23776: [PowerPC] fix panic reading /dev/kmem on !DMAP machines: jhibbits, luporl.
Feb 20 2020, 7:34 PM · PowerPC
alfredo created D23776: [PowerPC] fix panic reading /dev/kmem on !DMAP machines.
Feb 20 2020, 7:33 PM · PowerPC

Feb 7 2020

lwhsu renamed alfredo from alfredo.junior_eldorado.org.br to alfredo.
Feb 7 2020, 6:19 AM

Feb 3 2020

alfredo accepted D23401: Make access to VirtIO configuration with proper endianness on big endian platforms.
Feb 3 2020, 11:26 AM · PowerPC

Jan 30 2020

alfredo added a comment to D23401: Make access to VirtIO configuration with proper endianness on big endian platforms.

nice job @afscoelho_gmail.com !
I just tried your patch in a image uploaded to a POWER8 instance at https://openpower.ic.unicamp.br/minicloud/ and it worked out of the box.
Please check my comment on the diff.

Jan 30 2020, 5:00 PM · PowerPC

Jan 21 2020

alfredo updated the diff for D19237: Fix TARGET_TRIPLE assembly and retrieve OS version automatically.

Updated patch to latest HEAD (thanks to @bdragon)

Jan 21 2020, 8:23 PM · PowerPC

Jan 17 2020

alfredo created D23233: [PowerPC64] fix crash when using machdep.moea64_bpvo_pool_size tunable.
Jan 17 2020, 2:03 PM · PowerPC

Jan 8 2020

alfredo updated the summary of D22833: [PowerPC64] Enable virtio drivers.
Jan 8 2020, 6:06 PM · PowerPC

Dec 17 2019

alfredo added inline comments to D20261: [PowerPC64] Use ld.bfd to build LIB32 and STAND - when using llvm.
Dec 17 2019, 8:50 PM · PowerPC
alfredo added inline comments to D20261: [PowerPC64] Use ld.bfd to build LIB32 and STAND - when using llvm.
Dec 17 2019, 8:47 PM · PowerPC
alfredo updated the diff for D20261: [PowerPC64] Use ld.bfd to build LIB32 and STAND - when using llvm.

add more comments

Dec 17 2019, 8:46 PM · PowerPC
alfredo requested review of D20383: [PowerPC64] starting from FreeBSD 13.0, default 64-bit ELF ABI is V2 (ELFv2).

Back to review as no changes planned

Dec 17 2019, 3:55 PM · PowerPC

Dec 16 2019

alfredo updated the summary of D20261: [PowerPC64] Use ld.bfd to build LIB32 and STAND - when using llvm.
Dec 16 2019, 7:17 PM · PowerPC
alfredo updated the diff for D22833: [PowerPC64] Enable virtio drivers.

enable man pages as suggested by @bdragon

Dec 16 2019, 7:08 PM · PowerPC
alfredo updated the diff for D22833: [PowerPC64] Enable virtio drivers.

build virtio modules on all powerpc platforms

Dec 16 2019, 6:06 PM · PowerPC
alfredo added a reviewer for D22833: [PowerPC64] Enable virtio drivers: PowerPC.
Dec 16 2019, 1:36 PM · PowerPC
alfredo added inline comments to D20261: [PowerPC64] Use ld.bfd to build LIB32 and STAND - when using llvm.
Dec 16 2019, 12:48 PM · PowerPC
alfredo created D22833: [PowerPC64] Enable virtio drivers.
Dec 16 2019, 12:37 PM · PowerPC
alfredo added inline comments to D22810: devel/llvm90 fix PowerPC64 ABI detection.
Dec 16 2019, 12:20 PM · PowerPC

Dec 14 2019

alfredo created D22810: devel/llvm90 fix PowerPC64 ABI detection.
Dec 14 2019, 12:34 AM · PowerPC
alfredo updated the diff for D20261: [PowerPC64] Use ld.bfd to build LIB32 and STAND - when using llvm.

Simplified the code inspired by @imp inputs.

Dec 14 2019, 12:22 AM · PowerPC

Dec 13 2019

alfredo updated the diff for D22549: [PowerPC] enable atomic.c in compiler_rt and do not check and forces lock/lock_free decisions in compiled time.

Removed OS check and fixed comment

Dec 13 2019, 7:34 PM · PowerPC
alfredo updated the diff for D22688: multimedia/x264 - use base compiler on PowerPC64/ELFv2.

reverted PGO part

Dec 13 2019, 5:27 PM · PowerPC
alfredo added a comment to D22688: multimedia/x264 - use base compiler on PowerPC64/ELFv2.

Also, PGO options seems to require GCC. Why do you remove USE_GCC=any there? Have you verified it's not needed?

Dec 13 2019, 5:23 PM · PowerPC

Dec 12 2019

alfredo added inline comments to D22549: [PowerPC] enable atomic.c in compiler_rt and do not check and forces lock/lock_free decisions in compiled time.
Dec 12 2019, 8:06 PM · PowerPC
alfredo updated the diff for D22688: multimedia/x264 - use base compiler on PowerPC64/ELFv2.

remove explicit GCC dependency and add "modern compiler dependency" instead (compiler:c11)

Dec 12 2019, 8:03 PM · PowerPC
alfredo updated the diff for D20378: [PowerPC64] LLVM as default toolchain for PowerPC and PowerPC64.

rebased to current HEAD

Dec 12 2019, 6:47 PM · PowerPC
alfredo updated the diff for D22688: multimedia/x264 - use base compiler on PowerPC64/ELFv2.

check compiler type

Dec 12 2019, 3:13 PM · PowerPC

Dec 5 2019

alfredo added a comment to D22687: lang/ruby26 - Use base compiler on PowerPC64/ELFv2.

Correction - since powerpc switches to LLVM as well, it should not use GCC when LLVM is available.

Dec 5 2019, 2:26 PM · PowerPC
alfredo created D22688: multimedia/x264 - use base compiler on PowerPC64/ELFv2.
Dec 5 2019, 12:50 PM · PowerPC
alfredo created D22687: lang/ruby26 - Use base compiler on PowerPC64/ELFv2.
Dec 5 2019, 12:07 PM · PowerPC

Dec 3 2019

alfredo added a member for PowerPC: alfredo.
Dec 3 2019, 10:09 PM
alfredo added a project to D20261: [PowerPC64] Use ld.bfd to build LIB32 and STAND - when using llvm: PowerPC.
Dec 3 2019, 10:08 PM · PowerPC
alfredo added a project to D20378: [PowerPC64] LLVM as default toolchain for PowerPC and PowerPC64: PowerPC.
Dec 3 2019, 10:08 PM · PowerPC
alfredo added a project to D21800: fix emulation name passed to linker when cross compiling: PowerPC.
Dec 3 2019, 10:05 PM · PowerPC
alfredo added a project to D22549: [PowerPC] enable atomic.c in compiler_rt and do not check and forces lock/lock_free decisions in compiled time: PowerPC.
Dec 3 2019, 10:04 PM · PowerPC
alfredo added a project to D19237: Fix TARGET_TRIPLE assembly and retrieve OS version automatically: PowerPC.
Dec 3 2019, 10:04 PM · PowerPC
alfredo added a project to D22634: rtld: do not try to mmap a zero-sized PT_LOAD: PowerPC.
Dec 3 2019, 10:04 PM · PowerPC
alfredo added a project to D20383: [PowerPC64] starting from FreeBSD 13.0, default 64-bit ELF ABI is V2 (ELFv2): PowerPC.
Dec 3 2019, 10:03 PM · PowerPC
alfredo removed a reviewer for D20383: [PowerPC64] starting from FreeBSD 13.0, default 64-bit ELF ABI is V2 (ELFv2): PowerPC.
Dec 3 2019, 10:02 PM · PowerPC
alfredo added a reviewer for D20383: [PowerPC64] starting from FreeBSD 13.0, default 64-bit ELF ABI is V2 (ELFv2): PowerPC.
Dec 3 2019, 9:59 PM · PowerPC
alfredo updated the diff for D22634: rtld: do not try to mmap a zero-sized PT_LOAD.

Updated with reviewers comment.
I changed the indentation a bit as it looked incorrect after looking code around. Let me know if still need changes. Thanks!

Dec 3 2019, 8:40 PM · PowerPC

Dec 2 2019

alfredo created D22634: rtld: do not try to mmap a zero-sized PT_LOAD.
Dec 2 2019, 10:56 PM · PowerPC
alfredo accepted D22524: [PowerPC] Enable TLS usage in system libraries on ELFv2..

I'm running with this patch for a while and found no side effects.

Dec 2 2019, 1:15 PM · PowerPC
alfredo added a comment to D20261: [PowerPC64] Use ld.bfd to build LIB32 and STAND - when using llvm.

Any updates on this?

Dec 2 2019, 1:10 PM · PowerPC
alfredo added inline comments to D22549: [PowerPC] enable atomic.c in compiler_rt and do not check and forces lock/lock_free decisions in compiled time.
Dec 2 2019, 1:08 PM · PowerPC
alfredo updated the diff for D22549: [PowerPC] enable atomic.c in compiler_rt and do not check and forces lock/lock_free decisions in compiled time.

updated after comments from reviewers

Dec 2 2019, 1:08 PM · PowerPC

Nov 26 2019

alfredo updated the diff for D22549: [PowerPC] enable atomic.c in compiler_rt and do not check and forces lock/lock_free decisions in compiled time.

Updated with comments, added a compiler check to make it "commitable" before flagday and retested

Nov 26 2019, 4:11 PM · PowerPC

Nov 25 2019

alfredo added a reviewer for D22549: [PowerPC] enable atomic.c in compiler_rt and do not check and forces lock/lock_free decisions in compiled time: emaste.
Nov 25 2019, 6:28 PM · PowerPC
alfredo updated the summary of D22549: [PowerPC] enable atomic.c in compiler_rt and do not check and forces lock/lock_free decisions in compiled time.
Nov 25 2019, 6:27 PM · PowerPC
alfredo updated the summary of D22549: [PowerPC] enable atomic.c in compiler_rt and do not check and forces lock/lock_free decisions in compiled time.
Nov 25 2019, 6:22 PM · PowerPC
alfredo created D22549: [PowerPC] enable atomic.c in compiler_rt and do not check and forces lock/lock_free decisions in compiled time.
Nov 25 2019, 6:19 PM · PowerPC

Nov 22 2019

alfredo accepted D22039: Mk/bsd.port.mk: detect powerpc64 abi .

Is this ready to commit?

Nov 22 2019, 8:16 PM

Nov 18 2019

alfredo planned changes to D19237: Fix TARGET_TRIPLE assembly and retrieve OS version automatically.

Need to reroll

Nov 18 2019, 6:26 PM · PowerPC

Nov 14 2019

alfredo added inline comments to D22317: [PowerPC64] Fix broken kernel modules due to LLD 9+ TOC optimization.
Nov 14 2019, 1:19 PM

Nov 11 2019

alfredo updated the summary of D20383: [PowerPC64] starting from FreeBSD 13.0, default 64-bit ELF ABI is V2 (ELFv2).
Nov 11 2019, 6:42 PM · PowerPC
alfredo requested review of D20261: [PowerPC64] Use ld.bfd to build LIB32 and STAND - when using llvm.
Nov 11 2019, 6:39 PM · PowerPC
alfredo planned changes to D20261: [PowerPC64] Use ld.bfd to build LIB32 and STAND - when using llvm.
Nov 11 2019, 6:38 PM · PowerPC
alfredo updated the diff for D20261: [PowerPC64] Use ld.bfd to build LIB32 and STAND - when using llvm.

fix rtld 32 bit build when cross building

Nov 11 2019, 6:38 PM · PowerPC
alfredo updated the diff for D22317: [PowerPC64] Fix broken kernel modules due to LLD 9+ TOC optimization.

removed compiler check to address gcc+lld possible use case

Nov 11 2019, 6:09 PM
alfredo added reviewers for D22317: [PowerPC64] Fix broken kernel modules due to LLD 9+ TOC optimization: jhibbits, bdragon.
Nov 11 2019, 6:01 PM
alfredo created D22317: [PowerPC64] Fix broken kernel modules due to LLD 9+ TOC optimization.
Nov 11 2019, 6:00 PM
alfredo updated the diff for D20378: [PowerPC64] LLVM as default toolchain for PowerPC and PowerPC64.

update man file with @bdragon's comment

Nov 11 2019, 12:11 PM · PowerPC

Nov 9 2019

alfredo retitled D19237: Fix TARGET_TRIPLE assembly and retrieve OS version automatically from Fix TARGET_TRIPLE variable assembly when specifying TARGET_ABI to Fix TARGET_TRIPLE assembly and retrieve OS version automatically.
Nov 9 2019, 1:45 AM · PowerPC