Page MenuHomeFreeBSD

alfredo (Alfredo Dal'Ava Júnior)
User

Projects

User Details

User Since
Dec 7 2018, 3:31 PM (285 w, 4 d)

Recent Activity

Nov 19 2023

alfredo committed rG62646709fd67: powerpc: Fix inconsistent Altivec handling in set_mcontext (authored by sanastasio_raptorengineering.com).
powerpc: Fix inconsistent Altivec handling in set_mcontext
Nov 19 2023, 9:05 PM
alfredo committed rG91e53779b4fc: powerpc: Implement fpu_kern_enter/fpu_kern_leave (authored by sanastasio_raptorengineering.com).
powerpc: Implement fpu_kern_enter/fpu_kern_leave
Nov 19 2023, 9:05 PM

Nov 3 2023

alfredo committed rG270f75cf3433: powerpc: Fix inconsistent Altivec handling in set_mcontext (authored by sanastasio_raptorengineering.com).
powerpc: Fix inconsistent Altivec handling in set_mcontext
Nov 3 2023, 5:57 PM
alfredo closed D42417: powerpc: Fix inconsistent Altivec handling in set_mcontext.
Nov 3 2023, 5:56 PM · PowerPC
alfredo accepted D42417: powerpc: Fix inconsistent Altivec handling in set_mcontext.
Nov 3 2023, 5:29 PM · PowerPC

Mar 12 2023

alfredo committed rG63715498ac6b: powerpc: enable ZFS on 32 bit powerpc/powerpcspe (authored by alfredo).
powerpc: enable ZFS on 32 bit powerpc/powerpcspe
Mar 12 2023, 6:24 AM

Feb 28 2023

alfredo committed R9:848cfb96d14f: Replace my expired key (authored by alfredo).
Replace my expired key
Feb 28 2023, 4:12 AM

Feb 25 2023

alfredo accepted D38787: powerpc: fix warning: a function declaration without a prototype is deprecated in all versions of C.
Feb 25 2023, 11:46 PM

Jan 11 2023

alfredo accepted D37891: vtblk: Bypass iommu on powerpc.

I verified the patch on powerpc64, powerpc64le and it fixes the issue completely. Also, powerpc 32 bit is fine with this patch.

Jan 11 2023, 3:35 AM

Dec 20 2022

alfredo closed D37675: ufs/ffs: detect endian mismatch between machine and filesystem.
Dec 20 2022, 3:26 AM
alfredo committed rGb13110e9f3ca: ufs/ffs: detect endian mismatch between machine and filesystem (authored by alfredo).
ufs/ffs: detect endian mismatch between machine and filesystem
Dec 20 2022, 3:26 AM

Dec 17 2022

alfredo added a comment to D37675: ufs/ffs: detect endian mismatch between machine and filesystem.

@mckusick , thank you for the improved patch!
During test I figured out that kernel retries to mount the filesystem several times. I prevented this changing sys/kern/vfs_mountroot.c

Dec 17 2022, 3:08 AM
alfredo updated the diff for D37675: ufs/ffs: detect endian mismatch between machine and filesystem.

remove empty line

Dec 17 2022, 3:03 AM
alfredo updated the diff for D37675: ufs/ffs: detect endian mismatch between machine and filesystem.

Update with code from mckusick

Dec 17 2022, 3:02 AM
alfredo abandoned D37720: ufs/ffs: detect endian mismatch between machine and filesystem.
Dec 17 2022, 3:01 AM
alfredo requested review of D37720: ufs/ffs: detect endian mismatch between machine and filesystem.
Dec 17 2022, 3:00 AM

Dec 13 2022

alfredo added a comment to D37675: ufs/ffs: detect endian mismatch between machine and filesystem.

Here is my proposed fix:

{F53027994}

Let me know if this works for you.

Dec 13 2022, 2:54 PM
alfredo added a comment to D35962: uname: switch machine to HW_MACHINE_ARCH.
In D35962#856826, @imp wrote:

Would a "hack" activated by poudriere/ports to change the behavior of uname(1) and uname(3) to report HW_MACHINE_ARCH instead of HW_MACHINE, be acceptable?

I doubt it would work. The hack is easy to write: just set UNAME_m=$(uname -p) when building packages (but not for buildworld, etc). However, even this wouldn't do what you want... It would break at least kernel module building would be broken since MACHINE wouldn't be powerpc in this case. It may also break some utilities that grovel in the kernel as well (though they may not since /usr/include/machine would be built correctly... though anything that needs to know where kernel sources are might not work).

Dec 13 2022, 6:46 AM
alfredo added a comment to D35962: uname: switch machine to HW_MACHINE_ARCH.

Would a "hack" activated by poudriere/ports to change the behavior of uname(1) and uname(3) to report HW_MACHINE_ARCH instead of HW_MACHINE, be acceptable?

Dec 13 2022, 6:25 AM
alfredo added a comment to D35962: uname: switch machine to HW_MACHINE_ARCH.
In D35962#856814, @imp wrote:

You are wrong. Very wrong. Wikipedia is a bad source.

Dec 13 2022, 5:54 AM

Dec 12 2022

alfredo added a comment to D35962: uname: switch machine to HW_MACHINE_ARCH.
In D35962#856667, @imp wrote:

Well, Poudriere should use uname -p. Using -p doesn't make sense. On powerpc*, it prints just powerpc on all 4 platforms and is totally misleading on 3 of them. On armv{6,7}, it's imprecise (do we deal with arm as in the removed ARMv5, armeb, armv6 or maybe armv7?), although not as incorrect as on powerpc*. On riscv64, it makes other software think it's actually riscv32, which FreeBSD doesn't even support. I have posted previously links here to software and ugly workarounds that I needed to use.

EDIT: I meant "Using -m doesn't make sense." in my 2nd sentence.

Poudriere is doing exactly the right thing. It uses them for different things. uname -m is for kernel APIs, and uname -p is for userland ABIs. We use both in our build process in a nuanced way, and it works.

Given how much this broke, I'm going to go out on a limb and say you'll never be able to change this. You must patch all the software to conform with FreeBSD's quirky way of splitting these. While uname(1) didn't change, a lot of things use uname (3) rather than sysctl for this information, and you'll be playing whack-a-mole fixing the things that are already working. So I'm back to dead set against this because it causes too much POLA.

Dec 12 2022, 5:36 PM
alfredo added a comment to D37675: ufs/ffs: detect endian mismatch between machine and filesystem.

I have some questions :)
Should we define a custom (negative) error number for endian mismatch?
Should we check for the returned error number and make the caller print the message instead?

Dec 12 2022, 4:38 AM
alfredo requested review of D37675: ufs/ffs: detect endian mismatch between machine and filesystem.
Dec 12 2022, 4:23 AM

Dec 11 2022

alfredo accepted D35962: uname: switch machine to HW_MACHINE_ARCH.
Dec 11 2022, 10:54 AM

Nov 18 2022

alfredo added a comment to D36667: vtblk: Use busdma.

@cperciva this change caused a regression on powerpc64 and powerpc64le (mountroot can't mount the filesystem).

Nov 18 2022, 5:39 AM

Nov 8 2022

alfredo committed rGf12e86a205c8: tools/build/make.py: fix cross build on Fedora Linux (authored by alfredo).
tools/build/make.py: fix cross build on Fedora Linux
Nov 8 2022, 3:31 AM

Nov 1 2022

alfredo committed rGb7ac17b48bdf: tools/build/make.py: fix cross build on Fedora Linux (authored by alfredo).
tools/build/make.py: fix cross build on Fedora Linux
Nov 1 2022, 9:03 PM
alfredo closed D36900: tools/build/make.py: fix cross build on Fedora Linux.
Nov 1 2022, 9:03 PM

Oct 28 2022

alfredo awarded D36900: tools/build/make.py: fix cross build on Fedora Linux a Like token.
Oct 28 2022, 5:28 PM
alfredo added a comment to D36900: tools/build/make.py: fix cross build on Fedora Linux.

This is fine as a workaround, but maybe we should just use command -v instead of which? I've seen build failures where docker images didn't include which

Oct 28 2022, 11:36 AM

Oct 27 2022

alfredo updated the summary of D36900: tools/build/make.py: fix cross build on Fedora Linux.
Oct 27 2022, 6:53 PM

Oct 7 2022

alfredo updated the test plan for D36900: tools/build/make.py: fix cross build on Fedora Linux.
Oct 7 2022, 3:45 AM
alfredo requested review of D36900: tools/build/make.py: fix cross build on Fedora Linux.
Oct 7 2022, 3:44 AM

Oct 6 2022

alfredo closed D36894: zfs: disable floating point on powerpc kernels.
Oct 6 2022, 8:36 PM · PowerPC
alfredo committed rG344986ff4cb6: zfs: powerpc: disable kernel floating point support (authored by alfredo).
zfs: powerpc: disable kernel floating point support
Oct 6 2022, 8:36 PM
alfredo updated the summary of D36894: zfs: disable floating point on powerpc kernels.
Oct 6 2022, 6:53 PM · PowerPC
alfredo requested review of D36894: zfs: disable floating point on powerpc kernels.
Oct 6 2022, 6:50 PM · PowerPC
alfredo abandoned D19237: Fix TARGET_TRIPLE assembly and retrieve OS version automatically.

This was superseded by https://reviews.freebsd.org/D36420

Oct 6 2022, 6:04 PM · PowerPC

Oct 5 2022

alfredo committed rGb9ced1317b32: powerpc: slb_alloc_user_cache: fix missing uma_zalloc wait flag (authored by alfredo).
powerpc: slb_alloc_user_cache: fix missing uma_zalloc wait flag
Oct 5 2022, 9:15 PM
alfredo committed rG24c553621905: powerpcspe: make GEOM_LABEL kernel built-in (authored by alfredo).
powerpcspe: make GEOM_LABEL kernel built-in
Oct 5 2022, 9:15 PM
alfredo committed rG05f9810b3197: powerpc: cpuset: add local functions for copyin/copyout (authored by alfredo).
powerpc: cpuset: add local functions for copyin/copyout
Oct 5 2022, 9:15 PM
alfredo committed rG4e6cf9ee5808: nfs: skip bootpc when vfs.root.mountfrom is other than nfs (authored by alfredo).
nfs: skip bootpc when vfs.root.mountfrom is other than nfs
Oct 5 2022, 9:15 PM

Oct 4 2022

alfredo abandoned D36866: uma_core: fix typo.

Thanks imp, but I'm abandoning since actually looks like the ":" makes sense here as there are more output due to "stack_print()" !

Oct 4 2022, 9:04 PM

Oct 3 2022

alfredo committed rG603bbd771f0c: busdma: Fix powerpc DMA alignment check (authored by jhibbits).
busdma: Fix powerpc DMA alignment check
Oct 3 2022, 10:48 PM
alfredo committed rGff80ab1cebd6: powerpc: slb_alloc_user_cache: fix missing uma_zalloc wait flag (authored by alfredo).
powerpc: slb_alloc_user_cache: fix missing uma_zalloc wait flag
Oct 3 2022, 8:57 PM
alfredo closed D36865: powerpc: slb_alloc_user_cache fix missing uma_zalloc wait flag.
Oct 3 2022, 8:57 PM · PowerPC
alfredo updated the summary of D36865: powerpc: slb_alloc_user_cache fix missing uma_zalloc wait flag.
Oct 3 2022, 8:32 PM · PowerPC
alfredo requested review of D36866: uma_core: fix typo.
Oct 3 2022, 8:27 PM
alfredo requested review of D36865: powerpc: slb_alloc_user_cache fix missing uma_zalloc wait flag.
Oct 3 2022, 8:26 PM · PowerPC
alfredo committed rGdb79bf75ac9e: powerpc: cpuset: add local functions for copyin/copyout (authored by alfredo).
powerpc: cpuset: add local functions for copyin/copyout
Oct 3 2022, 12:03 PM
alfredo closed D36234: cpuset: add local functions for copyin/copyout.
Oct 3 2022, 12:03 PM · PowerPC

Sep 29 2022

alfredo updated the diff for D36234: cpuset: add local functions for copyin/copyout.

Make this change powerpc* only in order to unbreak pfsync module and
the test infrastructure.

Sep 29 2022, 6:06 PM · PowerPC

Sep 26 2022

alfredo added a comment to D35962: uname: switch machine to HW_MACHINE_ARCH.

I started a similar discussion some time ago on IRC and the only conclusion I got was there's no standard. I looked at https://en.wikipedia.org/wiki/Uname to try to find some pattern, but found none as well and I agreed to keep as is to avoid breaking things. However I understand that keeping as is today adds an unnecessary (and avoidable) extra burden to the already small number of ports maintainers that do an excellent job keeping powerpc* ports in shape. Since no regular package delivery for powerpc* existed and we are about to have them (with the new hardware that was acquired), it's the the perfect moment to discuss it.

Sep 26 2022, 5:03 PM

Aug 16 2022

alfredo added a comment to D36234: cpuset: add local functions for copyin/copyout.

This is rather strange. The description makes it sound like there is a bug somewhere in powerpc relocation handling, nothing specifically to do with cpuset code.
Until the problem is better understood, I don't think it's appropriate to commit something like this - how do you know that the bug won't require another workaround next week?

Aug 16 2022, 10:28 PM · PowerPC
alfredo updated the summary of D36234: cpuset: add local functions for copyin/copyout.
Aug 16 2022, 9:33 PM · PowerPC
alfredo updated the test plan for D36234: cpuset: add local functions for copyin/copyout.
Aug 16 2022, 9:30 PM · PowerPC
alfredo requested review of D36234: cpuset: add local functions for copyin/copyout.
Aug 16 2022, 9:27 PM · PowerPC

Aug 2 2022

alfredo committed rG8b57548e9a38: powerpcspe: make GEOM_LABEL kernel built-in (authored by alfredo).
powerpcspe: make GEOM_LABEL kernel built-in
Aug 2 2022, 6:17 PM

Aug 1 2022

alfredo committed rGc97585565fe7: loader: fix powerpc64le ofw loader (authored by alfredo).
loader: fix powerpc64le ofw loader
Aug 1 2022, 11:07 AM

Jul 29 2022

alfredo committed rG0df5a06864b3: loader: fix powerpc64le ofw loader (authored by alfredo).
loader: fix powerpc64le ofw loader
Jul 29 2022, 5:14 AM

Jul 28 2022

alfredo added a reverting change for rG4f5890a0fb08: csu: test: explicitly add libm as build parameter: rGa12eb9e4ae53: Revert "csu: test: explicitly add libm as build parameter".
Jul 28 2022, 11:24 AM
alfredo added a comment to D35691: csu: test: explicitly add libm as build parameter.

This change was reverted in a12eb9e4ae534557867d49803a1e28bfe519a207

Jul 28 2022, 11:24 AM
alfredo added a reverting change for D35691: csu: test: explicitly add libm as build parameter: rGa12eb9e4ae53: Revert "csu: test: explicitly add libm as build parameter".
Jul 28 2022, 11:24 AM
alfredo committed rGa12eb9e4ae53: Revert "csu: test: explicitly add libm as build parameter" (authored by alfredo).
Revert "csu: test: explicitly add libm as build parameter"
Jul 28 2022, 11:24 AM

Jul 8 2022

alfredo committed rG56e8444a1709: zfs: fixup build on powerpc64le (authored by alfredo).
zfs: fixup build on powerpc64le
Jul 8 2022, 6:54 PM

Jul 7 2022

alfredo committed rG4f5890a0fb08: csu: test: explicitly add libm as build parameter (authored by alfredo).
csu: test: explicitly add libm as build parameter
Jul 7 2022, 8:58 PM
alfredo closed D35691: csu: test: explicitly add libm as build parameter.
Jul 7 2022, 8:57 PM
alfredo added a comment to D35691: csu: test: explicitly add libm as build parameter.

I just updated the review upstream, adding the needed test, so I think it should be good to submit in the next several days. I think that should make this change redundant at that point.

Jul 7 2022, 12:50 PM

Jul 6 2022

alfredo added a comment to D35691: csu: test: explicitly add libm as build parameter.

Thanks for the reviews!

Jul 6 2022, 9:48 PM
alfredo retitled D35691: csu: test: explicitly add libm as build parameter from csu: explicitly add libm as build parameter to csu: test: explicitly add libm as build parameter.
Jul 6 2022, 9:45 PM
alfredo updated the diff for D35691: csu: test: explicitly add libm as build parameter.

Make -lm added to powerpcspe only

Jul 6 2022, 9:39 PM

Jul 4 2022

alfredo committed rGe879436ce4b5: loader: fix powerpc* ofw loader (authored by alfredo).
loader: fix powerpc* ofw loader
Jul 4 2022, 9:37 AM

Jul 1 2022

alfredo added reviewers for D35691: csu: test: explicitly add libm as build parameter: PowerPC, emaste, jhb, imp.
Jul 1 2022, 3:24 PM
alfredo requested review of D35691: csu: test: explicitly add libm as build parameter.
Jul 1 2022, 3:21 PM
alfredo committed rG5d48fb3b16c1: loader: fix powerpc* ofw loader (authored by alfredo).
loader: fix powerpc* ofw loader
Jul 1 2022, 12:57 PM

May 31 2022

alfredo committed rG3cb9f1976c26: nfs: skip bootpc when vfs.root.mountfrom is other than nfs (authored by alfredo).
nfs: skip bootpc when vfs.root.mountfrom is other than nfs
May 31 2022, 7:08 PM
alfredo closed D35098: nfs: skip bootpc when vfs.root.mountfrom is other than nfs.
May 31 2022, 7:08 PM · PowerPC
alfredo added inline comments to D35098: nfs: skip bootpc when vfs.root.mountfrom is other than nfs.
May 31 2022, 6:56 PM · PowerPC

May 6 2022

alfredo committed rGe44e611e31c3: nfs: do not panic on bootpc_init when no interfaces are found (authored by alfredo).
nfs: do not panic on bootpc_init when no interfaces are found
May 6 2022, 12:15 PM
alfredo added a comment to D33603: Add FreeBSD "Orb" logo to boot loader.

I like the idea! However I burned an DVD for a PowerBook G4 and I only see the regular disc icon.
What's your device model? (based on other sources your patch looks correct. Maybe my firmware is too old for this feature)

May 6 2022, 1:32 AM · PowerPC
alfredo added a reviewer for D33603: Add FreeBSD "Orb" logo to boot loader: PowerPC.
May 6 2022, 1:25 AM · PowerPC

May 5 2022

alfredo added reviewers for D35098: nfs: skip bootpc when vfs.root.mountfrom is other than nfs: glebius, gonzo, imp.
May 5 2022, 7:08 PM · PowerPC

May 3 2022

alfredo closed D34429: retrieve OS release automatically to build compiler target triple.
May 3 2022, 11:17 AM
alfredo committed rGf9ee4156741a: build target triple variable from sys/conf/newvers.sh (authored by alfredo).
build target triple variable from sys/conf/newvers.sh
May 3 2022, 11:17 AM

May 2 2022

alfredo added a comment to D35098: nfs: skip bootpc when vfs.root.mountfrom is other than nfs.

@rmacklem, 'vfs.root.mountroot' is used as a kernel parameter to specify (or override) where is the root filesystem to be mounted and its partition type. It's usually something like "vfs.root.mountroot=ufs:/dev/da0s1a" if you use a local disk, or "vfs.root.mountroot=nfs:192.168.0.1:/tftpboot/root" if using nfs.

May 2 2022, 1:45 PM · PowerPC
alfredo added a reviewer for D35098: nfs: skip bootpc when vfs.root.mountfrom is other than nfs: sjg.
May 2 2022, 11:56 AM · PowerPC
alfredo updated the diff for D35098: nfs: skip bootpc when vfs.root.mountfrom is other than nfs.

use strncmp instead of strstr in order to match only the beginning of the string

May 2 2022, 11:56 AM · PowerPC

Apr 29 2022

alfredo updated the test plan for D35098: nfs: skip bootpc when vfs.root.mountfrom is other than nfs.
Apr 29 2022, 9:41 PM · PowerPC
alfredo requested review of D35098: nfs: skip bootpc when vfs.root.mountfrom is other than nfs.
Apr 29 2022, 9:22 PM · PowerPC

Apr 7 2022

alfredo committed rG0b1b30d66450: nfs: do not panic on bootpc_init when no interfaces are found (authored by alfredo).
nfs: do not panic on bootpc_init when no interfaces are found
Apr 7 2022, 10:38 PM
alfredo closed D34567: nfs: do not panic on bootpc_init when no interfaces are found.
Apr 7 2022, 10:38 PM

Apr 1 2022

alfredo added a comment to D34567: nfs: do not panic on bootpc_init when no interfaces are found.

Have you tested the case where there is no suitable
net interface and no local root fs to see if the failure
is "as clear" to users as the panic is?

Apr 1 2022, 12:39 PM

Mar 25 2022

alfredo added a comment to D34429: retrieve OS release automatically to build compiler target triple.

Hi @imp, are you ok with current patch?

Mar 25 2022, 5:49 PM
alfredo committed rG4081882c415b: powerpcspe: fix PCI enumeration on ppce500 (authored by alfredo).
powerpcspe: fix PCI enumeration on ppce500
Mar 25 2022, 11:07 AM

Mar 24 2022

alfredo requested review of D34567: nfs: do not panic on bootpc_init when no interfaces are found.

During tests I found that when a eligible NIC exists and network isn't prepared for bootp, it cannot load the local root file system.
More investigation is required:

Mar 24 2022, 8:16 PM

Mar 21 2022

alfredo committed rG27f56d337be3: powerpcspe: fix PCI enumeration on ppce500 (authored by alfredo).
powerpcspe: fix PCI enumeration on ppce500
Mar 21 2022, 7:12 PM
alfredo closed D34621: powerpcspe: fix PCI enumeration on ppce500.
Mar 21 2022, 7:12 PM
alfredo updated the test plan for D34621: powerpcspe: fix PCI enumeration on ppce500.
Mar 21 2022, 11:15 AM
alfredo updated the diff for D34621: powerpcspe: fix PCI enumeration on ppce500.

style

Mar 21 2022, 11:13 AM
alfredo requested review of D34621: powerpcspe: fix PCI enumeration on ppce500.
Mar 21 2022, 11:07 AM