Page MenuHomeFreeBSD

sanastasio_raptorengineering.com (Shawn Anastasio)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 21 2023, 6:30 PM (39 w, 3 h)

Recent Activity

Apr 4 2024

sanastasio_raptorengineering.com added a comment to D44274: ossl: Add GCM support on powerpc64/powerpc64le (POWER8+).

Hi all, sorry for the ping. If anybody had time to review this, it would be greatly appreciated. We've deployed this patch internally on some of our production systems and in addition to the massive performance improvement, it has proven stable under various workloads.

Apr 4 2024, 9:54 PM

Mar 11 2024

sanastasio_raptorengineering.com updated the diff for D44274: ossl: Add GCM support on powerpc64/powerpc64le (POWER8+).
  • Whitespace/formatting cleanup
  • Use powerpc64 compiler conditional instead of PPC
  • Drop ppc_aes_gcm_{de,en}crypt_ wrapper functions in favor of macros
Mar 11 2024, 5:32 PM

Mar 7 2024

sanastasio_raptorengineering.com requested review of D44274: ossl: Add GCM support on powerpc64/powerpc64le (POWER8+).
Mar 7 2024, 9:02 PM

Mar 5 2024

sanastasio_raptorengineering.com added inline comments to D41837: ossl: Add support for powerpc64/powerpc64le.
Mar 5 2024, 7:05 PM
sanastasio_raptorengineering.com updated the diff for D41837: ossl: Add support for powerpc64/powerpc64le.
  • Add device ossl to GENERIC64LE as well
Mar 5 2024, 7:04 PM

Mar 1 2024

sanastasio_raptorengineering.com added a comment to D44015: powerpc: Bump maximum number of FDT reserved mem entries.

This means the function now uses more than 1kB stack space. We should be careful bumping it again in the future. It's called early enough that stack space shouldn't be an issue, but something to keep in mind, definitely.

Does this fix https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277097 ?

Mar 1 2024, 6:54 PM
sanastasio_raptorengineering.com updated the diff for D41837: ossl: Add support for powerpc64/powerpc64le.
  • Use powerpc64 compiler conditional
  • Update sys/modules/Makefile
  • Rebase
Mar 1 2024, 4:59 PM
sanastasio_raptorengineering.com added a comment to D41837: ossl: Add support for powerpc64/powerpc64le.
In D41837#978749, @jhb wrote:

Do you need to update sys/modules/Makefile to enable ossl on powepc64*?

Mar 1 2024, 4:58 PM

Feb 21 2024

sanastasio_raptorengineering.com requested review of D44015: powerpc: Bump maximum number of FDT reserved mem entries.
Feb 21 2024, 8:25 PM

Dec 1 2023

sanastasio_raptorengineering.com added a comment to D41837: ossl: Add support for powerpc64/powerpc64le.

Sorry to ping again, but now that the fix for the kernel_fpu facilities has been merged could I request further review of this patch?

Dec 1 2023, 8:16 PM

Oct 31 2023

sanastasio_raptorengineering.com requested review of D42417: powerpc: Fix inconsistent Altivec handling in set_mcontext.
Oct 31 2023, 8:35 PM · PowerPC

Oct 9 2023

sanastasio_raptorengineering.com added inline comments to D41837: ossl: Add support for powerpc64/powerpc64le.
Oct 9 2023, 9:24 PM

Sep 26 2023

sanastasio_raptorengineering.com added a comment to D41837: ossl: Add support for powerpc64/powerpc64le.

Hi all,

Sep 26 2023, 10:41 PM

Sep 15 2023

sanastasio_raptorengineering.com updated the diff for D41837: ossl: Add support for powerpc64/powerpc64le.
  • Correct license header on newly-added ossl_ppc.c
Sep 15 2023, 8:14 PM
sanastasio_raptorengineering.com added inline comments to D41837: ossl: Add support for powerpc64/powerpc64le.
Sep 15 2023, 8:12 PM

Sep 14 2023

sanastasio_raptorengineering.com added inline comments to D41837: ossl: Add support for powerpc64/powerpc64le.
Sep 14 2023, 5:49 PM

Sep 12 2023

sanastasio_raptorengineering.com removed reviewers for D41837: ossl: Add support for powerpc64/powerpc64le: jhb, jhibbits, pkubaj.
Sep 12 2023, 8:18 PM
sanastasio_raptorengineering.com requested review of D41837: ossl: Add support for powerpc64/powerpc64le.
Sep 12 2023, 8:17 PM
sanastasio_raptorengineering.com added a comment to D41540: powerpc: Implement fpu_kern_enter/fpu_kern_leave.

Also, thank you @jhibbits for approving the patch. I'm not super familiar with the FreeBSD contribution work flow yet, so excuse the question, but is there anything that I need to do at this point to have this patch committed? I presume the patch must now be merged by someone other than me with commit privileges.

Sep 12 2023, 8:09 PM
sanastasio_raptorengineering.com added a comment to D41540: powerpc: Implement fpu_kern_enter/fpu_kern_leave.

As long as it doesn't require VSX (able to run on PowerMac G5), I think it's good.

Sep 12 2023, 6:37 PM

Sep 11 2023

sanastasio_raptorengineering.com added a comment to D41540: powerpc: Implement fpu_kern_enter/fpu_kern_leave.

Hi all,

Sep 11 2023, 6:54 PM

Sep 1 2023

sanastasio_raptorengineering.com added a comment to D41540: powerpc: Implement fpu_kern_enter/fpu_kern_leave.

It seems like aes-xts and all its variants are the only ones failing. See below.

Sep 1 2023, 5:20 PM

Aug 31 2023

sanastasio_raptorengineering.com updated the diff for D41540: powerpc: Implement fpu_kern_enter/fpu_kern_leave.
  • Guard out entire implementation on SPE
Aug 31 2023, 3:31 AM
sanastasio_raptorengineering.com added inline comments to D41540: powerpc: Implement fpu_kern_enter/fpu_kern_leave.
Aug 31 2023, 3:31 AM

Aug 29 2023

sanastasio_raptorengineering.com updated the diff for D41540: powerpc: Implement fpu_kern_enter/fpu_kern_leave.
  • Update fpu_kern.9 manual page
  • Bump __FreeBSD_version
  • Rebase
Aug 29 2023, 11:06 PM

Aug 23 2023

sanastasio_raptorengineering.com added a comment to D41540: powerpc: Implement fpu_kern_enter/fpu_kern_leave.

I've just done some preliminary tests with ZFS kernel FPU enabled on power and it seems to be working, though I'm not sure if I've fully exercised the relevant code paths.

Aug 23 2023, 10:29 PM
sanastasio_raptorengineering.com added a comment to D41540: powerpc: Implement fpu_kern_enter/fpu_kern_leave.

Thank you all for the comments. I'll coalesce my replies into a single message.

Aug 23 2023, 8:19 PM

Aug 21 2023

sanastasio_raptorengineering.com requested review of D41540: powerpc: Implement fpu_kern_enter/fpu_kern_leave.
Aug 21 2023, 11:01 PM