• Rename ARM's ossl_aes_gcm.c to ossl_aes_gcm_neon.c and update references

Hi all, sorry for the ping. Could anybody take another look at this patch set?

Hi all,

• Update style as suggested

In D44274#1021011, @markj wrote:

It looks like the ARM NEON implementation could be deduplicated too, but it isn't. Is there a reason?

Hi all, sorry for the ping. If anybody had time to review this, it would be greatly appreciated. We've deployed this patch internally on some of our production systems and in addition to the massive performance improvement, it has proven stable under various workloads.

• Whitespace/formatting cleanup
• Use powerpc64 compiler conditional instead of PPC
• Drop ppc_aes_gcm_{de,en}crypt_ wrapper functions in favor of macros

• Add device ossl to GENERIC64LE as well

In D44015#1004103, @jhibbits wrote:

This means the function now uses more than 1kB stack space. We should be careful bumping it again in the future. It's called early enough that stack space shouldn't be an issue, but something to keep in mind, definitely.

Does this fix https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277097 ?

• Use powerpc64 compiler conditional
• Update sys/modules/Makefile
• Rebase

In D41837#978749, @jhb wrote:

Do you need to update sys/modules/Makefile to enable ossl on powepc64*?

Sorry to ping again, but now that the fix for the kernel_fpu facilities has been merged could I request further review of this patch?

Hi all,

• Correct license header on newly-added ossl_ppc.c

Also, thank you @jhibbits for approving the patch. I'm not super familiar with the FreeBSD contribution work flow yet, so excuse the question, but is there anything that I need to do at this point to have this patch committed? I presume the patch must now be merged by someone other than me with commit privileges.

In D41540#953470, @jhibbits wrote:

As long as it doesn't require VSX (able to run on PowerMac G5), I think it's good.

Hi all,

It seems like aes-xts and all its variants are the only ones failing. See below.

• Guard out entire implementation on SPE

• Update fpu_kern.9 manual page
• Bump __FreeBSD_version
• Rebase

I've just done some preliminary tests with ZFS kernel FPU enabled on power and it seems to be working, though I'm not sure if I've fully exercised the relevant code paths.

Thank you all for the comments. I'll coalesce my replies into a single message.