HomeFreeBSD

powerpc: Fix inconsistent Altivec handling in set_mcontext

Description

powerpc: Fix inconsistent Altivec handling in set_mcontext

When support for fpu_kern_enter/fpu_kern_leave was added to powerpc,
set_mcontext was updated to handle Altivec state restoration in the same
way that the FPU state by lazily restoring the context on the first
trap. However the function was not correctly updated to unconditionally
clear the PCB_VEC and PSL_VEC bits from the pcb's flags and srr1
respectively which can sometimes result in a mismatch between a
process's MSR[VEC] state and its pcb_flags.

Fix this by simply clearing the VEC flags unconditionally in
set_mcontext, which is already done for FPU/VSX.

Fixes: a6662c37b6ffe ("powerpc: Implement fpu_kern_enter/fpu_kern_leave")

Reviewed by: alfredo
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D42417

(cherry picked from commit 270f75cf3433807d124cdf1f0072ab801532f425)

Details

Provenance
sanastasio_raptorengineering.comAuthored on Nov 3 2023, 5:40 PM
alfredoCommitted on Nov 19 2023, 8:57 PM
Reviewer
alfredo
Differential Revision
D42417: powerpc: Fix inconsistent Altivec handling in set_mcontext
Parents
rG91e53779b4fc: powerpc: Implement fpu_kern_enter/fpu_kern_leave
Branches
Unknown
Tags
Unknown