gonzo (Oleksandr Tymoshenko)
User

Projects

User Details

User Since
Jan 15 2015, 11:54 PM (156 w, 6 d)

Recent Activity

Thu, Jan 11

gonzo accepted D13856: Fix `make` in sys/modules.

Looks OK for sdhci_acpi

Thu, Jan 11, 8:13 AM

Tue, Jan 2

gonzo committed rS327502: nctgpio: add new device id for the GPIO chip in PCEngines APU3.
nctgpio: add new device id for the GPIO chip in PCEngines APU3
Tue, Jan 2, 8:58 PM

Sun, Dec 31

gonzo committed rS327454: Fix GCC build broken by r32744.
Fix GCC build broken by r32744
Sun, Dec 31, 11:40 PM
gonzo committed rS327449: Unbreak build broken by r327444.
Unbreak build broken by r327444
Sun, Dec 31, 9:29 PM
gonzo committed rS327444: vt(4): add support for configurable console palette.
vt(4): add support for configurable console palette
Sun, Dec 31, 8:21 PM
gonzo closed D13645: Make vt(4) palette configurable.
Sun, Dec 31, 8:21 PM
gonzo accepted D13695: stand/fdt: Make fdt_overlay_apply signature-compatible with libfdt.

LGTM

Sun, Dec 31, 12:01 AM
gonzo updated the diff for D13645: Make vt(4) palette configurable.

Remove unneccessary loop, strtoul takes care of leading whitespaces

Sun, Dec 31, 12:00 AM

Sat, Dec 30

gonzo added inline comments to D13645: Make vt(4) palette configurable.
Sat, Dec 30, 2:45 AM
gonzo added inline comments to D13645: Make vt(4) palette configurable.
Sat, Dec 30, 2:19 AM

Fri, Dec 29

gonzo updated the diff for D13645: Make vt(4) palette configurable.
  • Fixed typo in man page
  • Addressed jilles@ comments in rgb-triplet parsing code
Fri, Dec 29, 9:40 PM
gonzo added inline comments to D13645: Make vt(4) palette configurable.
Fri, Dec 29, 9:40 PM
gonzo added a comment to D13645: Make vt(4) palette configurable.
In D13645#285283, @manu wrote:

It should be documented in loader.conf(5), otherwise looks okay.

Fri, Dec 29, 1:10 AM
gonzo updated the diff for D13645: Make vt(4) palette configurable.

Document new tunable in vt(4)

Fri, Dec 29, 1:08 AM

Thu, Dec 28

gonzo accepted D13664: stand/fdt: Consistently apply fdt_overlays.
Thu, Dec 28, 9:12 PM
gonzo accepted D13663: stand/fdt: Avoid bailout when dtbo has no fixups.
Thu, Dec 28, 9:08 PM
gonzo accepted D13659: stand/fdt: Fix loading of multiple fdt_overlays.
Thu, Dec 28, 9:00 PM
gonzo added a comment to D13659: stand/fdt: Fix loading of multiple fdt_overlays.
In D13659#285514, @manu wrote:

Did you test multiple overlays targeting the same node ?
Last time I talk to gonzo@ about he came to the conclusion that we need to update libfdt in our tree and use their overlay implementation.

Thu, Dec 28, 9:00 PM

Tue, Dec 26

gonzo created D13645: Make vt(4) palette configurable.
Tue, Dec 26, 9:33 PM
gonzo committed rD51338: Provide more details for new committers on Bugzilla account merging.
Provide more details for new committers on Bugzilla account merging
Tue, Dec 26, 9:17 PM
gonzo closed D12828: Provide more details for new committers on Bugzilla account merging.
Tue, Dec 26, 9:17 PM

Dec 18 2017

gonzo accepted D13456: bthidd: Add evdev protocol support.

Kernel part and overall style looks fine. I skimmed through userland code and didn't find any obvious blunders but I guess final say on funcitonal side of this change is up to emax@

Dec 18 2017, 9:29 PM
gonzo added a comment to D12828: Provide more details for new committers on Bugzilla account merging.

Ping. Any additional redactions required?

Dec 18 2017, 9:22 PM

Dec 5 2017

gonzo updated the diff for D12828: Provide more details for new committers on Bugzilla account merging.

Refrase login step

Dec 5 2017, 7:08 AM
gonzo accepted D13086: Add chvgpio driver for gpio present of Intel z8000 series (Cherry View) SOC.

Code part looks good to me

Dec 5 2017, 12:30 AM

Dec 4 2017

gonzo committed rP455495: www/chromium: add support for USB U2F devices.
www/chromium: add support for USB U2F devices
Dec 4 2017, 5:44 AM

Nov 19 2017

gonzo accepted D12983: evdev: USB scancode 0x54 is KEY_KPSLASH, not KEY_SLASH.

LGTM

Nov 19 2017, 10:40 PM

Nov 4 2017

gonzo committed rS325410: Increase TX_MAX_SEGS from 10 to 20 for the if_awg.c driver.
Increase TX_MAX_SEGS from 10 to 20 for the if_awg.c driver
Nov 4 2017, 11:28 PM

Nov 3 2017

gonzo updated the diff for D12828: Provide more details for new committers on Bugzilla account merging.

Style fix: there should be two spaces between full stop and capital letter in next sentence

Nov 3 2017, 12:29 AM

Nov 1 2017

gonzo accepted D12676: evdev: several minor fixes and improvements.

LGTM

Nov 1 2017, 7:35 PM
gonzo updated the diff for D12828: Provide more details for new committers on Bugzilla account merging.

Style fixes suggested by mat@

Nov 1 2017, 7:31 PM

Oct 29 2017

gonzo added a reviewer for D12828: Provide more details for new committers on Bugzilla account merging: Doc Committers.
Oct 29 2017, 9:00 PM
gonzo created D12828: Provide more details for new committers on Bugzilla account merging.
Oct 29 2017, 8:55 PM
gonzo accepted D12672: bthidd: generate button release event after virtual T-axis button press.

I am not qualified to approve functional side of patch I will leave it to emax@, but style-wise it looks OK.

Oct 29 2017, 6:22 PM

Oct 27 2017

gonzo committed rS325048: Fix MAC address detection regression introduced by r324184.
Fix MAC address detection regression introduced by r324184
Oct 27 2017, 9:23 PM

Oct 19 2017

gonzo added a comment to D12649: FDT support for RTL8366 on etherswitch framework.

Custom dts files shouldn't be put to sys/gnu/dts. This directory is periodically synced with upstream tree, so custom changes may be hard to maintain. The right way to new .dts is to put it to boot/fdt/dts/mips. All include operators should just work

Oct 19 2017, 12:51 AM

Aug 24 2017

gonzo committed rS322827: Add "xlnx,zynq-7000" to zedboard and zybo compatible property.
Add "xlnx,zynq-7000" to zedboard and zybo compatible property
Aug 24 2017, 2:09 AM

Aug 16 2017

gonzo accepted D12017: wmt: Driver for generic MS Windows 7/8/10 - compatible USB HID multi-touch devices.

Looks good to me

Aug 16 2017, 11:35 PM

Jun 26 2017

gonzo committed rS320387: [arm] Use correct index value when checking range validity.
[arm] Use correct index value when checking range validity
Jun 26 2017, 9:45 PM
gonzo closed D9145: Fix MSI IRQ allocation for ARM GIC by committing rS320387: [arm] Use correct index value when checking range validity.
Jun 26 2017, 9:45 PM

Jun 22 2017

gonzo added a comment to D9145: Fix MSI IRQ allocation for ARM GIC.

ping

Jun 22 2017, 1:03 AM

Jun 21 2017

gonzo accepted D11156: uep(4): add evdev support.

Looks good to me

Jun 21 2017, 6:32 PM

May 29 2017

gonzo accepted D10265: psm(4), evdev support part 3: EVDEV support itself.

Looks good to me

May 29 2017, 7:21 AM

May 23 2017

gonzo added a comment to D10264: psm(4), evdev support part 2: psm softc locking.

Vladimir, could you abandon this change if it's obsolete and you don't have any plans to update the patch?

May 23 2017, 12:45 PM

May 11 2017

gonzo committed rS318196: MFC r315031:.
MFC r315031:
May 11 2017, 8:31 PM

May 9 2017

gonzo committed rS318118: MFC r310343-r310344.
MFC r310343-r310344
May 9 2017, 9:26 PM
gonzo committed rS318102: MFC r315009:.
MFC r315009:
May 9 2017, 7:54 PM
gonzo committed rS318093: MFC r306806, r313709, r317058, r317060.
MFC r306806, r313709, r317058, r317060
May 9 2017, 6:46 PM
gonzo committed rS317994: MFC r315019:.
MFC r315019:
May 9 2017, 12:29 AM

May 8 2017

gonzo committed rS317993: MFC r315010:.
MFC r315010:
May 8 2017, 11:58 PM
gonzo committed rS317989: MFC r315176-r315178.
MFC r315176-r315178
May 8 2017, 10:35 PM
gonzo committed rS317976: MFC r310791:.
MFC r310791:
May 8 2017, 8:09 PM
gonzo committed rS317974: MFC r308424, r310636.
MFC r308424, r310636
May 8 2017, 7:57 PM
gonzo committed rS317970: MFC r310560:.
MFC r310560:
May 8 2017, 7:23 PM

May 5 2017

gonzo added a comment to D10264: psm(4), evdev support part 2: psm softc locking.

It looks OK to me but could you email link to this review to freebsd-arch@ and ask for second opinion? With code this old there might be some hidden pitfalls. If nobody raises any concerns - go ahead and commit it.

May 5 2017, 8:50 PM

May 4 2017

gonzo accepted D10266: psm(4), evdev support part 0: minor mostly touchpads-related fixes and improvements.

LGTM

May 4 2017, 6:48 PM

May 2 2017

gonzo updated the diff for D9145: Fix MSI IRQ allocation for ARM GIC.

Sync patch to the latest HEAD version

May 2 2017, 6:42 PM
gonzo reclaimed D9145: Fix MSI IRQ allocation for ARM GIC.

Yeah, overlooked end_irq part, reopening

May 2 2017, 6:41 PM

May 1 2017

gonzo committed rS317625: Welcome Vladimir Kondratyev (wulf) as a new src committer..
Welcome Vladimir Kondratyev (wulf) as a new src committer.
May 1 2017, 1:55 AM

Apr 26 2017

gonzo abandoned D9145: Fix MSI IRQ allocation for ARM GIC.

Overcome by events: fixed by r317428

Apr 26 2017, 12:08 AM

Apr 3 2017

gonzo added a comment to D10207: psm(4): evdev support + psm&atkbdc locking.

Hi Vladimir,

Apr 3 2017, 7:41 PM

Apr 1 2017

gonzo committed rS316371: [versatilepb] Fix keyboard driver after switching to upstream DTS.
[versatilepb] Fix keyboard driver after switching to upstream DTS
Apr 1 2017, 8:38 PM
gonzo committed rS316370: [versatilepb] Convert VERSATILEPB kernel to INTRNG and switch to upstream DTB.
[versatilepb] Convert VERSATILEPB kernel to INTRNG and switch to upstream DTB
Apr 1 2017, 8:10 PM

Mar 30 2017

gonzo committed rS316306: [am335x] Fix HDMI suport for Beaglebone Black.
[am335x] Fix HDMI suport for Beaglebone Black
Mar 30 2017, 9:55 PM

Mar 25 2017

gonzo committed rS315967: [rpi] Use compatibility string from upstream DTB for I2C controller.
[rpi] Use compatibility string from upstream DTB for I2C controller
Mar 25 2017, 10:58 PM

Mar 14 2017

gonzo abandoned D9432: Add FreeBSD layer for AM335x-based devices DTS files.
Mar 14 2017, 11:12 PM

Mar 12 2017

gonzo committed rS315178: [evdev] Fix Right Alt and Keypad Enter event codes for atkbd(4) and kbdmux(4)….
[evdev] Fix Right Alt and Keypad Enter event codes for atkbd(4) and kbdmux(4)…
Mar 12 2017, 7:29 PM
gonzo committed rS315177: [evdev] Fix race condition between client's event queue reading and dropping.
[evdev] Fix race condition between client's event queue reading and dropping
Mar 12 2017, 7:28 PM
gonzo committed rS315176: [evdev] Do not ignore result evdev_register in UI_DEV_CREATE handler.
[evdev] Do not ignore result evdev_register in UI_DEV_CREATE handler
Mar 12 2017, 7:26 PM
gonzo closed D9320: evdev - minor fixes by committing rS315176: [evdev] Do not ignore result evdev_register in UI_DEV_CREATE handler.
Mar 12 2017, 7:26 PM

Mar 10 2017

gonzo committed rS315031: [fdt] Make DTBs generated by make_dtb.sh overlay-ready.
[fdt] Make DTBs generated by make_dtb.sh overlay-ready
Mar 10 2017, 10:45 PM
gonzo committed rS315019: [loader][fdt] Fix applying overlays without __local_fixups__ node.
[loader][fdt] Fix applying overlays without __local_fixups__ node
Mar 10 2017, 7:16 PM
gonzo committed rS315010: [dtc] regenerate version file if upstream Makefile has been changed.
[dtc] regenerate version file if upstream Makefile has been changed
Mar 10 2017, 5:38 PM
gonzo committed rS315009: Merge from vendor branch importing dtc 1.4.3.
Merge from vendor branch importing dtc 1.4.3
Mar 10 2017, 5:36 PM
gonzo committed rS314986: Tag dtc 1.4.3 post import.
Tag dtc 1.4.3 post import
Mar 10 2017, 3:31 AM
gonzo committed rS314985: Import dtc 1.4.3.
Import dtc 1.4.3
Mar 10 2017, 3:29 AM

Mar 9 2017

gonzo committed rS314934: [spigen] Add spigen module.
[spigen] Add spigen module
Mar 9 2017, 1:21 AM
gonzo committed rS314933: [spigen] make spigen device ready to be compiled as a module.
[spigen] make spigen device ready to be compiled as a module
Mar 9 2017, 1:00 AM

Mar 4 2017

gonzo added a comment to D9640: cpufreq for rpi3.

Committed. Sorry for delay.

Mar 4 2017, 5:35 PM
gonzo committed rS314672: [rpi] rpi3 should use the same cpufreq logic as rpi2, not rpi-b.
[rpi] rpi3 should use the same cpufreq logic as rpi2, not rpi-b
Mar 4 2017, 5:34 PM
gonzo closed D9640: cpufreq for rpi3 by committing rS314672: [rpi] rpi3 should use the same cpufreq logic as rpi2, not rpi-b.
Mar 4 2017, 5:34 PM

Mar 2 2017

gonzo committed rS314569: MFC r314535:.
MFC r314535:
Mar 2 2017, 10:43 PM
gonzo committed rS314535: [intelspi][bytgio] Fix buildworld with MODULES_WITH_WORLD set.
[intelspi][bytgio] Fix buildworld with MODULES_WITH_WORLD set
Mar 2 2017, 3:19 AM

Feb 27 2017

gonzo committed rS314364: MFC r313712:.
MFC r313712:
Feb 27 2017, 10:53 PM
gonzo committed rS314363: MFC r310645:.
MFC r310645:
Feb 27 2017, 8:50 PM
gonzo committed rS314361: MFC r313757:.
MFC r313757:
Feb 27 2017, 7:51 PM

Feb 17 2017

gonzo added a comment to D9647: Make the evdev devices owned by the video group and set mode to 0660.

Just to rehash what we discussed on IRC: evdev provides access to all keyboard traffic so normally it shouldn't be exposed to non-root users. I believe Xorg handles this problem by being suid/sgid. Not sure about wayland. So some additional research required before this change can be accepted.

Feb 17 2017, 7:44 PM
gonzo accepted D9640: cpufreq for rpi3.

Looks good

Feb 17 2017, 7:42 PM

Feb 15 2017

gonzo committed rS313757: [psm] Fix calculation for clickpad softbuttons at the top.
[psm] Fix calculation for clickpad softbuttons at the top
Feb 15 2017, 2:53 AM

Feb 14 2017

gonzo committed rS313712: [sdhci_acpi] Add support for Bay Trail SDHC SD card slot.
[sdhci_acpi] Add support for Bay Trail SDHC SD card slot
Feb 14 2017, 12:04 AM

Feb 13 2017

gonzo committed rD49984: Update my expired PGP key.
Update my expired PGP key
Feb 13 2017, 7:44 PM

Feb 11 2017

gonzo updated D9432: Add FreeBSD layer for AM335x-based devices DTS files.
Feb 11 2017, 1:53 AM

Feb 10 2017

gonzo added a comment to D9520: loader: implement MEDIA_FILEPATH_DP support in efipart.
In D9520#196965, @gonzo wrote:

I tested it on rpi3, it works with crochet-generated image

... skipped ...

does it actually boot properly in your case?

Feb 10 2017, 7:37 PM
gonzo added a comment to D9520: loader: implement MEDIA_FILEPATH_DP support in efipart.

I tested it on rpi3, it works with crochet-generated image

Feb 10 2017, 7:34 PM

Feb 5 2017

gonzo updated the diff for D9432: Add FreeBSD layer for AM335x-based devices DTS files.

Do not use the same name as upstream DTS files and add UPDATING notice
about compatibility breakage

Feb 5 2017, 8:37 PM
gonzo accepted D9320: evdev - minor fixes.

LGTM

Feb 5 2017, 8:35 PM

Feb 4 2017

gonzo committed rS313183: MFC r310124 (by andrew):.
MFC r310124 (by andrew):
Feb 4 2017, 1:24 AM

Feb 3 2017

gonzo retitled D9432: Add FreeBSD layer for AM335x-based devices DTS files from to Add FreeBSD layer for AM335x-based devices DTS files.
Feb 3 2017, 11:40 PM

Feb 1 2017

gonzo committed rS313068: [am335x] Fallback to standard video interface bindings when using Linux dts.
[am335x] Fallback to standard video interface bindings when using Linux dts
Feb 1 2017, 10:04 PM

Jan 29 2017

gonzo committed rS312969: [am335x] Fix DTB name in LINKS variable.
[am335x] Fix DTB name in LINKS variable
Jan 29 2017, 10:07 PM