Page MenuHomeFreeBSD

armv8crypto: add AES-XTS support
Needs ReviewPublic

Authored by greg_unrelenting.technology on Jul 21 2019, 7:19 PM.

Details

Summary

Straightforward(ish) port from aesni, without unrolling (block8).

Quick speed test: dd if=/dev/zero of=/dev/md0.eli bs=1m reports ~360 MB/s instead of ~60 MB/s on a Cortex-A72 @ 2GHz (Marvell Armada8k).

Test Plan

Tested with opencrypto tests. (D21018 enables them on aarch64)

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

manu added a subscriber: manu.Jul 21 2019, 7:50 PM
manu added inline comments.
sys/crypto/armv8/armv8_crypto.c
191

Why did you change the argument here ?
You have the key and the key length in the struct cryptoini

sys/crypto/armv8/armv8_crypto.c
191

Look at the calls — in the CRD_F_KEY_EXPLICIT case, instead of cryptoini, we have cryptodesc. This is how aesni deals with this.

lwhsu added a subscriber: lwhsu.Jul 22 2019, 2:13 PM