Page MenuHomeFreeBSD

gbe (Gordon Bergling)
User

Projects

User Details

User Since
Jul 9 2019, 1:39 PM (51 w, 5 d)

Recent Activity

Today

gbe abandoned D25566: apropos(1) and makewhatis(8): Update HISTORY sections.

It was decided that the updates to apropos(1) and makewhatis(8) should be reverted, so this revision is abandoned.

Mon, Jul 6, 6:50 AM

Yesterday

gbe abandoned D25522: Handbook: Pre-Installation Tasks: Update the dd example.
Sun, Jul 5, 10:36 AM
gbe requested review of D25566: apropos(1) and makewhatis(8): Update HISTORY sections.
Sun, Jul 5, 7:36 AM

Wed, Jul 1

gbe added a comment to D25522: Handbook: Pre-Installation Tasks: Update the dd example.
In D25522#564549, @bcr wrote:

OK, thanks for these assessments.
@gbe: Can you either update the diff or close the PR if you think that is better than changing the existing text (just for the process= part)? For example, it could be "not a bug".

Wed, Jul 1, 9:07 PM
gbe added a comment to D25525: Add timerisvalid() from OpenBSD.

Should we also do a MLINKS+= timeradd.3 timerisvalid.3 in share/man/man3/Makefile?

Wed, Jul 1, 2:28 PM
gbe updated the diff for D25525: Add timerisvalid() from OpenBSD.
  • Hock up timerisvalid to the Makefile
Wed, Jul 1, 2:28 PM
gbe added reviewers for D25533: clear_tmp: Remove all chflags bits in /tmp before the clear proccess is initiated: Contributor Reviews (base), Src Committers.
Wed, Jul 1, 10:41 AM
gbe requested review of D25533: clear_tmp: Remove all chflags bits in /tmp before the clear proccess is initiated.
Wed, Jul 1, 10:40 AM
gbe added a comment to D25021: Synchronize OpenBSM github repository with the FreeBSD sources.
In D25021#564243, @csjp wrote:

I am ok with this diff.

I do think we ought to do a vendor import sooner than later though. @gbe I merged a couple of syscall identifiers here: https://github.com/openbsm/openbsm/pull/63 Can you point me to specifically which changes have been made to FreeBSD that haven't been upstreamed? I can work on getting those in. The diffs between default github branch for OpenBSM and base are extensive, so we need to make sure we get it tested and merged in a responsible manner.

Wed, Jul 1, 8:15 AM

Tue, Jun 30

gbe requested review of D25525: Add timerisvalid() from OpenBSD.
Tue, Jun 30, 9:25 PM
gbe added a reviewer for D25021: Synchronize OpenBSM github repository with the FreeBSD sources: Contributor Reviews (base).

Adding Contributor Reviews (base) as reviewer in the hope to speedup the approval process.

Tue, Jun 30, 7:35 PM
gbe accepted D25462: printf(1): Add EXAMPLES section.

LGTM

Tue, Jun 30, 7:26 PM
gbe requested review of D25522: Handbook: Pre-Installation Tasks: Update the dd example.
Tue, Jun 30, 7:03 PM
gbe committed rS362809: Mention FreeBSD in the HISTORY sections of apropos(1) and makewhatis(8)..
Mention FreeBSD in the HISTORY sections of apropos(1) and makewhatis(8).
Tue, Jun 30, 6:09 PM
gbe closed D25521: Mention FreeBSD in the HISTORY sections of apropos(1) and makewhatis(8).
Tue, Jun 30, 6:09 PM
gbe requested review of D25521: Mention FreeBSD in the HISTORY sections of apropos(1) and makewhatis(8).
Tue, Jun 30, 5:53 PM
gbe committed rS362808: iovctl(8): Correct a typo in the manpage and correct the SYNOPSIS.
iovctl(8): Correct a typo in the manpage and correct the SYNOPSIS
Tue, Jun 30, 5:21 PM

Mon, Jun 29

gbe committed rS362779: gre(4): Add a STANDARDS section.
gre(4): Add a STANDARDS section
Mon, Jun 29, 10:31 AM
gbe closed D25504: gre(4): Add STANDARDS section.
Mon, Jun 29, 10:30 AM
gbe added a comment to D25406: hexdump(1): Add EXAMPLES section.
In D25406#563515, @0mp wrote:
In D25406#563478, @gbe wrote:

Thanks for the patch!

Everything looks good except the manpage date, which should be bumped. :)

Hi Gordon,

Thanks for reviewing this!
I usually bump .Dd when I commit the review (although I know it is a risk because I could forget it). As a general rule, should the manpage date and the commit date be equal?

The manual page date should match the commit date.

Mon, Jun 29, 9:04 AM
gbe added a comment to D25406: hexdump(1): Add EXAMPLES section.
In D25406#563515, @0mp wrote:
In D25406#563478, @gbe wrote:

Thanks for the patch!

Everything looks good except the manpage date, which should be bumped. :)

Hi Gordon,

Thanks for reviewing this!
I usually bump .Dd when I commit the review (although I know it is a risk because I could forget it). As a general rule, should the manpage date and the commit date be equal?

The manual page date should match the commit date.

If everything is OK, I can commit this (later) today. The commit date will match .Dd

Mon, Jun 29, 9:02 AM
gbe accepted D25406: hexdump(1): Add EXAMPLES section.
Mon, Jun 29, 7:37 AM
gbe updated subscribers of D25406: hexdump(1): Add EXAMPLES section.
In D25406#563478, @gbe wrote:

Thanks for the patch!

Everything looks good except the manpage date, which should be bumped. :)

Hi Gordon,

Thanks for reviewing this!
I usually bump .Dd when I commit the review (although I know it is a risk because I could forget it). As a general rule, should the manpage date and the commit date be equal?

Mon, Jun 29, 7:37 AM
gbe requested review of D25504: gre(4): Add STANDARDS section.
Mon, Jun 29, 7:09 AM
gbe requested changes to D25406: hexdump(1): Add EXAMPLES section.

Thanks for the patch!

Mon, Jun 29, 6:18 AM

Sun, Jun 28

gbe committed rS362725: MFC r360604: Add references for the most important man7 pages.
MFC r360604: Add references for the most important man7 pages
Sun, Jun 28, 2:41 PM
gbe committed rS362724: MFC r359633, r359656, r360190: Add a manpage for smbios(4)..
MFC r359633, r359656, r360190: Add a manpage for smbios(4).
Sun, Jun 28, 2:37 PM
gbe committed rS362723: MFC r360493: Add a new manual page for unionfs(5).
MFC r360493: Add a new manual page for unionfs(5)
Sun, Jun 28, 2:23 PM
gbe committed rS362721: MFC r360459: Add a HISTORY section to domain(9)..
MFC r360459: Add a HISTORY section to domain(9).
Sun, Jun 28, 2:03 PM

Sat, Jun 27

gbe committed rS362702: MFC r339956 r362170: Add HISTORY sections to ZFS and dtrace manpages.
MFC r339956 r362170: Add HISTORY sections to ZFS and dtrace manpages
Sat, Jun 27, 5:39 PM
gbe committed rS362685: MFC r362326: fgetln(3): Add a Caveats Section.
MFC r362326: fgetln(3): Add a Caveats Section
Sat, Jun 27, 1:56 PM
gbe committed rS362683: MFC r362327: Add HISTORY sections to banner(6), basename(1), limits(1) and….
MFC r362327: Add HISTORY sections to banner(6), basename(1), limits(1) and…
Sat, Jun 27, 1:18 PM
gbe committed rS362682: MFC r362171: libc manpages: various improvements from NetBSD.
MFC r362171: libc manpages: various improvements from NetBSD
Sat, Jun 27, 12:13 PM
gbe requested review of D25358: Sync vis(1) with recent NetBSD sources.

@emaste like requested, this is a vendor import of the recent vis sources.

Sat, Jun 27, 7:32 AM

Fri, Jun 26

gbe committed rS362662: MFC r362169: libutil: Document function HISTORY within the manpages.
MFC r362169: libutil: Document function HISTORY within the manpages
Fri, Jun 26, 8:44 PM
gbe committed rS362659: MFC r362165: Add a HISTORY section to ctime(3).
MFC r362165: Add a HISTORY section to ctime(3)
Fri, Jun 26, 6:57 PM
gbe added a comment to D24293: Add orders(7) man page from netbsd.

@carlavilla thanks for turning the PR into a differential. Could you commit it? I am currently looking through my PR's and this one could be closed afterwards.

Fri, Jun 26, 6:19 PM

Tue, Jun 23

gbe requested review of D24651: unzip(1): Ignore malformed directory entries as created by Dropbox (/)..
Tue, Jun 23, 3:23 AM

Fri, Jun 19

gbe planned changes to D25358: Sync vis(1) with recent NetBSD sources.

Address the comments.

Fri, Jun 19, 12:21 PM
gbe updated the summary of D25358: Sync vis(1) with recent NetBSD sources.
Fri, Jun 19, 11:07 AM
gbe requested review of D25358: Sync vis(1) with recent NetBSD sources.
Fri, Jun 19, 11:06 AM

Thu, Jun 18

gbe abandoned D23893: Sync vis(1) with NetBSD.

@gbe indeed you can commit to src with approval from any src committer, however I noticed after that this code comes from vendor/NetBSD/vis, so we will want to import the update there and merge to contrib/

I'm happy to help you through the process if you're comfortable taking it on, but the process will change completely with the transition to git in a few months so I can just update there if you prefer.

Thu, Jun 18, 2:16 PM
gbe added a comment to D24916: Add Caveats Section to fgetln(3).
In D24916#558726, @bcr wrote:

You can always re-open the revision.
@0mp: Sure, Dq is better. Sorry I missed that, causing extra work.

Thu, Jun 18, 1:56 PM
gbe added a comment to D23893: Sync vis(1) with NetBSD.
In D23893#558720, @gbe wrote:

This differential is already approved. It would be very kind if a src committer could just commit it. :)

I think you can commit it with your doc bit with @emaste 's approval. :-)

Thu, Jun 18, 1:46 PM
gbe added a comment to D24916: Add Caveats Section to fgetln(3).

@0mp I see that you have put a lot of comments in already approved and committed differential. Could provide just a new differential with you comments applied to manpage? I wasn't aware of style.mdoc(5), definitely read it this afternoon.

Thu, Jun 18, 1:29 PM
D3390: improvements to kproc/kthread man pages now requires changes to proceed.
Thu, Jun 18, 1:24 PM
gbe added a reviewer for D23893: Sync vis(1) with NetBSD: Src Committers.

This differential is already approved. It would be very kind if a src committer could just commit it. :)

Thu, Jun 18, 1:22 PM
gbe closed D25019: Add HISTORY sections to banner(6), basename(1), limits(1) and vmstat(8).
Thu, Jun 18, 1:20 PM
gbe committed rS362327: Add HISTORY sections to banner(6), basename(1), limits(1) and vmstat(8).
Add HISTORY sections to banner(6), basename(1), limits(1) and vmstat(8)
Thu, Jun 18, 1:20 PM
gbe committed rS362326: fgetln(3): Add a Caveats Section.
fgetln(3): Add a Caveats Section
Thu, Jun 18, 1:13 PM
gbe closed D24916: Add Caveats Section to fgetln(3).
Thu, Jun 18, 1:13 PM
gbe accepted D25206: tee(1): Add EXAMPLES section.

LGTM!

Thu, Jun 18, 10:07 AM
gbe committed rS362274: ctime(3): Bump .Dd after r362165.
ctime(3): Bump .Dd after r362165
Thu, Jun 18, 9:25 AM

Tue, Jun 16

gbe committed rS362230: libcasper(3): Document HISTORY within the manpages.
libcasper(3): Document HISTORY within the manpages
Tue, Jun 16, 4:49 PM
gbe closed D24695: libcasper(3): Document HISTORY within the manpages.
Tue, Jun 16, 4:49 PM
gbe updated the diff for D25019: Add HISTORY sections to banner(6), basename(1), limits(1) and vmstat(8).
  • Fix typo
Tue, Jun 16, 5:57 AM

Sun, Jun 14

gbe committed rS362171: libc manpages: various improvements from NetBSD.
libc manpages: various improvements from NetBSD
Sun, Jun 14, 5:59 AM
gbe closed D24650: libc manpages: various improvements from NetBSD.
Sun, Jun 14, 5:59 AM
gbe closed D23833: Add HISTORY sections to ZFS and dtrace manpages.
Sun, Jun 14, 5:50 AM
gbe committed rS362170: Add HISTORY sections to ZFS and dtrace manpage.
Add HISTORY sections to ZFS and dtrace manpage
Sun, Jun 14, 5:50 AM
gbe added a comment to D24650: libc manpages: various improvements from NetBSD.

@bcr can this be committed?

Sun, Jun 14, 5:46 AM
gbe added a comment to D24916: Add Caveats Section to fgetln(3).

@bcr can this be committed?

Sun, Jun 14, 5:45 AM
gbe added a comment to D24695: libcasper(3): Document HISTORY within the manpages.

@bcr can this be committed?

Sun, Jun 14, 5:45 AM
gbe updated subscribers of D25019: Add HISTORY sections to banner(6), basename(1), limits(1) and vmstat(8).

@bcr could you review this one?

Sun, Jun 14, 5:43 AM
gbe committed rS362169: libutil: Document function HISTORY within the manpages.
libutil: Document function HISTORY within the manpages
Sun, Jun 14, 5:35 AM
gbe closed D24795: libutil: Document function HISTORY within the manpages.
Sun, Jun 14, 5:35 AM
gbe committed rS362165: Add a HISTORY section to ctime(3).
Add a HISTORY section to ctime(3)
Sun, Jun 14, 5:08 AM
gbe closed D24635: Add a HISTORY section to ctime(3).
Sun, Jun 14, 5:08 AM

Sat, Jun 13

gbe updated subscribers of D24795: libutil: Document function HISTORY within the manpages.

@bcr could you review this change?

Sat, Jun 13, 8:00 AM
gbe updated subscribers of D24650: libc manpages: various improvements from NetBSD.

@bcr could you review this change?

Sat, Jun 13, 8:00 AM
gbe added a comment to D23833: Add HISTORY sections to ZFS and dtrace manpages.

@bcr can this be committed? I would afterwards upstream this patch to the OpenSolaris folks, considering, they like HISTORY sections. ;-)

Sat, Jun 13, 7:59 AM
gbe added a comment to D25206: tee(1): Add EXAMPLES section.

Small grammar "enhancement". Otherwise, LGTM, and thanks for the patch! :)

Sat, Jun 13, 7:52 AM
gbe accepted D25240: sockstat(1): Add EXAMPLES to man page.

Very small grammar issues, otherwise, thanks for the patch! :)

Sat, Jun 13, 7:48 AM
gbe added a comment to D24635: Add a HISTORY section to ctime(3).

Can this be committed?

Sat, Jun 13, 7:18 AM
gbe added a comment to D25242: vis(1): Add EXAMPLES section.

Once https://reviews.freebsd.org/D23893 is committed you just have to rebase your differential. So we have the new examples section with the latest version of VIS. And after the commit, don't forget the sending your diff to the NetBSD folks. :)

Sat, Jun 13, 6:51 AM
gbe added a comment to D23893: Sync vis(1) with NetBSD.

OK

Sat, Jun 13, 6:48 AM

Fri, Jun 12

gbe closed D25241: Add myself (gbe) to committers-doc.dot and calendar.freebsd.
Fri, Jun 12, 9:34 AM
gbe committed rS362089: Add myself (gbe) to committers-doc.dot and calendar.freebsd.
Add myself (gbe) to committers-doc.dot and calendar.freebsd
Fri, Jun 12, 9:34 AM
gbe added a comment to D23893: Sync vis(1) with NetBSD.

Could someone review this one? There already changes to the vis manpage that depend on this one.

Fri, Jun 12, 8:12 AM
gbe added a comment to D25242: vis(1): Add EXAMPLES section.

I have an open differential https://reviews.freebsd.org/D23893 which synchronizes NetBSD changes with our version. Maybe our efforts can be joined. Could you try to integrate my differential first and then apply your manpage updates upon it?

Fri, Jun 12, 8:09 AM
gbe updated the diff for D25241: Add myself (gbe) to committers-doc.dot and calendar.freebsd.
  • Add missing \n
Fri, Jun 12, 7:49 AM
gbe requested review of D25241: Add myself (gbe) to committers-doc.dot and calendar.freebsd.
Fri, Jun 12, 7:11 AM

Thu, Jun 11

gbe added a comment to D24916: Add Caveats Section to fgetln(3).

Although there is nothing wrong with this per se, applications can deal with this problem more easily using getline(3) (which is also standard).

Thu, Jun 11, 9:50 PM
gbe updated the diff for D24916: Add Caveats Section to fgetln(3).
  • Add NULL pointer check for the while condition
Thu, Jun 11, 9:45 PM
gbe added inline comments to D24916: Add Caveats Section to fgetln(3).
Thu, Jun 11, 9:39 PM
gbe committed rD54245: Add my missing gpg key from r54244.
Add my missing gpg key from r54244
Thu, Jun 11, 8:15 PM
gbe closed D25199: Add myself (gbe) as doc committer.
Thu, Jun 11, 7:34 PM
gbe committed rD54244: Add myself (gbe) as doc committer.
Add myself (gbe) as doc committer
Thu, Jun 11, 7:34 PM
gbe updated the diff for D25199: Add myself (gbe) as doc committer.
Thu, Jun 11, 5:30 PM

Wed, Jun 10

gbe added a member for docs: gbe.
Wed, Jun 10, 2:54 PM
gbe added a member for manpages: gbe.
Wed, Jun 10, 2:53 PM
gbe updated the diff for D25199: Add myself (gbe) as doc committer.
  • Add news about me beeing a new committer
Wed, Jun 10, 11:55 AM
gbe requested review of D25199: Add myself (gbe) as doc committer.
Wed, Jun 10, 11:39 AM
gbe updated the diff for D25199: Add myself (gbe) as doc committer.
  • Fix identation, space instead of tabs
  • Add my (gbe) PGP key
Wed, Jun 10, 11:17 AM
bofh renamed gbe from gbergling_gmail.com to gbe.
Wed, Jun 10, 8:47 AM

Jun 4 2020

gbe added a comment to D23392: More Secure Permissions for /root.

This is a very small and quiet ping!

Jun 4 2020, 2:36 PM

Jun 3 2020

gbe added inline comments to D25082: [new port] games/lolcat, a high performance C implementation of the famous lolcat.
Jun 3 2020, 6:27 PM
gbe updated the diff for D25082: [new port] games/lolcat, a high performance C implementation of the famous lolcat.
  • Move DIST* make directives to the top and add a LICENSE block while here
Jun 3 2020, 6:27 PM
gbe added a comment to D25082: [new port] games/lolcat, a high performance C implementation of the famous lolcat.

Mark findings as done.

Jun 3 2020, 3:32 PM
gbe updated the diff for D25082: [new port] games/lolcat, a high performance C implementation of the famous lolcat.
  • Add changes from the tcberner's feedback
Jun 3 2020, 3:31 PM