Page MenuHomeFreeBSD

gbe (Gordon Bergling)
User

Projects

User Details

User Since
Jul 9 2019, 1:39 PM (73 w, 3 d)

Recent Activity

Today

gbe committed rS368348: ping(8): Fix a few mandoc related issues.
ping(8): Fix a few mandoc related issues
Fri, Dec 4, 8:48 PM

Fri, Nov 20

gbe committed rS367904: hostapd.conf(5): Add missing 'l'.
hostapd.conf(5): Add missing 'l'
Fri, Nov 20, 7:09 PM
gbe committed rS367902: crashinfo(8): Fix a few mandoc warnings.
crashinfo(8): Fix a few mandoc warnings
Fri, Nov 20, 7:09 PM
gbe committed rS367903: moused(8): Fix a few mandoc warnings.
moused(8): Fix a few mandoc warnings
Fri, Nov 20, 7:09 PM
gbe committed rS367901: hostapd.conf(5): Fix a mandoc warning.
hostapd.conf(5): Fix a mandoc warning
Fri, Nov 20, 7:09 PM
gbe committed rS367899: snmp_wlan(3): Fix mandoc warnings.
snmp_wlan(3): Fix mandoc warnings
Fri, Nov 20, 7:09 PM
gbe committed rS367900: syslog.conf(5): Fix a few mandoc warnings.
syslog.conf(5): Fix a few mandoc warnings
Fri, Nov 20, 7:09 PM
gbe committed rS367898: iscsi.conf(5): Fix a mandoc warning.
iscsi.conf(5): Fix a mandoc warning
Fri, Nov 20, 7:09 PM
gbe committed rS367897: devmatch(8): Fix section ordering.
devmatch(8): Fix section ordering
Fri, Nov 20, 7:09 PM
gbe committed rS367889: camcontrol(8): Fix some warnings spotted by mandoc.
camcontrol(8): Fix some warnings spotted by mandoc
Fri, Nov 20, 11:45 AM

Thu, Nov 19

gbe added a comment to D26137: Wireguard merge.

Wouldn't it be better to commit this to -CURRENT and start over later on?

Thu, Nov 19, 6:17 PM
gbe accepted D25114: Add entry in rtwn_usb(4) for TP-Link Archer T2U Plus.
Thu, Nov 19, 4:36 PM
gbe accepted D26241: update exports.5 to include information on the TLS export options.
Thu, Nov 19, 4:36 PM
gbe added reviewers for D26654: Support immutable motd when /var/run is tmpfs: imp, cem.

Ok from the man page perspective. Adding Warner and Conrad, since they have done the latest changes to the motd.

Thu, Nov 19, 4:34 PM
gbe added inline comments to D27285: Add freebsd-office-hours-2020-12-03 event.
Thu, Nov 19, 4:08 PM
gbe added a comment to D25447: /usr/libexec/flua: Add bindings for libifconfig.

From the first look the man page should be fine. Did you run igor and mandoc -Tlint against it?

Thu, Nov 19, 4:03 PM
gbe accepted D22076: netgraph/ng_vlan_rotate: IEEE 802.1ad VLAN manipulation netgraph node type (new type).

LGTM.

Thu, Nov 19, 3:59 PM
gbe added a comment to D24617: Add additional EINVAL information about wrong block size to read(2)/write(2).

Should be okay. Did you have any opinion about the comments from @danfe ?

Thu, Nov 19, 3:55 PM
gbe accepted D26208: sleep(1) fractional seconds not so risky.

OK from man pages. If the mentioned extension is existing in the GNU version, the portability should be that worse.

Thu, Nov 19, 3:52 PM
gbe accepted D26949: fstat(1): Add EXAMPLES section.

OK from manpages . Thanks for adding this example section to the manpage.

Thu, Nov 19, 3:32 PM
gbe added a comment to D24832: libcasper: Create a minimal cap_netdb service.

Small nit for the copyright section of the man page.

Thu, Nov 19, 3:25 PM · capsicum
gbe accepted D26262: Document the "tls" mount_nfs option..

OK from man pages. It would be great if the correct RFC could be mentioned once it has its number.

Thu, Nov 19, 3:19 PM
gbe added a comment to D26928: Add atf-lua, a lua analog to atf-sh(1) and atf-sh(3).

Ok from the man page perspective. Did you checked the man pages via igor and mandoc -Tlint?

Thu, Nov 19, 3:18 PM
gbe accepted D27277: Handbook:12.2.3 Fix load example.

Show be correct. But I haven't seen seen a /boot/GENERIC directory on -STABLE, 12.2-RELEASE or -CURRENT system.

Thu, Nov 19, 3:09 PM
gbe added a comment to D27272: Add a manpage for kernel TLS..

@jhb did you run the obligatory igor and mandoc -Tlint checks?

Thu, Nov 19, 2:45 PM

Sun, Nov 15

gbe added a comment to D27228: Note slight difference between strlcpy and snprintf return values.

Should be fine. Maybe a separate CAVEATS section would be more suitable for this kind of note.

Sun, Nov 15, 8:33 PM
gbe added reviewers for D27221: ipfw(8): Improve divert, forward and addr descriptions: ae, melifaro.

@ae and @melifaro could you verify that this man page update is correct in terms of functionality?

Sun, Nov 15, 12:52 PM

Sat, Nov 14

gbe requested review of D27221: ipfw(8): Improve divert, forward and addr descriptions.
Sat, Nov 14, 11:38 PM
gbe added a comment to D27216: Add HISTORY sections for pthread(3) functions.

A pthread implementation "libc_r" was already added in 2.2-release, which contained most of these functions.

Sat, Nov 14, 7:58 PM
gbe committed rS367679: MFC r366580: bpf(4): Update the man page to reflect reality.
MFC r366580: bpf(4): Update the man page to reflect reality
Sat, Nov 14, 2:15 PM
gbe added a comment to D27216: Add HISTORY sections for pthread(3) functions.

@bcr thanks for spotting this, the typo is fixed.

Sat, Nov 14, 1:37 PM
gbe updated the diff for D27216: Add HISTORY sections for pthread(3) functions.
  • pthread_cond_wait(3): Fix a typo
Sat, Nov 14, 1:34 PM
gbe requested review of D27216: Add HISTORY sections for pthread(3) functions.
Sat, Nov 14, 12:49 PM

Tue, Nov 10

gbe added a comment to D25358: Sync vis(1) with recent NetBSD sources.

@emaste is there anything I can do to get this committed?

Tue, Nov 10, 10:43 AM
gbe added a comment to D21377: ping: merge ping6 to ping.

Thanks for reminding me, @gbe . I think I'll have time to work on this on Halloween weekend. Feel free to remind me if I haven't done anything by November.

Tue, Nov 10, 9:32 AM

Oct 31 2020

gbe committed rS367202: MFC r366946: socket(9): Remove duplicate word 'is is'.
MFC r366946: socket(9): Remove duplicate word 'is is'
Oct 31 2020, 12:39 PM
gbe committed rS367201: MFC r367091: Use my FreeBSD.org mail address in man pages I have written.
MFC r367091: Use my FreeBSD.org mail address in man pages I have written
Oct 31 2020, 12:37 PM
gbe committed rS367200: MFC r359731: Add a basic manpage for smbfs(5).
MFC r359731: Add a basic manpage for smbfs(5)
Oct 31 2020, 12:36 PM
gbe committed rS367198: MFC r359608, r359611.
MFC r359608, r359611
Oct 31 2020, 12:05 PM
gbe committed rS367197: MFC r358891, r358894, r359454, r359513, r359550 and r359556.
MFC r358891, r358894, r359454, r359513, r359550 and r359556
Oct 31 2020, 11:57 AM

Oct 27 2020

gbe committed rS367091: Use my FreeBSD.org mail address in man pages I have written.
Use my FreeBSD.org mail address in man pages I have written
Oct 27 2020, 6:31 PM
gbe accepted D26980: Drop "All rights reserved" from all my stuff.

OK from manpages

Oct 27 2020, 5:52 PM

Oct 25 2020

gbe added a comment to D23572: Update OpenBSM constants with recent additions by Apple.

@csjp I created the following PR for further reference, https://github.com/openbsm/openbsm/pull/69 .

Oct 25 2020, 5:46 PM
gbe added a comment to D23572: Update OpenBSM constants with recent additions by Apple.

@csjp thanks for picking this up. Will you submit a PR, or should I do it?

Oct 25 2020, 8:31 AM

Oct 24 2020

gbe added a comment to D23572: Update OpenBSM constants with recent additions by Apple.

ping?

Oct 24 2020, 7:01 AM

Oct 23 2020

gbe added a comment to D21377: ping: merge ping6 to ping.

Is there any interest to get this into -CURRENT?

Oct 23 2020, 1:24 PM

Oct 22 2020

gbe committed rS366949: stablerestart(5): Fix some issues reported by mandoc.
stablerestart(5): Fix some issues reported by mandoc
Oct 22 2020, 7:25 PM
gbe committed rS366947: pnfsserver(4): Fix some issues reported by mandoc.
pnfsserver(4): Fix some issues reported by mandoc
Oct 22 2020, 7:19 PM
gbe committed rS366946: socket(9): Remove duplicate word 'is is'.
socket(9): Remove duplicate word 'is is'
Oct 22 2020, 6:46 PM
gbe accepted D24813: Corestop..

OK from manpages.

Oct 22 2020, 3:39 PM
gbe accepted D26700: ctl.conf(5): add support for an 'include' directive..

OK from manpages.

Oct 22 2020, 3:37 PM

Oct 21 2020

gbe accepted D26864: col(1): Add EXAMPLES section.

You could also include the vim example after @bcr comment states that it would be okay.

Oct 21 2020, 8:21 AM

Oct 20 2020

gbe committed rS366891: MFC r366481: intro(3): Update the list of included libraries.
MFC r366481: intro(3): Update the list of included libraries
Oct 20 2020, 9:51 AM
gbe accepted D26866: getent(1): Add EXAMPLES section.

LGTM! Thanks for addressing my comments.

Oct 20 2020, 9:26 AM
gbe updated subscribers of D26864: col(1): Add EXAMPLES section.

@bcr would it be okay to use a ports application in a manual page from base?

Oct 20 2020, 9:24 AM
gbe accepted D26862: pwd(1): Add EXAMPLES section.

LGTM!

Oct 20 2020, 9:18 AM

Oct 19 2020

gbe added a comment to D26866: getent(1): Add EXAMPLES section.

Just one small nit in the last example, otherwise LGTM.

Oct 19 2020, 9:58 PM
gbe accepted D26863: realpath(1): Add EXAMPLES section..

LGTM

Oct 19 2020, 7:26 PM
gbe accepted D26865: compress(1): Add EXAMPLES section.

LGTM, besides a small nit.

Oct 19 2020, 7:20 PM
gbe added a comment to D26864: col(1): Add EXAMPLES section.

Some small nits, otherwise LGTM. Thanks for working on the EXAMPLE sections. :)

Oct 19 2020, 7:08 PM
gbe added a comment to D26862: pwd(1): Add EXAMPLES section.

LGTM, but how do you know that pwd is using file(1) for the logical current directory?

Oct 19 2020, 7:01 PM

Oct 17 2020

gbe committed rS366790: MFC r366611: cpuset(1): Fix a typo.
MFC r366611: cpuset(1): Fix a typo
Oct 17 2020, 9:51 AM
gbe committed rS366789: MFC r366610: sigevent(3): Fix a typo.
MFC r366610: sigevent(3): Fix a typo
Oct 17 2020, 9:50 AM
gbe committed rS366788: MFC r366617: pnfsdsfile(8): Remove dublicate word 'the'.
MFC r366617: pnfsdsfile(8): Remove dublicate word 'the'
Oct 17 2020, 9:49 AM
gbe committed rS366787: MFC r366609: dtrace_audit(4): Fix a typo.
MFC r366609: dtrace_audit(4): Fix a typo
Oct 17 2020, 9:48 AM
gbe committed rS366786: MFC r366616: cxgbetool(8): Remove dublicate word 'whether'.
MFC r366616: cxgbetool(8): Remove dublicate word 'whether'
Oct 17 2020, 9:45 AM

Oct 14 2020

gbe added a comment to D26726: Add support for asynchrous file system operations to aio.

Some man pages nits.

Oct 14 2020, 10:49 AM

Oct 12 2020

gbe committed rS366630: MFC r366613: ls(1): Use \& as an escape character for the ',' option.
MFC r366613: ls(1): Use \& as an escape character for the ',' option
Oct 12 2020, 8:43 AM

Oct 10 2020

gbe accepted D23450: libalias: Allow setting alias port ranges.

LGTM.

Oct 10 2020, 5:11 PM
gbe committed rS366617: pnfsdsfile(8): Remove dublicate word 'the'.
pnfsdsfile(8): Remove dublicate word 'the'
Oct 10 2020, 2:38 PM
gbe committed rS366616: cxgbetool(8): Remove dublicate word 'whether'.
cxgbetool(8): Remove dublicate word 'whether'
Oct 10 2020, 2:36 PM
gbe committed rS366615: man5: Fix a few typos spotted by igor.
man5: Fix a few typos spotted by igor
Oct 10 2020, 2:20 PM
gbe committed rS366613: ls(1): Use \& as an escape character for the ',' option.
ls(1): Use \& as an escape character for the ',' option
Oct 10 2020, 1:39 PM
gbe committed rS366611: cpuset(1): Fix a typo.
cpuset(1): Fix a typo
Oct 10 2020, 1:01 PM
gbe committed rS366610: sigevent(3): Fix a typo.
sigevent(3): Fix a typo
Oct 10 2020, 12:07 PM
gbe committed rS366609: dtrace_audit(4): Fix a typo.
dtrace_audit(4): Fix a typo
Oct 10 2020, 12:06 PM
gbe committed rS366608: MFC r366407, r366403.
MFC r366407, r366403
Oct 10 2020, 9:52 AM
gbe committed rS366607: MFC r366408, r366410, r366405.
MFC r366408, r366410, r366405
Oct 10 2020, 9:50 AM
gbe committed rS366606: MFC r366411: gvinum(8): Fix an issue reported by mandoc.
MFC r366411: gvinum(8): Fix an issue reported by mandoc
Oct 10 2020, 9:45 AM
gbe committed rS366605: MFC 366404: cp(1): Bugfixes for some issues reported by mandoc.
MFC 366404: cp(1): Bugfixes for some issues reported by mandoc
Oct 10 2020, 9:43 AM
gbe committed rS366604: MFC r366409: veriexec(8): Bugfix for an issue reported by mandoc.
MFC r366409: veriexec(8): Bugfix for an issue reported by mandoc
Oct 10 2020, 9:42 AM
gbe committed rS366603: MFC r366406: camcontrol(8): Bugfixes for some issues reported by mandoc.
MFC r366406: camcontrol(8): Bugfixes for some issues reported by mandoc
Oct 10 2020, 9:41 AM
gbe committed rS366602: MFC r366414: cpuset(1): Fix some issues reported by mandoc.
MFC r366414: cpuset(1): Fix some issues reported by mandoc
Oct 10 2020, 9:40 AM

Oct 9 2020

gbe committed rS366583: Fix a few mandoc issues.
Fix a few mandoc issues
Oct 9 2020, 7:13 PM
gbe closed D25993: bpf(4): Update the manual page to reflect reality.
Oct 9 2020, 3:51 PM
gbe committed rS366580: bpf(4): Update the man page to reflect reality.
bpf(4): Update the man page to reflect reality
Oct 9 2020, 3:51 PM
gbe committed rS366575: Fix a few mandoc issues.
Fix a few mandoc issues
Oct 9 2020, 3:14 PM
gbe committed rS366572: Fix a few mandoc issues.
Fix a few mandoc issues
Oct 9 2020, 2:04 PM
gbe added a comment to D23572: Update OpenBSM constants with recent additions by Apple.

@emaste @rwatson Could you review this differential, and would it be okay if I commit this?

Oct 9 2020, 7:47 AM
gbe added a comment to D25993: bpf(4): Update the manual page to reflect reality.

Could someone review the differential?

Oct 9 2020, 7:45 AM
gbe added a comment to D25358: Sync vis(1) with recent NetBSD sources.

@emaste ping?

Oct 9 2020, 7:44 AM
gbe updated the diff for D26719: setkey(8): Improve directions descriptions.
  • Correct the date
Oct 9 2020, 5:32 AM
gbe updated the diff for D26719: setkey(8): Improve directions descriptions.
  • Bump man page date and remove an whitespace at the end of line
Oct 9 2020, 5:29 AM
gbe requested review of D26719: setkey(8): Improve directions descriptions.
Oct 9 2020, 5:27 AM

Oct 8 2020

gbe accepted D25631: periodic script to create backup of gmirror information.

LGTM, since all previous comments regarding man page issues are addressed.

Oct 8 2020, 2:55 PM
gbe accepted D22076: netgraph/ng_vlan_rotate: IEEE 802.1ad VLAN manipulation netgraph node type (new type).

LGTM

Oct 8 2020, 2:53 PM
gbe accepted D3343: Add "Logical Block Mode" to geom multipath.

LGTM, but the comments of @wblock should be addressed first.

Oct 8 2020, 2:53 PM

Oct 7 2020

gbe accepted D26146: ul(1): Remove references to colcrt(1) and nroff(1).

Thanks addressing my feedback!

Oct 7 2020, 1:35 PM
gbe updated subscribers of D26146: ul(1): Remove references to colcrt(1) and nroff(1).
In D26146#580584, @gbe wrote:

Thanks for taking responsibility for this PR.

nroff(1) still exists in base, colcrt(1) doesn't not. Please adapt the diff accordingly.

--Gordon

Thanks for the feedback, Gordon.

I can't find nroff(1) in my CURRENT machine:

[fernape@vm-current ~]$ find / -name nroff 2>/dev/null
uname -a
[fernape@vm-current ~]$ uname -a
FreeBSD vm-current 13.0-CURRENT FreeBSD 13.0-CURRENT #2 r364141: Wed Aug 12 14:46:01 CEST 2020     root@vm-current:/usr/obj/usr/src/amd64.amd64/sys/GENERIC  amd64
[fernape@vm-current ~]$ whereis nroff
nroff:
[fernape@vm-current ~]$

Hi again Gordon!

Having a look at /usr/bin/man I see the pipeline can be built to use either mandoc or a flavor of roff. The two possible flavors are:

NROFF='groff -S -P-h -Wall -mtty-char -man'
TROFF='groff -S -man'

So both of them are groff. But groff is not in base. In fact, there is this message in /usr/bin/man:

echo "This manpage needs groff(1) to be rendered" >&2
echo "First install groff(1): " >&2
echo "pkg install groff " >&2

It seems by default we are using mandoc which is in base:

pipeline="mandoc $mandoc_args | $MANPAGER"

Either way, it is weird that we reference nroff(1) in the SEE ALSO section but then we can not see the manual page:

[fernape@vm-current ~]$ man nroff
No manual entry for nroff
[fernape@vm-current ~]$ man 1 nroff
No manual entry for nroff
[fernape@vm-current ~]$

Thanks a lot for helping!

Oct 7 2020, 1:04 PM

Oct 6 2020

gbe closed D26476: Update manpage for intro(3).
Oct 6 2020, 10:52 AM