- User Since
- Jul 9 2019, 1:39 PM (73 w, 3 d)
Fri, Nov 20
Thu, Nov 19
Wouldn't it be better to commit this to -CURRENT and start over later on?
Ok from the man page perspective. Adding Warner and Conrad, since they have done the latest changes to the motd.
From the first look the man page should be fine. Did you run igor and mandoc -Tlint against it?
Should be okay. Did you have any opinion about the comments from @danfe ?
OK from man pages. If the mentioned extension is existing in the GNU version, the portability should be that worse.
OK from manpages . Thanks for adding this example section to the manpage.
Small nit for the copyright section of the man page.
OK from man pages. It would be great if the correct RFC could be mentioned once it has its number.
Ok from the man page perspective. Did you checked the man pages via igor and mandoc -Tlint?
Show be correct. But I haven't seen seen a /boot/GENERIC directory on -STABLE, 12.2-RELEASE or -CURRENT system.
@jhb did you run the obligatory igor and mandoc -Tlint checks?
Sun, Nov 15
Should be fine. Maybe a separate CAVEATS section would be more suitable for this kind of note.
Sat, Nov 14
@bcr thanks for spotting this, the typo is fixed.
- pthread_cond_wait(3): Fix a typo
Tue, Nov 10
@emaste is there anything I can do to get this committed?
Oct 31 2020
Oct 27 2020
OK from manpages
Oct 25 2020
@csjp thanks for picking this up. Will you submit a PR, or should I do it?
Oct 24 2020
Oct 23 2020
Is there any interest to get this into -CURRENT?
Oct 22 2020
OK from manpages.
Oct 21 2020
You could also include the vim example after @bcr comment states that it would be okay.
Oct 20 2020
LGTM! Thanks for addressing my comments.
@bcr would it be okay to use a ports application in a manual page from base?
Oct 19 2020
Just one small nit in the last example, otherwise LGTM.
LGTM, besides a small nit.
Some small nits, otherwise LGTM. Thanks for working on the EXAMPLE sections. :)
LGTM, but how do you know that pwd is using file(1) for the logical current directory?
Oct 17 2020
Oct 14 2020
Some man pages nits.
Oct 12 2020
Oct 10 2020
Oct 9 2020
Could someone review the differential?
- Correct the date
- Bump man page date and remove an whitespace at the end of line
Oct 8 2020
LGTM, since all previous comments regarding man page issues are addressed.
LGTM, but the comments of @wblock should be addressed first.
Oct 7 2020
Thanks addressing my feedback!