Page MenuHomeFreeBSD
Feed Advanced Search

Tue, Jul 20

gbe accepted D31230: init: execute /etc/rc.final after all user processes have terminated.

LGTM for the man page part.

Tue, Jul 20, 11:52 AM

Mon, Jul 19

gbe committed R10:b5d786b26894: pmc(3): mandoc clean ups (authored by gbe).
pmc(3): mandoc clean ups
Mon, Jul 19, 6:20 AM
gbe committed R10:af3367398454: pmc(3): mandoc clean ups (authored by gbe).
pmc(3): mandoc clean ups
Mon, Jul 19, 6:18 AM
gbe committed R10:0054c0afb770: libcasper(3): Correct some warnings found by mandoc (authored by gbe).
libcasper(3): Correct some warnings found by mandoc
Mon, Jul 19, 6:17 AM
gbe committed R10:2800c163f083: nfsd: Fix some issues found by mandoc (authored by gbe).
nfsd: Fix some issues found by mandoc
Mon, Jul 19, 6:17 AM

Thu, Jul 15

gbe added a comment to D31146: cron: Implement -s command option.

The man page part looks good, but I am a little bit confused, on my FreeBSD systems I see

Thu, Jul 15, 5:31 AM

Wed, Jul 14

gbe accepted D29754: Augment systat(1) -swap to display large swap space processes.

OK for the man page part, since all comments are addressed.

Wed, Jul 14, 11:28 AM

Tue, Jul 13

gbe added a comment to D31150: MANA NIC driver.

Thanks for contributing this driver. Is possible to test it already on Hyper-V, or Azure?

Tue, Jul 13, 1:24 PM
gbe committed R10:331d4f3c0779: igc(4): Correct the man page section (authored by trond.endrestol_ximalas.info).
igc(4): Correct the man page section
Tue, Jul 13, 1:18 PM

Mon, Jul 12

gbe committed R10:4c87085d3521: nfsd: Fix some issues found by mandoc (authored by gbe).
nfsd: Fix some issues found by mandoc
Mon, Jul 12, 4:33 AM
gbe closed D31145: nfsd: Fix some issues found by mandoc.
Mon, Jul 12, 4:33 AM
gbe committed R10:0b1293252543: pmc(3): mandoc clean ups (authored by gbe).
pmc(3): mandoc clean ups
Mon, Jul 12, 4:30 AM
gbe closed D31143: pmc(3): mandoc clean ups.
Mon, Jul 12, 4:29 AM
gbe committed R10:3251ad29f429: libcasper(3): Correct some warnings found by mandoc (authored by gbe).
libcasper(3): Correct some warnings found by mandoc
Mon, Jul 12, 4:19 AM
gbe closed D31144: libcasper(3): Correct some warnings found by mandoc.
Mon, Jul 12, 4:19 AM
gbe committed R10:9428c3c912db: math(3): Use the .Fa macro for function arguments (authored by gbe).
math(3): Use the .Fa macro for function arguments
Mon, Jul 12, 4:08 AM

Sun, Jul 11

gbe committed R10:5aa1e55b0ae7: hwpmc(4): Fix a typo in the man page date (authored by gbe).
hwpmc(4): Fix a typo in the man page date
Sun, Jul 11, 12:54 PM
gbe requested review of D31145: nfsd: Fix some issues found by mandoc.
Sun, Jul 11, 12:42 PM
gbe requested review of D31144: libcasper(3): Correct some warnings found by mandoc.
Sun, Jul 11, 12:19 PM
gbe requested review of D31143: pmc(3): mandoc clean ups.
Sun, Jul 11, 11:13 AM
gbe accepted D29917: BeFS support for fstyp command.

LGTM for the man page part.

Sun, Jul 11, 6:57 AM
gbe added a comment to D30837: Correct HISTORY section of basename(1).

I think this differential can be closed, since the HISTORY section was corrected with f394c73666ba375cbd6114950b1b1ea5943185a8.

Sun, Jul 11, 6:53 AM
gbe added a comment to D31126: vget(9): update after r364271.

Just one small nit, otherwise LGTM.

Sun, Jul 11, 6:51 AM
gbe accepted D31135: add information on the "nconnect" mount option to the man page.

LGTM

Sun, Jul 11, 6:47 AM
gbe accepted D30330: rc.conf(5): Add _limits, _loginclass, and _oomprotect.

LGTM, since all previously comments are addressed.

Sun, Jul 11, 6:42 AM

Fri, Jul 9

gbe committed R10:c5cbef2f85e6: math(3): Use the .Fa macro for function arguments (authored by gbe).
math(3): Use the .Fa macro for function arguments
Fri, Jul 9, 5:57 PM
gbe closed D31090: math(3): function args must not use .Ar, use .Fa instead.
Fri, Jul 9, 5:56 PM

Wed, Jul 7

gbe requested review of D31090: math(3): function args must not use .Ar, use .Fa instead.
Wed, Jul 7, 11:53 AM

Jul 1 2021

gbe accepted D30815: hz.9: update stathz for current usage.

LGTM

Jul 1 2021, 3:17 PM

Jun 6 2021

gbe accepted D30546: Install the linux(4) man page also for aarch64.

LGTM

Jun 6 2021, 1:18 PM

Jun 2 2021

gbe committed R10:999b023cc786: iwn(4): Remove duplicate device entry (authored by gbe).
iwn(4): Remove duplicate device entry
Jun 2 2021, 6:27 AM
gbe committed R10:849fdb8d7d4c: iwn(4): Remove duplicate device entry (authored by gbe).
iwn(4): Remove duplicate device entry
Jun 2 2021, 6:27 AM

Jun 1 2021

gbe committed R10:e303e19dfc0d: DRIVER_MODULE(9): Correct the SYNOPSIS of EARLY_DRIVER_MODULE() (authored by fbsd_opal.com).
DRIVER_MODULE(9): Correct the SYNOPSIS of EARLY_DRIVER_MODULE()
Jun 1 2021, 5:35 AM
gbe committed R10:fe0ff38bf157: DRIVER_MODULE(9): Correct the SYNOPSIS of EARLY_DRIVER_MODULE() (authored by fbsd_opal.com).
DRIVER_MODULE(9): Correct the SYNOPSIS of EARLY_DRIVER_MODULE()
Jun 1 2021, 5:34 AM

May 30 2021

gbe committed R10:66e2a5803b0f: iwn(4): Remove duplicate device entry (authored by gbe).
iwn(4): Remove duplicate device entry
May 30 2021, 1:45 PM

May 29 2021

gbe accepted D30442: mprotect.2: Update text for largepages.

LGTM

May 29 2021, 4:22 PM
gbe accepted D30464: sh: Add -o verify to use O_VERIFY when sourcing scripts.

OK, for the man page part.

May 29 2021, 4:21 PM
gbe added a reviewer for D30498: Fix syscall kld example: jilles.

Should be fine, but since it is a src change I added @jilles for src review and approval.

May 29 2021, 4:19 PM

May 24 2021

gbe closed D30411: DRIVER_MODULE(9): Correct the SYNOPSIS of EARLY_DRIVER_MODULE().
May 24 2021, 2:58 PM
gbe committed R10:3fdd5c1e49cb: DRIVER_MODULE(9): Correct the SYNOPSIS of EARLY_DRIVER_MODULE() (authored by fbsd_opal.com).
DRIVER_MODULE(9): Correct the SYNOPSIS of EARLY_DRIVER_MODULE()
May 24 2021, 2:58 PM
gbe retitled D30411: DRIVER_MODULE(9): Correct the SYNOPSIS of EARLY_DRIVER_MODULE() from DRIVER_MODULE(9): Correct the SYNOPSIS of EARLY_DRIVER_MODULE()) to DRIVER_MODULE(9): Correct the SYNOPSIS of EARLY_DRIVER_MODULE().
May 24 2021, 12:23 PM
gbe requested review of D30411: DRIVER_MODULE(9): Correct the SYNOPSIS of EARLY_DRIVER_MODULE().
May 24 2021, 12:20 PM

May 16 2021

gbe committed R10:ed5c8820f478: find(1): Document the -f option (authored by ceri).
find(1): Document the -f option
May 16 2021, 8:39 AM
gbe committed R10:3f5f4078b371: find(1): Document the -f option (authored by ceri).
find(1): Document the -f option
May 16 2021, 8:38 AM

May 13 2021

gbe accepted D30188: [patch] syslog.3 - LOG_PID cannot be disabled.

@gbe are we good to go?

May 13 2021, 2:19 PM
gbe accepted D30240: Reference CC modules consistently.

LGTM, thanks for keeping the manual pages in sync.

May 13 2021, 9:31 AM
gbe committed R10:82483ea7adfe: find(1): Document the -f option (authored by ceri).
find(1): Document the -f option
May 13 2021, 8:14 AM
gbe closed D30215: find(1): Document the -f option.
May 13 2021, 8:14 AM
gbe closed D30232: Remove references to timed(8).
May 13 2021, 7:58 AM
gbe committed R10:1760799b4c61: Remove references to timed(8) (authored by ceri).
Remove references to timed(8)
May 13 2021, 7:57 AM
gbe accepted D30232: Remove references to timed(8).

LGTM

May 13 2021, 5:42 AM

May 12 2021

gbe committed R10:d99e1e90e9b2: full(4): Use correct section name for AUTHORS (authored by gbe).
full(4): Use correct section name for AUTHORS
May 12 2021, 8:17 AM
gbe committed R10:699e490dfc21: full(4): Use correct section name for AUTHORS (authored by gbe).
full(4): Use correct section name for AUTHORS
May 12 2021, 8:16 AM

May 11 2021

gbe requested review of D30215: find(1): Document the -f option.
May 11 2021, 3:08 PM
gbe accepted D30191: ipfw.8: Fix table example.
May 11 2021, 2:56 PM
gbe accepted D30188: [patch] syslog.3 - LOG_PID cannot be disabled.

OK, for the manpage side of things, but I am not sure if this is true, since the code fragment from libc doesn't point out that this option can't be disabled?

May 11 2021, 2:55 PM

May 9 2021

gbe committed R10:416051f5818e: full(4): Use correct section name for AUTHORS (authored by gbe).
full(4): Use correct section name for AUTHORS
May 9 2021, 3:35 PM

May 8 2021

gbe committed R10:0da5e909e9c9: release.7: update for current context (authored by emaste).
release.7: update for current context
May 8 2021, 4:50 AM

Apr 24 2021

gbe accepted D29963: tcp: fix man page.
Apr 24 2021, 6:00 PM

Apr 22 2021

gbe accepted D28931: Basic Lost Retransmission Detection (LRD).

OK for the man page part.

Apr 22 2021, 6:31 PM
gbe added a comment to D29924: stats.7: Add dwatch(1) to the list.
In D29924#671479, @0mp wrote:

Just a note, ctlstat seems to be missing from the SEE ALSO section. That could be another commit.

OK, I'll do it in a separate commit.

Also, could you MFC that? To 13.0 at least (I am not sure if other branches have stats(7)).

Sure. 12.2 has stats(7) too. But maybe MFC to 13 would be enough?

Apr 22 2021, 5:39 PM

Apr 18 2021

gbe accepted D26652: Implement SO_RERROR.

LGTM for the man page part.

Apr 18 2021, 11:25 AM
gbe accepted D27194: Add vnode_pager_purge_range(9) KPI.

LGTM for the man page part.

Apr 18 2021, 11:22 AM
gbe added a comment to D28255: Add some more non-portable acl_* functions..

Two small nits on the man pages, otherwise LGTM.

Apr 18 2021, 11:14 AM
gbe accepted D28347: Add fspacectl(2), vn_deallocate(9) and VOP_DEALLOCATE(9)..

LGTM for the man page part.

Apr 18 2021, 8:55 AM
gbe accepted D29343: flopen: simplify the code.

LGTM

Apr 18 2021, 8:53 AM

Apr 17 2021

gbe committed R10:53c0fd84096c: ossl(4): Install the man page also for arm64 (authored by gbe).
ossl(4): Install the man page also for arm64
Apr 17 2021, 5:56 AM

Apr 16 2021

gbe added a comment to D29724: [phb]: Fix poudriere ports tree creation instructions.
In D29724#668396, @gbe wrote:

LGTM for the documentation change, but I am not so deep into poudriere stuff.

Hi Gordon,

Thanks for the review. I'm pretty positive of the change, but if you feel more comfortable I can bring another pair of eyes from a ports committer to validate the change, or we can ask @0mp since he is a ports committer too.

Apr 16 2021, 4:59 PM
gbe accepted D29788: kern: ether_gen_addr: randomize on default hostuuid, too.

LGTM from manpages.

Apr 16 2021, 4:56 PM
gbe accepted D29724: [phb]: Fix poudriere ports tree creation instructions.

LGTM for the documentation change, but I am not so deep into poudriere stuff.

Apr 16 2021, 4:51 PM
gbe committed R10:9cfb2dfada93: config(8): Mention the authors of a paper in the SEE ALSO section (authored by gbe).
config(8): Mention the authors of a paper in the SEE ALSO section
Apr 16 2021, 2:30 PM
gbe committed R10:7e55fdf88bce: lpd(8): Mention the author of a paper in the SEE ALSO section (authored by gbe).
lpd(8): Mention the author of a paper in the SEE ALSO section
Apr 16 2021, 2:29 PM
gbe committed R10:ddb7a5056f25: ed(1): Add two references in the SEE ALSO section (authored by gbe).
ed(1): Add two references in the SEE ALSO section
Apr 16 2021, 2:26 PM
gbe committed R10:cd1729e8b69f: lpd(8): Mention the author of a paper in the SEE ALSO section (authored by gbe).
lpd(8): Mention the author of a paper in the SEE ALSO section
Apr 16 2021, 2:26 PM
gbe committed R10:e981fc617700: config(8): Mention the authors of a paper in the SEE ALSO section (authored by gbe).
config(8): Mention the authors of a paper in the SEE ALSO section
Apr 16 2021, 2:26 PM

Apr 15 2021

gbe committed R10:732f3191b4af: m4(1): Add a SEE ALSO section and reference an AT&T manual (authored by gbe).
m4(1): Add a SEE ALSO section and reference an AT&T manual
Apr 15 2021, 12:46 PM
gbe committed R10:f2950759b88d: m4(1): Add a SEE ALSO section and reference an AT&T manual (authored by gbe).
m4(1): Add a SEE ALSO section and reference an AT&T manual
Apr 15 2021, 12:44 PM
gbe committed R10:1d51d41519f3: sed(1): Add a reference for a 4.4BSD manual document (authored by gbe).
sed(1): Add a reference for a 4.4BSD manual document
Apr 15 2021, 12:44 PM

Apr 14 2021

gbe added a reverting change for R10:e6ab1e365c06: config(8): Correct the mentioned paper in the SEE ALSO section: R10:c8786bba8ebb: Revert "config(8): Correct the mentioned paper in the SEE ALSO section".
Apr 14 2021, 6:26 PM
gbe added a reverting change for D29701: config(8): Correct the mentioned paper in the SEE ALSO section: R10:c8786bba8ebb: Revert "config(8): Correct the mentioned paper in the SEE ALSO section".
Apr 14 2021, 6:26 PM
gbe committed R10:c8786bba8ebb: Revert "config(8): Correct the mentioned paper in the SEE ALSO section" (authored by gbe).
Revert "config(8): Correct the mentioned paper in the SEE ALSO section"
Apr 14 2021, 6:26 PM
gbe committed R10:b1ab802ce490: ossl(4): Install the man page also for arm64 (authored by gbe).
ossl(4): Install the man page also for arm64
Apr 14 2021, 4:36 PM
gbe closed D29762: ossl(4): Install the man page also for arm64.
Apr 14 2021, 4:36 PM
gbe added a comment to D29762: ossl(4): Install the man page also for arm64.
In D29762#667531, @gbe wrote:

Thanks for catching this. I believe we generally prefer one block checking the supported MACHINE_CPUARCH values, like the _cgem.4 example below. Both styles are imperfect however.

I would have reused this block, but ossl(4) doesn't support arm or riscv. If this doesn't matter, I could adapt the differential.

Sorry, I mean add a new block that checks for aarch64, amd64, or i386. Then, move the existing assignment to _ossl.4 to this new block.

Apr 14 2021, 4:13 PM
gbe updated the diff for D29762: ossl(4): Install the man page also for arm64.
  • Consolidate the MACHINE_CPUARCH block for ossl(4) man page
Apr 14 2021, 4:12 PM
gbe added a comment to D29762: ossl(4): Install the man page also for arm64.

Thanks for catching this. I believe we generally prefer one block checking the supported MACHINE_CPUARCH values, like the _cgem.4 example below. Both styles are imperfect however.

Apr 14 2021, 3:48 PM
gbe requested review of D29762: ossl(4): Install the man page also for arm64.
Apr 14 2021, 3:13 PM

Apr 13 2021

gbe closed D29701: config(8): Correct the mentioned paper in the SEE ALSO section.
Apr 13 2021, 4:54 AM
gbe committed R10:e6ab1e365c06: config(8): Correct the mentioned paper in the SEE ALSO section (authored by gbe).
config(8): Correct the mentioned paper in the SEE ALSO section
Apr 13 2021, 4:54 AM
gbe committed R10:bc54f5f1cd5c: route(8): Add an example how to print the routing tables (authored by gbe).
route(8): Add an example how to print the routing tables
Apr 13 2021, 4:48 AM
gbe closed D29702: route(8): Add an example how to print the routing tables.
Apr 13 2021, 4:48 AM
gbe committed R10:fa5210b55a35: sysctl.conf(5): Mention sysctl.conf.local in the sysctl.conf(5) manual page (authored by gbe).
sysctl.conf(5): Mention sysctl.conf.local in the sysctl.conf(5) manual page
Apr 13 2021, 4:38 AM
gbe committed R10:d33c99d27da2: sysctl.conf(5): Mention sysctl.conf.local in the sysctl.conf(5) manual page (authored by gbe).
sysctl.conf(5): Mention sysctl.conf.local in the sysctl.conf(5) manual page
Apr 13 2021, 4:38 AM

Apr 11 2021

gbe requested review of D29702: route(8): Add an example how to print the routing tables.
Apr 11 2021, 11:32 AM
gbe requested review of D29701: config(8): Correct the mentioned paper in the SEE ALSO section.
Apr 11 2021, 10:53 AM

Apr 10 2021

gbe accepted D29693: [committers-guide] Add missing word.

LGTM

Apr 10 2021, 7:10 PM

Apr 9 2021

gbe accepted D29676: Rename struct device to struct _device.

LGTM from manpages

Apr 9 2021, 6:20 PM
gbe closed D29673: Mention sysctl.conf.local in the sysctl.conf(5) manual page.
Apr 9 2021, 3:34 PM
gbe committed R10:46c99528078a: sysctl.conf(5): Mention sysctl.conf.local in the sysctl.conf(5) manual page (authored by gbe).
sysctl.conf(5): Mention sysctl.conf.local in the sysctl.conf(5) manual page
Apr 9 2021, 3:34 PM
gbe requested review of D29673: Mention sysctl.conf.local in the sysctl.conf(5) manual page.
Apr 9 2021, 2:36 PM