Page MenuHomeFreeBSD

timeout(1): Some minor tweaks and improvements
ClosedPublic

Authored by gbe on Dec 2 2024, 1:51 PM.
Tags
None
Referenced Files
F106835345: D47866.id148451.diff
Mon, Jan 6, 4:45 AM
F106828364: D47866.id.diff
Mon, Jan 6, 1:54 AM
F106818806: D47866.id147391.diff
Sun, Jan 5, 9:58 PM
Unknown Object (File)
Sun, Jan 5, 7:52 AM
Unknown Object (File)
Sat, Jan 4, 6:06 PM
Unknown Object (File)
Sat, Dec 28, 7:17 AM
Unknown Object (File)
Sat, Dec 28, 6:47 AM
Unknown Object (File)
Dec 6 2024, 4:12 AM
Subscribers

Details

Summary
  • Define exit status and macros and use them
  • Improve the second kill logic by setting 'do_second_kill = false' after configuring the second kill
  • Minor style tweaks
  • Reorder options in the man page, as well as the usage help
  • Reorder the exit status in the man page
  • Enhance the HISTORY section in the man page (obtained from NetBSD)

Obtained from: DragonFlyBSD

Test Plan

make in the timeout(1) source directory

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

gbe requested review of this revision.Dec 2 2024, 1:51 PM
ziaee requested changes to this revision.Dec 2 2024, 2:13 PM
ziaee added a subscriber: ziaee.

I wish we had any consensus on how we want to sort options. I'm partial to "-A -a -B -b --bee -C" sorting, but I don't want to bikeshed it. We have all different styles in the tree and any sorting is better!

bin/timeout/timeout.1
37

I like this!

212

Although if you want to do it the other way, .Fx would need to be on it's own line to render.

This revision now requires changes to proceed.Dec 2 2024, 2:13 PM
  • address feedback (put .Fx on this on line)
  • bump .Dd
gbe marked 2 inline comments as done.Dec 3 2024, 7:24 AM

@bapt @emaste any one for review? I have few other differentials in the making, but this one is the foundation for further mergers from modifications other BSDs have done.

This revision is now accepted and ready to land.Dec 5 2024, 8:38 PM

Just something to note I noticed today, style.mdoc(5) says not to use spaces in the synopsis pipes. This does conflict with the upstream mdoc style guides, and we more often seem to use spaces.

This revision was automatically updated to reflect the committed changes.