- User Since
- Jul 25 2015, 10:06 AM (104 w, 3 d)
Sun, Jul 9
Looks OK for me (after wrapping my head around PLIST_FILES and PORTDATA and how the port installs the files).
Mon, Jul 3
Keep it at 32bits, only extend the defines to cover visually 32bits instead of only 16 (and keep
the new flag).
Sun, Jul 2
May 8 2017
May 7 2017
Jan 15 2017
Dec 3 2016
Sep 19 2016
Aug 17 2016
Jul 31 2016
Apr 16 2016
Feb 27 2016
Jan 29 2016
Dec 8 2015
In general it looks ok. I haven't validated the plists or such. The Mk files look good (no obvious error). The rest seem to be "a simple version update".
Aug 9 2015
Jul 28 2015
That's where patching the current ports tree fails. I've tried to fix it, but it seems to have been generated from your previous patched ports tree.
Jul 26 2015
Jul 25 2015
After agreement with Alain: comandeer this revision.
I improved some parts of the code (see individual comments).
As it seems phabricator is build for more colaboration between the people besides 1 submitter and several no-patch-modify-rights reviewers. It doens't allow me to upload my diff.
Answer a question from eadler.
I have reviewed this completely (read-only, I haven't tested anything) now (Essen Hackathon 2015), and apart from the comment about the remvoed IGNORE part which should be handled, I think the patch is OK.
Is this tested to not break the 32bit version of the linux base ports (c6 & f10)?
If it doesn't break -- specially the case where a port wants c6 but the override is set to f10 (= the IGNORE part of my comments) -- I would say go ahead and commit it (it will not hurt to have some rough edges in the 64bit parts... if any, we can fix them as they show up).