Page MenuHomeFreeBSD

ipfw tests: cover layer-2 filtering of unmapped mbufs
Needs RevisionPublic

Authored by netchild on Fri, Sep 4, 1:46 PM.
Tags
None
Referenced Files
F171266192: D59390.diff
Wed, Sep 9, 11:42 PM
F171208703: D59390.id185820.diff
Wed, Sep 9, 1:10 PM
F171207610: D59390.diff
Wed, Sep 9, 12:58 PM
F171204631: D59390.id185820.diff
Wed, Sep 9, 12:23 PM
Unknown Object (File)
Wed, Sep 9, 4:52 AM
Unknown Object (File)
Wed, Sep 9, 3:30 AM
Unknown Object (File)
Tue, Sep 8, 5:35 PM
Unknown Object (File)
Mon, Sep 7, 5:41 PM

Details

Summary

Test that ipfw's layer-2 hook maps unmapped mbufs before inspecting them.

Assisted-by: Claude Code (Fable 5)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 76496
Build 73379: arc lint + arc unit

Event Timeline

netchild held this revision as a draft.
netchild published this revision for review.Fri, Sep 4, 1:51 PM

Unit test for the issue in D59389.

glebius requested changes to this revision.Fri, Sep 4, 9:22 PM
glebius added inline comments.
tests/sys/netpfil/ipfw/unmapped.sh
83

No, such a long execution time is unacceptable for the test suite. Imagine every test was like that.

unmapped:unmapped_block  ->  passed  [71.714s]

This needs to be refactored. Maybe use reset instead of deny in the rule?

This revision now requires changes to proceed.Fri, Sep 4, 9:22 PM