Page MenuHomeFreeBSD
Differential D59390

ipfw tests: cover layer-2 filtering of unmapped mbufs
ClosedPublic
Actions

Authored by netchild on Fri, Sep 4, 1:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 1, 8:47 AM
Unknown Object (File)
Wed, Sep 30, 3:47 PM
Unknown Object (File)
Wed, Sep 30, 3:47 PM
Unknown Object (File)
Wed, Sep 30, 10:50 AM
Unknown Object (File)
Tue, Sep 29, 11:27 PM
Unknown Object (File)
Tue, Sep 29, 11:26 PM
Unknown Object (File)
Tue, Sep 29, 3:59 AM
Unknown Object (File)
Mon, Sep 28, 4:34 PM
View All 50 Files
Subscribers
ae
donner
imp
melifaro
vegeta_tuxpowered.net

Details

Reviewers
glebius
markj
gallatin
Commits
rG044cae040488: ipfw tests: cover layer-2 filtering of unmapped mbufs
Summary

Test that ipfw's layer-2 hook copes with unmapped mbufs, on the pass
and on the deny path.

This test covers 5f81426831a6 / D59426.

Assisted-by: Claude Code (Fable 5, Opus 5)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

netchild created this revision.Fri, Sep 4, 1:46 PM
netchild held this revision as a draft.
Herald added subscribers: vegeta_tuxpowered.net, donner, melifaro and 2 others. · View Herald TranscriptFri, Sep 4, 1:46 PM
Harbormaster completed remote builds in B76496: Diff 185820.Fri, Sep 4, 1:46 PM
netchild added a parent revision: D59389: ipfw: pull up only the headers ipfw_chk() inspects.Fri, Sep 4, 1:46 PM
netchild published this revision for review.Fri, Sep 4, 1:51 PM

Unit test for the issue in D59389.

glebius requested changes to this revision.Fri, Sep 4, 9:22 PM
glebius added inline comments.
tests/sys/netpfil/ipfw/unmapped.sh
84

No, such a long execution time is unacceptable for the test suite. Imagine every test was like that.

unmapped:unmapped_block  ->  passed  [71.714s]

This needs to be refactored. Maybe use reset instead of deny in the rule?

This revision now requires changes to proceed.Fri, Sep 4, 9:22 PM
glebius added a child revision: D59426: ipfw: refactor macros around m_pullup().Fri, Sep 4, 9:24 PM
netchild updated this revision to Diff 187207.Sat, Sep 19, 9:47 AM

unmapped_block now denies the data segments instead of the handshake (tcpdatalen 1000-65535): 71 s -> 1.5 s, and an unfixed kernel panics on it

Harbormaster completed remote builds in B77086: Diff 187207.Sat, Sep 19, 9:47 AM
netchild edited the summary of this revision. (Show Details)Sat, Sep 19, 9:51 AM
netchild marked an inline comment as done.
glebius accepted this revision.Tue, Sep 22, 7:24 PM

Thanks!

This revision is now accepted and ready to land.Tue, Sep 22, 7:24 PM
Closed by commit rG044cae040488: ipfw tests: cover layer-2 filtering of unmapped mbufs (authored by netchild). · Explain WhyWed, Sep 23, 12:48 PM
This revision was automatically updated to reflect the committed changes.
netchild added a commit: rG044cae040488: ipfw tests: cover layer-2 filtering of unmapped mbufs.

Revision Contents
Changeset List

PathSize
tests/
sys/
netpfil/
ipfw/
3 lines
189 lines

Diff 187500

View Options

tests/sys/netpfil/ipfw/Makefile

Loading...
View Options

tests/sys/netpfil/ipfw/unmapped.sh

Loading...