secteamGroup
ActivePublic

Recent Activity

Sun, May 27

jmg added a comment to D15389: aesni(4): improve session lookup performance.

I agree w/ cem that we need a general solution to this. I'm fine w/ this patch, but I do question the wisdom in making this code aesni only. This code really needs to be turned into a library which any OCF driver can use, as this performance problem is not limited to aesni.

Sun, May 27, 9:25 PM · secteam

May 25 2018

cem added a comment to D15389: aesni(4): improve session lookup performance.

So what is the plan here? Wait for somebody willing to do the session management in OCF right?

May 25 2018, 7:21 AM · secteam
emeric.poupon_stormshield.eu added a comment to D15389: aesni(4): improve session lookup performance.
In D15389#328341, @cem wrote:

Nobody wants this? It is definitely better than the current code though.

Sure, it improves performance (I haven't tested, but I'm quite willing to take your word for it) of a single OCF driver in the case that some consumer is allocating a lot of sessions (or maybe a reasonable number of sessions on a high core-count CPU). But that doesn't make it definitely better.

It adds complexity and perpetuates the problem that every OCF driver needs to copy and paste crappy session management. I think a general solution that moves the session management into OCF and out of drivers is a better way to fix this. You don't need the RB tree if sessions are just pointers.

May 25 2018, 7:11 AM · secteam

May 24 2018

cem added a comment to D15389: aesni(4): improve session lookup performance.

Nobody wants this? It is definitely better than the current code though.

May 24 2018, 3:03 PM · secteam
emeric.poupon_stormshield.eu added a comment to D15389: aesni(4): improve session lookup performance.

Nobody wants this? It is definitely better than the current code though.

May 24 2018, 12:21 PM · secteam

May 16 2018

emeric.poupon_stormshield.eu updated the diff for D15389: aesni(4): improve session lookup performance.

Remove bad comment

May 16 2018, 9:32 AM · secteam

May 14 2018

emeric.poupon_stormshield.eu updated the diff for D15389: aesni(4): improve session lookup performance.

Remarks

May 14 2018, 8:07 AM · secteam
emeric.poupon_stormshield.eu added inline comments to D15389: aesni(4): improve session lookup performance.
May 14 2018, 7:21 AM · secteam
emeric.poupon_stormshield.eu added a comment to D15389: aesni(4): improve session lookup performance.
In D15389#324522, @cem wrote:

I agree that the current system sucks and that it does not scale with multiple sessions. I'm not sure a binary tree is the right replacement, though. And probably session management should be lifted out into OCF (OpenCrypto Framework) so that all drivers can benefit from it without copy-pasting.

OCF has a number of shortcomings which John detailed here: https://lists.freebsd.org/pipermail/freebsd-arch/2018-January/018835.html

May 14 2018, 7:20 AM · secteam

May 11 2018

cem added a reviewer for D15389: aesni(4): improve session lookup performance: jhb.

I agree that the current system sucks and that it does not scale with multiple sessions. I'm not sure a binary tree is the right replacement, though. And probably session management should be lifted out into OCF (OpenCrypto Framework) so that all drivers can benefit from it without copy-pasting.

May 11 2018, 4:09 PM · secteam
emeric.poupon_stormshield.eu created D15389: aesni(4): improve session lookup performance.
May 11 2018, 1:36 PM · secteam

Mar 13 2018

badfilemagic_gmail.com removed a watcher for secteam: badfilemagic_gmail.com.
Mar 13 2018, 4:23 PM

Dec 8 2017

gordon added a member for secteam: emaste.
Dec 8 2017, 5:37 AM

Jul 15 2017

delphij added a member for secteam: gordon.
Jul 15 2017, 4:01 PM

Jun 11 2017

badfilemagic_gmail.com added a watcher for secteam: badfilemagic_gmail.com.
Jun 11 2017, 3:31 PM

Mar 22 2016

lattera-gmail.com added a watcher for secteam: lattera-gmail.com.
Mar 22 2016, 12:22 AM

Aug 11 2015

delphij added members for secteam: jmg, glebius.
Aug 11 2015, 7:48 PM

Jul 15 2015

eadler changed the edit policy for secteam.
Jul 15 2015, 2:32 AM
eadler changed the join policy for secteam.
Jul 15 2015, 2:29 AM

Jul 14 2015

delphij added a member for secteam: delphij.
Jul 14 2015, 6:33 PM