Page MenuHomeFreeBSD

jmg (John-Mark Gurney)
User

Projects

User Details

User Since
Sep 2 2014, 10:55 PM (308 w, 6 d)

Recent Activity

Thu, Jul 30

jmg closed D25874: remove some serial drivers (rc, rp, cy).

commited in https://reviews.freebsd.org/rS363683

Thu, Jul 30, 6:08 AM
jmg committed rS363683: remove some long abandonded serial drivers (cy, rc, rp) since 2008.
remove some long abandonded serial drivers (cy, rc, rp) since 2008
Thu, Jul 30, 12:54 AM

Wed, Jul 29

jmg committed rS363674: add link to crypto(7) page, and drop a link to unrelated crypt(3) page...
add link to crypto(7) page, and drop a link to unrelated crypt(3) page..
Wed, Jul 29, 9:15 PM
jmg added a comment to D25874: remove some serial drivers (rc, rp, cy).

Removed manual pages need to be added to ObsoleteFiles.inc as well.

Wed, Jul 29, 7:34 PM
jmg updated the diff for D25874: remove some serial drivers (rc, rp, cy).

didn't complain about missing file on command line, that being
rp's module dir..

Wed, Jul 29, 8:56 AM
jmg updated the diff for D25874: remove some serial drivers (rc, rp, cy).

forgot to remove from files..

Wed, Jul 29, 8:05 AM
jmg updated the summary of D25874: remove some serial drivers (rc, rp, cy).
Wed, Jul 29, 7:01 AM
jmg updated the diff for D25874: remove some serial drivers (rc, rp, cy).

too smart w/ command line, include the rest of the files..

Wed, Jul 29, 7:01 AM
jmg requested review of D25874: remove some serial drivers (rc, rp, cy).
Wed, Jul 29, 6:59 AM

Mon, Jul 27

jmg added a comment to D25809: major update to if_ure.

I'll wait to get a few more reports of tests before committing..

Mon, Jul 27, 6:28 PM
jmg added a comment to D25809: major update to if_ure.

ok, these should address all of your comments.

Mon, Jul 27, 1:46 AM
jmg updated the diff for D25809: major update to if_ure.

update to address hselasky's comments.

Mon, Jul 27, 1:46 AM
jmg updated the diff for D25809: major update to if_ure.

make it relative to HEAD.. Post white space commit..

Mon, Jul 27, 1:18 AM

Sat, Jul 25

jmg requested review of D25809: major update to if_ure.
Sat, Jul 25, 10:52 PM
jmg committed rS363531: clean up whitespace....
clean up whitespace...
Sat, Jul 25, 6:09 PM

Fri, Jul 24

jmg committed rS363468: fix up docs for m_getjcl as well...
fix up docs for m_getjcl as well..
Fri, Jul 24, 12:47 AM
jmg committed rS363467: document that m_get2 only accepts up to MJUMPAGESIZE...
document that m_get2 only accepts up to MJUMPAGESIZE..
Fri, Jul 24, 12:35 AM

Thu, Jul 23

jmg added a comment to D25697: minor improvements to man9 + MLINKs update.

I'm going to commit the change (which the grammar fix) in the next day or two if I don't get any more feedback.

Thu, Jul 23, 11:24 PM
jmg committed rS363462: update example to make it active when creating a new boot method....
update example to make it active when creating a new boot method...
Thu, Jul 23, 10:28 PM

Fri, Jul 17

jmg added a comment to D17541: update ZFS to note support of extended attributes.

Yes a PR clarifying this in OpenZFS would be greatly appreciated. Any change here would only be good for MFC. I think the wording suggested by @delphij is a bit more clear.

Fri, Jul 17, 8:01 PM
jmg added a comment to D17541: update ZFS to note support of extended attributes.

@freqlabs let ms know if you just want to integrate this into the OpenZFS update, or what.

Fri, Jul 17, 7:02 PM
jmg added a comment to D21017: armv8crypto: add AES-XTS support.

Looks fine. You should look at unrolling the loop to 3 or 4 rounds. Looking at the A72 optimization guide, it shows that there is a 3 cycle latency, but throughput of 1. Section 4.10 gives example showing three pairs to achieve max perf.

Fri, Jul 17, 1:01 AM · arm64

Thu, Jul 16

jmg committed rS363265: add script to help figure out what man pages need MLINKS updated....
add script to help figure out what man pages need MLINKS updated...
Thu, Jul 16, 11:05 PM
jmg added a reviewer for D25682: tests/sys/opencrypto: use python3: ngie.

Looks good to me. I'm adding ngie as they did the port to Python 3. I have not run and verified that this works under Python 3, but fully support the move to 3.

Thu, Jul 16, 10:39 PM
jmg requested review of D25697: minor improvements to man9 + MLINKs update.
Thu, Jul 16, 10:08 PM

Jun 7 2020

jmg added a comment to D21886: Add USB support for location based device unit numbers.
In D21886#554614, @imp wrote:

Cool script. It would be better to add the alias with devfs. Then it would disappear w/o devd needing all the info...

Jun 7 2020, 3:13 AM

Jun 6 2020

jmg added a comment to D21886: Add USB support for location based device unit numbers.

I took Daniel O'Connor's script from: https://www.mail-archive.com/freebsd-usb@freebsd.org/msg14258.html

Jun 6 2020, 10:42 PM

May 24 2020

jmg added a comment to D24987: Update platform docs for arm.

a later diff has addressed these comments.

May 24 2020, 8:30 PM
jmg added a comment to D24987: Update platform docs for arm.

these should not have been marked done. Why phab did this I have no clue. Maybe they think that if you update a patch you address all of your comments, but that is a TERRIBLE assumption to make.

May 24 2020, 8:29 PM
jmg updated the diff for D24987: Update platform docs for arm.

update with comments from manu

May 24 2020, 8:28 PM
jmg added inline comments to D24987: Update platform docs for arm.
May 24 2020, 8:18 PM
jmg updated the diff for D24987: Update platform docs for arm.

add the path to the diff...

May 24 2020, 8:15 PM
jmg requested review of D24987: Update platform docs for arm.
May 24 2020, 8:12 PM

May 21 2020

jmg added a comment to D24945: Turn off SSLv3..

If you want to test, you generate a self sign cert:
openssl req -x509 -newkey rsa:4096 -keyout key.pem -out cert.pem -days 365

May 21 2020, 10:32 PM
jmg added a comment to D24945: Turn off SSLv3..
In D24945#549197, @cem wrote:

We should also disable SSL2, if we do not already. And perhaps TLS 1.0?

SSLv2 already doesn't exist, so no problem there.

TLSv1.0 is still widely deployed. I think removing support entirely is premature.

May 21 2020, 10:28 PM
jmg committed rS361326: Bring in support for single core Zynq devices. Turns out that real.
Bring in support for single core Zynq devices. Turns out that real
May 21 2020, 6:41 AM
jmg closed D14429: Support single core Zynq devices (MiniZed)..
May 21 2020, 6:41 AM
jmg accepted D14429: Support single core Zynq devices (MiniZed)..

Tested and working.

May 21 2020, 6:33 AM
jmg committed rS361325: minor cleanup of white space, and function name in panic....
minor cleanup of white space, and function name in panic...
May 21 2020, 6:18 AM

May 20 2020

jmg requested changes to D14429: Support single core Zynq devices (MiniZed)..

Sorry, got a bit excited that things worked.

May 20 2020, 7:42 AM
jmg accepted D14429: Support single core Zynq devices (MiniZed)..

This booted on my 07S board w/o me having to set hw.ncpu in loader!

May 20 2020, 12:32 AM

May 19 2020

jmg added a comment to D14429: Support single core Zynq devices (MiniZed)..
In D14429#548354, @jmg wrote:

I just tested this on my Cora Z7-07S board, and it looks like there's a hardware bug that prevents this patch from working.

I added a printf to dump mp_maxid and mp_ncpus, and I get 1 and 2 respectively, which per the TRM indicates that it's suppose to have 2 cpus instead of 1.

Crud. I guess the number of CPUs isn't properly represented in the SCU config register. Do you know the value of the entire register? From the u-boot prompt,
type "md 0xf8f00004 1". Another idea is to key off the device field of the SLCR's PSS_IDCODE register at 0xf8000530. Can you get that value too?
It also shows up in a sysctl under "hw.zynq.pss_idcode".

May 19 2020, 7:48 PM
jmg requested changes to D14429: Support single core Zynq devices (MiniZed)..

I just tested this on my Cora Z7-07S board, and it looks like there's a hardware bug that prevents this patch from working.

May 19 2020, 9:10 AM

May 17 2020

jmg added a comment to D14429: Support single core Zynq devices (MiniZed)..

Thanks, I'll look at committing this. I have a Cora Z7 that needs this.

May 17 2020, 9:37 PM

May 16 2020

jmg added a reviewer for D14429: Support single core Zynq devices (MiniZed).: jmg.
May 16 2020, 1:34 AM

Oct 23 2019

jmg added a comment to D10567: mkimg: Respect gpt first usable LBA.

Is there a reason this hasn't been committed?

Oct 23 2019, 5:55 PM

Oct 17 2019

jmg added a comment to D22068: mkimg: make MBR and EBR honor alignment, and change default alignment to 4k.

Would you mind splitting the changes into 2 reviews/commits. I don't oppose the changes, but they are logically unrelated/independent and it helps us with reversals and/or MFCs if they are separate commits.

Oct 17 2019, 9:46 PM
jmg added a reviewer for D22068: mkimg: make MBR and EBR honor alignment, and change default alignment to 4k: marcel.
Oct 17 2019, 7:18 PM
jmg created D22068: mkimg: make MBR and EBR honor alignment, and change default alignment to 4k.
Oct 17 2019, 6:54 PM

Oct 9 2019

jmg committed rS353374: document how to apply altq to vlan interfaces w/ pf..
document how to apply altq to vlan interfaces w/ pf.
Oct 9 2019, 9:48 PM

Sep 16 2019

jmg committed rS352431: fix the article to be correct....
fix the article to be correct...
Sep 16 2019, 10:48 PM

Aug 15 2019

jmg committed rS351086: finish the pcp feature, but documenting it in the man page....
finish the pcp feature, but documenting it in the man page...
Aug 15 2019, 4:58 PM

Nov 25 2018

jmg added a comment to D18059: Remove KN_HASKQLOCK..

Yeah, after a bit of splunking after writing that comment, I discovered that it was unused.

Nov 25 2018, 8:19 PM

Nov 24 2018

jmg added a comment to D18059: Remove KN_HASKQLOCK..

why was this removed? This was necessary to prevent lock inversion due to a kq being in another kq...

Nov 24 2018, 10:43 PM

Nov 14 2018

jmg added a reviewer for D17972: Fix "usbconfig set_template": jmg.
Nov 14 2018, 6:38 AM

Nov 5 2018

jmg committed rD52468: use https instead of http for this link..
use https instead of http for this link.
Nov 5 2018, 4:47 PM

Oct 28 2018

jmg added a comment to D17739: Update awk(1) manual to accurately describe regex syntax..

oh, don't forget to bump date!

Oct 28 2018, 6:29 PM
jmg accepted D17739: Update awk(1) manual to accurately describe regex syntax..

looks good! Thanks!

Oct 28 2018, 6:29 PM

Oct 25 2018

jmg added reviewers for D4964: Protect calls to explicit_bzero() via by explicitly disabling the link-time and other optimizations that can cause code elimination.: secteam, gordon.
Oct 25 2018, 3:17 AM
jmg added a comment to D4964: Protect calls to explicit_bzero() via by explicitly disabling the link-time and other optimizations that can cause code elimination..

Now that memset_s is part of the standard, should we just make explicit_bzero a wrapper for memset_s?

Oct 25 2018, 3:17 AM

Oct 12 2018

jmg created D17541: update ZFS to note support of extended attributes.
Oct 12 2018, 10:38 PM

Sep 16 2018

jmg committed rS338698: Significantly improve pf purge cpu usage by only taking locks.
Significantly improve pf purge cpu usage by only taking locks
Sep 16 2018, 12:44 AM
jmg closed D17097: only lock row in pf purge thread when work to do.
Sep 16 2018, 12:44 AM

Sep 10 2018

jmg added a comment to D17097: only lock row in pf purge thread when work to do.

For reference, on an active pf firewall, before the patch, ~1.56% cpu core was used on the purge thread, after the patch, .427% cpu core. over a third less CPU. This is with the same 128k hash table size.

Sep 10 2018, 5:18 PM

Sep 9 2018

jmg added a comment to D17097: only lock row in pf purge thread when work to do.

CPU usage calculated by taking the time pf purge ran and dividing it by the difference between now, and lstart:

ps -ax -o lstart,time,command | grep pf; date

Sun Sep 9 16:31:23 2018 0:30.95 [pf purge]
Sun Sep 9 19:33:53 2018 0:00.02 grep pf
Sun Sep 9 19:33:53 UTC 2018

Sep 9 2018, 7:35 PM
jmg added a comment to D17097: only lock row in pf purge thread when work to do.

note, if you apply the diff and check it w/ svn diff -x -wb, you'll see that the only change is the comment, the if, and the braces.

Sep 9 2018, 4:54 PM
jmg created D17097: only lock row in pf purge thread when work to do.
Sep 9 2018, 4:52 PM

Sep 1 2018

jmg added a comment to D15713: Bug 182518 - [login.conf] Better Password Hashes .

All comments are minor.

Sep 1 2018, 6:40 PM · security

Aug 29 2018

jmg updated the diff for D16690: make device_printf use sbuf.

ok, this should be ready to land.. Not going to update printf(9),
that'll be a different patch, and there are missing vprintf and vlog
from the body of the man page...

Aug 29 2018, 12:39 AM

Aug 28 2018

jmg added inline comments to D16690: make device_printf use sbuf.
Aug 28 2018, 9:27 PM
jmg updated the diff for D16690: make device_printf use sbuf.

add fix for when printf returns an error, pass the error up
correctly.. prf_buf does not return an error..

Aug 28 2018, 5:19 AM
jmg planned changes to D16690: make device_printf use sbuf.

All but the printf error is addressed, and the next patch will address this issue.

Aug 28 2018, 5:17 AM
jmg added a comment to D16690: make device_printf use sbuf.

Fix most of the issues. I will address the cast to int w/ a KASSERT in another update.

Aug 28 2018, 5:05 AM
jmg updated the diff for D16690: make device_printf use sbuf.

Update and address various comments.

Aug 28 2018, 5:00 AM

Aug 24 2018

jmg added a comment to D16873: Limit the harvest rate of "fast" entropy for random(4) so as not to overload the system..

simple fix, limit local_read_rate to be 0 or 1. Even more simple that the fix that was committed.

Aug 24 2018, 9:12 PM
jmg added a comment to D16873: Limit the harvest rate of "fast" entropy for random(4) so as not to overload the system..

@delphij this is my comment copied over from https://reviews.freebsd.org/D16866?id=47165 that was unaddressed.

Aug 24 2018, 5:23 PM
jmg planned changes to D16690: make device_printf use sbuf.

I'll update the patch shortly. Thanks for the review.

Aug 24 2018, 5:02 PM

Aug 23 2018

jmg added a comment to D16690: make device_printf use sbuf.

This does add some tests that were missing. I can commit those and the MLINK for _putbuf separately if people would like. I'm also fine breaking out the sys/kern/subr_bus.c changes as well.

Aug 23 2018, 4:47 PM
jmg added inline comments to D16690: make device_printf use sbuf.
Aug 23 2018, 4:46 PM
jmg updated the diff for D16690: make device_printf use sbuf.

Update. Use a new created printf drain function that works in both
userland and kernel. Document the function, and add tests for it.

Aug 23 2018, 4:45 PM
jmg added a comment to D16866: Fix excessive reseeding in random(4)..

Please commit these patches separately. They deal w/ different issues.

Aug 23 2018, 4:16 PM
jmg accepted D16860: Use arc4rand() instead of read_random().

IMO, looks good to me.

Aug 23 2018, 3:22 PM

Aug 21 2018

jmg committed rS338140: minor grammar nit, to what? between them...
minor grammar nit, to what? between them..
Aug 21 2018, 3:11 PM

Aug 20 2018

jmg planned changes to D16690: make device_printf use sbuf.

Working on testing sbuf, and adding new drain function from printing, w/ both a userland and kernel versions of the function.

Aug 20 2018, 12:32 AM

Aug 19 2018

jmg committed rS338075: use sbuf so that lines are printed together... As aarch64 often.
use sbuf so that lines are printed together... As aarch64 often
Aug 19 2018, 9:38 PM
jmg closed D16689: make arm64 identcpu use an sbuf.
Aug 19 2018, 9:38 PM

Aug 17 2018

jmg added a comment to D16690: make device_printf use sbuf.

Thanks for the comments, you solved some of the issues I knew about and didn't know how to solve best.

Aug 17 2018, 3:41 PM

Aug 16 2018

jmg added a comment to D16740: GPT is standard in x86 and arm64 land. Add it to DEFAULTS with the others..

Should powerpc64 be added too?

Aug 16 2018, 4:49 PM

Aug 12 2018

jmg created D16690: make device_printf use sbuf.
Aug 12 2018, 3:07 AM
jmg updated the summary of D16689: make arm64 identcpu use an sbuf.
Aug 12 2018, 2:59 AM
jmg created D16689: make arm64 identcpu use an sbuf.
Aug 12 2018, 2:57 AM

Aug 10 2018

jmg committed rD52098: update key now that mine expired....
update key now that mine expired...
Aug 10 2018, 3:12 AM

Aug 9 2018

jmg added a comment to D16552: random: Add PowerPC 'darn' instruction entropy source.

looks fine. Agree that conditioned output should be used. We do our own conditioning so it wouldn't be a major problem to use the raw, but the raw will likely have less entropy.

Aug 9 2018, 12:24 PM

Jul 18 2018

jmg added a comment to D16316: Consistently use explicit_bzero() for _Final methods..

looks good. Thanks.

Jul 18 2018, 10:35 PM

Jun 25 2018

jmg added a comment to D15993: change rcmds removal.

I cannot comment on this as __pure2 is not documented, so I don't know the expected semantics of adding that define.

Jun 25 2018, 11:26 PM
jmg added a comment to D15679: Remove potential identifier conflict in the EV_SET macro..

no comments...

Jun 25 2018, 11:22 PM

Jun 2 2018

jmg added a comment to D15526: reduce overhead of entropy collection.

Oh, note that the above are my opinions, and they differ significantly from most of the rest of the FreeBSD team. Mainly why I haven't spent much time working on the rng system,

Jun 2 2018, 8:45 PM
jmg added a comment to D15526: reduce overhead of entropy collection.

Collecting the first 10 packets or so every second is not a great idea. With things like tcp off-load which bursts packets, it's common for bursts of packets to be correlated.

Yes. True. Nonetheless, I'm much more interested in the questions I raised in the review. All of these implementation details are secondary to those.

Jun 2 2018, 8:42 PM
jmg added a comment to D15526: reduce overhead of entropy collection.

While certainly better than what we were doing, global pps accounting would not be efficient multi-core. I'd much rather have it collect the first 10 packets or so every second.

Jun 2 2018, 6:45 PM
jmg added a comment to D15526: reduce overhead of entropy collection.

If people want to use ethernet entropy harvesting, can we do something to make it more useful in a separate change? I was going to initially suggest the ether dst addr, but that's not very random either.

In any cases, I think these changes are a huge win. Especially moving the collection mask outside a cacheline that is written in the hot path.

Jun 2 2018, 5:45 PM