Page MenuHomeFreeBSD

jmg (John-Mark Gurney)
User

Projects

User Details

User Since
Sep 2 2014, 10:55 PM (354 w, 5 d)

Recent Activity

Thu, Jun 3

jmg added inline comments to D30625: add support for media and link change events to CDCE..
Thu, Jun 3, 7:43 PM
jmg added a comment to D30625: add support for media and link change events to CDCE..

Let me know more about the CDCE_IND_SIZE_MAX constant.

Thu, Jun 3, 5:57 PM
jmg requested review of D30625: add support for media and link change events to CDCE..
Thu, Jun 3, 6:05 AM

May 4 2021

jmg added a comment to D26305: search does not work with multiple sites listed.

No, this needs to be updated to the new website.

May 4 2021, 6:54 PM

Apr 21 2021

jmg accepted D29748: rc: fix dependencies for growfs.

looks good.

Apr 21 2021, 8:51 PM

Apr 15 2021

jmg added a comment to D29748: rc: fix dependencies for growfs.

Makes perfect sense, but growfs depends on awk(1), which might be on a separate /usr, which gets mounted by mountcritlocal, which runs after root.

I wonder if it would be possible to somehow extend geom(8) to make the walk through the hierarchy easier, to not require complicated text processing?

Apr 15 2021, 12:49 AM

Apr 13 2021

jmg added a comment to D29748: rc: fix dependencies for growfs.

Do you remember any details about the bug, or the testing setup?

The problem with current ordering is that it's not really defined when the sysctl script runs - it has no dependencies, so it's up to rcorder(8), and from what I've seen it's not very stable about sorting.

Apr 13 2021, 10:59 PM
jmg added a comment to D29748: rc: fix dependencies for growfs.

Looking at the comment in the original commit:

# TODO: Figure out where this should really be ordered.
# I suspect it should go just after fsck but before mountcritlocal
# but it's hard to tell for sure because of the bug described
# below.
Apr 13 2021, 6:49 PM

Apr 6 2021

jmg committed R10:b8028f9d3ca0: add Xr to the rc.d script... (authored by jmg).
add Xr to the rc.d script...
Apr 6 2021, 11:34 PM

Mar 16 2021

jmg added inline comments to D29268: armv8crypto: add some missing copyright statements.
Mar 16 2021, 11:43 PM
jmg added a comment to D29268: armv8crypto: add some missing copyright statements.

the phrase "This file derived from" has no history in our tree, I'd prefer the phrase I proposed.

Mar 16 2021, 9:50 PM

Mar 15 2021

jmg added a comment to D29268: armv8crypto: add some missing copyright statements.

Thank you.

Mar 15 2021, 9:11 PM

Mar 6 2021

jmg added a comment to D29007: address a performance problem w/ partial sscanf on long strings....

Ok, the results from an arm64 run (A53, Pine64 A64-LTS).

Mar 6 2021, 2:41 AM

Mar 3 2021

jmg added a comment to D29007: address a performance problem w/ partial sscanf on long strings....
In D29007#650040, @cem wrote:
In D29007#649973, @jmg wrote:
In D29007#649700, @cem wrote:

Is 128 a reasonable chunk here? How does it relate to the internal buffering of FILE?

I'm going to run some perf numbers on ARM, but w/ the attached file w/ benchmarks, it looks like the chunk should be closer to 16.

That sounds about right if we're optimizing for single conversions (%d, %g, whatever) at the start of long input strings. Does the small size penalize larger conversions much? It seems like we'll be bouncing around _vsscanf_read every N bytes now. (I wonder how common the GTA use case actually is.)

Mar 3 2021, 7:07 PM
jmg added a comment to D29007: address a performance problem w/ partial sscanf on long strings....
In D29007#649700, @cem wrote:

Is 128 a reasonable chunk here? How does it relate to the internal buffering of FILE?

Mar 3 2021, 2:35 AM

Mar 2 2021

jmg added a comment to D29007: address a performance problem w/ partial sscanf on long strings....

strlen tests pass:

freebsd@test:/usr/tests $ kyua test lib/libc/string/strlen_test
lib/libc/string/strlen_test:strlen_basic  ->  passed  [0.004s]
lib/libc/string/strlen_test:strlen_huge  ->  passed  [0.027s]
lib/libc/string/strlen_test:strnlen_basic  ->  passed  [0.004s]
Mar 2 2021, 12:39 AM
jmg added a comment to D29007: address a performance problem w/ partial sscanf on long strings....

address comments.

Mar 2 2021, 12:26 AM
jmg updated the diff for D29007: address a performance problem w/ partial sscanf on long strings....
  • address brooks's comments,
Mar 2 2021, 12:25 AM
jmg added a comment to D29007: address a performance problem w/ partial sscanf on long strings....

style(9) uses \0 exclusively, so I guess I'll change.

Mar 2 2021, 12:21 AM
jmg updated the diff for D29007: address a performance problem w/ partial sscanf on long strings....
  • use a more common spelling of NUL...
Mar 2 2021, 12:20 AM
jmg added a comment to D29007: address a performance problem w/ partial sscanf on long strings....

Attached is a set of benchmarks. First number is chunk size, second number is number of 0's in the string that is sscanf'd.
Bench (results from an amd64, AMD PRO A10-8770E, 2.8GHz):

Mar 2 2021, 12:10 AM
jmg added a comment to D29007: address a performance problem w/ partial sscanf on long strings....

The strnlen will be committed as a separate commit, likely before this change, as this change depends upon it for performance.

Mar 2 2021, 12:04 AM
jmg requested review of D29007: address a performance problem w/ partial sscanf on long strings....
Mar 2 2021, 12:02 AM

Feb 17 2021

jmg abandoned D3084: add option to invert data set so you can convert seconds into per seconds...

As "more" correct term was never provided, and phk also didn't like this change, no point in keeping this open.

Feb 17 2021, 12:06 AM
jmg abandoned D2651: libcpufeats and amd64 assembly for sha256.

I have no plans to work on this in the future. Someone else is free to take this over and get it committed.

Feb 17 2021, 12:03 AM

Jan 21 2021

jmg added a comment to D26538: Add SIOCGIFDATA.

Compat with what? There is no code in the FreeBSD source tree that uses it, and no releases have this ioctl. It hasn't even been merged to 12-stable yet.

Future backwards compat - i.e. introduce the new ioctl if and when we extend if_data.

Jan 21 2021, 9:25 PM
jmg added a comment to D26538: Add SIOCGIFDATA.
In D26538#632166, @jmg wrote:

I know this was closed and committed, but I want to get some more discussion on this.

I happen to be reviewing this for my own code (to get at _hwassist), and noticed that the code does not check how much space the program allocated for the if_data structure. This means that as the interface stands, it cannot be expanded, ever in the future, as it'll break old programs when they use this.

Why can't we change the ioctl number and keep the old one for compat?

Jan 21 2021, 8:56 PM
jmg reopened D26538: Add SIOCGIFDATA.

I know this was closed and committed, but I want to get some more discussion on this.

Jan 21 2021, 2:11 AM

Jan 19 2021

jmg committed R10:fd11270509f2: add missing .Xr.. (authored by jmg).
add missing .Xr..
Jan 19 2021, 10:25 PM

Dec 13 2020

jmg committed R9:21b7427a8777: make the Makefile a bit more friendly to forieng configurations... (authored by jmg).
make the Makefile a bit more friendly to forieng configurations...
Dec 13 2020, 8:11 PM
jmg committed R9:5038e5588ef5: Hasty is out of order. Put him in his proper place. :) (authored by jmg).
Hasty is out of order. Put him in his proper place. :)
Dec 13 2020, 8:08 PM
jmg committed R9:19bbbdf4d0c9: fix a mistyping of mistype (authored by jmg).
fix a mistyping of mistype
Dec 13 2020, 7:54 PM
jmg committed R9:7e8c48d2b030: add Alfred Perlstein <bright@rush.net> for PR/12780... (authored by jmg).
add Alfred Perlstein <bright@rush.net> for PR/12780...
Dec 13 2020, 7:54 PM
jmg committed R9:ad12315b5420: add my pgp key to the rest... (authored by jmg).
add my pgp key to the rest...
Dec 13 2020, 7:45 PM
jmg committed R9:547de0e14375: move wosch's entry into line... talking with billf on irc it appears that (authored by jmg).
move wosch's entry into line... talking with billf on irc it appears that
Dec 13 2020, 7:44 PM
jmg committed R9:de1d5b1b2664: Announce that I'm back. (authored by jmg).
Announce that I'm back.
Dec 13 2020, 7:03 PM
jmg committed R9:abacb57ffe5f: Move myself from the Alumni back into the Developers section now that (authored by jmg).
Move myself from the Alumni back into the Developers section now that
Dec 13 2020, 7:03 PM
jmg committed R9:bdac1971333d: Update Ted's year he started. Gleaned from the old avail file: (authored by jmg).
Update Ted's year he started. Gleaned from the old avail file:
Dec 13 2020, 7:03 PM
jmg committed R9:5f5253cab020: update if_sk, and add if_re, both have been locked down for a while now.. (authored by jmg).
update if_sk, and add if_re, both have been locked down for a while now..
Dec 13 2020, 6:29 PM
jmg committed R9:c4e70f7290bc: spell N/A using the entity... (authored by jmg).
spell N/A using the entity...
Dec 13 2020, 6:29 PM
jmg committed R9:4eef766cbf7b: add request for fast AMD64 box for build support... (authored by jmg).
add request for fast AMD64 box for build support...
Dec 13 2020, 6:10 PM

Dec 10 2020

jmg committed rS368529: fix up documentation/comments: processname is not defined, but programname.
fix up documentation/comments: processname is not defined, but programname
Dec 10 2020, 11:24 PM

Dec 1 2020

jmg committed rS368267: add documentation that the rules need to be reloaded, and how to do it....
add documentation that the rules need to be reloaded, and how to do it...
Dec 1 2020, 11:25 PM

Nov 19 2020

jmg added a comment to D27279: if: Protect V_ifnet in vnet_if_return().

can't say how correct this is, but it'll be great to have it fixed!

Nov 19 2020, 6:46 PM

Nov 6 2020

jmg committed rS367434: fix up docs, if signature checking is enabled, the file MUST exist....
fix up docs, if signature checking is enabled, the file MUST exist...
Nov 6 2020, 10:11 PM
jmg added a comment to D26617: Rename DISTDIR to RELDISTDIR to avoid clash with ports DISTDIR defined in make.conf.

Yes, can we please get this committed ASAP? I just spent some time debugging this problem. (Other solution would be for base not to read /etc/make.conf, but I have a feeling this commit is more likely.)

Nov 6 2020, 12:33 AM

Nov 4 2020

jmg committed rS367354: fix the docs, this was always wrong... In some cases, DISTDIR is set.
fix the docs, this was always wrong... In some cases, DISTDIR is set
Nov 4 2020, 11:26 PM

Oct 26 2020

jmg committed rS367048: update write(2)'s iovec limit w/ info about the iosize_max_clamp sysctl....
update write(2)'s iovec limit w/ info about the iosize_max_clamp sysctl...
Oct 26 2020, 12:37 AM

Oct 8 2020

jmg updated the diff for D26713: enable firstboot configuration for arm images.
  • minor spelling and grammar fixups. (was originally included)
  • revert this change... (release.sh)
  • remove whitespace at end of the copyright lines..
Oct 8 2020, 6:53 PM
jmg added inline comments to D26713: enable firstboot configuration for arm images.
Oct 8 2020, 12:21 AM
jmg added a comment to D26713: enable firstboot configuration for arm images.

I am planning on committing 1 and 2 individually.

Oct 8 2020, 12:19 AM
jmg requested review of D26713: enable firstboot configuration for arm images.
Oct 8 2020, 12:06 AM

Oct 6 2020

jmg committed rS366502: add the FILESYSTEMS placeholder and note that it's the default….
add the FILESYSTEMS placeholder and note that it's the default…
Oct 6 2020, 10:53 PM

Sep 15 2020

jmg added a comment to D26220: Improve test coverage for sbuf.

@jmg @imp I have seen other places where KASSERT was re-defined as

#define	KASSERT(exp,msg) assert((exp))
Sep 15 2020, 6:41 PM · tests
jmg committed rS365738: MFC r365623: Don't clear reserved bits per RealTek.
MFC r365623: Don't clear reserved bits per RealTek
Sep 15 2020, 12:22 AM

Sep 14 2020

jmg committed rS365730: MFC r365623: Don't clear reserved bits per RealTek.
MFC r365623: Don't clear reserved bits per RealTek
Sep 14 2020, 7:40 PM

Sep 12 2020

jmg committed rS365648: A major update to the ure driver..
A major update to the ure driver.
Sep 12 2020, 12:33 AM
jmg closed D25809: major update to if_ure.
Sep 12 2020, 12:33 AM
jmg added a comment to D26395: cp: fall back to read/write if copy_file_range fails.

Might I suggest that you enable NetBSD's cp tests, and add necessary tests to prevent this breakage again?

Sep 12 2020, 12:23 AM

Sep 11 2020

jmg committed rS365623: Don't clear reserved bits per RealTek.
Don't clear reserved bits per RealTek
Sep 11 2020, 2:02 AM

Sep 8 2020

jmg updated the diff for D25809: major update to if_ure.

minor update to include some new register definitions.. unused for now..

Sep 8 2020, 5:50 PM

Sep 4 2020

jmg updated the diff for D25809: major update to if_ure.

don't overwrite the RCR register, keep some bits set. This gets
MTU up to 4096 - mumble working w/o my devices crashing...

Sep 4 2020, 1:37 AM

Sep 2 2020

jmg requested review of D26305: search does not work with multiple sites listed.
Sep 2 2020, 8:58 PM
jmg added a comment to D26220: Improve test coverage for sbuf.
In D26220#584521, @imp wrote:

@jmg @imp Need your input how to proceed on the sbuf_negative test.

I'm having trouble understanding its purpose. Maybe you could give a one or two sentence summary of what it should test?

@imp I am assuming the sbuf_new_negative_test is supposed to test for cases for which sbuf_new fails to create a sbuf.

From sys/kern/subr_sbuf.c

	KASSERT(length >= 0,
	    ("attempt to create an sbuf of negative length (%d)", length));
	KASSERT((flags & ~SBUF_USRFLAGMSK) == 0,
	    ("%s called with invalid flags", __func__));

or when SBMALLOC fails..

Sep 2 2020, 6:50 PM · tests

Sep 1 2020

jmg updated the diff for D25809: major update to if_ure.

move some debug prints to before the error...

Sep 1 2020, 11:50 PM
jmg committed rS365062: add Xr to device_get_sysctl(9) to make this easier to find.
add Xr to device_get_sysctl(9) to make this easier to find
Sep 1 2020, 8:43 PM

Aug 11 2020

jmg committed rS364132: since kld_deb.py was removed a while back, this script isn't useful.
since kld_deb.py was removed a while back, this script isn't useful
Aug 11 2020, 10:34 PM

Aug 10 2020

jmg added a comment to D24914: Make sure the multicast release tasks are properly drained when destroying VNET and IFNET.

Thanks for committing this. I've run the patch for a while, and it solves my panic, and didn't introduce any others.

Aug 10 2020, 6:47 PM

Jul 30 2020

jmg closed D25874: remove some serial drivers (rc, rp, cy).

commited in https://reviews.freebsd.org/rS363683

Jul 30 2020, 6:08 AM
jmg committed rS363683: remove some long abandonded serial drivers (cy, rc, rp) since 2008.
remove some long abandonded serial drivers (cy, rc, rp) since 2008
Jul 30 2020, 12:54 AM

Jul 29 2020

jmg committed rS363674: add link to crypto(7) page, and drop a link to unrelated crypt(3) page...
add link to crypto(7) page, and drop a link to unrelated crypt(3) page..
Jul 29 2020, 9:15 PM
jmg added a comment to D25874: remove some serial drivers (rc, rp, cy).

Removed manual pages need to be added to ObsoleteFiles.inc as well.

Jul 29 2020, 7:34 PM
jmg updated the diff for D25874: remove some serial drivers (rc, rp, cy).

didn't complain about missing file on command line, that being
rp's module dir..

Jul 29 2020, 8:56 AM
jmg updated the diff for D25874: remove some serial drivers (rc, rp, cy).

forgot to remove from files..

Jul 29 2020, 8:05 AM
jmg updated the summary of D25874: remove some serial drivers (rc, rp, cy).
Jul 29 2020, 7:01 AM
jmg updated the diff for D25874: remove some serial drivers (rc, rp, cy).

too smart w/ command line, include the rest of the files..

Jul 29 2020, 7:01 AM
jmg requested review of D25874: remove some serial drivers (rc, rp, cy).
Jul 29 2020, 6:59 AM

Jul 27 2020

jmg added a comment to D25809: major update to if_ure.

I'll wait to get a few more reports of tests before committing..

Jul 27 2020, 6:28 PM
jmg added a comment to D25809: major update to if_ure.

ok, these should address all of your comments.

Jul 27 2020, 1:46 AM
jmg updated the diff for D25809: major update to if_ure.

update to address hselasky's comments.

Jul 27 2020, 1:46 AM
jmg updated the diff for D25809: major update to if_ure.

make it relative to HEAD.. Post white space commit..

Jul 27 2020, 1:18 AM

Jul 25 2020

jmg requested review of D25809: major update to if_ure.
Jul 25 2020, 10:52 PM
jmg committed rS363531: clean up whitespace....
clean up whitespace...
Jul 25 2020, 6:09 PM

Jul 24 2020

jmg committed rS363468: fix up docs for m_getjcl as well...
fix up docs for m_getjcl as well..
Jul 24 2020, 12:47 AM
jmg committed rS363467: document that m_get2 only accepts up to MJUMPAGESIZE...
document that m_get2 only accepts up to MJUMPAGESIZE..
Jul 24 2020, 12:35 AM

Jul 23 2020

jmg added a comment to D25697: minor improvements to man9 + MLINKs update.

I'm going to commit the change (which the grammar fix) in the next day or two if I don't get any more feedback.

Jul 23 2020, 11:24 PM
jmg committed rS363462: update example to make it active when creating a new boot method....
update example to make it active when creating a new boot method...
Jul 23 2020, 10:28 PM

Jul 17 2020

jmg added a comment to D17541: update ZFS to note support of extended attributes.

Yes a PR clarifying this in OpenZFS would be greatly appreciated. Any change here would only be good for MFC. I think the wording suggested by @delphij is a bit more clear.

Jul 17 2020, 8:01 PM
jmg added a comment to D17541: update ZFS to note support of extended attributes.

@freqlabs let ms know if you just want to integrate this into the OpenZFS update, or what.

Jul 17 2020, 7:02 PM
jmg added a comment to D21017: armv8crypto: add AES-XTS support.

Looks fine. You should look at unrolling the loop to 3 or 4 rounds. Looking at the A72 optimization guide, it shows that there is a 3 cycle latency, but throughput of 1. Section 4.10 gives example showing three pairs to achieve max perf.

Jul 17 2020, 1:01 AM · arm64

Jul 16 2020

jmg committed rS363265: add script to help figure out what man pages need MLINKS updated....
add script to help figure out what man pages need MLINKS updated...
Jul 16 2020, 11:05 PM
jmg added a reviewer for D25682: tests/sys/opencrypto: use python3: ngie.

Looks good to me. I'm adding ngie as they did the port to Python 3. I have not run and verified that this works under Python 3, but fully support the move to 3.

Jul 16 2020, 10:39 PM
jmg requested review of D25697: minor improvements to man9 + MLINKs update.
Jul 16 2020, 10:08 PM

Jun 7 2020

jmg added a comment to D21886: Add USB support for location based device unit numbers.
In D21886#554614, @imp wrote:

Cool script. It would be better to add the alias with devfs. Then it would disappear w/o devd needing all the info...

Jun 7 2020, 3:13 AM

Jun 6 2020

jmg added a comment to D21886: Add USB support for location based device unit numbers.

I took Daniel O'Connor's script from: https://www.mail-archive.com/freebsd-usb@freebsd.org/msg14258.html

Jun 6 2020, 10:42 PM

May 24 2020

jmg added a comment to D24987: Update platform docs for arm.

a later diff has addressed these comments.

May 24 2020, 8:30 PM
jmg added a comment to D24987: Update platform docs for arm.

these should not have been marked done. Why phab did this I have no clue. Maybe they think that if you update a patch you address all of your comments, but that is a TERRIBLE assumption to make.

May 24 2020, 8:29 PM
jmg updated the diff for D24987: Update platform docs for arm.

update with comments from manu

May 24 2020, 8:28 PM
jmg added inline comments to D24987: Update platform docs for arm.
May 24 2020, 8:18 PM
jmg updated the diff for D24987: Update platform docs for arm.

add the path to the diff...

May 24 2020, 8:15 PM