- User Since
- Sep 2 2014, 10:55 PM (308 w, 6 d)
Thu, Jul 30
commited in https://reviews.freebsd.org/rS363683
Wed, Jul 29
didn't complain about missing file on command line, that being
rp's module dir..
forgot to remove from files..
too smart w/ command line, include the rest of the files..
Mon, Jul 27
I'll wait to get a few more reports of tests before committing..
ok, these should address all of your comments.
update to address hselasky's comments.
make it relative to HEAD.. Post white space commit..
Sat, Jul 25
Fri, Jul 24
Thu, Jul 23
I'm going to commit the change (which the grammar fix) in the next day or two if I don't get any more feedback.
Fri, Jul 17
@freqlabs let ms know if you just want to integrate this into the OpenZFS update, or what.
Looks fine. You should look at unrolling the loop to 3 or 4 rounds. Looking at the A72 optimization guide, it shows that there is a 3 cycle latency, but throughput of 1. Section 4.10 gives example showing three pairs to achieve max perf.
Thu, Jul 16
Looks good to me. I'm adding ngie as they did the port to Python 3. I have not run and verified that this works under Python 3, but fully support the move to 3.
Jun 7 2020
Jun 6 2020
I took Daniel O'Connor's script from: https://firstname.lastname@example.org/msg14258.html
May 24 2020
a later diff has addressed these comments.
these should not have been marked done. Why phab did this I have no clue. Maybe they think that if you update a patch you address all of your comments, but that is a TERRIBLE assumption to make.
update with comments from manu
add the path to the diff...
May 21 2020
If you want to test, you generate a self sign cert:
openssl req -x509 -newkey rsa:4096 -keyout key.pem -out cert.pem -days 365
Tested and working.
May 20 2020
Sorry, got a bit excited that things worked.
This booted on my 07S board w/o me having to set hw.ncpu in loader!
May 19 2020
I just tested this on my Cora Z7-07S board, and it looks like there's a hardware bug that prevents this patch from working.
May 17 2020
Thanks, I'll look at committing this. I have a Cora Z7 that needs this.
May 16 2020
Oct 23 2019
Is there a reason this hasn't been committed?
Oct 17 2019
Oct 9 2019
Sep 16 2019
Aug 15 2019
Nov 25 2018
Yeah, after a bit of splunking after writing that comment, I discovered that it was unused.
Nov 24 2018
why was this removed? This was necessary to prevent lock inversion due to a kq being in another kq...
Nov 14 2018
Nov 5 2018
Oct 28 2018
oh, don't forget to bump date!
looks good! Thanks!
Oct 25 2018
Now that memset_s is part of the standard, should we just make explicit_bzero a wrapper for memset_s?
Oct 12 2018
Sep 16 2018
Sep 10 2018
For reference, on an active pf firewall, before the patch, ~1.56% cpu core was used on the purge thread, after the patch, .427% cpu core. over a third less CPU. This is with the same 128k hash table size.
Sep 9 2018
CPU usage calculated by taking the time pf purge ran and dividing it by the difference between now, and lstart:
ps -ax -o lstart,time,command | grep pf; date
Sun Sep 9 16:31:23 2018 0:30.95 [pf purge]
Sun Sep 9 19:33:53 2018 0:00.02 grep pf
Sun Sep 9 19:33:53 UTC 2018
note, if you apply the diff and check it w/ svn diff -x -wb, you'll see that the only change is the comment, the if, and the braces.
Sep 1 2018
All comments are minor.
Aug 29 2018
ok, this should be ready to land.. Not going to update printf(9),
that'll be a different patch, and there are missing vprintf and vlog
from the body of the man page...
Aug 28 2018
add fix for when printf returns an error, pass the error up
correctly.. prf_buf does not return an error..
All but the printf error is addressed, and the next patch will address this issue.
Fix most of the issues. I will address the cast to int w/ a KASSERT in another update.
Update and address various comments.
Aug 24 2018
simple fix, limit local_read_rate to be 0 or 1. Even more simple that the fix that was committed.
I'll update the patch shortly. Thanks for the review.
Aug 23 2018
This does add some tests that were missing. I can commit those and the MLINK for _putbuf separately if people would like. I'm also fine breaking out the sys/kern/subr_bus.c changes as well.
Update. Use a new created printf drain function that works in both
userland and kernel. Document the function, and add tests for it.
Please commit these patches separately. They deal w/ different issues.
IMO, looks good to me.
Aug 21 2018
Aug 20 2018
Working on testing sbuf, and adding new drain function from printing, w/ both a userland and kernel versions of the function.
Aug 19 2018
Aug 17 2018
Thanks for the comments, you solved some of the issues I knew about and didn't know how to solve best.
Aug 16 2018
Should powerpc64 be added too?
Aug 12 2018
Aug 10 2018
Aug 9 2018
looks fine. Agree that conditioned output should be used. We do our own conditioning so it wouldn't be a major problem to use the raw, but the raw will likely have less entropy.
Jul 18 2018
looks good. Thanks.
Jun 25 2018
I cannot comment on this as __pure2 is not documented, so I don't know the expected semantics of adding that define.
Jun 2 2018
Oh, note that the above are my opinions, and they differ significantly from most of the rest of the FreeBSD team. Mainly why I haven't spent much time working on the rng system,