Page MenuHomeFreeBSD

gjb (Glen Barber)
Release Engineering Lead

Projects

User Details

User Since
Nov 24 2013, 2:14 AM (462 w, 3 d)

I do not receive Phabricator email, because I am tired of the spam it generates.

Add me as a reviewer to get my attention.

Send me an email out-of-band if I do not respond.

Recent Activity

Today

gjb accepted D36704: Update tip for adding a user to wheel:.

Apologies for the delay, and thank you for pinging about it. Approved.

Wed, Oct 5, 12:32 PM
gjb accepted D36879: bsdinstall: Fix race condition when shutting down after installation.

Minor nit: please adjust the first line of the commit log message to fit within 80 characters. Otherwise, looks good to me.

Wed, Oct 5, 12:29 PM

Mon, Oct 3

gjb accepted D30004: Add sections to the handbook on cpu frequency control.
Mon, Oct 3, 5:01 PM
gjb committed R9:0d79b6a8e5ff: 13.1 and 13.2 relnotes: fix a typo (authored by gjb).
13.1 and 13.2 relnotes: fix a typo
Mon, Oct 3, 2:00 PM

Fri, Sep 30

gjb accepted D36803: bsdinstall release: Move code to a new startbsdinstall wrapper.
Fri, Sep 30, 3:50 PM
gjb accepted D36804: bsdinstall: Add a new runconsoles helper binary.
Fri, Sep 30, 3:50 PM
gjb accepted D36805: bsdinstall release: Start installer on multiple consoles.
Fri, Sep 30, 3:47 PM

Thu, Sep 29

gjb committed R9:8321c86562b4: 12.4 release: reminder email had been sent (authored by gjb).
12.4 release: reminder email had been sent
Thu, Sep 29, 11:49 PM
gjb committed R9:e895421d20ec: 13.2 release: add relnotes template (authored by gjb).
13.2 release: add relnotes template
Thu, Sep 29, 4:49 PM
gjb committed R9:86aefa44ff7a: 12.4 release: update miscellaneous information (authored by gjb).
12.4 release: update miscellaneous information
Thu, Sep 29, 4:45 PM
gjb committed R9:5da814778181: 12.4 release: add relnotes template (authored by gjb).
12.4 release: add relnotes template
Thu, Sep 29, 4:41 PM

Tue, Sep 27

gjb accepted D36737: Copyedit the legacy releng blurb..

Approved.

Tue, Sep 27, 2:58 PM

Fri, Sep 23

gjb accepted D36681: FreeBSD Handbook: FreeBSD Boot Process: GNU GRUB.

Approved, once @bcr's comments are addressed.

Fri, Sep 23, 7:01 PM
gjb accepted D36668: Track removal of Tokenring and FDDI media types from devd.cc..

Approved.

Fri, Sep 23, 1:34 AM
gjb accepted D36676: sidenav.html: remove 13.0, add 14.0.

Approved.

Fri, Sep 23, 1:33 AM

Tue, Sep 20

gjb added a comment to D36635: release: Use standard mount points for arm MBR boot images.
In D36635#831806, @imp wrote:
In D36635#831793, @gjb wrote:
In D36635#831784, @manu wrote:
In D36635#831783, @gjb wrote:

I cannot think of any place off-hand (in the build process) where it is explictly encoded/hard-coded. However, I cannot speak to things like DTS files or the like.

DTS are loaded only from u-boot and overlays from the /boot/dtb/ directory (so on UFS in the image), so no worries here.

Excellent, thank you for confirming.

So should I also change the label to EFI always?

Tue, Sep 20, 6:06 PM
gjb added a comment to D36635: release: Use standard mount points for arm MBR boot images.
In D36635#831784, @manu wrote:
In D36635#831783, @gjb wrote:

I cannot think of any place off-hand (in the build process) where it is explictly encoded/hard-coded. However, I cannot speak to things like DTS files or the like.

DTS are loaded only from u-boot and overlays from the /boot/dtb/ directory (so on UFS in the image), so no worries here.

Tue, Sep 20, 5:19 PM
gjb added a comment to D36635: release: Use standard mount points for arm MBR boot images.
In D36635#831778, @imp wrote:

Isn't the point that it's not just EFI, because all the MBR images are ones that have RPI firmware files?

The label should be consistent with the mount point, regardless.

Yes. The pre-EFI days we had to have a number of files on a FAT partition (or in the first 2MB of the drive) that were used to get u-boot loaded... and that loaded ubldr in days of yore, but now loads the /efi/boot/bootxxx.efi file. This has transitioned from fixed areas in the first part of the disk to GPT partitions (which coincidentally cover the same space) since the early boot files now understand GPT these days. The ROMs in the old arm (esp armv4/armv5) SoCs were definitely limited in what they could do (and I did over-state that u-boot is the only one that cares about partitioning... some of them loaded off fixed areas, others loaded fixed files in the first FAT partition they found).

I'm less confident in changing the label itself. But I can't come up with a good reason to keep the old other than 'I worry that it may be encoded someplace else'...

Tue, Sep 20, 5:08 PM
gjb added inline comments to D36635: release: Use standard mount points for arm MBR boot images.
Tue, Sep 20, 3:17 PM
gjb added a comment to D36635: release: Use standard mount points for arm MBR boot images.

Huh, we previously created both /boot/efi and /boot/msdos, but only used one or the other depending on GPT/MBR? That's unfortunate.

Tue, Sep 20, 2:41 PM
gjb accepted D23327: add mergemaster(8) deprecation notice.

Perhaps bump .Dd, too, when you are ready to commit.

Tue, Sep 20, 2:38 PM
gjb accepted D36635: release: Use standard mount points for arm MBR boot images.
Tue, Sep 20, 2:36 PM

Wed, Sep 7

gjb committed R9:8f94e441d014: 14.0: s/head/main/ for consistency (authored by gjb).
14.0: s/head/main/ for consistency
Wed, Sep 7, 6:07 PM
gjb committed R9:9e7d6f062362: release: schedules - comment MFC note until the cycles start (authored by gjb).
release: schedules - comment MFC note until the cycles start
Wed, Sep 7, 6:02 PM

Sep 2 2022

gjb accepted D36419: release: Set loader_menu_multi_user_prompt to "Installer" for installer.
Sep 2 2022, 12:09 AM

Aug 24 2022

gjb committed R9:69d73b6ae6fd: 12.4: spell 2022 correctly (authored by gjb).
12.4: spell 2022 correctly
Aug 24 2022, 5:46 PM

Aug 19 2022

gjb committed R9:bedd831197b9: release: remove reference to sysutils/bsdstats (authored by gjb).
release: remove reference to sysutils/bsdstats
Aug 19 2022, 9:25 PM
gjb committed R9:46fa2ec3610e: release: add 12.3 and 13.2 to the sidenav bar (authored by gjb).
release: add 12.3 and 13.2 to the sidenav bar
Aug 19 2022, 9:16 PM
gjb committed R9:16f2ceb01ea3: release: add 12.4 and 13.2 to the index page as upcoming releases (authored by gjb).
release: add 12.4 and 13.2 to the index page as upcoming releases
Aug 19 2022, 9:16 PM
gjb committed R9:7846c78e4ba3: release: add schedule for 14.0-RELEASE (authored by gjb).
release: add schedule for 14.0-RELEASE
Aug 19 2022, 8:54 PM
gjb committed R9:10c2854852c0: release: link 12.4, 13.2, and 14.0 schedules to the releng page (authored by gjb).
release: link 12.4, 13.2, and 14.0 schedules to the releng page
Aug 19 2022, 8:54 PM
gjb committed R9:6d8c97bfa5f5: release: add schedule for 13.2-RELEASE (authored by gjb).
release: add schedule for 13.2-RELEASE
Aug 19 2022, 8:54 PM
gjb committed R9:53949fba11e4: release: add schedule for 12.4-RELEASE (authored by gjb).
release: add schedule for 12.4-RELEASE
Aug 19 2022, 8:54 PM

Aug 17 2022

gjb committed R11:d2bee5f2e054: security/clamd-stream-client: drop maintainership (authored by gjb).
security/clamd-stream-client: drop maintainership
Aug 17 2022, 7:10 PM

Aug 11 2022

gjb committed R9:c7897c47b078: administration: update the doceng member list (authored by gjb).
administration: update the doceng member list
Aug 11 2022, 8:12 PM
gjb committed R9:96dcaee26c77: admninistration: update doceng-secretary (authored by gjb).
admninistration: update doceng-secretary
Aug 11 2022, 6:30 PM
gjb committed rGf6cfa91f4d6b: release: fix alignment for arm SoCs (authored by gjb).
release: fix alignment for arm SoCs
Aug 11 2022, 3:17 AM
gjb committed rG9168218160ca: release: fix alignment for arm SoCs (authored by gjb).
release: fix alignment for arm SoCs
Aug 11 2022, 3:17 AM

Aug 8 2022

gjb committed rG45add40717c2: release: fix alignment for arm SoCs (authored by gjb).
release: fix alignment for arm SoCs
Aug 8 2022, 3:01 PM

Aug 1 2022

gjb added a comment to D34746: add minimal OCI-compliant image builder.
In D34746#817400, @dch wrote:

do we need anything further to commit this yet?

Aug 1 2022, 7:44 PM

Jul 28 2022

gjb added a member for committers: carlavilla.
Jul 28 2022, 12:32 PM
gjb added a member for committers: grahamperrin.
Jul 28 2022, 12:32 PM

Jul 25 2022

gjb accepted D35819: Upgrade ports intalling section.

Err... I lost track of who sent the latest review. You don't need approval. :)

Jul 25 2022, 5:57 PM

Jul 19 2022

gjb accepted D35858: release: Include an etcupdate tree in -DNO_ROOT release image builds.

I'm okay with this as long as @jhb is. Looks good to me, though.

Jul 19 2022, 8:28 PM
gjb accepted D35855: release: Forward ${MAKE} to etcupdate via the new -m flag.
Jul 19 2022, 8:27 PM
gjb accepted D35853: release: Use in-tree etcupdate for build.

Weird this wasn't discovered sooner. Good catch.

Jul 19 2022, 8:26 PM

Jul 18 2022

gjb accepted D35838: New Account Creation Procedure: correct two links.

Approved.

Jul 18 2022, 4:56 PM
gjb accepted D35803: Update share/misc/committers-*.dot comments for git..

Doc committers can commit to all three repositories for doc-related items, so no explicit permission is necessary unless you are under mentorship.

Jul 18 2022, 4:45 PM
gjb accepted D35768: New committer (doc): Pau Amma.

Yes, please go ahead.

Jul 18 2022, 4:43 PM

Jul 15 2022

gjb accepted D35746: committers-doc.dot: add grahamperrin.
Jul 15 2022, 6:30 PM

Jul 14 2022

gjb accepted D35816: amd64.adoc: Modernize the list of amd64 examples.
Jul 14 2022, 3:25 PM
gjb added a comment to D35814: release: Support GNU stat in mkisoimages.sh.
In D35814#812882, @gjb wrote:

I do not object to the change, but I would prefer to test uname -s against "FreeBSD" and reverse the if/else logic. But I will not complain too loudly about this nit.

macOS wants the FreeBSD behaviour; currently Linux is the exception. I could flip it with != Linux, but if != .. else feels wrong to write.

Jul 14 2022, 3:13 PM
gjb accepted D35814: release: Support GNU stat in mkisoimages.sh.

I do not object to the change, but I would prefer to test uname -s against "FreeBSD" and reverse the if/else logic. But I will not complain too loudly about this nit.

Jul 14 2022, 3:03 PM
gjb accepted D35813: Makefile.inc1 release bsd.own.mk: Introduce and use TAR_CMD.
Jul 14 2022, 3:01 PM

Jul 13 2022

gjb committed rGc7bb57f17fef: release: increase IMAGE_SIZE for arm, arm64, riscv (authored by gjb).
release: increase IMAGE_SIZE for arm, arm64, riscv
Jul 13 2022, 6:39 PM
gjb committed rG1dfcff294e44: release: increase IMAGE_SIZE for arm, arm64, riscv (authored by gjb).
release: increase IMAGE_SIZE for arm, arm64, riscv
Jul 13 2022, 6:38 PM
gjb committed R9:184690fad5f2: 13.1: document RISCV VM-IMAGE removal (authored by gjb).
13.1: document RISCV VM-IMAGE removal
Jul 13 2022, 11:24 AM

Jul 12 2022

gjb committed R9:52fb1e279947: 13.1: comment riscv VM-IMAGES links (authored by gjb).
13.1: comment riscv VM-IMAGES links
Jul 12 2022, 8:21 PM

Jul 11 2022

gjb added inline comments to D35768: New committer (doc): Pau Amma.
Jul 11 2022, 3:13 PM
gjb added inline comments to D35768: New committer (doc): Pau Amma.
Jul 11 2022, 2:58 PM
gjb accepted D35768: New committer (doc): Pau Amma.
Jul 11 2022, 2:47 PM

Jul 7 2022

gjb accepted D35746: committers-doc.dot: add grahamperrin.

Approved.

Jul 7 2022, 6:50 PM

Jul 2 2022

gjb added a comment to D35692: New committer: Pau Amma (docs), steps 1-4.

You have been added to the access and mentors files. Fire away at your convenience.

Jul 2 2022, 2:25 AM
gjb accepted D35692: New committer: Pau Amma (docs), steps 1-4.

Approved. Give me a minute to add you to mentors/access files.

Jul 2 2022, 2:23 AM

Jul 1 2022

gjb committed R9:497735a86188: 13.1: belatedly document the branch is handed over to secteam (authored by gjb).
13.1: belatedly document the branch is handed over to secteam
Jul 1 2022, 4:08 PM

Jun 22 2022

gjb committed rG423871b226ea: release: arm - increase IMAGE_SIZE (authored by gjb).
release: arm - increase IMAGE_SIZE
Jun 22 2022, 6:25 PM
gjb committed rGcf83038cec68: release: arm - increase IMAGE_SIZE (authored by gjb).
release: arm - increase IMAGE_SIZE
Jun 22 2022, 6:24 PM

Jun 15 2022

gjb accepted D35495: Mention AMD Zen processor support (Epyc/Ryzen) in 13.1 release notes.
Jun 15 2022, 7:43 PM

Jun 13 2022

gjb added a comment to D35445: pkg-bootstrap: use latest package set on arm64 stable branches.

Apologies - I meant to look over this during the weekend, but then life happened...

Jun 13 2022, 7:22 PM

Jun 2 2022

gjb committed R9:41f9dcd33071: releng: replace 'so' with 'security-officer' for consistency (authored by gjb).
releng: replace 'so' with 'security-officer' for consistency
Jun 2 2022, 5:42 PM
gjb committed R9:5e142f9fdf46: releng: hand over releng/13.1 to so@/security-officer@ (authored by gjb).
releng: hand over releng/13.1 to so@/security-officer@
Jun 2 2022, 3:01 PM

May 31 2022

gjb committed R9:2d7aa6834f0f: releng: Remove 13.1 from upcoming releases (authored by gjb).
releng: Remove 13.1 from upcoming releases
May 31 2022, 1:14 PM

May 27 2022

gjb accepted D35330: bsdinstall: allow a install script to access packages on the DVD.
May 27 2022, 3:21 PM
gjb added inline comments to D35330: bsdinstall: allow a install script to access packages on the DVD.
May 27 2022, 2:08 PM
gjb accepted D35329: Replace subversion with git in the installation DVD.
May 27 2022, 2:06 PM

May 19 2022

gjb committed R9:d7765e8a1a66: where.html: re-enable 13-STABLE snapshot download links (authored by gjb).
where.html: re-enable 13-STABLE snapshot download links
May 19 2022, 8:19 PM
gjb committed R9:6c56a248d292: SA/EN templates: update for 13.1-RELEASE inclusion (authored by gjb).
SA/EN templates: update for 13.1-RELEASE inclusion
May 19 2022, 2:47 PM
gjb committed R9:1bf0fbc379fa: security: add releng/13.1 to supported releases (authored by gjb).
security: add releng/13.1 to supported releases
May 19 2022, 2:08 PM

May 17 2022

gjb added inline comments to D34746: add minimal OCI-compliant image builder.
May 17 2022, 7:59 PM

May 16 2022

gjb committed R9:5db70ab17b91: man.cgi: update to include 13.1-RELEASE (authored by gjb).
man.cgi: update to include 13.1-RELEASE
May 16 2022, 8:43 PM
gjb committed R9:b02dc86be46d: 13.1: installation: fix version numbers (authored by gjb).
13.1: installation: fix version numbers
May 16 2022, 8:36 PM
gjb committed R9:5fefb0f67d68: 13.1: prune stale entries (authored by gjb).
13.1: prune stale entries
May 16 2022, 8:32 PM
gjb committed R9:831e4e8cf9fd: Announce 13.1-RELEASE (authored by gjb).
Announce 13.1-RELEASE
May 16 2022, 8:24 PM
gjb committed R9:c87b07bdc9b6: 13.1: add errata (authored by gjb).
13.1: add errata
May 16 2022, 8:24 PM
gjb committed R9:83abc3a47ba4: 13.1: add hardware (authored by gjb).
13.1: add hardware
May 16 2022, 8:24 PM
gjb committed R9:c6d8953ecb53: 13.1: add installation (authored by gjb).
13.1: add installation
May 16 2022, 8:24 PM
gjb committed R9:493b1b5ef8cc: 13.1: add readme (authored by gjb).
13.1: add readme
May 16 2022, 8:24 PM
gjb committed R9:59fccfaafc54: 13.1: add RELEASE checksums, prune RC6 checksums (authored by gjb).
13.1: add RELEASE checksums, prune RC6 checksums
May 16 2022, 8:24 PM
gjb committed R11:911fa5503bd8: misc/freebsd-release-manifests: add 13.1 RELEASE, prune RC6 (authored by gjb).
misc/freebsd-release-manifests: add 13.1 RELEASE, prune RC6
May 16 2022, 8:18 PM
gjb committed R11:1cd3adc56526: misc/freebsd-release-manifests: add 13.1 RELEASE, prune RC6 (authored by gjb).
misc/freebsd-release-manifests: add 13.1 RELEASE, prune RC6
May 16 2022, 8:17 PM

May 15 2022

gjb closed D35212: 13.1-RELEASE note: fsck_ffs: background fsck.
May 15 2022, 5:05 PM
gjb accepted D35212: 13.1-RELEASE note: fsck_ffs: background fsck.
May 15 2022, 5:04 PM
gjb closed D35211: 13.1-RELEASE note: UEFI boot is improved for amd64.
May 15 2022, 5:04 PM
gjb accepted D35211: 13.1-RELEASE note: UEFI boot is improved for amd64.
May 15 2022, 5:04 PM
gjb committed R9:9b6154ac2adc: 13.1 relnotes: add note regarding fsck_ffs background fsck (authored by grahamperrin).
13.1 relnotes: add note regarding fsck_ffs background fsck
May 15 2022, 5:02 PM
gjb committed R9:4f8240b0d997: 13.1 relnotes: add note about UEFI improvements (authored by grahamperrin).
13.1 relnotes: add note about UEFI improvements
May 15 2022, 5:02 PM

May 12 2022

gjb committed rGfc952ac2212b: Update in preparation of 13.1-RELEASE (authored by gjb).
Update in preparation of 13.1-RELEASE
May 12 2022, 12:01 AM
gjb committed R9:02fdfdbe9045: 13.1: update the schedule to reflect RELEASE builds have started (authored by gjb).
13.1: update the schedule to reflect RELEASE builds have started
May 12 2022, 12:00 AM

May 11 2022

gjb committed R9:bcceaf6deef3: freebsd-releng: fix a file path (authored by gjb).
freebsd-releng: fix a file path
May 11 2022, 11:23 PM

May 6 2022

gjb committed R9:c4c96dee7d57: 13.1: prune checksums for RC5 (authored by gjb).
13.1: prune checksums for RC5
May 6 2022, 1:21 AM