Page MenuHomeFreeBSD

gjb (Glen Barber)
Release Engineering Lead

Projects

User Details

User Since
Nov 24 2013, 2:14 AM (408 w, 4 d)

I do not receive Phabricator email, because I am tired of the spam it generates.

Add me as a reviewer to get my attention.

Send me an email out-of-band if I do not respond.

Recent Activity

Tue, Sep 21

gjb committed R9:20267508e4d1: Remove gabor from the doceng list per his request (authored by gjb).
Remove gabor from the doceng list per his request
Tue, Sep 21, 6:49 PM
gjb committed R9:02910aa5ae75: Bump PGP key expiration (authored by gjb).
Bump PGP key expiration
Tue, Sep 21, 3:20 AM

Mon, Sep 20

gjb committed R9:f12aa30cf966: fix rendering for the URL to EN-21:18.libc++ (authored by gjb).
fix rendering for the URL to EN-21:18.libc++
Mon, Sep 20, 9:17 PM

Tue, Sep 7

gjb added a comment to D31134: Add FriendlyArm NanoPi R4S config for generation of release images.

Can we please continue the discussion if it is feasible to add more images/boards to the release scripts?

Tue, Sep 7, 3:38 PM

Tue, Aug 24

gjb committed R9:0b9aaa5bfe4d: 13.0-RELEASE: fix path to riscv/riscv64 checksum URLs (authored by gjb).
13.0-RELEASE: fix path to riscv/riscv64 checksum URLs
Tue, Aug 24, 6:28 PM

Aug 17 2021

gjb accepted D31590: Increase partition limit size for boot code.
Aug 17 2021, 6:30 PM
gjb accepted D31587: Improvements to growfs rc script.
Aug 17 2021, 5:15 PM

Aug 14 2021

gjb added a comment to D30239: Add ALLOW_OSVERSION_MISMATCH flag to bsd.ports.mk.
In D30239#710984, @gjb wrote:

Thank you for the detailed explanation. I understand I am hard to deal with on this. I think upon human behavior sporadically and it is impossible for us to communicate our true thoughts, beliefs, or assumptions, or to easily break out of our own perspectives or assumptions. Especially over body-free text. I will try to communicate here in a way that avoids those pitfalls. Please do the same and assume I am asking innocently questions. I only wish I could always have this mindset in text. I'm only saying all of this because I've personally gotten frustrated over this discussion a lot and I'm trying to approach it differently after discussion with the Poudriere user post-commit.
I like to understand things at too deep a level sometimes, in that I need to know the root cause. I suppose I prefer quicker paced communications like IRC, or a call, to get the details out, versus this back and forth mailing list thing we've been doing. I should have asked for details or listened better in the past, like 8 years ago or whenever you ran into it.

Aug 14 2021, 7:08 AM
gjb added a comment to D30239: Add ALLOW_OSVERSION_MISMATCH flag to bsd.ports.mk.

It has saved me at work before as well where we do cross-os-release builds and have to define the UNAME_* stuff anyway.

I chose to call it that because the flag IS DANGEROUS in the common case. The flag reflects the outcome if it is used and not understood. Anything benign is an open invitation for [not people here] ignorant users to use or suggest it.

Aug 14 2021, 12:49 AM

Jul 27 2021

gjb committed R10:27988b833300: bsdinstall: Only show menu if there are more items to be installed (authored by garga).
bsdinstall: Only show menu if there are more items to be installed
Jul 27 2021, 8:15 PM
gjb committed R10:3312bc6f109d: bsdinstall: Only show menu if there are more items to be installed (authored by garga).
bsdinstall: Only show menu if there are more items to be installed
Jul 27 2021, 8:07 PM
gjb committed R10:c3c458ce3c91: bsdinstall: Only show menu if there are more items to be installed (authored by garga).
bsdinstall: Only show menu if there are more items to be installed
Jul 27 2021, 8:07 PM

Jul 22 2021

gjb committed R10:95f0da5be1e3: bsdinstall: Only show menu if there are more items to be installed (authored by garga).
bsdinstall: Only show menu if there are more items to be installed
Jul 22 2021, 8:04 PM
gjb added a comment to D31134: Add FriendlyArm NanoPi R4S config for generation of release images.
In D31134#704406, @manu wrote:

I'm not sure that we want to add all possible image.
RPI was added because, unfortunately it's popular.
All the Pine devices are too and most have LTS status.
If we start adding every FriendlyElec we're in trouble because they release a lot of boards (like a lot).

Jul 22 2021, 4:36 PM

Jun 11 2021

gjb accepted D30739: Move the developer-centric bits from handbook/mirrors to committers-guide.
Jun 11 2021, 6:13 PM
gjb added a comment to D30239: Add ALLOW_OSVERSION_MISMATCH flag to bsd.ports.mk.

@bdrewery But don't you think that

  1. A feature request from an important consumer of the ports collection should be considered;
  2. There is a large number of ports where none of this (uname, osversion, etc.) matters anyway, at least in a development environment;
  3. It's better to be able to clearly express "I'm willing to allow a mismatch" vs. overriding an environment variable and pretend there is none?

@gjb @bdrewery Can you imagine to agree on some compromise?

Jun 11 2021, 1:06 AM

Jun 10 2021

gjb added a comment to D30239: Add ALLOW_OSVERSION_MISMATCH flag to bsd.ports.mk.

This isn't simply about host not matching the jail. It's more nuanced. The jail may not match the jail.

Does this change anything about the patch though (which in the end implements a force flag, which isn't nuanced at all)? Would you prefer a different name of the flag that emphasizes that you think this error shouldn't be ignored?

If people don't understand that I am strongly against anything like this going in. But what do I care if you shoot yourselves in the foot?

That's the very nature of providing force/override/ignore warning flags, people using them are on their own. This was raised by a couple of experienced engineers, who have their workflows disrupted by the current state of affairs.

My perspective is that we have re@ trying to use it without understanding the problem. It should not be used for any official builds.

As long as the default behavior doesn't change and therefore things stay safe for normal ports tree users, I don't see any negative consequences. People will shoot themselves in the foot anyway by patching the file manually, so having a flag will at least make sure they don't start using diverging local copies of bsd.port.mk.

I have no personal interest in this beyond trying to direct our energy towards more productive discussions, this doesn't seem like something worth fighting over and being subjected to a lot of negativity in the process.

The negativity is because the problem has not been understood since the check went in which has built up frustration over years, and now there is screaming to remove or allow disabling still without understanding the problem which is causing me to get frustrated. Misunderstandings breed frustration. Now everyone is frustrated. Let's slow down and try to understand.

Hopefully this clears up the problem:

  • When building a port it is possible for it to run uname to determine its target system (edit: and bake in different target runtime behavior). If that is coming back not matching the userland of the chroot/jail, how is that _ever ok_? 3rd party ports are far more likely to care about uname than __FreeBSD_version or any other FreeBSD-specific version lookup.
  • OSVERSION can probably always be determined automatically. A user does not need to mess with it so long as /usr/include/sys/param.h has a __FreeBSD_version that is expected for the target system.
  • OSVERSION ultimately determines *Ports framework behavior* and which patches are applied. It needs to be correct for the target system.
  • The only thing that someone trying to build in a chroot must do is ensure UNAME_r is correct.
    • Explain to me why it is easier for them to set ALLOW_OSVERSION_MISMATCH rather than modifying UNAME_r once every 2-3 years or making their chroot setup script do it auto based on git branch or something?
  • UNAME_r could probably be automatically determined from OSVERSION. That is a more sane proposal rather than ignoring the problem but I haven't thought deeply about it yet.

Please, anyone, explain to me why my points are wrong.

Please, anyone, explain to me what I am missing.

Jun 10 2021, 6:10 PM

May 30 2021

gjb accepted D30331: Add PDF targets to doc/documentation/Makefile.

I cannot accept this review, due to some permission problem. Consider this comment as 'accepted'.

May 30 2021, 7:12 PM

May 26 2021

gjb added a watcher for pfsense: gjb.
May 26 2021, 6:26 PM
gjb added a comment to D29923: arm: add a release conf for distribution files.
In D29923#678538, @gjb wrote:

Yes. There was a missing change to use the git repository for ports. They should be available this week.

Hi, just checking in again. I didn't see any output in the last two runs either, presumably there are still issues with the build?

May 26 2021, 2:41 PM

May 19 2021

gjb accepted D30265: Update references to en_US.ISO8859-1 documentation in src/.
May 19 2021, 10:19 PM · docs

May 17 2021

gjb committed R9:d9e11c39f75b: releng: add the section header back after the previous commit (authored by gjb).
releng: add the section header back after the previous commit
May 17 2021, 5:06 PM
gjb committed R9:e623fd791cdb: releng: comment the upcoming release section (authored by gjb).
releng: comment the upcoming release section
May 17 2021, 4:56 PM

May 13 2021

gjb committed R10:e256adf0e0d7: release.sh: pass UNAME_r for embedded builds (authored by gjb).
release.sh: pass UNAME_r for embedded builds
May 13 2021, 3:03 PM
gjb accepted D30239: Add ALLOW_OSVERSION_MISMATCH flag to bsd.ports.mk.

I personally prefer danfe's suggestion on the knob name, but yes, I think this works.

May 13 2021, 5:28 AM

May 12 2021

gjb committed R10:e2872019983d: release: fix ports checkout if /usr/ports does not exist (authored by gjb).
release: fix ports checkout if /usr/ports does not exist
May 12 2021, 4:11 PM
gjb committed R10:c0dbc49ab3f7: release: fix ports checkout if /usr/ports does not exist (authored by gjb).
release: fix ports checkout if /usr/ports does not exist
May 12 2021, 4:09 PM
gjb committed R10:0ed1051313c1: release: remove logic to locate the svn{,lite} binary (authored by gjb).
release: remove logic to locate the svn{,lite} binary
May 12 2021, 3:58 PM
gjb committed R10:929bf5b637c3: release: follow-up to previous commit to use Git for the ports tree (authored by gjb).
release: follow-up to previous commit to use Git for the ports tree
May 12 2021, 3:57 PM
gjb committed R10:18fe4221391f: release: update release.sh to use Git for ports tree checkouts (authored by gjb).
release: update release.sh to use Git for ports tree checkouts
May 12 2021, 3:57 PM
gjb committed R10:41f27ff22956: release: fix logic for ports update/checkout if the directory exists (authored by gjb).
release: fix logic for ports update/checkout if the directory exists
May 12 2021, 3:52 PM
gjb committed R10:a87bab2feb1f: release: fix command to check out ports tree (authored by gjb).
release: fix command to check out ports tree
May 12 2021, 3:52 PM
gjb committed R10:db83952138a9: release: permanently remove the 'reldoc' target and associates (authored by gjb).
release: permanently remove the 'reldoc' target and associates
May 12 2021, 3:52 PM
gjb committed R10:ae0b4bec3af0: release: disable the 'reldoc' target after the ASCIIDoctor switch (authored by gjb).
release: disable the 'reldoc' target after the ASCIIDoctor switch
May 12 2021, 3:51 PM
gjb committed R10:716f5ae59ae7: release: permanently remove the 'reldoc' target and associates (authored by gjb).
release: permanently remove the 'reldoc' target and associates
May 12 2021, 3:51 PM
gjb committed R10:fb6e261c20eb: release: follow-up to previous commit to use Git for the ports tree (authored by gjb).
release: follow-up to previous commit to use Git for the ports tree
May 12 2021, 2:49 PM
gjb committed R10:69b6abb7b2bb: release: remove logic to locate the svn{,lite} binary (authored by gjb).
release: remove logic to locate the svn{,lite} binary
May 12 2021, 2:49 PM
gjb committed R10:3f25cfea5592: release: update release.sh to use Git for ports tree checkouts (authored by gjb).
release: update release.sh to use Git for ports tree checkouts
May 12 2021, 2:49 PM

May 11 2021

gjb added a comment to D29923: arm: add a release conf for distribution files.
In D29923#671549, @gjb wrote:

I think it might be a bit more complicated than this configuration file suggests, but please go ahead and commit it, and we'll work out the edge cases (if any) as they occur.

Indeed, I have not seen any results appear at https://download.freebsd.org/ftp/snapshots/arm/armv7/ so maybe there is something else needed on the release builder side.

May 11 2021, 8:52 PM

Apr 30 2021

gjb committed R10:885d930e8504: UPDATING: dereference portupgrade(8) (authored by gjb).
UPDATING: dereference portupgrade(8)
Apr 30 2021, 4:49 PM
gjb committed R10:e4419043d1dd: UPDATING: dereference portupgrade(8) (authored by gjb).
UPDATING: dereference portupgrade(8)
Apr 30 2021, 4:49 PM

Apr 29 2021

gjb committed R10:aa4eb2089751: pass UNAME_r to fix building 14.x ports on 13.x (authored by gjb).
pass UNAME_r to fix building 14.x ports on 13.x
Apr 29 2021, 3:59 PM
gjb committed R10:fb3ce5331ce3: release: fix VMSIZE following 1ca8842f3ad9 (authored by gjb).
release: fix VMSIZE following 1ca8842f3ad9
Apr 29 2021, 3:58 PM
gjb committed R10:5a3548f2e28a: release: do not set __MAKE_CONF and SRCCONF for the chroot build (authored by gjb).
release: do not set __MAKE_CONF and SRCCONF for the chroot build
Apr 29 2021, 3:58 PM
gjb committed R10:0490d82acef8: release: sync 'git count' logic with newvers.sh (authored by gjb).
release: sync 'git count' logic with newvers.sh
Apr 29 2021, 3:58 PM
gjb committed R10:5950b9cdbba2: release.sh: Skip installing textproc/docproj when NODOC is set (authored by gjb).
release.sh: Skip installing textproc/docproj when NODOC is set
Apr 29 2021, 3:33 PM

Apr 27 2021

gjb committed R9:952889e6af94: 13.0: update the releng page to show releng/13.0 is now owned by so@ (authored by gjb).
13.0: update the releng page to show releng/13.0 is now owned by so@
Apr 27 2021, 4:07 PM
gjb committed R9:1c909733b8ed: 13.0: turn releng/13.0 over to security-officer (authored by gjb).
13.0: turn releng/13.0 over to security-officer
Apr 27 2021, 4:05 PM

Apr 26 2021

gjb committed R9:fc09d63a368b: security: update EN and SA templates for 13.0-RELEASE (authored by gjb).
security: update EN and SA templates for 13.0-RELEASE
Apr 26 2021, 1:14 PM

Apr 22 2021

gjb committed R9:3b0cb15d911b: security: spell '2' correctly (authored by gjb).
security: spell '2' correctly
Apr 22 2021, 8:08 PM
gjb committed R9:63003c8f8961: security: bump version numbers for freebsd-update(8) upgrades (authored by gjb).
security: bump version numbers for freebsd-update(8) upgrades
Apr 22 2021, 7:27 PM
gjb committed R9:32d3b817c3ff: security: bump version numbers (authored by gjb).
security: bump version numbers
Apr 22 2021, 7:27 PM
gjb committed R9:8cc847924e7c: security: add stable/13 and releng/13.0 information (authored by gjb).
security: add stable/13 and releng/13.0 information
Apr 22 2021, 7:27 PM
gjb accepted D29923: arm: add a release conf for distribution files.

I think it might be a bit more complicated than this configuration file suggests, but please go ahead and commit it, and we'll work out the edge cases (if any) as they occur.

Apr 22 2021, 4:27 PM
gjb committed R9:dde11c5ad850: releases: add 13.0-RELEASE to the releasees page (authored by gjb).
releases: add 13.0-RELEASE to the releasees page
Apr 22 2021, 3:24 PM

Apr 13 2021

gjb committed R9:c55c46963394: release: fix URL for 13.0 release VM images (authored by gjb).
release: fix URL for 13.0 release VM images
Apr 13 2021, 8:39 PM
gjb committed R9:3a080a45d613: release: announce 13.0-RELEASE (authored by gjb).
release: announce 13.0-RELEASE
Apr 13 2021, 6:50 PM
gjb committed R9:14349b7ce618: 13.0: add checksums for 13.0-RELEASE (authored by gjb).
13.0: add checksums for 13.0-RELEASE
Apr 13 2021, 6:50 PM
gjb committed R9:b632ecb3fd66: release: bump version numbers (authored by gjb).
release: bump version numbers
Apr 13 2021, 6:50 PM
gjb committed R9:c35cc3fb7876: 13.0: uncomment the installation page (authored by gjb).
13.0: uncomment the installation page
Apr 13 2021, 6:50 PM
gjb committed R11:2cf0be6dd16e: misc/freebsd-release-manifests: add 13.0-RELEASE, rm 13-RC* (authored by gjb).
misc/freebsd-release-manifests: add 13.0-RELEASE, rm 13-RC*
Apr 13 2021, 5:54 PM

Apr 9 2021

gjb accepted D29678: Add arm64 tier 1 to relnotes.

FWIW, it builds fine for me. Please go ahead.

Apr 9 2021, 4:25 PM
gjb committed R10:6dadf78f115c: UPDATING: dereference portupgrade(8) (authored by gjb).
UPDATING: dereference portupgrade(8)
Apr 9 2021, 12:28 AM
gjb committed R9:831e7478ecd5: 13.0: update schedule to reflect RELEASE builds have started (authored by gjb).
13.0: update schedule to reflect RELEASE builds have started
Apr 9 2021, 12:22 AM
gjb committed R10:ea31abc261ff: 13.0: update to RELEASE (authored by gjb).
13.0: update to RELEASE
Apr 9 2021, 12:16 AM
gjb committed R10:5003c6014ca6: 13.0/UPDATING: anticipate 13.0-RELEASE date (authored by gjb).
13.0/UPDATING: anticipate 13.0-RELEASE date
Apr 9 2021, 12:16 AM
gjb committed R10:df7114e92efe: 13.0: set static __FreeBSD_version (authored by gjb).
13.0: set static __FreeBSD_version
Apr 9 2021, 12:15 AM

Apr 8 2021

gjb added inline comments to D29648: relnotes: fix-up some section oddities.
Apr 8 2021, 7:39 PM
gjb added inline comments to D29648: relnotes: fix-up some section oddities.
Apr 8 2021, 7:32 PM
gjb committed R9:86d4fe5d511e: relnotes: document qat(4) driver addition (authored by gjb).
relnotes: document qat(4) driver addition
Apr 8 2021, 6:41 PM
gjb accepted D29648: relnotes: fix-up some section oddities.
Apr 8 2021, 3:50 PM

Apr 6 2021

gjb accepted D29569: Add helper scripts for translations.
Apr 6 2021, 4:21 PM
gjb accepted D29573: books/fdp-primer: Fix outdated information.
Apr 6 2021, 4:20 PM
gjb accepted D29596: Update security advisory template for Git.
Apr 6 2021, 2:40 PM
gjb added a comment to D29596: Update security advisory template for Git.

Works for me.

Apr 6 2021, 1:45 AM

Apr 5 2021

gjb accepted D29596: Update security advisory template for Git.
Apr 5 2021, 10:59 PM
gjb accepted D29582: release: move installworld before installkernel.
Apr 5 2021, 4:42 PM

Apr 3 2021

gjb committed R9:a3ee3d4e7645: where.html: fix download links to 13.x VM images (authored by gjb).
where.html: fix download links to 13.x VM images
Apr 3 2021, 3:37 PM
gjb committed R9:c398d32c9202: Announce 13.0-RC5 (authored by gjb).
Announce 13.0-RC5
Apr 3 2021, 3:37 PM
gjb committed R9:5647b50bfa42: 13.0: RC4 -> RC5 (authored by gjb).
13.0: RC4 -> RC5
Apr 3 2021, 3:37 PM
gjb committed R9:83d907801151: 13.0: prune RC4 CHECKSUM files (authored by gjb).
13.0: prune RC4 CHECKSUM files
Apr 3 2021, 3:37 PM
gjb committed R9:5aeaa004a866: 13.0: add RC5 CHECKSUM files (authored by gjb).
13.0: add RC5 CHECKSUM files
Apr 3 2021, 3:37 PM

Apr 2 2021

gjb committed R9:f5a51ed0bc3c: 13.0: update schedule to reflect RC5 builds have started (authored by gjb).
13.0: update schedule to reflect RC5 builds have started
Apr 2 2021, 12:28 AM
gjb committed R10:f8a134d0ef1d: 13.0: update to RC5 (authored by gjb).
13.0: update to RC5
Apr 2 2021, 12:27 AM

Mar 31 2021

gjb committed R9:037971c6d4f5: 13.0 schedule: fix a rendering nit (authored by gjb).
13.0 schedule: fix a rendering nit
Mar 31 2021, 4:02 PM
gjb committed R9:57d0dca5c543: 13.0: minor fix to RC5 date (authored by gjb).
13.0: minor fix to RC5 date
Mar 31 2021, 3:56 PM
gjb committed R9:6c419cdf05b8: 13.0: add RC5 to the schedule (authored by gjb).
13.0: add RC5 to the schedule
Mar 31 2021, 3:47 PM

Mar 30 2021

gjb accepted D29502: Convert the ports(7) manual page to Git..
Mar 30 2021, 8:57 PM
gjb accepted D29502: Convert the ports(7) manual page to Git..
Mar 30 2021, 8:47 PM
gjb added inline comments to D29502: Convert the ports(7) manual page to Git..
Mar 30 2021, 8:20 PM
gjb accepted D29502: Convert the ports(7) manual page to Git..
Mar 30 2021, 8:08 PM

Mar 29 2021

gjb committed R9:48ab795b80fe: 13.0: prune RC3 checksums (authored by gjb).
13.0: prune RC3 checksums
Mar 29 2021, 10:44 PM
gjb committed R9:92a5552e7275: 13.0: update the URL to the mailing list announcement (authored by gjb).
13.0: update the URL to the mailing list announcement
Mar 29 2021, 10:44 PM
gjb committed R9:af9a628c9ce1: Announce 13.0-RC4 (authored by gjb).
Announce 13.0-RC4
Mar 29 2021, 10:44 PM
gjb committed R9:817c3ea08fc0: 13.0: add RC4 signed checksum files (authored by gjb).
13.0: add RC4 signed checksum files
Mar 29 2021, 10:44 PM
gjb committed R9:15f624fb75cf: 13.0: RC3 -> RC4. (authored by gjb).
13.0: RC3 -> RC4.
Mar 29 2021, 10:44 PM
gjb committed rP569499: MFH: r569498.
MFH: r569498
Mar 29 2021, 7:34 PM
gjb committed rP569498: Add 13.0-RC4 MANIFESTs..
Add 13.0-RC4 MANIFESTs.
Mar 29 2021, 7:33 PM
gjb committed R9:ffac931ccf02: 13.0: update schedule to reflect RC4 builds have started (authored by gjb).
13.0: update schedule to reflect RC4 builds have started
Mar 29 2021, 12:04 AM
gjb committed R10:2e70fcbb1543: 13.0: update to RC4 (authored by gjb).
13.0: update to RC4
Mar 29 2021, 12:03 AM