stop looping if it fails, we'll try again in 100ms..

[cem]

No objection. I'll let someone else stamp it.

[markm]

I don't have a major objection to this, but I'm nervous of the lower-numbered pools being favoured. I'm not formally requesting changes yet, as I could be persuaded that I'm wrong.

sys/dev/random/random_harvestq.c

303

This may result in the lower-numbered pools being favoured, which is undesirable. All pools need an equal chance at this entropy. A fix may be to make i static, and simply increment it mod(npools), with the loop terminating at the point where it wraps.

[freebsd_igalic.co]

the comment says

We don't perform any other verification of an entropy source (i.e., length is allowed to be anywhere from 1 to sizeof(entropy), quality is unchecked, etc)

is there a way we could do that?

not in a live / production system, unless it's via dtrace