Page MenuHomeFreeBSD

stop looping if it fails, we'll try again in 100ms..
Needs ReviewPublic

Authored by jmg on Mar 3 2023, 6:44 PM.
Referenced Files
Unknown Object (File)
Thu, May 11, 2:28 PM
Unknown Object (File)
Fri, May 5, 12:00 PM
Unknown Object (File)
Fri, May 5, 2:54 AM
Unknown Object (File)
Tue, May 2, 7:16 AM
Unknown Object (File)
Apr 10 2023, 8:55 AM
Unknown Object (File)
Mar 21 2023, 5:16 AM
Unknown Object (File)
Mar 21 2023, 5:16 AM
Unknown Object (File)
Mar 18 2023, 7:40 AM


Group Reviewers

Diff Detail

rG FreeBSD src repository
Lint Skipped
Tests Skipped
Build Status
Buildable 50134
Build 47026: arc lint + arc unit

Event Timeline

jmg requested review of this revision.Mar 3 2023, 6:44 PM

No objection. I'll let someone else stamp it.

I don't have a major objection to this, but I'm nervous of the lower-numbered pools being favoured. I'm not formally requesting changes yet, as I could be persuaded that I'm wrong.


This may result in the lower-numbered pools being favoured, which is undesirable. All pools need an equal chance at this entropy. A fix may be to make i static, and simply increment it mod(npools), with the loop terminating at the point where it wraps.

the comment says

We don't perform any other verification of an entropy source (i.e., length is allowed to be anywhere from 1 to sizeof(entropy), quality is unchecked, etc)

is there a way we could do that?

not in a live / production system, unless it's via dtrace