Page MenuHomeFreeBSD

jsihv_gmx.com (Jari Sihvola)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 11 2023, 8:59 PM (32 w, 6 h)

Recent Activity

Jun 21 2024

jsihv_gmx.com added a comment to D45600: Add StarFive JH7110's Ethernet (eqos & mcommphy modifications, a new board specific file).

I investigated the LOR (lock order reversal) issue further by temporarily removing eqos locks entirely. Witness still keeps on talking about eqos lock, so it possibly rightly notices a connection between the eqos driver and callout API linked to its operations. Debugger's lock commands were pretty uninformative but by using printfs I became pretty sure the lock really is located in softclock (callout API) code (while the other lock involved in LOR is in the generic clock code, clk.c).

Jun 21 2024, 7:30 AM

Jun 17 2024

jsihv_gmx.com added a watcher for riscv: jsihv_gmx.com.
Jun 17 2024, 5:41 PM

Jun 16 2024

jsihv_gmx.com updated the diff for D45600: Add StarFive JH7110's Ethernet (eqos & mcommphy modifications, a new board specific file).

Now with the full context and without style corrections for if_eqos.c

Jun 16 2024, 9:43 PM

Jun 15 2024

jsihv_gmx.com requested review of D45600: Add StarFive JH7110's Ethernet (eqos & mcommphy modifications, a new board specific file).
Jun 15 2024, 9:29 PM

Apr 29 2024

jsihv_gmx.com added inline comments to D43037: jh7110_clkgen: Add StarFive JH7110 clock generator driver.
Apr 29 2024, 3:25 PM
jsihv_gmx.com updated the diff for D43037: jh7110_clkgen: Add StarFive JH7110 clock generator driver.

Now the io_assign() function which was used by reset operations is optimized away within the framework of existing driver classes. At this point I don't see a reason to create more classes.

Apr 29 2024, 12:44 PM

Apr 25 2024

jsihv_gmx.com updated the diff for D43037: jh7110_clkgen: Add StarFive JH7110 clock generator driver.

This update fixes smaller issues. The proposal to restructure the reset code by creating a new base class is left for later.

Apr 25 2024, 11:54 AM
jsihv_gmx.com added inline comments to D43037: jh7110_clkgen: Add StarFive JH7110 clock generator driver.
Apr 25 2024, 11:51 AM

Apr 22 2024

jsihv_gmx.com updated the diff for D43037: jh7110_clkgen: Add StarFive JH7110 clock generator driver.

This update includes small changes that were proposed. See comments for the discussion about a new header file and having more static arrays.

Apr 22 2024, 1:02 PM
jsihv_gmx.com added inline comments to D43037: jh7110_clkgen: Add StarFive JH7110 clock generator driver.
Apr 22 2024, 1:01 PM

Mar 9 2024

jsihv_gmx.com updated the diff for D44026: JH7110 MMC driver.

doing it like it should be done

Mar 9 2024, 10:54 PM
jsihv_gmx.com added inline comments to D44026: JH7110 MMC driver.
Mar 9 2024, 10:53 PM

Mar 8 2024

jsihv_gmx.com updated the diff for D43037: jh7110_clkgen: Add StarFive JH7110 clock generator driver.

mhorne's improvements for jh7110_clk_pll.c and files.starfive added
(note: some lines in jh7110_clk_pll.c are over 80 chars)

Mar 8 2024, 11:28 AM

Mar 7 2024

jsihv_gmx.com added inline comments to D44026: JH7110 MMC driver.
Mar 7 2024, 6:35 PM

Mar 1 2024

jsihv_gmx.com updated the diff for D43037: jh7110_clkgen: Add StarFive JH7110 clock generator driver.

This patch update fixes style issues, improves module load scheduling, removes reset timeout polling and UART clk special handling, adds PLL macros. I welcome yet discussion about these issues. I was pretty undecided about reset & UART.

Mar 1 2024, 11:37 AM

Feb 29 2024

jsihv_gmx.com updated the diff for D44026: JH7110 MMC driver.

Fixing obvious style issues

Feb 29 2024, 2:40 PM

Feb 28 2024

jsihv_gmx.com added a comment to D43037: jh7110_clkgen: Add StarFive JH7110 clock generator driver.

Okay, I had still few things to learn about formatting (some things were seen wrongly here because I had relied excessively on using spaces. I will stop that). I agree with almost every formatting related comment and I haven't answered those ones.

Feb 28 2024, 3:55 PM

Feb 22 2024

jsihv_gmx.com added a reviewer for D44026: JH7110 MMC driver: riscv.
Feb 22 2024, 9:12 PM
jsihv_gmx.com requested review of D44026: JH7110 MMC driver.
Feb 22 2024, 8:41 PM
jsihv_gmx.com updated the diff for D43037: jh7110_clkgen: Add StarFive JH7110 clock generator driver.

Restructuring code to the device tree used in Linux, now including separate devices and reset driver's methods.

Feb 22 2024, 7:52 PM
jsihv_gmx.com updated the diff for D43034: jh7110_gpio: Add StarFive JH7110 GPIO controller driver.

Switching to another device tree. Makes no really difference for this file.

Feb 22 2024, 2:53 PM
jsihv_gmx.com abandoned D43036: jh7110_reset: Add StarFive JH7110 reset driver.

When switching to another device tree reset driver will be merged with clockgen driver

Feb 22 2024, 9:36 AM

Jan 31 2024

jsihv_gmx.com planned changes to D43034: jh7110_gpio: Add StarFive JH7110 GPIO controller driver.

This code will be adjusted to support a device tree supplied with U-Boot

Jan 31 2024, 7:33 PM
jsihv_gmx.com planned changes to D43036: jh7110_reset: Add StarFive JH7110 reset driver.

This code will be adjusted to support a device tree supplied with U-Boot (will be probably merged to clkgen code)

Jan 31 2024, 7:33 PM
jsihv_gmx.com planned changes to D43037: jh7110_clkgen: Add StarFive JH7110 clock generator driver.

This code will be adjusted to support a device tree supplied with U-Boot

Jan 31 2024, 7:32 PM

Dec 14 2023

jsihv_gmx.com updated the diff for D43037: jh7110_clkgen: Add StarFive JH7110 clock generator driver.

Fixing style issues

Dec 14 2023, 10:24 PM
jsihv_gmx.com updated the diff for D43036: jh7110_reset: Add StarFive JH7110 reset driver.

Fixing style issues

Dec 14 2023, 10:12 PM
jsihv_gmx.com updated the diff for D43034: jh7110_gpio: Add StarFive JH7110 GPIO controller driver.

I blew up the previous fix. Now fixing the (style) fix.

Dec 14 2023, 9:58 PM
jsihv_gmx.com updated the diff for D43034: jh7110_gpio: Add StarFive JH7110 GPIO controller driver.
  • fixing style issues
Dec 14 2023, 9:30 PM

Dec 13 2023

jsihv_gmx.com requested review of D43037: jh7110_clkgen: Add StarFive JH7110 clock generator driver.
Dec 13 2023, 4:47 PM
jsihv_gmx.com requested review of D43036: jh7110_reset: Add StarFive JH7110 reset driver.
Dec 13 2023, 4:29 PM
jsihv_gmx.com requested review of D43034: jh7110_gpio: Add StarFive JH7110 GPIO controller driver.
Dec 13 2023, 4:14 PM