Page MenuHomeFreeBSD
Differential D44026

JH7110 MMC driver
Needs ReviewPublic
Actions

Authored by mhorne on Feb 22 2024, 8:41 PM.
Tags
None
Referenced Files
F82409016: D44026.id137266.diff
Sun, Apr 28, 7:54 AM
Unknown Object (File)
Fri, Apr 26, 3:36 AM
Unknown Object (File)
Feb 26 2024, 10:27 PM
Subscribers
imp
jrtc27

Details

Reviewers
jsihv_gmx.com
Group Reviewers
riscv

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 57147
Build 54035: arc lint + arc unit

Event Timeline

jsihv_gmx.com created this revision.Feb 22 2024, 8:41 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 22 2024, 8:41 PM
jsihv_gmx.com requested review of this revision.Feb 22 2024, 8:41 PM
jsihv_gmx.com added a reviewer: riscv.Feb 22 2024, 9:12 PM
jsihv_gmx.com updated this revision to Diff 135222.Feb 29 2024, 2:40 PM

Fixing obvious style issues

mhorne added inline comments.Mar 7 2024, 5:22 PM
sys/dev/mmc/host/dwmmc_starfive.c
47

Where does this number come from?

jsihv_gmx.com added inline comments.Mar 7 2024, 6:35 PM
sys/dev/mmc/host/dwmmc_starfive.c
47

It's the actual frequency this clock has in vendor's kernel

jrtc27 added a subscriber: jrtc27.Mar 7 2024, 7:26 PM
jrtc27 added inline comments.
sys/dev/mmc/host/dwmmc_starfive.c
47

Why isn't it using the frequency in the mmc_ios?

jsihv_gmx.com added inline comments.Mar 9 2024, 10:53 PM
sys/dev/mmc/host/dwmmc_starfive.c
47

I had made tests with more complicated algorithms here. At some point merely reading ios->clock caused a crash. Somehow I had eventually dispensed a now obvious looking solution to get the frequency from there.

jsihv_gmx.com updated this revision to Diff 135570.Mar 9 2024, 10:54 PM

doing it like it should be done

mhorne commandeered this revision.Wed, Apr 17, 5:32 PM
mhorne edited reviewers, added: jsihv_gmx.com; removed: mhorne.

Taking this over so I can publish some additions/changes...

mhorne updated this revision to Diff 137266.Wed, Apr 17, 5:33 PM

Add check for generic compatible string exported by current u-boot.

Harbormaster completed remote builds in B57147: Diff 137266.Wed, Apr 17, 5:33 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
mmc/
host/
115 lines
riscv/
conf/
4 lines
starfive/
1 line

Diff 137266

View Options

sys/dev/mmc/host/dwmmc_starfive.c

Loading...
View Options

sys/riscv/conf/std.starfive

Loading...
View Options

sys/riscv/starfive/files.starfive

Loading...