Differential D44026

JH7110 MMC driver
ClosedPublic
Actions

Authored by mhorne on Feb 22 2024, 8:41 PM.

Tags

None

Referenced Files

	F133150977: D44026.diff
	Thu, Oct 23, 10:36 AM

	Unknown Object (File)
	Sun, Oct 19, 6:37 PM

	Unknown Object (File)
	Sun, Oct 19, 5:57 PM

	Unknown Object (File)
	Sun, Oct 19, 5:52 PM

	Unknown Object (File)
	Sun, Oct 19, 3:45 AM

	Unknown Object (File)
	Sat, Oct 18, 10:15 PM

	Unknown Object (File)
	Fri, Oct 17, 11:25 AM

	Unknown Object (File)
	Thu, Oct 16, 6:57 AM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rGc8b472aa4b9d: jh7110: enable MMC driver

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

jsihv_gmx.com created this revision.Feb 22 2024, 8:41 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 22 2024, 8:41 PM

jsihv_gmx.com requested review of this revision.Feb 22 2024, 8:41 PM

jsihv_gmx.com added a reviewer: riscv.Feb 22 2024, 9:12 PM

Fixing obvious style issues

mhorne added inline comments.Mar 7 2024, 5:22 PM

sys/dev/mmc/host/dwmmc_starfive.c
47	Where does this number come from?

jsihv_gmx.com added inline comments.Mar 7 2024, 6:35 PM

sys/dev/mmc/host/dwmmc_starfive.c
47	It's the actual frequency this clock has in vendor's kernel

jrtc27 added a subscriber: jrtc27.Mar 7 2024, 7:26 PM

jrtc27 added inline comments.

sys/dev/mmc/host/dwmmc_starfive.c
47	Why isn't it using the frequency in the mmc_ios?

jsihv_gmx.com added inline comments.Mar 9 2024, 10:53 PM

sys/dev/mmc/host/dwmmc_starfive.c
47	I had made tests with more complicated algorithms here. At some point merely reading ios->clock caused a crash. Somehow I had eventually dispensed a now obvious looking solution to get the frequency from there.

doing it like it should be done

Taking this over so I can publish some additions/changes...

Add check for generic compatible string exported by current u-boot.

Harbormaster completed remote builds in B57147: Diff 137266.Apr 17 2024, 5:33 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 7 2024, 4:05 PM

Closed by commit rGc8b472aa4b9d: jh7110: enable MMC driver (authored by mhorne). · Explain Why

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rGc8b472aa4b9d: jh7110: enable MMC driver.

Revision Contents
Changeset List

Path

Size

sys/

dev/

mmc/

host/

dwmmc_starfive.c

110 lines

Diff 134855

sys/dev/mmc/host/dwmmc_starfive.c

Loading...