ipfw: use typed pointers to access network protocols headers where possible
Needs ReviewPublic
Actions

Authored by glebius on Fri, Sep 4, 11:10 PM.

Details

Reviewers

ae
lytboris_gmail.com

Group Reviewers

network

Summary

The 'void *ulp' is still in action, but where possible prefer a typed
pointer. Get rid of associated pre-processor macros.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 76555
Build 73438: arc lint + arc unit

Event Timeline

glebius created this revision.Fri, Sep 4, 11:10 PM

Herald added subscribers: vegeta_tuxpowered.net, donner, melifaro, imp. · View Herald TranscriptFri, Sep 4, 11:10 PM

Harbormaster completed remote builds in B76555: Diff 185901.Fri, Sep 4, 11:10 PM

glebius requested review of this revision.Fri, Sep 4, 11:10 PM

glebius added a parent revision: D59426: ipfw: refactor macros around m_pullup().

Treat this as a suggestion. IMHO, this is more readable than the old version. If everybody disagrees with me, I'm fine with abandoning this.

The diff may not look great but I like the spelling out of types rather than hiding casts behind macros.

I was going to say I'd start the block under the case and not at the end of the line but it seems the more dominant style indeed is what you chose, so ignore this one.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

ipfw/

ip_fw2.c

225 lines

Diff 185901

View Options

ipfw: use typed pointers to access network protocols headers where possibleNeeds ReviewPublicActions