Differential D58282

iflib: remove the unused TX queue state machine
ClosedPublic
Actions

Authored by netchild on Thu, Jul 16, 11:11 AM.

Tags

None

Referenced Files

	F166462772: D58282.id183100.diff
	Thu, Aug 13, 5:34 PM

	F166445530: D58282.id182076.diff
	Thu, Aug 13, 3:06 PM

	Unknown Object (File)
	Thu, Aug 13, 1:43 PM

	Unknown Object (File)
	Thu, Aug 13, 6:28 AM

	Unknown Object (File)
	Wed, Aug 12, 11:55 PM

	Unknown Object (File)
	Wed, Aug 12, 9:08 PM

	Unknown Object (File)
	Tue, Aug 11, 3:20 AM

	Unknown Object (File)
	Mon, Aug 10, 11:19 PM

View All 44 Files

Subscribers

Details

Reviewers

gallatin
kbowling
markj
erj
shurd

Group Reviewers

Commits

rG5da9bc88936a: iflib: remove the unused TX queue state machine

Summary

The previous commit stopped using ift_qstatus and the IFLIB_QUEUE_*
states for the TX watchdog decision, leaving only dead stores.
Remove the field, the states, and all assignments. The byte the
field frees stays behind as explicit padding. No functional change.

MFC after: 1 month
Assisted-by: Claude Code (Fable 5, Opus 5)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

netchild created this revision.Thu, Jul 16, 11:11 AM

Herald added a reviewer: shurd. · View Herald TranscriptThu, Jul 16, 11:11 AM

Herald added 1 blocking reviewer(s): iflib. · View Herald Transcript

Herald added subscribers: glebius, melifaro, ae, imp. · View Herald Transcript

netchild requested review of this revision.Thu, Jul 16, 11:11 AM

Harbormaster completed remote builds in B74848: Diff 182076.Thu, Jul 16, 11:11 AM

netchild mentioned this in D58266: iflib: restore TX watchdog functionality.Sun, Jul 19, 3:05 PM

markj accepted this revision.Wed, Jul 29, 2:39 PM

Make the padding explicit.

gallatin accepted this revision.Mon, Aug 3, 6:07 PM

This revision is now accepted and ready to land.Mon, Aug 3, 6:07 PM

Closed by commit rG5da9bc88936a: iflib: remove the unused TX queue state machine (authored by netchild). · Explain WhyTue, Aug 4, 5:15 PM

This revision was automatically updated to reflect the committed changes.

netchild added a commit: rG5da9bc88936a: iflib: remove the unused TX queue state machine.

Revision Contents
Changeset List

Path

Size

sys/

net/

21 lines

Diff 183392

sys/net/iflib.c

Loading...