User Details
User Details
- User Since
- Mon, May 25, 4:29 PM (1 d, 14 h)
Yesterday
Yesterday
nick_spun.io added a comment to D57253: qlxge(4): Distribute RSS over num_rx_rings with a modulo.
Same bug assuming the number of queues from iflib will be a power of two, was the only other network driver I found with the same bug
nick_spun.io published D57253: qlxge(4): Distribute RSS over num_rx_rings with a modulo for review.
nick_spun.io added a comment to D57240: aq(4): Fix RSS indirection table OOB write and queue distribution.
The default pattern is to repeat the queues across the RX queues so if there are 4 RSS queues but 8 RX queues you end up with 1 2 3 4 1 2 3 4 but this is actually configurable at runtime for traffic steering and whatnot
Mon, May 25
Mon, May 25
nick_spun.io added a comment to D57240: aq(4): Fix RSS indirection table OOB write and queue distribution.
sys/dev/qlxge/qls_hw.c:1004 also seems to use the incorrect RSS queue pattern - may be worth specifically mentioning that anti-pattern in the iflib man page or in the rss comments somewhere
nick_spun.io added reviewers for D57240: aq(4): Fix RSS indirection table OOB write and queue distribution: adrian, emaste.
nick_spun.io published D57240: aq(4): Fix RSS indirection table OOB write and queue distribution for review.
Think this is in a pretty reasonable state now.