Paths

Table of Contentst

Differential D57253

qlxge(4): Distribute RSS over num_rx_rings with a modulo
Needs ReviewPublic
Actions

Authored by nick_spun.io on Tue, May 26, 5:02 PM.

Tags

Referenced Files

	Unknown Object (File)
	Thu, Jun 11, 3:07 AM

	Unknown Object (File)
	Sat, Jun 6, 1:57 PM

	Unknown Object (File)
	Thu, Jun 4, 11:15 AM

	Unknown Object (File)
	Thu, Jun 4, 11:14 AM

	Unknown Object (File)
	Thu, Jun 4, 10:10 AM

	Unknown Object (File)
	Thu, Jun 4, 12:43 AM

	Unknown Object (File)
	Wed, Jun 3, 8:33 PM

	Unknown Object (File)
	Wed, Jun 3, 7:22 PM

View All 21 Files

Subscribers

Details

Reviewers

Summary

qls_init_rss() built the RSS indirection table with rss_icb->cq_id[i] = (i & (ha->num_rx_rings - 1)); which assumes num_rx_rings is a power of two. When it is not, the AND mask leaves some completion queues with no entries and skews the hash
distribution.

MAX_RX_RINGS is currently hardcoded to 1, so this is latent today, but use a modulo so the table stays correct if the ring count is ever raised to a non-power-of-two value.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 73456
Build 70339: arc lint + arc unit

Event Timeline

nick_spun.io created this revision.Tue, May 26, 5:02 PM

nick_spun.io held this revision as a draft.

Herald added a subscriber: imp. · View Herald TranscriptTue, May 26, 5:02 PM

Harbormaster completed remote builds in B73451: Diff 178638.Tue, May 26, 5:02 PM

nick_spun.io updated this revision to Diff 178642.Tue, May 26, 5:08 PM

This comment was removed by nick_spun.io.

Harbormaster completed remote builds in B73455: Diff 178642.Tue, May 26, 5:08 PM

nick_spun.io edited the summary of this revision. (Show Details)Tue, May 26, 5:10 PM

nick_spun.io added a project: drivers.

nick_spun.io added a reviewer: adrian.Tue, May 26, 5:14 PM

nick_spun.io updated this revision to Diff 178645.Tue, May 26, 5:17 PM

Harbormaster completed remote builds in B73456: Diff 178645.Tue, May 26, 5:18 PM

nick_spun.io published this revision for review.Tue, May 26, 5:21 PM

How's this relate to D57240 ?

Same bug assuming the number of queues from iflib will be a power of two, was the only other network driver I found with the same bug

Revision Contents
Changeset List

Path

Size

sys/

dev/

qlxge/

2 lines

Diff 178645

sys/dev/qlxge/qls_hw.c

Loading...